[00:05] niemeyer: did you get a new one ? [00:05] with the new keyboard ? [00:05] No, still the old one.. but the keys fail every once in a while [00:05] niemeyer: this may be of use, http://www.sadtrombone.com/ [00:06] After spanking them hard enough, they seem to get back in shape [00:06] +1, good advice [00:07] thumper: i have a problem [00:07] thumper: https://bugs.launchpad.net/juju-core/+bug/1298115 [00:07] <_mup_> Bug #1298115: utils/ssh: test failures

[00:07] uses a map to collect up the options when forming the command [00:07] so the results are [00:07] 1. always correct [00:08] 2. random [00:08] this is, IMO a bug in the test [00:08] I can do [00:08] 1. change to test to look for the specific arguments, rather than assert the string is exactly the same [00:08] 2. change the code to not use a map and enforce ordering [00:09] 2. is more work, and feels wrong as thre is no requirement for the order of arguments to be stable [00:09] 1. will probable make the test a bit messier [00:16] thumper: I am now (re 3 hours ago) [00:21] thumper: you still want me to take a look at bug 1297899 , I will add it to my task list for first thing in the morning. [00:21] <_mup_> Bug #1297899: Libvirt machines deployed with MAAS and Precise is only able to successfully boot once

[00:23] wwitzel3: that would be really helpful [00:23] as I don't have vmaas set up [00:23] it could be any one of the moving parts [00:24] davecheney: I'd suggest check with axw when he starts shortly [00:24] davecheney: as he was the author of said test [00:24] sent an email to juju-dev@ -- if anyone can spare some cpu shares it would be most welcome :) [00:24] thumper: yep, np [00:24] whenever convenient [00:24] thumper: right [00:24] * davecheney goes to do something else [00:25] bodie_: yeah, just saw it [00:25] bodie_: we have a team meeting tonight, I'll whack it on the agenda there too :-) [00:27] thanks! hope it's not too verbose, I did my best to chop out the fat [00:27] I'm used to an environment where nothing longer than 5 bullet points gets read [00:27] (where no bullet points have line wrap) [00:28] heh [00:50] bodie_: what is an Action ? [00:56] sinzui: how many cpu's does the landing bot have ? [01:01] davecheney, an Action is a charm-defined um, action, such as snapshot for a MySQL service [01:10] wallyworld: re SupportedArchitectures [01:10] If you can never upload the tools for a different arch, then FindInstanceTools will never be able to find them, right? [01:10] axw: sec, otp [01:10] add-machine ssh:... still relies on FindInstanceTools [01:10] ok [02:02] * thumper is back again [02:09] I'm not sure, I was thinking of it as an API endpoint to run the Command on the client [02:11] I don't understand how hooks are put together yet, I was focused on breaking down the command line syntax just to hopefully add a command we could test out [02:33] wallyworld: raised #1298159, let me know if you've got too much on and I can take it [02:33] <_mup_> Bug #1298159: manual: SupportedArchitecture restricts add-machine to same arch as bootstrap-host

=== Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [03:04] wallyworld: I'm just gonna do it, it's more important than the azure stuff [03:04] (unless you're already doing it) [03:04] axw: ah sorry, i replied and didn't hit enter cause i'm on another call, that woud be great [03:04] sorry about that [03:05] wallyworld: no worries [03:26] axw: thanks for taking a look at the ssh failures [03:26] davecheney: nps === vladk|offline is now known as vladk [07:30] morning all === vladk is now known as vladk|offline [08:00] arosales: hiya, I sent an email about the joyent provider. we're having our weekly meeting in a few hours where we can discuss. let me know if you want input (or you could even tag along on the meeting if you needed to) [08:01] wallyworld: hello [08:01] hi [08:02] I would love to attend the meeting but probably won't be awake enough to attend. [08:02] I'll take a look at your mail. [08:02] ok. meeting starts in 2 hours [08:02] raise any concerns and i'l pass them on [08:05] wallyworld: you work on picking up the joyent provider work is very appreciated [08:05] odd you ran into a quota issue [08:05] np, sorry i haven't had a lot of time this week to start earlier, i've been swamped [08:06] good to hear bootstrap worked though [08:06] arosales: i didn't look closely - it may have been a rate limit exceeded issue [08:06] wallyworld: no worries, I appreciate you picking up this extra task with your already full workload [08:06] wallyworld: you using my account or curtis? [08:06] yours [08:07] ok, I'll see if there are any account settings, but I didn't see any . . . [08:07] np. i've been called to dinner, bbiab [08:08] wallyworld: do you have 2 instances currently running in joyent? [08:15] wallyworld: I'll leave those two running (they do look like juju instances), but if you could destroy so they are not racking up $$$ before you leave that would be great. === vladk|offline is now known as vladk [08:17] vladk, hey [08:17] dimitern: good morning [08:17] vladk, morning [08:18] vladk, how is that card ("Update ec2/openstack/etc provisioners to fail requests with StartInstanceParams.Network set.") going ? [08:18] vladk, would you like to do some pairing on it? [08:19] dimitern: I didn't have much time for it [08:19] Mostly I worked on installing MAAS over VirtualBox [08:19] vladk, did you manage ok? [08:20] I stuck with 'juju bootstrap' for maas, can't understand what ssh key I shoud configure on cluster controller [08:20] vladk, I installed maas on precise with libvirt/kvm [08:20] arosales: i'll destroy [08:20] wallyworld: thanks I didn't want to disrupt any debugging [08:20] I am working on daemon, that converts Wake-On-Lan packets to virtualbox start command [08:20] vladk, so inside the maas web ui there's a preferences page where you can generate an api key and import your ssh keys [08:21] vladk, doesn't vbox support WoL already? [08:21] vladk, that's why I decided to use libvirt - maas has support for controlling kvm vms with virsh directly [08:22] and works quite well [08:22] now i'm installing a new maas on trusty, in order to get vlan support (v1.5 r1961 or later) [08:22] vbox doesn't support WoL, but I write a daemon on Go, that listen vboxnet0 interface and starts VirtualBox images. This daemon is running on VirtualBox host [08:22] vladk, nice! :) [08:23] I know about virsh, but it works only on Linux host, but I am still on MacOS [08:23] vladk, you should get ubuntu ;) [08:25] I have installed ubuntu on macbook, and it surprisingly installed without problems, but I need time to be accustomed to new shortcuts and software. [08:25] yeah, ubuntu works very well on mac books [08:28] About trusty, I failed to install maas on it, I got a lot of error on celeryd, that it could not connect to rabbitmq, so I switched to saucy. [08:29] yeah, but we need maas on trusty which supports vlans [08:29] other versions are too old [08:32] dimitern: we may use saucy for cluster controller and trusty for nodes [08:33] vladk, we need a trusty region controller, the nodes do not matter - the RC is where the web ui and the maas api is (hence vlans support) [08:34] dimitern, vladk: there is a PPA here: https://launchpad.net/~maas-maintainers/+archive/dailybuilds/+packages which has the updated versions of maas (I believe), but I do believe it only has a new-enough MaaS for the vlan work if you use trusty. [08:34] if you don't want quite the bleeding edge there is daily-qa-ok as well [08:34] dimitern: if I select 'Create a new MAAS on this server' during installation, what do I get on that host? region-controller or cluster-controller or both? [08:35] dimitern: actually, https://launchpad.net/~maas-maintainers/+archive/daily-qa-ok [08:35] jam, yeah i talked with bigjools and rvba about that [08:35] bigjools: thanks, I just saw that while poking around [08:35] jam: yeah it would be better for you at the moment [08:36] vladk, you get both [08:36] vladk, to install only one or the other you'll need to install manually maas-region-controller or maas-cluster-controller (maas package includes both) [08:37] jam, well, i'm half-way there with the installation anyway [08:38] vladk, dimitern: you always need both, I would install both of them on the main machine. [08:38] The cluster-controller is about scale-out [08:38] so region is the overarching one, and clusters are groups of machines [08:38] but you'd only have 2 cluster-controllers if you had, say, >1000 machines. [08:42] dimitern, jam: do I need a separate machine for juju? or I can install juju on maas host? [08:42] you need a separate VM for the Juju state server (machine-0) [08:43] MaaS doesn't let you put workloads on the MaaS host. [08:45] jam: Should 'juju state server' be inside or outside of MAAS cluster? [09:04] vladk, when you run juju bootstrap in a maas environment, juju asks maas for a new node (one of the Ready ones), where juju will install the state server [09:05] vladk, so strictly speaking the juju state server is inside the maas cluster (as in on the same network), but not on the cluster machine itself (on one of the enlisted nodes) [09:23] morning all [09:23] voidspace, hiya [09:25] dimitern: o/ [09:36] hello [09:38] wwitzel3: morning [10:00] roll up, roll up, meeting limit approaching fast! [10:00] fwereade, dimitern: ^ [10:01] rogpeppe, cheers [10:01] voidspace: meeting? [10:02] jam, voidspace: meeting time [10:02] waigani: meeting [10:02] thumper: grrr, it keeps trying to log me in with my OTHER google account [10:04] thumper: I looked at bug 1297899 this morning, I can replicate it with 1.17.2, but not with trunk. So I was going to try it with latest stable release to see if the fix can just be recommend the user upgrade. [10:04] <_mup_> Bug #1297899: Libvirt machines deployed with MAAS and Precise is only able to successfully boot once

[10:12] can't connect juju-core-team call: This video call is full [10:13] vladk: yeah, we hit 15 today [10:13] have to get in early :) [10:20] vladk: https://docs.google.com/a/canonical.com/document/d/1eeHzbtyt_4dlKQMof-vRfplMWMrClBx32k6BFI-77MI/edit# is the doc we use each week to bring up stuff to talk as the whole team [10:22] I tried to install MAAS from the latest Trusty daily build and stuck again with MAAS web-UI: [10:22] I have a lot of messages in /var/log/maas/celery-region.log: [10:22] ERROR/MainProcess] consumer: Cannot connect to amqp://maas_workers@10.0.1.198:5672//maas_workers: [Errno 104] Connection reset by peer. [10:22] Does anyone know how to overcome it? [10:23] vladk: you can go to #maas and speak with rvba or allenap there [10:23] they are usually quite helpful [10:23] they lurk here too, but topic wise it makes more sense to ask there. [10:25] vladk: Looks like the rabbitmq server is down/not working. Can you have a look at the logs? [10:29] rvba: rabbitmq is running, but probably not properly initialized, I don't see any vhosts and users on it [10:29] vladk: That's not right, you should see a maas user at least. That's all created when the package gets installed. [10:30] rvba: I see maas user in Linux (although without /home/maas directory), but I don't see maas user in rabbitmqctl [10:33] rvba: the first mention of maas in rabbit@core.log is: "AMQPLAIN login refused: user 'maas_longpoll' - invalid credentials" [10:33] hum… [10:34] Same problem, the 'maas_longpoll' hasn't been created. [10:35] found in /var/log/installer/syslog: in-target: Creating user "maas_longpoll" ... [10:35] in-target: Error: unable to connect to node rabbit@core: nodedown [10:36] Interesting, looks like rabbitmq was down when the MAAS package was being installed. [10:36] alexisb: ^ [10:36] alexisb: err, sorry [10:36] allenap: ^ [10:37] Ah, that would explain it. [10:37] Could it be a race during installation? Rabbit’s not started by the time MAAS tries to create the user? [10:39] rvba, alexisb, allenap: part of /var/log/installation/syslog: http://pastebin.ubuntu.com/7162005/ [10:47] vladk: Is policy-rc.d something you’ve installed? [10:50] allenap: I do the installation of MAAS on VirtualBox. Nothing special. I have a description here: https://docs.google.com/a/canonical.com/document/d/1oK80_jjPAD2BCwhNcFv9v_szkG1CE2AHy05BMjQfIeY/edit?usp=sharing [10:51] allenap: I don't have any problems with Saucy, but with Trusty this is persistent issue [10:57] axw: perhaps we could have a chat after this meeting about HA stuff, if you have a little time? [10:57] vladk: Doing an install on canonistack now… you've installed 1.5+bzr2153+2177+253~ppa0~ubuntu14.04.1 correct? [10:57] rogpeppe: bad time, sorry - need to get dinner on and so on [10:57] rogpeppe: maybe later on [10:57] vladk: Essentially policy-rc.d seems to be blocking the correct operation of maas-region-controller’s postinst. [10:58] axw: sure [10:58] axw: let us know when might be a good time [10:58] I will come back a bit later if I can [10:58] vladk: Unfortunately, the postinst explicitly ignores failure when trying to restart rabbitmq-server. [10:58] rogpeppe: coffee and stuff - but my branch is nearly ready for review [10:59] voidspace: lovely stuff [10:59] rvba: I take the latest trusty-server iso image from ubuntu site, my full installation/syslog: http://pastebin.ubuntu.com/7162080/ [10:59] rogpeppe: one more test (for the auto creating of the document - which as you suspected did fix the issue) [10:59] voidspace: grand [10:59] allenap: ^ [10:59] rogpeppe: so I'll write the test and then wang the branch up for review [10:59] natefinch: I'm about half way through the review of your EnsureMongoServer patch [10:59] voidspace: i'll grab some breakfast, then join the standup hangout [10:59] rogpeppe: cool, see you there in a few minutes [11:00] vladk: okay, you're installing the trusty package from the main archive. [11:00] jam1: good, we're still cleamimg it up a bit, but generally should be reviewable. there's still a few failing tests. [11:05] vladk: this part doesn't look good. We're not 100% sure but we think it's what's causing the failure http://paste.ubuntu.com/7162104/ [11:08] so... do I reboot for a proper shell, or keep working audio... I should really work out what the sound issue under ubuntu is [11:09] rvba, allenap: so the question should be redirected to ubuntu installer team? [11:10] vladk: the server team can probably help you with that indeed. Let me just finish my test first (I'm installing the same package on a canonistack instance). [11:11] bbl [11:16] vladk: it's taking forever… canonistack is so slow these days. [11:18] wallyworld: have you pushed your joyent branch up to launchpad? [11:18] mgz: not yet, give me a minute [11:19] ta [11:19] wwitzel3: do you have instructions for local maas? [11:19] natefinch: ish .. yes [11:20] natefinch: I can walk you through and shore up the docunentation for it while we do it, that will help [11:20] natefinch: I've done it so many times now it doesn't take very long [11:20] vladk: Possibly. The policy-rc.d stuff seems to be preventing maas-region-controller from installing properly, but because it’s explicit ignoring failures when restarting rabbit, and because it’s shell which invites poor error handling, it proceeds regardless, and it’s only discovered later. We could say that maas-region-controller conflicts with [11:20] whatever’s providing policy-rc.d, or we could work with policy-rc.d to enable whatever maas has to do. [11:21] vladk: I’m not familiar with policy-rc.d so I can’t say which is the best option. [11:21] wwitzel3: yeah, cool. can you put them in a google doc? easiest way to share and edit stuff. [11:21] vladk: I’ll talk to roaksoax when he’s available; he knows a lot more about how maas is packaged than I do. [11:22] mgz: lp:~wallyworld/juju-core/joyent-provider-instance wip, tests don't pass, won't compile without changes pushed also to github/joyent/gocommon and github/joyent/gosign [11:22] natefinch: yep, what I most have documented is specific to VirtualBox but I switch recently to libvirt so I could take advantage of the virsh power stuff [11:22] natefinch: which is what I don't have documented [11:23] wwitzel3: is libvert better? I've never used it [11:23] wallyworld: thanks, the gojoyent library split was one of the things I was concerned about with the landing [11:24] mgz: so i'll have to write tests for the libs and do git hub pull requests. even though tests don't pass, the code did bootstrap a real instance [11:24] natefinch: well MAAS has native support for it as a power type, so that makes it better, less hand waving to get a VM to boot at the right time. [11:26] natefinch, vladk, wwitzel3, here's my step by step notes for installing maas on libvirt locally: http://paste.ubuntu.com/7162174/ [11:28] dimitern: step 0 needs some work ;) [11:29] natefinch, yeah :) so you need https://help.ubuntu.com/community/KVM/Installation [11:32] dimitern, natefinch: yeah, those instructions for libvirt are exactly what I did [11:33] wwitzel3, dimitern: nice [11:33] dimitern, natefinch: only step I did you don't mention is I added an internal domain "my.maas" and added the maas controller to my list of nameservers in resolvconf [11:34] dimitern: you trick is to not install MAAS directly from installer [11:34] gotta go help w/ kids, I'll be back in an hour or so [11:34] dimitern: oh and I added an upstream dns server [11:35] dimitern: oh, I can just downloaded a trusty ISO and installed maas, I didn't do the install/apt-get/upgrade steps [11:36] dimitern: so slightly different starting steps, but it all works the same :) [11:38] wallyworld: short-term workaround for your github pull issue [11:39] wallyworld: you can always just update dependencies.tsv to point to github branches in your own namespace [11:39] mgz: that's not a bad idea [11:39] that lets you land the branch, now, without blocking [11:39] mgz: i need to get a bunch of tests passing though and write new onces [11:40] I suggest this, as the alternative is I land the older branch... which depends on lp:gojoyent, which then gets pulled out again when you land the further changes [11:40] which would be somewhat annoying for everyone [11:40] mgz: since i'm now storing the joyent private key in env config [11:40] wwitzel3, yeah, I couldn't find trusty iso offhand [11:40] mgz: if we re going ti github, may as well link to those versions of the libs [11:41] (and generates conflicts, most likely) [11:43] rogpeppe: you don't appear to be in either hangout (neither juju-core nor juju-core-team) [11:44] voidspace: weird, i'm sitting in *a* hangout :-) [11:44] hah [11:44] good old google+ [11:44] what's the name (from the url)? [11:44] I can try again [11:44] voidspace: https://plus.google.com/hangouts/_/calendar/Y2Fub25pY2FsLmNvbV9pYTY3ZTFhN2hqbTFlNnMzcjJsaWQ5bmhzNEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t.mf0d8r5pfb44m16v9b2n5i29ig?authuser=1 [11:51] rogpeppe: the orb, banco de gaia [11:52] rogpeppe: look for "little fluffy clouds" [11:53] rogpeppe: Adventures Beyond the Ultraworld [11:54] rogpeppe: Flaming Lips, Yoshimi Battles the Pink Robots [11:54] are we saying real things? [11:54] rogpeppe: Jonathan Coulton [11:54] rogpeppe: look for the mandelbrot song [11:54] rogpeppe: garfunkel and oates - pregnant women are smug === marcoceppi is now known as marco_traveling [11:56] rogpeppe: The Streets "Original Pirate Material" [12:17] voidspace: TestOpenCreatesStateServersDoc [12:34] https://codereview.appspot.com/81440043 [12:34] simple review for someone [12:34] rogpeppe: ^ [12:38] voidspace: LGTM, but perhaps dimitern or fwereade or jam1 might want to take a look [12:39] rogpeppe: I've pushed the additional comment you suggested [12:39] voidspace: ta [12:40] rogpeppe: don't think I can do a hangout tonight, but I will be around IRC for a while [12:40] voidspace: what is Key in this context (other than the contents of Keyfile) ? [12:40] (if that's useful...) [12:40] axw: that's fine [12:40] Private Key for the Certificate? [12:40] voidspace, why not use environ global key to set the stateserverinfo ? [12:40] Maybe PrivateKey is a clearer spelling? [12:40] jam1: it is the same Key as stateServerKey from configInternal [12:40] jam1: sgtm [12:40] voidspace, once we have multiple environments it will become a problem [12:41] dimitern: there are other docs in the same collection [12:41] rogpeppe, what other docs? [12:41] jam1: do we have more than one key in the context of state serving? [12:41] dimitern: stateserverinfo and apihostports [12:41] voidspace: rogpeppe: Since this *is* exposed in the API, and we don't want to change APIs when they are public, can we just expose KeyFile, or possible call in MongoKey ? [12:41] Rather than a comment about wanting it in the future? [12:42] rogpeppe, so shouldn't the state server info be linked to the environment? [12:42] jam1: sure, that's reasonable [12:42] I guess it isn't in API just yet [12:42] rogpeppe: jam1: do we have that information easily available at the point we want to use it/ [12:42] dimitern: every single other collection has a problem if we're going to store multiple environments [12:42] rogpeppe: jam1: it wasn't accessible on the config structs passed round when bootstrapping happens [12:42] dimitern: using environGlobalKey doesn't help [12:42] morning all [12:42] Given lines like this: + err := st.stateServers.Find(bson.D{{"_id", stateServingInfoKey}}).One(&info) [12:42] bodie_: hiya [12:43] we probably want to be careful what we call a "Key"d [12:43] jam1: the API will come very soon [12:43] since stateServingInfoKey is a index entry? [12:43] aka, nothing like the public/private key strings [12:43] jam1: rogpeppe: I'm happy to change Key to PrivateKey [12:43] yeah, PrivateKey sgtm [12:44] dimitern: we *could* potentially have a separate collection for every singleton document, but that seems like it's unnecessary work [12:44] rogpeppe, just sayin'.. [12:45] dimitern: currently every document in every collection is implicitly linked to the environment [12:46] rogpeppe, except for these which are linked to an environment [12:46] rogpeppe: given that it is just the value "e" [12:46] rogpeppe, annotations, constraints, settings [12:46] dimitern: ^^ [12:46] ./state/environ.go:16:const environGlobalKey = "e" [12:46] jam1, I know, but it can be different in the future [12:46] jam1, e#uuid [12:47] dimitern: well, we'd certainly have to restructure things and make it attributes of a State object, rather than global consts/vars [12:48] jam1, +1 on that [12:48] rogpeppe: voidspace: So I happen to not like our current pattern of creating yet-another-collection whenever we have 1 doc worth of stuff to write, but it is the pattern so far. [12:49] jam1: bikeshedding on name for "KeyFile" - rogpeppe is suggesting "SharedSecret" [12:49] fwereade: re proxy-ssh, what do you mean by "can we instead just refuse it and error out" in the local provider code? [12:49] voidspace: I'd probably still want to put Mongo in there [12:49] to distinguish what we're sharing the secret about [12:49] or at least, DBSharedSecret [12:50] jam1: well, all this info is for running mongo [12:50] jam1: i guess we could put Mongo in front of every field [12:50] rogpeppe: technically APIPort isn't [12:50] jam1: good point. [12:50] DBSharedSecret sounds good [12:50] mongo should be an implementation detail [12:50] voidspace: I think rog has a point that most of it is about the DB already [12:51] ok, so back to SharedSecret [12:51] Cert happens to be used both ways, right? [12:51] jam1: i think just SharedSecret should be ok [12:51] it is the Mongo TLS Cert and the API TLS Cert [12:51] jam1: it doesn't actually matter that much how it's used [12:51] jam1: yes [12:51] jam1: the Mongo KeyFile is just a shared password, really [12:52] natefinch: yeah, hence my SharedSecret suggestion [12:52] naming things is the *perfect* topic for bike shedding :-) [12:52] voidspace: https://codereview.appspot.com/81440043/ [12:52] reviewd [12:52] rogpeppe: yeah that seems fine if we want to avoid referencing mongo [12:52] voidspace: naming is one of the 3 unsolved problems, right? [12:52] cool, I'm just running tests before pushing the name change [12:52] jam1: hah right [12:52] the 2 hard problems in computer science [12:52] cache invalidation? [12:52] cache invalidation, off by one errors and naming things [12:53] 4 things\: naming, cache invalidation and off by one errors [12:53] There are 10 types of people in the world [12:53] cmars, are bug 1290824 and bug 1290828 fix committed? [12:53] Those who understand binary, those who don't and those who were expecting a joke about trinary [12:53] <_mup_> Bug #1290824: juju should ask the charm store to decide the default series for a charm [12:53] <_mup_> Bug #1290828: charm-store should be able to map "foo" into "cs:precise/foo" [12:53] I love nerd jokes [12:54] btw, appreciate seeing good responses to my email. thanks all [12:54] My favourite nerd joke, not computer related [12:54] Heisenberg is driving along the freeway and happens to be speeding [12:54] heheh [12:54] A traffic cop spots him and flags him down [12:54] The cop walks up to the car and gets Heisenberg to wind down the windo [12:54] *window [12:54] "Do you know how fast you were going?" the cop asks [12:55] "No" replies Heisenberg, "but I know exactly where I am" [12:56] I like the one about one Newton per square meter [12:56] that's funny [12:56] and my delivery is terrible, but I suspected the audience would already know the content... [12:56] possibly not, it was new to me a few days ago [12:56] why use a copy when a reference will do? [12:57] :) [12:57] I like the "infitinte mathmeticians walk into a bar. The first one asks for half a pint, the second for a quarter, the third for an eighth and so on" [12:57] The barman pours a pint and tells them to sort it out amongst themselves... [12:58] And on that note, coffee... [12:59] lol [13:02] a pint of coffee [13:03] davecheney, I don't know about the landing bot. CI's unit tests are run with 2cpu machines except for arm64 which has 4 [13:04] axw, that's in Prepare, right? I'd just like to check that nobody sets a bad value without being warned -- I'd be fine with overwriting it if we output that we;re doing so [13:05] fwereade: ok [13:05] fwereade: I would normally, I just didn't in this case because there's no reason for a user setting it in the first place [13:05] but I can do that [13:06] fwereade: is there a better way to do this? feels slightly awkward putting it in the config [13:06] fwereade: especially if it means going to the API for config ... [13:06] axw, I felt awkward about that too [13:06] just didn't want to do the dreaded env.Type() == "local" [13:06] axw, but it *is* I think config, it can reasonably vary for different environments even against the same provider at times [13:07] axw, +100 to avoiding that, yeah [13:07] what is the difference between _test.go and _whitebox_test.go ? [13:08] perrito666, the _whitebox_ ones are in-package [13:08] perrito666, ie `package foo` not `package foo_test` [13:09] perrito666, they don't get compiled into proper builds because their names end in _test.go [13:09] perrito666, but they get all sorts ofinadvisable access to packageinternals [13:09] perrito666: _whitebox isn't a Go thing, it's just a visual indicator for us. _test.go is the magic that makes them only compiled during go test [13:10] natefinch, perrito666: I suspect there may be a couple named _internal_test.go [13:10] fwereade, perrito666 : I've only seen _whitebox in a few places... it's something I'd rather avoid, since it seems to just add visual noise. I don't think it really matters that much if tests are internal or not [13:11] fwereade: I much prefer internal tests anyway, because you can make the tests a lot more focused, so when something breaks, it's more obvious where the breaks are, rather than having to trace through reams and reams of code [13:12] natefinch, well, it's inevitably testing the implementation not the interface, to some degree at least, and is therefore a bit nasty and makes things harder to change [13:12] natefinch, so I'd prefer tests in general to be in a different package to the code [13:13] natefinch, but if they have to be, I also rather agree it's not *that* big a deal if a few internal tests really help [13:14] natefinch, I'm not sure the _whitebox_ bit is that justifiable but it's quite nice to have them flagged a bit more obviously [13:14] the eye tends to slide right over foo vs foo_test [13:15] whitebox tests just lead you down a path of pain and heartache, that said, in a pinch, it sure is nice having access to all those internals ;) [13:15] fwereade: I'm the opposite. testing the implementation is the only thing you're ever testing. and tests with smaller scope are easier to fix when implementations change. rather than monstrous system tests that blow up with weird errors. [13:16] natefinch, the answer there is smaller packages imo [13:16]