=== maclin_ is now known as maclin | ||
pitti | jtaylor: yes, it is; but jenkins doesn't export it as an artifact unfortunately, we need to fix that in the job config | 05:24 |
---|---|---|
jibel | Good morning | 06:57 |
DanChapman | good morning | 08:01 |
smox | Hi, I have an old bugreport which is not fixed correctly because I can't test the newer versions of ModemManager. Now trusty will be shipped with ModemManager 1.* and the issue effects trusty too. Now my questions, should I report this issue in a testing-tracker? When yes, which (link) ? Should I "reject" this bug to the ModemManager Team and when yes, how? | 08:26 |
smox | Here is the Link: https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1198283 I hope my english is good enough that everbody can understand me. | 08:27 |
ubot5 | Ubuntu bug 1198283 in modemmanager (Ubuntu) "Huawei E3276 will not recognized correctly" [Undecided,Confirmed] | 08:27 |
=== chihchun_afk is now known as chihchun | ||
=== chihchun is now known as chihchun_afk | ||
=== chihchun_afk is now known as chihchun | ||
=== chihchun is now known as chihchun_afk | ||
=== psivaa is now known as psivaa-lunch | ||
popey | elopio: (or someone else) do we have any AP experts who can help with https://bugs.launchpad.net/music-app/+bug/1300450 ? ahayzen (music app dev) has taken a look, but is stuck, and it's blocking us being able to get music updated in the store.. | 12:45 |
ubot5 | Ubuntu bug 1300450 in Ubuntu Music App "Autopilot failing on mako #269 Object not found with name '*' and properties {'objectName': 'playshape'}." [Undecided,New] | 12:45 |
=== _salem is now known as salem_ | ||
=== fader is now known as fader_ | ||
=== fader_ is now known as fader | ||
=== psivaa-lunch is now known as psivaa | ||
pitti | jibel: the rmtree issue you pinged me about yesterday (or this morning?), is that bug 1300474 ? | 14:40 |
ubot5 | bug 1300474 in apport (Ubuntu) "tmp directory cleanup fails" [Undecided,New] https://launchpad.net/bugs/1300474 | 14:40 |
jibel | pitti, yes, it is the same issue. It is because the exit handler is called twice | 14:45 |
pitti | jibel: ack, thanks; fixing now | 14:45 |
elopio | alesage: about https://code.launchpad.net/~allanlesage/unity8/autopilot-indicator-page-title-matches-widget/+merge/196991 | 16:31 |
elopio | did you agree with my suggestions from yesterday, or would you like to merge it as it is now? | 16:31 |
elopio | popey: oh, sorry, I missed your ping | 16:32 |
elopio | I'll take a look in some minutes. | 16:32 |
popey | elopio: np, i asked robotfuel to take a look, dunno if he has had a chance yet | 16:32 |
alesage | elopio if you don't mind I'd like to proceed now, and then I'll file a bug for the suggestion you made | 16:32 |
robotfuel | popey: elopio I just started looking in to it. | 16:33 |
elopio | robotfuel: ok, thanks. | 16:33 |
elopio | alesage: ok. I'm taking a last look. I don't get this: | 16:34 |
elopio | 181+ self.wait_select_single('Indicators', fullyOpened=True) | 16:34 |
elopio | why on the close indicator method you are waiting for it to be fully opened? | 16:34 |
alesage | elopio egads you're right | 16:34 |
alesage | elopio, one minute to fix pls | 16:35 |
elopio | alesage: oh, the thing is that you are never calling close indicator. | 16:35 |
elopio | I would remove that method. Code that's not used nor tested can become a headache. | 16:36 |
alesage | elopio you make a good point, removing | 16:37 |
alesage | elopio, pushed that, thanks :/ | 16:38 |
elopio | alesage: last detail while you are there, please turn get_indicator_widget and get_indicator_page into _get_indicator_widget and _get_indicator_page | 16:39 |
elopio | so nobody outside of unity is tempted to use them. | 16:39 |
elopio | I'll approve the branch. | 16:40 |
alesage | elopio just verifying by running again thx | 16:41 |
alesage | elopio, pushed that again thanks again | 16:47 |
elopio | alesage: one last, sorry | 16:57 |
elopio | 137+from autopilot.input._common import get_center_point | 16:57 |
alesage | yessir | 16:57 |
elopio | you can do from autopilot import input. And then input.get_center_point() | 16:57 |
elopio | no need to import _common. | 16:57 |
=== bfiller is now known as bfiller_afk | ||
alesage | elopio, done | 16:59 |
elopio | alesage: ok, approved. Now you need to do this to get a review from the unity team | 17:00 |
elopio | https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8 | 17:00 |
elopio | I'll do the review checklist. | 17:01 |
alesage | ok elopio thanks, I may need some coaching here :) | 17:02 |
elopio | alesage: I'm looking at your other branch for the visual ordering. | 17:05 |
elopio | with the new scopes branch they changed the behaviour and I didn't notice. | 17:05 |
elopio | instead of returning autopilot elements, this method should return a list of the names of the apps. | 17:05 |
alesage | elopio, o hmm, doesn't that revert an earlier change to returning the autopilot elements? | 17:07 |
=== roadmr is now known as roadmr_afk | ||
elopio | alesage: I'm not sure I'm getting your question. | 17:08 |
alesage | elopio, I noticed that in order to get this code working I had to shift from using names to using autopilot objects, is it true that they've reversed this change? | 17:09 |
alesage | elopio, I'm surprised because I liked the 'returning autopilot objects' decision | 17:09 |
elopio | alesage: if we follow the page object pattern, we should never return a UI element that the user can't see. | 17:10 |
elopio | when the user is looking at the UI, what he sees are icons and application names. That's the only thing we should return. | 17:10 |
alesage | elopio that's fair, although the 'tile' would be a kind of object for the user--maybe the idea would be just to hide all of the autopilot guts from them | 17:11 |
elopio | alesage: that's precisely the idea. | 17:11 |
elopio | the name of the test is test_get_applications_should_return_list_with_names | 17:12 |
elopio | and they change it to return a list of autopilot proxy objects :( | 17:12 |
alesage | doorbell brb | 17:12 |
alesage | elopio ok hmm, well I'll adapt my test--do you know if that reversion is released? | 17:14 |
elopio | alesage: no, I'm making a branch to revert that. It's a small one. | 17:14 |
elopio | give me a couple of minutes. | 17:14 |
alesage | elopio ok no hurry, I'll wait for your ping | 17:15 |
elopio | alesage: https://code.launchpad.net/~elopio/unity8/revert_get_applications/+merge/213693 | 17:22 |
alesage | elopio, I wonder if this has effects elsewhere | 17:24 |
elopio | alesage: just in the unity-click-scope tests. | 17:24 |
elopio | without my branch, they are broken. | 17:24 |
elopio | I need to put them on CI as soon as possible, so they can't get broken anymore. | 17:25 |
alesage | elopio, ok weird, ok I'll test in a bit, must do an errand, then my branch will depend on this | 17:26 |
elopio | alesage: yes, please add this as a prerequisite for yours. | 17:26 |
alesage | elopio, ok more news a bit later | 17:27 |
elopio | I'm going to leave in about two hours. So I might not have a chance to check it before tomorrow. | 17:27 |
=== maclin__ is now known as maclin | ||
knome | somebody feels like working on a generic wiki page for r/zsync instructions for bug 1004558? | 17:54 |
ubot5 | bug 1004558 in Ubuntu QA Website "In download links, link to instructions on using r/zsync" [Wishlist,Triaged] https://launchpad.net/bugs/1004558 | 17:54 |
=== bfiller_afk is now known as bfiller | ||
=== roadmr_afk is now known as roadmr | ||
Letozaf_ | balloons, hello | 19:16 |
elfy | knome: I can do that | 19:22 |
elfy | though I might wait till september so it's two years old :) | 19:24 |
knome | elfy, hah | 20:00 |
balloons | Letozaf_, howdy | 20:06 |
Letozaf_ | balloons, I checked again the rssreader app error I had, and it's still there even if I branched rsssreader-app from trunk and put my tests back in, I commented the merge proposal | 20:08 |
balloons | Letozaf_, you should push your code up :-) | 20:11 |
Letozaf_ | balloons, If I push from the new branched reminders-app with my tests in I get a diverged branch error, so should I push on a new mp ? | 20:18 |
balloons | Letozaf_, ohh really? you can supersede your mp if needed, so the comments stay in there | 20:18 |
Letozaf_ | balloons, oh! how do you do that ? | 20:19 |
balloons | https://code.launchpad.net/~carla-sella/ubuntu-rssreader-app/tests-refactoring/+merge/213335/+resubmit | 20:19 |
balloons | Letozaf_, when you do it, change the source branch to your new branch :-) | 20:19 |
Letozaf_ | balloons, ok let me try, thanks | 20:19 |
Letozaf_ | balloons, lp:~carla-sella/ubuntu-rssreader-app/test-view-mode | 20:23 |
balloons | Letozaf_, cool, yep looks good | 20:26 |
Letozaf_ | balloons, :P not really the test fails | 20:27 |
balloons | running now | 20:34 |
balloons | Letozaf_, do you always get the tab index error? | 20:38 |
Letozaf_ | balloons, yes when I run that test on my desktop, never tried on device | 20:39 |
balloons | Letozaf_, I see it only on the one test | 20:39 |
balloons | shorts_app.tests.test_rssreader.TestMainWindow.test_remove_feed_and_topic | 20:39 |
balloons | so I would reckon we should have a look at the test | 20:39 |
Letozaf_ | balloons, no I get it only on this test: test_view_mode the others run fine | 20:40 |
Letozaf_ | balloons, I mean if I run the other tests they do not fail, only the test_view_mode does and with the tab index error | 20:41 |
balloons | Letozaf_, right.. I can confirm | 20:41 |
balloons | so let's look at it quickly | 20:41 |
Letozaf_ | balloons, ok | 20:41 |
balloons | fails on and_topic | 20:41 |
balloons | <balloons> so I would reckon we sh | 20:41 |
balloons | shortsListModePage = self.main_view.get_tab_ListModePage() | 20:42 |
Letozaf_ | balloons, yep | 20:42 |
balloons | hmmm | 20:43 |
balloons | get_current_tab() is an emulator bit | 20:44 |
robotfuel | popey: I can't get the music-app to run in the emulator, I don't have an n4 to debug further. | 20:44 |
Letozaf_ | balloons, yes | 20:44 |
balloons | elopio, you about? | 20:44 |
popey | robotfuel: oh ☹ | 20:44 |
popey | balloons: if you have time, are you able to help robotfuel ? | 20:45 |
popey | trying to get this music AP problem fixed | 20:45 |
balloons | the one I can't reproduce? | 20:45 |
balloons | I have a few moments sure | 20:45 |
popey | well, its changed now | 20:45 |
popey | andrew posted a patch which fixes one thing but now it fails differently | 20:45 |
balloons | ok, how can I help? | 20:46 |
balloons | Letozaf_, I'm playing around with working around the issue in the emulator | 20:46 |
Letozaf_ | balloons, ok | 20:46 |
balloons | I think we should file a bug about it, and change the test if needed | 20:46 |
popey | balloons: https://bugs.launchpad.net/music-app/+bug/1300450 is the bug | 20:46 |
ubot5 | Ubuntu bug 1300450 in Ubuntu Music App "Autopilot failing on mako #269 Object not found with name '*' and properties {'objectName': 'playshape'}." [Undecided,New] | 20:46 |
balloons | otherwise your tweaks work, and we should land them when the bug you reported is fixed | 20:47 |
balloons | as right now, jenkins fails everything | 20:47 |
balloons | popey, oO! right! did you hear back from Andrew on that? | 20:47 |
popey | yeah, small patch, but it still fails, differently | 20:47 |
balloons | he wasn't supposed to implement it that way | 20:47 |
balloons | as in, there is a bug veebers has been working on to land support for properly selecting his custom object | 20:48 |
balloons | how did this pass in jenkins I wonder? | 20:48 |
balloons | Letozaf_, for your sanity. http://paste.ubuntu.com/7191549/ | 20:52 |
balloons | Now, this is bad because it assumes the current Page is the first object returned. | 20:52 |
balloons | But it's proof you can just use the parent to make the select work. Can you specify the tab any better? | 20:53 |
Letozaf_ | balloons, haven't tried if you want I will try to see if I can find a way | 20:54 |
balloons | Letozaf_, that will help you to land it if needed | 20:54 |
balloons | anyways, everything else looks good. | 20:54 |
balloons | Letozaf_, can you file a bug against the emulator for the issue though? Mention the branch and the test, so Leo can recreate the issue | 20:55 |
balloons | Letozaf_, https://bugs.launchpad.net/ubuntu-ui-toolkit/+filebug | 20:55 |
balloons | just mention it's the autopilot sdk helper | 20:55 |
Letozaf_ | balloons, ok was just doing that (reporting the bug) | 20:56 |
balloons | popey, so looking at the report quickly it seems like Victor is thinking it's a timing issue | 20:56 |
balloons | that is inline with the error being reported | 20:56 |
balloons | I'll pull trunk and confirm/deny | 20:57 |
popey | balloons: its possible | 20:57 |
Letozaf_ | balloons, fyi bug 1301012 | 21:00 |
ubot5 | bug 1301012 in Ubuntu UI Toolkit "Getting current tab using Ubuntu Ui Toolkit fails" [Undecided,New] https://launchpad.net/bugs/1301012 | 21:00 |
balloons | Letozaf_, perfect. | 21:01 |
Letozaf_ | balloons, I am going to bed now I will try to fix the tests with a workaround tomorrow | 21:01 |
balloons | Letozaf_, I think you can hold on the workaround | 21:01 |
balloons | Letozaf_, until trunk for rssreader builds a proper deb package it can't land :-) | 21:02 |
Letozaf_ | balloons, ok so I will wait for the bug to be fixed | 21:02 |
balloons | Letozaf_, and elopio should have a look | 21:02 |
balloons | Letozaf_, but if he can't fix, then yes certainly workaround it and land it | 21:02 |
Letozaf_ | balloons, ok | 21:02 |
Letozaf_ | balloons, buona notte | 21:03 |
balloons | Letozaf_, buona notte! | 21:03 |
balloons | popey, it's interesting to note this test is very very similar to the play_pause_now_playing test | 21:10 |
balloons | popey, I fixed it | 21:14 |
popey | ♥ | 21:15 |
popey | you can have a vacation now ☻ | 21:18 |
balloons | popey, left an mp and comments.. cheers | 21:24 |
popey | ok | 21:25 |
=== salem_ is now known as _salem | ||
=== popey_ is now known as popey | ||
knome | hey balloons | 22:00 |
balloons | hey knome | 22:02 |
knome | you might be interested in some bugs... | 22:02 |
knome | bug 1300576 | 22:02 |
ubot5 | bug 1300576 in Ubuntu QA Website "Tooltip text appears on top of the bug link" [Medium,Fix committed] https://launchpad.net/bugs/1300576 | 22:02 |
knome | bug 1035503 | 22:02 |
ubot5 | bug 1035503 in Ubuntu QA Website "Bug description yellow boxes exceed browser window dimensions." [Low,Fix committed] https://launchpad.net/bugs/1035503 | 22:02 |
knome | O:) | 22:02 |
=== slickyma2ter is now known as slickymaster | ||
balloons | knome, you fixed the yellow box bug?! | 22:22 |
balloons | <3! | 22:22 |
knome | haha, yep... | 22:22 |
knome | two of those | 22:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!