| Makyo | jujugui PR on loading relation indicator images https://github.com/juju/juju-gui/pull/218 (testing CI, too, tests fail on Air, can fix on ubuntu if they fail CI) | 02:02 |
|---|---|---|
| Makyo | s/tests fail/console tests fail | 02:02 |
| Makyo | No luck, will check in the AM | 03:32 |
| === rogpeppe3 is now known as rogpeppe | ||
| rick_h_ | frankban: morning | 11:12 |
| frankban | hi rick_h_ | 11:12 |
| rick_h_ | frankban: heads up, I talked to wallyworld last night and he says he's tested the joyent provider in trunk (and it's backported to the 1.18 tree) so hopefully that'll work | 11:13 |
| rick_h_ | frankban: and thanks for replying to his email on the megawatcher updates. Can you create cards in the backlog for us to update where we watch for those ip address changes? | 11:13 |
| frankban | rick_h_: yes I'll do. https://165.225.150.74/ is the GUI deployed on joyent \o/ | 11:14 |
| frankban | rick_h_: there is still bug #1300846 which affects the quickstart implementation. I'll check if it gets fixed for 1.18 | 11:15 |
| _mup_ | Bug #1300846: Juju crashes bootstrapping joyent <bootstrap> <joyent-provider> <juju-core:In Progress by jameinel> <juju-core 1.18:In Progress by jameinel> <https://launchpad.net/bugs/1300846> | 11:15 |
| * frankban lunches | 11:15 | |
| rick_h_ | frankban: awesome, I just saw a branch from him around the provider and wallyworld admitted it needed a "couple of tweaks to be perfect" | 11:16 |
| rick_h_ | so not https://codereview.appspot.com/83540043/ | 11:17 |
| rick_h_ | sorry, so looks like it's in progress and should land somewhere soon hopefully | 11:17 |
| rick_h_ | frankban: very cool to have another provider working woot thanks for keeping up on that. | 11:17 |
| * rick_h_ runs to take the boy to day care back in a few | 11:18 | |
| === rogpeppe2 is now known as rogpeppe | ||
| rick_h_ | back | 11:45 |
| frankban | Makyo: mroning, do you have time today for reviewing https://github.com/juju/juju-gui/pull/215 ? thanks | 12:30 |
| frankban | morning even | 12:30 |
| rick_h_ | frankban: think he's still a couple hours away | 12:32 |
| rick_h_ | frankban: I'll be relocating shortly when the cleaners get here but can start going through it if you need a second review | 12:32 |
| frankban | rick_h_: there is no rush, it was more like a message from the past, thank you | 12:34 |
| rick_h_ | lol echo echo | 12:34 |
| frankban | :-) rick_h_: I created the two cards in backlog/deck | 12:37 |
| rick_h_ | frankban: thank you much | 12:37 |
| frankban | rick_h_: thanks for the review. re comments: good suggestion | 12:54 |
| rick_h_ | frankban: thanks for the update :) | 13:10 |
| hatch | morning | 13:44 |
| rick_h_ | morn | 13:44 |
| rick_h_ | hatch__: https://plus.google.com/hangouts/_/canonical.com/go-over when you get a sec | 14:00 |
| kadams54 | Are there any Handlebars helpers in the codebase to handle displaying ModelLists (or even ArrayLists)? | 14:24 |
| hatch__ | rick_h_ thanks for the review - ugly I know *hangs head* | 14:25 |
| hatch__ | it'll get better! | 14:25 |
| hatch__ | kadams54 negative, it's always been to specific | 14:25 |
| hatch__ | domain specific* | 14:25 |
| kadams54 | Like {{#each}} but using object.each() to iterate rather than a for loop | 14:25 |
| rick_h_ | hatch__: yea, just want to make sure we know things are broken and note them to make sure we get them all fixed | 14:25 |
| hatch__ | kadams54 we usually convert it to an array/object then use the native handlebar helpers for looping | 14:26 |
| === hatch__ is now known as hatch | ||
| rick_h_ | kadams54: yea, often we have, in the view, a prepForTemplate() or something | 14:26 |
| rick_h_ | kadams54: that builds a handlebars friendly data structure | 14:26 |
| kadams54 | Hmm. Would be nice if ArrayList had a function to spit out a plain list | 14:26 |
| rick_h_ | kadams54: well you can map based on Y.Array.each | 14:28 |
| rick_h_ | kadams54: but yea | 14:28 |
| rick_h_ | kadams54: http://yuilibrary.com/yui/docs/api/classes/Array.html maybe? I don't recall | 14:28 |
| hatch | kadams54 typeof myArrayList._items === 'array' | 14:29 |
| kadams54 | Yeah, but accessing private members es no bueno. | 14:29 |
| rick_h_ | yea, frowed upon. It'll be a smallish list | 14:29 |
| rick_h_ | you're safe looping it out into a new strcuture | 14:29 |
| rick_h_ | kadams54: as you'll probably want to turn the models into objects and such anyway | 14:29 |
| rick_h_ | tweak things in process | 14:30 |
| kadams54 | Thinking about similar situations in python where there's usually a method on the iterator to have it spit out a list object | 14:30 |
| hatch | the _items property will -never- change, it's a YUI convention | 14:30 |
| rick_h_ | kadams54: yea, I'd just add a prepForTemplate() handler | 14:30 |
| hatch | it's ok to access it | 14:30 |
| hatch | I promise :) | 14:30 |
| kadams54 | rick_h_: will do | 14:30 |
| hatch | grep _items in our codebase you'll se we use it already | 14:31 |
| bac | jujugui: charmworld review please https://codereview.appspot.com/83620043 | 14:33 |
| rick_h_ | kadams54: http://yuilibrary.com/yui/docs/api/files/app_js_model-list.js.html#l888 | 14:33 |
| kadams54 | Nice | 14:34 |
| rick_h_ | http://yuilibrary.com/yui/docs/api/classes/ModelList.html#method_toArray for the prettier view | 14:34 |
| rick_h_ | bac: can look in a bit | 14:34 |
| bac | rick_h_: thanks | 14:35 |
| * rick_h_ heads back to the house from the coffee shop | 14:38 | |
| rick_h_ | jujugui call in 10 please kanban | 14:50 |
| rick_h_ | hatch: looking at your commment | 14:52 |
| rick_h_ | hatch: the code reads that this.environmentHeader is gone | 14:52 |
| rick_h_ | hatch: replaced by var header | 14:52 |
| rick_h_ | oh, it's added back in line 57 | 14:52 |
| rick_h_ | hatch: any reason for the change/indirection? | 14:53 |
| hatch | minification | 14:53 |
| hatch | :) | 14:53 |
| rick_h_ | jujugui call in 1 | 15:00 |
| jcastro | rick_h_, hey what's the tldr on showing colocated services in the gui? | 15:01 |
| jcastro | I feel like for 14.04 we should have a owncloud all-in-one bundle | 15:01 |
| rick_h_ | jcastro: http://comingsoon.jujucharms.com/:flags:/il/mv/ in progress see you in vegas | 15:02 |
| jcastro | whoa! that looks nice! | 15:02 |
| frankban | rick_h_: one thing we missed: the 1.18 change which no longer includes the unit public address in the mega-watcher breaks quickstart :-/ | 15:27 |
| rick_h_ | frankban: ok, well that'll have to be the reason to force an upload update for quickstart | 15:28 |
| frankban | rick_h_: quickstart uses the watcher to retrieve the GUI address | 15:28 |
| frankban | rick_h_: also, without the change to the MachineInfo I mentioned in the email, there is no way currently for quickstart to get the unit address when using the local env | 15:29 |
| frankban | rick_h_: so 1) make the change in core and 2) update quickstart | 15:29 |
| frankban | rick_h_: 2) is tricky because we will need to support both new and old behavior | 15:29 |
| frankban | rick_h_: I suspect we should escalate those bugs | 15:30 |
| rick_h_ | frankban: +1 | 15:30 |
| frankban | rick_h_: and the core fix should be included in 1.18, otherwise we have a limbo in which there is no way to get containers' addresses for API clients | 15:32 |
| frankban | rick_h_: what's the timing for 1.18? | 15:32 |
| rick_h_ | frankban: it's moved so much I'm not even sure any more | 15:32 |
| frankban | heh | 15:32 |
| rick_h_ | frankban: let's talk to sinzui and get that marked as a blocker for 1.18 | 15:32 |
| rick_h_ | and then we can get that going asap | 15:33 |
| frankban | +1 | 15:33 |
| hatch | Makyo just ran it again and it still failed locally | 15:55 |
| hatch | I'm baffled | 15:55 |
| rick_h_ | hatch: bisect? does it work on older code? | 15:55 |
| rick_h_ | go back a week and make clean-all | 15:56 |
| rick_h_ | there could be a real bug, better to catch it now while bisect path is short | 15:56 |
| hatch | yeah going on that now | 15:56 |
| hatch | I had a conflict i had to resolve | 15:56 |
| rick_h_ | other thing is a fresh checkout and see if there's something else that's off | 15:57 |
| hatch | I ran into a very odd chrome bug debugging those routes yesterday - it would cache the previous url even though the path didn't have /inspector for example | 15:58 |
| hatch | the solution was to open a new tab | 15:58 |
| hatch | nananananananana bisect man bisect man | 16:01 |
| hatch | hmm nope even old versions are broken | 16:06 |
| hatch | new repo time | 16:06 |
| hatch | wow our git repository is getting large | 16:10 |
| hatch | 90MB or so | 16:10 |
| rick_h_ | sorry bac getting back to your review | 16:13 |
| rick_h_ | everyone seems to think today is monday and wants to break stuff :) | 16:13 |
| hatch | haha | 16:14 |
| hatch | even a new fresh checkout doesn't fix it :/ | 16:14 |
| hatch | wth | 16:14 |
| rick_h_ | hatch: then your machine is broken, time to buy a new one :P | 16:14 |
| hatch | mine AND Makyo's? | 16:15 |
| hatch | c'mon! | 16:15 |
| Makyo | Hahaha | 16:15 |
| Makyo | hatch, you working in vagrant? | 16:15 |
| hatch | yeah | 16:15 |
| Makyo | That's the common factor, I think. | 16:15 |
| hatch | yeah but what changed? It worked two days ago | 16:15 |
| Makyo | d3 upgrade involved regenerating npm-shrinkwrap, maybe that? | 16:16 |
| hatch | ohh | 16:16 |
| hatch | lemme check out before that | 16:16 |
| Makyo | It should still snag the same version - none of the versions changed - but maybe something's going on with that. | 16:16 |
| hatch | ok trying a pre-D3 branch | 16:17 |
| hatch | maybe we need to update to the latest phantom binary | 16:17 |
| hatch | anywho I'll keep you posted | 16:18 |
| Makyo | hatch, you'll have to make clean clean-all etc. Sorry. I'll do the same to check it out. | 16:18 |
| hatch | yep it's npming now | 16:19 |
| hatch | ugh I long for the day there is an npm rollup | 16:19 |
| hatch | Makyo nope still crashed | 16:20 |
| hatch | :/ | 16:20 |
| hatch | ExceptionHandler::GenerateDump waitpid failed:No child processes | 16:20 |
| Makyo | Boo! | 16:20 |
| Makyo | Yep, same thing here. | 16:20 |
| Makyo | What would it take to get test-debug/prod to run locally? | 16:21 |
| hatch | it does? | 16:22 |
| Makyo | I haven't tried yet, I've been getting that in the vagrant. | 16:23 |
| hatch | what do you mean to run locally? | 16:23 |
| Makyo | In osx term | 16:23 |
| hatch | ohh it can't the way we are running it | 16:24 |
| Makyo | Okay. Hmm. | 16:24 |
| Makyo | Wonder if it's a saucy thing. Let me see what happens if I go back to Raring. | 16:24 |
| hatch | https://github.com/juju/juju-gui/blob/develop/test-server.sh | 16:24 |
| rick_h_ | frankban: sorry, one more call. Just talked with james/robie | 16:27 |
| frankban | rick_h_: same url? | 16:27 |
| rick_h_ | frankban: https://plus.google.com/hangouts/_/7ecpjnf6uun25l4dh5sus8edhg?hl=en | 16:27 |
| hatch | Makyo I'm updating phantom and mocha-phantom | 16:29 |
| * hatch crosses fingers | 16:29 | |
| Makyo | hatch, okay. I'm ducking back to Raring real quick, will compare notes. | 16:29 |
| Makyo | jujugui need qa on https://github.com/juju/juju-gui/pull/218 real quick. Fast one. | 16:31 |
| rick_h_ | frankban: http://paste.ubuntu.com/7194939/ is the other package they've got that is a lot like this | 16:31 |
| hatch | ugh I just wish I could run Ubuntu on metal | 16:32 |
| hatch | someone fix the kernel | 16:32 |
| rick_h_ | frankban: they make --no-adjust-repos the default in the distro package | 16:32 |
| hatch | Makyo new versions didn't help... | 16:33 |
| hatch | although now it's just crashing without any error | 16:33 |
| frankban | rick_h_: sound good, so --distro-only and --ppa? | 16:33 |
| Makyo | hatch, improvement! | 16:33 |
| Makyo | Well, okay. Not really. | 16:33 |
| hatch | lol | 16:33 |
| rick_h_ | frankban: sounds good to me | 16:33 |
| hatch | I wonder if we are runnign too many tests and it's overloading something | 16:34 |
| hatch | too much domness or something | 16:34 |
| hatch | there are 1040 issues.... | 16:34 |
| hatch | yikes | 16:34 |
| Makyo | Yeah. Curious if it's an NFS problem. | 16:34 |
| Makyo | Will check raring, almost done provisioning. | 16:34 |
| hatch | cool - wasn't there a reason why we upgraded though? | 16:34 |
| frankban | rick_h_: cool, both == --ppa, none == --ppa | 16:35 |
| Makyo | Don't believe it worked for bac? Something. | 16:35 |
| Makyo | hatch, if the downgrade works, though, we can rule out NFS. | 16:35 |
| hatch | yeah it's just very odd that it just happened | 16:36 |
| rick_h_ | frankban: sounds good to me | 16:36 |
| Makyo | and keep nfs on raring, maybe trusty | 16:36 |
| Makyo | YEah. | 16:36 |
| hatch | with no changes... | 16:36 |
| Makyo | hatch, other than added tests, like you said. | 16:36 |
| hatch | yeah but rolling back to an old version didn't make it pass | 16:36 |
| rick_h_ | hatch: when you rolled back you make clean-all? | 16:36 |
| hatch | you bet | 16:36 |
| rick_h_ | hatch: so that you got the old node/d3 deps? | 16:36 |
| rick_h_ | cool, just checking | 16:36 |
| hatch | I even tried a fresh new repo | 16:37 |
| hatch | https://github.com/ariya/phantomjs/issues/11706 | 16:38 |
| hatch | ^ hmm | 16:38 |
| Makyo | hatch, I juist think it might be a system dependency, not a node dependency. | 16:39 |
| Makyo | Oh, hmm. | 16:40 |
| hatch | works now? | 16:40 |
| Makyo | Oh, no, you're GH issue | 16:40 |
| hatch | ahh yeah... | 16:41 |
| Makyo | hatch, try modifying the phantomjs command to output more? --debug=true I think | 16:42 |
| hatch | hmm not according to it's docs | 16:44 |
| hatch | but I can try | 16:44 |
| hatch | oh --setting debug=true | 16:45 |
| hatch | ok trying that | 16:45 |
| Makyo | hatch, okay, sorry. Was going off the global install on my linux box. | 16:46 |
| hatch | well because we use mocha-phantomjs to run the tests | 16:46 |
| Makyo | Oh, right, hah. | 16:48 |
| hatch | still no output | 16:48 |
| hatch | ugh | 16:48 |
| Makyo | Gah | 16:48 |
| hatch | rick_h_ I don't think this is a valid route /inspector/apache2/service | 16:54 |
| hatch | /inspector/apache2 would show the details by default | 16:55 |
| hatch | and /inspector/apache2#tabName would show the appropriate tab | 16:55 |
| hatch | unless 'service details' means something else? | 16:55 |
| hatch | oh s/service/charm | 16:56 |
| hatch | makes sense | 16:56 |
| rick_h_ | hatch: rgr | 17:04 |
| rick_h_ | hatch: oh wait, so that was the url to have service details shown from the inspector | 17:04 |
| rick_h_ | so /inspector/apache2 is inspector | 17:04 |
| rick_h_ | and /service on it means details of that service popout | 17:04 |
| rick_h_ | hatch: welcome suggestions | 17:04 |
| hatch | isn't that the charm details? what are the service details? | 17:05 |
| rick_h_ | hatch: from the inspector you click the link and the details pops out to the left | 17:05 |
| rick_h_ | that's not quite charm details, it's different data? | 17:05 |
| hatch | I was pretty sure it was the exact same thing | 17:05 |
| rick_h_ | well the data comes froma different place | 17:05 |
| rick_h_ | service data vs browser model data | 17:06 |
| rick_h_ | tabs are different etc | 17:06 |
| hatch | hmm | 17:06 |
| hatch | lemme mull it over | 17:06 |
| rick_h_ | k | 17:06 |
| hatch | but ok I understand now | 17:06 |
| hatch | thx | 17:06 |
| Makyo | hatch, charm version differences are taken into account there. | 17:10 |
| Makyo | Store will always show you the latest version. | 17:10 |
| hatch | yeah right but to me /inspector/apache2/charm means the charm details for that service | 17:11 |
| Makyo | Oh, sorry. Don't have the doc in front of me. | 17:12 |
| hatch | where /inspector/apache2/service doesn't really say anything about the service, it's talking about the charm | 17:12 |
| Makyo | Trying to debug CI failure. | 17:12 |
| hatch | I'm mulling....I'm mulling! | 17:12 |
| Makyo | Mmm, mulled wine | 17:12 |
| rick_h_ | hatch: it's the information in the service. It's readme/etc | 17:13 |
| rick_h_ | hatch: it's more of a comparison to charm details (browser) service details (/service) unit details (/unit/4) | 17:14 |
| rick_h_ | those are the 3 versions/distinctions | 17:14 |
| hatch | I just think that /inspector/apache2 IS the service and we are showing the charm details used to create that service | 17:17 |
| Makyo | hatch, on a more interesting note, tests work in raring. | 17:18 |
| Makyo | s/interesting/positive | 17:18 |
| Makyo | Didn't mean to imply, sorry. | 17:18 |
| hatch | hmm so everything works on raring? | 17:18 |
| Makyo | That was test-debug, let me do test-prod | 17:19 |
| rick_h_ | hatch: we've just got to port what already exists. Something has to say "this inspector is open on X" and something else needs to say "inspector is open on this with the details open" | 17:19 |
| hatch | yep for sure | 17:20 |
| hatch | arm the charm details don't have any url | 17:20 |
| hatch | it just minimizes the sidebar | 17:20 |
| hatch | just fyi | 17:20 |
| rick_h_ | huh? | 17:20 |
| rick_h_ | /precise/mysql-10 is a charm details url. | 17:21 |
| rick_h_ | plus /sidebar/precise/mysql-10, and /sidebar/search/precise/mysql-10?text=mysql | 17:21 |
| hatch | not when you click it from the inspector | 17:21 |
| hatch | it minimizes the browser and opens the left panel | 17:21 |
| hatch | without a url change | 17:21 |
| rick_h_ | right, that's what we do now | 17:21 |
| rick_h_ | which is why we're inventing a new url | 17:21 |
| rick_h_ | there's not space to show the sidebar + inspeector + details. In the new world we'll show inspector + details | 17:22 |
| hatch | right | 17:22 |
| rick_h_ | hatch: so what's the issue/argument point here? | 17:22 |
| rick_h_ | you don't like the word service and prefer the word charm? | 17:22 |
| bac | hey rick_h_, regarding an XXX bug for removing the deprecated field, we could do that, but it is kind of out of our hands. i don't see it happening before the death of charmworld. | 17:22 |
| rick_h_ | bac: k, nvm then | 17:23 |
| hatch | rick_h_ yeah - /service seems weird | 17:23 |
| rick_h_ | hatch: ok, then happy to entertain a better word | 17:24 |
| rick_h_ | details was ditched because there's two types of details off the inspector. I didn't pick charm because things would get called charmDetails and such and it's an overloaded term already. | 17:26 |
| rick_h_ | you're right that technically the inspector is the details of the service | 17:26 |
| rick_h_ | so service isn't great either | 17:26 |
| hatch | yeah....hmm | 17:27 |
| hatch__ | hmm apparently freenode didn't like it either lol | 17:31 |
| === hatch__ is now known as hatch | ||
| Makyo | hatch, test-prod fails with the same error :( | 17:38 |
| hatch | ugh | 17:38 |
| hatch | what in the heck is going on | 17:38 |
| Makyo | No clue :( | 17:40 |
| Makyo | Will keep poking. | 17:40 |
| Makyo | Meanwhile, think I figured out CI problems, created discussion card for what I found. | 17:40 |
| hatch | ugh devops issues infuriate me | 17:42 |
| Makyo | Also meanwhile, if chiptunes are your thing, the ChipWIN April Fools album is actually pretty good, despite being mostly jokes. http://chiptuneswin.com/album/chiptunes-srsbsns | 17:42 |
| hatch | I've tried to do the chiptune thing | 17:43 |
| hatch | can't quite get into it | 17:43 |
| Makyo | Haha, that's fair :) | 17:44 |
| Makyo | Took me a bit to get past the fact that it's not mixed down to the wall-of-sound that we've come to expect from music these days. Motown popularized that years ago, and it's just gotten more and more extreme since. | 17:45 |
| * Makyo rambles. | 17:47 | |
| Makyo | AGH I hate not having .lbox.check | 17:49 |
| Makyo | Sorry for the spam. | 17:49 |
| rick_h_ | Makyo: a pre-commit or pre-push hook added to the docs would be cool :) | 17:50 |
| Makyo | rick_h_, Alright, will investigate over lunch! | 17:53 |
| hatch | yeah pre-push hook would be awesome | 17:56 |
| hatch | although also somewhat irritating | 17:56 |
| hatch | because you could never push incomplete code | 17:56 |
| hatch | heh | 17:56 |
| hatch | git pushncheck | 17:57 |
| hatch | :) | 17:57 |
| hatch | so it's an alias maybe | 17:57 |
| Makyo | hatch, there's apparently a --no-verify option | 17:57 |
| hatch | oh interesting | 17:57 |
| Makyo | At least, to pre-commit hooks, reading up on pre-push | 17:57 |
| hatch | ohhhh rick_h_ you changed our 1:1 ok lunching now | 17:58 |
| hatch | :) | 17:58 |
| hatch | bbiab | 17:58 |
| rick_h_ | hatch: changed it? /me thought it was always here. | 17:58 |
| rick_h_ | hatch: oh, this is the time change in effect maybe? | 17:58 |
| rick_h_ | it's still 2pm for me | 17:58 |
| hatch | oh it says it was just changed | 17:59 |
| hatch | odd...ok whichever I thought it was right now | 17:59 |
| hatch | I'm hungry anyways | 17:59 |
| hatch | :D | 17:59 |
| rick_h_ | it is right now | 17:59 |
| rick_h_ | I'm in there, huh? | 17:59 |
| hatch | weird | 17:59 |
| hatch | ok joining | 17:59 |
| frankban | rick_h_: I have to go, I have a possible prototype to fix the issue, see http://pastebin.ubuntu.com/7195287/ (lp:~frankban/juju-core/machine-addresses). There might be still something to fix, you can take a look at the discussion in #juju-dev. Please feel free to email me if you get additional info. I'll check tomorrow morning if I can do something. Have a nice evening! | 18:27 |
| rick_h_ | frankban: thanks so much, have fun! | 18:28 |
| Makyo | Got an email of someone trying to recruit me through a dating app. Unfortunately, the recruitment company has debug mode on, and so now I have their DB server password. Classy. | 19:18 |
| Makyo | Wonder if it's some ridiculous CTF. | 19:19 |
| rick_h_ | lmao | 19:22 |
| Makyo | Looks like it made it to HN, now their cache is failing. | 19:25 |
| Makyo | Aaaand now it's just blank. That was fast. | 19:26 |
| hatch | Makyo what were they recruiting you for?... | 19:28 |
| hatch | :P | 19:28 |
| Makyo | Never did find out. Their redirect thing is what threw the debug error. | 19:28 |
| Makyo | It was a click-tracking thing on the recruiter's site. | 19:29 |
| hatch | ohh haha | 19:29 |
| hatch | the other day I was recruited for a mechanical engineering position | 19:29 |
| hatch | I think they read the 'software engineer' and was like....."close enough" | 19:30 |
| hatch | lol | 19:30 |
| rick_h_ | kadams54: hey, meant to stab you and let you know today is you QA day | 19:38 |
| rick_h_ | and welcome back to the interwebs :) | 19:39 |
| kadams54 | Yeah, I realized that around 1 today :-) | 19:39 |
| rick_h_ | I'll need the pokey stick back for bac tomorrow | 19:39 |
| bac | rick_h_: er? | 19:40 |
| hatch | lol | 19:40 |
| hatch | stabby stabby | 19:40 |
| bac | oh, to do QA? | 19:40 |
| bac | yeah, good luck with that | 19:40 |
| rick_h_ | bac: friday chat was that we want to bring back the QA day. I'll use a pokey stick to help remind folks | 19:40 |
| bac | i *always* forget | 19:40 |
| bac | ok, i'll try to remember | 19:41 |
| rick_h_ | thus the pokey stick, I've got to remember before EOD tomorrow unlike today | 19:41 |
| kadams54 | So… what's the best way to do this QA? | 19:41 |
| kadams54 | comingsoon.jujucharms.com? | 19:42 |
| rick_h_ | kadams54: works for me | 19:42 |
| kadams54 | Production? | 19:42 |
| rick_h_ | or do a live environemtn | 19:42 |
| rick_h_ | test out your lxc or ec2 setup | 19:42 |
| kadams54 | Oh yeah | 19:42 |
| kadams54 | I was going to get EC2 setup | 19:42 |
| rick_h_ | the goal is to test all kinds of things, whateer your fancy is and try to find a bug | 19:42 |
| hatch | yeah - do odd interactions too | 19:42 |
| rick_h_ | try your non default browser of choice, non default env of choice | 19:42 |
| rick_h_ | preted you think like hatch | 19:42 |
| rick_h_ | pretend | 19:42 |
| hatch | lol | 19:43 |
| hatch | enter my mind..... | 19:43 |
| rick_h_ | break outside the mold a bit and try to make sure things still work as expected | 19:43 |
| hatch | kadams54 my mind http://upload.wikimedia.org/wikipedia/en/thumb/a/a3/Escher's_Relativity.jpg/300px-Escher's_Relativity.jpg | 19:43 |
| kadams54 | :-) | 19:44 |
| rick_h_ | hatch: that pic doesn't have enough promises in it :P | 19:45 |
| hatch | lol | 19:45 |
| Makyo | kadams54, actually, if you're doing QA stuff, think you could do a quick check on my PR? | 19:46 |
| kadams54 | Sure | 19:46 |
| Makyo | 218 | 19:46 |
| Makyo | https://github.com/juju/juju-gui/pull/218 | 19:46 |
| Makyo | Sorry | 19:46 |
| kadams54 | Question: how intelligent should bundles be? That is, if I deploy the hadoop:cluster bundle and then attempt to deploy mediawiki:single after, is it fair to expect the mysql service in mediawiki to be renamed? | 19:48 |
| hatch | kadams54 nope | 19:48 |
| hatch | it'll fail | 19:48 |
| hatch | there will be a bundle configuration step at some point | 19:48 |
| kadams54 | Yeah, I know it fails | 19:49 |
| kadams54 | That just seems sorta unfair to me as the user though :-) | 19:49 |
| kadams54 | Especially in complex environments | 19:49 |
| rick_h_ | kadams54: because you might want to share that service | 19:50 |
| rick_h_ | so let's say you have a beefy mysql server | 19:50 |
| rick_h_ | and want to share it across wordpress and mediawiki bundles | 19:51 |
| rick_h_ | kadams54: so it's a valid question, but we don't have the abliity to handle it right now | 19:51 |
| rick_h_ | so we error | 19:51 |
| kadams54 | Except you can't deploy the bundle | 19:51 |
| kadams54 | Yeah | 19:51 |
| rick_h_ | right, and you can't from the cli | 19:51 |
| kadams54 | OK | 19:51 |
| kadams54 | If the CLI can't do it :-) | 19:51 |
| rick_h_ | if you've got scripts that rely on that service name (juju log mysql/0) | 19:51 |
| rick_h_ | it'll break if you rename it automatically | 19:51 |
| rick_h_ | renaming is a bad thing in some cases | 19:51 |
| kadams54 | Not the existing service | 19:52 |
| kadams54 | The new service | 19:52 |
| rick_h_ | well a bundle is a repeatable deployment | 19:52 |
| rick_h_ | so in one cloud it's named X and Y in another? | 19:52 |
| rick_h_ | if you've got benchmark tools to automate testing you can't use it now | 19:52 |
| kadams54 | You just need to use a deterministic renaming algo | 19:53 |
| rick_h_ | it's all imaginary for sure | 19:53 |
| kadams54 | mysql-1 in both clouds | 19:53 |
| kadams54 | bam | 19:53 |
| rick_h_ | well then you're fine if you call it that in your bundle | 19:53 |
| rick_h_ | just don't use the default service names in your bundle and you're fine :) | 19:53 |
| kadams54 | Now you sound like a Java guy | 19:53 |
| rick_h_ | railsmysql, railsapp, railsmemcache :) | 19:53 |
| kadams54 | "Explicitly configure everything and you'll be fine!" | 19:54 |
| rick_h_ | just playing devils advocate | 19:54 |
| kadams54 | ;-) | 19:54 |
| rick_h_ | it's something we'll deal with as bundes mature I think | 19:54 |
| hatch | stacks ahoy! | 19:54 |
| rick_h_ | crazy to think they're still young little things. | 19:54 |
| rick_h_ | this is the first ubuntu release with them in there | 19:54 |
| kadams54 | Someday they'll grow up and leave the nest *sniff* | 19:54 |
| hatch | and we'll be ecstatic to have an empty house | 19:56 |
| === BradCrittenden is now known as bac | ||
| Makyo | jujugui docs change, but would appreciate someone checking my work: https://github.com/juju/juju-gui/pull/220 | 20:11 |
| hatch | rick_h_ routeDefault calls a jujucharms() view who actually only renders 'hello world' to the dom....was this supposed to be removed some time ago? | 20:11 |
| hatch | the XXX is from jcsackett July 2013 | 20:12 |
| rick_h_ | hatch: yea, there's a bug for it still I think | 20:12 |
| hatch | hmm | 20:12 |
| jcsackett | hatch: that was a long time ago, i think it was when we had a demo mode on top of the fullscreen mode etc etc. | 20:12 |
| jcsackett | hatch: given even fullscreen is dead (right?) you can rip out any of that stuff you find. | 20:12 |
| rick_h_ | bah, thought there was one | 20:12 |
| hatch | yeah I vaguely remember something about that | 20:13 |
| hatch | jcsackett yep it's gone | 20:13 |
| rick_h_ | now I can't find, I'll have to look later sorry | 20:13 |
| hatch | ok np I'll remove it | 20:13 |
| hatch | if you find the bug plz assing to me | 20:13 |
| hatch | assign even | 20:13 |
| rick_h_ | ok, I'm out all. Have a good night! | 20:15 |
| hatch | enjoy | 20:15 |
| hatch | Makyo looking at your branch | 20:17 |
| hatch | Makyo review done | 20:24 |
| hatch | sorry I kind of tore it apart...but in a good way :D | 20:24 |
| kadams54 | ALso just finished review on 218 | 20:24 |
| Makyo | hatch, re: the NO_VERIFY env var: this is specific to pre-push. Pre-commit uses the --no-verify option. We could leave it in, but it won't do anything. Want to keep it? | 20:25 |
| Makyo | It's not slowing anything down, just extra stuff. No harm in leaving it. | 20:25 |
| hatch | Makyo maybe we drop the --no-verify entirely and only use the env var so that it's the same across both check and lint? | 20:25 |
| Makyo | hatch, it's not by check or lint, is by hook type. | 20:26 |
| hatch | right | 20:26 |
| Makyo | git commit --no-verify or NO_VERIFY git push | 20:26 |
| Makyo | Etc. | 20:26 |
| Makyo | Sure. | 20:26 |
| hatch | NO_VERIFY=1 git commit | 20:26 |
| hatch | NO_VERIFY=1 git push | 20:26 |
| Makyo | Sure. | 20:26 |
| hatch | I'm just going for easiest to understand for new gitters | 20:26 |
| Makyo | Sure. | 20:26 |
| hatch | feel free to disagree :) | 20:27 |
| bac | rick_h_: would you remove benji from the short list of assignees in kanban? i get sad everytime i see his name. | 20:28 |
| * hatch hands bac a tissue | 20:28 | |
| Makyo | hatch, no, you're right,t hat's what hacking.rst is for | 20:29 |
| Makyo | hatch, can I bother you real quick to check again and see if that's along the lines of what you were thinking | 20:30 |
| hatch | sure | 20:30 |
| hatch | looking | 20:30 |
| bac | jujugui: would some bored soul please review https://codereview.appspot.com/83270048 ? it is trivial. only question is warning vs error. | 20:30 |
| hatch | Makyo :+1: thanks | 20:31 |
| hatch | I just deleted 200 lines of browser routing code and it still mostly works..... | 20:31 |
| hatch | wow fullscreen required a lot of cruft | 20:32 |
| hatch | bac on it | 20:32 |
| * hatch isn't bored though | 20:32 | |
| hatch | I love that python can deconstruct vars....I wish js could do that (coming in ES6? 7?) | 20:33 |
| Makyo | Pssst. | 20:33 |
| Makyo | Coffeescript can~ | 20:33 |
| kadams54 | Eh? | 20:33 |
| hatch | Makyo lol | 20:33 |
| hatch | no it just hides it | 20:34 |
| Makyo | I kid, I kid. | 20:34 |
| hatch | bac reviewed...plz see comment | 20:36 |
| hatch | Makyo they are bringing arrow fn's to js in ES7 I think.... | 20:36 |
| hatch | it makes me sad | 20:36 |
| bac | hatch: i just included QA instructions on the RV | 20:36 |
| hatch | bac ok, before I qa let me know what you think of that comment | 20:40 |
| rick_h_ | bac: updated | 20:41 |
| bac | hatch: i'm of two minds about your request. i chose to do the easy thing because i think the intent is provide a simple check for people that forgot to remove the juju-gui from their bundle. | 20:41 |
| bac | hatch: but it is easy enough to fail on either a service named 'juju-gui' or a charm url that has 'juju-gui' in it | 20:42 |
| hatch | hmm | 20:43 |
| hatch | are there any charms which could have juju-gui in them besides the actual gui? | 20:43 |
| rick_h_ | bac: I'd think we can get away with a warning. Because technically they can have a bundle with the gui, but it'll fail quickstart/dragging/dropping int he gui | 20:43 |
| hatch | I think the potential false negative/positive is much less checking the charm | 20:44 |
| rick_h_ | bac: but will work for deployer/automated builds | 20:44 |
| rick_h_ | bac: and we only case about what 'will not work' which is colliding names | 20:44 |
| rick_h_ | bac: so if someone wants two guis, maybe different config/etc then more power to them | 20:44 |
| rick_h_ | imo | 20:44 |
| rick_h_ | the goal if the work is to stop people from doing something sane (taking their env and exporting it) and having it fail to deploy | 20:44 |
| bac | rick_h_: but if it is just a warning then it'll get ingested into charmworld and be presented in the juju-gui sidebar and then not be deployable | 20:45 |
| bac | so we'll have stuff over there that fails when you drag it in | 20:45 |
| rick_h_ | bac: ah true. Ok, yea, so guess it's an error | 20:46 |
| rick_h_ | so you can use a bundle of your own with it | 20:46 |
| rick_h_ | but not have it get ingested | 20:46 |
| rick_h_ | bac: sounds good to me | 20:46 |
| hatch | rick_h_ mind weighing in on the "check service name or charm name" discussion? | 20:46 |
| hatch | you can be the tie breaker | 20:46 |
| hatch | :) | 20:46 |
| hatch | no pressure | 20:46 |
| rick_h_ | we just need to check service name | 20:46 |
| rick_h_ | it's the only thing not allowed | 20:46 |
| rick_h_ | and the only thing that's causing users to hit errors | 20:46 |
| hatch | ok that's valid | 20:47 |
| rick_h_ | there's nothing wrong with two guis like I said | 20:47 |
| hatch | bac lgtm'd | 20:48 |
| bac | hatch, rick_h_: in light of that i'll change the message to | 20:48 |
| bac | Bundles may not services named "juju-gui". | 20:48 |
| hatch | good call | 20:48 |
| bac | but i'll make it make sense | 20:48 |
| hatch | +1 | 20:48 |
| hatch | rofl | 20:48 |
| hatch | HOW IS BABBY FORMED | 20:48 |
| hatch | ^ still the best thing on the internet | 20:49 |
| rick_h_ | bac: thanks. We've done users a disservice with this so far so definitely good to help get them on the right track. | 20:49 |
| bac | hatch: are you going to QA? | 20:51 |
| bac | hatch: sorry it is a pain. | 20:51 |
| bac | hatch: i'm proposing that charm-tools patch next to make it less painful going forward | 20:52 |
| hatch | bac sorry I don't have charmworld | 20:53 |
| bac | rick_h_: yeah, too bad we didn't pay a little more attention to the export process. it became integral really fast and a few mistteps really bit us. | 20:53 |
| hatch | I wouldn't even know where to start | 20:53 |
| bac | hatch: no biggie | 20:53 |
| hatch | maybe someone who already has charmworld up and running | 20:53 |
| bac | hatch: we can just let it land on staging and then qa from there. i've proven it works on my machine. | 20:54 |
| hatch | sure | 20:54 |
| hatch | rick_h_ /precise/mysql and /bundle/... are really doing the same thing....is there a reason why they are handled separately? | 20:54 |
| hatch | one is rendered in sidebar and one is rendered in routedirectcharmid | 20:55 |
| Makyo | jujugui anyone know what this is about? http://ci.jujugui.org:8080/job/juju-gui-merge/221/console This is on merging a docs only branch, has this changed otherwise? | 20:59 |
| hatch | hmm | 21:00 |
| hatch | I'd re-run | 21:00 |
| hatch | I have seen it before and I think I just re-ran | 21:01 |
| rick_h_ | hatch: because they're different views, bundles, and url parts? | 21:03 |
| rick_h_ | hatch: e.g. bundle/mysql/scalable bundle/mysql/4/scalable | 21:03 |
| rick_h_ | /precise/mysql is just the mysql charm with the latest revision | 21:03 |
| hatch | yeah, lots of duplication of functionality across the two | 21:03 |
| rick_h_ | hatch: right, but they share a common View base, entityBase | 21:04 |
| rick_h_ | and so it's shared a bit, but the url matching/state is different. But this is what I mean about breaking things down into better state bits. | 21:04 |
| rick_h_ | detail: bundle, id: mysql/4/scalable or detail: charm, id: precise/mysql, or detail: service, id: mysql, or detail: unit, id: 5 | 21:05 |
| hatch | do we have a list of the valid bundle urls? | 21:06 |
| rick_h_ | ~user/basket/bundle ~user/basket/version/bundle (and without ~user where it's assumed it's promulgated and is ~charmers) | 21:06 |
| rick_h_ | so those 4 possible urls | 21:06 |
| hatch | right now they are all /bundle/:user/:basket/:revno/:bundle | 21:06 |
| hatch | ok cool thanks | 21:07 |
| rick_h_ | right, user and revno are optional and can be assumed as ~charmers or latest version | 21:07 |
| hatch | hmm I wonder if I should remove minimized as well | 21:21 |
| hatch | rick_h_ this is confirmed? ^ | 21:21 |
| hatch | Makyo looks like just re-running it was the trick? | 21:50 |
| huwshimi | Morning | 22:06 |
| Makyo | hatch, yep. | 22:11 |
| Makyo | Sorry, was dogwalking | 22:11 |
| hatch | no prob | 22:11 |
| hatch | morning huwshimi | 22:11 |
| huwshimi | Internet is bad this morning. | 22:14 |
| hatch | they need to run another phone line to the island I guess eh? | 22:15 |
| huwshimi | hatch: Yep, it's a hassle when someone wants to make a call! | 22:18 |
| hatch | lol, they pick up the phone and the internet goes down | 22:18 |
| hatch | ugh parents | 22:18 |
| huwshimi | haha | 22:18 |
| huwshimi | hatch: There is fibre running past my house, they just haven't turned it on yet. | 22:19 |
| huwshimi | Yay! I'm getting 0.31mbps! | 22:20 |
| hatch | lol nice | 22:20 |
| huwshimi | brb, rebooting router | 22:21 |
| Makyo | hatch, got a minor fix for the provided example hook in hacking.rst. Mind if I just land it? Fixing a typo. https://github.com/juju/juju-gui/pull/221 | 22:22 |
| Makyo | Just making it a bit more compatible. | 22:23 |
| hatch | Makyo sure | 22:24 |
| hatch | what does it do? | 22:24 |
| Makyo | I wrote bash syntax, but used #!/bin/sh in the shebang. Calls test to ensure that make lint runs unless NO_VERIFY was set. | 22:25 |
| hatch | ahh | 22:27 |
| hatch | coolio | 22:27 |
| hatch | rick_h_ if you're looking for some night time reading material. I have removed viewmode but not yet added in all the state bits https://github.com/hatched/juju-gui/compare/remove-viewmode?expand=1 | 23:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!