| rick_h_ | morning huwshimi | 00:33 |
|---|---|---|
| === rogpeppe is now known as rogpeppe1 | ||
| === rogpeppe1 is now known as rogpeppe | ||
| rick_h_ | frankban: do you still need a review? If so can you shoot me the link and I'll look. | 12:27 |
| frankban | rick_h_: thank you! https://codereview.appspot.com/84630043 | 12:28 |
| rick_h_ | thanks for the link | 12:28 |
| * frankban lunches | 12:52 | |
| hazmat | what's the status of icons and local charms? | 13:23 |
| rick_h_ | hazmat: on the board for this week hopefully | 13:28 |
| rick_h_ | hazmat: got delayed due to juju 1.18 changes messing with quickstart a bit | 13:28 |
| hazmat | rick_h_, i need to discuss that a bit more.. we're using local charms for a demo.. afaicr.. gui was still fetching icons from the store based on what the store told it, but apis where put in place to fetch from state server? | 13:29 |
| hazmat | er. demo this week | 13:30 |
| hazmat | er. apis on the state server where put in place to fetch/return files from a charm.. | 13:31 |
| rick_h_ | hazmat: yep, that's the work we've got to do to hook to those | 13:31 |
| rick_h_ | hazmat: free if you want to chat now | 13:32 |
| rick_h_ | hazmat: https://plus.google.com/hangouts/_/canonical.com/weekly-gui | 13:33 |
| rick_h_ | or https://plus.google.com/hangouts/_/canonical.com/weekly-gui?authuser=1 for the second account business if you need | 13:34 |
| hatch | morning all | 13:35 |
| rick_h_ | morning hazmat | 13:35 |
| rick_h_ | err hatch | 13:35 |
| rick_h_ | damn tab complete | 13:35 |
| hatch | haha - I'm so close to finishing this darn url parser | 13:35 |
| hatch | man we have a lot of urls | 13:35 |
| rick_h_ | hatch: very cool | 13:36 |
| hatch | http://www.regexr.com/ it's like regex pal but "modern" :) | 13:37 |
| hazmat | rick_h_, grabbing coffee, 1m | 13:38 |
| rick_h_ | hazmat: rgr | 13:38 |
| hatch | rick_h_ I can't seem to boot ubuntu with an external monitor plugged in - have you tried that with yours yet? | 13:45 |
| rick_h_ | nope | 13:46 |
| rick_h_ | my only monitor is my 4k on the desktop | 13:46 |
| rick_h_ | so no spares around | 13:46 |
| hatch | ahh ok - it just kernel panics so I'll have to do some digging | 13:48 |
| hatch | one of these days I'll get it working hah | 13:48 |
| hatch | usually I wait a few months before trying out a new version, this is very out of character :) | 13:48 |
| hatch | jujugui lf two reviews on the url request to state parser https://github.com/juju/juju-gui/pull/225 plz and thanks (no qa) | 14:11 |
| rick_h_ | hatch: will look in a bit | 14:11 |
| hatch | it's *snif* beautiful | 14:11 |
| rick_h_ | frankban: are you looking for reviews? kadams54 or bac might be able to help? | 14:11 |
| kadams54 | hatch: taking a look | 14:11 |
| hatch | thanks | 14:11 |
| frankban | rick_h_, guihelp: yes, I need one review for https://codereview.appspot.com/84520047 (quickstart). thanks! | 14:12 |
| rick_h_ | frankban: heads up, after quickstart we've got a important thing to try to get local charm icons for this week. Will bring it up on call today | 14:12 |
| bac | frankban: i'll look | 14:13 |
| frankban | rick_h_: ack | 14:13 |
| hatch | I can look | 14:13 |
| frankban | bac: thank you! | 14:13 |
| hatch | oh | 14:13 |
| hatch | too slow :) | 14:13 |
| hazmat | what does token mean? | 14:14 |
| rick_h_ | hazmat: it's the widget used in the browser | 14:15 |
| hatch | rick_h_ kadams54 I'm purposefully leaving out reviewer comments because I wrote it to try and be as easy to read as possible - let me know if I failed in that :) | 14:15 |
| rick_h_ | for search completion suggestions, sidebar, etc | 14:15 |
| hazmat | rick_h_, ic.. not to be confused with auth token etc | 14:15 |
| rick_h_ | hazmat: correct | 14:15 |
| hazmat | rick_h_, thanks | 14:15 |
| hazmat | rick_h_, iotw a viewlet by another name/impl ? | 14:16 |
| rick_h_ | hazmat: sure | 14:16 |
| rick_h_ | hazmat: it's pre the viewlet work and the charm tokens were done as YUI widgets. so it was a non 'widget' word | 14:16 |
| hazmat | gadget is open ;-) | 14:17 |
| hatch | haha | 14:17 |
| rick_h_ | go go gui gadget! | 14:17 |
| hatch | "gadget all the things!" | 14:17 |
| frankban | jujugui: during the weekend I had some fun writing a little juju plugin which allows deploying charms hosted on github. Maybe it can be useful for someone: https://github.com/frankban/juju-git-deploy | 14:17 |
| hazmat | frankban, hatch i saw that one.. | 14:17 |
| rick_h_ | frankban: sweet | 14:17 |
| kadams54 | nice | 14:18 |
| hazmat | frankban, very nice ++ | 14:18 |
| hazmat | was trolling pypi looking for juju this morning and came across it | 14:18 |
| hazmat | s/trolling/trawling | 14:18 |
| hatch | frankban awesome! | 14:18 |
| hatch | hazmat oh c'mon you were trolling it :P | 14:18 |
| frankban | hazmat: yeah, uploaded this morning, I wanted to hack something with python3 | 14:19 |
| * kadams54 tries to imagine what trolling pypi would look like | 14:19 | |
| frankban | hatch: thanks, I used your ghost charm for examples | 14:19 |
| hatch | kadams54 someone uploaded a bunch of null packages to npm as barack_obama ..... that's trolling...I think? lol | 14:19 |
| kadams54 | lol | 14:19 |
| kadams54 | Yeah, that qualifies | 14:19 |
| hatch | frankban I hope it was good enough quality :) | 14:20 |
| frankban | hatch: it deploys... good enough ;-) | 14:20 |
| hatch | lol | 14:20 |
| hatch | If I could just figure out haproxy I could get it back in for review | 14:20 |
| hatch | I can't seem to get haproxy to proxy anything ( even wordpress ) so I'm guessing I'm doing something wrong | 14:21 |
| kadams54 | hatch: that's a lot of code. What's going to be replaced? | 14:47 |
| kadams54 | loadRequest… | 14:48 |
| hatch | kadams54 yeah loadRequest and anything loadRequest calls | 14:48 |
| rick_h_ | chunks of routeView | 14:48 |
| rick_h_ | lots of browser.js stuff | 14:48 |
| hatch | that too | 14:48 |
| hatch | yeah | 14:48 |
| kadams54 | Filter? | 14:48 |
| hatch | filter doesn't technically exist right now | 14:48 |
| hatch | it's old code there | 14:49 |
| rick_h_ | ? | 14:49 |
| hatch | we don't filter anything anymore | 14:49 |
| kadams54 | this.filter.update(query) <- line 261 in loadRequest | 14:49 |
| rick_h_ | k, will look into it. Thought we still needed it | 14:49 |
| hatch | ohh I thought that we didn't use this because we only used search now | 14:50 |
| rick_h_ | jujugui call in 10, kanban please | 14:50 |
| rick_h_ | hatch: it's used in search still | 14:50 |
| hatch | you can't select by series and whatnot any longer | 14:50 |
| kadams54 | So is state.js taking on functionality that had previously existed in browser.js? | 14:50 |
| rick_h_ | kadams54: yes | 14:50 |
| rick_h_ | kadams54: well, the plan is it'll exist in state.js and statecontroller (not there yet) soon | 14:51 |
| kadams54 | All of the new functionality seems like a good for state.js, so I approve :-) | 14:51 |
| hatch | yay! | 14:51 |
| hatch | rick_h_ kadams54 I was pretty sure that the only line in use in filter was `this.set('text', data.text);` | 14:51 |
| kadams54 | Still not sure we need a state manager… I started down that route but decided it was overkill | 14:52 |
| frankban | bac: thanks for the review. +0 == <shrug>, correct? ;-) | 14:52 |
| hatch | after the call we can chat and you can educate me on this filter class | 14:52 |
| hatch | maybe I missed the functionality somewhere | 14:52 |
| hatch | kadams54 entirely possible....the functionality is still required, just weather it's required in a capacity that requires a whole new class :) | 14:52 |
| hatch | whether even | 14:54 |
| kadams54 | ;-) | 14:55 |
| hatch | good afternoon luca__ | 14:55 |
| luca__ | good morning hatch | 14:56 |
| hatch | we need to invent some cross-timezone greating | 14:56 |
| hatch | greeting | 14:56 |
| hatch | bleh I can't type | 14:56 |
| kadams54 | Good day to you, fine [sir/madam]. | 14:56 |
| hatch | old-english has to have something that would sound awesome | 14:56 |
| luca__ | Good post-pre noon | 14:57 |
| hatch | haha that's not very old-englishy | 14:57 |
| hatch | kadams54 is so far winning | 14:57 |
| kadams54 | A merry Greenwich morning! | 14:57 |
| luca__ | rofl | 14:57 |
| luca__ | old english isn’t my forte | 14:57 |
| hatch | what? Isn't everyone in England fluent in old english? | 14:58 |
| hatch | just like all Canadians live in igloos | 14:58 |
| kadams54 | It's just English, only all olde timey, right? | 14:58 |
| luca__ | hmmm, don’t think so | 14:58 |
| hatch | english is a melting pot of other languages that's why it's such a mess lol | 14:58 |
| kadams54 | My wife was a Chaucer nut, so I had some exposure Middle English. | 14:59 |
| luca__ | though its the best language melting point | 14:59 |
| hatch | clearly - it's winning, that must mean it's the best | 14:59 |
| hatch | right? right? | 14:59 |
| hatch | ... | 14:59 |
| luca__ | I think Mandarin is winning | 14:59 |
| rick_h_ | jujugui call in 1 | 15:00 |
| hatch | luca__ but outside of their borders too? | 15:00 |
| luca__ | hatch: think so, and then it’s spanish | 15:01 |
| rick_h_ | kadams54: standup please | 15:01 |
| hatch | hmm, it sounds to me like I'm grossly misinformed | 15:01 |
| hatch | which woudln't be the first time | 15:01 |
| kadams54 | tech diificulties, one moment | 15:01 |
| kadams54 | *sigh* | 15:03 |
| kadams54 | "It's taking too long to connect you to this video call. Try again in a few minutes." | 15:03 |
| hatch | I'll review/qa huws branch | 15:11 |
| rick_h_ | hatch: thanks | 15:11 |
| hatch | ohh rick_h_ did you want to educate me on the filter stuff? | 15:13 |
| rick_h_ | hatch: let's plan that for later in the day? I want to go through the branch before my call at noon | 15:13 |
| hatch | yeah sure np | 15:14 |
| rick_h_ | hatch: and I've got to review myself. I remember kadams54 and I talking about it and there was something there | 15:14 |
| rick_h_ | but hazy memory atm | 15:14 |
| hatch | ok sure - take a peek at it when you get a chance, I'm pretty sure it's not being used anymore with the exception of that one line | 15:18 |
| * frankban bbiab | 15:21 | |
| rick_h_ | hatch: comments added, have one big note I'd like to chat on | 15:27 |
| hatch | ok looking | 15:27 |
| rick_h_ | hatch: setup a link when you're ready. Would like to chat pre-call in 30. That's a 2hr call so will be afk for a bit | 15:34 |
| hatch | yep almost done replying | 15:34 |
| hatch | rick_h_ replied, generating hangout | 15:37 |
| hatch | rick_h_ https://plus.google.com/hangouts/_/76cpjkvbtggmqe4fcb1apod8cs?authuser=1&hl=en | 15:37 |
| * hatch puts thinking cap on | 15:50 | |
| rick_h_ | hatch: sorry to throw wrenches, duck harder lol | 15:52 |
| hatch | haha - no this is good, we definitely need the state to be coordinated by UI 'section' | 15:52 |
| rick_h_ | hatch: but <3 the well thought out series of urls/parsing/etc. Exactly what we need | 15:52 |
| hatch | I am thinking of a way to parse it and allow for expansion/modification easier | 15:53 |
| rick_h_ | know that was a pita to go through but it'll save so much time later | 15:53 |
| hatch | great | 15:53 |
| rick_h_ | should actually have jcastro look at it and go "here's your new urls" :P | 15:53 |
| jcastro | hatch, show me! | 15:54 |
| hatch | https://github.com/juju/juju-gui/pull/225/files#diff-2a3133ac229f3cbcee63940b2d270c50R300 | 15:55 |
| hatch | 100 lines of supported urls lol | 15:55 |
| hatch | will chrome stream .ogg files by default? I'm trying to test before it's up but the file 'could not be found' | 15:57 |
| Makyo | hatch, I don't think icecast is up yet | 15:58 |
| hatch | any idea if chrome will stream .ogg? | 15:58 |
| Makyo | It will | 15:58 |
| hatch | ok cool | 15:58 |
| Makyo | There it goes. | 15:59 |
| hatch | I just didn't want to be scrambling to find a plugin heh | 15:59 |
| hatch | oh there we go | 15:59 |
| hatch | elevator music | 15:59 |
| hatch | cool | 15:59 |
| hatch | I feel like I'm in a uk sitcom | 15:59 |
| Makyo | Haha | 15:59 |
| hatch | oh billy go grab my trunk from the boot | 15:59 |
| hatch | haha, that's all I got | 16:00 |
| Makyo | You're weird. :) | 16:00 |
| hatch | truth! | 16:00 |
| Makyo | This coffee shop is playing country - it's a weird mix. | 16:01 |
| hatch | haha | 16:02 |
| rick_h_ | jujugui remember this call is internal and keep any notes/discussion in internal irc | 16:04 |
| * rick_h_ puts away paranoid boss hat | 16:05 | |
| hatch | :) | 16:05 |
| hatch | rick_h_ I think I figured out a good way to do this state thing - I'll throw it together after this call | 16:05 |
| bac | so don't mention the facebook buyout offer? | 16:05 |
| rick_h_ | hatch: cool | 16:05 |
| hatch | lol - that was such a poorly executed april fools joke | 16:06 |
| rick_h_ | ok, 2hr call ended | 16:17 |
| rick_h_ | well cancelled | 16:17 |
| rick_h_ | so yay me | 16:17 |
| hatch | rick_h_ before implementing I wrote a proposition in the PR, check it out when you can | 16:54 |
| rick_h_ | hatch: will load it up | 16:55 |
| * Makyo runs back home real quick. Back on there. | 16:58 | |
| rick_h_ | hatch: replied | 16:59 |
| rick_h_ | kadams54: appreciate your feedback based on your state understanding as well please | 16:59 |
| hatch | thanks - I'm trying to think/read/listen at the same time heh | 16:59 |
| hatch | brain isn't built for three tasks | 16:59 |
| rick_h_ | hatch: understand, same here | 17:00 |
| hatch | ok call done, now back to single tasking | 17:01 |
| hatch | rick_h_ I'm going to keep replying in the PR so that others can get in on the convo/stay up to date on it...ok? | 17:02 |
| hatch | it's kind of an important architecture part of the app | 17:02 |
| rick_h_ | hatch: I suppose, but let's not go an hour typing what we can talk in 10 | 17:03 |
| hatch | haha for sure | 17:03 |
| rick_h_ | hatch: what I'm looking for is the example realistic use case that requires the dual state purpose | 17:03 |
| hatch | sure | 17:04 |
| hatch | typing also helps to think things through before hitting send | 17:04 |
| hatch | :_ | 17:04 |
| hatch | :) | 17:04 |
| rick_h_ | rgr | 17:04 |
| hatch | rick_h_ ok replied, after you read through that if you want to chat on it fire me a link | 17:12 |
| rick_h_ | reading | 17:13 |
| hatch | I think I prefer typing then discussing....helps flesh out ideas before trying to stumble through them in a call first :) | 17:13 |
| rick_h_ | hatch: https://plus.google.com/hangouts/_/7acpjlm8eiil44q1btqpkg163o?hl=en | 17:14 |
| rick_h_ | kadams54: ^ if you'd like to join | 17:14 |
| rick_h_ | or anyone else | 17:14 |
| rick_h_ | jujugui if anyone has any questions from that call today let me know and happy to see if I can answer or get answers. | 17:50 |
| bac | jujugui: i'm going to be starting late due to dr appt tomorrow. | 18:26 |
| rick_h_ | bac: rgr, thanks for the heads up | 18:27 |
| === BradCrittenden is now known as bac | ||
| hatch | Makyo have you had any luck getting the tests to pass in vagrant? | 19:15 |
| hatch | I haven't... | 19:15 |
| * hatch crys | 19:15 | |
| Makyo | hatch, not even in test-server? | 19:16 |
| hatch | Makyo yeah test-server works, but it's over 4x slower :) | 19:17 |
| hatch | "ain't no body got time for that" | 19:17 |
| Makyo | It's not THAT bad, yeesh. | 19:20 |
| Makyo | At least, not for me. | 19:20 |
| Makyo | Also, xchat's broken for me, sorry if I don't see replies right away. | 19:20 |
| hatch | oh yeah it's about 20s in test-debug, and in the browser it's ~100s | 19:23 |
| hatch | so I guess that's 5x heh | 19:26 |
| Makyo | Hasty, hasty :) | 19:40 |
| * rick_h_ runs off to get boy from day care. Have a good evening all | 20:15 | |
| hatch | lata | 20:16 |
| hatch | hmm | 20:39 |
| hatch | rick_h_ I ran into a slight glitch with this new object, ping whenever you get a chance | 20:39 |
| hatch | we actually have three sections, sidebar (sectionA), machineView(sectionC), and charm details(sectionB) | 20:41 |
| hatch | ^ kadams54 | 20:41 |
| hatch | unless the charm details is in section C | 20:41 |
| hatch | I'd create the new section...but I'm not sure if there are any new designs which have the charm details go into the machine view area | 20:42 |
| kadams54 | Sorry, context switching is hard… we're talking about sections (substrings) of the URL, right? Not sections (panes) within the UI? | 20:42 |
| kadams54 | Also, I haven't seen any designs that incorporate pulling details up in machine view… FWIW. | 20:43 |
| hatch | sections in the UI | 20:43 |
| hatch | ok then in that case we 'need' three sections | 20:43 |
| * hatch puts foots down | 20:44 | |
| hatch | I guess when rick_h_ returns he can tell me to undo it all lol | 20:44 |
| kadams54 | From what I've heard, details would be in the sidebar? | 20:44 |
| hatch | when you look at all of the information in the charm details pane, don't you think that would be hard to make legible in the sidebar? | 20:45 |
| hatch | especially considering bundle examples | 20:45 |
| hatch | well really it's pretty trivial to change in my code, just a pita to change 100 url results in the test | 20:45 |
| kadams54 | Ah, yeah… some of my conversations two weeks ago with Rick are starting to come back | 20:46 |
| kadams54 | We talked about three sections: sidebar, content, and canvas | 20:46 |
| kadams54 | Well, maybe canvas was default content | 20:46 |
| kadams54 | So then it would just be two | 20:46 |
| hatch | then the charm details would go over the canvas, like the machine view? | 20:46 |
| kadams54 | So details would display in the content section | 20:47 |
| kadams54 | Content section would display these: canvas, machineView, details | 20:47 |
| hatch | ok our current UI requires three states though | 20:47 |
| kadams54 | Sidebar would display these: search/browse, inspector, ...? | 20:47 |
| hatch | I doubt he would have had that UI change also done by vegas | 20:47 |
| kadams54 | Not sure what you mean by three states | 20:48 |
| hatch | sidebar: search/browse/inspector | 20:48 |
| hatch | details: charm details | 20:48 |
| hatch | content: canvas/machineview/networkview | 20:48 |
| kadams54 | I'm not following why details can't be just another type of content | 20:48 |
| hatch | the state needs to be organized by UI blocks so that we can parse this state to generate urls | 20:51 |
| hatch | so each block that can be rendered at the same time needs it's own 'section' in the state object | 20:52 |
| hatch | so since search, charm details, machine view can all be rendered at once, that's three sections | 20:52 |
| hatch | yup that's it....that was the defining argument - thanks mr sounding board :) | 20:52 |
| rick_h_ | hatch: ping | 21:06 |
| hatch | pong | 21:07 |
| * hatch points to the scrollback | 21:07 | |
| rick_h_ | hatch: yes, there are designs to make all details go into the machine view area by making it full size | 21:07 |
| hatch | ok but that's not coming before..... | 21:07 |
| rick_h_ | and there's designs trying to find a way to make a mini-details in the sidebar | 21:07 |
| hatch | whatever the conf coming up is called | 21:07 |
| rick_h_ | hatch: well, if it's easier to do that than deal with it as a 3rd component then yes | 21:07 |
| rick_h_ | which I think it might be eaiser to just make the thing full width | 21:08 |
| hatch | from my end here it's really easy to add another section | 21:08 |
| hatch | the harder part is writing all these darn tests | 21:08 |
| hatch | heh | 21:08 |
| hatch | as in, it took me about 15s to add another section :) | 21:08 |
| hatch | maybe less | 21:08 |
| rick_h_ | right ,but then you have to test that as a 3rd combination of sections | 21:09 |
| rick_h_ | vs just showing the view or not showing the view | 21:09 |
| rick_h_ | which is a dispatch problem really and not for this branch | 21:09 |
| hatch | yep | 21:10 |
| rick_h_ | it makes this branch simpler, and dispatch has to destroy machine view and show details view | 21:10 |
| hatch | no I'd render it overtop | 21:10 |
| rick_h_ | I'm not seeing what the big work is, it's some CSS to adjust the width, which doesn't have to happen right away | 21:10 |
| rick_h_ | that's an optimization when we get there | 21:10 |
| rick_h_ | right now they're two views, we show one or the other | 21:10 |
| hatch | well the toggle buttons need to go to a 'blank' state, then when you click on it needs to hide the details | 21:10 |
| rick_h_ | no, because details have a close button | 21:11 |
| rick_h_ | you can have 'machine' clicked due to the url or your activity | 21:11 |
| rick_h_ | and when you close it, the url updates, and it renders the machine view | 21:11 |
| hatch | and what happens if the user clicks the machine/canvas buttons? | 21:11 |
| hatch | it will need to close the details | 21:11 |
| rick_h_ | the url updates, dispatch determines there's nothing to do | 21:11 |
| hatch | (if it's full screen) | 21:12 |
| rick_h_ | because you've not closed details | 21:12 |
| rick_h_ | it's part of the priority/ "should show XXX" work in dispatch | 21:12 |
| hatch | that feels like a bug to me | 21:12 |
| rick_h_ | at least for machine view 1.0 | 21:12 |
| rick_h_ | sure, then we can work on the bug, but adding a 3rd state right now is asking for trouble we don't need | 21:12 |
| hatch | call? | 21:12 |
| rick_h_ | sure | 21:12 |
| rick_h_ | link | 21:12 |
| hatch | on it | 21:12 |
| hatch | https://plus.google.com/hangouts/_/7acpiv3m6of4d4nfejfu4or3ns?hl=en | 21:13 |
| bac | hey rick_h_, you're back. what was the ES book you found to be good? | 21:19 |
| rick_h_ | bac: looking | 21:20 |
| rick_h_ | bac: I think it was http://www.amazon.com/gp/product/B00BAOC2KQ/ref=oh_d__o08_details_o08__i00?ie=UTF8&psc=1 | 21:21 |
| bac | rick_h_: ping me if you discover it was something else. thanks | 21:25 |
| bac | bbiab | 21:25 |
| rick_h_ | bac: that was the one | 21:32 |
| bac | rick_h_: cool. now i have light reading for the evening | 21:33 |
| hatch | bac are you going to be our ES expert? | 21:37 |
| hatch | so the console version of mocha doesn't output the assertion failure message to the console.... | 22:30 |
| rick_h_ | mocha is fail | 22:35 |
| hatch | lol | 22:37 |
| hatch | I wonder if jasmine would fix the mocha bugs | 22:39 |
| hatch | probably will fix the mocha ones and introduce others | 22:40 |
| hatch | lol | 22:40 |
| huwshimi | Morning | 23:01 |
| huwshimi | I wish our tests would all run :( | 23:13 |
| hatch | morning huwshimi | 23:26 |
| hatch | huwshimi so the trash can is a different size and colour? Can you just pick one and use it for both then? kind of odd to have two trash cans that are so similar but different | 23:28 |
| huwshimi | hatch: How about we make all our fonts the same colour and size as well? | 23:29 |
| huwshimi | hatch: Ooh, ooh, we could do the same with our charm icons too! | 23:30 |
| hatch | we don't need to load in multiple fonts to change the size | 23:30 |
| hatch | we also don't need multiple trash cans to change the size either :P | 23:30 |
| huwshimi | hatch: Well, it's a sprite, not a whole lot of extra bytes | 23:31 |
| huwshimi | hatch: You could bring it up with spencer if you feel strongly about it. | 23:31 |
| huwshimi | hatch: I'm not even sure where we use delete.png | 23:32 |
| hatch | relation delete dialogue | 23:32 |
| huwshimi | Ah | 23:33 |
| hatch | I just remember when we had you go through the sprites and clear out all the old unused junk | 23:33 |
| hatch | that's going to happen again unless we keep on top of the assets | 23:33 |
| huwshimi | hatch: Sure, but it's a bit crazy to say that things shouldn't be different sizes and shapes | 23:35 |
| huwshimi | erm sizes and colours | 23:36 |
| hatch | no - but you can scale images down | 23:36 |
| hatch | so a single asset becomes multiple | 23:36 |
| huwshimi | hatch: Not with our spriting system you can't. | 23:37 |
| huwshimi | hatch: Also recolouring rasters is not fun. | 23:37 |
| huwshimi | We're at least not set up to do that either | 23:37 |
| hatch | OH KAY then | 23:38 |
| hatch | just trying to look out for the future! | 23:38 |
| huwshimi | hatch: Additionally these are rasters so you can't do any pixel hinting on resize. | 23:39 |
| hatch | we can't do a css scale transform on the element? | 23:40 |
| huwshimi | hatch: Not with any pixel hinting | 23:41 |
| hatch | what's pixel hinting? | 23:41 |
| hatch | css blend modes are coming soon | 23:42 |
| hatch | that's gona be cool | 23:42 |
| huwshimi | hatch: Well, if you scale an image you'll end up with blurry edges as they won't line up with the pixel edges, that's why images are redesigned, or at least recreated for different sizes. | 23:43 |
| hatch | yeah I suppose, I figured they were so small it wouldn't matter | 23:43 |
| huwshimi | hatch: The smaller the image, the more this matters. | 23:44 |
| huwshimi | hatch: Or at least, the more you will notice it. | 23:44 |
| hatch | hmm interesting | 23:45 |
| hatch | well then they should be the same asset then lol | 23:45 |
| rick_h_ | if they're different size then they're png's. We should be able to size somewhat | 23:45 |
| rick_h_ | if they're different colors we need to address with UX | 23:45 |
| rick_h_ | that seems like an issue and we've got a lot of trash cans coming in the machine view | 23:45 |
| rick_h_ | so better to get it straight | 23:45 |
| hatch | so much garbage | 23:45 |
| hatch | :P | 23:45 |
| rick_h_ | however, it's fine to land until we get answers, but we should get an email out at the very least and bring it up on comingsoon | 23:46 |
| huwshimi | hatch: Well, the point is that they need to be different assets as you need to recreate them for each size so you can get the pixels in the right places. | 23:46 |
| hatch | huwshimi yeah I am not saying your arguments aren't valid | 23:47 |
| hatch | I'm saying that we should probably use the same one in both places | 23:47 |
| hatch | like...change the design | 23:47 |
| huwshimi | hatch: But that's what I'm saying, that argument is like saying all the fonts should be the same size. | 23:48 |
| hatch | well no, it's more like saying all the fonts should be the same font | 23:48 |
| hatch | :) | 23:48 |
| rick_h_ | hatch: did you review/qa the rest of the branch? | 23:48 |
| rick_h_ | trash can aside? | 23:48 |
| rick_h_ | e.g. is it ok to land and bring up with UX | 23:48 |
| hatch | rick_h_ trying to do it while cooking supper | 23:48 |
| rick_h_ | hatch: rgr, thanks. I can look in a bit as well after the boy goes to bed | 23:48 |
| huwshimi | hatch: You want to change the design for technical reasons, but it is more than logical that the icons might be a different size to fit with different UI elements. | 23:48 |
| rick_h_ | but let's agree we need to communicate with UX and not debate on it here. We can't move it forward without involving them and their wireframes | 23:49 |
| rick_h_ | and from my pov, the change of color/etc is more interesting to debate than the size. | 23:49 |
| huwshimi | rick_h_: The colour may be because of the background it is on. | 23:49 |
| huwshimi | it may well be because of outdated colours too. | 23:50 |
| hatch | huwshimi are you firing events for some reason? Or just to allow for testing? | 23:50 |
| hatch | deleteToken, selectToken for example | 23:50 |
| huwshimi | hatch: I assume we'll want to interact with the token somehow... | 23:51 |
| hatch | ok - I wasn't sure if there was an actual reason or if it was just put there as a sort of placeholder | 23:51 |
| hatch | I'm not sure how we would interact with it tbh | 23:51 |
| hatch | events do seem to be a good way though | 23:52 |
| huwshimi | hatch: I actually don't know what will happen with those events yet... | 23:52 |
| hatch | code looks good with some tidbits, just qa'ing now | 23:54 |
| huwshimi | rick_h_: Should I move onto the container token next? | 23:55 |
| rick_h_ | huwshimi: yes please | 23:55 |
| rick_h_ | huwshimi: and you should be able to wire up the click on the machine token to fill out the containers. You might need to talk with kadams54 about that at some point | 23:55 |
| huwshimi | rick_h_: ok sure | 23:56 |
| rick_h_ | huwshimi: and I want to make sure you see https://www.dropbox.com/sh/lvdydgiu7jeuuso/7MlRX5-IPu#lh:null-05.4-container.png | 23:56 |
| rick_h_ | that folder has a list of container-y wireframes | 23:56 |
| kadams54 | huwshimi: I'll be around if you want to chat. Working on taxes right now. (Yay.) | 23:56 |
| rick_h_ | including the container token stuff | 23:56 |
| rick_h_ | kadams54: yay you | 23:56 |
| rick_h_ | I'm so glad to get that over with, always hangs over my head | 23:56 |
| rick_h_ | huwshimi: check out 8 of 22 and 7 of 22 | 23:57 |
| rick_h_ | in particular for a start | 23:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
