| knome | hey stgraber | 00:02 |
|---|---|---|
| knome | stgraber, did you notice my bugfixes to the trackers (in the main branch, waiting to be pushed upstream) | 00:02 |
| stgraber | knome: I noticed your IRC ping at that time but haven't had the chance to look into it. | 00:04 |
| knome | oki | 00:04 |
| knome | the JS files itself are tested and will work; | 00:04 |
| knome | what you should review is how they are called in the module; i think i have it finally right.. | 00:04 |
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| pitti | Good morning | 05:58 |
| elfy | good morning pitti :) | 06:01 |
| pitti | hey elfy, how are you? | 06:01 |
| elfy | I'm good thanks - glad that xubuntu have finally decided what to do about ibus | 06:02 |
| * elfy was worried about releasing with that | 06:02 | |
| elfy | in other news - back to work today after week off :( | 06:03 |
| pitti | elfy: hah, did you enjoy you holidays? | 06:04 |
| elfy | it was a break - poor as a church mouse I am :) | 06:05 |
| elfy | pitti: actually I work p/t so I have 2 weeks a month off - but my week starts on a thursday ... | 06:06 |
| === maclin_ is now known as maclin | ||
| === knome_ is now known as knome | ||
| jibel | Good morning | 07:01 |
| knome | morning jibel | 07:03 |
| jibel | good morning knome | 07:04 |
| elfy | morning jibel knome | 07:04 |
| knome | allö elfy | 07:04 |
| jibel | hey elfy | 07:09 |
| pitti | jibel: hah, this time it's you who are too fast on the "retry" trigger :) | 08:39 |
| pitti | (udisks, nova) | 08:39 |
| jibel | pitti, heh, actually we should have a bot which restarts the tests if it fails on one arch and not on the other | 08:47 |
| === vrruiz_ is now known as rvr | ||
| davmor2 | jibel: we doing yet another round of testing today or is RC ready? | 09:39 |
| jibel | davmor2, if you have time, sure. We should test every image until the release. | 09:43 |
| davmor2 | jibel: no worries, I'm off tomorrow though :) | 09:44 |
| jibel | davmor2, cool, you won't be bothered by phone testing then. That leaves you plenty of time for desktop ;) | 09:47 |
| davmor2 | jibel: HA!! Not a pray I won't be anywhere near a computer all day, I'm going outside, I know I didn't think it existed either :) | 09:48 |
| === vrruiz_ is now known as rvr | ||
| === chihchun is now known as chihchun_afk | ||
| === fader_ is now known as fader | ||
| === _salem is now known as salem_ | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === qwebirc984668 is now known as slickymasterWork | ||
| === maclin_ is now known as maclin | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === bfiller is now known as bfiller_afk | ||
| === bfiller_afk is now known as bfille | ||
| === bfille is now known as bfiller | ||
| Letozaf_ | elopio, hello | 19:07 |
| elopio | hey Letozaf_ how are you? | 19:08 |
| Letozaf_ | elopio, I'm fine and you ? | 19:08 |
| elopio | good | 19:09 |
| elopio | Letozaf_: I had just opened your branch 15 minutes ago | 19:09 |
| Letozaf_ | elopio, how is it ? | 19:09 |
| elopio | Letozaf_: it looks very good. | 19:09 |
| elopio | just some more details | 19:10 |
| Letozaf_ | elopio, I had some doubts about those two methods you wanted me to be private | 19:10 |
| elopio | Letozaf_: you asked that if you made the helpers private in emulators.py, you shouldn't call them from the test | 19:10 |
| elopio | that's precisely the idea :) | 19:11 |
| Letozaf_ | elopio, oh! so probalby I misunderstood :P | 19:11 |
| elopio | you should move open_feed_item and get_article_count to emulators.py, and those are the methods you call from the test. | 19:11 |
| Letozaf_ | elopio, oh fine I will | 19:12 |
| elopio | Letozaf_: another thing is that you removed the assertion at the end of the test | 19:12 |
| elopio | we need to check something, but I'm not sure what's the thing you want to check here. | 19:12 |
| Letozaf_ | elopio, I wanted to check that the count property of the article view was greater than 0 before opening a feed it is 0 | 19:14 |
| Letozaf_ | elopio, so if the feed is opened is should be greater than 0 | 19:14 |
| Letozaf_ | elopio, I put that in get_current_article_count | 19:14 |
| elopio | Letozaf_: ok, that could work. But as we are testing from the user point of view here, it sounds that it would be better to check that the article you opened is visible. | 19:15 |
| Letozaf_ | elopio, and also get_current_index should assert that the current_index property is greater than -1 | 19:15 |
| Letozaf_ | elopio, yes that is true | 19:15 |
| elopio | so, on pseudocode, something like: assertEqual(get_current_article().title, 'blah') | 19:15 |
| elopio | Letozaf_: and I have a question. | 19:16 |
| elopio | are you calling ensure_list_view_mode because open_feed_item only works in list view? | 19:17 |
| Letozaf_ | elopio, yes | 19:17 |
| elopio | Letozaf_: so, what would you think about this: | 19:17 |
| elopio | - move ensure_grid_view_mode to emulators.py, probably to MainView | 19:17 |
| elopio | - on the first statement inside open_feed_item, call ensure_grid_view_mode | 19:18 |
| Letozaf_ | elopio, ok fine I will make the changes you suggested | 19:19 |
| elopio | Letozaf_: I'm throwing a lot of things to you, I hope you are not hating me :) | 19:20 |
| Letozaf_ | elopio, no instead thanks for teaching me how to do things correctly | 19:20 |
| elopio | as I said, the test is good, so if you feel that it would be better to land it and then improve it little by little, that's fine by me. | 19:21 |
| Letozaf_ | elopio, I think you are only trying to make tests better | 19:21 |
| Letozaf_ | elopio, let's do it the way you think is better :P | 19:21 |
| Letozaf_ | elopio, so I will fix it as you suggested so you can see if it's ok first | 19:23 |
| elopio | Letozaf_: yes, thanks! | 19:23 |
| Letozaf_ | balloons, o/ | 19:23 |
| Letozaf_ | elopio, ok | 19:23 |
| * elopio <- lunch break | 19:29 | |
| balloons | Letozaf_, howdy | 19:59 |
| Letozaf_ | balloons, fine and you ? | 19:59 |
| balloons | Letozaf_, sunburned, tired, good to be home :-) | 20:00 |
| elfy | hi balloons - welcome back | 20:00 |
| elfy | they brought release forward to tomorrow - hope you're realdy :p | 20:00 |
| Letozaf_ | balloons, lucky you :D | 20:00 |
| Letozaf_ | balloons, here it not hot to sun tan yet, maybe in a few weeks | 20:00 |
| balloons | elfy, :-) | 20:04 |
| === salem_ is now known as _salem | ||
| phillw | balloons: how can you forward an email for RC when the iso tracker is not RC ? | 21:27 |
| phillw | makes me look like an idiot when I take on trust emails from you and post them to social media :( | 21:28 |
| balloons | phillw, ? final RC images will come after the freeze of course | 21:42 |
| phillw | balloons: is okay.... they froze tonight, but there is no deffinate answer as to when they will make an RC... the cron should be turned off, but then who will make the build? | 21:44 |
| balloons | phillw, I expect an RC by Monday morning.. sometime between now and Monday it will get started | 21:45 |
| balloons | the earliest would be tomorrow | 21:45 |
| phillw | and, of course... release will be 17th :P | 21:45 |
| phillw | to hell with the testers.... | 21:46 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!