[07:15] Saviq, did you manage to get back to try lp:~macslow/unity-notifications/modal-snap-decisions and lp:~macslow/unity-notifications/modal-snap-decisions again after the conflict-fix with mterry' greeter-ux-fixes branch for unity8? [07:18] MacSlow, will do today [07:21] Saviq, ok... I'll turn to combobutton and the sms-class2/timeout stuff again then [08:12] Saviq: so it's not the last change that broke the carousel, removing it is still broken [08:12] and i can't go back enough to make it work again :S [08:12] tsdgeos, are we sure it did work? [08:12] which is very weird since i remember it clearly working [08:13] but it may be just fake memories [08:13] tsdgeos, right [08:13] tsdgeos, what's the bug? [08:13] ok, let's fix it anyway [08:13] Cimi: second carusel is just not drawn at all [08:13] tsdgeos, scopes bug? [08:13] no [08:14] make tryGenericScopeView [08:14] scroll down [08:14] nice empty space where teh carousel should be [08:14] scroll up again [08:14] you even lost the first carousel that was correctly shown before ^_^ [08:15] tsdgeos, lswph? [08:15] lvwph [08:15] can be [08:15] qt 5.2 [08:15] but i've reverted the changes i did lately and didn't fix it [08:15] i have memories of it working but it just doesn't [08:15] so yes, let's stop saying names and i'll have a look ;) [08:17] tsdgeos, it's not about the second carousel even [08:17] tsdgeos, just one is enough, as long as it's culled [08:17] yes [08:17] k [08:17] it's the second carousel in that test [08:18] yeah ok [08:19] tsdgeos, increasing cachebuffer affects? [08:20] uh? [08:20] tsdgeos, of the scrollable [08:20] not the carousel [08:21] let me work on it :) i'll come back when i've no more ideas [08:22] but no, that's not the problem [08:23] the carousel is being created [08:23] as needed [08:33] tsdgeos, sounds like another 5.2 fallout? [08:34] Saviq: so i know what's wrong [08:34] but i don't know what's wrong :D [08:34] i mean [08:34] if we replace [08:34] delegate: tileWidth > 0 && tileHeight > 0 ? loaderComponent : undefined [08:34] with [08:34] delegate: loaderComponent [08:34] it'll work again [08:34] oh [08:34] but i've no idea why [08:34] since tileWidth and tileHeight are correctly > 0 [08:35] trying to find out a bit more [08:35] ok, not distracting you then [08:35] :) [08:37] Saviq, wondering if we should land latest music scope, as it makes that bug quite obvious [08:37] mhr3, tsdgeos'll fix it, don't worry there :) [08:38] mhr3, anyway we can reproduce it fine [08:38] Saviq, like your "no pressure" attitude :) [08:38] but very well [08:38] mhr3, unless your question was rather "should we _not_ land it", then yeah, ideally we'd wait a bit [08:39] and land it together/after unity8 fix [08:41] alrighty [08:41] not landing until there's a fix [08:42] that branch waited for a month, it can wait few more days :P [08:42] ;D [08:42] mhr3, can we get rid of the useless "Songs" carousel from there? [08:43] Saviq, ask design :P [08:43] mhr3, I did! :P [08:43] s/ask/convince/ [08:43] bug #1237970 [08:43] bug 1237970 in Unity Media Scanner Scope "Carousel in music scope should group songs by album" [Medium,Triaged] https://launchpad.net/bugs/1237970 [08:43] * Saviq bugs mikenagle [08:43] slacker, not around [08:44] ooh apt has a cool progress bar :D [08:45] ooh and unity crashed... [08:46] Saviq, iirc displaying songs was a bandaid fix for not being able to do proper album queries, so you might get your wish afterall [08:46] mhr3, I know ;) [08:46] mhr3, but then the visuals do list "Songs" as the first category in a carousel [08:47] the visuals need updating too from time to time ;) [08:53] Saviq, the apt-progressbar is the bling of the day :) [08:53] indeed ;) [08:54] oh and one more u7 crash yay [09:19] greyback: hey. i think we are seeing a noticalbe performance hit comparing our image 250 (previous promotion) to yesterdays promotion; are ou guys aware of something that could have caused this? [09:19] thats on mako [09:19] didrocks and popey can give more details [09:19] it was mentionned in the landing email IIRC [09:20] better ask directly. maybe its known and worked on [09:20] asac: nothing that I'm aware of :( [09:20] hmm [09:21] didrocks: popey: anything special to trigger that slowdown? [09:21] quite a few moving parts have changed since 250 [09:21] didrocks: popey: is it all over the place or some specific user interaction that is slow? [09:22] greyback: in general, or also on MIR? [09:22] I'm using 293 on nexus4 - I hadn't noticed any perf hit [09:22] didrocks: popey: maybe explain where you see that perf hit. thx [09:22] asac: well mostly mir, but unity has gained the new scopes which does impact scrolling performance in the dash [09:22] asac: using the phone… [09:22] really, just use it [09:22] and compare to 250 [09:23] didrocks: is there anything killing CPU? [09:23] greyback: no, and no full memory [09:23] just use it for few minutes and you will clearly see it [09:23] even once the cache should be full [09:24] new scopes were in 250, no? [09:24] no [09:24] ok well that could indeed be contributing here then [09:24] but if its not CPU bound [09:24] then sounds really more MIR'ish, but what do i know :) [09:25] we had a Mir and an unity8 release meanwhile [09:25] we already started to get a closer image bisect range [09:26] didrocks: who is bisecting? [09:27] asac: nobody *is* [09:27] asac: when we started that, I was asked to stop [09:27] last time we did we got to: [09:27] Purely anecdotal, but #269 certainly felt much snappier than my #274 [09:27] or #275 builds in doing very simple things like swiping away the [09:27] welcome screen, and swiping up and down the apps scope. [09:27] landing email [09:27] (from popey) [09:30] I don't find any bug report though, let's see if popey got one, I thought he did, my search is probably just sucking [09:30] didrocks: there are 2 places I know of where performance has decreased [09:30] MacSlow, (how) can I mimic a modal snap decision with the create-notification.py script? [09:30] mzanetti: ah? [09:30] didrocks: for one the new-scopes, which we are aware of and working on improving it [09:31] mzanetti: so, unity8 rendering/threading with new-scopes? [09:31] didrocks: and the other is a bug that came with Qt 5.2 which impacts all sorted lists (in apps for example) [09:31] (seems to match the landing timeframe) [09:31] mzanetti: ok, here, alan is only talking about the new scopes [09:31] as #250 had 5.2 [09:31] didrocks: yeah, new-scopes still scroll badly. but we know why [09:32] and have the first optims in store already [09:32] really? I thought 250 wasn't 5.2 yet [09:32] mzanetti: any fix/workaround in progress? (I think no as it would have been done for long, right?) [09:32] mzanetti: it was 5.2 [09:32] Saviq, from AP-tests? [09:32] just not new scopes [09:32] MacSlow, I just want to manually test it [09:32] didrocks: no, didn't file a bug as I had no science, just anecdote [09:32] * Saviq looks in the MP [09:33] mzanetti: is there a bug for that one? [09:33] Saviq, just any snap-decision will do... as long as it's not happening while the greeter is shown... e.g. call yourself... without the dialer being open [09:33] MacSlow, kk [09:33] Saviq, or use any of the snap-decision examples from lp:unity-notifications/examples [09:34] MacSlow, right, k [09:34] asac: sorry, was afk, didrocks has explained it fully enough from my pov [09:35] popey: do we have a LP bug for the QSortFilterProxyModel that hits us in the Reminders app? [09:35] * mzanetti only knows about the upstream qt bug [09:36] mzanetti: I'm talking about the unity8 perf optimization needed (the one popey and I noticed, not linked to 5.2) [09:36] MacSlow, so, I should be unable to interact with the dash while ./sd-example-incoming-call.py is happening, should I? [09:36] bug 1303746 ? [09:36] bug 1303746 in Ubuntu Reminders app "Performance hit when editing sorted lists" [Critical,Triaged] https://launchpad.net/bugs/1303746 [09:38] Saviq, correct [09:38] MacSlow, then it's not working... let me try calling myself [09:38] Saviq, there should be a tinted background swallowing all input [09:38] Saviq, hm... [09:38] didrocks: don't think there is one [09:39] mzanetti: mind filing one with the details? Would be easier to track [09:39] (as you have more details than us) [09:39] MacSlow, you can branch from http://people.canonical.com/~didrocks/citrain/silos/landing-001/unity8/ [09:39] MacSlow, or take the packages from https://launchpad.net/~ci-train-ppa-service/+archive/landing-001/ [09:39] MacSlow, but let me verify [09:40] Saviq, and that has https://code.launchpad.net/~macslow/unity8/modal-snap-decisions/+merge/210988 ? [09:40] Saviq, it's not marked as "Merged" [09:40] MacSlow, sure it's not, it's only in the silo [09:40] MacSlow, it's only Merged when it's in trunk [09:40] Saviq, ah ok [09:40] MacSlow, I'm just testing before ACKing the silo [09:41] MacSlow, yeah, no worky, again - conflict with mterry's branch I'd say [09:42] MacSlow, please rebase yours on his branch and verify everything's working (and that the tests are correct... since they pass, and should catch this) [09:42] ok [09:42] MacSlow, https://code.launchpad.net/~mterry/unity8/greeter-ux-fixes/+merge/210042 [09:43] biab, testing autopilot [09:44] didrocks: https://bugs.launchpad.net/unity8/+bug/1307959 [09:44] Ubuntu bug 1307959 in Unity 8 "new-scopes need to be optimized" [Undecided,New] [09:44] mzanetti: thanks! [10:02] wow, not sure if true, but seemed that router got into a state that it was sending packets to my laptop that make the wireless driver crash [10:02] asac: didrocks: sorry I dropped offline just over 30 mins ago [10:03] greyback: basically, we are talking about https://bugs.launchpad.net/unity8/+bug/1307959 [10:03] Ubuntu bug 1297197 in unity8 (Ubuntu) "duplicate for #1307959 New scopes performance needs to be improved" [High,Triaged] [10:03] didrocks: okay, thanks for update [10:04] if I can help in any way, let me know [10:21] Saviq, I'm not sure if it's related... but I've added ppy:ci-train-ppa-service/landing-001 to my N4 setup and unity-notifications is nowhere to be found [10:25] Saviq, that said... modal snap-decisions do work for me though using that landing-001 silo-ppa [10:26] Saviq, non-blocking when on the greeter... blocking when greeter isn't shown... just as design requested [10:26] it always freaks me out when i run unity8 on desktop and i start receiving all notifications in there :) [10:27] mhr3, yeah.. .that's odd indeed :) [10:34] Saviq, ignore the mentioned issue with the unity-notifications... after a reboot of the phone they did show up via "apt-cache policy ..." [10:35] tsdgeos, I am testing your branch [10:35] tsdgeos, but it seems I probably found other bugs [10:35] like? [10:35] tsdgeos, with your branch I mean the position at beginning [10:35] yes [10:35] tsdgeos, for example, I am in app scope [10:35] like which bugs? [10:36] tsdgeos, I expand apps and scroll down to hide the header === MacSlow is now known as MacSlow|lunch [10:36] tsdgeos, then I swipe from right to left to change to music scope [10:36] tsdgeos, the header lags then it appears [10:36] tsdgeos, I go back to apps scope and redo the same thing, the header is partially shown [10:36] ? [10:37] what do you mean with "lags"? [10:37] tsdgeos, I see it skipping frames [10:37] animate maybe [10:38] tsdgeos, sending on whatsapp [10:39] Cimi: well, just see if it happens without my patch [10:39] or not [10:39] tsdgeos, it does with and without [10:40] i sincerely don't see any lagging :D [10:40] minute:second? [10:40] tsdgeos, not now, just first run [10:40] MacSlow|lunch, hmmpf [10:40] tsdgeos, anyway, you see it is not fully shown [10:40] tsdgeos, see last seconds when I scroll down [10:41] and the header fully appears [10:41] i see [10:41] MacSlow|lunch, oh, I think I know why... I didn't upgrade the notifications plugin... [10:41] tsdgeos, also [10:41] that may be because of my patch, not sure [10:41] tsdgeos, another bug [10:41] tsdgeos, go in scopes scope [10:42] previously we were showing all the headers and now i only show the one of the list we are seeing [10:42] tsdgeos, run an app from launcher, like system settings [10:42] that is the one you care about in reality [10:42] tsdgeos, reveal launcher and tap the home button [10:42] tsdgeos, the header shows "app scope" but we're still in the scopes scope [10:44] Cimi: please check if those happen or not without my patch and write it in the MR so i remember what i have to fix [10:44] otherwise i'll forget :) [10:44] if they still happen with my patch, open a bug so i don't forget about those either :D [10:45] mzanetti, https://code.launchpad.net/~macslow/unity-api/expose-notification-data-roles-to-qml/+merge/212581 should've had an unity-notifications- version bump, please remember about those [10:46] mzanetti, in the .pc file [10:46] oh... :/ sorry. yes, will try to remember [10:47] tsdgeos, sent you the video of the second bug [10:47] tsdgeos, whatsapp encodes automatically, handy :) [10:48] mzanetti, as punishment, you get to try and reproduce bug #1307634 ;) [10:48] bug 1307634 in Unity 8 "Crash When Using Phone" [Undecided,New] https://launchpad.net/bugs/1307634 [10:48] mzanetti, since the one I thrown at you yesterday got snatched by mterry [10:48] Saviq, throw me bugs [10:48] ah nice. [10:49] Cimi, bug #1301038 for you [10:49] bug 1301038 in Unity 8 "TimeFormatterTest does not set environment properly." [Medium,Triaged] https://launchpad.net/bugs/1301038 [10:53] tsdgeos, sorry, you'll have to remind me again on why we did not want LANG=C for tests ↑? ;D [10:53] tsdgeos, and ideally comment on the bug? [10:53] Saviq: you mean why you did not want it :D [10:54] tsdgeos, we're a team! [10:54] ;P [10:54] Saviq: ;.) [10:54] Saviq: it's not that we did not want it [10:54] fyi: jenkins does export this to workaround an issue with autopilot debug prints [10:54] not sure if its still required [10:54] Saviq: it's that we could not decide wheter to put it as env in the make call or as setenv in the code itself [10:54] Saviq: so we statusquo'ed by doing nothing [10:54] tsdgeos, right ;) [10:57] MacSlow|lunch, ok, darkening I have, but I can still tap apps behind the darkening [10:58] * Saviq writes stuff down on the MPs [11:07] ok, qt bug found [11:07] \o/ [11:07] now i only need to create a testcase bla bla bla === _salem is now known as salem_ [11:17] tsdgeos, tried with 5.3? [11:18] bug is still there in the code [11:18] in 5.3 [11:18] ok [11:18] it's an obvious mistake after you read the code [11:18] i have that right in the LVWPH code [11:19] they are basically not accounting for setting a delegate to null on creation and non null after everything has been setup [11:19] need the test though [11:19] working on that now [11:19] tsdgeos, so the header scrolling bug is present with the devel proposed image as well [11:20] tsdgeos, not the second one with the scope [11:20] testing [11:20] interesting === salem_ is now known as _salem [11:23] tsdgeos, cannot reproduce it anymore [11:23] tsdgeos, but you saw the video :) [11:23] Cimi: i think it is this [11:24] https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1297770 [11:24] Ubuntu bug 1297770 in unity8 (Ubuntu) "Scopes scroll down till header goes seems to lock the scope in place" [High,Confirmed] [11:24] or similar [11:31] and the testcase http://paste.ubuntu.com/7254748/ [11:33] Trevinho, hi [11:33] Trevinho, there seems to be some problem with window placement, the titlebar often appears below the top panel [11:33] bug 1308005 [11:33] bug 1308005 in unity (Ubuntu) "[regression] no way to close tall windows as they appear below top panel" [Undecided,New] https://launchpad.net/bugs/1308005 === Malsasa_ is now known as Malsasa [11:40] andyrock, ^ === alan_g is now known as alan_g|afk [11:49] tsdgeos, same bug [11:49] tsdgeos, I can launch an app [11:50] tsdgeos, from the scopes when the header is shown but I scrolled down [11:50] tsdgeos, and I can see only the header changing [11:51] Saviq, hm, seems like the slowness of scrolling in apps is partially caused by the art rescaling [11:51] plus masking [11:51] mhr3, well, sure [11:51] mhr3, all the complexity of the card has impact [11:52] Saviq, it's just odd that when the icon is smaller the perf is worse [11:53] mhr3, that's because there's more of them on screen probably [11:53] since a smaller art means less vertical space taken by any given card === alan_g|afk is now known as alan_g [11:55] Saviq, dunno, feels like there's more to it === Malsasa_ is now known as Malsasa [11:55] mhr3, what we need to do is just build a library of smallest-possible card configurations to cater for all the supported cases (which we ~wanted anyway) [11:56] mhr3, this way they won't be as complex [11:57] it's also taking away the power for scope authors [11:58] mhr3, no no [11:59] mhr3, nothing would change scope-side [11:59] mhr3, we need to build a library that really supports all the possible combinations (that we support, not as in the ones listed in dash spec, but basically all) [12:00] mhr3, we'd still accept the configuration as it is now (and optionally a choice from a library later) [12:00] mhr3, and well, ultimately we can just leave Card as is, and fall back to it [12:00] mhr3, while selecting simpler delegates for the ones we want it makes sense to [12:01] hm, so js workaround? [12:01] mhr3, not a workaround ;) [12:01] totally a workaround :P [12:01] mhr3, no, not a workaround [12:02] in an app card [12:02] we have: mascot, subtitle, summary, emblem → all invisible [12:02] but existent nevertheless [12:02] background, too [12:03] which means they are consuming resources, even though we know they'll never be used [12:03] but none of those are used, there should be 0 overhead for such things [12:03] mhr3, but there can't be [12:03] mhr3, they need to be created [12:03] mhr3, sure, they're not uploaded to the GPU [12:04] mhr3, but they're still objects in the QML tree, their properties are still evaluated [12:04] Saviq: hmm... so, I can reproduce the black screen with outdated launcher entries, however it doesn't crash unity here but recovers on any edge gesture [12:04] mhr3, sure, the first thing we do is: https://code.launchpad.net/~aacid/unity8/card_optimizations/+merge/213660 [12:04] couldn't get anything out of the attached crash file. (crashes GDB here when trying to load :D ) [12:04] mhr3, making it so that they're not loaded, shaving off ½ off the time for an app tile creation [12:05] mzanetti, yeah, the .crash files are stupid [12:05] mzanetti, so... tried devel (not -proposed) image? [12:05] mzanetti, as that's what Rick was using, and I believe that's where Dave confirmed the crash [12:06] ah.. right... that might be one revision lower [12:06] Saviq, so shouldn't that solution be good enough? [12:06] mhr3, depends, we'll have to compare how much overhead is there for just the Loaders [12:06] * mzanetti tries to reproduce on the dogfooding phone [12:06] Saviq, i mean, clearly it isn't, but that just makes me think we're missing something [12:07] mzanetti, devel is 250 [12:07] mzanetti, not "one revision lower" [12:07] but some 38 revisions lower [12:07] Saviq: no.. not any more [12:07] mzanetti, oh, so we got a promoted image did we? [12:07] mzanetti, still, that was 250 Rick got it on [12:07] Saviq: and how I read the bug it happened after upgrading from 250 to the new promoted one [12:07] oh ok [12:07] which explains the outdated launcher entries [12:08] kinda [12:08] I recreated them manually by writing account-settings [12:08] click updates are unrelated to image updates [12:08] can reproduce the black screen he's talking about [12:08] but doesn't crash it [12:08] mhr3, well "clearly it isn't" we don't know yet, we need to compare how much overhead is that to a plan image + text tile [12:09] mhr3, and then try to shave off even more === alan_g is now known as alan_g|lunch [12:09] mhr3, so all in all, yes, it needs investigation still, but saying "invisible things should have 0 overhead" is rather extreme ;) [12:10] i.e. impossible to achieve :P [12:10] Saviq, i like setting "proper" goals ;) [12:10] unless invisible == nonexistent [12:10] «proper» [12:13] mzanetti, try with image 250, I really think that's where it happened [12:13] mzanetti, the bug was filed before the new image was promoted, AFAICT [12:14] mzanetti, or well, the .crash could have been unrelated / previous [12:15] mzanetti, but https://bugs.launchpad.net/unity8/+bug/1307634/comments/4 does mention #250 [12:15] Ubuntu bug 1307634 in Unity 8 "Crash When Using Phone" [Undecided,New] [12:16] jeez /me really needs to land this thing... [12:30] elopio, hey, can you please run http://people.canonical.com/~msawicz/unity8/strip-u8-tags.sh on lp:~elopio/unity8/error_on_missing_url-dispatcher [12:31] alesage, and you, can you please run http://people.canonical.com/~msawicz/unity8/strip-u8-tags.sh on lp:~allanlesage/unity8/dash-apps-visible-ordering [12:31] dednick, ↑ same on lp:~nick-dedekind/unity8/remove-indicatormanager-upstart [12:31] oh elopio, one more of yours: lp:~elopio/unity8/use_fake_instead_of_messaging === jhodapp|afk is now known as jhodapp [12:52] Cimi: maybe comment it on the bug too just in case when we fix it ? [12:55] I'll test again when we will have a branch with the fix [12:55] to make sure both work [12:55] do you guys use imap for the canonical email? [12:56] suddenly it's failing for me [12:56] says invalid credentials === alan_g|lunch is now known as alan_g [12:58] tsdgeos, I am, not through gmail, though [12:59] right [13:02] what? [13:02] works now [13:02] with my old password for canonical [13:02] * tsdgeos confused [13:03] greyback_: Is there any reason we don't use qdbusxml2cpp to generate the interface? [13:04] greyback_: from dbus xml -> cpp [13:04] paulliu: tsdgeos is the author of that bit of code, best ask him. [13:05] I'm assuming you're asking about the dbus interface in unity-mir === greyback_ is now known as greyback|lunch [13:08] tsdgeos: ^^^^ === MacSlow|lunch is now known as MacSlow [13:09] Cimi: ; added [13:09] tsdgeos, th [13:09] x [13:10] paulliu: which interface? [13:11] tsdgeos: I'm adding a new dbus methods for people to use. But I noticed that the dbuswindowstack.cpp is coded by hand. [13:11] tsdgeos: So I'm wondering that if there's any policy that we want to code it by hand rather than using the generator. [13:11] paulliu: what is "by hand"? [13:12] tsdgeos: qdbusxml2cpp can read the dbus xml file and generate an interface.cpp for it. So if we add more methods we can just add it to the xml file. [13:13] paulliu: what code of dbuswindowstack.cpp would you save implementing by doing so? [13:15] besides do we have a dbus xml file for that interface? [13:16] tsdgeos: No code saving I think. But would be easier to use the generator. Especially it generates the Introspection which can be used for qdbus command line. [13:16] tsdgeos: no. [13:16] tsdgeos: So if it is not forbidden. Can I use that tool to generate the interface? [13:16] tsdgeos: Because I got the an xml file from unity7. [13:17] paulliu: i'm not maintener of that code :D [13:17] tsdgeos: ok [13:17] i can not see any need to do so for the dbuswindowstack.cpp [13:17] if you see a reason for the new code you're doing and can justify it in a review request [13:17] i don't see why not [13:18] tsdgeos: ok. thanks~ [13:18] but again i'm not deciding on that piece of code, that's gerry ;) [13:19] paulliu: there was some argument in the past === greyback|lunch is now known as greyback [13:19] over if we wanted to have the file that qdbusxml2cpp generates commited in the bzr or created on runtime [13:19] not sure how that ended though [13:19] paulliu: I don't have a strong opinion on it. I'll welcome using qdbusxml2cpp if you write it :) [13:20] note unity8 uses qdbusxml2cpp already [13:20] see ./plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp [13:30] Saviq, on https://bugs.launchpad.net/unity8/+bug/1301038 tsdgeos is right we do have a caveat in the CODING file, to run make test with LC_ALL=C [13:30] Ubuntu bug 1301038 in Unity 8 "TimeFormatterTest does not set environment properly." [Medium,Triaged] [13:31]