| === oCrazyLemn is now known as CrazyLemon | ||
| mlankhorst | Hello, world!\n | 07:26 |
|---|---|---|
| seb128 | good morning desktopers | 08:02 |
| mlankhorst | hai | 08:02 |
| Laney | yo | 08:04 |
| mvo | hey seb128 | 08:06 |
| seb128 | mvo, hey ;-) wie gehts? | 08:06 |
| mvo | and good morning mlankhorst and Laney | 08:06 |
| seb128 | same! | 08:06 |
| mvo | seb128: good, thanks. looking at upgrade bugs | 08:06 |
| mvo | that is medium fun but important :) | 08:07 |
| * mvo makes up for it by drinking huge amounts of tea | 08:08 | |
| mvo | (to add fun ot it I mean) | 08:08 |
| Laney | never upload chromium | 08:08 |
| Laney | to be more precise, don't subscribe to its bugs | 08:09 |
| seb128 | Laney, living the life of the maintainer of a popular (and buggy) application? ;-) | 08:09 |
| Laney | a maintainer who has an overused "mark all as read" button :P | 08:10 |
| seb128 | lol | 08:10 |
| mvo | haha - or a worn out "d" key | 08:11 |
| Laney | I've got a script which subscribes me to bug mail for packages I upload | 08:13 |
| Laney | which is fine most of the time, but not when I upload chromium just to change a recommends to a suggests | 08:13 |
| mvo | *cough* | 08:13 |
| pitti | bonjour seb128 | 08:13 |
| pitti | hey mvo | 08:13 |
| pitti | morning Laney | 08:14 |
| pitti | hey mlankhorst! | 08:14 |
| mvo | hey pitti | 08:14 |
| Laney | guten morgen pitti | 08:14 |
| pitti | I should check this channel more often :) | 08:14 |
| mvo | its good fun here | 08:14 |
| Laney | was ist los? | 08:15 |
| seb128 | pitti, guten tag! wie gehts? | 08:15 |
| mlankhorst | hai | 08:15 |
| pitti | seb128: mediocre, caught a cold :( | 08:15 |
| seb128 | pitti, :-( | 08:15 |
| seb128 | pitti, get better! I hope it's over for the easter w.e | 08:15 |
| pitti | but yesterday was fun, we went to the Munich theater to see the West Side Story (my wife's bday present) | 08:15 |
| mvo | pitti: oh, get well! | 08:15 |
| seb128 | pitti, oh, nice | 08:15 |
| pitti | I hadn't seen that before | 08:16 |
| pitti | with an original NY theater cast | 08:16 |
| === tkamppeter_ is now known as tkamppeter | ||
| seb128 | didrocks, see, pitti seems to like croissants au chocolat, he +1ed my post! | 08:26 |
| pitti | seb128: oui, je les aime ! | 08:26 |
| didrocks | yeah, I had to reflect reality and just answered! | 08:26 |
| seb128 | pitti, moi aussi, mais le pauvre Didier ne connaît pas les croissants au chocolat | 08:26 |
| didrocks | it's clearly a German thing | 08:26 |
| seb128 | he says that they don't have those in Lyon | 08:27 |
| pitti | comment est-ce c'est possible ? | 08:27 |
| pitti | "que" | 08:27 |
| didrocks | seb128: we have french cuisine in Lyon! | 08:27 |
| didrocks | only things on THE list :) | 08:27 |
| seb128 | pitti, je ne sais pas non plus, dommage pour eux :/ | 08:27 |
| pitti | seb128: mais du gâteau de rhubarbe est encore mieux :) | 08:28 |
| didrocks | rhubarbe… pas très fan ici | 08:28 |
| seb128 | gâteau ou tarte ? | 08:28 |
| seb128 | tarte à la rhubarbe ! | 08:28 |
| pitti | seb128: ma femme a fait le tarte pour mon anniversaire, yummy | 08:29 |
| seb128 | pitti, une tarte à quoi ? à la rhubarbe ? | 08:30 |
| seb128 | c'est pas encore la saison, si ? | 08:30 |
| pitti | oui | 08:30 |
| pitti | seb128: non, nous pouvons acheter de la rhubarbe dans nos "market" | 08:30 |
| pitti | seb128: de avril à juin | 08:32 |
| pitti | seb128: c'était un printemps tôt :) | 08:32 |
| seb128 | pitti, tu as raison ;-) | 08:33 |
| didrocks | dbarth: I think alex_abreu, Laney and you talked about the migration script which readded the amazon entry in launcher if people have removed it. Is that fixed now? | 09:39 |
| Laney | don't think so, but alex_abreu said he thought he knew what to do | 09:40 |
| dbarth | what's the bug num. for that one? | 09:41 |
| Laney | Don't know, I asked him on irc yesterday | 09:41 |
| dbarth | hmm ok | 09:42 |
| didrocks | Laney: dbarth: this needs to be fixed before we release trusty though | 09:42 |
| didrocks | (and should go on -updates) | 09:42 |
| dbarth | and the issue is that the amazon launcher comes back | 09:42 |
| Laney | yup | 09:42 |
| * didrocks can already imagine the bad PR with "Canonical forces amazon in the launcher where I removed it" | 09:42 | |
| didrocks | the solution is really easy | 09:42 |
| dbarth | oh no, please ;) | 09:42 |
| didrocks | just put back the script to the older name | 09:42 |
| dbarth | right | 09:42 |
| didrocks | so, people transitionned are already transitionned | 09:42 |
| didrocks | for the new part of the script | 09:43 |
| didrocks | brings a second script with a new name | 09:43 |
| didrocks | but don't mix both in the same script | 09:43 |
| dbarth | hmm, taking a look | 09:43 |
| Laney | what changed? | 09:43 |
| didrocks | so people on past LTS won't get it added | 09:43 |
| didrocks | Laney: the name of the script | 09:43 |
| didrocks | so never seen -> executed | 09:43 |
| Laney | I mean in the script | 09:43 |
| didrocks | Laney: I didn't check yet | 09:43 |
| Laney | okay | 09:44 |
| didrocks | was hoping to bring the topic and having people with more knowledge knowing :) | 09:44 |
| seb128 | https://launchpad.net/ubuntu/+source/webapps-applications/2.4.17+14.04.20140411-0ubuntu1 | 09:44 |
| Laney | well, then we could take the opportunity to do my fix from yesterday | 09:44 |
| seb128 | * Update session migration script to remove all the cruft | 09:44 |
| seb128 | ~/.local/share/applications by supported webapps | 09:44 |
| Laney | and avoid having that grimy dependency on libunity-core-whateveritis | 09:44 |
| dbarth | yup | 09:44 |
| dbarth | Laney: this one landed i think | 09:44 |
| Laney | I know | 09:44 |
| Laney | I suggested an IMO nicer fix to check that at runtime instead | 09:45 |
| dbarth | https://bugs.launchpad.net/ubuntu/+source/webapps-applications/+bug/1308076 | 09:45 |
| ubot2 | Launchpad bug 1308076 in webapps-applications (Ubuntu) "/usr/share/session-migration/scripts/install-default-webapps-in-launcher-and-cleanup-local.py:5:g_settings_set_property:object_set_property:g_object_new_internal:g_object_new_valist:g_object_new" [High,Fix released] | 09:45 |
| dbarth | ah i see | 09:45 |
| seb128 | Laney, can you handle that/make sure the fix land? | 09:45 |
| Laney | can do | 09:45 |
| dbarth | well, so you want to change robru's fix with another one? | 09:45 |
| Laney | dunno | 09:45 |
| dbarth | i don't mind, that's packaging black magic to me | 09:45 |
| dbarth | as long as it covers more bases | 09:46 |
| Laney | I like it more, but who knows | 09:46 |
| Laney | he said he thought it was still technical debt, not sure I agree | 09:46 |
| Laney | anyways we can do the first fix I guess | 09:46 |
| dbarth | and so the first fix landed afaict | 09:47 |
| Laney | unrenaming the script | 09:47 |
| Laney | and doing the new part in a second one | 09:47 |
| dbarth | yeah, marked as landed in citrain | 09:47 |
| dbarth | ok | 09:47 |
| dbarth | now on to the amazon one | 09:47 |
| Laney | I wonder if I should rename the "new" script | 10:06 |
| Laney | install-... isn't what it does now | 10:06 |
| Laney | Will do, it shouldn't be bad to run it an extra time | 10:07 |
| didrocks | dbarth: btw, not sure it was discussed, but this is now broken with the new webapps: http://developer.ubuntu.com/web/tutorial/ | 10:07 |
| didrocks | dbarth: if a website is setting a userscript on their site to show a webapps, from what I heard (didn't try myself), it won't be shown | 10:08 |
| Laney | didrocks: a bad exit code means a script will be re-run the next time, yes ? | 10:17 |
| Laney | but no error or anything like that | 10:17 |
| didrocks | Laney: right | 10:17 |
| Laney | ok | 10:18 |
| didrocks | g_printerr("Exited with an error\nstdout: %s\nstderr: %s\n", stdout, stderr); | 10:18 |
| didrocks | in logs | 10:18 |
| Laney | It's "the schema isn't installed, don't do anything but try again next time" | 10:18 |
| Laney | == sys.exit(1) | 10:18 |
| didrocks | sounds good :) | 10:19 |
| Laney | cheers | 10:20 |
| Laney | seb128: dbarth: https://code.launchpad.net/~laney/webapps-applications/dont-readd-launcher-icon/+merge/216057 please to review | 10:27 |
| Laney | I just copied the old script back | 10:28 |
| Laney | and removed that part of the new one | 10:28 |
| dbarth | uh, faster | 10:28 |
| Laney | hmm | 10:28 |
| Laney | ? | 10:28 |
| didrocks | (looks like from what you tell is the right strategy to me) | 10:29 |
| seb128 | Laney, didrocks, dbarth: looks fine to me as well | 10:32 |
| Laney | I saw that you suggested this runtime check too | 10:33 |
| Laney | on the original bug report | 10:33 |
| Laney | ;-) | 10:33 |
| dbarth | yup +1 | 10:33 |
| dbarth | adding a silo request | 10:34 |
| Laney | ok well if you want to get it trained into the queue then there's a minor chance of it being accepted | 10:35 |
| Laney | otherwise 0-day sru which is fine | 10:35 |
| Sweetshark | *grumble* *grumble* fscking logscreen forces me to kill my debugging session and loose a trillion carefully planted breakpoints. A logscreen that lets me Alt-Tab though apps (which are not shown of course), but not unlock the screen is ... not helpful. | 10:35 |
| Laney | Sweetshark: what unity version is running? can you reproduce it? | 10:35 |
| dbarth | thanks Laney | 10:36 |
| Laney | np | 10:36 |
| Sweetshark | unity 7.2.0+14.04.20140404-0ubunt(here the terminal ran out of chars) | 10:38 |
| Laney | Try upgrading ;-) | 10:39 |
| Sweetshark | Laney: I have no welldefined reproduction scenario, but its not the first time this happened. | 10:39 |
| Laney | Lots of issues like that were fixed in >> 0404 | 10:39 |
| Laney | man that chromium notifications indicator is ugly | 10:43 |
| seb128 | Laney, getting used to be the chromium maintainer? ;-) | 10:43 |
| qengho | Laney: :( | 10:45 |
| * Laney hugs qengho | 10:45 | |
| Laney | qengho: Is the indicator an upstream thing or something you've done? | 10:47 |
| Laney | Sorry for sounding mean :( | 10:47 |
| qengho | Laney: It's not me. Don't feel bad for that. | 10:51 |
| Laney | In that case I don't know what a Chromium notification is or why I need an indicator for it the whole time :-) | 10:52 |
| qengho | Laney: Can you show me a screenshot? | 10:53 |
| Laney | qengho: http://ubuntuone.com/0Ejd0uop0SwgC8HLiR7hUL | 10:56 |
| Laney | (I'll miss being able to do that) | 10:56 |
| === MacSlow is now known as MacSlow|lunch | ||
| seb128 | Laney, how did you activate that? | 11:14 |
| Laney | I have no idea | 11:15 |
| Laney | not on purpose | 11:15 |
| Laney | Maybe it was when I got a notification on Twitter (I'm using tweetdeck inside chromium) | 11:16 |
| qengho | Laney: I have honestly never seen that. I have seen little pop-up windows in bottom-right corner, and I was going to agree they're ugly. | 11:17 |
| Laney | Someone send me a tweet :-) | 11:17 |
| * Laney posts something controversial | 11:17 | |
| seb128 | lol | 11:17 |
| didrocks | I guess seb128 already did on g+ | 11:18 |
| seb128 | roh | 11:18 |
| * Laney doesn't have seb128 there :-o | 11:19 | |
| didrocks | Laney: you are just missing some fake photos :p | 11:20 |
| Laney | it's like the moon landing right | 11:20 |
| seb128 | didrocks, you are loosing on that post, we are 3 to say "yummy" and you are alone to say "fake" | 11:20 |
| Laney | he just faked it up in a studio | 11:20 |
| didrocks | seb128: hum, that's not what Julie is saying | 11:20 |
| didrocks | Laney: exactly! | 11:20 |
| seb128 | didrocks, you both are counting for 1 :p | 11:20 |
| didrocks | roh | 11:21 |
| seb128 | didrocks, I don't want to say anything but Julie just admitted on the same post that you eat cat food | 11:22 |
| didrocks | seb128: I saw that, but it seems you don't understand irony :p | 11:22 |
| didrocks | bad for you ;) | 11:22 |
| seb128 | tssss | 11:23 |
| Laney | didrocks / seb128: want to check landing-004 doesn't re-add icons for you? | 11:24 |
| seb128 | didrocks, btw I saw Julie (the real one on TV, with a "e" in the name :p) cooking some of those pink stuff on TV yesterday | 11:25 |
| seb128 | Laney, on it | 11:25 |
| didrocks | seb128: ahah ;) | 11:28 |
| rickspencer3 | seb128, what's the word on the street regarding trusty? everything looking good? | 11:28 |
| seb128 | rickspencer3, there were some rounds of bugfixes/respin since yesterday (mostly langpack install issues), but things look under control/good | 11:29 |
| Laney | Still another go around for that problem | 11:30 |
| Laney | OEM installs getting the wrong language settings | 11:30 |
| * seb128 test Laney's migration script fix, session restart, brb | 11:30 | |
| Laney | Seems to be under control though | 11:30 |
| rickspencer3 | well, tomorrow is release day ... | 11:30 |
| Laney | Yup, fix is uploaded | 11:31 |
| rickspencer3 | Laney, seb128 so sounds like one last respin for desktop today? | 11:31 |
| Laney | AIUI, but I'm not in the room | 11:31 |
| seb128 | rickspencer3, hopefully one and we are good yes | 11:31 |
| rickspencer3 | nice | 11:31 |
| Laney | other than that it's pretty good I think | 11:32 |
| seb128 | Laney, no icon added after a session restart | 11:34 |
| Laney | cool | 11:34 |
| Laney | thanks for checking | 11:34 |
| Laney | new kettle! | 11:35 |
| seb128 | yw | 11:35 |
| * Laney MPs a gsettings-qt symbols file | 11:37 | |
| Laney | dbarth: do you want to check 004? | 11:54 |
| Laney | I'd like to publish it quickly so it has a chance of going in | 11:54 |
| Laney | doing this now ;-) | 11:58 |
| dbarth | Laney: sure | 11:58 |
| dbarth | just doing now (removed amazon first) | 11:59 |
| Laney | I think you might get it readded if you installed in the 5 days since the script was renamed | 12:01 |
| Laney | but that's probably acceptable | 12:01 |
| dbarth | just re-starting my session to make sure | 12:01 |
| didrocks | Laney: yeah, it's the "risk" of running a development release :) | 12:02 |
| didrocks | (seems acceptable if we only had those kind of issues :p) | 12:03 |
| dbarth | Laney: ok, that's a land then | 12:04 |
| dbarth | landing | 12:04 |
| dbarth | well, anyway | 12:04 |
| Laney | dbarth: thanks, already pressed the button ;-) | 12:04 |
| Laney | cheers for checking | 12:05 |
| dbarth | see that | 12:05 |
| Laney | on that note, going to lunch | 12:05 |
| dbarth | Laney: the icing on the cake is that i don't even have to ping the release team about the unapproved queue ;) | 12:05 |
| Laney | will walk to the cafe in the sun, nice day for it :-) | 12:05 |
| dbarth | Laney: yup, enjoy | 12:06 |
| didrocks | Laney: don't take any croissant please! | 12:06 |
| === MacSlow|lunch is now known as MacSlow | ||
| === Sweetsha1k is now known as Sweetshark | ||
| Sweetshark | Laney: FWIW libreoffice autopkgtest magically self healed: https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-libreoffice/ | 13:16 |
| Laney | Sweetshark: witchcraft? | 13:19 |
| seb128 | time for some exercice, bbiab | 13:20 |
| Sweetshark | Laney: "any sufficiently advanced technology is indistingushable from magic" | 13:22 |
| Sweetshark | Laney: teaches you something about how advanced LibreOffice is ;) | 13:22 |
| alex_abreu | Laney, didrocks https://code.launchpad.net/~abreu-alexandre/webapps-applications/dont-forcefully-add-amazon-webapp/+merge/216100 | 13:31 |
| Laney | alex_abreu: thanks - we already uploaded something similar to that earlier to try and get it into the release | 13:36 |
| Laney | check the trusty-proposed branch | 13:36 |
| Laney | but in that one we restored the old script to add the launcher entry too | 13:37 |
| alex_abreu | Laney, yeah sorry for the delay, was busy w/ other things | 13:37 |
| Laney | you think that's not needed? | 13:37 |
| alex_abreu | Laney, mmmh yeah yours is better actually | 13:40 |
| Laney | ok | 13:40 |
| alex_abreu | Laney, why do you remove libunity-core ? | 13:40 |
| Laney | added a runtime check for it instead | 13:40 |
| alex_abreu | Laney, the SettingsSchemaSource ? | 13:41 |
| Laney | y | 13:41 |
| Laney | a | 13:41 |
| alex_abreu | ok +1 | 13:41 |
| Laney | avoids having that fugly dependency | 13:41 |
| Laney | :) | 13:41 |
| alex_abreu | agree | 13:41 |
| Laney | wowzers, my PC's locked up hard | 13:46 |
| Laney | all I did was try the G+ webapp | 13:46 |
| Laney | twice now | 13:57 |
| Laney | someone else want to try this? | 13:57 |
| Laney | using nouveau if that helps | 13:58 |
| Laney | mlankhorst: maybe you | 13:58 |
| Laney | http://paste.ubuntu.com/7261615 http://paste.ubuntu.com/7261622 | 14:00 |
| mlankhorst | card's dead | 14:04 |
| mlankhorst | oh looks like fun corruption | 14:04 |
| mlankhorst | and a newer card than I have :P | 14:05 |
| Laney | card specific? | 14:05 |
| mlankhorst | no idea | 14:05 |
| Laney | launch the G+ webapp and use it a bit | 14:05 |
| Laney | eventually (< 1 min) it locks my system up | 14:05 |
| mlankhorst | looks like the real fun is in 'Unknown handle 0x0000001f' which means that the kernel disagrees with userspace about whether some buffers are valid or not | 14:05 |
| === JanC_ is now known as JanC | ||
| mlankhorst | Laney: can I run it from the command line? | 14:29 |
| Laney | Exec=unity-webapps-runner -n 'R29vZ2xlUGx1cw==' -d 'plus.google.com' --store-session-cookies %u | 14:30 |
| Laney | that's what the desktop file runs | 14:30 |
| mlankhorst | no crash yet | 14:59 |
| Laney | I never managed to get signed in | 14:59 |
| Laney | time to expense a new card! | 14:59 |
| mlankhorst | just as i finished typing it.. | 15:03 |
| mlankhorst | :/ | 15:03 |
| Laney | you got it? | 15:03 |
| xclaesse | what's the facebookmessenger app that keep coming back into my launchers | 15:03 |
| mlankhorst | Laney: yeah after i hit enter on 'no crash yet' | 15:04 |
| Laney | well, that's promising | 15:04 |
| Laney | as in, if anyone in the team can fix it :P | 15:04 |
| mlankhorst | no! It's downright terrible.. | 15:04 |
| qengho | xclaesse: Hrm. $ grep face ~/.config/autostart/* | 15:04 |
| xclaesse | qengho, nothing | 15:04 |
| qengho | xclaesse: How often does it "keep coming back"? | 15:05 |
| xclaesse | that app seems completely useless, it just dispaly the same facebook than I have in firefox already | 15:06 |
| xclaesse | qengho, literraly every time I'm not looking | 15:06 |
| qengho | Oh, a web-app maybe? | 15:06 |
| xclaesse | ah ok, each time I reload facebook tab in firefox | 15:07 |
| xclaesse | that facebook icon appear in the launchers | 15:07 |
| Laney | uh, yeah, that happens here too | 15:10 |
| Laney | also for other webapps | 15:11 |
| Laney | alex_abreu: do you know about this? | 15:11 |
| mlankhorst | Laney: bleh I suspect something that valgrind will turn up anyway | 15:11 |
| * qengho thinks hard about Valgrind on GPUs. | 15:12 | |
| alex_abreu | Laney, mmmh no | 15:12 |
| mlankhorst | qengho: no it's a handle issue, some handle is annotated by userspace but the handle is invalid :P | 15:13 |
| Laney | alex_abreu: ok, I'll file it, which package is the firefox webapps integration? | 15:17 |
| alex_abreu | Laney, unity-firefox-extension | 15:17 |
| Laney | ty | 15:17 |
| === m_conley_away is now known as m_conley | ||
| seb128 | Laney, xclaesse, alex_abreu: I guess that's how I got the amazon icon back on my launcher the other day btw | 15:18 |
| seb128 | Laney, since I didn't have webapps-applications-common installed | 15:18 |
| Laney | maybe | 15:19 |
| Laney | I can't trigger it with amazon but could be | 15:19 |
| seb128 | Laney, I had it after visiting your kettle stuff I think | 15:20 |
| Laney | try again? | 15:20 |
| seb128 | yeah, I couldn't reproduce | 15:20 |
| Laney | I guess you can do with facebook or g+ though | 15:20 |
| seb128 | but I can't reproduce on fb either | 15:20 |
| Laney | huh | 15:20 |
| seb128 | no | 15:20 |
| seb128 | it seems to depends of the url | 15:20 |
| seb128 | or how you access the site | 15:20 |
| seb128 | not sure | 15:20 |
| Laney | I just go to facebook.com in firefox | 15:20 |
| Laney | not logged in if that makes a difference | 15:21 |
| seb128 | yeah, can't reproduce... | 15:21 |
| Laney | oh well | 15:21 |
| seb128 | that made amazon listed first in my dash as most recently used though | 15:22 |
| seb128 | (trying on amazon) | 15:22 |
| mlankhorst | Laney: yeah freed memory use in egl_gallium, probably the cause of this bug :P | 15:24 |
| Laney | that's usually inadvisable | 15:24 |
| mlankhorst | can't look further, no debug symbols yet | 15:24 |
| mlankhorst | ok tomorrow :P | 15:27 |
| Laney | bug #1308625 | 15:29 |
| ubot2 | Launchpad bug 1308625 in unity-firefox-extension (Ubuntu) "Visiting a website with a webapp re-adds the launcher icon every time" [Undecided,New] https://launchpad.net/bugs/1308625 | 15:29 |
| Laney | I don't remember what, if anything, I picked when it asks you if you want to 'install' the site | 15:30 |
| Laney | or how to get that choice back | 15:30 |
| seb128 | Laney, I can confirm your issue btw | 15:31 |
| Laney | which one? | 15:31 |
| seb128 | Laney, I had the webapp integration disable, I did that ages ago, I didn't remember it | 15:31 |
| seb128 | Laney, fb adding itself to the launcher | 15:31 |
| Laney | ah | 15:31 |
| Laney | you mean you had the extension off? | 15:31 |
| seb128 | yes | 15:31 |
| Laney | nod | 15:32 |
| * Laney adds that to the bug | 15:32 | |
| Laney | everyone must disable it or we'd certainly have heard about this by now, you'd think | 15:33 |
| Laney | ... | 15:33 |
| Laney | or keep the icon there I guess | 15:33 |
| seb128 | or don't use fb :p | 15:33 |
| Laney | yeah it is pretty niche | 15:34 |
| seb128 | our devel release userbase is for sure not the same set than the ones who are going to run the stable version | 15:34 |
| Laney | I don't use it on that machine or I'd have noticed sooner | 15:34 |
| seb128 | hum, visiting g+ adds googledocs to the launcher | 15:34 |
| seb128 | dbarth, alex_abreu, are you looking at those issue? | 15:35 |
| seb128 | that seems like a potential release blocker to me | 15:35 |
| dbarth | seb128: same as amazon, or is that a new one? | 15:36 |
| dbarth | seb128: hmm no, ok ,taking a look | 15:36 |
| seb128 | dbarth, https://launchpad.net/bugs/1308625 | 15:36 |
| seb128 | dbarth, it's happening with facebook, g+ at least | 15:36 |
| ubot2 | seb128: Error: Could not gather data from Launchpad for bug #1308625 (https://launchpad.net/bugs/1308625). The error has been logged | 15:36 |
| Laney | good old LP going down | 15:36 |
| dbarth | yeah,seems so | 15:37 |
| dbarth | release time, not a good time for being launchpad | 15:37 |
| seb128 | dbarth, well, basically is "enable webapp integration in firefox, visit facebook -> get an icon for fb in the launcher" | 15:37 |
| dbarth | right | 15:37 |
| seb128 | dbarth, if you unpin it, the icon comes back every time you visit the site | 15:37 |
| Laney | remove facebook first if it's already there | 15:37 |
| dbarth | ok, checking in a guest session; any particular rev. of the firefox ext? | 15:38 |
| seb128 | same on g+ (it doesn't even add the right site there, you get a gdrive launcher) | 15:38 |
| seb128 | dbarth, trusty | 15:38 |
| seb128 | current trusty versions | 15:38 |
| Laney | I get the G+ one | 15:38 |
| seb128 | could be random on google sites? | 15:39 |
| Laney | shrug | 15:39 |
| seb128 | oh, I don't have unity-webapps-googleplus in fact | 15:39 |
| Laney | I'll let these guys debug it now :) | 15:40 |
| seb128 | yeah | 15:40 |
| Laney | xclaesse: thanks for reporting | 15:40 |
| seb128 | dbarth, alex_abreu: let us know what you figure out | 15:40 |
| seb128 | xclaesse, thanks! | 15:40 |
| === gatox is now known as gatox_lunch | ||
| seb128 | shrug, does the same on launchpad | 15:42 |
| seb128 | do we enable that integration by default? | 15:42 |
| * seb128 boots test box | 15:42 | |
| Laney | I don't see it there either | 15:43 |
| Laney | wonder why | 15:43 |
| Laney | I probably said 'never' ages ago | 15:43 |
| seb128 | Laney, we don't install any of the unity-webapps-* by default in trusty | 15:45 |
| Laney | yeah I checked I have these ones installed though | 15:45 |
| seb128 | that's likely why nobody ran into the issue | 15:45 |
| seb128 | same here | 15:45 |
| seb128 | so either we tried that | 15:45 |
| seb128 | or they were installed in older releases | 15:45 |
| Laney | I had it installed as far back as my apt/dpkg logs go | 15:46 |
| Laney | 2013-05-16 | 15:47 |
| Laney | could have done it manually though | 15:47 |
| Laney | or that's what the install prompt does/did | 15:48 |
| alex_abreu | Laney, seb128 ok a fix is on the way | 15:53 |
| Laney | this guy is fast | 15:53 |
| alex_abreu | Laney, seb128 https://code.launchpad.net/~abreu-alexandre/unity-firefox-extension/fix-launcher-pin-on-reload/+merge/216148 | 15:53 |
| Laney | ty, building that | 15:54 |
| Laney | alex_abreu: yep, no new icon, thanks | 15:59 |
| seb128 | dbarth, can you organize a landing for that fix? | 16:00 |
| alex_abreu | Laney, ok great, ... | 16:00 |
| Laney | should get it reviewed | 16:00 |
| Laney | it's not obvious why it's right to me | 16:00 |
| seb128 | yeah, to me neither | 16:01 |
| seb128 | we should also check that they still get added on first use/when they should | 16:01 |
| seb128 | rsalveti, hum, committing to trunks/uploading of projects without asking for review or even pinging on IRC now? :-( | 16:02 |
| rsalveti | seb128: packaging changes, and just adding | | 16:02 |
| rsalveti | for the x86 emulator | 16:02 |
| rsalveti | not changing anything else | 16:02 |
| seb128 | yeah, packaging changes can be buggy | 16:03 |
| rsalveti | that was the direction I took with the landing team for that sort of changes | 16:03 |
| rsalveti | seb128: right, I'm a core-dev | 16:03 |
| rsalveti | I could just upload it by hand as well | 16:03 |
| seb128 | and asking is also explaining to others what you commit to their trunk and why :p | 16:03 |
| seb128 | rsalveti, the fact that you can do it doesn't make it right though | 16:03 |
| rsalveti | I just did the sync so the trunk is also in sync with the archive | 16:03 |
| seb128 | rsalveti, yeah, my problem is not with the way the landing is done | 16:03 |
| rsalveti | right, but it doesn't mean I need to ping someone before doing it | 16:03 |
| seb128 | is about committing changes to project you don't usually contribute to without even bothering give a notice/ping on IRC | 16:04 |
| alex_abreu | seb128, Laney I did test that & other use cases | 16:04 |
| rsalveti | well, I didn't change the code, and check the review, it's minimal | 16:04 |
| rsalveti | landing for this is a huge pita | 16:05 |
| rsalveti | for a minor packaging change | 16:05 |
| seb128 | rsalveti, let's agree to disagree, it feels wrong in principle to me but maybe that's just me being old school | 16:05 |
| rsalveti | well, the old school way would be me uploading it directly | 16:05 |
| rsalveti | and not pushing to trunk | 16:05 |
| seb128 | rsalveti, yeah, as said my issue is not with the way it landed, it's about doing changes on packages actively maintained by somebody else without asking/let a fyi first | 16:05 |
| rsalveti | but then someone from the landing team would need to do that later on | 16:05 |
| Laney | alex_abreu: I mean I can't tell what that realInit call is for and if it was ever useful | 16:06 |
| Laney | but maybe nobody else exists who knows this code anyway | 16:06 |
| rsalveti | seb128: asking for changes when minimal? | 16:06 |
| rsalveti | this is not debian | 16:06 |
| seb128 | rsalveti, I soviet Debian you would get list flamed for uploading a package without talking to the maintainer :p | 16:06 |
| seb128 | I->in* | 16:06 |
| rsalveti | right, but that's why I'm not doing that there | 16:06 |
| rsalveti | :-) | 16:06 |
| seb128 | haha, fair enough | 16:06 |
| rsalveti | seb128: but I'll ping you next time if you prefer that, np with that | 16:07 |
| seb128 | rsalveti, well as said, no big deal, it's maybe me but I try to ping/let a quick fyi before uploading a package if it's usually actively maintained by somebody/a team in Ubuntu | 16:07 |
| alex_abreu | Laney, yeah, I asked for a review, ... the thing is that it is a left over from the past. The extension was much simplified & now only takes care of very little | 16:07 |
| seb128 | rsalveti, thanks | 16:07 |
| seb128 | rsalveti, like if you had asked "ok if I upload a small control fix for the emulator" I would have said "yes, no problem, go for it" and we would have spared that discussion ;-) | 16:08 |
| seb128 | anyway moving on | 16:08 |
| seb128 | rsalveti, thanks for the fix btw ;-) | 16:08 |
| rsalveti | seb128: np, I thought it was fine because I had that discussion with the landing team before doing such changes | 16:08 |
| rsalveti | so I had their 'ack' | 16:08 |
| rsalveti | but anyway, pinging you next time :-) | 16:09 |
| seb128 | rsalveti, it's not their project :p | 16:09 |
| rsalveti | fair enough | 16:09 |
| rsalveti | :-) | 16:09 |
| seb128 | but yeah, enough discussion about a minor detail | 16:09 |
| seb128 | thanks ;-) | 16:09 |
| seb128 | rsalveti, btw another approach is to email ubuntu-devel@ saying "I"m going to go through the package that have that depends to add an alternative, let me know if you are in this case and have an issue with an upload" | 16:10 |
| rsalveti | sure | 16:10 |
| seb128 | rsalveti, that way you don't have to ping individual projects and you let everyone know waht's going on | 16:10 |
| seb128 | </discussion> | 16:10 |
| seb128 | ;-) | 16:10 |
| seb128 | bregma, Trevinho, ChrisTownsend: is anyone looking at why compiz is making update-manager not resizable? that's a regression from this cycle and quite annoying, if you try to see the details of an upgrade you have like 1 line of content and can't change the height to see more | 16:17 |
| Trevinho | seb128: I will | 16:18 |
| Trevinho | seb128: it's resizable btw... but the hints gets updated with some delay | 16:18 |
| seb128 | Trevinho, you should share some of the bug with your team ;-) | 16:18 |
| Trevinho | seb128: playing with the window size gets the power back | 16:18 |
| Trevinho | seb128: hehe, of course, just that I know where to put the hands | 16:19 |
| seb128 | Trevinho, not it's not resizable for me, I don't have the cursor changing on borders | 16:19 |
| seb128 | no* | 16:19 |
| === gatox_lunch is now known as gatox | ||
| bregma | Trevinho, same thing happens with the apport dialog, btw, I used to be able to resize it now it's fixed size and I can't see most stack dumps... maybe those windows have something in common>? | 16:36 |
| Trevinho | bregma: might be... as I ignored one event that I thought it was duplicated, while it might not be the case | 16:37 |
| === maclin__ is now known as maclin | ||
| === dpm is now known as dpm-afk | ||
| === psivaa_ is now known as psivaa | ||
| === mjohnson151 is now known as mjohnson15 | ||
| === alex_abreu is now known as alex-abreu | ||
| * Laney is off | 17:06 | |
| Laney | seb128: do you think we need to insert some stuff in the release notes? | 17:06 |
| Laney | https://wiki.ubuntu.com/TrustyTahr/ReleaseNotes#Desktop looks bare | 17:06 |
| seb128 | Laney, we should | 17:06 |
| seb128 | bregma, can you get an unity7 section in ^ | 17:07 |
| Laney | that's for known issues | 17:07 |
| * bregma looks | 17:07 | |
| Laney | there's an 'updated packages' section for good stuff | 17:07 |
| Laney | known issues could be e.g. the grab lockscreen bug | 17:07 |
| Laney | probably others too, need to think | 17:08 |
| Laney | will be back later / tomorrow morning to work on that a bit | 17:08 |
| Laney | but now I have to go: https://twitter.com/DepotNottingham/status/456410825117671424/photo/1 | 17:08 |
| Laney | :-) | 17:08 |
| seb128 | Laney, I guess that be filed tomorrow morning still? | 17:08 |
| seb128 | Laney, happy climbing ;-) | 17:08 |
| Laney | sorry? | 17:08 |
| seb128 | that can be* | 17:09 |
| seb128 | Laney, the release notes | 17:09 |
| Laney | I think we'll have the morning to work on it | 17:09 |
| seb128 | ok | 17:09 |
| seb128 | so good | 17:09 |
| seb128 | let's do that then | 17:09 |
| Laney | but you could verify with ubuntu-release | 17:09 |
| Laney | i'm not doing that stuff | 17:09 |
| seb128 | right, but I think I'm going to call it a day soon as well | 17:09 |
| Laney | nod | 17:09 |
| seb128 | let's see, I might be back later in front of the TV to write some stuff | 17:09 |
| seb128 | otherwise it's going to be for tomorrow | 17:09 |
| Laney | we have our .nz overnight guy who might have time ;-) | 17:09 |
| seb128 | oh, that's right! | 17:10 |
| seb128 | I'm going to drop an email to robert_ancell | 17:10 |
| Laney | our man in the land of the upside down | 17:11 |
| Laney | ok, back later | 17:11 |
| Laney | bye! | 17:11 |
| seb128 | have fun, ttyl! | 17:13 |
| === mjohnson151 is now known as mjohnson15 | ||
| qengho | robru, did you have any trouble with smuxi and the notifications menu? | 17:55 |
| robru | qengho, notifications *menu* seems fine for me, the problem I'm having is that I can't get it to make an audible beep on notifications. And yet it makes the beep in gnome-shell, so it seems more like a unity issue... | 17:56 |
| === psivaa is now known as psivaa-afk | ||
| qengho | robru: say my name. I'll get a screenshot. | 17:58 |
| robru | qengho, ok | 17:58 |
| qengho | robru: Hrm, again? | 17:58 |
| robru | qengho, qengho, qengho ! | 17:59 |
| qengho | robru: thanks. http://i.imgur.com/RM2nQ45.png | 18:02 |
| robru | qengho, nope, never saw that | 18:03 |
| qengho | robru: do you use many workspaces? | 18:05 |
| robru | qengho, nope, just the one (but two screens though) | 18:05 |
| qengho | robru: I just discovered I get no notification menu update if smuxi is focused, even if it's in a different channel than focused one. | 18:05 |
| qengho | I don't know if focus/visibility is different. | 18:06 |
| robru | qengho, right, if the window is focused then smuxi assumes you're paying attention and doesn't do any notification | 18:06 |
| robru | qengho, actually what's annoying me about smuxi now is the when I wake up each morning and it tells me I have x pings in a given channel, but then I have to scrollllll so far through the scrollback to find them. I might give quassel another try because it has that special notification area that just shows all your pings at once... | 18:08 |
| qengho | What's the best way to bisect this menu problem? Before we added DBus security, I'd have just snooped it. Is that still easiest? | 18:09 |
| robru | qengho, I don't know much about dbus personally ;-) | 18:10 |
| qengho | robru: lucky. | 18:11 |
| === dpm-afk is now known as dpm | ||
| seb128 | qengho, what's the issue? | 18:34 |
| === dpm is now known as dpm-afk | ||
| qengho | seb128, I want to find the problem with my IRC notifications. http://i.imgur.com/RM2nQ45.png | 18:52 |
| qengho | seb128: I suspect the client is doing something wrong. | 18:53 |
| seb128 | qengho, that seems like an indicator-messages issue, larsu can probably help you if you ping him during european work hours | 18:53 |
| seb128 | or client issue, but larsu knows the api/can help you debugging | 18:53 |
| qengho | seb128: thx. | 18:53 |
| rickspencer3 | robert_ancell, jasoncwarner, hey is https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/1308572 on your radar at all? | 20:13 |
| ubot2 | Launchpad bug 1308572 in gnome-screensaver (Ubuntu) "Ubuntu 14.04: security problem in the lock screen" [Undecided,New] | 20:13 |
| robert_ancell | rickspencer3, I hadn't seen it but bregma should be looking at that (it's all in unity now) | 20:13 |
| rickspencer3 | robert_ancell, ok, thanks | 20:14 |
| jasoncwarner | Trevinho: can you take a look at the bug rickspencer3 mentioned above? | 20:17 |
| Trevinho | jasoncwarner, rickspencer3: ok... I'm moving the bug to unity btw | 20:19 |
| Laney | beat you :) | 20:19 |
| Trevinho | Laney: oh :) | 20:19 |
| bschaefer | Trevinho, just bumped the prio... | 20:20 |
| jasoncwarner | Thanks Trevinho IMO this should be top of our list right now. Thanks! | 20:20 |
| bschaefer | hopefully didn't step on anyones toes | 20:20 |
| bschaefer | Trevinho, i can take a look as well | 20:20 |
| Trevinho | jasoncwarner: I can't reproduce btw... | 20:20 |
| bschaefer | Trevinho, i can | 20:20 |
| Trevinho | bschaefer: ok, cool | 20:21 |
| bschaefer | Trevinho, just type an incorrect password | 20:21 |
| bschaefer | Trevinho, and just hold enter down | 20:21 |
| Trevinho | bschaefer: yeah, but it goes well here | 20:21 |
| * bschaefer assumes it the TextEntry being popped off the queue | 20:21 | |
| rickspencer3 | just hold down enter | 20:21 |
| rickspencer3 | you don't even need to put a password in | 20:21 |
| bschaefer | yeah just did that as well | 20:21 |
| Trevinho | rickspencer3: yes, I'm trying but I can't :) | 20:21 |
| Trevinho | lucky me :P | 20:21 |
| bschaefer | Trevinho, did you accidentally fix it :)? | 20:21 |
| bschaefer | Trevinho, what unity branch are you running? Im a bit behind trunk | 20:22 |
| bschaefer | i think | 20:22 |
| Trevinho | bschaefer: mh, I think no... I'm on trunk + hacks now... | 20:22 |
| rickspencer3 | to repro I just cntrl-l and hold down the shift key until it crashes | 20:22 |
| rickspencer3 | then I am into Unity | 20:22 |
| bschaefer | Trevinho, yeah i've a crash dealing with a lockscreen tooltip...hopefully thats not where im crashing | 20:23 |
| rickspencer3 | I guess we need to fix either the crasher or make it so that unity doesn't comeback when it crashes | 20:23 |
| bschaefer | rickspencer3, well you can always restart unity in a tty... | 20:23 |
| bschaefer | to get around the lock screen (idk if thats been fixed) | 20:23 |
| Trevinho | rickspencer3: well, it should come up locked if it crashes in such state | 20:23 |
| rickspencer3 | bschaefer, do you not need a password for the 'puter to log in to do taht? | 20:23 |
| rickspencer3 | Trevinho, right, but the first step is to get it into a shippable state | 20:23 |
| bschaefer | rickspencer3, yeah, so its not as critical | 20:24 |
| bschaefer | Trevinho, was that bit fixed? When you restart unity, if in lockscreen, to show the lockscreen still? | 20:25 |
| Trevinho | bschaefer: sorry? We don't have that yet | 20:27 |
| bschaefer | Trevinho, shoots | 20:27 |
| bschaefer | Trevinho, thats half the fix for this bug | 20:27 |
| * bschaefer will focus on the crash it self | 20:27 | |
| Trevinho | bschaefer: it would be trivial to achieve though... Just touching/removing a cache file when entering/exiting the lockscreen so that when loading unity we check if locking or not | 20:28 |
| bschaefer | Trevinho, we can do that for now | 20:28 |
| bschaefer | or possibly the way to do it :) | 20:28 |
| bschaefer | so anytime we setup unity and the lockscreen controller, check if that file exists, if so, then lock the screen | 20:29 |
| Trevinho | exactly | 20:29 |
| bschaefer | Trevinho, that should be a really quick way around the current security issue (though crashes are bad bad BAD!!!) | 20:29 |
| Trevinho | bschaefer: I can do it, if you move on the crash | 20:29 |
| bschaefer | Trevinho, sounds good | 20:29 |
| rickspencer3 | bschaefer, right, the crash should be fixed, but it seems like that method is necessary anyway | 20:29 |
| bschaefer | rickspencer3, yeah, ... hopefully we can get that landed asap to fix the release... | 20:31 |
| rickspencer3 | groovy | 20:31 |
| rickspencer3 | bschaefer, Trevinho will it help if I ask for status every 5 minutes | 20:31 |
| rickspencer3 | ? | 20:31 |
| rickspencer3 | j/k | 20:32 |
| bschaefer | haha | 20:32 |
| bschaefer | it motivates Trevinho | 20:32 |
| Laney | you need to juju deploy a status pinger to all the manager nodes | 20:32 |
| bschaefer | Trevinho, ill set up a new bug for you :) | 20:32 |
| rsalveti | crap, just tried to reproduce and now unity is gone | 20:32 |
| rsalveti | but at least it returned locked | 20:32 |
| Trevinho | rickspencer3: eheh :) | 20:32 |
| bschaefer | Trevinho, actually ill turn that current bug into the main problem you're looking at and ill make a new bug for the crash | 20:36 |
| Trevinho | bschaefer: ok, if you've the bt to attach is better to go with a new | 20:37 |
| bschaefer | Trevinho, i dont, gdb doesn't like my laptop due to schemas :( | 20:37 |
| bschaefer | ill give it a go though | 20:37 |
| bschaefer | Trevinho, if you cant reproduce the crash, you can always restart unity from a tty to test that fix :) | 20:41 |
| Trevinho | bschaefer: indeed | 20:42 |
| bschaefer | Trevinho, also try unpluging your extra monitor :) | 20:42 |
| Trevinho | bschaefer: or, also from main view | 20:42 |
| bschaefer | Trevinho, couldn't get the crash with a second monitor, with 1 i can | 20:42 |
| bschaefer | Trevinho, or that ;) | 20:42 |
| Trevinho | bschaefer: ah so maybe it's why I can't reproduce it, I'm two monitors | 20:43 |
| bschaefer | Trevinho, yeah | 20:44 |
| bschaefer | Trevinho, you always do :) | 20:44 |
| bschaefer | Trevinho, but cool, got the stack trace | 20:44 |
| bschaefer | Trevinho, interesting: http://paste.ubuntu.com/7263684/ | 20:45 |
| bschaefer | looks like an issue with future (some message hanging aroud) and calling a glib signal | 20:45 |
| === Ursinha is now known as Ursinha-afk | ||
| jasoncwarner | Hey robert_ancell could you help test the fix that Trevinho is working on when he's done? | 20:46 |
| Trevinho | bschaefer: I'd avoid the problem from the root btw, by avoiding to emit too many signals when enter is pressed, and if we didn't get anything back yet | 20:47 |
| Trevinho | bschaefer: basically unless we don't have a reply, we should avoid to send anything | 20:47 |
| bschaefer | Trevinho, cool, andyrock said he'll take a look | 20:47 |
| bschaefer | Trevinho, yeah | 20:47 |
| bschaefer | Trevinho, andyrock said he knew whats causing it, so with that fix + your fix (should be a yay!) | 20:48 |
| robert_ancell | jasoncwarner, sure | 20:48 |
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| jasoncwarner | Thanks robert_ancell | 21:00 |
| robert_ancell | Trevinho, let me know when you have a branch to test | 21:00 |
| Trevinho | robert_ancell: indeed | 21:00 |
| xnox | Hey, i have a solution to respawning compiz locked again, using upstart. | 21:01 |
| xnox | so when compiz crash, instead of just respawning compiz we add a second job to respawn compiz and lock the screen. | 21:01 |
| xnox | this should protect from any crashes caused to lock screen WM. | 21:01 |
| xnox | (in the x11 world) | 21:01 |
| dobey | except for the ones that introduce an infinite loop you can't break out of because compiz crashing results in the screen being locked, when you try to unlock it :) | 21:02 |
| rickspencer3 | Trevinho, robert_ancell, jasoncwarner I should be able to test as well | 21:03 |
| rickspencer3 | just let me know if you want any help | 21:03 |
| === psivaa-afk is now known as psivaa | ||
| === Ursinha-afk is now known as Ursinha | ||
| andyrock | rickspencer3, https://code.launchpad.net/~andyrock/unity/fix-1308572/+merge/216216 | 21:36 |
| rickspencer3 | and, nice | 21:36 |
| rickspencer3 | andy, I guess that fixes the crash, right? | 21:37 |
| andyrock | sorry about that that... but sometimes nux is just stupid | 21:37 |
| andyrock | rickspencer3, yep | 21:37 |
| bschaefer | rickspencer3, testing it right now :) | 21:38 |
| rickspencer3 | nice | 21:39 |
| jasoncwarner | nice andyrock fingers crossed ;) | 21:39 |
| andyrock | can we get it in for the final image? | 21:40 |
| Sweetshark | jasoncwarner: thanks for the quick approval ;) | 21:41 |
| jasoncwarner | np Sweetshark | 21:42 |
| jasoncwarner | andyrock I think we are going to hold up image for this fix | 21:42 |
| jasoncwarner | infinity fyi, fix is coming...testing to commence. | 21:42 |
| bschaefer | jasoncwarner, we still need Trevinho fix :) | 21:42 |
| jasoncwarner | bschaefer: yeah | 21:42 |
| rickspencer3 | excellent work guys | 21:43 |
| Sweetshark | desrt: wasnt it you saying: I wont support the lib on a bazillion platforms. Sit down and take a look at this in amazement: http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/apps/asn1pars.c?rev=1.15 | 21:43 |
| Trevinho | rickspencer3, jasoncwarner, robert_ancell: this is the other: https://code.launchpad.net/~3v1n0/unity/relocks-on-crashes/+merge/216221 | 21:43 |
| * bschaefer needs a faster computer... | 21:43 | |
| Trevinho | bschaefer: ^ | 21:43 |
| bschaefer | Trevinho, awesome | 21:43 |
| infinity | jasoncwarner: Shiny. Whatever fix occurs for the rexec issue, do let's make sure it doesn't do anything silly like lock after login or other such failure modes one might think about. :) | 21:43 |
| rickspencer3 | andyrock, we should work hard to get this fix and the fix that protects against other crashes as well ready today/tonight so that we can respin and get it into the final image | 21:43 |
| * bschaefer gets that compiling | 21:43 | |
| desrt | Sweetshark: beautiful | 21:44 |
| rickspencer3 | Trevinho, bschaefer, andyrock great work guys! | 21:44 |
| desrt | Sweetshark: and not too dissimilar to a mess that i had to recently unravel | 21:44 |
| infinity | Trevinho: OnUnlockedSCreen with a capital C? :) | 21:45 |
| Trevinho | infinity: yeah I've fixwed that locally, pusjhing in a sec | 21:45 |
| infinity | Trevinho: Is there a cleanup here, or if I crash my laptop while locked, will a reboot lead to login->lock->login? | 21:45 |
| * Trevinho has evidently typo issues :P | 21:45 | |
| Trevinho | infinity: I was thinking that just now... | 21:46 |
| Sweetshark | desrt: I assume so. Its been a while since I last dared to look at our main(). | 21:46 |
| Trevinho | infinity: mh, no.. so maybe it's better to save in temp... at that point | 21:46 |
| Trevinho | also if temp can be configured not to be cleaned up.. | 21:47 |
| Sweetshark | desrt: slightly unnerving that there is still a comment saying "/* hmm... this is a little evil but it works */" in openssls main ... | 21:47 |
| infinity | Trevinho: /tmp is usually not the right answer, security-wise, cause then you need to get all mktemp-happy and audit that whole mess. User's ~/.cache or whatever is less error-prone. | 21:48 |
| infinity | Trevinho: Especially if you're relying on it being a well-known-name on restart. | 21:48 |
| bschaefer | andyrock, woot no crash! | 21:48 |
| bschaefer | rickspencer3, andyrock branch works for me, and is approved (off to test Trevinho) | 21:50 |
| andyrock | nice! | 21:50 |
| Trevinho | infinity: yeah, I would prefer to avoid that... Mh, so... The only thing we can do is probably adding it to the startup script | 21:51 |
| chrisccoulson | oh, I was just about to ask the same question as infinity (about cleaning up on crash) | 21:53 |
| infinity | Trevinho: Yeah, cleaning the semaphore in /usr/share/upstart/sessions/unity7.conf would likely do the right thing. | 21:53 |
| chrisccoulson | wouldn't /run/user be a better place? | 21:53 |
| chrisccoulson | (rather than /tmp or ~/.cache) | 21:53 |
| Trevinho | chrisccoulson: mh, oh, right... that might be probably better | 21:54 |
| infinity | chrisccoulson: Oh, indeed, I keep forgetting we have that. | 21:54 |
| infinity | That would solve needing to clean the semaphore on system restart. | 21:54 |
| Trevinho | right | 21:54 |
| * Trevinho moves there | 21:54 | |
| bschaefer | nice :) | 21:54 |
| jasoncwarner | bschaefer andyrock nice. looks like #1 is all set ? | 21:54 |
| bschaefer | jasoncwarner, yup, and Trevinho is hammering out the finishing details on #2 | 21:55 |
| jasoncwarner | awesome, great work everyone! thanks for jumping on this. | 21:55 |
| bschaefer | Trevinho, nice :) | 21:59 |
| bschaefer | Trevinho, working here for the #2 case | 21:59 |
| jasoncwarner | bschaefer Trevinho already? | 22:00 |
| jasoncwarner | what kind of black magic is this? | 22:00 |
| thumper | o/ | 22:00 |
| Trevinho | jasoncwarner: now should be done | 22:00 |
| thumper | sometimes I miss you guys | 22:00 |
| bschaefer | thumper, :) | 22:00 |
| * bschaefer has done nothing | 22:01 | |
| bschaefer | but tested | 22:01 |
| bschaefer | haha | 22:01 |
| jasoncwarner | thumper: you should always miss those guys ;) | 22:01 |
| * thumper is feeling nostalgic | 22:01 | |
| Trevinho | thumper: <3 | 22:01 |
| Trevinho | :D | 22:01 |
| thumper | jasoncwarner: how goes the home gym purchase? | 22:01 |
| jasoncwarner | thumper: slow...have to slowly convince the wife it's a good idea (aka, her idea) | 22:02 |
| thumper | haha | 22:02 |
| jasoncwarner | robert_ancell: , seems both should be fixed. mind looping in and helping to verify? | 22:02 |
| robert_ancell | jasoncwarner, still compiling the first one... | 22:02 |
| bschaefer | https://code.launchpad.net/~3v1n0/unity/relocks-on-crashes/+merge/216221 | 22:02 |
| jasoncwarner | infinity: FYI, looks like #1 and #2 are both fixed. bschaefer verified, looping in more people to test | 22:02 |
| bschaefer | robert_ancell, i was lucky to have half compiled unity branches :) | 22:02 |
| bschaefer | jasoncwarner, always a good idea | 22:03 |
| robert_ancell | bschaefer, I was wondering what you had! | 22:03 |
| bschaefer | robert_ancell, haha | 22:03 |
| * bschaefer reboots | 22:04 | |
| Trevinho | chrisccoulson: the runtime dir is cleaned up also on login/logout, right? | 22:05 |
| chrisccoulson | Trevinho, that's a good question. does upstart manage this? | 22:06 |
| wgrant | I wouldn't expect it to be, but does it matter? | 22:06 |
| wgrant | The main case we care about is system crash, when /run will obviously be wiped. | 22:06 |
| wgrant | The screen won't be locked during logout. | 22:07 |
| Trevinho | chrisccoulson, wgrant: well probably it won't happne if you're also logged in a nother tty or ssh... | 22:08 |
| wgrant | Right, that's why I doubt it happens at all. | 22:08 |
| Trevinho | wgrant: I care about it because if in that case an user goes to tty1, then kills gnome-session at next login it will get a double lock screen | 22:08 |
| Trevinho | wgrant: both lightdm and unity lockscreen | 22:08 |
| Trevinho | wgrant: cleaning it up on unity destruction should help, but not if there's another crash there (hard killing the session?) | 22:09 |
| wgrant | Trevinho: Well, if they kill gnome-session then they deserve what they get? :) | 22:13 |
| infinity | Yeah, that's a weird case to cater to. | 22:13 |
| Trevinho | wgrant: eheh ok :) | 22:13 |
| infinity | Real users have machines crash. | 22:13 |
| apw | just deleteing the marker on unlock should be enough no? worst case they get relocked, and when they unlock it gets removed and they are good | 22:13 |
| wgrant | It seems most important to fail as safely as we can. | 22:13 |
| infinity | They don't kill random processes. | 22:13 |
| * Trevinho tries to things to corner cases as well | 22:13 | |
| Trevinho | think* | 22:13 |
| apw | if they randomly kill compiz and survive that, they get locked, and can unlock | 22:14 |
| bschaefer | well it'll only happen if they were in the lockscreen | 22:14 |
| bschaefer | that file is only generated when in the lockscreen | 22:15 |
| infinity | Right. | 22:15 |
| infinity | So, /run/user is absolutely the right thing here, since it also can't go wrong if your /home goes readonly, etc. | 22:15 |
| Trevinho | apw: it depends how they kill it, since on sigterm it will gets cleared | 22:15 |
| bschaefer | the only edge cause i can think of is restarting while in the lockscreen | 22:16 |
| infinity | The only weird failure mode is if you actually start randomly killing processes for kicks, and then you get two login screens (maybe), not world-ending. | 22:16 |
| bschaefer | which putting it in /run/user will fix that | 22:16 |
| jasoncwarner | hey all, robotfuel is going to test the fixes as well. robert_ancell is probably still compiling unity. robert_ancell and robotfuel could you let me know when/what you find? | 22:16 |
| wgrant | bschaefer: Reboot while locked is handled by /run clearing on reboot | 22:16 |
| bschaefer | infinity, well unity-greeter shouldn't start up? | 22:16 |
| robert_ancell | will do. I'm at 60% at the moment | 22:16 |
| bschaefer | wgrant, cool, were there any other edge cases? | 22:16 |
| infinity | bschaefer: Depends on when you went r/o. ;) | 22:16 |
| bschaefer | infinity, right... lockscreens are interesting haha | 22:16 |
| infinity | Anyhow, it seems the advantages of /run wildly outweight the potential benefits of ~/.cache | 22:17 |
| infinity | outweigh, too. | 22:17 |
| Trevinho | bschaefer: if you want to do a new test, btw... I've pushed the cleaned up version | 22:18 |
| bschaefer | Trevinho, sweet, will do! | 22:18 |
| bschaefer | bregma, yay you've returned! | 22:19 |
| olli_ | Trevinho, robert_ancell, everyone else thx for your help | 22:28 |
| Trevinho | olli_: np ;) | 22:28 |
| olli_ | Trevinho, let me know if you want me to test something | 22:28 |
| Trevinho | olli_: the branches are lp:~3v1n0/unity/relocks-on-crashes and lp:~andyrock/unity/fix-1308572 | 22:29 |
| bschaefer | Trevinho, \o/ | 22:29 |
| bschaefer | Trevinho, works now on a reboot :) | 22:29 |
| bschaefer | Trevinho, we need to get a silo for test, not sure if bregma has resolved his internet issues | 22:29 |
| olli_ | Trevinho, do we have .debs? | 22:29 |
| olli_ | ah | 22:29 |
| olli_ | happy to give the silo a spin | 22:30 |
| Trevinho | olli_: eh, not yet I believe... bregma will set it up in minutes I guess | 22:30 |
| bschaefer | olli_, i've tested both branches, and confirmed them working | 22:30 |
| bschaefer | robert_ancell, is also testing | 22:30 |
| olli_ | bschaefer, alrighty | 22:30 |
| robert_ancell | 72%... | 22:30 |
| bschaefer | robert_ancell, you should always have a nice (~5GB) unity build ready to compile a new unity branch! (joking) | 22:30 |
| robert_ancell | bschaefer, heh :) I guess it's nice to have a complete build from scratch to be 100% sure everything is working | 22:31 |
| bschaefer | robert_ancell, this is very true! | 22:31 |
| bschaefer | Trevinho, bregma wanted either you or I to poke robru to get a silo | 22:32 |
| bschaefer | Trevinho, it makes it easier for others to test as well, from a ppa | 22:32 |
| bschaefer | Trevinho, code looks good as well, branch approved | 22:34 |
| Trevinho | bschaefer: cool | 22:35 |
| robru | bschaefer, i'm back now, silos for all! | 22:35 |
| bschaefer | robru, \o/ | 22:35 |
| bschaefer | robru, would you be able to place these two branch in them, and start the build? | 22:36 |
| bschaefer | lp:~3v1n0/unity/relocks-on-crashes and lp:~andyrock/unity/fix-1308572 | 22:36 |
| robru | bschaefer, got some branches for something? I hope you're not wanting to land something in desktop trusty... | 22:36 |
| robru | bschaefer, yeah I can help you with that. you know bout the spreadsheet right? | 22:36 |
| jasoncwarner | robru: yes, they do and yes, they shoudl ;) | 22:36 |
| Trevinho | robru: we have | 22:36 |
| bschaefer | robru, we are un fortunately, critical security issues | 22:36 |
| bschaefer | robru, yeah, but i don't think i hvae the power! | 22:36 |
| jasoncwarner | robru: these are critical security things in the lockscreen. | 22:36 |
| Laney | Yeah XDG_RUNTIME_DIR is what you want | 22:36 |
| robru | jasoncwarner, ok ok I'm on it | 22:37 |
| Laney | It lives as long as the user is logged in somewhere | 22:37 |
| bschaefer | robru, then you very much! | 22:37 |
| bschaefer | thank* | 22:37 |
| Laney | and will be cleared on a reboot or full logout | 22:37 |
| robru | bschaefer, do you have merges for those branches? I need merges | 22:37 |
| bschaefer | robru, yeah let me get them | 22:37 |
| bschaefer | https://code.launchpad.net/~3v1n0/unity/relocks-on-crashes/+merge/216221 | 22:37 |
| bschaefer | https://code.launchpad.net/~andyrock/unity/fix-1308572/+merge/216216 | 22:38 |
| bschaefer | robru, ^ | 22:38 |
| robru | bschaefer, thanks. | 22:39 |
| bschaefer | robru, thank you :) | 22:39 |
| robru | bschaefer, jasoncwarner Trevinho : ok, got those building in silo 8: https://ci-train.ubuntu.com/job/landing-008-1-build/44/console | 22:39 |
| bschaefer | sweet | 22:40 |
| robru | jasoncwarner, is the release team aware of this? | 22:40 |
| Trevinho | olli_: then, if you want to test they will be there in some minutes ^ | 22:40 |
| jasoncwarner | robru: infinity is looped in | 22:40 |
| robru | jasoncwarner, ok great, so when I ask him to accept it he won't be surprised ;-) | 22:41 |
| wgrant | We're all eagerly awaiting it. | 22:41 |
| jasoncwarner | robru: shouldn't be ;) robert_ancell and robotfuel are also testing when they can. robert_ancell is trying to build unity...probably at 78% right now ;) | 22:41 |
| robert_ancell | 79 | 22:42 |
| robotfuel | I am compiling as well | 22:42 |
| Trevinho | robert_ancell: unrelated, but why we don't get the PropertyChanged signal from lightdm https://code.launchpad.net/~andyrock/unity/lp-1281058/+merge/215331/comments/513206 ? | 22:42 |
| Trevinho | robert_ancell: if you want to speed things up (and you're not building the debs), just build things inside build/plugins/unityshell and build/UnityCore | 22:43 |
| robert_ancell | Trevinho, I guess it was never implemented - please file a bug | 22:43 |
| Trevinho | robert_ancell: ok, fine... Also, I've noticed that when the unity_Greeter is already there (i.e. you call .Lock on display manager, then you move with ctrl+alt+fX to the prev session, you unlock and back in, then again you recall .Lock), then unity don't get the Locked signal | 22:44 |
| Trevinho | robert_ancell: thus we don't lock... | 22:45 |
| Trevinho | robert_ancell: gdbus monitor said it's not sent to anyone... | 22:45 |
| robert_ancell | Trevinho, this is Locked from logind? | 22:45 |
| Trevinho | robert_ancell: yes | 22:45 |
| robert_ancell | Trevinho, interesting. Please file a bug and we can make a test for that and check it does the right thing | 22:46 |
| Trevinho | robert_ancell: ok, in lightdm or what? | 22:46 |
| robert_ancell | Trevinho, yes, put it in lightdm | 22:46 |
| jasoncwarner | hi everyone. I have to step out for about 15 minutes, just fyi. | 22:52 |
| olli_ | Trevinho, is it done? | 22:58 |
| Trevinho | olli_: still building at https://launchpad.net/~ci-train-ppa-service/+archive/landing-008/ | 22:59 |
| Trevinho | olli_: amd64 is doing the pkgs btw, so it's matter of few minutes | 22:59 |
| Trevinho | robert_ancell: here you are some details | 23:00 |
| Trevinho | https://bugs.launchpad.net/lightdm/+bug/1308789 | 23:00 |
| ubot2 | Launchpad bug 1308789 in Light Display Manager "logind Locked signal is not emitted when (unity_)greeter is already running" [Undecided,New] | 23:00 |
| robert_ancell | Trevinho, thanks | 23:00 |
| Trevinho | robert_ancell: same happens with g-s (double checked now), so it's not unity fault (and it would be weird as we don't get the signals) | 23:02 |
| Trevinho | robert_ancell: the only thing that I see differnt with g-s is that I also get /org/freedesktop/login1/session/c2: org.freedesktop.DBus.Properties.PropertiesChanged ('org.freedesktop.login1.Session', @a{sv} {}, ['IdleHint', 'IdleSinceHint', 'IdleSinceHintMonotonic']), do you know what is that related to? | 23:04 |
| robert_ancell | Trevinho, I think that's the same as the idle that comes from gnome-screensaver. Though I don't know if anything populates it | 23:05 |
| Trevinho | jasoncwarner, olli_: packages are finally at https://launchpad.net/~ci-train-ppa-service/+archive/landing-008/+packages for your tests | 23:05 |
| olli_ | bschaefer, Trevinho, robert_ancell, robotfuel, do we have a testplan we are using to validate this one | 23:07 |
| Trevinho | Trevinho: there are actually two fixes in there | 23:08 |
| Trevinho | err self-ping | 23:08 |
| Trevinho | olli_: there are actually two fixes in there | 23:08 |
| Trevinho | olli_: the first one is: it should not crash when keeping enter pressed in the lockscreen | 23:09 |
| Trevinho | olli_: then, the other fix is about making sure that if unity crashed when in lockscreen, then it relocks when run | 23:10 |
| Trevinho | olli_: so for this one, just run your normal session, lock it | 23:10 |
| Trevinho | olli_: go to tty1 and do something like killall -9 compiz (the -9 is important, otherwise it will not be like a crash) | 23:10 |
| olli_ | k | 23:11 |
| Trevinho | olli_: go back to tty7 and unity should be reloading, but locked | 23:11 |
| olli_ | Trevinho, try sleep 5; killall -9 compiz | 23:12 |
| olli_ | and go to 7 to watch | 23:12 |
| robert_ancell | andyrock, bschaefer, also confirm lp:~andyrock/unity/fix-1308572 fixes the crash | 23:12 |
| olli_ | didn't recover for me | 23:12 |
| Trevinho | olli_: further test would be doing the same, but after killing it, reboot... And not-experiencing the 2nd lock after lightdm (quite unlikely as it's ensured by the kernel, but... just to be sure) | 23:12 |
| Trevinho | olli_: oh, yeah indeed.. you can just run a sleep 5 && killall -9 compiz, then Super+L | 23:12 |
| Trevinho | olli_: weird I didn't mention that since it's the way i tested it :D | 23:13 |
| robert_ancell | Trevinho, does https://launchpad.net/~ci-train-ppa-service/+archive/landing-008/+packages contain both lp:~andyrock/unity/fix-1308572 and lp:~3v1n0/unity/relocks-on-crashes? Do you want confirmation on the latter? | 23:13 |
| olli_ | Trevinho, I kicked it off on tty1 | 23:13 |
| olli_ | and it the lockscreen didn't come back | 23:13 |
| Trevinho | robert_ancell: yes it has both | 23:13 |
| Trevinho | olli_: you mean, once you're back on tty7 that unity is running normally? | 23:14 |
| olli_ | no, it's not | 23:14 |
| olli_ | Trevinho, go to tty1 | 23:14 |
| olli_ | sleep 5; killall -9 compiz | 23:15 |
| olli_ | in a clean / newly started session | 23:15 |
| olli_ | that works as expected | 23:15 |
| olli_ | however, if you do it a 2nd time without login in I don't get the lockscreen | 23:15 |
| olli_ | iow, compiz can't crash multiple consecutive times | 23:16 |
| Trevinho | olli_: that's because it doesn't get reloaded twice maybe? :o that should be upstart doing it... mhmh | 23:16 |
| olli_ | Trevinho, even when I log in between the 2 tries I am not getting the lock screen on the 2nd try | 23:17 |
| Trevinho | olli_: let me test, but I think it's not unity's fault, mostly it doesn't get reloaded more than a certain limit I think | 23:17 |
| robert_ancell | jasoncwarner, ^ | 23:18 |
| robru | uh, guys? I just tried silo 8 in a VM... after installing the updated unity, it doesn't restart after a crash, locked or not, killall -9 makes it go away permanently. | 23:19 |
| jasoncwarner | not quite out of the woods yet? | 23:19 |
| robru | jasoncwarner, gonna test more | 23:19 |
| olli_ | jasoncwarner, I think the security issue is fixed | 23:20 |
| Trevinho | robru: this is just weird, since we didn't change anything that should be related to that :o mhmh | 23:20 |
| olli_ | i.e. can't crash Unity anymore by keep pushing Enter | 23:20 |
| robru | olli_, yeah, I couldn't reproduce the Enter key crash in an unpatched VM either. | 23:21 |
| jasoncwarner | olli_: acked | 23:21 |
| olli_ | jasoncwarner, what's left is that 2 consecutive crashes of Unity while being locked doesn't bring UNity back | 23:21 |
| jasoncwarner | olli_: ok, thanks for the clarification | 23:21 |
| olli_ | so, you can argue whether the latter is a ship stopper still | 23:21 |
| olli_ | I think we need to keep pushing atm | 23:22 |
| olli_ | but got to be aware that the security aspect is solved | 23:22 |
| olli_ | robru, interesting, did you keep pushing Enter for like 30sec? | 23:22 |
| robru | olli_, ok, just confirmed, same. the first killall makes unity come back locked, second killall makes unity not come back. | 23:22 |
| wgrant | I've seen thatbefore thischange | 23:22 |
| Trevinho | olli_: I think this problem isn't a new thing btw... I don't use unity run by upstart much, but I noticed it doesn't restart always... | 23:22 |
| robru | olli_, i held down the enter key for one full minute. | 23:22 |
| wgrant | I could only crash it maybe 2 or 3 times before it stopped autorestarting. | 23:22 |
| wgrant | But the Enter crash is reliable within 30s or so | 23:23 |
| olli_ | robru, that makes for sucky repro testing ;) | 23:23 |
| robru | I'm testing in a VM, it's quite slow, I guess it's a race condition or something. | 23:23 |
| olli_ | let me try the 2 consecutive crash thing on this machine real quick, this is unpatched | 23:23 |
| olli_ | brb | 23:23 |
| infinity | robru: That's not a new behaviour. We saw the same pre-patch when reproducing the crash in the first place. | 23:23 |
| robru | when you guys hold down enter, do you see the lock screen check and recheck rapidly? because it seemed to only do it quite slowly for me | 23:23 |
| infinity | robru: (ie: it's not a regression that you can't keep crashing it forever) | 23:24 |
| robert_ancell | Trevinho, olli_, do we strictly need the "keep lock on unity crash" fix? Note that killing gnome-screensaver would break the lock in the existing case | 23:24 |
| robru | infinity, ok | 23:24 |
| infinity | robert_ancell: That's the fix that matters. | 23:24 |
| wgrant | Killing gnome-screensaver would break it, but gnome-screensaver is simpler, well-tested code. | 23:24 |
| wgrant | There will be other crashers. | 23:24 |
| infinity | robert_ancell: The crash isn't the security bug, the fact that it's unlocked after a crash is. | 23:24 |
| wgrant | We need to prevent the crashers from becoming security bugs in the first place. | 23:25 |
| olli | infinity, and that seems to be fixed - sorry I dropped just when you started | 23:25 |
| robert_ancell | sure, it just feels like this is a bit of an enhancement over the status quo rather than a fix. Though of course the likelihood of unity crashing is higher than gnome-screensaver. | 23:25 |
| robotfuel | killall compiz unlocks the screen. | 23:25 |
| olli | robotfuel, under which circumstances? | 23:26 |
| infinity | robert_ancell: Enhancement is to be encouraged. :P | 23:26 |
| wgrant | A non-crash exit should unlock the screen. | 23:26 |
| robert_ancell | infinity, this close to release? :) | 23:26 |
| robotfuel | olli: wait for the screen to to dim and lock, switch terminals to tty1 login and type killall compiz | 23:27 |
| infinity | robert_ancell: For a security hole? Yes. | 23:27 |
| olli | robotfuel, will try | 23:27 |
| wgrant | robotfuel: The crash case is the interesting one; killall will send SIGTERM for a clean shutdown by default. | 23:27 |
| infinity | robotfuel: A sigkill isn't a security hole. | 23:27 |
| wgrant | unity should be cleaning up on SIGTERM. | 23:27 |
| olli | Trevinho, ^ what robotfuel says | 23:27 |
| infinity | Or term. | 23:27 |
| wgrant | SIGKILL or SIGSEGV should both work fine for reproducing this. | 23:27 |
| infinity | olli: A TERM isn't a crash. | 23:28 |
| apw | don't we send a SIGTERM to unlock, isn't that normal | 23:28 |
| wgrant | But SIGSERGV isn't the interesting one. | 23:28 |
| jasoncwarner | infinity: I think what robert_ancell is asking, if I read it right, is would we stop the release for the same behavior in gnome-screensaver (which, I believe, has done this for quite some time as well). again, if I read that right | 23:28 |
| wgrant | SIGSEGV *is* the interesting one. | 23:28 |
| olli | infinity, ah, didn't get that robotfuel missed -9 | 23:28 |
| infinity | jasoncwarner: If there was any evidence that gnome-screensaver had crashed at some point in the last 7 years, sure. | 23:28 |
| infinity | jasoncwarner: Turns out that compiz and unity do a lot. | 23:28 |
| jasoncwarner | infinity: maybe I'm misunderstanding. perhaps someone could rephrase the current issue? As I understand it, the security hole is fixed....but.... | 23:30 |
| jasoncwarner | olli ^ | 23:30 |
| olli | jasoncwarner, I think infinity is arguing that killall -9 is not valid | 23:30 |
| olli | SIGKILL vs SIGSEGV | 23:30 |
| robru | jasoncwarner, infinity ok guys, well, the package as built in silo 8 contains the behavior that unity restarts locked after a crash, I guess that is what we desire? let me know if you want me to hit 'publish' | 23:30 |
| Trevinho | wgrant, robert_ancell: gnome-screensaver? it's not anymroe in trusty (unless you don't have some a11y settings on)... | 23:30 |
| Trevinho | wgrant: unity *does* cleanup in SIGTERM | 23:31 |
| wgrant | I know, and I know. | 23:31 |
| infinity | Trevinho: Right. Which it should. | 23:31 |
| wgrant | gnome-screensaver's reliability is important, because it's what we have to measure against. | 23:31 |
| infinity | Trevinho: The point is that people were (incorrectly) using TERM to fake a "crash". :) | 23:31 |
| wgrant | The point is that SIGKILL, SIGABRT, SIGSEGV are all good for testing | 23:31 |
| wgrant | SIGTERM is not. | 23:31 |
| Trevinho | infinity: ah, indeed... but SIGKILL is fine, sin't it? | 23:32 |
| wgrant | Yes. | 23:32 |
| jasoncwarner | thanks olli | 23:32 |
| Trevinho | wgrant: I underlined that on the test-case I wrote above... :) | 23:32 |
| infinity | robru: That is what we want, yes. Both the lock-on-crash and, optionally (but highly desired) the fix for the crash itself. | 23:32 |
| olli | infinity, I tested with killall -9 | 23:32 |
| robru | i was also testing with -9 | 23:32 |
| olli | and couldn't get into unity | 23:32 |
| olli | now doing a -11 also doesn't get me into unity | 23:33 |
| olli | even though it takes way longer for compiz to die | 23:33 |
| olli | back to the lockscreen though | 23:33 |
| wgrant | That's correct. | 23:33 |
| wgrant | -11 will invoke aport, so it will coredump. | 23:33 |
| wgrant | == slow | 23:33 |
| olli | alrighty, so do we have agreement that the security issue is sufficiently addressed? | 23:35 |
| olli | infinity, ^ | 23:36 |
| wgrant | Have we etseted that edge cases such as system crashes while locked don't require double login? | 23:36 |
| wgrant | But it sounds like it works, and the code looks fine. | 23:36 |
| Trevinho | wgrant: it needs if you use your tty powers... :/ | 23:36 |
| Trevinho | wgrant: not if you reboot | 23:36 |
| olli | I think once we agree that the sec issue is addressed I'd do some more general testing | 23:37 |
| wgrant | We just need to make sure it's not regressing anything, given how late this is. | 23:37 |
| olli | just to make sure we didn't catch a nasty regression | 23:37 |
| olli | ack | 23:37 |
| wgrant | Right. | 23:37 |
| robru | ok guys here's the thing | 23:37 |
| robotfuel | I did some guest session test, but multiple user tests might be interesting. | 23:37 |
| wgrant | Trevinho: Right, but we can't really avoid that, and it's not a normal user case. | 23:37 |
| wgrant | Power failures are a normal user case :) | 23:37 |
| robru | so doing killall -9 makes it relaunch locked the first time, but then the second time it doesn't relaunch at all. that's supposedly expected | 23:37 |
| wgrant | Right | 23:37 |
| robru | but eg I was testing this with a terminal open | 23:37 |
| Trevinho | wgrant: yeah, indeed :) | 23:37 |
| robru | and when "unity doesn't relaunch", it leaves the terminal open | 23:38 |
| infinity | Okay, has anyone also done a fresh reboot with this unity to make sure it doesn't do anything silly on first login? | 23:38 |
| wgrant | The failure to restart the second time is not a regression | 23:38 |
| wgrant | It is a security vuln, but that's probably harder. | 23:38 |
| infinity | I see no way from the code that it would, but. | 23:38 |
| olli | infinity, I did | 23:38 |
| infinity | olli: Thanks. | 23:38 |
| robru | can't type in it, but I can copy & paste with the mouse in the terminal. so effectively I have access to the terminal to issue commands in a limited way. still seems like a security hole to me | 23:38 |
| olli | will do again just to be sure | 23:38 |
| robru | eg if i'm an attacker and i have the ability to take down compiz, all i have to do is do it twice... | 23:38 |
| wgrant | It would be nice to track down the double restart issue | 23:38 |
| olli | Trevinho, ^ | 23:39 |
| Trevinho | this thing about "unity doesn't relaunch" I think it's something related to wront config from gnome-session/upstart since it doens't seem to be managed by upstart at pstree level, but maybe it's just because upstart runs throught g-s? | 23:39 |
| wgrant | But I don't think it's absolutely essential, as it requires a triggerable crash to exploit, and is possibly awkward to fix now. | 23:39 |
| wgrant | But it should certainly be investigated. | 23:39 |
| robru | ok | 23:39 |
| robru | well I'm happy to publish this unity then, do we all agree it's a good idea? | 23:40 |
| * Trevinho abstains, but would say +1 :P | 23:40 | |
| infinity | robru: Do it. | 23:40 |
| robru | ok | 23:40 |
| wgrant | Agrred. | 23:40 |
| robotfuel | robru: +1 | 23:40 |
| robru | oh lol, still building on armhf and powerpc... | 23:41 |
| olli | Trevinho, why, just because it's like... 2am | 23:41 |
| Trevinho | :) | 23:41 |
| jasoncwarner | powerpc? did someone say powerpc? don't even get me started..... | 23:41 |
| olli | robru, can yuou pls update the bug with your latest finding re terminal | 23:42 |
| robru | olli, sure | 23:42 |
| olli | jasoncwarner, I'll update the incident report to document the decision | 23:42 |
| jasoncwarner | thanks olli | 23:42 |
| olli | infinity, is there anything else left to do? | 23:42 |
| olli | for today | 23:42 |
| olli | I think we need to follow up on the double crash | 23:42 |
| olli | asap | 23:42 |
| infinity | jasoncwarner: I'll hook you up with (much) faster ppc buildds after release. | 23:43 |
| jasoncwarner | infinity: :) | 23:43 |
| jasoncwarner | Trevinho andyrock robotfuel robert_ancell robru infinity thank you all for working this so late in the game (and day for some!). | 23:44 |
| jasoncwarner | awesome to see how people rallied around it....not that we like seeing it b/c of a bug, obviously ;) | 23:44 |
| Trevinho | jasoncwarner: np, it's mostly my normal work time :) | 23:44 |
| jasoncwarner | Trevinho: ah, to be young again ;) | 23:45 |
| jasoncwarner | or...perhaps....not old :) | 23:45 |
| Trevinho | jasoncwarner: not that young... unfortunately :/ but time is not my friend | 23:46 |
| jasoncwarner | Trevinho: :) indeed! | 23:46 |
| robru | jasoncwarner, hah, not even 5PM here ;-) | 23:47 |
| robru | jasoncwarner, but you know that! | 23:47 |
| robru | olli, https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1308572/comments/6 | 23:49 |
| ubot2 | Launchpad bug 1308572 in unity (Ubuntu) "Ubuntu 14.04: security problem in the lock screen" [Critical,In progress] | 23:49 |
| olli | thx robru | 23:49 |
| robru | you're welcome | 23:49 |
| olli | robru, can you pls ping me once you have hit release | 23:49 |
| robru | olli, sure | 23:49 |
| olli | thx | 23:49 |
| infinity | robru: That ppc build should be done in ~5m or so. Sorry, if I'd known the build was in flight earlier, I would have aimed it at sagari. | 23:54 |
| robru | infinity, no worries. | 23:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
