| Makyo | lp, put in an offer | 00:40 |
|---|---|---|
| Makyo | That was most of what I typed. Thanks xchat. | 00:40 |
| rick_h_ | Makyo: lol | 00:46 |
| rick_h_ | Makyo: so you put in an offer on the houes you saw? | 00:46 |
| rick_h_ | jcsackett: recorded myself with that headset. Crazy that noise. Doesn't do it on the air running ubuntu. My other headsets haven't been an issue. | 01:18 |
| frankban | morning rick_h_: do you have a minute for a quick look at https://codereview.appspot.com/90220043 (charm)? | 10:57 |
| rick_h_ | frankban: will do | 11:11 |
| frankban | rick_h_: thanks | 11:11 |
| rick_h_ | frankban: I've got to take the wife's car into the shop, will be in/out but will be working through it and do qa from there | 11:14 |
| frankban | rick_h_: ack | 11:14 |
| * frankban lunches | 11:42 | |
| bac | frankban: thanks for the review. i think your idea is good. | 12:14 |
| rick_h_ | geeze this is why I <3 working from home | 12:26 |
| rick_h_ | stupid rush hour | 12:26 |
| bac | rick_h_: at the subaru dealer all morning? | 12:29 |
| rick_h_ | bac: yea,verified her car is leaking oil in the driveway. She just had an oil change done so I htink they munged up something | 12:29 |
| rick_h_ | trying to be the good husband and get it handled for her | 12:30 |
| bac | well hopefully it is just a small leak. i've had friends go to jiffy lube and drive away only to get a mile or two before the engine seized since the plug fell out | 12:30 |
| rick_h_ | yea, I had that happen when I was a kid | 12:30 |
| rick_h_ | plug fell on the highway in a construction zone | 12:31 |
| rick_h_ | had to go 4 miles by the time I could pull over | 12:31 |
| rick_h_ | new engines for me! | 12:31 |
| bac | then JL wanted to pay her a pro-rated amount for her dead engine. | 12:31 |
| rick_h_ | lol | 12:31 |
| rick_h_ | I only got mine 'rebuilt' but as a college kid I was happy | 12:31 |
| bac | oh no, LP hates me | 12:32 |
| bac | error: Failed to load data for member "bac": Get https://api.launchpad.net/devel/~bac: EOF | 12:32 |
| rick_h_ | oops | 12:32 |
| rick_h_ | you've been cut off | 12:32 |
| bac | frankban: i've proposed changes back to error: Failed to load data for member "bac": Get https://api.launchpad.net/devel/~bac: EOF | 12:33 |
| bac | let's try that again | 12:33 |
| bac | frankban: i've proposed changes back to https://codereview.appspot.com/90060043 | 12:33 |
| bac | i kept the change s/get_admin_secret/get_value_from_jenv/ as it is more generic and may be useful in the future. but it may be YAGNI. let's discuss. | 12:34 |
| bac | rick_h_: the deploy of the migration to staging on prodstack failed yesterday. i had to run a full ingest on my laptop last night so i can try to reproduce the problem | 12:35 |
| rick_h_ | bac: :( | 12:35 |
| rick_h_ | bac: good to know thanks. Yay for staging doing its job I guess | 12:36 |
| rick_h_ | bac: there was an ingestion issue yesterday as well. I filed a bug on there | 12:36 |
| bac | yeah, but having the other we control would've been nicer | 12:36 |
| frankban | bac: cool, taking a look | 12:36 |
| rick_h_ | bac: I tried to look into it but something in charmworld hates that charm. | 12:36 |
| bac | rick_h_: is it on the board? | 12:36 |
| rick_h_ | bac: yes, the vsm charm | 12:36 |
| bac | cool | 12:36 |
| frankban | rick_h_: thanks for the review, I already created a card to update docs while making a release, my next thing after this branch lands | 12:36 |
| rick_h_ | frankban: awesome, thanks. I need to rename my code reviews to "rick thinks out louad" :) | 12:37 |
| frankban | :-) | 12:37 |
| rick_h_ | bah, can't type on this air | 12:38 |
| frankban | guihelp: charmworld shows that Last ingest job "finished at 2014-04-18 17:34:37Z". | 12:49 |
| rick_h_ | frankban: oh hmm, well that may be the ticket. Oh, and the queues are where I saw them yesterday | 12:50 |
| bac | frankban: looking | 12:51 |
| rick_h_ | lol, I just saw the queues and missed the numbers didn't change | 12:51 |
| rick_h_ | frankban: does this not need a functional test run? | 12:52 |
| frankban | rick_h_: I run the suite, and I'll run it again for the release, so it's not required now | 12:53 |
| rick_h_ | frankban: rgr | 12:53 |
| rick_h_ | frankban: LGTM then, after the release please ping jcastro so he knows his fix is out. | 12:55 |
| frankban | rick_h_: sure, thanks | 12:55 |
| rick_h_ | luca: morning | 13:07 |
| jcsackett | morning all. | 13:07 |
| frankban | bac: your branch LGTM | 13:07 |
| bac | frankban: thanks | 13:07 |
| rick_h_ | jcsackett: party | 13:08 |
| frankban | jujugui: heads up email to peeps re: charm development environment | 13:08 |
| rick_h_ | frankban: ty much kind sir | 13:08 |
| luca | morning rick_h_ | 13:09 |
| rick_h_ | luca: hey, any chance of bumping up our catchup? | 13:09 |
| rick_h_ | luca: or are you guys busy? :) | 13:09 |
| luca | rick_h_: you want to have it sooner than later? | 13:09 |
| rick_h_ | luca: yep | 13:10 |
| luca | rick_h_: I can do it in 10 mins if thats ok | 13:10 |
| rick_h_ | luca: sounds good thanks! | 13:10 |
| luca | rick_h_: no worries | 13:11 |
| jcsackett | rick_h_, given the MV priority, should i be looking at that stack of cards for today's work? and follow up question: if yes, what should i take a look at to get up to speed on said project? :p | 13:11 |
| rick_h_ | jcsackett: stick in project A if possible | 13:12 |
| jcsackett | rick_h_, you got it. | 13:12 |
| rick_h_ | jcsackett: either the charm search card or the charm browser home button with kadam's face on it | 13:12 |
| rick_h_ | just take him off | 13:13 |
| jcsackett | dig. | 13:13 |
| rick_h_ | lazyPower: marcoceppi https://jujucharms.com/precise/vsm | 13:19 |
| bac | jujugui: m.j.c is ingesting charms again. | 13:19 |
| bac | looking at log files and keeping an eye on it | 13:19 |
| jcsackett | bac: what was preventing vsm from being ingested? | 13:19 |
| rick_h_ | bacty | 13:19 |
| bac | jcsackett: nothing was being ingested and i haven't looked at that one specifically yet | 13:20 |
| rick_h_ | bac: it's all good | 13:20 |
| rick_h_ | clsoing the bug | 13:20 |
| jcsackett | bac: ah, ok. | 13:20 |
| rick_h_ | it was due to no ingestion at all happening | 13:20 |
| bac | rick_h_: that's what i assumed | 13:20 |
| rick_h_ | luca: no hangout on that calendar entry to please invite me to whatever you guys set up. | 13:21 |
| bac | rick_h_, jcsackett: weird, it looks like ingest just gave up a few days ago. https://pastebin.canonical.com/108930/ | 13:26 |
| bac | i assume the two github attempts right after midnight are due to it being kicked by logrotate or something | 13:26 |
| bac | the IngestErrors for "charm contains no files" are handled and aren't fatal to the process | 13:27 |
| jcsackett | bac, yeah, i think i recall no files being handled back in the orangesquad days. | 13:29 |
| bac | jcsackett: but then it just went on strike | 13:30 |
| bac | servicectl status showed it was alive. | 13:30 |
| jcsackett | bac: eh, ingest is a tetchy beast. it probably just wanted a holiday. | 13:37 |
| rick_h_ | bac: rgr, we should add a low maint task to add a nagios check for that last run stuff | 13:39 |
| rick_h_ | bac: so at least if it gives up the ghost for a day we know about it | 13:39 |
| rick_h_ | or at least make that RED on heartbeat | 13:39 |
| rick_h_ | so blind people like me can see what's up :) | 13:39 |
| bac | sure | 13:39 |
| jcsackett | jujugui: i'm finding that `make clean-all test-debug` is requiring my password for sudo rights. any idea what i goofed? | 13:44 |
| rick_h_ | jcsackett: check perms on ~/tmp and ~/.npm | 13:45 |
| rick_h_ | jcsackett: the instructions should have had you chown those during the setup | 13:45 |
| rick_h_ | jcsackett: but you shouldn't need to run make clean-all much | 13:46 |
| bac | jcsackett: oddly enough it did shut down right on good friday. | 13:46 |
| rick_h_ | as well | 13:46 |
| jcsackett | rick_h_, it just tells you to make them, which shouldn't be a problem since they should default correctly. | 13:46 |
| jcsackett | and indeed, i am owner &c. | 13:46 |
| rick_h_ | jujugui on the road back home, biab | 13:46 |
| jcsackett | ha! i love that it died on good friday. | 13:46 |
| jcsackett | ...oh, bad word choice on my part...i love that it took good friday off. | 13:47 |
| lazyPower | rick_h_: thanks for looking into that. | 14:17 |
| bac | jcsackett: the exodus branch from yesterday failed when deployed to staging. this branch is the fix. could you take a look at it? https://codereview.appspot.com/90300043 | 14:24 |
| jcsackett | bac, lgtm | 14:27 |
| bac | ty jcsackett. now to try to deploy to staging and make it happy again | 14:27 |
| * rick_h_ is back | 14:31 | |
| rick_h_ | jcsackett: not sure then on the sudo thing. | 14:31 |
| jcsackett | rick_h_, no worries, i'll poke at it later. it's doing something with /usr/local/src, but it's an LXC so meh. | 14:34 |
| jcsackett | rick_h_, got a quick sec for g+? | 14:34 |
| rick_h_ | jcsackett: sure thing | 14:34 |
| rick_h_ | shoot me a link | 14:35 |
| jcsackett | rick_h_ https://plus.google.com/hangouts/_/7acpj4cuggoppve90pnm3v27hs?hl=en | 14:35 |
| jcsackett | jujugui: can someone take a look at a short PR for me? https://github.com/juju/juju-gui/pull/252 | 14:50 |
| bac | jcsackett: i will after the meeting | 14:52 |
| jcsackett | bac, thanks. | 14:52 |
| bac | jujugui: meeting at :00 | 14:52 |
| * jcsackett needs coffee for meetings | 14:54 | |
| frankban | jcastro: new precise and trusty charms released/ingested with the apt-update fix | 14:54 |
| kadams54 | Question about testing and flags: I see a slew of tests in test_browser_app.js that check to make sure various routing situations are handled correctly. It seems like they're all run sans flags. Is there a way to easily control flag values for a test? | 14:57 |
| jcastro | frankban, thank you sir! | 14:58 |
| jcastro | rick_h_, man I can't believe I found a bug and a fix! | 14:58 |
| rick_h_ | jcastro: :) | 14:58 |
| jcastro | rick_h_, and you were probably bored at some meeting | 14:58 |
| frankban | :-) | 14:59 |
| rick_h_ | jcastro: someone has to plan for everyone else to be bored in vegas :P | 14:59 |
| Makyo | jujugui call in 1 | 14:59 |
| jcsackett | kadams54, you'll see many a test set window.flags = $flag_you_need | 15:00 |
| jcsackett | just make sure there's cleanup as well. | 15:00 |
| rick_h_ | Makyo: join the hangout again? | 15:20 |
| bac | jcsackett: i'm looking at your branch. i'm trying to see the broken behavior on jujucharms.com | 15:23 |
| bac | jcsackett: i searched for mysql and then clicked on the home icon. seemed to work. what am i missing? | 15:23 |
| jcsackett | bac: with il? | 15:24 |
| bac | OH ff | 15:24 |
| jcsackett | yup | 15:24 |
| bac | jcsackett: like so? https://jujucharms.com/sidebar/search/:flags:il/?text=mysql | 15:26 |
| bac | jcsackett: or is there another slash after :flags: | 15:26 |
| bac | either way i don't see it misbehaving | 15:27 |
| rick_h_ | bac :flags:/il/? | 15:27 |
| jcsackett | huh, it isn't misbehaving on jujucharms; it does on develop locally tho. | 15:27 |
| rick_h_ | jujucharms is old | 15:28 |
| rick_h_ | use comingsoon | 15:28 |
| bac | ahhhh. doh. | 15:28 |
| rick_h_ | it's stuff that's broken in code since the last release | 15:28 |
| bac | ok, that is def broken: http://comingsoon.jujucharms.com/:flags:/il/?text=mysql | 15:28 |
| rick_h_ | :) | 15:28 |
| rick_h_ | and now hopefully fixed | 15:29 |
| jcsackett | rick_h_, responded to your comment with updated branch. bac, you still looking? | 15:45 |
| bac | jcsackett: done | 15:46 |
| bac | jcsackett: now, really done | 15:47 |
| jcsackett | bac: the test is just for metadata being safely reset--component resets are already tested. | 15:50 |
| bac | ok | 15:50 |
| jcsackett | rick_h_, the other card you told me to look at was the one about updating charm-search.js to use new state? just confirming what "charm search card" meant. | 15:51 |
| rick_h_ | jcsackett: that one and the one that kadams54 is working on are closely related. That one needs to bring the filters object back into the state code | 15:57 |
| rick_h_ | kadams54: sorry, I mixed up this card and yours this morning | 15:57 |
| rick_h_ | jcsackett: yes that's the card I mean and it's updating the charm-search.js and bringing the filters back for managing the query string/search api call | 15:57 |
| jcsackett | rick_h_, dig. i'll start looking into it post lunch. | 15:58 |
| jcsackett | oh, wait, missed what you just said. | 15:58 |
| jcsackett | shall i leave that one to kadams54 then, post his work? | 15:58 |
| rick_h_ | jcsackett: I think you can get started, but will have to incorporate his work. Maybe sync with him on it. | 15:59 |
| rick_h_ | jcsackett: he's not touching things like charm-search.js but he is in the state code dealing with filters/query string changes | 15:59 |
| jcsackett | rick_h_, dig. i reiterate my post-lunch remark then. :p | 15:59 |
| jcsackett | kadams54, you likely to be around to chat a bit past 1? | 16:00 |
| kadams54 | Yes | 16:00 |
| jcsackett | cool beans. i'll ping you around then and we can make sure i don't wreck anything. :) | 16:10 |
| jcsackett | kadams54, free to chat at 1:30? | 17:16 |
| kadams54 | jcsackett: let me ping you when I'm ready. Just got a call from my son's school that he's had an accident and I need to run out a fresh change of clothes :-( | 17:17 |
| jcsackett | kadams54, dig. that is def a priority situation. | 17:18 |
| Makyo | jujugui review/qa of relations+ecs stuff https://github.com/juju/juju-gui/pull/253 | 17:19 |
| Makyo | Lost my pre-push hook, so lint may be bad. | 17:19 |
| jcsackett | makyo: i can look, but please tell me what does ECS stand for? | 17:20 |
| Makyo | jcsackett, Environment Change Set. Local transaction that will be tied to a deploy button, so that you can work locally, then deploy all changes at once. | 17:21 |
| jcsackett | ah, so set up the whole set of relations and go rather than just one service at a time. | 17:21 |
| jcsackett | cool. looking now, makyo. | 17:21 |
| Makyo | It's all hatch 's fault, jcsackett | 17:24 |
| Makyo | (well, okay, 90%) | 17:24 |
| * jcsackett laughs | 17:25 | |
| hatch | lol | 17:25 |
| jcsackett | Makyo, i've finished looking at code, QAing now--none of my comments are major. | 17:50 |
| jcsackett | looks like hatch is reviewing it too. | 17:50 |
| Makyo | Good. | 17:50 |
| Makyo | Thanks guys | 17:50 |
| jcsackett | Makyo, looks like your QA directions got cut off? "ensure that the relation" | 17:54 |
| Makyo | jcsackett, oops, sorry. Ensure that the relation is in the changeset by investigating app.ecs.changeSet in the javascript console. | 17:54 |
| Makyo | Updated. | 17:57 |
| jcsackett | Makyo, thanks. it passes your QA instructions--ping me when you address rick_h_'s comments about flags and i'll double check QA again. | 17:57 |
| Makyo | jcastro, will do. Thanks! | 17:57 |
| Makyo | jcsackett, Sorry, thanks. | 17:58 |
| Makyo | jcastro, Lazy fingers, don't mind me | 17:58 |
| kadams54 | jcsackett: ready to talk when you are | 17:58 |
| jcsackett | kadams54, awesome, i'll pass your a URL momentarily. | 17:59 |
| jcsackett | kadams54, https://plus.google.com/hangouts/_/7acpj3384g52o10sitntlhkh3s | 18:00 |
| kadams54 | Says the party is over :-/ | 18:01 |
| jcsackett | ...bloody hell. | 18:02 |
| jcsackett | kadams54, are you signed in as your @canonical.com self? | 18:02 |
| jcsackett | what is your email? | 18:02 |
| kadams54 | kyle.adams@canonical.com | 18:02 |
| jcsackett | kadams54, give it a try now. | 18:03 |
| rick_h_ | Makyo: comments added, I'm curious on the ecs as an arg vs communicating with the env | 18:03 |
| Makyo | rick_h_, Every time I bring up events, I get in trouble, so I avoided it. If that's the path we're heading down, I'm all for it. | 18:06 |
| Makyo | In particular, hatch__ has been a pretty big opponent of event-based work such as the topology. | 18:07 |
| Makyo | Not quite sure who to make happy here :) | 18:07 |
| jcsackett | rick_h_, you got a second to chat? | 18:08 |
| === hatch__ is now known as hatch | ||
| rick_h_ | Makyo: k | 18:09 |
| rick_h_ | Makyo: I'm just curious if there was a big reason | 18:09 |
| hatch | who said what in the where now? | 18:09 |
| rick_h_ | Makyo: I think it makes the topology simpler and keeps it cleaner especially as it's nuts for it to deal with the ecs everywhere | 18:09 |
| rick_h_ | jcsackett: sure thing | 18:10 |
| rick_h_ | jcsackett: linky? | 18:10 |
| Makyo | rick_h_, sure, makes sense. | 18:10 |
| jcsackett | rick_h_, https://plus.google.com/hangouts/_/7acpj3384g52o10sitntlhkh3s | 18:10 |
| Makyo | hatch, using events to communicate between layers of the application. | 18:10 |
| rick_h_ | jcsackett: is that from your url in the browser? | 18:10 |
| jcsackett | rick_h_, nope, that's from the share window, where i just invited your canonical address. | 18:10 |
| rick_h_ | jcsackett: no worky, invite me? | 18:10 |
| hatch | ahh yeah | 18:10 |
| rick_h_ | jcsackett: oh you've got to start it first then give me the live hangout url | 18:11 |
| jcsackett | rick_h_, it's started. i'm sitting in it. | 18:11 |
| rick_h_ | jcsackett: invite again please. | 18:11 |
| jcsackett | rick_h_, hang on, i'm just going to start a new one. | 18:11 |
| rick_h_ | Makyo: well I appreciate your thoughts on the two paths. | 18:11 |
| jcsackett | rick_h_, invite sent. | 18:12 |
| rick_h_ | Makyo: we can mute hatch if we have to, he's on vacation and we can do what we want :P | 18:12 |
| jcsackett | rick_h_, https://plus.google.com/hangouts/_/7acpifdroro7ler4og7bqoom8k | 18:12 |
| Makyo | Hahaha | 18:12 |
| * hatch is wondering if he should join this hangout | 18:12 | |
| rick_h_ | hatch: not yet | 18:12 |
| Makyo | + like a million | 18:12 |
| rick_h_ | Makyo: k, then we can chat with hatch if he has issues but I like the simpler use of events in this case | 18:13 |
| hatch | I'm not done going through the review yet | 18:13 |
| Makyo | rick_h_, sure, I think it's a good direction to move in. I'll investigate heading in that direction. Thanks for the multiple reviews | 18:13 |
| hatch | I'll hold off until then | 18:13 |
| Makyo | hatch, go ahead and finish if you find anything outstanding. | 18:14 |
| Makyo | I'll get them all in one go. | 18:14 |
| Makyo | the asynchronicity was something we agreed on, hatch. Wait until each layer of the hierarchy came back before starting the next so that we were sure the entities existed in the state machine. | 18:15 |
| Makyo | As in, can't create a relation between services that don't exist in the state machine yet. | 18:15 |
| rick_h_ | Makyo: yea, and my comments on that I realize are more wide ranging than this branch | 18:18 |
| rick_h_ | Makyo: so you hatch and I should chat about the long term usage of this in real life use cases | 18:18 |
| hatch | Makyo ok right, I'm just trying to see if I see a better way for that | 18:23 |
| hatch | I don't like using Y.soon just to pop things to the top of the stack | 18:23 |
| Makyo | hatch, ah, okay. More than happy to change it, I don;'t like it either. | 18:24 |
| Makyo | Though it does show up elsewhere in our code. | 18:24 |
| rick_h_ | Makyo: big one at https://github.com/juju/juju-gui/pull/253/files#diff-2396c727b78bbe8c6ff20dc9a231ee2aR935 though | 18:24 |
| hatch | yeah it does....but it's pretty much a hack everywhere | 18:24 |
| rick_h_ | bah, never mind | 18:25 |
| rick_h_ | Makyo: ok, so env has an add_relation method? | 18:25 |
| Makyo | rick_h_, yes, though you're right that could do with a test. | 18:25 |
| rick_h_ | can we not just ecs or not ecs it there in the env then and forget events or passing it in? | 18:25 |
| rick_h_ | then the topo code doens't need to be changed at all in this branch | 18:26 |
| Makyo | Oh, does the env have ecs? | 18:27 |
| rick_h_ | the env is passing the ecs into topo I thought? | 18:27 |
| rick_h_ | maybe I'm not following stuff /me looks again | 18:27 |
| hatch | the environment view is passing ecs into the topology when it creates the topology | 18:28 |
| hatch | not the env | 18:28 |
| rick_h_ | oh ok | 18:28 |
| hatch | confusing name clash :) | 18:28 |
| Makyo | Yeah, yikes | 18:28 |
| rick_h_ | bah, this is nuts | 18:28 |
| rick_h_ | :) | 18:28 |
| rick_h_ | ok, so then is there value is giving the env the ecs and making everyone work with him | 18:29 |
| rick_h_ | vs passing hte ecs into topo/etc? | 18:29 |
| rick_h_ | the inspector/config changes will want access right? | 18:29 |
| rick_h_ | what else? | 18:29 |
| hatch | think of the env as a bunch of utilities that the ecs controls in the proper order | 18:30 |
| hatch | so the ecs is what other things need to make requests of | 18:30 |
| rick_h_ | ok, if we swap the env for the ecs I'm ok, but adding to feels like we're muddying things up even more | 18:30 |
| hatch | well keep in mind that this is a wip, the ecs never used to exist so everything was calling the env | 18:31 |
| hatch | it'll take time for things to move over | 18:31 |
| rick_h_ | I know but I want to make sure we're thinking/planning for the future and trying to lay down a cleaner path as we go | 18:32 |
| rick_h_ | if you're saying that all things should talk to the ecs vs the env, then let's do that. | 18:32 |
| rick_h_ | I mean if the flag is set pass the ecs into the topology and if not, then pass in the env. Then we have an XXX that when the flag is removed to rename the var or something. | 18:33 |
| rick_h_ | but this doesn't plan does a life without env atm | 18:33 |
| rick_h_ | it just adds more code and more required setup and more things to keep in your head in the end | 18:34 |
| bac | jcsackett: yet another... https://codereview.appspot.com/90420043 | 18:38 |
| rick_h_ | so in looking at this, if we moved the ecs into the env, then we could simplify things. The env is already passed around and is on the environment View. hatch Makyo | 18:38 |
| rick_h_ | Makyo: hatch the ecs could be setup with different options as required for sandbox vs go | 18:38 |
| rick_h_ | Makyo: hatch and things like add_relation could just be 'ecs' enabled? | 18:39 |
| Makyo | I can see that working, yeah | 18:39 |
| rick_h_ | hatch: have time for a call? | 18:39 |
| rick_h_ | maybe worth a chat? | 18:39 |
| hatch | sec just otp | 18:42 |
| rick_h_ | hatch: np, appreciate your thoughts while you're away. | 18:42 |
| jcsackett | bac, so we're just losing any bundles that got grandfathered? will those be reingested eventually if they're updated to pass proof? | 18:42 |
| bac | jcsackett: yeah, if they are fixed | 18:42 |
| bac | jcsackett: it is no loss, they cannot be deployed | 18:43 |
| bac | as is | 18:43 |
| bac | we've just never had a process to do any housekeeping. | 18:43 |
| jcsackett | bac, dig. | 18:44 |
| jcsackett | lgtm. | 18:44 |
| hatch | ok off the phone | 18:45 |
| rick_h_ | hatch: k, setting up a call | 18:46 |
| rick_h_ | hatch: Makyo https://plus.google.com/hangouts/_/76cpik3in0rjn0urt22rbvjpo8?authuser=1&hl=en | 18:47 |
| bac | jcsackett: your approve comment in RV needs to include the magic string LGTM somewhere in it. | 18:47 |
| jcsackett | bac: duh, of course. sorry. | 18:49 |
| jcsackett | bac, done. | 18:50 |
| bac | thx | 18:50 |
| jcsackett | jujugui: i believe CI is stuck. is there a means of terminating a build? | 18:52 |
| rick_h_ | jcsackett: yea second | 18:52 |
| hatch | rick_h_ yeah this will be a good change, will make it easier to follow when some things use/don't use the ecs | 19:08 |
| rick_h_ | hatch: cool | 19:08 |
| rick_h_ | hatch: thanks for taking the time to chat about it. | 19:08 |
| rick_h_ | now go have fun! | 19:08 |
| rick_h_ | :) | 19:08 |
| hatch | annnnnd my flight out of YXE is delayed 3H | 19:09 |
| hatch | how the heck.... | 19:09 |
| hatch | it's not until tomorrow | 19:09 |
| rick_h_ | ouch! | 19:09 |
| hatch | how can it be delayed so bad already lol | 19:09 |
| rick_h_ | 3hr is quite the delayed | 19:09 |
| hatch | I guess I get to sleep in more | 19:10 |
| rick_h_ | well I'd make sure to watch it. Might move back :P | 19:10 |
| hatch | haha yeah wouldn't doubt it | 19:10 |
| hatch | the new google transit maps are pretty cool | 19:11 |
| hatch | it was just delayed another 20 mins.... umm | 19:11 |
| hatch | maybe I'm driving to Denver | 19:11 |
| hatch | lol | 19:11 |
| rick_h_ | lol | 19:11 |
| jcsackett | we only filter on categories now, right? there's no UI to say "just recommended" or "just aws" is there? | 19:21 |
| rick_h_ | jcsackett: no, there is not | 19:21 |
| rick_h_ | jcsackett: there's talk of a future "tag based" search UI that we'd detect words as things like that | 19:21 |
| rick_h_ | but no current UI | 19:22 |
| jcsackett | rick_h_, awesome. so we don't need to maintain the FILTER_SERIES &c bits? just the categories. | 19:22 |
| rick_h_ | jcsackett: yes | 19:22 |
| jcsackett | alright, i'm not going to delete those bits in this branch, but i'll put a card saying once we remove the il flag they can be whacked. | 19:23 |
| jcsackett | s/card/note/ | 19:23 |
| jcsackett | though, maybe a card as well? | 19:23 |
| rick_h_ | stick a card in the backlog for it | 19:23 |
| rick_h_ | and we'll try to get a big cleanup phase into the plans at some point | 19:23 |
| jcsackett | "pool" vs "on deck"? i'm guessing pool, but the meaning isn't inherently obvious. | 19:26 |
| rick_h_ | yes, pool | 19:26 |
| rick_h_ | on deck is what we planning poker and has a chance to be in the next 2wk iteration | 19:26 |
| rick_h_ | pool is long term | 19:26 |
| jcastro | hey rick_h_ | 19:30 |
| jcastro | I have an awesome idea | 19:30 |
| jcastro | "awesome" | 19:30 |
| jcastro | for demo mode | 19:31 |
| rick_h_ | jcsackett: otp, but love ideas | 19:34 |
| jcsackett | he meant jcastro. :p | 19:35 |
| jcastro | hey so | 19:35 |
| jcastro | https://github.com/chjj/tty.js/ | 19:35 |
| jcastro | remember how the old old old gui stuff had an idea for a terminal in the webui | 19:35 |
| rick_h_ | jcastro: but that would have to run on each machine right? | 19:52 |
| rick_h_ | jcastro: in the environment | 19:52 |
| rick_h_ | jcastro: we've got tasks for debug-log and juju run to try to do next cycle, should help with some of it | 19:53 |
| jcsackett | rick_h_, just a reminder, there's a build stuck on CI. | 20:15 |
| rick_h_ | jcsackett: ah thanks | 20:15 |
| jcsackett | it's based off my branch, which is a tad alarming, but it doesn't hang locally on a make test or make check | 20:16 |
| rick_h_ | jcsackett: looks like you've got a login | 20:16 |
| rick_h_ | jcsackett: so you have to login and then stop it | 20:16 |
| jcsackett | i have a login? that's news to me. | 20:16 |
| rick_h_ | you're in the list :) | 20:17 |
| jcsackett | huh. i wonder what my login info is. | 20:17 |
| rick_h_ | guihelp anyone seen ERROR no such request - method Client.PrivateAddress is not implemented | 20:17 |
| hatch | that's new to me, where are you getting that? | 20:18 |
| rick_h_ | hatch: juju ssh jenkins/0 | 20:18 |
| hatch | oh that's very odd | 20:19 |
| * Makyo returns from house. | 21:06 | |
| Makyo | Signed my half of the contract, woo | 21:06 |
| rick_h_ | Makyo: wooo! | 21:09 |
| hatch | oo whats woo? | 21:11 |
| hatch | rick_h_ so I'm on test coverage/improvements with kadams54 next wk? | 21:11 |
| Makyo | Signed my half of the contract on the house. Need to get James to sign, then the offer's official. | 21:11 |
| hatch | right on!!!! | 21:11 |
| rick_h_ | hatch: if he's interested | 21:12 |
| rick_h_ | or Makyo if he is, or jcsackett if he is | 21:12 |
| rick_h_ | hatch: you just need a programming buddy | 21:12 |
| * hatch brings a rubber ducky | 21:13 | |
| kadams54 | hatch: sure, test coverage it is | 21:13 |
| kadams54 | Makyo: congrats! | 21:14 |
| Makyo | Thanks :) Going heads down again to get this branch up ASAP. | 21:15 |
| hatch | oh Makyo the lazyAddRelation is a little confusing around the 'if deploy' block, can you add some comments there? | 21:15 |
| Makyo | Yep | 21:17 |
| jcsackett | hatch: i may be very interested in test coverage next week. i have concerns about things that are only implicitly tested. | 21:28 |
| hatch | jcsackett we need a refactor of our entire test suite so maybe the three of us can chip away at it in the down time | 21:28 |
| rick_h_ | let's try to get coverage without a rewrite though | 21:29 |
| hatch | just want to make sure we end the week with a 'shippable' project | 21:29 |
| rick_h_ | something we can accomplish, a rewrite will be a stuck branch | 21:29 |
| rick_h_ | :) | 21:29 |
| jcsackett | i'll accept all parts of state being explicitly tested. :p | 21:29 |
| jcsackett | also, maybe we can just kill those 13 pending tests that have been around for ever. | 21:29 |
| hatch | haha, they are....you see all those url tests? | 21:29 |
| hatch | NEVA!!!! | 21:30 |
| jcsackett | hatch, i just changed the new ui state object to load a filter object into metadata.search instead of a string. *nothing* broke. | 21:30 |
| jcsackett | i don't for a second believe that means everything is just working. :p | 21:30 |
| rick_h_ | lol | 21:30 |
| hatch | sure - that means it's working exactly as intended | 21:31 |
| hatch | :) | 21:31 |
| rick_h_ | admittingly search is already broken per kadams54's branch but not a good sign | 21:31 |
| * jcsackett laughs | 21:31 | |
| hatch | honestly though, search is just a key, if you put the wrong stuff in it, that's not the state systems fault | 21:31 |
| rick_h_ | hatch: but the url generation stuff should go boom | 21:32 |
| rick_h_ | hatch: I'd expect at least | 21:32 |
| rick_h_ | hatch: then again I guess the tests put a string in there | 21:32 |
| rick_h_ | so it's still passing | 21:32 |
| jcsackett | ah, that's true | 21:32 |
| hatch | this isn't "enterprise" software, it can only be SO resilient lol | 21:33 |
| rick_h_ | it's not perfect, but gets better every day | 21:34 |
| hatch | oh man I saw some .NET the other day....instead of whitelisting a specific kind of input, it blacklisted......EVERYTHING | 21:34 |
| hatch | honestly, it was like 2000 lines | 21:35 |
| hatch | "enterprise yo" | 21:35 |
| jcsackett | wow. | 21:35 |
| jcsackett | that's both entirely unsurprising and sort of horrendous. | 21:35 |
| hatch | haha true true | 21:35 |
| === hatch___ is now known as hatch | ||
| Makyo | rick_h_, hatch did we agree to postpone possible changes re ecs/env to a future branch, or should I work in that direction with a comment? | 22:08 |
| hatch | future branch | 22:08 |
| rick_h_ | Makyo: yes, let's do a future branch. Feel free to note any XXX so we can remember what we talked about | 22:08 |
| rick_h_ | Makyo: but yes, let's get this landed and get the deploy button triggering to this for demo at least | 22:08 |
| Makyo | Sounds good. | 22:08 |
| rick_h_ | Makyo: I'm 100% ok with a hack for the deploy button. Then we can come back around on this env thing and refactor that up | 22:09 |
| * rick_h_ is tempted to just make 'onclick=xxx.commit()' | 22:09 | |
| hatch | ERMAHGERD | 22:10 |
| rick_h_ | does that have an english translation? | 22:10 |
| hatch | google it | 22:10 |
| hatch | lol | 22:10 |
| rick_h_ | OMG | 22:11 |
| hatch | rofl | 22:11 |
| hatch | I'm probably using it wrong.....oh well, I live in a bubble | 22:12 |
| rick_h_ | kadams54: any luck? I was looking at the code on that and I don't see how the code uses the renderSearchResults or anything at all | 22:13 |
| rick_h_ | kadams54: so it looks like there's a chunk of wiring to make that work on page load | 22:14 |
| rick_h_ | the dispatch stuff runs sidebar.showSearch but nothing actually makes sure the view is there with any content. | 22:15 |
| rick_h_ | in the il flagged dispatch work | 22:16 |
| hatch | cool, I have a broken, but working, code coverage implementation working already | 22:25 |
| hatch | rick_h_ kadams54 jcsackett - it's ALLLLLIVEEEE (sortof) https://www.evernote.com/shard/s219/sh/12455d7f-3ed4-4884-ba5c-e7fbedcac294/2103b2b738982a28bebe7df94ee63219 | 22:32 |
| hatch | this is as far as I'm taking it :) | 22:32 |
| hatch | before the sprint that is | 22:32 |
| huwshimi | Morning | 23:02 |
| kadams54 | hatch: Nice. | 23:02 |
| kadams54 | rick_h_: Yeah, that tracks with what I was finding. Two options: 1) re-jigger routeDefault to somehow get the search into sidebar rendering, likely by taking it from the request rather than from state or 2) re-jigger routeView to render the sidebar if it's not present, likely similar to how routeDefault does it. | 23:04 |
| kadams54 | huwshimi: Morning :-) | 23:04 |
| huwshimi | kadams54: Hey! | 23:05 |
| rick_h_ | kadams54: have time to chat or want to do it first thing in the morning? | 23:16 |
| rick_h_ | huwshimi: morning, welcome back | 23:17 |
| rick_h_ | huwshimi: I've got a mission for you if you're looking for something to do? | 23:17 |
| huwshimi | rick_h_: Thanks. | 23:17 |
| huwshimi | rick_h_: Sure! | 23:17 |
| huwshimi | (was taking a look at the minimize removal) | 23:17 |
| rick_h_ | huwshimi: invite inbound | 23:18 |
| hatch | kadams54 I spent a bunch of time looking at how to do the search within the same code....mind running the issue past me? | 23:30 |
| hatch | I may have already explored some routes you're going down :) | 23:31 |
| rick_h_ | hatch: the thing is that if you have a search in the initial page load /?text=apache then in the old code it would call this.renderSearchResults(req, resp, next) | 23:31 |
| rick_h_ | hatch: and the new dispatch stuff only calls this._sidebar.showSearch() | 23:32 |
| rick_h_ | which is the show/hide bit, but not creating the instance of the View for results and such | 23:32 |
| rick_h_ | hatch: at least that's my cursory look over it atm | 23:32 |
| hatch | right, when the sidebar is created it instantiates the search view so it's always rendered | 23:33 |
| hatch | just hidden when the inspector is rendered | 23:33 |
| rick_h_ | hmm, I missed that connection then | 23:33 |
| hatch | so where is the problem with that? I'm guessing search + inspector is causing issues? | 23:33 |
| rick_h_ | no | 23:33 |
| rick_h_ | just /?text=apache | 23:33 |
| hatch | oh, that should work just fine | 23:34 |
| rick_h_ | the query string search never gets to the dispatched work that I can see | 23:34 |
| hatch | hmm that's definitely not right | 23:34 |
| hatch | lemme check real quick | 23:34 |
| rick_h_ | kadams54: the trick is that when the flag is set you shouldn't be hitting defaulrRoute or routeView. | 23:34 |
| rick_h_ | hatch: if you can note out the dispatch path on a fresh request maybe that would help. | 23:34 |
| hatch | http://comingsoon.jujucharms.com/:flags:/il/?text=apache | 23:35 |
| hatch | that works....? | 23:35 |
| hatch | ohhh | 23:35 |
| hatch | without the flag is broken | 23:35 |
| rick_h_ | http://comingsoon.jujucharms.com/:flags:/il/?text=apache doesn't | 23:36 |
| hatch | ^ that is the same link that I had working :) | 23:36 |
| hatch | did you mean to have that without the il flag? | 23:36 |
| rick_h_ | oh it's the stupid slash thing | 23:36 |
| rick_h_ | take that last slash out | 23:36 |
| rick_h_ | and the url updates to with, but no search is dispatched | 23:36 |
| rick_h_ | http://comingsoon.jujucharms.com/:flags:/il?text=apache | 23:36 |
| hatch | ohh right | 23:37 |
| hatch | I think that's an issue with the namespacing | 23:37 |
| hatch | that's technically an invalid url | 23:37 |
| hatch | as far as the namespacing is concerned | 23:37 |
| hatch | if I remember correctly | 23:37 |
| rick_h_ | ok, so have to look at how the dispatch to sidebar to search results works | 23:37 |
| rick_h_ | and how to get the metadata.search down into the widget | 23:37 |
| rick_h_ | which is probably expecting a filter object to be sent in | 23:38 |
| hatch | yeah, check the state object going to the dispatcher to make sure it has the proper data in it | 23:38 |
| rick_h_ | which jcsackett is working on adding | 23:38 |
| hatch | debugging this is very trivial now | 23:38 |
| rick_h_ | kadams54: is confused in routeDefault vs routeView vs what is called with the flag | 23:38 |
| rick_h_ | which is just _sidebar right? | 23:38 |
| hatch | I can run you through the execution order if you like | 23:39 |
| rick_h_ | oh, no wonder kadams54 was confused. | 23:39 |
| hatch | the -only- route which gets hit when it's under the il flag is the { path: '*', callbacks: 'routeDefault'}, | 23:39 |
| rick_h_ | that was not clear | 23:39 |
| rick_h_ | kadams54: man I lead you so wrong. I'm sorry | 23:40 |
| rick_h_ | ok, will have to pull the code down and debugger through after the boy goes to bed. | 23:41 |
| hatch | rick_h_ when You have a moment I can give you the tour through the execution order | 23:43 |
| hatch | I gave it to kadams54 but it's a lot to digest in one sitting :) | 23:44 |
| rick_h_ | hatch: I'll walk it. So that calls sidebar, but the thing is that what is this.state at that point? Does it have the query in it? It's not loaded in routeDefault until after sidebar() is callled | 23:45 |
| rick_h_ | it might be as simple as moving the loadRequest to before sidebar, but there's a race because it's doing one call | 23:45 |
| hatch | so sidebar's job is just to render the 'dumb' container then the loadRequest is what parses the url and dispatches stuff to render into the sidebar view | 23:46 |
| hatch | to fix the search results.... | 23:46 |
| hatch | sec | 23:46 |
| rick_h_ | right, but sidebar() does a bunch of stuff | 23:46 |
| kadams54 | Back, though only temporarily… getting the kiddos settled into bed and then I'll have more time. | 23:47 |
| hatch | yeah only when it's not under il, under il, sidebar() is never called | 23:47 |
| hatch | the issue is likely with the filter | 23:47 |
| rick_h_ | kadams54: understood, it's past EOD so we can punt until tomorrow. Just trying to understand better and apologize early/often for leading you wrong | 23:48 |
| kadams54 | Yeah, it's not as simple as switching loadRequest and sidebar… I tried that already :-) | 23:48 |
| rick_h_ | right, the search widget expects that filter object I think. | 23:48 |
| kadams54 | I've been down about 5 rabbit holes so far with this bug | 23:48 |
| hatch | basically rick_h_ when it's not under il, it should be running the same path as it did before | 23:48 |
| rick_h_ | I think we need jcsackett's branch + a tweak to make this work | 23:48 |
| rick_h_ | hatch: right, but the il flag at the start of sidebar doesn't put the rest of the work in an 'else' | 23:48 |
| rick_h_ | hatch: so it's still run | 23:48 |
| rick_h_ | kadams54: :( | 23:48 |
| hatch | oh right right, so my guess is that the filter parsing got busted somehow.... | 23:49 |
| hatch | although won't all of this be moot come Fridayish? | 23:49 |
| kadams54 | I'm not sure anything's busted | 23:49 |
| huwshimi | rick_h_: There is code that minimises the sidebar so that other things can use the space on the screen. Should I stop that happening as well? | 23:50 |
| kadams54 | We just need to settle on *one* spot for storing filter/querystring info | 23:50 |
| kadams54 | Right now it's in state.sectionA.metadata.search and state.filter | 23:50 |
| rick_h_ | huwshimi: oh crap! that's the missing bit | 23:50 |
| rick_h_ | huwshimi: we haven't updated the inspector charm details/unit details to pop out right yet | 23:50 |
| hatch | oops, I forgot about that too | 23:50 |
| rick_h_ | huwshimi: yes, that should stop and go away though | 23:50 |
| * hatch blames rick_h_ | 23:50 | |
| hatch | lol | 23:51 |
| * rick_h_ checks schedule for code-time available tomorrow | 23:51 | |
| kadams54 | Right now state.filter is fed into the pipeline that eventually renders the sidebar | 23:51 |
| kadams54 | See line 133 in browser.js | 23:51 |
| kadams54 | So that's the first problem… | 23:51 |
| huwshimi | rick_h_: So should I remove it in my branch and someone will fix up the details panels? | 23:51 |
| rick_h_ | huwshimi: yes | 23:51 |
| kadams54 | The second problem is straightening out sidebar() and loadRequest() | 23:51 |
| huwshimi | rick_h_: Thanks :) | 23:51 |
| kadams54 | Seems like we ought to be able to render the sidebar, then call loadRequest | 23:52 |
| kadams54 | And calling loadRequest should populate the empty search input with the search string | 23:52 |
| hatch | nonono, the problem is that the filter class was ignored | 23:52 |
| kadams54 | Which would resolve the current race condition | 23:52 |
| hatch | the filter class needs to be updated with the information from state | 23:52 |
| hatch | so that when it's passed in all of the rquired data is available | 23:53 |
| rick_h_ | kadams54: let's catch up in the morning on it. Go tuck in the kids | 23:53 |
| kadams54 | OK :-) | 23:53 |
| rick_h_ | it's past EOD everyone needs some wine time :) | 23:53 |
| kadams54 | But I can definitively say hatch is incorrect ;-) | 23:53 |
| kadams54 | hatch: In my branch filter is updated with info from state | 23:53 |
| kadams54 | But it still doesn't work | 23:53 |
| kadams54 | Because state doesn't exist when sidebar() is called | 23:53 |
| hatch | that's fine | 23:54 |
| hatch | it doesn't need to be | 23:54 |
| kadams54 | And there's nothing in loadRequest to trigger a re-render of the sidebar if the querystring is present | 23:54 |
| hatch | the search view needs to be updated with the _charmbrowser dispatcher | 23:54 |
| hatch | right now the search view was always re-rendered | 23:54 |
| hatch | but the new implementation just hides it | 23:54 |
| hatch | I'm not available tomorrow but If you'd like we can chat about it tonight | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!