tsdgeosSaviq: answered in https://code.launchpad.net/~aacid/unity8/filtergrid_bindingloop/+merge/21614708:03
Saviqtsdgeos, tx08:04
tsdgeosSaviq: how are we doing on the landing side?08:17
Saviqtsdgeos, we ~need to wait for U to open08:18
tsdgeoswe should at least get https://code.launchpad.net/~aacid/unity8/card_optimizations/+merge/213660 in so qmluitests stop failing08:18
Saviqtsdgeos, yeah, already in a silo08:18
Saviqtsdgeos, but I don't want to SRU it08:18
Saviqdon't think it's worth the pain08:19
=== xnox is now known as NoNameYet_xnox
mhr3Saviq, how can i get more debug on "QUbuntu: Could not create application instance" ?08:21
Saviqmhr3, look in unity8.log08:21
mhr3Saviq, also, good morning :)08:22
mhr3Saviq, it's not unity though, it's an app08:22
Saviqmhr3, yes, look in unity8.log why it rejected it08:22
Saviqmhr3, did you pass --desktop_file_hint?08:23
mhr3ah, it really says something :)08:23
=== Chipaca is now known as UtilitarianUvula
mhr3Saviq, hm, keeps telling me that no desktop_file_hint was specified, even if i do specify it :/08:30
Saviqmhr3, full path? is it a bash wrapper by any chance?08:30
mhr3Saviq, it's.. complicated :)08:30
mhr3can try full path to it08:31
Saviqmhr3, the process which creates the Mir connection needs to have full path to the .desktop file on its command line08:31
Saviqmhr3, or be the main process launched by upstart-app-launch08:31
mhr3Saviq, is qtubuntu the one who tries to parse it out from the cmd line?08:33
Saviqmhr3, no, unity-mir is08:33
Saviqmhr3, if you wanted more output, you'd have to build unity-mir with no -DNODEBUG08:34
mhr3eek, it reads /proc/*/cmdline08:37
tsdgeosi did that i think ^_^08:41
tsdgeoson command by someone08:41
Saviqmhr3, the whole thing is eek indeed08:42
Saviqmhr3, which is why you should just build a .desktop file and launch via ual :P08:42
tsdgeosSaviq: see last comment of https://code.launchpad.net/~josharenson/unity8/doc_args/+merge/21664908:43
mhr3Saviq, and i am, but.. as i said.. complicated :)08:43
Saviqmhr3, and/or push Ted to do https://docs.google.com/a/canonical.com/document/d/1ODZjYjpMre2T-IFuFdBmzee4G0MRSsU4DbRkuZhts7o/edit ;)08:43
Saviqmhr3, yeah, I can tell you're doing something weird :P08:43
mhr3super weird ;)08:43
Saviqtsdgeos, or we could just use gettext there?08:44
SaviqOTOH translating --help? who does that :D08:44
tsdgeosSaviq: but then you need to load it there too because the loading we do in qml is too late08:44
Saviqtsdgeos, yeah I know08:45
tsdgeosSaviq: kde software does, that's why QCommandLineParser has the option08:45
Saviqtsdgeos, j/k08:45
Saviqtsdgeos, replied08:45
tsdgeosSaviq: i feel we could do with just pretending people don't and should not care about those comand line options that are kind of internal and not translate them for now08:45
Saviqtsdgeos, exactly what I said08:46
tsdgeosbut not sure what's our policy and if "everything should be translatable"08:46
tsdgeosah didn't read your comment in there08:46
mhr3Saviq, so what does ual do special that --desktop_file_hint isn't required then?08:51
Saviqmhr3, unity-mir talks to ual directly08:51
Saviqmhr3, so ual reports to unity-mir "hey, dude, there's app foo launching now, beware!"08:51
mhr3so it just tracks the pid?08:51
mhr3i see08:52
CimiSaviq, ~cimi/unity8/fix-locale-tests I removed the first line in the cmake as requested08:53
SaviqCimi, kk08:53
CimiSaviq, the other branch is still stripping tags..08:53
CimiSaviq, how do we want to deal with the logout? https://code.launchpad.net/~paulliu/unity8/logout/+merge/21637308:56
Cimiquitting is fine?08:56
SaviqCimi, yes, see the related unity-mir branch, it deals with everything else08:56
=== UtilitarianUvula is now known as Chipaca
CimiSaviq, tags were stripped from the update mir variables branch09:17
SaviqCimi, thanks09:17
CimiSaviq, on09:36
ubot5Launchpad bug 1309135 in unity8 (Ubuntu) ""required" value seems to be ignored in "rating-input" widget" [Undecided,New]09:36
CimiSaviq, basically he created a rating widget with both element displayed (review text and stars) but only stars required09:37
SaviqCimi, yeah, that should work09:37
SaviqCimi, only requiring the stars09:37
SaviqCimi, that's why it's separate to display vs. require09:38
tsdgeosSaviq: playing with run_on_device vs "installed image" i find that run_on_device seems laggier09:39
Saviqtsdgeos, CPU busy pushing text through adb?09:40
tsdgeosmaybe is because we're passing the -qmljsdebugger ?09:40
Saviqtsdgeos, or that, yeah09:41
mhr3Saviq, https://bugs.launchpad.net/unity-mir/+bug/131101109:47
ubot5Launchpad bug 1311011 in unity-mir "unity-mir authorizes any process with specific cmdline" [Undecided,New]09:47
Saviqmhr3, seen the FIXME there? ;)09:48
Saviqmhr3, but yeah, confirmed09:48
mhr3Saviq, nope, no fixme09:49
Saviqmhr3, well, ok, there's the thing above, says "Hack"09:49
Saviqmhr3, either way, confirmed09:49
* Saviq wonders if that's still needed, actually... the oxide renderer doesn't have that in its command line...09:50
tsdgeosi'm getting the "Caught an error from create_query(): unity::scopes::TimeoutException: Request timed out after 300 milliseconds" error10:13
tsdgeosbut i do have the scopes running10:13
tsdgeosany idea why that may happen?10:13
tsdgeosok, a restart helped10:14
CimiSaviq, if we have required only for the text, but no rating...10:26
Cimiquite weird a review without a rating10:26
SaviqCimi, that depends on what the underlying service implements10:57
SaviqCimi, so we need to make sure we support all the cases - even if it seems weird10:57
tsdgeoshe, silly me ^_^11:23
tsdgeosSaviq: remember when i was confused because by making the filtergridcard have an async loader it should make the list scroll perfectly even if the stuff just showed up blank and loaded later but it didn't?11:24
tsdgeoswell, basically i forgot to make the Card be the sourceComponent of the loader11:25
tsdgeosso the async wasn't having any effect ^_^11:25
tsdgeosnow if you do that, it's peachy smooth, but feels *ultra* weird11:25
Saviqtsdgeos, heh11:26
tsdgeosSaviq: i'll put a branch for you to try, but don't think we can go that way unless we somehow control the async loading better11:27
Saviqtsdgeos, meaning that you end up with screen completely empty and that after a few seconds the item loads?11:28
tsdgeosSaviq: yeah11:28
tsdgeosi mean not "a few seconds"11:28
tsdgeosbut yeah11:28
tsdgeoswe can play with it11:29
tsdgeosand try to make it so that the text is always there11:29
tsdgeosbut not sure how feasible it is11:29
Saviqtsdgeos, maybe a placeholder Rectangle { visible: !loader.status == Loader.Ready } would do }11:29
tsdgeosor a fake UShape11:29
Saviqyeah, or that11:30
Saviqbut if we say "a fake UShape and title", we're down to async-loading the image ;)11:30
tsdgeoswhich is async already11:30
tsdgeossince it comes from network11:30
tsdgeosmost of the times11:30
tsdgeosnot for the local app11:30
Saviqexactly, so if we can make it so that we can see a UShape and Text straight away, we need to make it so the actual Card shows them straight away ;)11:31
Saviqmeaning "if it's possible to show shape + text straight away", we need to make it so that the Card does it like that11:31
tsdgeoswell when i said fake UShape i meant an image that looks like an UShape11:31
tsdgeosnot an UShape11:31
=== MacSlow is now known as MacSlow|lunch
tsdgeosSaviq:  lp:~aacid/unity8/unity8_real_async_loader  you can see how it looks11:33
tsdgeosit's certainly smoother but awfully looking11:34
Saviqtsdgeos, kk11:34
tsdgeosi'll see how can i make it less bad11:34
Saviqtsdgeos, looks like card sizes got broken, too (see scopes scope - no margin in the middle)11:39
tsdgeosSaviq: with this patch? or without?11:40
Saviqtsdgeos, with11:40
jfiHi,about libappindicator, is the 'guide' parameter of app_indicator_set_label supposed to work in trusty? Whatever the way I set it, it does appear to be used. I also does not understand how it can really be useful as the font is not size fixed one. I don't see anyway to change it.12:00
jfidoes *not* appear to be used12:00
=== mpt_ is now known as mpt
=== _salem is now known as salem_
Saviqmhr3, is there a reason for unity8 to wait for scope-ui-starting to return?12:30
Saviqmhr3, == does scopes-shell deal fine with scope registry starting after the plugin started?12:30
mhr3Saviq, if it starts within 300ms12:31
Saviqmhr3, so, no ;)12:31
mhr3or whatever the timeout is for that12:31
mhr3might be a second12:32
mhr3Saviq, shouldn't the emit take like 20ms max?12:32
Saviqmhr3, yeah, it's fine, just adding a --no-wait to indicators, who don't care12:32
Saviqmhr3, will not add for scopes-ui-starting12:32
Saviqmhr3, also, ideas about scope tool triggering the scopes to start? should we just put an emit in tool's main()? can't think of a better solution...12:33
mhr3Saviq, hm, i find it meh cause it works fine when running through sdk12:34
Saviqmhr3, bug #131017212:34
ubot5bug 1310172 in unity8 (Ubuntu) "Unable to load scopes with unity-scope-tool" [Undecided,Confirmed] https://launchpad.net/bugs/131017212:34
mhr3you seldom need to debug all *installed* scopes12:34
Saviqmhr3, sure, please comment on the bug and mark as appropriate?12:36
Saviqmhr3, maybe we can give up a better error message? maybe something in the UI?12:37
=== andyrock is now known as andyrock-lunch
seb128jfi, try talking to tedg when he's around (he's in Texas so he might not be online yet)12:46
mhr3Saviq, i'm actually wondering why do we even install a .desktop for it13:06
Saviqmhr3, indeed13:06
Saviqmhr3, I already have a branch to drop the .desktop file13:17
=== MacSlow|lunch is now known as MacSlow
=== jhodapp|afk is now known as jhodapp
tsdgeosSaviq: ping13:46
Saviqtsdgeos, wassup?13:46
tsdgeosSaviq: so i made it so the external thing is not async and what is async is the shape13:46
tsdgeosso the text is always there on creation13:46
Saviqtsdgeos, tell me13:46
tsdgeosit's not as smooth as the other way13:46
tsdgeosbut it's better13:46
tsdgeosthere's the problem in which we align the header below the art13:47
tsdgeosand thus until the art is loaded the text is up and then jumps down13:47
Saviqshould be solvable, though, in case we know the height before its loaded?13:48
Saviqwhich is the case for the app cards13:49
paulliudandrader: hi, please re-review https://code.launchpad.net/~paulliu/unity-mir/logout/+merge/21633613:49
tsdgeosSaviq: do we? where does it come?13:50
Saviqmikenagle_, could use your input in bug #123797013:50
ubot5bug 1237970 in Unity Media Scanner Scope "Carousel in music scope should group songs by album" [Medium,Triaged] https://launchpad.net/bugs/123797013:50
Saviqtsdgeos, from CardTools13:50
Saviqtsdgeos, or well, we get aspect-ratio in the template, and that's the aspect ratio of the space in which the art will be13:51
Saviqtsdgeos, respective to card width13:51
Saviqtsdgeos, right now it's calculated in Card itself, should probably move out to CardTool...13:52
tsdgeosSaviq: you mean updateWidthHeightBindings ?13:53
Saviqtsdgeos, yeah, in a sense13:53
tsdgeosbut there we need the image to be loaded, no?13:54
Saviqtsdgeos, but we only need it to maintain the aspect ratio13:54
tsdgeosi understand what you say13:56
tsdgeoswill try to make it happen D:13:56
Saviqtsdgeos, basically, as we discussed before, anything that is calculated against components[] or template[] is a candidate for moving into the CardTool13:59
Saviqat least in aprt13:59
=== dandrader is now known as dandrader|afk
=== alan_g is now known as alan_g|tea
=== alan_g|tea is now known as alan_g
pete-woodslarsu: hi, we're getting a strange thing happening in HUD where what appear to be invalid menu indexes are being emitted through the items-changed signal (https://errors.ubuntu.com/problem/648b0ee396d66bc960c224a5794f5c22850b51ed) see frame #1214:37
pete-woodswondered if you might have any insight14:38
* larsu looks14:39
pete-woodsit looks like -1 is getting converted into an unsigned int somehow14:40
pete-woodsbut why we'd get an index of -1 being sent over the bus, I don't know14:40
pete-woodsit looks to me like the gmenu implementation internally converts -1 into the end of list index14:41
larsupete-woods: I don't think it does... can you reproduce this error locally?14:43
larsuI would like to see the dbus message that was sent14:43
pete-woodslarsu: unfortunately I'm not able to reproduce it, but the method g_dbus_menu_path_signal is directly connected to the dbus signal is it not?14:44
pete-woodsI realise we can't see the other params, though :(14:45
CimiSaviq, tsdgeos I noticed latest commits messages by albert on the card optimisation14:45
Cimishoouldn't we keep those on max 2 lines?14:46
SaviqCimi, yeah, that should've gone into Description14:46
SaviqCimi, not max 2 lines, but something reasonable14:46
pete-woodslarsu: we're planning an MR that just exits HUD in this condition and reports the application that triggered it14:46
pete-woodswe're putting all the debug info we can thing of in there (menu structure, that sorta thing). is there anything specific that would help you figure out what's going on?14:47
larsupete-woods: not really. let me check with desrt14:48
larsupete-woods: so, there are definitely some input validation issues in gdbusmenumodel. I'll fix those (or desrt might)15:13
larsuthose shouldn't lead to that crash though15:13
larsuand clearly someone is sending the invalid messages in the first place15:13
pete-woodslarsu: I guess I'm puzzled about how they have managed to get that message through, given that if you look at, e.g. g_menu_insert_item, it bounds the position to be between 0 and the menu length15:16
pete-woodsI guess there must be a crack somewhere it has sneaked through15:16
pete-woodslarsu: there are other instances where it looks like the menu index is reasonable (https://errors.ubuntu.com/problem/29678a80c8c2c42e53a74ca04751c29b8d7321d2)15:18
pete-woodsbut the client-side copy of the menu structure gets upset when you ask for them15:18
pete-woodsI don't know if this is related or not, and could potentially be memory corruption inside HUD15:19
pete-woodsinvestigating that case, we're simply accessing position 7 in the menu structure after being told is has been inserted, then gmenumodel asserts that we've given it an invalid index (albeit with a strange error message)15:20
pete-woodsI think (though am not certain) that if you give those accessors an out of bounds index (as far as it is concerned) then you get that "code should not be reached) assertion15:22
larsupete-woods: ya, and that makes sense I think, as there's no other way for gmenumodel to report an errror15:24
larsubasically, if you implement a gmenumodel, you need to do the bounds checking yourself15:24
pete-woodssure, it's a bit unfriendly to assert, I might prefer a null, but the thing that worries me is that we've just been instructed by the items-changed signal to access that index15:25
pete-woodsit goes, hey, there's new stuff at index 7, okay gimme that menuitem at index 7 then, assert failure15:26
larsuya, the input validation is definitely broken15:26
pete-woodssure, we could check the index range (and we will going forward), but it still makes me worry about what's going on15:26
pete-woodsokay, well as long as you think there's some sanity checking that could be added there15:27
pete-woodsI don't quite understand why the local copy of the menu hasn't been updated in this case, though15:27
pete-woodsbut maybe the input is just bad, as you say15:27
pete-woodsI guess we'll have to put some logic into HUD to just block an app as soon as it starts saying "crazy stuff"15:28
larsudefinitely. Especially since these apps can be untrusted15:28
larsupete-woods: if you're interested in following the upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=72873315:28
ubot5Gnome bug 728733 in gapplication "insufficient input validation in GDBusMenuModel" [Normal,New]15:28
Cimimzanetti, Saviq autopilot test for this? https://code.launchpad.net/~paulliu/unity8/logout/+merge/21637315:28
pete-woodslarsu: thanks :)15:29
larsuI'll try to fix that this week, I'm sure seb128 would be fine with a backport15:29
SaviqCimi, probably makes sense, yeah, I'd rather land it soon, though, so if we don't get it, we'll just file a bug that it's missing15:38
=== dandrader|afk is now known as dandrader
=== gatox is now known as gatox_lunch
Cimino internet at home for me (almost)16:23
Cimiconnected to a broken public ap16:24
=== gatox_lunch is now known as gatox
=== dandrader is now known as dandrader|afk
=== alan_g is now known as alan_g|EOD
=== andyrock-lunch is now known as andyrock
josharensonI'm trying to make unity8 dependent on qt5 v5.2 or greater. Is the only thing I need to change the 'qt5-default' line of the debian/control file?19:26
=== dandrader|afk is now known as dandrader
kgunndandrader: ^ josh's question...19:44
kgunnjosharenson: might have to wait till tomorrow on that one19:44
josharensonkgunn, no problem.. I've tried changing the value to something that would cause the build/app to break (to see if that was the correct pkg), but it won't break19:45
dandraderjosharenson, well, I would add a "(>= 5.2.1)" to all qt packages listed there19:50
josharensondandrader: ok, wasn't sure they _all_ needed it or if just 119:50
dandraderjosharenson, in practice just one should do the job... but changing all is safer and seems more correct IMHO19:51
seb128josharenson, why do you want to update the depends?19:51
seb128ideally a lib that changes its abi would bump its symbol/shlibs versions and rdepends would get the correct updated depends19:52
josharensonseb128 using a feature (QCommandLineParser) that is only available in >5.2.1  If this seems unecessary/bad idea, I can use a different method19:52
seb128josharenson, you can check with Mirv tomorrow (it's too late for him at this hour I think), I'm unsure if qt uses shlibs/symbols for that api, but otherwise you just need to update the depends for the library that provides QCommandLineParser19:53
josharensonseb128, alright. it looks like the lib is in libqtcore but since I didn't see a lib with that exact name in the control file19:55
seb128josharenson, libs are sometime grouped in packages which have a different name19:56
seb128but ask Mirv tomorrow if you want to be sure19:56
seb128josharenson, or submit a merge request and wait for the review comment19:56
josharensonseb128, ok thanks. Do you know his timezone?19:56
seb128whoever reviews it is going to comment on what you did19:56
seb128he's early european19:57
josharensonseb128, will do... thats how I got here in the first place19:57
seb128like 6am utc to 16pm utc19:57
seb128or somewhere between those19:57
=== beidl_ is now known as beidl
=== jhodapp is now known as jhodapp|afk
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!