davecheney | https://code.launchpad.net/~dave-cheney/juju-core/170-update-to-mgo-latest/+merge/217839 | 00:00 |
---|---|---|
davecheney | can someone hulk smash this revision | 00:00 |
davecheney | it will never apply, for reasons obvious from the error in the MP | 00:00 |
menn0 | mgz: turns out Will had already fixed this test but hadn't landed it in trunk. I've just marked the review as approved (with him sitting next to me). | 00:05 |
perrito666 | mgz: looks like what you need? lp:~hduran-8/goose/json_encoded_errors | 00:12 |
mgz | menn0: good job | 00:22 |
mgz | perrito666: loooooking | 00:22 |
menn0 | mgz: those changes landed and the tests pass now on my machine | 00:27 |
menn0 | mgz: hooray :) | 00:27 |
perrito666 | knock, knock, knock, mgz | 00:30 |
perrito666 | knock, knock, knock, mgz | 00:30 |
mgz | perrito666: just got the net back | 00:30 |
mgz | comment #1: we want the fallback 500 to include the unknown error string | 00:31 |
mgz | perrito666: looks okay past that | 00:31 |
mgz | -ify is a bit funny | 00:32 |
perrito666 | mgz: JSON, JSONEncode ? | 00:33 |
mgz | AsJSON? | 00:33 |
mgz | naming bikeshedding anyone? | 00:34 |
perrito666 | that sounds a bit like fantastic twins :p but I can fix that | 00:34 |
perrito666 | how do I lbox propose something and mark that it depends on another proposal? | 00:46 |
mgz | perrito666: it's a flag on propose, do --help | 00:53 |
menn0 | tedious but easy review please: https://codereview.appspot.com/95920043 | 01:02 |
mgz | menn0: you sorted out the appspot login thing? | 01:03 |
perrito666 | mgz: https://codereview.appspot.com/97870044 | 01:09 |
bodie_ | hello all, we're getting a bit hung up on the lifecycle stuff since we're trying to implement a new collection of docs for Action | 05:10 |
bodie_ | is there a technique for getting a unique sequential ID for a new document from txn? | 05:10 |
=== negronjl-afk is now known as negronjl | ||
stokachu | hazmat: see where that websocket library now supports py3/2? | 14:09 |
hazmat | stokachu, awesome! | 15:25 |
hazmat | stokachu, don't worry someone will rewrite deployer in go | 15:25 |
stokachu | hazmat: haha | 15:26 |
stokachu | deployer's logic for waiting on services before relating should go into the juju-core code | 15:26 |
stokachu | like a 'services pending relation' queue | 15:27 |
davecheney | jamespage: is there a utopic ami ? | 15:30 |
davecheney | or cloud image that I can test with ? | 15:30 |
jamespage | davecheney, http://cloud-images.ubuntu.com/utopic/20140429/ | 15:35 |
davecheney | jamespage: thanks | 15:41 |
davecheney | i guess they aren't published to ec2 | 15:41 |
davecheney | i'm addicted to the ec2 links on the cloud images page | 15:41 |
jamespage | davecheney, maybe not yet | 15:46 |
jamespage | davecheney, utlemming would know when | 15:46 |
perrito666 | mgz: strangely, the merge failed https://code.launchpad.net/~hduran-8/goose/testservice_errors/+merge/217818 | 16:18 |
dimitern | perrito666, vladk|offline, mgz, a quick review about showing networks in status? https://codereview.appspot.com/91000043 | 16:24 |
perrito666 | dimitern: lgtm I added a comment there | 16:28 |
dimitern | perrito666, cheers! | 16:29 |
=== vladk|offline is now known as vladk | ||
bodie_ | o/ jcw4 | 16:35 |
jcw4 | \o | 16:35 |
jcw4 | bodie_: I'll start adding the actionids to the unit | 16:36 |
bodie_ | sweet | 16:36 |
bodie_ | i'm hitting up rick for the hangout | 16:36 |
jcw4 | and investigating how the unit would pull the actions off and execute them | 16:36 |
jcw4 | bodie_: cool | 16:36 |
mgz | perrito666: that's odd | 16:59 |
adeuring1 | https://codereview.appspot.com/96950043 | 17:13 |
mgz | dimitern: did a post-landing review | 17:17 |
dimitern | mgz, cheers | 17:24 |
mgz | perrito666: lp:~gz/juju-core/os_listservers_errors_1222413 | 17:43 |
perrito666 | mgz: can you read me? if so pass me again the link, my irc proxy swallowed it | 17:59 |
mgz | perrito666: lp:~gz/juju-core/os_listservers_errors_1222413 | 18:00 |
dimitern | mgz, https://codereview.appspot.com/90970045 updated status as suggested | 18:06 |
mgz | perrito666: https://codereview.appspot.com/91010044 | 18:09 |
perrito666 | mgz: rvd | 18:10 |
menn0 | review please (Python script): https://codereview.appspot.com/94010044 | 18:11 |
perrito666 | mgz: ok, finally got your branch : | 18:27 |
perrito666 | :p | 18:27 |
mgz | :D | 18:28 |
=== negronjl is now known as negronjl-afk | ||
mgz | perrito666: landed first stage of your goose branches | 18:57 |
perrito666 | mgz: cool | 18:57 |
perrito666 | mgz: http://4.bp.blogspot.com/-YK_lIV2xxPs/T6iQnXqubbI/AAAAAAAAAUo/SY3DCN5mJzs/s1600/droopy-i-am-so-happy.jpg | 18:57 |
perrito666 | mgz: hey around your code, I cannot return json encoded error, I ether do a sendJSON with the encoded error and return the error or I return the actual error and you call yourself the json encoding | 19:08 |
mgz | perrito666: my code? | 19:10 |
mgz | or the bit in service_http.go? | 19:11 |
mgz | do a sendJSON for now if that's what you need | 19:11 |
perrito666 | the bit on service_http.go | 19:11 |
mgz | we want unified error handling later, but shortest path to sane error response is right for now | 19:11 |
perrito666 | mgz: I broke the universe https://pastebin.canonical.com/109483/ | 19:20 |
perrito666 | :p | 19:20 |
perrito666 | will see whats up later, gotta change chairs now | 19:20 |
mgz | perrito666: ...what did you do... | 19:24 |
mgz | perrito666: looks like your cast is not working | 19:25 |
perrito666 | mgz: nah, its the sendJSON part that is broken | 19:25 |
perrito666 | that I broke that is | 19:26 |
=== vladk is now known as vladk|offline | ||
mgz | perrito666: having any joy? | 20:36 |
=== vladk|offline is now known as vladk | ||
jcw4 | bodie_: ping | 22:13 |
mwhudson | how do i prevent bootstrap destroying the env if it fails? | 22:26 |
=== Ursinha is now known as Ursinha-afk | ||
jcw4 | bodie_: bits3rpent - I probably can't make the standup... fyi | 22:37 |
=== Ursinha-afk is now known as Ursinha |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!