/srv/irclogs.ubuntu.com/2014/05/01/#ubuntu-unity.txt

=== daek_ is now known as Daekdroom
=== jhodapp|afk is now known as jhodapp
=== jhodapp is now known as jhodapp|afk
=== salem_ is now known as _salem
=== deegee__ is now known as drussell
mzanettirpadovani: hey, you around?08:24
mhr3so quiet here08:33
mhr3scary08:33
Saviq;_08:39
Saviqhmm08:39
Saviqsmiley fail08:40
Cimilalaaaaaaaaaaaaaaa08:53
Cimimhr3, only people in uk are working :D08:53
mhr3Cimi, yea, we're the ones keeping the wheels turning :)08:54
Saviqexcept for the ones that don't have nothing better to do ;P08:54
mhr3Saviq, go away, we won't acknowledge you today! :P08:55
Saviqmhr3, I'm working today ;)08:55
Saviqso is mzanetti08:56
Saviqit's Labour Day, what is it without Labour!08:56
CimiSaviq, looks to me there's a new module for the infographics, right?08:56
Cimihah08:56
SaviqCimi, there shouldn't be, no08:56
SaviqCimi, there was one already08:57
mhr3Saviq, hr wouldn't be happy about you08:57
Saviqmhr3, I'll get it back the week after next :P08:57
dednickanyone running utopic yet?08:59
Saviqdednick, yes08:59
dednickSaviq: you having any issues with nameservers?08:59
Saviqdednick, not really, although there was a bug mentioned yesterday on the ML, me looks09:00
dednickevery time i boot, dnsmasq process is thrashing and my nameservers are reset09:00
Saviqbug #1307981 maybe?09:00
dednickhave to manually edit /etc/resolv.conf and add the ns09:00
ubot5bug 1307981 in network-manager (Ubuntu) "[touch] randomly messed up routing with recent trusty images" [High,Confirmed] https://launchpad.net/bugs/130798109:00
Saviqwell, then that's not it...09:00
CimiSaviq, there's this src/modules/Infographics/09:01
SaviqCimi, yeah, but that was there all along no?09:02
CimiSaviq, thought it was added here http://bazaar.launchpad.net/~unity-team/libusermetrics/file-based-infographics/revision/15409:02
Cimiunless this is trunk09:02
* Saviq looks for the previous moduel09:03
SaviqCimi, ah it looks that this was in lp:unity8 until now09:04
Cimiah ok09:04
SaviqCimi, or actually, qlightdm09:04
Cimiyes09:04
Cimiso it has to change indeed09:04
dednickhm. weird. removing /etc/NetworkManager/NetworkManager.conf seems to have fixed my problem09:13
dednickalthough it sounds a bit dubious09:14
SaviqCimi, yeah, and it needs to be cleaned up in our mocks09:15
mhr3Cimi, there's something weird with the rating input widget09:25
mhr3Cimi, i can't focus it 80% of the time09:25
Cimimhr3, what?09:29
mhr3Cimi, grab https://launchpad.net/~ci-train-ppa-service/+archive/landing-014/+build/5966633/+files/unity-scope-click_0.1%2B14.10.20140501-0ubuntu1_armhf.deb install on phone and try to review an installed app09:29
Saviqmhr3, Cimi, confirmed09:32
Cimimhr3, trying09:32
Cimialready rebooting09:32
SaviqCimi, mhr3, looks like something's wrong with "scroll and focus" or so09:33
Saviqit just scrolls a 1gu on tap09:33
Saviqsomething seems to be on top of the text entry09:34
mhr3Saviq, can you send reviews btw?09:34
Saviqmhr3, trying09:34
mhr3cause i just get09:34
mhr32014-05-01 10:21:51,622 - CRITICAL - ../../../../lib/SignOn/connection-manager.cpp 106 setupSocketConnection p2p error: QDBusError("org.freedesktop.DBus.Error.FileNotFound", "Failed to connect to socket /run/user/32011/signond/socket: No such file or directory") 109:34
Saviqmhr3, in registry log?09:35
mhr3yea09:35
Saviqmhr3, same09:35
mhr3"cool"09:35
Saviqmhr3, signond isn't running here, isn't it meant to be DBus-triggered or something?09:35
mhr3no idea09:36
SaviqOTOH it's probably wrapped in a library anyway, so there's something bad there09:37
SaviqCimi, while you're looking at the rating, there's some huge margin between the text and review input widgets, have a look please09:50
SaviqI wonder if we should have a HR before the review input widget, too09:50
Saviqobviously no visuals :|09:50
mhr3Saviq, the apps scope is being redesigned09:57
mhr3will look quite different soon09:57
Saviqmhr3, I know, it's meant to be "different" :P09:57
Saviqmhr3, but it's not just about apps scope, any preview that has description + review will get that09:58
CimiSaviq, might be minimum height of the review09:58
mhr3Saviq, even the description will look different :)09:59
Saviqmhr3, do you have something to show me?09:59
mhr3Saviq, had a peek yesterday, there was a tabbed view09:59
CimicontentHeight / lineCount * (maximumCollapsedLineCount - 2)09:59
mhr3so yey! :)09:59
Cimimight be this09:59
Cimifor the padding10:00
Saviqmhr3, heh... right on time for RTM then10:00
Cimithis google drive is a mess10:00
CimiSaviq, how do you browse between visual designs?10:00
SaviqCimi, https://drive.google.com/a/canonical.com/?usp=folder#folders/0B-a_7E3tDxOgWDlCSWxkUGZlcnM10:02
CimiSaviq, much better, thx10:03
Cimistarred10:03
Cimidash looks better than apps10:04
Cimihttps://drive.google.com/a/canonical.com/?usp=folder#folders/0B-a_7E3tDxOgTTBybG1TZG9GWnM10:04
Cimithis is much better than weather app10:04
Cimican I run the preview instead the weather app ? :D10:04
Saviqmhr3, see! devel branch is evil!10:05
Cimialso, this previews contains a sunshine, while my weather app currently shows clouds :D :D10:05
mhr3Saviq, why, what happened?10:05
Saviqmhr3, https://code.launchpad.net/~michihenning/unity-scopes-api/test-timeout-changes/+merge/217872/comments/51867210:06
mhr3ah10:06
mhr3minor issue :P10:06
mhr3also, stop peeking where you shouldn't :)10:07
* mhr3 is afraid Saviq will discover the terrible secrets10:07
Saviqmhr3, stop notifying me about all that!10:07
CimiSaviq, I think is seeMore being not visible but still counting for the childrenRect10:09
CimiSaviq, the padding between the rating and text10:10
dednickSaviq: spurious tags. is that anything with a ?10:10
CimiSaviq, am I correct that childrenRect doesn't care about visible or not?10:10
Saviqdednick, yeah10:11
dednickSaviq: there's one in trunk10:11
dednick7.85+14.10.20140428.2-0ubuntu1 ?10:11
Saviqdednick, oh interesting10:11
Saviqdednick, that sounds like a bug in train10:11
Saviqdednick, but that one I won't fight10:11
Saviqdednick, not worth it10:11
rpadovanimzanetti, hey10:12
rpadovanimzanetti, I have ~20 minutes now, otherwise I'll ping you this evening10:12
mzanettihey man.10:12
Saviqdednick, we had over 300 before, of which 280 were ? from lp:unity8....10:12
mzanettirpadovani: just wanted you to show this: https://code.launchpad.net/~mzanetti/reminders-app/color/+merge/21785010:12
mzanettirpadovani: and suggest that we create a shared branch on lp:~reminders-app-devs for the new design where we work together10:13
dednickSaviq: ok10:13
rpadovanimzanetti, sounds good to me10:13
mzanettirpadovani: because we probably want the transition to the new design in one big merge10:13
rpadovanimzanetti, I saw your branch, seems good, but I didn't test it yet10:14
rpadovanimzanetti, yes, perfect, do you do it? (the common branch)10:14
mzanettirpadovani: so lets do small branches but instead of merging them into trunk, lets merge them to the common one. so we still have small code reviews while getting the one big transition in one block10:14
mzanettirpadovani: yeah, I'll set it up10:14
rpadovanimzanetti, awesome, thanks!10:16
mzanettirpadovani: ok... talk to you later then... we can set that up tonight10:17
mzanettihave to do some unity business now10:17
rpadovanimzanetti, ok, see you tonight then, have a nice day!10:18
Saviqgreyback, don't touch root CMakeLists.txt in unity-api, increment just the one in include/shell/…10:25
Saviqgreyback, also, bump changelog for unity-mir to be able to depend on the change10:25
greybackSaviq: none of this is is for promoting yet. But point 1 is good10:26
Saviqgreyback, kk10:26
Saviqgreyback, mark WiP then?10:26
greybackSaviq: I'm not merging into lp:unity-api but I want a review from maznetti10:26
greybackah shoot10:27
Saviqgreyback, you can get a review on a WiP branch :)10:27
greybackSaviq: it's not WiP, I want to iterate on a separate branch for qtcompositor support, so want to go through usual review process10:30
Saviqgreyback, ok :D10:30
CimiSaviq, fix for padding https://code.launchpad.net/~cimi/unity8/preview-text-summary-bottom-padding/+merge/21790310:30
SaviqCimi, tx10:36
CimiSaviq, how do I debug where my touches go?10:36
CimiSaviq, on the rating input widget issue10:36
CimiSaviq, looks like indeed scrolling does not move mousearea or so10:37
SaviqCimi, can't tell you much more than to put MouseAreas here and there10:37
SaviqCimi, and see which one reacts10:38
CimiSaviq, nope is not mouse areas moving10:38
CimiSaviq, it's the scrolling10:39
CimiSaviq, if you quickly tap the tap is interpreted as scrolling10:39
SaviqCimi, re: text widget, let's use Column there, childrenRect is unreliable when the height changes10:39
CimiSaviq, try holding the finger on the text review widget and you see that when you lift the finger it gets input10:39
SaviqCimi, and implicitHeight will be easier10:39
SaviqCimi, and anchors simpler10:39
CimiSaviq, I'll try10:40
CimiSaviq, let's go back to this input thing10:40
CimiSaviq, would it be possible that lvwph is stealing inputs?10:41
SaviqCimi, there's no lvwph in there10:41
SaviqCimi, just a flickable10:41
Cimiwhatever then10:41
Cimiso if you ddon't scroll10:41
Cimiwhen you open the preview10:41
Cimitextarea immediately gets input10:41
Cimiotherwise, you have to hold10:42
SaviqCimi, interesting...10:42
SaviqCimi, btw, it should scroll up on focus10:42
SaviqCimi, otherwise it ends up behind the keyboard10:42
Saviqbut yeah, back to the issue at hand10:43
CimiI agree with that (how do we do this?)10:43
CimiI hope we have auto scrolling from the sdk/osk10:43
SaviqCimi, the expandables in the SDK should help10:43
SaviqCimi, try and reproduce the issue with a simple TextArea in a Flickable10:44
=== shiznix_ is now known as shiznix
CimiSaviq, I think is a focus issue10:45
Cimibuttons seems to behave ok10:45
CimiSaviq, ok, another finding10:47
CimiSaviq, scroll, quickly tap on text area, wait 300ms, tap -> focus10:47
CimiSaviq, seems like the flickable keeps focus or something10:48
Cimiso you either tap and hold after scroll or you need a second tap10:48
SaviqCimi, flickable can't "keep focus", tapping on a text area forces the focus on it, assuming it actually gets the touch input10:49
SaviqCimi, and touch input does not care about focus10:49
mhr3Saviq, ok if we land the click scope changes even though the widget is odd?11:00
CimiSaviq, shall I use anchors left and right inside column items?11:00
SaviqCimi, yes11:00
CimiSaviq, or width?11:00
Saviqmhr3, you tell me, it's not working ;)11:00
SaviqCimi, anchors11:00
Cimiagree, I prefer11:00
Cimipushing11:00
mhr3Saviq, but theoretically it doesn't introduce a regression :)11:01
Saviqmhr3, back to unity times, eh? :P11:01
Saviqmhr3, let's find a fix, make it work, then land?11:01
Saviqmhr3, unless you're pressed for landing?11:01
Saviqdamn apport-bug11:02
mhr3Saviq, nah, i'm ok with waiting11:02
mhr3will talk to dobey about the signon issue11:02
CimiSaviq, ok https://code.launchpad.net/~cimi/unity8/preview-text-summary-bottom-padding/+merge/21790311:03
mhr3i do wonder how do they test their stuff if they didn't notice this weirdness11:03
Cimishit, test fails11:03
Saviq;)11:04
CimiSaviq, weird, needs time with column11:06
* Cimi replaces compare with trycompare11:06
SaviqCimi, sure, column needs to wait for its children to lay them out11:06
SaviqCimi, and it's not really about time, but about letting the event loop spin11:07
CimiSaviq, thx11:08
Cimitest fixed11:08
=== jhodapp|afk is now known as jhodapp
SaviqCimi, you can't set topMargin in a column11:50
=== alan_g is now known as alan_g|lunch
=== _salem is now known as salem_
CimiSaviq, ok12:07
CimiSaviq, I will add it to height of the text item12:07
SaviqCimi, you'd know if you looked at the debug output ;)12:07
CimiSaviq, no debug12:07
SaviqCimi, sure debug12:07
Saviqwell, no debug12:07
Saviqjust log output12:07
SaviqCimi, with try*, you get output after you close the thing12:08
Cimicimi@draco:~/Development/unity8/card-touchpress/builddir$ make tryPreviewTextSummary12:08
CimiQML debugging is enabled. Only use this in a safe environment.12:08
Cimifile:///usr/lib/x86_64-linux-gnu/qt5/qml/QtTest/TestCase.qml:345:32: Unable to assign [undefined] to bool12:08
Cimiunless this is the famous debug12:08
SaviqCimi, maybe that's because you don't have a top anchor, so it doesn't care at all12:09
SaviqCimi, something's wrong, btw, with your change the expand / contract is not smooth12:09
CimiSaviq, here is smooth12:12
SaviqCimi, well, here it isn't ;P12:12
CimiSaviq, column maybe12:12
SaviqCimi, column deals just fine with growing items12:12
CimiSaviq, I fixed and pushed the anchors12:14
CimiSaviq, no idea for the issue with the animated expansion12:14
CimiSaviq, there's a Behaviour on height12:14
Cimiyou sure your computer is not just skipping frames?12:15
SaviqCimi, you're not the only one with a i7 quadcore :P12:15
SaviqCimi, but imagine that I compared the two!12:15
Saviqis smooth before, not smooth after12:16
Saviqcrap, if only we could have slow animations...12:17
CimiSaviq, ah you mean it skips frames?12:17
Cimiso you see the animation but not smooth?12:17
Cimiit must be the column12:18
Cimibtw there were some designs with seemore/less12:18
Cimicannot find them anymore12:18
SaviqCimi, yeah, were for tablet, gone atm12:18
SaviqCimi, I'd be really worried if it was indeed Column that caused the slowdown12:23
SaviqCimi, but it does seem like it...12:25
CimiSaviq, cannot reproduce with my i7 477012:25
Cimi8-)12:25
SaviqCimi, http://pastebin.ubuntu.com/7372630/12:28
SaviqCimi, there's less height changes with a Column :|12:28
Saviqwth12:28
Cimiyeah12:28
Cimibtw12:28
Cimithis is more correct probably12:29
Saviq    onImplicitHeightChanged: console.log(implicitHeight)12:29
Saviqno it's not, if I can see the difference12:29
Cimihttp://paste.ubuntu.com/7372635/12:29
Saviqin a sense it is12:29
CimiSaviq, shall I go back with anchors?12:32
CimiSaviq, also, looks simpler with anchors to me :D12:32
Cimionly thing I am not a fan of is the implicitheight calculation12:33
SaviqCimi, how can it look simpler than just having a few items in a Column? ;)12:33
CimiSaviq, look at the last patch12:33
SaviqCimi, ETOOMANY childrenRect.height12:34
Saviqthat's definitely not simpler12:34
CimiSaviq, I can use the direct id12:34
Cimisame story12:34
Saviqyeah, not simpler IMO12:35
CimiI want to add padding at the top12:35
Saviqlet me try on the device12:35
Saviqwith the column12:35
Cimionly way to do it is with an empty item12:35
Saviqsure, yeah, having padding in columns is something I miss dearly12:35
Cimithe old tablet designs had 1 gu spacing, that's why I added12:35
Cimimight be better without12:36
Cimiin my opinion12:36
Cimibut we don't have designs12:36
SaviqCimi, so yeah, we need ExpandableColumn in there, expanding text should come on screen too12:37
SaviqCimi, but I can't see the Column issue on the device12:37
Saviqlooks plenty smooth (but it's too fast, too, should be velocity based, not duration based)12:38
CimiSaviq, which preview has seemore/less?12:40
Cimididn't find long description so far12:40
SaviqCimi, xbmcremote for example12:40
Cimicool12:40
SaviqCimi, but yeah, let's go with Column, it really is simpler - and we want the margin under text as well as under the see more / less widget12:41
SaviqCimi, but I think we need a HR on top of review input, otherwise it's bad with text12:41
CimiSaviq, with last patch looks awful with column12:41
Ciminot be able to add topmargin12:41
SaviqCimi, but you added 1gu in text height, that should be fine12:43
SaviqCimi, basically what I'm saying, your current branch looks good12:43
CimiSaviq, no12:43
Saviqbut does need a HR12:43
CimiSaviq, if you add 1px to text height12:43
CimiSaviq, you add one gu of text clipped12:43
Cimiwhile we want 1 px of padding12:44
Cimiso the text must not be 1gu taller12:44
Cimiwhile we need an item to add spacing12:44
SaviqCimi, yeah, either add a 1GU-high empty item, or wrap the label in an item + 1GU high12:45
Cimithat's what I did12:46
Cimihttp://paste.ubuntu.com/7372635/12:46
Cimilooks bad12:46
CimiI prefer with anchors12:46
SaviqCimi, just add a Item { height: units.gu(1) } between them12:47
SaviqCimi, we want the 1gu padding under text itself, too12:48
CimiSaviq, http://paste.ubuntu.com/7372703/ vs http://paste.ubuntu.com/7372718/12:51
CimiI have no preferences12:51
SaviqCimi, we *want* it even if there's no seeMore12:52
Ciminope12:52
Cimiall other preview widgets have no extra padding12:52
Saviqok, spacing is done in the listview12:53
SaviqCimi, go for the wrapping one, but drop the id and objectName from seeMore (only leave it in seeMoreContainer), and don't add the second visibility test12:54
CimiSaviq, I need it for tests12:55
SaviqCimi, you don't need to test it, that's what I'm saying12:55
SaviqCimi, btw, anchors { left: parent.left; right: parent.right } usually read better12:55
CimiI need to test seeMore.more12:55
Cimiand such12:55
Saviqright12:55
Cimialso, since we are here, I tested the container that goes away12:56
Cimiadding one line of test doesn't hurt if it's basically easy and free to do12:56
SaviqCimi, +            compare(seeMoreContainer.visible, true)?12:56
Cimimistake12:56
Cimiis false12:56
Cimialready corrected in second patch12:56
Saviqbleh12:57
Saviqnot being to do padding in columns is bleh12:57
SaviqCimi, ok, I take that back12:59
CimiI pushed with the nested item12:59
SaviqCimi, if we have to do it like this, go back to anchors, it's awful with the hacked-in padding12:59
SaviqCimi, sorry12:59
Cimifinally! :D13:00
Cimino worries13:00
Cimiwe discovered this ugly behaviour13:00
Saviq/food13:01
=== alan_g|lunch is now known as alan_g
Cimiwhen network says connected but it bloody doesn't work13:16
Cimiany fix apart rebooting and praying?13:16
mhr3Cimi, you can try rebooting without praying :)13:37
Cimimhr3, nope13:44
Cimidoesn't like my prays13:44
Cimiwe need an online connectivity check13:45
Cimiseeing the dash and previews and such full empty13:46
Cimiblank pages13:46
Cimiis weird13:47
Cimidednick, I have same issue with resolv.conf13:49
Cimiand others13:51
Cimidammit13:51
Cimimhall119, it is possible to launch https://developer.ubuntu.com and looks broken (http is fine)14:17
CimiSaviq, which animation shall I use for the behaviour?14:18
SaviqCimi, which behaviour?14:18
CimiSaviq, height expansion14:19
Cimiin textareass14:19
SaviqCimi, UbuntuAnimation with SnapDuration I'd say14:19
CimiSaviq, UbuntuAnimation { duration: UbuntuAnimation.SnapDuration } ?14:20
mhall119Cimi: file a bug please, we need to fix the theme headers to use the same protocol as the original request (the css files are hard-coded to use http:// currently)14:20
SaviqCimi, yeah14:21
CimiSaviq, ok done14:21
Cimipushed14:21
greybackanyone remember how to disable automatic mtp mounting of devices?14:22
Saviqgreyback, setprop sys.usb.config=ptp,adb14:22
Saviqgreyback, setprop persist.sys.usb.config=ptp,adb14:22
greybackSaviq: nothing on the PC side, no?14:23
Saviqgreyback, nope14:23
greybackSaviq: ok, thanks14:23
Saviqgreyback, well, you could kill the mtp monitor14:23
SaviqCimi, yikes on http://bazaar.launchpad.net/~cimi/unity8/preview-text-summary-bottom-padding/revision/876, why didn't the previous approach work?14:23
CimiSaviq, previous approach wasn't counting on invisible textlabel...14:24
Cimititlelabel..14:24
Cimiunless a Label with text = "" is 0 px height14:24
Cimiresult seems similar, this looks just more correct14:25
Saviqthis whole thing makes my eyes water :P14:25
CimiSaviq, yeah, my code is like chopping fresh onions14:25
Cimilet me see if height when text == "" is 014:26
Cimiin this case we can remove that logic14:26
SaviqCimi, you can just do "height: visible ? implicitHeight : 0"14:26
SaviqCimi, that's actually what we did in CardHeader.qml14:26
Cimilet me do the same for the seemore then14:26
Cimihttp://paste.ubuntu.com/7373290/14:28
mhall119Cimi: don't worry about that bug, a fix is in the pipeline already14:28
Cimimhall119, filed already14:28
Cimihttps://bugs.launchpad.net/ubuntudeveloperportal/+bug/131501614:28
ubot5Ubuntu bug 1315016 in Ubuntu App Developer site "Theme is broken using https" [Undecided,New]14:28
=== alan_g is now known as alan_g|tea
=== alan_g|tea is now known as alan_g
CimiSaviq, how to restart shell from phone? restart unity8 as phablet?14:53
SaviqCimi, yes14:53
Cimiit does not here14:53
SaviqCimi, how did you log in as phablet?14:58
CimiSaviq, sudo -u phablet -i14:58
SaviqCimi, and what does "restart unity8" say?14:58
CimiSaviq, hangs14:59
SaviqCimi, does not hang, but waits for unity8 to exit (it does take some time)14:59
SaviqCimi, you can also just go "pkill unity8"14:59
SaviqCimi, it will respawn14:59
Cimihaving a working wifi would dimplify my life here15:00
Cimion this ubuntu phone15:00
CimiI throw this phone15:14
CimiSaviq, bootstrap, no luck15:14
CimiI keep rebooting15:14
SaviqCimi, file a bug15:14
Cimifeels like windows ME15:15
Cimiahah15:15
* mhr3 wouldn't like to be close to Cimi now15:15
Cimimhr3, why not, I throw free Nexus 4s15:15
mhr3Cimi, i'd be worried you throw it in my face :P15:15
Cimiroot@ubuntu-phablet:~# cat /etc/resolv.conf15:17
Cimi# Dynamic resolv.conf(5) file for glibc resolver(3) generated by resolvconf(8)15:17
Cimi#     DO NOT EDIT THIS FILE BY HAND -- YOUR CHANGES WILL BE OVERWRITTEN15:17
Ciminameserver 127.0.1.115:17
CimiWHY15:17
Cimiwhat's this15:18
Cimiah there;s dnsmasq15:19
=== salem_ is now known as _salem
=== jhodapp is now known as jhodapp|lunch
* greyback akf for 45 mins15:34
Saviqxnox, hey, can I bug you for some CMake pointers?15:35
xnoxSaviq: go ahead!15:38
Saviqxnox, so... I'm looking for a recommended way to override an executable (qmltestrunner) that we've been finding with find_program until now15:39
Saviqxnox, problem with find_program is that once it finds something, it will keep it until the cache is removed15:39
Saviqxnox, I started with add_executable(... IMPORTED ...), but that only really works for add_custom_command AFAICT, and we need to prefix with env anyway15:41
xnoxSaviq: find it each time -> as in don't do find_program at all.15:42
Saviqxnox, how can I find other than find_program?15:42
xnoxSaviq: can't you just call it, and then set appropriate PATH if you want to use some other one.15:42
xnoxSaviq: can you point me at package / example you are working on, to play with locally.15:42
xnox?15:42
Saviqxnox, lp:unity815:43
Saviqxnox, cmake/QmlTest.cmake15:43
Saviqcmake/modules that is15:43
Saviqxnox, you might puke at this module, too...15:45
xnoxSaviq: so far my bzr is having a heart attack pulling updates =)15:45
=== _salem is now known as salem_
Saviqit's grown some cruft over time, I'm starting to feel like we're abusing cmake there...15:46
Saviqbut it's been working for us somewhat ;)15:46
xnoxSaviq: so you shouldn't do find_program outside the macro15:47
Saviqxnox, noted15:47
xnoxSaviq: you should do it inside the macro and set the found binary as a target variable15:47
xnoxSaviq: and possibly you don't need find_program(qmltestrunner_exe) at all.....15:47
xnoxSaviq: just drop that hunk, no?15:47
=== josharenson is now known as josharenson|bike
Saviqxnox, well, it was a "let's give a helpful message on why this fails" thing15:48
xnoxSaviq: you don't use that variable.15:48
Saviqxnox, yeah we do15:48
Saviqxnox, line 10715:48
Saviqand 12215:48
Saviqgranted, not in the best way possible... that's why I feel like we're abusing the shit out of cmake..15:49
xnoxSaviq: don't use qmltestrunner_exe variable and just replaces those instances with "qmltestrunner"15:49
xnoxSaviq: keep the top level check, for well, just the FATAL_ERROR15:50
xnoxSaviq: that way the users of that macro can override things as they wich, e.g. by setting custom path.15:50
xnoxs/wich/wish/15:50
Saviqxnox, right, so set that variable from the outside?15:50
Saviqxnox, and expect users of that macro to do the same?15:51
xnoxSaviq: no, i mean this -> http://paste.ubuntu.com/7373813/15:51
xnoxSaviq: at the top you assert that qmltestrunner is available on the path, later you just keep on assuming that =)15:51
Saviqxnox, ok understood15:52
xnoxSaviq: cause e.g. in qmltest_ENVIRONMENT i can say PATH=/path/to/my/custom/qt/bin:$PATH15:53
xnoxSaviq: and by magic the right qmltestrunner will be used.15:53
Saviqxnox, right, didn't want to name a wrapper around qmltestrunner the same, but maybe that's ok...15:53
Saviqwanted to be slightly more explicit15:54
xnoxSaviq: this way i set path; executed marco for e.g. qt4; set different path; execute marco for e.g. qt5 and that will all work.15:54
Saviqxnox, ok, understood15:55
xnoxSaviq: you can do further checks, e.g. if someone did set variable on the target -> use that, else fallback to finding one from find_programm or some such.15:55
Saviqxnox, "did set variable on the target"? what do you mean by that?15:55
xnoxSaviq: that's convoluted, but that's how e.g. Qt5::moc are done15:55
xnoxSaviq: set_target_properties15:56
Saviqxnox, ah you mean to check if(TARGET qmltestrunner)?15:56
xnoxSaviq: instead of using global variables, you can set variables/per target.15:56
Saviqxnox, how do I get the path from that target then? other than get_target_properties?15:56
CimiSaviq, you have any clue what could cause this input issue?15:57
SaviqCimi, afraid not15:57
CimiSaviq, a nice mouseArea filling the whole ratinginput DOES get all events15:57
xnoxSaviq: checkout Qt5 upstream cmake modules for e.g. how Qt5 ::moc is handled. i'm fuzzy on the details.15:57
Saviqxnox, ok thanks15:57
CimiSaviq, weird!!!!! https://www.youtube.com/watch?v=uWUb6yuWRjI16:06
CimiSaviq, I open preview16:06
CimiSaviq, scroll down16:06
CimiSaviq, tap-hold around the text area16:06
CimiSaviq, it jumps back the scrolling16:06
SaviqCimi, well, yeah, it's weird that tapping on the text area scrolls a bit up, too16:07
Saviqxnox, ah, one more q, can't find docs about it, what does "AND COMMAND foo" do for add_executable?16:09
CimiSaviq, onFocusChanged: if (focus) column.positionViewAtIndex(index, ListView.Contain) in Preview.qml sounds strange16:10
* Cimi disables that line16:10
SaviqCimi, right, that one was meant to do the scrolling indeed16:10
CimiSaviq, of couse wifi stopped working after I pushed that change16:14
Cimiso I cannot test16:14
CimiMurphy is testing my patience today16:14
xnoxSaviq: it's a boolean operator16:17
xnoxSaviq:  if(COMMAND command-name)16:17
xnoxTrue if the given name is a command, macro or function that can be invoked.16:17
Saviqxnox, right :)16:18
Saviqxnox, so, add_executable(Qt5::qmake IMPORTED AND COMMAND "/usr/lib/$ENV{DEB_BUILD_MULTIARCH}/qt5/bin/qmake")16:19
Saviqxnox, that does not create the target if the command doesn't exist?16:19
Saviqxnox, that's from MultiArchCross.cmake16:19
CimiI need connectionnn16:20
xnoxSaviq: I believe that is the intention yes.16:21
Saviqxnox, ok, thanks again, you got me on the right track :)16:21
Saviqxnox, fwiw, that construct (with AND COMMAND ...) doesn't seem to work, it happily continues trying to run a bogus executable16:26
xnoxSaviq: maybe it's utterly wrong.16:28
Saviqxnox, it does feel like it :)16:29
xnoxSaviq: need to check docs of add_executable, cause COMMAND i quoted above is for "if", not add_executable =/16:29
Saviqxnox, yeah, nothing re: COMMAND is there in add_executable docs, that's why I asked in the first place16:30
=== salem_ is now known as _salem
xnoxSaviq: i'm surprised it even works then ;-)))))16:34
Saviqxnox, yeah, it just ignores it16:35
Saviqxnox, cmake has this habit, doesn't it16:35
=== alan_g is now known as alan_g|EOD
CimiI really need to have wifi working16:39
Cimiwho has ideas here?16:39
CimiI did bootstrap and reinstalled16:39
SaviqCimi, try with a different wifi?16:40
CimiSaviq, I have 4 AP at home, none works16:40
Cimiit's a phone thing16:40
Cimiit works like after 5 reboots16:40
Cimithen I test something16:40
Cimiand doesn-t work anymore16:40
SaviqCimi, try with stable16:41
SaviqCimi, try with android on the phone16:41
Ciminot flashing android :)16:41
SaviqCimi, you need to try and drill down on the variables16:41
Cimiok I will16:41
SaviqCimi, why not? to check if your HW is still fine?16:41
CimiSaviq, this textarea issue I bet is SDK16:47
SaviqCimi, I don't, the onFocus thing might be at fault16:48
CimiSaviq, I commented16:48
Cimistill issue16:48
CimiI have a lot of code commented16:48
Cimieven no page header16:48
SaviqCimi, tried replacing it with a single-line text edit, or with a QML area?16:49
CimiSaviq, was about to do it16:50
=== _salem is now known as salem_
CimiSaviq, I cannot reproduce the input issue anymore on the stars, just text area16:51
Cimiso I just put textedit16:51
SaviqCimi, I think it'd be faster if you didn't type on IRC every time you find something out ;)16:53
SaviqCimi, just dive into it, come back when you know what's going on, or need help ;)16:53
Cimiok same issue16:53
Cimiok :))16:53
CimiI feel less lonely16:53
=== salem_ is now known as _salem
CimiSaviq, workd with TextField17:13
Cimitomorrow I'll try playing with the MouseArea inside  the TextArea, seeing if there's a bug here17:18
=== jhodapp|lunch is now known as jhodapp
=== josharenson|bike is now known as josharenson
=== jhodapp is now known as jhodapp|afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!