| === chriadam|away is now known as chriadam | ||
| vthompson | balloons, jhodapp, I have some questions about a MP that the music-app has in place to test the swap-buffers bug that was fixed for Qt5.2: https://code.launchpad.net/~vthompson/music-app/proceeds-to-next | 00:32 |
|---|---|---|
| vthompson | jhodapp, I haven't seen the tracklist implementation of the media-hub in any detail yet, but would I be correct in assuming that there won't be anything in place to notify/wake the music app from suspension when the track switches? | 00:34 |
| vthompson | balloons, do you know if AP can retrieve component properties from an app that is suspended? | 00:40 |
| jhodapp | vthompson, unknown atm, that part of background playlist isn't implemented yet | 01:17 |
| vthompson | jhodapp, thanks. We'll hold off on landing our AP test branch then. I assume you guys will have your own AP/unit tests for the tracklist implementation? | 01:20 |
| jhodapp | vthompson, yes indeed | 01:20 |
| jhodapp | vthompson, any reason why you can't land that now? | 01:21 |
| vthompson | jhodapp, because the tests go through a sleep that should put the app into suspension. Right now we are granted a lifecycle exception so we are always on... but the goal is to remove that exception when tracklist media-hub lands. | 01:23 |
| jhodapp | vthompson, k | 01:23 |
| vthompson | jhodapp, when that does happen, music-app will suspend like the rest and I'm not sure the AP test can get the info we want it to when it checks the suspended app | 01:23 |
| jhodapp | vthompson, right, so you need to rely on media-hub then to get that persistence across suspension | 01:24 |
| vthompson | jhodapp, yep, but simply having that data in MediaPlayer when we awake isn't enough (I assume) to allow this test to work in our suite. Since track management is media-hub's responsibility it sounds like it's not a worthwhile test in the music-app | 01:27 |
| jhodapp | vthompson, yeah it'll be well tested in media-hub since it's a primary reason for even having media-hub :) | 01:30 |
| === _salem is now known as salem_ | ||
| bzoltan1 | pmcgowan: xhoch3: yes, the SDK PPA has exactly the same stuff as Utopic achive | 03:05 |
| === salem_ is now known as _salem | ||
| === chihchun_afk is now known as chihchun | ||
| Aki-Thinkpad | evening all | 06:00 |
| Aki-Thinkpad | morning for some; I'm sure | 06:00 |
| dholbach | good morning | 06:34 |
| justCarakas | Good morning all | 06:58 |
| dpm | morning nik90, around? | 07:24 |
| dpm | and good morning everyone :) | 07:24 |
| justCarakas | good morning dpm | 07:25 |
| dpm | hi :) | 07:26 |
| === chriadam is now known as chriadam|away | ||
| JamesTait | Good morning all; happy No Homework Day - my boys will be thrilled! :-D | 08:00 |
| dholbach | justCarakas, didn't you ask where JamesTait was? ^ :) | 08:01 |
| justCarakas | dholbach: I did :D | 08:01 |
| dholbach | good morning JamesTait! :) | 08:01 |
| justCarakas | Welcome back JamesTait I missed your morning greetings | 08:02 |
| JamesTait | dholbach, justCarakas: o/ | 08:02 |
| justCarakas | JamesTait: \ o | 08:03 |
| Aki-Thinkpad | bah this is annoying having to ask this... In Python, I can treat strings as an array, doing something like mystring = "hello world"; | 08:09 |
| Aki-Thinkpad | and then mystring[0:3] would return "hell" | 08:09 |
| Aki-Thinkpad | how can I do that in qml, javascript, or c++ | 08:09 |
| Aki-Thinkpad | im not sure what language applies for a qml property | 08:10 |
| Aki-Thinkpad | I know you can do mystring[0], and get "h", but I don't know how to define a range | 08:10 |
| mzanetti | dpm: hey, wanna do a couple of reviews? | 08:11 |
| dpm | mzanetti, do you have some more nice features for me? :-) | 08:12 |
| mzanetti | dpm: https://code.launchpad.net/~reminders-app-dev/reminders-app/new-design/+activereviews | 08:12 |
| dpm | I'm excited already by the title of the MR :) | 08:12 |
| dpm | give me a few mins to finish what I was doing and I'll have a look | 08:13 |
| mzanetti | dpm: don't review the one from rpadovani yet. I need to ask him to rebase it | 08:13 |
| dpm | ack | 08:13 |
| mzanetti | dpm: but the 2 branches of mine should be fine I hope | 08:13 |
| dpm | ok | 08:13 |
| Aki-Thinkpad | dpm, oh hey I got the source downloaded and such. My first goal is to submit one patch. Atm I am usure if my environment is clean though, as I am having issues loading images which is causing performance issues | 08:15 |
| dpm | Aki-Thinkpad, what issues exactly? Are you seeing lots of warnings on the console output? If so, I'm seeing those too :) | 08:16 |
| Aki-Thinkpad | dpm, yah, http://i.imgur.com/blh8v33.jpg | 08:17 |
| dpm | Aki-Thinkpad, btw, thanks for getting started on this! I saw your request to join the team, but I prefer to add members once they've done at least a contribution, I hope that's ok for you? | 08:17 |
| Aki-Thinkpad | dpm yah I I know the drill | 08:17 |
| Aki-Thinkpad | :) | 08:17 |
| dpm | great, thanks :) | 08:18 |
| Aki-Thinkpad | so is that output what you are seeing? Is this a biproduct of the run environment? | 08:18 |
| dpm | mzanetti, so Aki-Thinkpad is getting his system set up to help with reminders. He could build the app already and he's seeing some warnings/errors related to images in the QtC console output. I too could see them, but I haven't bothered too much about them. Any ideas if this is something we should worry about? http://i.imgur.com/blh8v33.jpg | 08:19 |
| mzanetti | dpm: hmm... not sure... works on my macbook. must be the thinkpad | 08:20 |
| dpm | hahaha | 08:21 |
| mzanetti | no... seriously... don't know what it is | 08:21 |
| mzanetti | if images are missing in the notes we should worry about it, yes | 08:21 |
| dpm | one set of errors is clearly that the app cannot write to the .cache dir. Perhaps it has not been created? I don't actually know what creates the .cache/com..... dir on the desktop | 08:21 |
| mzanetti | I'll keep an eye on the console | 08:21 |
| dpm | for me the images are downloaded and I can see them fine, but the console messages are still there | 08:21 |
| Aki-Thinkpad | dpm, can't miss it. I was thinking about the cache. I'll go check if its been created. | 08:22 |
| mzanetti | strange... I think I create the cache dir myself if its not there yetp | 08:22 |
| Aki-Thinkpad | mzanetti, * | 08:22 |
| mzanetti | hi Aki-Thinkpad | 08:22 |
| Aki-Thinkpad | hey | 08:22 |
| dpm | yeah, it's quite possible that on the desktop the .cache dir is not created automatically | 08:22 |
| mzanetti | I'll check where they come from | 08:22 |
| Aki-Thinkpad | yah I think that might be it. Manually creating the directory | 08:23 |
| dpm | ok, cool | 08:25 |
| dpm | I think I might have done it too, but I can't quite remember, it's been a while since I did the initial setup | 08:25 |
| dpm | mzanetti, here are the messages I'm getting: http://pastebin.ubuntu.com/7403285/ | 08:25 |
| dpm | Images are loading fine, though | 08:26 |
| Aki-Thinkpad | Yep, that solved part of the problem. | 08:26 |
| mzanetti | Aki-Thinkpad: are all the warnings/messages gone after creating the dir? | 08:27 |
| Aki-Thinkpad | sec, uploading screenies | 08:27 |
| Aki-Thinkpad | some | 08:27 |
| mzanetti | you can also paste the text... should be easier/faster :) | 08:31 |
| DanChapman | Good Morning | 08:32 |
| Aki-Thinkpad | mzanetti, http://imgur.com/a/eSHJ9#0 | 08:33 |
| Aki-Thinkpad | 0, what I was getting, 1, creating the folder, 2, in the folder, 3, running the app, 4, new output, 5 file now being written to. | 08:34 |
| mzanetti | hmm... need to debug it... it shouldn't print that many warnings when everything works fine | 08:34 |
| Aki-Thinkpad | mzanetti, are you using qfile to create the directory, or cmake? | 08:36 |
| mzanetti | definitely not cmake | 08:37 |
| Aki-Thinkpad | Don't know much about cmake actually. | 08:37 |
| mzanetti | I think I don't create it at all... | 08:39 |
| mzanetti | strange | 08:39 |
| mzanetti | nope... images fail to load here if that directory doesn't exist | 08:40 |
| mzanetti | I wonder how they appear for you guys... it should clearly fail in that case | 08:41 |
| Aki-Thinkpad | mzanetti, could my debug environment be at fault here? http://i.imgur.com/Ycqvuf2.jpg | 08:42 |
| mzanetti | Aki-Thinkpad: no... your system is fine. its a bug in the reminders app | 08:42 |
| mzanetti | I just wonder where that path came from if the app doesn't create it | 08:42 |
| mzanetti | oh.. wait | 08:43 |
| Aki-Thinkpad | mzanetti, will you be patching, so it creates the directory in ~/.cache, or should I file a bug report? | 08:51 |
| mzanetti | Aki-Thinkpad: I'm on it | 08:51 |
| Aki-Thinkpad | k | 08:51 |
| mzanetti | narf... I hate that applicationName stuff | 08:52 |
| sergiusens | mzanetti: you should start a club :-) | 08:54 |
| * sergiusens would join | 08:54 | |
| mzanetti | :) | 08:54 |
| Aki-Thinkpad | dpm, mzanetti one thing I immediately notice in running the app, is lack of animations for fluidity. For example, when switching notes, it should do a fade, and should show the button being pressed. Are these things you will want implimented? | 08:55 |
| mzanetti | Aki-Thinkpad: yeah.. I guess we want to have that eventually | 08:58 |
| Aki-Thinkpad | ha okay maybe I'll try that as a first patch. | 08:58 |
| mzanetti | sergiusens: http://paste.ubuntu.com/7403432 :D | 09:00 |
| sergiusens | mzanetti: I had those all over when converting to click :-P | 09:01 |
| mzanetti | dpm: Aki-Thinkpad: https://code.launchpad.net/~mzanetti/reminders-app/fix-image-errors-and-warnings/+merge/218368 | 09:09 |
| mzanetti | thanks for reporting | 09:09 |
| Aki-Thinkpad | no probs. | 09:09 |
| dpm | Aki-Thinkpad, you might also want to look at the list of open bugs. That might give you a small task to get started, which might be easy than starting with a big feature (which could be the next contribution :) https://bugs.launchpad.net/reminders-app/ | 09:11 |
| dpm | Aki-Thinkpad, another way of easily getting started is with providing a review of the branch mzanetti just posted ^ | 09:12 |
| dpm | reviewing the work of other team members is also an important part of core apps development | 09:13 |
| dpm | reviewing implies looking at the code, testing that the branch actually works as intended and leaving a comment either pointing out what needs fixing or approving the change | 09:14 |
| dpm | you can also set the status of the comment to "Needs Fixing" or "Approve" as appropriate | 09:14 |
| Aki-Thinkpad | dpm, Thanks. I took a look at the bugs before; there are a few of the triaged bugs I am considering looking into | 09:16 |
| dpm | Aki-Thinkpad, awesome. Once you've found one you like, feel free to assign it to yourself, so that others know that someone else is working on it already. You can then set the status to "In Progress" once you actually start working on it | 09:18 |
| dpm | for anything else, you know where we are and who to ask :) | 09:18 |
| Aki-Thinkpad | cool beans | 09:18 |
| dpm | rock on | 09:22 |
| popey | dpm: seen this when opening qtcreator on a cmakelists file? paste.ubuntu.com/7403548/ | 09:43 |
| * popey updates packages | 09:44 | |
| dpm | popey, hm, no, I haven't. | 09:44 |
| dpm | mzanetti, on https://code.launchpad.net/~mzanetti/reminders-app/fix-image-errors-and-warnings/+merge/218368 - could you explain to me what " Don't scale images to 0,0 if sourceSize is not set." means? | 09:46 |
| dpm | That's the only part I cannot quite follow on the MP | 09:47 |
| popey | zbenjamin: paste.ubuntu.com/7403548/ I am getting that when I bzr branch lp:~dpm/ubuntu-terminal-app/merge-plugin, and then qtcreator the cmakelists file within... | 09:51 |
| zbenjamin | popey: wtf | 09:53 |
| zbenjamin | popey: that looks like the chroot is broken | 09:53 |
| zbenjamin | popey: can you build other projects? | 09:54 |
| popey | zbenjamin: i think i need to reset my qtcreator to some kind of base | 09:54 |
| popey | zbenjamin: clean start, spring clean, what should I rm to do that? | 09:54 |
| zbenjamin | popey: you can remove ~/.config/QtProject/qtcreator/ that should completely reset everything | 09:55 |
| popey | zbenjamin: including the chroots? | 09:56 |
| zbenjamin | popey: no the chroots you have to remove either from within QtC in the Ubuntu Options page, or manually from commandline | 09:56 |
| popey | zbenjamin: deleted that config dir, now just starting qtcreator with no project gives me the same error - paste.ubuntu.com/7403649/ | 09:59 |
| zbenjamin | did you also remove the chroots? | 09:59 |
| popey | no, exactly what should I remove? all of /var/lib/schroot? | 09:59 |
| zbenjamin | popey: click chroot -a armhf -f ubuntu-sdk-14.04 destroy | 10:00 |
| popey | thanks | 10:00 |
| popey | ok, now I get this /usr/share/qtcreator/ubuntu/scripts/qtc_chroot_cmake2: line 19: CLICK_SDK_ARCH: Need to set CLICK_SDK_ARCH non-empty | 10:01 |
| popey | (after deleting chroots and restarting qtc) | 10:01 |
| popey | zbenjamin: ^ | 10:06 |
| zbenjamin | popey: i think that can be ignored | 10:09 |
| zbenjamin | popey: just try if its working | 10:09 |
| mihir | popey: hi | 10:39 |
| popey | mihir: hji | 10:40 |
| popey | -j | 10:40 |
| popey | mihir: was just emailing you ☻ | 10:40 |
| mihir | popey: ohh got it. | 11:03 |
| mihir | popey: there are many bugs under needs-design | 11:03 |
| mihir | can we get some inputs on this ? | 11:03 |
| dpm | popey, the WIP branches: http://people.canonical.com/~dpm/core-apps-sponsoring/wip | 11:06 |
| dpm | I should probably put it all together in one page, but for now at least they won't get lost | 11:06 |
| popey | dpm: oof, that looks bad. | 11:12 |
| popey | mihir: see my mail ☻ | 11:12 |
| dpm | popey, it does look pretty red :) But let's focus on one thing at a time and concentrate on the "Needs review" page for now. I think the oldest WIP branches can in fact just be rejected, but let's use that page as a reminder only now, to which we can get to once we've gotten "Needs Review" under control | 11:15 |
| popey | indeed | 11:16 |
| popey | lool: i filed bug 1316552 - because I'm concerned that we're going to start blocking store updates soon on not having the framework. Wasn't sure you'd see it, hence pinging you with the bug number. | 11:24 |
| mihir | popey: got it :) thanks that would help a lot. | 11:50 |
| === _salem is now known as salem_ | ||
| mzanetti | dpm: for some reason I can't see the screenshot. but anyways... strange that it doesn't work for you | 12:08 |
| mzanetti | dpm: works for me: http://i.imgur.com/CaXcLFC.png | 12:08 |
| dpm | nice pic :) | 12:09 |
| mzanetti | lol | 12:10 |
| popey | haha | 12:10 |
| popey | that doesn't look comfy | 12:10 |
| mzanetti | this is how I look like when hacking on reminders at 2am | 12:10 |
| popey | heh | 12:10 |
| dpm | mzanetti, looking at your screen capture, it might be a locale-related thing? I use Catalan and perhaps that messes up the dates? http://i.imgur.com/NDDRjyv.png?1 | 12:10 |
| mzanetti | interesting | 12:11 |
| mzanetti | that might well be | 12:11 |
| mzanetti | dpm: actually no.. not really | 12:11 |
| mzanetti | I'm using QDateTime comparison... that should either always use catalan or never | 12:11 |
| dpm | ok | 12:11 |
| mzanetti | does that word start with double L? | 12:12 |
| dpm | just throwing a guess from the only difference I saw from our screenshots | 12:12 |
| dpm | which word? | 12:12 |
| mzanetti | Notebooks | 12:12 |
| dpm | yes, llibretes | 12:13 |
| mzanetti | dpm: debugging this it makes me really wonder how the heck it actually works here :D | 12:17 |
| dpm | :-) | 12:18 |
| dpm | I started debugging too, I just had to remind myself about -DCMAKE_BUILD_TYPE=debug | 12:18 |
| dpm | :) | 12:18 |
| mzanetti | dpm: please apply this patch and send another screenie: http://paste.ubuntu.com/7404242 | 12:19 |
| dpm | on it | 12:21 |
| renato | popey, I added some comments on the calendar MR | 12:25 |
| popey | thanks renato | 12:26 |
| rpadovani | dpm, mzanetti o/ I have a couple of hours for reminder :-) | 12:26 |
| mzanetti | rpadovani: yay | 12:26 |
| dpm | rpadovani, hi, awesome :) | 12:26 |
| mzanetti | rpadovani: I left some comments on your newDesign branch | 12:26 |
| dpm | mzanetti, I'm getting this when trying to get the app running on a device: | 12:27 |
| dpm | file:///home/phablet/dev_tmp/com.ubuntu.reminders/qml/ui/NotesPage.qml:20:1: module "QtQuick.Layouts" is not installed | 12:27 |
| dpm | import QtQuick.Layouts 1.0 | 12:27 |
| dpm | is QtQuick.Layouts not installed in the images? | 12:27 |
| mzanetti | dpm: apt-get install qtdeclarative5-qtquicklayouts-plugin | 12:27 |
| mzanetti | hmm... | 12:27 |
| rpadovani | mzanetti, I saw the email. There is a lot of works to do on my branch, so I'll restart from scratch after your branchs are landed | 12:27 |
| mzanetti | dpm: that's a bummer | 12:27 |
| dpm | mzanetti, right, but that means that we'll need to add it to the seeds before we ship the new design, yes | 12:28 |
| mzanetti | dpm: that, or do it still handcrafted | 12:28 |
| mzanetti | dpm: can you find out if its possible to include that in the image? | 12:28 |
| popey | Mirv: ^ | 12:29 |
| popey | Mirv: mzanetti asking if qtdeclarative5-qtquicklayouts-plugin can be added to the image? | 12:29 |
| dpm | mzanetti, my hunch is that it should be just possible to add it to the seeds, but we will need to justify why we need it too | 12:29 |
| mzanetti | dpm: justification is that they allow to layout items in qml with half of the code than without them | 12:30 |
| mzanetti | :) | 12:30 |
| mzanetti | finally no more typing "anchors" like crazy | 12:30 |
| rpadovani | seems cool | 12:31 |
| dpm | ok, let's hear what Timo has to say and then we can send a MP to update the seeds | 12:31 |
| mzanetti | awesome | 12:31 |
| mzanetti | dpm: back to the other branch for now. what does the note subtitle say after applying the above patch? | 12:32 |
| dpm | mzanetti, it's "Last week" all the way :( | 12:33 |
| mzanetti | really weird... | 12:33 |
| rpadovani | mzanetti, mhh, just tested again from scratch the notes-heading branch and I have nothing. Any idea? | 12:33 |
| rpadovani | I see dpm has problems too | 12:33 |
| Mirv | popey: no problem, although it was called "qtdeclarative5-quicklayouts-plugin" before and now that's transitional and it's qml-module-qtquick-layouts now (we should do the other renames in seed too) | 12:33 |
| mzanetti | rpadovani: but dpm sees the header just fine :D | 12:33 |
| mzanetti | rpadovani: note: its a section header, not a header for each note | 12:33 |
| rpadovani | mzanetti,yes yes, I saw your screen | 12:34 |
| Aki-Thinkpad | dpm, Curious, when clicking a delegate, is there a reason why its not exactly responsive? | 12:34 |
| mzanetti | rpadovani: so if you have all notes created at the same day, you would see only one | 12:34 |
| Aki-Thinkpad | mzanetti, | 12:34 |
| Aki-Thinkpad | ^ | 12:34 |
| Mirv | popey: it's not in seeds simply because Qt Quick Controls is new in 5.2 | 12:34 |
| popey | ah | 12:34 |
| === dholbach_ is now known as dholbach | ||
| dpm | Aki-Thinkpad, not sure what you mean exactly, could you provide more context? | 12:34 |
| Mirv | popey: well hmm, maybe let's bring bzoltan1 into discussion too, I fail to know how our "supported API" is exactly defined | 12:34 |
| mzanetti | Aki-Thinkpad: which delegates? | 12:35 |
| Aki-Thinkpad | dpm, sure; just take the default page, "Notes", and when you click on one... sometimes it does not switch to the note. | 12:35 |
| Aki-Thinkpad | sometimes you need to click it 3 or 4 times | 12:35 |
| mzanetti | Aki-Thinkpad: well, if the whole app just feels laggy and hangs all the time you're probably affected by the qt bug too | 12:35 |
| dpm | Mirv, but we are on 5.2 now, correct? | 12:35 |
| mzanetti | yes dpm | 12:35 |
| rpadovani | mzanetti, http://people.ubuntu.com/~rpadovani/touch/noteHeading.png | 12:36 |
| popey | dpm: yes, but it was new in upstream 5.2 | 12:36 |
| mzanetti | Aki-Thinkpad: try commenting out the two calls to "sort(0)" in notes.cpp | 12:36 |
| Aki-Thinkpad | mzanetti, hmmm; anything I can do about that? | 12:36 |
| popey | hence why we didnt seed it | 12:36 |
| Aki-Thinkpad | thanks | 12:36 |
| rpadovani | I have my phone setted on english US as regional format | 12:36 |
| rpadovani | s/phone/pc | 12:36 |
| Mirv | dpm: yes we are now. the seeds / supported API just are not controlled according to any formal process, I think. | 12:36 |
| Mirv | so when new things appear they don't automatically appear on images | 12:36 |
| mzanetti | rpadovani: the screenshot is a lie :D | 12:37 |
| mzanetti | rpadovani: nah, probabyl indeed the same issue dpm has | 12:37 |
| dpm | popey, Mirv, gotcha, so that explains why it's not there. And so theoretically, we could just add it | 12:37 |
| mzanetti | rpadovani: with some different outcome for the same root cause | 12:37 |
| popey | dpm: yeah, I'm creating a merge request now | 12:37 |
| rpadovani | mzanetti, it's a screenshot, not a cake :D | 12:37 |
| dpm | awesome popey | 12:37 |
| Mirv | popey is always awesome | 12:37 |
| dpm | \o/ | 12:37 |
| dpm | Aki-Thinkpad, this bug should be fixed soon on the desktop, we're in the process of SRU'ing it | 12:38 |
| dpm | Aki-Thinkpad, on the phone images it's already been fixed (for utopic) | 12:39 |
| bzoltan1 | Mirv: popey: who was the the brave to summon me? | 12:39 |
| Aki-Thinkpad | mzanetti, worked perfectly, and it looks like my animation works. Its just a very simple fade in and out animation. I made it a separate component, that is easily configurable. ought I try and merge? It is only a few lines of code honestly. | 12:39 |
| mzanetti | Aki-Thinkpad: create a merge proposal for it | 12:39 |
| Aki-Thinkpad | cool beans | 12:39 |
| popey | bzoltan1: not me! | 12:39 |
| dpm | everyone hides now | 12:40 |
| bzoltan1 | popey: ok.. one out :) | 12:40 |
| * popey puts on his level 10 invisibility cloak | 12:40 | |
| Mirv | bzoltan1: are you the Keeper of the API? | 12:41 |
| mzanetti | dpm: rpadovani: I think I found the issue. can you retry? I've pushed to the branch | 12:41 |
| Mirv | bzoltan1: you were summoned to ask whether qml-module-qtquick-layouts can be cast as part of the holy Ubuntu API | 12:41 |
| dpm | mzanetti, ok, pulling | 12:41 |
| rpadovani | mzanetti, commit message is interesting :D | 12:42 |
| popey | https://code.launchpad.net/~popey/ubuntu-seeds/add-quicklayouts/+merge/218405 | 12:42 |
| popey | hope thats right | 12:42 |
| mzanetti | :D | 12:42 |
| bzoltan1 | Mirv: Yes, my young fellow... I am | 12:42 |
| rpadovani | mzanetti, nope, no heading at all for me :/ | 12:43 |
| mzanetti | meh | 12:43 |
| bzoltan1 | Mirv: indeed it could be part of it... once it passes all the challenges | 12:43 |
| mzanetti | rpadovani: what's the debug output? | 12:43 |
| bzoltan1 | Mirv: where does it live? Who is its master? | 12:44 |
| mzanetti | lives upstream qt I think... | 12:44 |
| Mirv | bzoltan1: it lives in Qt Quick Controls, and I assume mzanetti is a willing master since he's the one wanting it! | 12:44 |
| mzanetti | :D | 12:44 |
| mzanetti | define "master" | 12:44 |
| dpm | define "willing" :D | 12:44 |
| bzoltan1 | define define | 12:45 |
| mzanetti | :D | 12:45 |
| dpm | does not compute | 12:45 |
| mzanetti | what are the duties | 12:45 |
| mzanetti | ? | 12:45 |
| bzoltan1 | mzanetti: buy me beer? | 12:45 |
| Mirv | Qt Quick Controls is at least part of official releases, so that makes it better than some of the other API:s we support | 12:45 |
| mzanetti | ok... I guess I can handle that | 12:45 |
| mzanetti | not in finland tho :P | 12:45 |
| rpadovani | mzanetti, http://paste.ubuntu.com/7404339/ | 12:45 |
| bzoltan1 | mzanetti: LOL :) I go with water in Finland | 12:45 |
| bzoltan1 | mzanetti: Mirv: I think it is fairly easy to include the Qt Quick Controls ... but I would be happier to consult with zsombi, as our layour strategy might be different from Qt's solution... and to be frank I do not want the default Qt Quick controlls sneak into our UI story | 12:47 |
| dpm | mzanetti, looks good with the new branch now, but I'd change the order to show the newest notes at the top of the list | 12:48 |
| zsombi | mzanetti: bzoltan1: actually our layouting was made to complement QtQuick Controls Layoutings, so those should be usable together without any probs | 12:48 |
| mzanetti | zsombi: nice one ^ | 12:49 |
| mzanetti | dpm: its the commented away sort(0) | 12:49 |
| mzanetti | rpadovani: I'm thinking you're not up to date with the code :/ | 12:49 |
| mzanetti | rpadovani: or with the build rather | 12:49 |
| zsombi | mzanetti: it was even mentioned in the tutorial if I'm not mistaken... if not, we have to update those, and even add few examples like how those work together | 12:49 |
| mzanetti | rpadovani: this message "NotesPage.qml:144:22: Unable to assign [undefined] to bool" is rather suspicious too | 12:50 |
| rpadovani | mzanetti, isn't the build 99 the last one? | 12:50 |
| dpm | mzanetti, ah, that was one of my questions on the MP, was there any reason to comment out the ordering? I guess to work around *the bug* temporarily on the desktop? :) | 12:50 |
| mzanetti | rpadovani: it is, but you need to call make in the top level builddir again. | 12:50 |
| mzanetti | rpadovani: could it be that you just typed make in the builddir/src/app subdit? | 12:50 |
| mzanetti | dpm: I replied to that comment on the MR | 12:51 |
| dpm | ah, ok, I'm not yet up to date, looking... | 12:51 |
| rpadovani | mzanetti, nope, I did it well | 12:51 |
| mzanetti | then I'm lost | 12:51 |
| mzanetti | rpadovani: I added some debug prints with the last commit too... I don't see them in your output | 12:51 |
| dpm | hola tsdgeos, I thought the "de novembre" vs. "Novembre" bug had been fixed in Qt 5.2? I'm still seeing in a current branch from the Reminders app -> http://i.imgur.com/4e6slM1.png | 12:52 |
| rpadovani | mzanetti, isn't this the right procedure? Maybe I understand wrong: http://paste.ubuntu.com/7404358/ | 12:52 |
| mzanetti | rpadovani: looks good | 12:53 |
| mzanetti | rpadovani: aaaah! I know what it is | 12:53 |
| mzanetti | rpadovani: you have account-plugin-evernote installed in your system. its using that one instead of the one from the builddir | 12:53 |
| rpadovani | mzanetti, ops :D | 12:53 |
| mzanetti | which is btw the reason I was opposed to install the plugin into the main Qt plugin dir with the account-plugin | 12:53 |
| dpm | mzanetti, ah, actually, that's something I wanted to mention: | 12:54 |
| dpm | QStringList importPathList = view.engine()->importPathList(); | 12:54 |
| dpm | importPathList.append(QDir::currentPath() + "/../plugin/"); | 12:54 |
| dpm | that does not work | 12:54 |
| dpm | it would need a prepend | 12:54 |
| dpm | to override the installed plugin | 12:54 |
| dpm | and IIRC QDir:currentPath() did not work either | 12:55 |
| mzanetti | somehow I had in mind it would wak them backwards, but seems I was wrong | 12:55 |
| dpm | I had to change this on filemanager to work | 12:55 |
| mzanetti | dpm: QDir::currentPath() wors, but you need to cd into src/app/ | 12:55 |
| dpm | let me send a quick MP for this | 12:55 |
| rpadovani | mzanetti, https://code.launchpad.net/~mzanetti/reminders-app/fix-image-errors-and-warnings/+merge/218368 works well for me, could I topapprove it? | 12:56 |
| mzanetti | fine with me, yes | 12:57 |
| rpadovani | mzanetti, I removed account-plugin-evernote, how can I add my account? | 13:00 |
| mzanetti | rpadovani: did you remove the account too? | 13:00 |
| mzanetti | rpadovani: the account should still be there and working | 13:00 |
| rpadovani | mzanetti, no, I ... wait... I did purge and not remove :/ | 13:01 |
| mzanetti | :D | 13:01 |
| dpm | mzanetti, rpadovani, here's a quick one for you: https://code.launchpad.net/~dpm/reminders-app/override-installed-plugin/+merge/218411 | 13:02 |
| tsdgeos | dpm: hmmmm, tbh i don't remember what was the outcome of the discusion | 13:02 |
| tsdgeos | dpm: i think i said it was a bug in the app | 13:02 |
| tsdgeos | but may be wrong | 13:02 |
| dpm | tsdgeos, I think you're thinking of another conversation we had. That was about the DatePicker. This one now is about a bug you fixed upstream a while ago, and I would have thought it'd land in 5.2 | 13:03 |
| tsdgeos | dpm: isn't that like ages ago? | 13:04 |
| dpm | yep | 13:04 |
| * tsdgeos tries to find the thing in his brain | 13:05 | |
| * dpm tries to dig out the upstream bug | 13:05 | |
| Aki-Thinkpad | dpm, hey I have never proposed a merge. Is what I am doing here, pushing to lp:~akiva/reminders-app/name-of-my-proposal , and then ??? | 13:09 |
| rpadovani | mzanetti, ok, now there are headers but in a strange order: http://people.ubuntu.com/~rpadovani/touch/strangeOrder.png | 13:09 |
| dpm | Aki-Thinkpad, then you go to LP, click on the branch that you've pushed, and you'll find a link that says "Propose for merging" | 13:10 |
| mzanetti | rpadovani: yeah... I commented out the sorting to work around the qt listview bug | 13:10 |
| Aki-Thinkpad | dpm, okay so the first step is correct then? | 13:10 |
| mzanetti | will keep that disabled for the new-design branch until we merge it to master... | 13:10 |
| rpadovani | mzanetti, ah, ok | 13:10 |
| rpadovani | which are next steps? | 13:11 |
| tsdgeos | dpm: i think i'm remember something | 13:11 |
| dpm | Aki-Thinkpad, correct, and this should answer some of your questions: https://wiki.ubuntu.com/Touch/CoreApps/DevelopmentGuide#Using_Launchpad | 13:11 |
| tsdgeos | dpm: https://codereview.qt-project.org/#change,54214 | 13:11 |
| mzanetti | rpadovani: I guess I'll make the new reminders delegate design | 13:11 |
| Aki-Thinkpad | dpm, thanks | 13:11 |
| Aki-Thinkpad | !cookie | 13:11 |
| mzanetti | rpadovani: while waiting for you to change the app background color and the notesview | 13:11 |
| dpm | tsdgeos, that was it! | 13:11 |
| mzanetti | rpadovani: can you create 2 branches, a quick one that just changes the main app color (so I can see how my stuff finally looks) | 13:12 |
| rpadovani | mzanetti, sure, going | 13:12 |
| mzanetti | rpadovani: and then the other, bigger one, for the notes delegate | 13:12 |
| rpadovani | mzanetti, I also tested https://code.launchpad.net/~dpm/reminders-app/override-installed-plugin/+merge/218411 and works, could I approve it? I see you approve it | 13:13 |
| tsdgeos | dpm: let me make sure the code is still there | 13:13 |
| mzanetti | awesome, thanks rpadovani. I top approved | 13:13 |
| dpm | tsdgeos, cool, thanks. If it helps, here's the code where that date string on my screenshot is generated from: http://pastebin.ubuntu.com/7404464/ | 13:14 |
| dpm | mzanetti, I added a new comment to https://code.launchpad.net/~mzanetti/reminders-app/notes-headers/+merge/218328 - let me know what you think | 13:17 |
| mzanetti | dpm: sure, can do... | 13:18 |
| dpm | awesome, thanks. I think it will be a really nice visual improvement to have already | 13:18 |
| rpadovani | mzanetti, what's wrong with bzr? (besides the fact is not git) | 13:19 |
| rpadovani | mzanetti, https://code.launchpad.net/~rpadovani/reminders-app/newBackground/+merge/218419 | 13:19 |
| rpadovani | I took the newDesign branch, why the diff is so big? | 13:19 |
| rpadovani | I mean, it's the same branch! | 13:20 |
| rpadovani | a no, its my error | 13:20 |
| rpadovani | sorry :/ | 13:20 |
| rpadovani | mzanetti, new background -> https://code.launchpad.net/~rpadovani/reminders-app/newBackground/+merge/218420 | 13:21 |
| mzanetti | nw | 13:21 |
| dpm | Aki-Thinkpad, how are you getting on with proposing the merge? Can I help with anything else? | 13:21 |
| Aki-Thinkpad | dpm, In my commits, I have always had a format of "Changelog: 1.... 2.... 3.... ; Todo: a.... b.... c...." Obviously employing newlines. Is this an acceptable format? | 13:23 |
| tsdgeos | dpm: you have to do the formatting yourself, MMMM will always give you the "non standalone" month name | 13:23 |
| Aki-Thinkpad | dpm, http://i.imgur.com/GajnYkK.jpg | 13:24 |
| tsdgeos | dpm: i.e. QLocale::standaloneMonthName + qdate::month | 13:25 |
| dpm | Aki-Thinkpad, that should be fine, yes | 13:26 |
| dpm | tsdgeos, ok, thanks, will try that | 13:27 |
| tsdgeos | dpm: i think what i fixed was standaloneMonthName not actually giving you the standaloneMonthName | 13:29 |
| === oSoMoN_ is now known as oSoMoN | ||
| dpm | tsdgeos, so to be sure, on the original code, how should the value on L18 be actually returned to get "Novembre 2014"? -> http://pastebin.ubuntu.com/7404464/ | 13:35 |
| tsdgeos | dpm: something like this http://paste.ubuntu.com/7404600/ | 13:39 |
| tsdgeos | though since it's now a standalonemonthname | 13:39 |
| tsdgeos | it's not capitalized | 13:39 |
| tsdgeos | so you may want to capilatize it | 13:39 |
| tsdgeos | or not | 13:39 |
| Aki-Thinkpad | dpm, last question; "Review Type"? | 13:40 |
| dpm | tsdgeos, ok, trying that now on the app | 13:40 |
| dpm | Aki-Thinkpad, feel free to leave that blank, we don't tend to use it. Just one detail to remember -> you'll need to set the commit message in the MP. It's a bit hidden in the form, you'll need to expand the options at the bottom | 13:41 |
| Aki-Thinkpad | yah done. | 13:41 |
| Aki-Thinkpad | thanks | 13:41 |
| Aki-Thinkpad | okay proposed. I set you as the reviewer | 13:41 |
| dpm | Aki-Thinkpad, awesome, thanks! No need to set anyone as the reviewer (but nothing wrong with setting it), as all team members get an e-mail notification when a new MP is submitted | 13:45 |
| Aki-Thinkpad | heh | 13:45 |
| Aki-Thinkpad | Bzr really is an amazing piece of technology. | 13:46 |
| dpm | tsdgeos, so how do I actually capitalize the month name? I can't find a way of doing it via http://qt-project.org/doc/qt-5/qlocale.html#standaloneMonthName ? | 13:49 |
| tsdgeos | dpm: you'll have to play magic with qstring/qchar and ::toUpper | 13:50 |
| tsdgeos | but now that i see http://i.imgur.com/4e6slM1.png it wasn't localized either | 13:51 |
| tsdgeos | err localized -> uppsercase | 13:51 |
| tsdgeos | do you really need it in uppercase? | 13:51 |
| dpm | if it's the start of a sentence, as in the header, yes | 13:51 |
| dpm | tsdgeos, so what's the point in using standaloneMonthName & co. if I have to present a translatable string to translators "%1 %2" in case they need to rearrange it and manually set the month name to uppercase? I would have expected that just presenting translators with a date string "MMMM YYYY" should have just done the trick? | 13:53 |
| tsdgeos | dpm: http://paste.ubuntu.com/7404666/ | 13:54 |
| tsdgeos | dpm: well, using standaloneMonthNAme gives you the month name | 13:54 |
| tsdgeos | how do you get the month name otehrwise? | 13:54 |
| dpm | tsdgeos, yes, but should not "MMMM" just give me the right month name already? It seems like a bug to me, unless I'm using the format string incorrectly (which I would not discard :) | 13:55 |
| tsdgeos | dpm: as i told you MMMM gives you the month name with "of" | 13:55 |
| tsdgeos | so you can properly say | 13:56 |
| tsdgeos | dd MMMM yyyy | 13:56 |
| tsdgeos | what you want is a sMMMM | 13:56 |
| popey | dpm: mzanetti is this expected when there's no network? https://imgur.com/V9717wT | 13:56 |
| tsdgeos | that gives you the standalone version | 13:56 |
| tsdgeos | but that doesn't exist | 13:56 |
| dpm | ok, so I'm just using the wrong one | 13:56 |
| tsdgeos | you're using the only one that is there, it just doesn't do what you want | 13:56 |
| tsdgeos | i just invented sMMMM myself | 13:56 |
| dpm | ha | 13:56 |
| dpm | ok | 13:56 |
| mzanetti | popey: yeah... it sort of is :) | 13:57 |
| mzanetti | popey: don't like the message? | 13:57 |
| popey | i dont like any error messages ☻ | 13:57 |
| popey | I like success messages! | 13:57 |
| Aki-Thinkpad | Ah rubbish I just noticed I replaced some of your spaced tabs, with tabs >:/ | 13:57 |
| mzanetti | popey: well... kinda hard in that case :D | 13:57 |
| mzanetti | popey: I added the "Error refreshing notes:" the rest comes from the evernote sdk | 13:58 |
| popey | mzanetti: search button works ever when no networi, but add note doesn't | 13:58 |
| dpm | tsdgeos, where are these format strings defined in Qt? I don't remember ever having had this issue with GTK apps, and I would have thought they both use the same underlying date formatting lib? | 13:58 |
| popey | guessing it shouldn't? | 13:58 |
| mzanetti | popey: hmm... maybe | 13:59 |
| tsdgeos | dpm: "I would have thought they both use the same underlying date formatting lib"? | 13:59 |
| tsdgeos | lol no way | 13:59 |
| popey | mzanetti: ok, also, what happens when the network comes back? | 13:59 |
| tsdgeos | why would someone share code? | 13:59 |
| tsdgeos | remember it's written in C++!!!!!1111 | 13:59 |
| popey | there's no [Retry] | 13:59 |
| mzanetti | popey: no... but every interaction you make tries again | 14:00 |
| popey | ah | 14:00 |
| popey | yup, that worked | 14:00 |
| tsdgeos | dpm: they are in the QDate documentation | 14:00 |
| popey | oof | 14:00 |
| popey | maybe not | 14:00 |
| mzanetti | popey: I lack two things from design: A place where to show that adding a note failed | 14:00 |
| dpm | mzanetti, are the Evernote SDK error messages also available as error codes we could intercept to show nicer error messages to the user? | 14:00 |
| popey | https://imgur.com/MhF3DDr mzanetti | 14:00 |
| mzanetti | meh... still that one | 14:01 |
| dpm | ok, thanks tsdgeos! | 14:02 |
| mzanetti | popey: dpm: so yes... we can intercept those messages | 14:02 |
| mzanetti | popey: dpm: I still need to know what to do if an actions fails (e.g. tapping on add note fails to connect to the server) | 14:03 |
| tsdgeos | dpm: sorry can't help you more, but yes i agree it'd be cool to be able to use toString with a format that gave you the standalone month name, or even if it was smart enough to use monthname vs standalone month name depending if the dd is before it or not, but it's not there | 14:03 |
| mzanetti | popey, dpm: and then I'm open to suggestions on how to do a "retry" button of some sort | 14:03 |
| tsdgeos | it's the problem of people thinking in enlgish while doing the coding | 14:04 |
| Aki-Thinkpad | enlgish? | 14:04 |
| mzanetti | popey: that bug with messagelength is happening sometimes here too. I suspect an issue in the evernote sdk when the connection is bad. will try to find a workaround | 14:04 |
| dpm | tsdgeos, no worries, thanks for the help | 14:11 |
| dpm | Aki-Thinkpad, thanks for your first contribution! I left some comments about a couple of small things that need fixing. If you could address them, that'd be great -> https://code.launchpad.net/~akiva/reminders-app/fadeinout-animation/+merge/218429 | 14:11 |
| Aki-Thinkpad | well do | 14:12 |
| dpm | awesome | 14:13 |
| Aki-Thinkpad | ah yes, I didnt notice the license :P | 14:13 |
| Aki-Thinkpad | and yah, I have signed the contributor agreement | 14:13 |
| dpm | no worries, have a look at the other headers in the code, you can just copy them, and add yourself as the author | 14:13 |
| dpm | cool | 14:14 |
| popey | dpm: have you tried running the autopilot tests on reminders at all? | 14:14 |
| popey | it barfs when setting up, trying to branch lp:reminders (when it's reminders-app) | 14:15 |
| dpm | argh! | 14:15 |
| popey | is this the x-test setting in the manifest.json being wrong? | 14:15 |
| popey | it's "autopilot": "reminders" | 14:15 |
| balloons | it's supposed to be reminders | 14:15 |
| popey | ok, so how do i fix this then? | 14:16 |
| dpm | popey, I had tested them on the desktop, though, IIRC. Is this failing on the device or both on device and desktop? | 14:16 |
| popey | paste.ubuntu.com/7404771/ | 14:16 |
| popey | good morning balloons btw | 14:16 |
| popey | device | 14:16 |
| dpm | and when I say them, I mean "it" :) | 14:16 |
| balloons | morning :-) | 14:16 |
| popey | I only run ap tests on device | 14:16 |
| dpm | I think we only had one test at the time :) | 14:16 |
| popey | thats 100% more tests than we had | 14:16 |
| popey | ignore my bad maths | 14:17 |
| popey | how do I tell phablet-click-test-setup to get the right thing balloons ? | 14:17 |
| balloons | ahh popey, so phablet-click-test-setup is whining, not the tests | 14:17 |
| popey | correct | 14:17 |
| balloons | sadly phablet-test-setup is kind of borked anyway | 14:18 |
| balloons | I was just looking at it, giving it some love in an mp.. the --click does nothing :-) | 14:18 |
| popey | ☹ | 14:19 |
| popey | but this works for other packages, what's broken with reminders (or p-t-s) that means I can't test reminders but can test other apps? | 14:19 |
| balloons | well the point is you don't need to run it | 14:20 |
| popey | oh? so how should I run the tests today? ☻ | 14:20 |
| balloons | and yes I believe you are correct the manifest is wrong | 14:20 |
| balloons | popey, I say you don't need to run it because it's not actually grabbing and installing the dependencies anyway | 14:21 |
| popey | so just run phablet-test-run -v reminders ? | 14:21 |
| balloons | you can do phablet-click-test-setup --only-base if you want to setup base, but it's only needed once | 14:22 |
| balloons | and yes, just phablet-test-run | 14:22 |
| popey | it doesn't find any tests | 14:22 |
| popey | paste.ubuntu.com/7404844/ | 14:23 |
| Aki-Thinkpad | grrrr... qt creator... why are you autoreplacing my spaces with tabs >:/ | 14:23 |
| * Aki-Thinkpad checks settings again | 14:24 | |
| balloons | if it complains about missing something, you'll have to push it manually | 14:24 |
| balloons | popey, you installed the click only then? | 14:25 |
| balloons | so that's the trouble.. you need it to find and push the tests | 14:25 |
| popey | balloons: which is exactly what I have been using phablet-test-setup to do... | 14:28 |
| balloons | :-) I get it | 14:28 |
| popey | glad you do! :D | 14:28 |
| popey | I am just a frustrated user of the tool | 14:29 |
| balloons | need to see if Sergio will land my fixes | 14:31 |
| popey | where does phablet-click-test-setup get the "x-source": { | 14:32 |
| popey | "vcs-bzr": "lp:reminders", | 14:32 |
| popey | oops | 14:32 |
| popey | well, thats the thing thats wrong | 14:32 |
| dpm | Aki-Thinkpad, I think by default it should not replace spaces. Is there anything you've changed in the config? | 14:32 |
| balloons | "vcs-bzr": "lp:reminders", | 14:32 |
| popey | yes | 14:32 |
| * popey fixes | 14:32 | |
| balloons | I just looked in manifest .json :-) | 14:33 |
| popey | ditto | 14:33 |
| Aki-Thinkpad | dpm, yah I had qml set to my custom settings. Fixed it. | 14:33 |
| popey | i thought it used the x-test thing | 14:33 |
| dpm | ok, cool | 14:33 |
| popey | but it's x-source | 14:33 |
| Aki-Thinkpad | (why can't you all be sane and use 8 spaced tabs, and seperate lines for every curly bracket? | 14:33 |
| Aki-Thinkpad | ) | 14:33 |
| Aki-Thinkpad | :P | 14:33 |
| balloons | x-test is for the module name for the tests | 14:33 |
| popey | which should be reminders or reminders_app? | 14:34 |
| popey | i should leave that be i think | 14:34 |
| balloons | lp:reminders-app for source | 14:34 |
| balloons | reminders for test name | 14:34 |
| popey | ta | 14:34 |
| balloons | sorry I was more focused on my annoyances with the tool | 14:35 |
| popey | heh | 14:36 |
| dpm | Aki-Thinkpad, also, another couple of caveats: please don't be discouraged by the "Needs fixing" comments, they're there to ensure quality and consistency in the code. Also, the reminders devs are working on new visual designs as we speak, so if your branch lands as it is, it might need rework when the visual designs land. Finally, other than my initial review, I'll ask one of the devs to look at it too | 14:36 |
| Aki-Thinkpad | But dpm, MY FEELINGS!!!!11!!1one. | 14:37 |
| dpm | :-) | 14:38 |
| Aki-Thinkpad | Also I expect the animations to be altered. This is a prototype more than anything. The component can easily be changed; that was my goal. | 14:38 |
| dpm | ok | 14:39 |
| Aki-Thinkpad | okay, white space inconsistencies are corrected | 14:40 |
| Aki-Thinkpad | ah shucks | 14:41 |
| Aki-Thinkpad | nvm, missing one space in front of one bracket >:/ | 14:42 |
| * popey tickles balloons with https://code.launchpad.net/~popey/reminders-app/fix-vcs-manifest/+merge/218444 | 14:42 | |
| dpm | mzanetti, when you've got a minute, do you think you could look at https://bugs.launchpad.net/reminders-app/+bug/1316172 and if it's possible, tell me if it's something that can be trivially fixed or if it's a bigger task? The reason I'm asking is because if it's an easy fix, it'd be nice to get it in for the Evernote folks to review | 14:42 |
| mzanetti | dpm: ack.. will have a look | 14:43 |
| dpm | awesome, thanks | 14:43 |
| Aki-Thinkpad | dpm, okay think its okay now | 14:45 |
| dpm | Aki-Thinkpad, a recommendation: as every commit is different, the commit message should be different too. No need to change it now, but something to bear in mind for the future | 14:46 |
| Aki-Thinkpad | ha ha ha, yah was wondering about that. | 14:46 |
| Aki-Thinkpad | ~:| | 14:47 |
| dpm | also the "how to test" info should rather be in the merge proposal's description | 14:47 |
| Aki-Thinkpad | sure | 14:47 |
| Aki-Thinkpad | can do | 14:47 |
| dpm | there's nothing wrong with long commit messages, but in general I'd recommend to provide one line or two of context, summarizing the changes | 14:48 |
| balloons | dpm have some free time this evening to chat about a few merges? | 14:48 |
| popey | thanks balloons | 14:48 |
| balloons | sorry you had to suffer and figure out the bug the hard way popey | 14:49 |
| dpm | balloons, I've got no other meetings today, so if you want we can chat now | 14:49 |
| popey | hah | 14:49 |
| popey | can't tell if being sarcastic or... | 14:49 |
| dpm | haha | 14:49 |
| dpm | you need to suffer and endure, popey! | 14:49 |
| popey | clearly | 14:49 |
| balloons | lol :-) | 14:51 |
| balloons | dpm, ok let's start simple. https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 | 14:51 |
| dpm | clearly you're being sarcastic now :) | 14:51 |
| popey | I was literally just about to post that one! | 14:52 |
| dpm | I can fix the issues in the 2 comments now | 14:52 |
| popey | thanks | 14:52 |
| davmor2 | balloons: I think you have a cheek dpm offers to help you and then you call him simple harsh dude harsh | 14:52 |
| dpm | hahaha | 14:53 |
| popey | balloons: one for you https://code.launchpad.net/~dpm/ubuntu-filemanager-app/run-ap-from-out-of-source-build/+merge/217510 ? | 14:53 |
| balloons | davmor2, haha | 14:53 |
| balloons | popey, yep that's also part of this review with dpm :-) | 14:54 |
| popey | kk | 14:54 |
| balloons | hence my simple statement.. things only get worse from here! | 14:54 |
| dpm | balloons, oh, wait, re-reading it does this mean we need the python3-lxml package installed on the device? | 14:55 |
| balloons | so dpm from my comments and memory I think that merge is good from my perspective with those tweaks | 14:55 |
| dpm | that's not a dependency I'd like to add | 14:55 |
| balloons | dpm, it needs the module.. it's an AP test dependency | 14:56 |
| balloons | I didn't install it on the device, I pushed the armhf version to the device | 14:56 |
| dpm | balloons, but on the device, it will not require it at runtime, correct? I can do a conditional import | 14:56 |
| balloons | dpm, lxml is basically something phablet-click-test-setup should do | 14:57 |
| balloons | but doesn't atm, till I bug sergiusens to review and help me land my mp ;-) | 14:57 |
| dpm | balloons, right, but that means that p-c-t would need to set the image in RW mode, which is not something I was intending to do with this MP | 14:57 |
| balloons | dpm, no it does not | 14:57 |
| balloons | dpm, modules are "installed" / copied to /home/phablet/autopilot | 14:58 |
| dpm | aha | 14:58 |
| balloons | so tests and needed dependencies (like the sdk helper) are all installed there and sought after there | 14:58 |
| sergiusens | dpm: nah, I made the entire thing not need to go into r/w | 14:59 |
| balloons | I was mentioning it because atm if popey for instance tried to run it, it would fail to run the tests looking for the module.. and it currently requires manual setup to get to run | 14:59 |
| balloons | the change to python3-lxml is there because it's py3 now, and we should depend on py3 packages | 15:00 |
| balloons | this also ensures jenkins will run ap as py3 | 15:00 |
| dpm | balloons, ok, gotcha. So your recommendation would still be what you're mentioning in the MP: 1) add a note to the README file and 2) Fix the package name in debian/control, correct? | 15:01 |
| balloons | yep.. Add a note you need to manually push the module to the device to run (and that it requires the armhf version as it's a compiled module) | 15:01 |
| balloons | and the dependency change.. so this one should be simple | 15:01 |
| balloons | sergiusens, what are your thoughts about dealing with compiled modules btw? We should go after the armhf versions of these things | 15:03 |
| sergiusens | balloons: I don't follow | 15:04 |
| sergiusens | balloons: oh, python modules with native code? | 15:05 |
| balloons | sergiusens, sorry. So specifically for this app, terminal, it has a dependency on python3-lxml. Now, atm, we're simply grabbing source and pushing it. Right, the module has native code. There's a .so file in there :-) | 15:05 |
| popey | dpm: if you're okay with us flipping to trusty on the next rev, can you please ส็็༼ ຈلຈ༽ส็็ https://code.launchpad.net/~popey/ubuntu-clock-app/fix-1315318/+merge/218067 | 15:05 |
| sergiusens | balloons: LD_LIBRARY_PATH and hope for no hardcodings? I'm really not sure; I was waiting on input from QA for what to do | 15:06 |
| popey | er, that should say a pprove | 15:06 |
| popey | stupid irc macro | 15:06 |
| sergiusens | popey: don't use macros :) | 15:06 |
| popey | yeah, I'll remove it | 15:06 |
| sergiusens | popey: automation will eventually get in your way :-P | 15:06 |
| popey | Then I'll be like (╯°□°)╯︵ ┻━┻ | 15:07 |
| balloons | sergiusens, it's kind of a new wrinkle, but terminal is the first app to hit it. I'd keep us focused on fixing it for the 99% | 15:07 |
| dpm | balloons, done. Please have a look at https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 to see if it looks ok to you now. | 15:08 |
| sergiusens | balloons: yeah, my proposal was to not use such modules as they aren't part of our 'base' | 15:08 |
| sergiusens | balloons: we can only do this as we are the upstream of most things, but image a random app developer wanting to run tests | 15:09 |
| sergiusens | balloons: I mean, create tests | 15:09 |
| dpm | popey, approved, but I didn't top-approve as I'm not sure what's going on with Jenkins on that MP and I didn't want to override it. Or should I? | 15:10 |
| popey | jenkins seems to be having a bad day | 15:10 |
| balloons | sergiusens, I do imagine them, heh. It's one of the biggest pushes for having this work.. I realize it's sort of a hack to start with | 15:10 |
| popey | one of my other merges hasn't merged | 15:10 |
| balloons | sergiusens, what do you think of me suggesting we put AP depends in the manifest? | 15:11 |
| balloons | yea, I noticed I've had top-approves sitting since last night | 15:11 |
| sergiusens | balloons: this is where python becomes a pain :-) if you do that deps in the click manifest; you end up needing to take care of the full dependency tree or create custom chroots per test or something | 15:12 |
| dpm | balloons, quick question: so if the python3-lxml module needs to be manually copied for the tests to run on the device, what will happen with the QA dashboard? If we don't have a human there to do this manual copying, would the tests not just fail? | 15:12 |
| balloons | dpm, :-) | 15:12 |
| balloons | sergiusens, yea, we would not do dependency resolution, we would assume all listed depends are apt package names, and given this new wrinkle of modules with native code, well :-) | 15:13 |
| balloons | it sounds worse than it would be though I think. We could support everything now with a handful of modules | 15:14 |
| balloons | longer term, we need a better solution, but I feel like this could help in the interim.. maybe it would make the hack too permanent | 15:14 |
| balloons | dpm, I guess we really need a solution in phablet-test-click-setup which is run as part of the setup process | 15:15 |
| balloons | otherwise, yes, it will blow up and fail to run | 15:15 |
| dpm | balloons, so in that case, I think the only option right now to get this approved is to drop python-lxml | 15:16 |
| balloons | err.. well, I'm slightly confused now because other apps have depends that fall outside of the normal modules | 15:16 |
| balloons | dpm, if you could drop the need for python-lxml it would save headache certainly | 15:16 |
| balloons | dpm, however the problem is still one we need to solve, so I'm glad to have seen it | 15:17 |
| dpm | balloons, ok, will do that this evening. I think I'll have to do the same split I did for filemanager | 15:17 |
| balloons | dpm, what's lxml used for now? | 15:17 |
| dpm | balloons, to parse the xml in CMakeLists.txt.user. I can probably use the standard python lib, but -lxml made it much easier to use xpath to parse the xml in there | 15:18 |
| balloons | dpm, sergiusens thinking aloud, if say the needed module was built into the click via cmake, what do you think of that? We could potentially end up with copies of python-lxml in multiple clicks, but | 15:23 |
| dpm | balloons, I don't think it's worth the effort. I think I'd rather rewrite the Python code to use only standard modules than adding cmake rules and dependencies to build external modules | 15:25 |
| dpm | so in any case, the first step will be to split the MP | 15:25 |
| dpm | so that -lxml code stays out of the way | 15:25 |
| balloons | dpm, it's not just for this and the lxml dependency. Other tests have the same needs | 15:26 |
| balloons | the issue with my proposal is AP tests are not part of clicks and in theory have no place | 15:27 |
| balloons | so, just like debian packages, perhaps we need a second click? The point is, I wondering if click doesn't already provide what we are looking for | 15:28 |
| === gatox is now known as gatox_lunch | ||
| mihir | renato: ping ! | 15:45 |
| === marcoceppi_ is now known as marcoceppi | ||
| balloons | dpm, ohh we also were supposed to chat about file manager and https://code.launchpad.net/~elopio/ubuntu-filemanager-app/cmake_autopilot_task/+merge/217791 and https://code.launchpad.net/~dpm/ubuntu-filemanager-app/run-ap-from-out-of-source-build/+merge/217510 | 15:51 |
| dpm | yep :) | 15:51 |
| === chihchun is now known as chihchun_afk | ||
| balloons | ping nik90 | 16:08 |
| mzanetti | dpm: https://code.launchpad.net/~mzanetti/reminders-app/notes-headers-to-trunk/+merge/218462 | 16:23 |
| dpm | oh cool, testing it | 16:24 |
| mzanetti | dpm: seems jenkins is lazy today | 16:25 |
| === chihchun_afk is now known as chihchun | ||
| mzanetti | dpm: crap... I just saw I'm using the Layouts already | 16:30 |
| dpm | mzanetti, yeah, that was the first thing I saw. If it's going to be a pain or unnecessary work to drop the dependency on Layouts until it's been added to the seeds, I'd say we leave it as it is | 16:32 |
| dpm | so in the end we might need to wait for this to land | 16:33 |
| mzanetti | dpm: well, its not really a lot... but yeah. would make me redo the other branches too as they depend on this stuff | 16:33 |
| === gatox_lunch is now known as gatox | ||
| mzanetti | dpm: do you think the plugin makes it into an image quick enough? | 16:33 |
| dpm | I'm not sure, perhaps into a proposed image, but it might take a while until it gets to a promoted one. popey, have you sent that MP or talked to someone already to add qtdeclarative5-quicklayouts-plugin to the seeds for Reminders? | 16:35 |
| mzanetti | ah I see | 16:35 |
| popey | dpm: yes, i proposed the merge | 16:41 |
| dpm | ah, cool, thanks | 16:41 |
| popey | dpm: https://code.launchpad.net/~popey/ubuntu-seeds/add-quicklayouts/+merge/218405 | 16:42 |
| dpm | mzanetti, ^ | 16:42 |
| popey | dpm: i set bzoltan as a reviewer on it, as Mirv said he is the king of sdk | 16:42 |
| popey | balloons / dpm I added a column to track the number of days since last upload to the store for each app - should make it easier for us to choose which app to focus on - as well as the column showing how many revs in trunk | 16:45 |
| dpm | popey, sounds good, but a column where? | 16:45 |
| balloons | popey, ohh I see | 16:46 |
| popey | dpm: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AnZdnhOl8MU5dDJseW1vT1N5RkJvLUJHZTdhalRVd1E&usp=drive_web#gid=1 3rd sheet | 16:46 |
| bzoltan | popey: emperor my friend, emperor ... and we have approved your mighty MR | 16:47 |
| popey | this wont be needed once fginther automates us out of a job | 16:47 |
| popey | bzoltan: I am not worthy | 16:47 |
| popey | thanks also | 16:47 |
| bzoltan | popey: nobody is :) not even me | 16:47 |
| popey | there you go dpm, should be in an image real soon now, right ogra_ ? | 16:48 |
| bzoltan | popey: it would be cool if the click chroots would have exactly the same packages as the skd seed | 16:48 |
| dpm | \o/ | 16:48 |
| fginther | popey, sadly ol' chap, I can't render you obsolete just yet | 16:48 |
| popey | keep trying! | 16:48 |
| ogra_ | popey, what is that ? | 16:49 |
| popey | ogra_: https://code.launchpad.net/~popey/ubuntu-seeds/add-quicklayouts/+merge/218405 that | 16:53 |
| ogra_ | oh, right | 16:54 |
| ogra_ | should show up in an image tomorrow ... | 16:54 |
| renato | mihir, pong | 16:56 |
| mihir | renato: all day events are appearing day before of actual scheduled date. | 16:57 |
| mihir | https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1314249 | 16:57 |
| mihir | i have debugged till the event get saved, it takes the correct date, but after it starts it takes previous day. | 16:57 |
| renato | mihir, ok I will put this on my list | 16:58 |
| mihir | renato: thanks :) | 16:58 |
| mihir | renato: just left comment on bug if i am not available. | 16:58 |
| mihir | leave* | 16:59 |
| popey | fginther: sudoku-app seems to be failing to build in jenkins.. ☹ | 16:59 |
| fginther | popey, looking | 17:00 |
| mzanetti | dpm: lol :) I wouldn't fix that :D | 17:00 |
| fginther | popey, this one ? http://91.189.93.70:8080/job/sudoku-app-autolanding/ | 17:01 |
| mzanetti | dpm: but thanks for the info. didn't know how to do that in c | 17:01 |
| popey | fginther: i was looking s-jenkins:8080/job/sudoku-app-click/ there | 17:02 |
| dpm | mzanetti, ok :-) | 17:02 |
| fginther | popey, yes, I realize the annoyance of having 2 different builds such that I even have to ask the question :-) | 17:02 |
| mzanetti | dpm: pushed again to the headers-to-trunk branch | 17:04 |
| fginther | popey, bazaar.launchpad.net/~sudoku-touch-dev/sudoku-app/trunk/view/head:/manifest.json#L14 is missing a trailing ',' | 17:05 |
| fginther | popey, the coreapps jenkins MP testing would probably have caught that if it was building click packages... I'll try to add that | 17:06 |
| dpm | mzanetti, oh cool, you worked around Layouts | 17:07 |
| dpm | fginther, any luck in finding out why Jenkins could not install the file-qml-plugin package on this MP: https://code.launchpad.net/~gang65/ubuntu-docviewer-app/ubuntu-docviewer-desktop-improvements/+merge/210866 ? | 17:08 |
| popey | balloons: can you please upload calculator 253 to the store? | 17:09 |
| balloons | popey, on it | 17:09 |
| popey | ta | 17:10 |
| fginther | dpm, thanks for the reminder. It looked like the version in the ppa was built against some old qt dependencies... I rebuilt it yesterday evening, but forgot to retry the test. Will do that now | 17:11 |
| dpm | excellent, thanks fginther | 17:11 |
| balloons | done | 17:11 |
| balloons | fginther, when you have a moment, I would like your input on https://code.launchpad.net/~popey/ubuntu-clock-app/fix-1315318/+merge/218067. The autolanding job using the device doesn't seem to work properly | 17:18 |
| balloons | there's also some other suspect errors | 17:18 |
| mzanetti | dpm: hey, regarding the performance issue | 17:21 |
| mzanetti | dpm: can you explain it a bit better? | 17:21 |
| mzanetti | how many notes do you have? | 17:21 |
| dpm | not many, but quite a few have images. Let me count | 17:22 |
| mzanetti | does this happen on the desktop? | 17:22 |
| dpm | mzanetti, 14 notes, testing on desktop now | 17:22 |
| mzanetti | anyway, it does happen on the phone with the qt fix, right? | 17:22 |
| dpm | mzanetti, yes, it happens on phone with qt fix. On the desktop scrolling seems to be fluid, but it's difficult to tell with the bug, since after a quick while the list jumps to its first item | 17:24 |
| mzanetti | dpm: just wanted to make sure its not only that | 17:25 |
| dpm | ok | 17:25 |
| mzanetti | dpm: ok. can reproduce it | 17:26 |
| dpm | ok, great | 17:26 |
| fginther | balloons, crap... Sorry about that click test failure. I'm working on sorting that out now. | 17:32 |
| fginther | dpm, the docviewer tests now run after rebuilding file-qml-plugin. There is one test failure: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2438/testReport/ | 17:36 |
| dpm | fginther, bummer. Ok, thanks for getting the infrastructure sorted, now it's on to us to fix the tests :) | 17:37 |
| dpm | popey, there are a couple of branches for Reminders pending autolanding (seems Jenkins is being a bit slow today) that I'd like to get on the next store update. Have you already done the Reminders upload today? In case you haven't, I just wanted to give you a heads up: perhaps it might be worth waiting until these have landed. Up to you: I'm mentioning it as perhaps then it'll be less work to wait for these 2 branches to land and do it all at once t | 17:45 |
| dpm | han doing 2 uploads | 17:45 |
| dpm | afk for a bit, bbl | 17:46 |
| popey | dpm: yeah, store has rev 110 | 17:46 |
| popey | dpm: happy to push another | 17:47 |
| popey | will do after the one I'm doing now | 17:47 |
| popey | sorry, that sounded confused. Yes, will push once those things land. | 17:47 |
| balloons | :-) | 17:51 |
| balloons | btw, how are we on getting reminders onto the dashboard? | 17:52 |
| === bfiller is now known as bfiller_afk | ||
| balloons | popey, how would you like some AP tests to go with your dropping letters merges? | 17:53 |
| popey | you offering some? | 17:53 |
| balloons | they both look like simple regressions.. probably could whip them up | 17:53 |
| balloons | I was going to test and help land them and thought.. hmm :-) | 17:53 |
| popey | regressions? nah, they've been broken forever | 17:54 |
| dpm | popey, sounds good, thanks | 17:54 |
| balloons | :-) well then, regardless.. yes I'll try reviewing and adding some tests to prove your fixes | 17:54 |
| popey | just gonna try and run AP tests against calendar balloons as the next one | 17:56 |
| balloons | ping barry | 18:15 |
| popey | balloons: 16 failures on calendar... | 18:29 |
| === chihchun is now known as chihchun_afk | ||
| popey | running again while dinner cooks | 18:29 |
| popey | hmm, a spinner always on screen during the calendar app tests. i think i need to delete my google accounts, not just disable sync | 18:30 |
| balloons | popey, we need to fix all the apps to properly setup envs.. we can do it now | 18:33 |
| * balloons can't remember if he filed a bug so it affects all core apps | 18:33 | |
| balloons | anyways, we could do it quickly for calendar to | 18:33 |
| popey | balloons: this fails basically every test | 18:34 |
| popey | how did this stuff land in trunk? | 18:34 |
| popey | gonna wait till it finishes and pastebin the full log and file a bug. | 18:34 |
| === bfiller is now known as bfiller-afk | ||
| dpm | balloons, does https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 look ok to you now? | 18:55 |
| balloons | popey, for you :-) https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/mock-test-env/+merge/218494 | 18:55 |
| popey | and for you balloons https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1316745 | 18:56 |
| dpm | feel the love | 18:57 |
| balloons | dpm, yes, you do need to merge the mp I proposed or jenkins won't be able to find and run the tests | 18:57 |
| * balloons notes he offered a solution while popey offered a problem :-) | 18:57 | |
| dpm | lol | 18:58 |
| dpm | balloons, which MP you want me to merge? I'm getting a bit lost now between your and xnox's MPs | 18:58 |
| balloons | popey, any other affected apps you know of please add as affects and I'll do them: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1316746 | 18:59 |
| balloons | dpm, lol.. my mp. it has nothing to do with the lxml issue | 19:00 |
| dpm | balloons, regardless, if you send me a link it will be much clearer to me which one I need to merge :) | 19:00 |
| balloons | dpm, https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/working-py3-jenkins/+merge/218488 | 19:02 |
| dpm | balloons, awesome, merged and pushed to https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 | 19:04 |
| balloons | dpm, awesome.. jenkins should let us know now | 19:05 |
| dpm | ok, cool - any ideas why https://code.launchpad.net/~nskaggs/reminders-app/py3-jenkins/+merge/218490 is failing? | 19:06 |
| dpm | balloons, ^ | 19:06 |
| dpm | I want to make sure Reminders is in shape to show it to the Evernote folks this week, and that we don't have any blockers for uploading new versions to the store | 19:07 |
| balloons | dpm, I'll look at it later | 19:07 |
| dpm | ok | 19:07 |
| dpm | balloons, argh, all tests failed now: https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 | 19:13 |
| xhoch3 | one creates a virtual arm chroot environment to develop apps in and create packages, right? | 19:16 |
| xhoch3 | then you can install these onto the device | 19:16 |
| xhoch3 | I have created a chroot, which I can see in Qt Creator, but how do I select it as a target? | 19:21 |
| dpm | xhoch3, when you open the CMakeLists.txt file in Qt Creator, it should show it for you to select it | 19:23 |
| xhoch3 | okok, I am starting with a plain Qt widgets project | 19:24 |
| xhoch3 | I just want to understand how it works | 19:24 |
| xhoch3 | dpm: can I use qmake? | 19:25 |
| dpm | xhoch3, unfortunately qmake does not work well with cross-compilation (or so I'm told, I'm not an expert, so sorry about the lack of details). That's why we're using cmake in Qt Creator, so that we can build C++ projects both on the desktop (on x86 or arm64) and on the chroots for armhf | 19:27 |
| xhoch3 | I see, ok, so I start by creating a non-Qt cmake project, I think I can add Qt support later on | 19:29 |
| balloons | dpm, sorry I'll look in a bit | 19:30 |
| dpm | np, thanks | 19:30 |
| balloons | it didn't work for reminders either as you said.. but it solved the issue with file manager | 19:30 |
| xhoch3 | dpm: it only shows the plain text representation of CMakeLists.txt, I am doing it wrong I think | 19:32 |
| balloons | so we might still need to understand some things we're missing | 19:32 |
| mzanetti | dpm: https://code.launchpad.net/~mzanetti/reminders-app/rework-resource-loading/+merge/218499 | 19:33 |
| mzanetti | rpadovani: ^ | 19:33 |
| dpm | mzanetti, nice! | 19:35 |
| dpm | xhoch3, you might want to try starting with one of the mixed (c++ and QML) Ubuntu templates in the SDK to see it in action | 19:36 |
| dpm | those should be using cmake | 19:36 |
| xhoch3 | dpm: unfortunately, they use qmake | 19:38 |
| rpadovani | mzanetti, code works well and the image in the note is very fast to load, but little preview takes a bit of time also after the first run. Shouldn't the preview being cached? | 19:39 |
| xhoch3 | File -> Create New Project -> Ubuntu and then I select a template | 19:39 |
| xhoch3 | the raw templates with QtQuick do not work either unmodified | 19:40 |
| xhoch3 | just the ones using qmlscene work right from the start | 19:40 |
| mzanetti | rpadovani: yes. but until I have loaded the text content, I don't know if there's an image in there | 19:45 |
| rpadovani | mzanetti, ok, seems right. Works well for me, I approve it, dpm, could you take a look and (top-)approve it? | 19:46 |
| dpm | xhoch3, hm, I thought all the non-qmlscene templates had been migrated to cmake. I'll have to check with the sdk folks tomorrow | 19:49 |
| dpm | rpadovani, mzanetti, giving it a go now | 19:49 |
| mzanetti | nice, thanks | 19:49 |
| dpm | mzanetti, building it now. I'm a bit out of touch with the Evernote API. Looking at the diff, what do "resources" mean in the context of notes? | 19:55 |
| mzanetti | dpm: file attachments basically | 19:55 |
| mzanetti | images, sound files... | 19:55 |
| dpm | ah, I see, thanks | 19:55 |
| xhoch3 | dpm, do you have a minimal example project that you could zip? | 19:55 |
| dpm | xhoch3, not really minimal, but you can grab the Ubuntu File manager app, for example. If you have bzr installed, you can just run this command to check it out: bzr branch lp:ubuntu-filemanager-app | 19:57 |
| dpm | and then have a look at the README file for the details on how to get it built | 19:57 |
| dpm | sorry that I don't have a simpler example | 19:57 |
| xhoch3 | no, that's perfectly fine | 19:57 |
| xhoch3 | I just want to get it going with as less friction as possible | 19:58 |
| === mspencer is now known as iBelieve | ||
| mzanetti | dpm: I change the section-headers back to use QtQuick.Layouts in the new-design branch, ok? | 20:04 |
| dpm | mzanetti, sounds good to me, yes | 20:04 |
| mzanetti | ok | 20:04 |
| xhoch3 | dpm: the README fails for me because it says I have to go to Project -> Add Kit and then select armhf kit, but there is nothing to select | 20:05 |
| xhoch3 | Add Kit is grayed out, I assume I have to configure it manually somehow | 20:06 |
| dpm | mzanetti, I've added a couple of comments to https://code.launchpad.net/~mzanetti/reminders-app/rework-resource-loading/+merge/218499 - it does not seem to work for me unfortunately | 20:08 |
| dpm | xhoch3, let me have a look | 20:08 |
| dpm | xhoch3, I assume you've done steps 1 to 5? | 20:11 |
| dpm | from http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/trunk/view/head:/README | 20:11 |
| mzanetti | dpm: can you try deleting the old cache dir? | 20:13 |
| dpm | sure | 20:13 |
| mzanetti | dpm: ~/.cache/com.ubuntu.reminders/ | 20:13 |
| xhoch3 | dpm: Yes, 1 to 4, in 5 I do not get prompted | 20:13 |
| xhoch3 | it reads that alternatively I can do 6 | 20:13 |
| xhoch3 | but 6 is not applicable, since I am missing the armhf, it's simply not there | 20:14 |
| xhoch3 | the kit, I mean | 20:14 |
| xhoch3 | under Tools -> Options -> Build & Run -> Kits I just have Desktop (default) | 20:15 |
| dpm | mzanetti, same result after deleting the cache: I don't get any image previews and as soon as I scroll I get the error output on the console and the lagging | 20:16 |
| === bfiller-afk is now known as bfiller | ||
| mzanetti | dpm: hmmm odd... I'll see what I can do | 20:17 |
| dpm | cool, thanks | 20:17 |
| dpm | xhoch3, under Tools > Options > Ubuntu > Click, do you have any click targets listed? | 20:18 |
| balloons | barry ping | 20:18 |
| xhoch3 | dpm, yes, trusty, Framework: ubuntu-sdk-14.04, Architecture armhf | 20:18 |
| xhoch3 | Update / Maintain / Delete | 20:19 |
| dpm | xhoch3, ok, cool. Can you 1) close the project 2) Delete the CMakeLists.txt.user file 3) Reopen the project ? That should now re-prompt you for the build targets | 20:19 |
| rpadovani | dpm, mzanetti https://code.launchpad.net/~rpadovani/reminders-app/new-notes-design/+merge/218505 | 20:21 |
| mzanetti | rpadovani: yay! will look at it in a few | 20:21 |
| xhoch3 | ok, I choose the build location, in the next dialog I have to run cmake, then finish | 20:21 |
| rpadovani | dpm, mzanetti also, we don't have a trash folder/tab/section | 20:21 |
| xhoch3 | no prompt | 20:21 |
| dpm | xhoch3, you shouldn't have to run cmake, it should be run for you. Can you try to do the same steps again and post a screenshot somewhere of the dialog that asky you to run cmake? | 20:22 |
| mzanetti | dpm: I've pushed a commit that adds some debug prints. mind generating a log for me? | 20:24 |
| dpm | sure | 20:24 |
| mzanetti | rpadovani: where did you see a trash folder? | 20:24 |
| dpm | ogra_, does https://code.launchpad.net/~popey/ubuntu-seeds/add-quicklayouts/+merge/218405 need top-approval or is it already on your TODO? | 20:24 |
| rpadovani | mzanetti, on the website | 20:25 |
| mzanetti | ah ok | 20:25 |
| dpm | nice work rpadovani, will have a look soon too | 20:25 |
| * mzanetti now gets why there's a GetDeletedNotes method in the api :D | 20:25 | |
| dpm | mzanetti, rpadovani, I'd leave the trash for now. I think the next feature we'll get asked to implement will be tags | 20:26 |
| mzanetti | dpm: right... I think I did already something with that... at least we're not far off iirc | 20:26 |
| xhoch3 | dpm: http://i59.tinypic.com/2s7fmrl.png | 20:26 |
| rpadovani | dpm, ok, I saw it this afternoon so I reported it :-) | 20:26 |
| dpm | mzanetti, ah, nice! | 20:26 |
| balloons | dpm, so my merge was a little off, heh | 20:27 |
| dpm | balloons, you nearly choked Jenkins to death! :-) | 20:27 |
| balloons | dpm, in python3 print is a function :-) | 20:27 |
| balloons | shall I update the old branch for you to re-merge? | 20:28 |
| mzanetti | rpadovani: seems the tile is too big, no? | 20:28 |
| dpm | balloons, sounds like a plan | 20:28 |
| dpm | xhoch3, so it looks like your Qt Creator is not using Ubuntu's cmake plugin, and I don't know why. I think you might need to wait until some of the SDK folks are around tomorrow (they're on European timezone) to help | 20:29 |
| rpadovani | mzanetti, the tile? Do you mean the title? Or the tile is the white rectangle? | 20:29 |
| balloons | dpm, done and pushed | 20:31 |
| dpm | mzanetti, here's some debug output for you :) http://pastebin.ubuntu.com/7406685/ | 20:31 |
| xhoch3 | dpm, so it is supposed to create a new kit automatically for me? | 20:31 |
| dpm | xhoch3, the kit should be there already, what the ubuntu cmake plugin does is to run cmake automatically for you and to offer you a prompt to select a build target using that kit | 20:33 |
| xhoch3 | ok, it's not there | 20:33 |
| xhoch3 | why not create one? | 20:33 |
| dpm | at first thought I would have said that you're missing the Ubuntu Qt Creator plugin, but since you're saying you can see the Ubuntu templates, it would appear you've got it installed already | 20:33 |
| mzanetti | dpm: thanks! | 20:34 |
| mzanetti | rpadovani: left some comments on the MR | 20:34 |
| xhoch3 | there seems to be a bug with missing kits, I have googled that | 20:34 |
| xhoch3 | that way I already added the desktop kit | 20:34 |
| xhoch3 | but I have no idea what to enter for the armhf kit | 20:34 |
| mzanetti | dpm: does this file exist? /home/phablet/.cache/com.ubuntu.reminders/587aa7be9c3fe6175c53d50f28d98a04.jpeg_0x162_image20140207_0001.jpg | 20:34 |
| dpm | xhoch3, no idea why you had to manually create the Desktop kit in the first place | 20:35 |
| rpadovani | mzanetti, thanks, I'm on it | 20:35 |
| xhoch3 | how about giving me the data (screenshot?) to create a armhf kit? | 20:35 |
| dpm | mzanetti, it appears to exist: http://pastebin.ubuntu.com/7406722/ | 20:36 |
| mzanetti | dpm: hmm, but the scaled down version doesn't | 20:36 |
| mzanetti | strange... | 20:37 |
| dpm | xhoch3, gladly, but I haven't got a clue which data you need | 20:37 |
| xhoch3 | dpm, when you click on the kit, it display the configuration at the bottom | 20:38 |
| dpm | xhoch3, define where I need to click | 20:38 |
| xhoch3 | Tools, Options, Build and run, then on the kits tab, there you should see your armhf kit somewhere | 20:39 |
| xhoch3 | if you click on its name, the parameters on the bottom change | 20:39 |
| mzanetti | dpm: stupid me.. seems I have to dropped a line when cleaning up debug prints before :D | 20:40 |
| mzanetti | dpm: I've pushed | 20:40 |
| mzanetti | now it should work | 20:41 |
| mzanetti | if it does I still need to clean out the current debug prints before merging | 20:41 |
| dpm | balloons, merged your change and pushed to lp:~dpm/ubuntu-terminal-app/merge-plugin - let's see what Jenkins has got to say now | 20:41 |
| balloons | dpm, hopefully only good things now :-) | 20:41 |
| dpm | mzanetti, ok, pulling now | 20:41 |
| dpm | mzanetti, it works now :-) . It really is a huge improvement | 20:45 |
| mzanetti | dpm: yay! let me drop the debug prints. I'll be more careful this time :) | 20:46 |
| mzanetti | dpm: also improves network traffic *a lot* | 20:46 |
| mzanetti | before we were loading all images on each note content update | 20:46 |
| mzanetti | now each image is loaded exactly once, scaled down to all the resolutions we need and never fetched again | 20:47 |
| dpm | mzanetti, yeah, not sure if it's related, but I notice the app being much more responsive | 20:47 |
| dpm | really cool | 20:47 |
| mzanetti | dpm: ok. debug prints dropped | 20:48 |
| mzanetti | and the image.save() call is still there :D | 20:49 |
| dpm | :-) | 20:49 |
| dpm | ok, pulling again | 20:49 |
| rpadovani | mzanetti, what do you suggest for the title? Actual size is 'large', but medium is too small... | 20:50 |
| mzanetti | rpadovani: I think its medium actually... I thought the same for the notebooksdelegate | 20:51 |
| mzanetti | rpadovani: the Notebooks delegate title is bold | 20:52 |
| mzanetti | rpadovani: you can try that too. I don't think its good to have that different in notes and notebooks anyways | 20:52 |
| rpadovani | mzanetti, the note one is Light | 20:52 |
| rpadovani | I can try with medium bold | 20:53 |
| mzanetti | yeah... but that would be a place where I'd be fine with differing from the ux spec.... I think some things are not consistent in there | 20:53 |
| mzanetti | but for spacings etc we need to stay the same. he really got that good imo | 20:53 |
| mzanetti | rpadovani: left another comment | 20:54 |
| rpadovani | mzanetti, seems I have same work to do :-) I'll work on this tomorrow, hope to be ready before the meeting! | 20:55 |
| mzanetti | rpadovani: sure | 20:56 |
| dpm | mzanetti, ok, works for me now \o/ will top-approve. I've noticed something else, but I'm not sure it's a big issue: https://bugs.launchpad.net/reminders-app/+bug/1316800 | 20:56 |
| mzanetti | dpm: this happens when you open a note and it has not been fetched yet... will elimite the warnings | 20:57 |
| dpm | what do you mean that it's not been fetched? So I guess this is displayed when the note is loading but it has not yet been displayed in the UI? | 20:58 |
| mzanetti | dpm: exactly | 20:59 |
| dpm | ok, gotcha | 20:59 |
| mzanetti | the ui tries to read the values, but everything is empty | 20:59 |
| mzanetti | so it prints those warnigns | 21:00 |
| dpm | man the app is getting nicer and nicer to use :) | 21:00 |
| mzanetti | then the note comes in and everything is updated without warnings | 21:00 |
| dpm | ah, ok | 21:00 |
| === jhodapp is now known as jhodapp|afk | ||
| dpm | mzanetti, do you have an idea of how to fix https://bugs.launchpad.net/reminders-app/+bug/1316176 ? This would be the next one on my list of "little annoying bugs for polish" :) | 21:02 |
| mzanetti | dpm: ah right... rpadovani said he investigated in that and found an SDK bug that seems to cause it | 21:03 |
| mzanetti | I didn't check myself yet | 21:03 |
| dpm | ah, ok. rpadovani, when you've got a minute, could you add a comment to https://bugs.launchpad.net/reminders-app/+bug/1316176 pointing out to the SDK bug? | 21:03 |
| rpadovani | dpm https://bugs.launchpad.net/reminders-app/+bug/1316176 | 21:07 |
| rpadovani | mzanetti, dpm I investigated a bit more, I didn't find a bug in toolkit that is equal to our bug, but also there are a lots of bugs about pagestack, tabs and wrong tools behavior. Also, I didn't find something in our code that could breaks toolbar. This doesn't mean that doesn't exist, but only that if there is, is hidden well :-) | 21:09 |
| dpm | rpadovani, ok, it seems we're guessing a bit here :) I'll see if I can have a chat about it with t1mp tomorrow morning. Thanks for looking into that! | 21:09 |
| mzanetti | dpm: btw, I've fixes stuff in here: https://code.launchpad.net/~mzanetti/reminders-app/new-notebooks-design/+merge/218503 | 21:10 |
| dpm | mzanetti, thanks. I've added a comment to see if we could add a small change to give some context for translators while at it. Those comments are then shown in LP and are a great help for translators | 21:16 |
| mzanetti | dpm: sure. will do | 21:19 |
| === salem_ is now known as _salem | ||
| dpm | great, thanks | 21:20 |
| mzanetti | dpm: pushed | 21:22 |
| rpadovani | mzanetti, mhh, the problem with the layout property in my implementation is that if I use Layout.fillHeight: true than an Image is loaded it brokes everything! | 21:23 |
| rpadovani | s/than/ and then/ | 21:23 |
| dpm | balloons, new failure on the terminal merge: https://code.launchpad.net/~dpm/ubuntu-terminal-app/merge-plugin/+merge/217380 | 21:27 |
| mzanetti | rpadovani: hmm... strange.. that shouldn't happen | 21:29 |
| mzanetti | dunno, would need to try myself | 21:29 |
| rpadovani | mzanetti, bah, probably I did a wrong implementation | 21:29 |
| rpadovani | mzanetti, I have to go now, ignore my last commit, it's only to have code to work on tomorrow at uni. See you! | 21:30 |
| mzanetti | rpadovani: np. good night | 21:30 |
| balloons | dpm, ok that's easy. it's still trying to run via python2 | 21:38 |
| balloons | dpm, so inside the debian-control file we need to specify python3.. that should have been in my merge | 21:38 |
| * balloons checks debian control file | 21:39 | |
| balloons | ahh, it's not there | 21:39 |
| balloons | dpm, add python3-autopilot as a depends to ubuntu-terminal-app-autopilot | 21:40 |
| balloons | that's will fix the issue, sorry about that | 21:40 |
| dpm | balloons, ok, pushed thanks | 21:50 |
| balloons | I'll top approve :-) | 21:50 |
| balloons | we are ready then yes? | 21:50 |
| balloons | the MP is a mind boggling 25k lines | 21:51 |
| dpm | balloons, awesome, thanks. Yes, it's a big one, but most of it is the addition of unchanged plugin code we were already running on the images. And the nice thing is that it will be subject to Jenkins tests, which it wasn't before | 22:03 |
| balloons | dpm, quickly on reminders it has a couple tests. adding tests that require online accounts is non-trivial and Leo has been working on it. He's of the opinion we are blocked without a solution from online accounts | 22:05 |
| balloons | let's talk tomorrow ping me | 22:05 |
| balloons | have a great night! | 22:05 |
| dpm | balloons, ok, cool, thanks. Could you find out what we would exactly need from online accounts? | 22:06 |
| balloons | in a nutshell, a way to pro grammatically add an account (aka, via autopilot) | 22:07 |
| balloons | dpm, basically I would not hold adding it to the build for this.. | 22:08 |
| balloons | there are tests | 22:08 |
| dpm | balloons, right, I'd like it to be like that too, but from Sergio's e-mail, he'll be asked why there are only a couple of tests when he requests to add it to the images | 22:09 |
| balloons | dpm, https://bugs.launchpad.net/account-plugins/+bug/1270264 | 22:13 |
| ahayzen | vthompson, o/ | 23:45 |
| vthompson | ahayzen, \o | 23:46 |
| vthompson | mhall119, are you around? | 23:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
