/srv/irclogs.ubuntu.com/2014/05/06/#xubuntu-devel.txt

Logan_hi ochosi :)00:09
ochosihey Logan_ 00:09
ochosigood to see you around :)00:09
Logan_bluesabre: any reason why this isn't in Utopic first?00:14
bluesabreLogan_: no particular reason, seemed more important to get it to trusty00:15
bluesabrebut yeah, it should also make its way to utopic00:15
bluesabreso if you're up for uploading it... :-)00:15
Logan_> Check that the bug is fixed in the current development release, and that its bug task is "Fix Released". It is, in general, not appropriate to release bug fixes for stable systems without first testing them in the current development branch.00:15
Logan_I mean, this is just the adding of a Recommends, but it's still standard procedure :P00:16
bluesabreah00:16
Logan_and does this change need to go to any other stable releases?00:16
bluesabreI filed the sru before utopic was open I think00:16
bluesabreno other stable releases00:17
Logan_ok00:17
Logan_I'll just change the target to utopic and upload to there (with you as the author in the changelog)00:18
Logan_and then I'll upload the SRU00:18
ochosiLogan_: actually we have a second SRU for you... :)00:19
Logan_link?00:19
ochosii haven't filed the bugreport yet, but the lightdm-gtk-greeter 1.8.5 release00:20
ochosihttps://launchpad.net/lightdm-gtk-greeter/1.8/1.8.500:20
ochosithis is actually a good summary, as it is very short ^00:20
Logan_bluesabre: also, the "verification-needed" tag is generally only added by the SRU team after it's in proposed, so I'll remove that from the bug00:20
bluesabrethanks Logan_00:21
ochosi+^00:21
ochosi+100:21
ochosiLogan_: if you can upload the greeter release to utopic too, that'd be a great start. i can try to get the paperwork ready tomorrow for the SRU00:44
ali1234okay, so the thunar crash changes depending on how many times you repeat the failed unmount01:10
ali1234and it also changes depending on whether it uses g_slice or malloc01:10
ali1234so there is definitely memory corruption of some kind01:10
ali1234so i figure repeating the unmount long enough will cause the crash without having to quit01:12
ali1234hmm well i fixed a gtk critical, but it wasn't the bug01:26
ali1234hmmmm01:43
ali1234so the crash changes depending on what view mode is in use, icons/list etc01:43
ali1234because each is a different component01:43
ali1234and it is this bit of memory that gets corrupted01:43
ali1234hmm01:53
ali1234getting somewhere... certainly looks like the early unref during failed unmount theory is correct02:01
ali1234the unmount operaton is done by glib and thunar passes in a bunch of callbacks02:02
ali1234wow... it's not the user callback02:09
ali1234it's not even the main callback... this makes no sense02:18
ali1234basically, calling g_mount_unmount_with_operation corrupts memory. the end02:18
ali1234hmmmmmmm okay02:23
ali1234the failed unmount part isn't even necessary02:23
ali1234all yohave to do is mount and unmount the same device 3 times then quit -> crash02:24
ali1234so i've been looking in the wrong place02:24
ali1234it has to be three times though02:29
drc" I have said it thrice: What i tell you three times is true."02:31
ali1234https://www.youtube.com/watch?v=xOrgLj9lOwk02:31
drcThat was my second choice :)02:31
ali1234any three will work too. you can mount then unmount three different drives and it still crashes02:35
ali1234no wonder it happens so much02:35
drcI haven't been paying real close attention...this is mounting/unmounting drives in thunar with 14.04?02:39
ali1234yeah, or 13.1002:39
ali1234although not tested with 13.10 there's just as many error reports from there02:39
ali1234and other distros too02:39
drcand usb external drives count?02:39
ali1234yes02:39
ali1234seems like it happens with anything that you can mount02:40
drcok, I've plugged in 2 external usb drives and a usb thumb drive.  Now use thunar to unmount them?02:40
ali1234you only need one02:40
ali1234start with them unmounted02:40
ali1234mount then unmount three times, then quit thunar02:41
drcbingo02:41
ali1234the only change i can make in the code that prevents the crash is to not call g_mount_unmount_with_operation02:43
ali1234it still crashes, even if i hand it a no-op callback02:44
drchuh, using 3 different drive does not crash.02:45
ali1234it does for me...02:46
ali1234it also depends on which type of file view you have selected02:46
ali1234icon view is easiest and most consistent02:46
drcThat's what I was using...still no crash with 3 different drives.02:47
ali1234this is a memory corruption bug so results are pretty random02:47
drcwell, they say that the memory is the second thing to go :)02:48
drcnope, can't make it crash with 3 different drives, one drive thrice, everytime.02:52
ali1234hmm well here's a thng, it only happens with the shortcuts sidepanel, not the tree sidepanel02:55
drcI use the shortcuts panel.02:56
* drc has a feeling that he's messing up ali1234's thinking.02:56
ali1234HMM02:58
ali1234hmmmmmm... this is a tricky one02:58
ali1234commenting: thunar_shortcuts_model_set_busy (THUNAR_SHORTCUTS_MODEL (child_model), device, TRUE);02:59
ali1234seems to prevent the crash02:59
ali1234and now we hit some gdk_threads code...03:03
drcgood hunting...bed time :)03:04
ali1234maybe it isn't anything to do withunmounting... maybe it is the mounting03:15
ali1234argh... neither works.03:17
ali1234lol... 3 times crashes... 2 times doesn't crash, and 4 times doesn't crash03:26
ali12345 is right out...03:27
ali12346 crashes03:27
ali12349 crashes03:28
ali12348 does not03:29
ali1234i think i've figured it out...04:18
ali1234well, i've at least narrowed it down04:23
Unit193Logan_: Nope.04:42
ali1234https://bugzilla.gnome.org/show_bug.cgi?id=72336605:12
ubottuGnome bug 723366 in Widget: GtkFileChooser "GtkFileChooser crashes due to a signal connection left behind by GtkMountOperation" [Normal,Resolved: fixed]05:12
ali1234pretty sure this is the problem05:12
ali1234aaaaaand... we don't have the fix in trusty05:17
ali1234yeah, they patched it in gtk3 and not gtk205:20
ali1234this explains why i could not catch the memory corruption happening... the invalid signal causes corruption when you close the window05:33
ali1234ie the corruption did not happen until you quit thunar05:33
ali1234morning elfy. i figured out the thunar bug. it's a gtk bug :(06:38
elfyali1234: yea read the backlog 06:40
elfythanks for finding it :)06:40
ochosiali1234: congrats06:53
ochosiso if it's a bug in gtk, we gotta SRU the patch/fix for trusty07:01
ochosishould be doable07:01
ali1234it's a trivial patch, we just need someone to upload it in gtk+2.007:11
ochosiyup, already asked in -desktop, but there's a dead silence there07:12
ali1234it's a bit early for them still07:12
ochosidepends, during the "hot phase" of trusty they were around :)07:12
ali1234i mean early in the day. it's 8 AM, they're probably still eating breakfast07:13
ochosisure07:14
ochosimmm, breakfast07:14
ochosii think you just gave me an idea07:14
brainwashali1234: nice work :)08:18
brainwashdoes this mean that every other distro is affected too?08:19
ali1234yes08:22
brainwashand why does it not crash when the user clicks the unmount icon?08:24
ali1234because it is random memory corruption08:24
brainwashah ok08:24
ali1234hence the monty python references08:25
ali1234you have to call a specific function exactly three times08:25
ali1234three is the number and the number shall be three08:25
ali1234probably if you called eject the right number of times it would also crash08:26
brainwashI see08:27
ali1234essentially what happens is that when you do a mount or unmount operation, you register a parent window for any dialogues that will get opened (like password stuff)08:27
brainwashbut only gtk3 has been patched? the upstream report was filed against gtk208:27
ali1234gtk registers a signal on that window08:27
ali1234when the operation finishes it deletes the operation object, but doesn't unregister the signal08:28
ali1234when the window gets deleted (when you quit thunar) it calls that signal, which trashes memory08:28
ali1234so the corruption never happens until you quit08:28
ali1234which is why it was so hard to debug08:28
brainwashthanks for explaining this :)08:28
ali1234and yes only gtk2 was patched08:28
ali1234i mean gtk308:29
brainwashbut gtk2 should be still somewhat maintained.. or?08:29
brainwashI don't quite understand why they skipped gtk2 in this case08:30
ochosijust talked to seb128 in -desktop, we can file a bugreport, attach the patch and go for SRU08:30
ochosiali1234: so there's no patch for gtk2 yet? i presume it will be pretty much the same though, right?08:31
ali1234it's identical08:31
=== sveta_ is now known as gry
ali1234the original bug report patch was against gtk2, but mclasen only applied it on gtk3 anyway08:31
ochosiright08:32
ochosivery nice...08:32
ochosianyway, let's get that going08:32
ochosigotta get some late breakfast, then i can write up that bugreport08:32
ochosii guess the patch needs to be slightly altered (comment removed?)?08:32
brainwashmmh, so we have to do the sru work :D08:32
ochosiwell, we need it08:32
ochosias opposed to practically all others08:33
ochosi(apart from lxde maybe)08:33
ochosi(and studio)08:33
slickymasterWorkelfy, you around?09:14
elfyyep09:14
slickymasterWorkgood morning09:15
elfygood morning to you :)09:15
slickymasterWorkone thing about your xfce4 Mouse Settings proposal09:15
elfyyep09:16
slickymasterWorkyou're just proposing to change the designation of each step, right?09:17
elfyyep09:17
slickymasterWorkok, just want to confirm that09:17
slickymasterWorkI'll have a review for you in about 30 minutes09:17
elfyonly actually doing it because I had some real ones to do - otherwise I'd not have bothered :)09:18
slickymasterWorkwell, some of them really need some rewording, which it's mainly what your MP seems to be about09:19
slickymasterWorkone other thing elfy, presently the test ask to <dt>Click the "Devices" tab</dt> -> <dt>Click the "Device:" menu</dt>09:20
slickymasterWorkI think it should be changed to <dt>Click the "Devices" tab</dt> -> <dt>Click the "Device:" drop down list</dt>09:21
elfywrite things on the MP - I'll read them there - otherwise I'll get confused - just working through the other optional stuff here 09:22
slickymasterWorkok, will do09:24
=== qwebirc854243 is now known as slickymasterWork
ochosiali1234: do you have an overview of the related thunar bugreports on launchpad?09:48
ali1234overview?09:48
ali1234there's like 50 of them09:48
ochosiall marked as duplicates?09:48
ali1234yeah, and even more not marked probably09:49
ochosii'd like to link to a list or include them somehow in the SRU report09:49
ochosii've written that one up now09:49
ochosiand am going to follow it up in -desktop09:49
ali1234https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/120329609:49
ubottuLaunchpad bug 1203296 in gtk+2.0 (Ubuntu) "thunar crashed with SIGSEGV in magazine_chain_pop_head()" [Undecided,Confirmed]09:49
ochosilaunchpad is killing me today09:50
ali1234i've already marked that against gtk+2.0 and the upstream gnome bug09:50
ochosii had to submit that bugreport 5 times because it kept timing out09:50
ali1234yeah i've been getting that all night too09:50
ali1234bank holiday, everything falls apart09:50
ali1234they're probably putting out the fires about now09:50
ochosimhm09:51
ali1234so anyway, that's the meta report for all this junk09:51
ali1234the explanation given on the gnome bug is the most concise though09:52
ali1234https://bugzilla.gnome.org/show_bug.cgi?id=72336609:52
ubottuGnome bug 723366 in Widget: GtkFileChooser "GtkFileChooser crashes due to a signal connection left behind by GtkMountOperation" [Normal,Resolved: fixed]09:52
ochosiyup09:52
ochosialready added that to my report09:53
ochosihere it is btw: https://bugs.launchpad.net/gtk/+bug/131650909:53
ubottuLaunchpad bug 1316509 in gtk+2.0 (Ubuntu) "GtkFileChooser crashes due to a signal connection left behind by GtkMountOperation" [Undecided,New]09:53
ali1234mark 1203296 as duplicate :)09:54
ochosiso ubuntu sponsors are processing this now, we just have to monitor it a bit09:54
ali1234nice work :)09:54
brainwashwhy didn't you reuse the existing bug report?09:54
brainwashjust curious09:55
ali1234it's a bit messy after i added loads of bug watches and it imported the comments09:55
brainwashah, makes sense09:55
ochosiyeah, for sru you want something cleaner09:55
ochosiso it gets processed faster09:55
ochosidarn, lp times out again on setting the duplicates...09:56
ali1234well, i suggest actually marking the other duplicate after it gets fixed09:56
ali1234to keep out "me too" noise09:56
ali1234that's assuming it gets fixed relatively quickly of course09:56
ochosiyeah09:57
ochosii already linked to the bugreport anyway09:57
ochosiso i guess we can leave it at that for now09:57
ochosibtw, i took the patch directly from upstream09:58
ochosii hope it applies on gtk2 in ubuntu09:58
ochosihad no time to look at that09:58
ochosibut if not, it should be fairly straight-forward to modify it accordingly09:58
ali1234yeah in gtk3 they removed the comment09:59
ali1234https://git.gnome.org/browse/gtk+/commit/gtk/gtkmountoperation.c?h=gtk-3-12&id=05f2f634260519b5448ffd53e8883412c025144309:59
ali1234looks like he quietly fixed a load of other bugs at the same time :(10:00
ochosimaybe he felt ashamed because of them and hence tried to sneak the fixes in ;)10:01
ali1234yeah that patch also fixes a memory leak in set_parent10:07
ali1234we can put a workaround in thunar to call set_parent(NULL) before unref'ing the mountoperation10:08
ali1234this will prevent the crash, but cause a harmless memory leak, when gtk is not patched10:08
ochosii asked in the upstream bugreport about getting the patch to gtk2 as well10:09
ochosisince folks in -desktop got all defensive about this being a simple oversight :)10:09
elfylol10:09
ali1234heh10:09
ali1234that would be the best resolution. get a patched gtk2 in U and then SRU it back from there10:10
ali1234we might get the memory leak fixed then too10:10
ochosiyup10:11
ochosithat's the plan10:11
ali1234man, i chased this bug all over the code10:12
ali1234i ended up implementing a menu item labelled "crash" with the minimum code required to trigger it10:12
ochosihehe10:13
ochosiwell, nice work though!10:13
ochosifor the first time it looks like this will be fixed in due time10:13
ali1234got it down to this: http://paste.ubuntu.com/7403729/ and i was like, "well, this has to be a Gtk bug." then i found the report10:14
ochosiholy crap, that's quite condensed :)10:14
slickymasterWorkelfy, enlighten me something. In the 1575_Xfce4 Appearance Settings test you kept <dt>From the launcher panel, click on the "Settings Manager" icon.</dt>10:21
slickymasterWorkthis is not valid anymore, or am I crazy?10:22
ochosiali1234: have you tested the gtk patch btw?10:22
ali1234no :P10:22
ali1234but i am 99.999% certain it is the cause10:22
ochosiwanna join the discussion on -desktop10:23
ochosi?10:23
ali1234okay10:23
ochosity10:23
elfyslickymasterWork: if it looks like I missed something - note it :)10:24
slickymasterWorkelfy, https://code.launchpad.net/~elfy/ubuntu-manual-tests/XFCEOptional/+merge/218310 <- done11:19
elfyslickymasterWork: thanks :)11:19
slickymasterWorknot sure if you'll agree with some of the suggestions elfy :P11:20
elfyI just did the catfish MP - that's all from the batch I just checked \o/ 11:20
slickymasterWorkelfy, do you want me to also review the catfish MP?11:21
elfyslickymasterWork: you can when you've time :)11:21
slickymasterWorkpast me the link, please11:22
elfyhttps://code.launchpad.net/~elfy/ubuntu-manual-tests/1315491/+merge/21838911:22
slickymasterWorkok, thanks11:22
slickymasterWorkelfy, https://code.launchpad.net/~elfy/ubuntu-manual-tests/1315491/+merge/218389 <- done11:33
elfyawesome slickymasterWork :)11:34
elfyslickymasterWork: pushed the big one back with the changes - if you want to doublecheck 12:06
elfyo/ amigamagic 12:24
amigamagic\o elfy12:24
ali1234thunar crash fix is now available at: https://launchpad.net/~a-j-buxton/+archive/gtk2mountop12:38
ali1234works for me, please test :)12:38
elfyali1234: do I really need to boot into trusty to test it :(12:57
ali1234i guess so12:57
ali1234utopic would also work, if you force install the debs12:57
ali1234because the gtk version is identical12:58
elfyok12:58
elfywill try and get a look a bit later today 12:58
ali1234i don't know how you build for different versions in a ppa12:58
amigamagicit works13:04
amigamagicI just tried13:04
amigamagicbtw, when I click on the triangle near the usb device, it will be completely removed so that I cannot mount it anymore unless I unplug and replug the device. Is this the expected behaviour?13:06
ali1234yes13:08
amigamagicok13:08
ochosiali1234: fix works13:09
amigamagicthe unmount from the contextual menu doesn't crash thunar anymore13:09
amigamagicgood job :)13:10
ali1234ಠ◡ಠ13:10
ochosiali1234: well i added your ppa and upgraded the gtk2 packages and now everything unmounts/ejects again as it should13:11
ochosiadded a comment to the bugreport to be sure13:12
slickymasterWorkhttps://code.launchpad.net/~elfy/ubuntu-manual-tests/XFCEOptional/+merge/218310 <- Approved elfy13:31
slickymasterWorkforestpiskie: ^^^13:31
elfyslickymasterWork: thanks - all done and synced now13:54
elfyali1234: a +1 from me as well in trusty13:55
ochosielfy: mind adding your +1 to the bugreport too?13:57
slickymasterWorkthanks for all that work elfy boss ;)13:57
ochosijust to get this on the record for the sponsors13:58
elfyochosi: was just doing that :)13:58
ochosioh great :)13:58
elfyslickymasterWork: thanks for you checking them :)13:58
* elfy thinks that by the time he writes the QA blueprint he can either not write anything at all - or write them and include :DONE :p13:59
elfyGridCube: hi - pressure is now off of the optional tests - all done and synced up to the tracker \o/14:00
slickymasterWorkeh eh that's what I call being really pro-active elfy 14:00
GridCube:) sorry i was of no help elfy :(14:00
elfyGridCube: that's ok - there will be more to do :)14:00
elfyand you can help with bzr too14:01
elfyGridCube: justhaving someone to write testcase edits - so that I don't have to write them, find someone to approve, then merge and sync will be an enormous help14:03
elfyand someone watching the trackers - bugs will need to be checked and added to the eventual bug blueprint14:03
elfyall stuff that slickymasterWork helped me with - but while he's happy to help - he's got Docs to worry about now :)14:04
GridCubeelfy, alright, ill try to do some of those tasks14:05
elfythanks GridCube - I need to add you into the QA team I think 14:05
amigamagicI don't know if it could help but I too added a comment for the bug 131650914:32
ubottubug 1316509 in gtk+2.0 (Ubuntu) "GtkFileChooser crashes due to a signal connection left behind by GtkMountOperation" [Undecided,New] https://launchpad.net/bugs/131650914:32
ochosiamigamagic: thanks, it's certainly good to show them that ppl have tested the patch successfully14:34
amigamagicI'm glad to help :)14:35
elfylderan:  we need to look at the autopilot list - sort out those that are optional so we can ignore them and then decide which we should try and target this cycle15:33
lderansounds like a plan15:38
elfycool15:44
elfyas soon as I've sorted the blueprint out I'll get hold of you then :)15:46
lderancool :)15:54
sidi-valenciahttp://blog.martin-graesslin.com/blog/2014/05/screenlocker-architecture-in-plasma-next/15:55
ochosisidi-valencia: good read, i think i read something on this issue by martin before16:09
ochosiactually their solution is not so different from ours16:09
ochosiwe also have three separate processes, if the greeter crashes, lightdm will bring it back16:10
ochosilightdm handles the authentication16:10
ochosiand light-locker handles the grabs and toplevel window16:10
ochosithe only nuisance is the VT switching16:11
sidi-valenciaochosi, read my comment when it shows up16:21
sidi-valenciathey can do even better with 3 processes ;P16:21
=== Guest67468 is now known as Logan_
=== nanotube is now known as bitcoin
=== bitcoin is now known as nanotube

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!