/srv/irclogs.ubuntu.com/2014/05/09/#juju-gui.txt

huwshimijcsackett: Yay!00:00
huwshimijcsackett: What's a service units?00:01
huwshimi*unit00:02
huwshimijcsackett: Oh, I see what you're saying.00:03
huwshimirick_h_: If you return I have some questions...00:38
kadams54Yay!01:03
jcsackettevening kadams54.01:05
kadams54So does this accomplishment include a PR that needs review/QA?01:06
jcsackettkadams54: hopefully, momentarily.01:08
jcsacketti'm figuring out how to test something.01:08
jcsackettthen, yes.01:08
jcsackettkadams54: you going to be around for a bit?01:09
kadams54As long as it takes to wrap up work on my card01:10
* jcsackett get zooming on tests01:12
rick_h_huwshimi: howdy01:15
rick_h_huwshimi: sorry, had a thing with the wife tonight. I meant to mention it when we talked earlier01:15
huwshimirick_h_: It's all good, you've been working a lot :)01:15
rick_h_huwshimi: shoot me a hangout url if you want and I'll join in for questions01:16
huwshimirick_h_: I just wanted to ask with the uncommitted stuff if there's actually anything that can be in an uncommitted state currently?01:16
huwshimirick_h_: It doesn't look like we can add machines or containers yet...01:16
rick_h_huwshimi: no, but it's next. So I wanted to have the asset and css class ready to add to the tokens01:17
rick_h_huwshimi: so I figured we could look at styling the token and testing with it hard coded or something for the moment, so it's one less step one we can create them01:17
huwshimirick_h_: Ah sure, I'll add some uncommitted states then.01:18
huwshimirick_h_: Should I add another card just for the states then?01:18
rick_h_huwshimi: yea, and it's kind of shared between the uncommited machine and container01:18
rick_h_huwshimi: ? I thought I put your head on a card for the uncommitted state?01:18
rick_h_huwshimi: or you mean add a card for making the new machine work?01:19
huwshimirick_h_: Oh, you did, but I thought I couldn't do it. I mean add a card just for the html/css work01:19
rick_h_huwshimi: ah gotcha01:19
rick_h_ok, that's fine01:20
rick_h_huwshimi: do you follow the d3 stuff to look at the card you've got now? 01:20
huwshimirick_h_: It looks quite a simple fix, unless I'm missing something: https://github.com/juju/juju-gui/pull/28701:21
rick_h_huwshimi: ooh, super awesome then01:22
rick_h_huwshimi: I'll check it out shortly then and QA it01:22
huwshimirick_h_: Thanks.01:24
huwshimirick_h_: In the mockups there are two uncommitted states. One with a blue background and one with blue circles next to the properties. Do you know the difference?01:28
rick_h_huwshimi: so they is supposed to be both that I'm aware of. /me goes to look at hte mockups01:35
rick_h_ah, these are out of date. So The blue is the background for new machines and new containers01:36
rick_h_the circle is used for a machine that exists, but contains an uncommitted service 01:36
rick_h_so for the demo purposes we can get away with just the blue backgroud since both the machine and container will be new/uncomitted01:37
huwshimirick_h_: OK01:37
huwshimirick_h_: This isn't going to take long, anything in particular you'd like me to take a look at for this afternoon?01:40
rick_h_huwshimi: well I'm going to look through your branches and ant's and then try to wrap up mine. if you get time to check out ant's branch and QA and see how that looks that'd be good01:48
rick_h_there's some failing tests I'll help him get through01:48
rick_h_after this level of stuff we need to get the drag/drop of unplaced unit tokens to create the machine/container for the demo01:48
rick_h_but I think those have to wait until existing branches land01:48
rick_h_huwshimi: check outu https://docs.google.com/a/canonical.com/file/d/0B7XG_QBXNwY1MmNDVXNoZDh3VFU/edit and see if we've got any missing UX bits you can see or point out01:49
rick_h_it's starting to blur a bit for me01:49
huwshimirick_h_: I could create the 'new machine' and 'new container' forms ready to be hooked up?01:53
huwshimi(create the base widget/view and html/css etc.)01:53
rick_h_huwshimi: well so the demo is to drag over the header and the header will create the new uncommitted machine01:56
rick_h_so I think we'll just have to spin up a token, I'm not sure if the constraint stuff is there atm01:56
huwshimirick_h_: Ah, so we'll by-pass those forms for now?01:56
rick_h_It's hard to see in his doc there01:57
rick_h_I think we'll drop, bring up a form to select constraints on the new machine and then go there01:58
rick_h_so there might be a 'part' of the machine token that needs doing there along the lines you're seeing01:58
huwshimiok01:58
huwshimirick_h_: I guess I can create the header states for dropping too.01:58
rick_h_huwshimi: cool01:58
rick_h_huwshimi: can you put some notes in the other pull request for me to know what's up in that review? The final machine view rendering/etc.02:05
rick_h_qa notes or anything I need for background02:05
huwshimisure02:07
huwshimirick_h_: Updated. Is that enough info?02:12
rick_h_cool thanks huwshimi 02:12
rick_h_huwshimi: note added 02:15
* huwshimi looks02:16
huwshimirick_h_: Card added.02:18
rick_h_huwshimi: thanks, there may be an existing test but want to make sure we go back on it if not02:18
huwshimirick_h_: Yep, np. I don't remember there being any tests02:19
huwshimibbs lunch02:54
jcsackettkadams54: don't know if you're still up, but you won't see a PR from me tonight. rebase just did something awful and i'm too tired to sort it.03:00
kadams54Gah! Alright man, get a good night's sleep.03:01
kadams54huwshimi: if you're interested, just put up https://github.com/juju/juju-gui/pull/289 which is the animation cleanup stuff that was started in the sprint.03:31
rick_h_thanks kadams54 03:34
rick_h_kadams54: can you rebase that down please?03:34
kadams54Yeah, planning on it.03:34
rick_h_kadams54: cool thanks03:35
huwshimikadams54: Great, I'll take a look03:37
huwshimikadams54: QA looks good.03:53
kadams54woot03:53
huwshimiUgh, looks like selenium is killing our ci again.04:29
rick_h_huwshimi: it's my fault04:30
rick_h_huwshimi: there's a flaky test in ant's branch I'm trying to work around04:31
huwshimirick_h_: Oh, that's ok then :)04:31
rick_h_yea, it's all my doing and I'm watching it closely 04:31
huwshimiAh good04:32
huwshimiI only noticed it in that branch anyway04:32
rick_h_finally!05:35
rick_h_ok, off to bed for me. Thanks for the great work huwshimi. We're actually going to be closer than I thought we'd be. Might be able to make it with some weekend work05:35
huwshimirick_h_: Great!05:36
huwshimirick_h_: Goodnight :)05:36
huwshimirick_h_: I tried to figure out this bug, but not sure what's going on: https://bugs.launchpad.net/juju-gui/+bug/131776606:54
_mup_Bug #1317766: Hardware info not available when a machine is first added <machine-view> <juju-gui:New> <https://launchpad.net/bugs/1317766>06:54
* frankban lunches11:58
rick_h_morning12:03
antdillonrick_h_, morning12:28
rick_h_howdy antdillon 12:28
antdillonrick_h_, It seems like the summary panel should be its own view?12:30
rick_h_antdillon: well, my first thought was that the deployer bar would launch it and watch it for the deploy button or cancel button and update itself based on that interaction12:31
rick_h_antdillon: so I'm ok with it being a view on its own, but I think the deployer bar needs to create, watch it, and then handle it12:32
rick_h_antdillon: but to start out with you could wire it into the deployer bar view, create a new template, a 'onDeployClick' handler that creates a new div floating with the template info rendered12:33
rick_h_there's not a ton in that popup for this demo. Just a list of the two services and such12:33
antdillonrick_h_, Yeah  sure12:33
rick_h_so rather start small and iterate 12:33
antdillonCool12:34
rick_h_so I'd rather start small/simple and iterate if that makes sense12:34
rick_h_but tell me if I sound crazy, still waking up 12:34
antdillonyeah, i'll get it working from the deployer bar. shouldnt be hard to split out later if we need12:34
rick_h_frankban: starting qa, we'll try to round up one or two others to make sure we hit it all12:49
frankbanrick_h_: thanks12:50
rick_h_morning luca 12:50
rick_h_luca: is this meeting something we need to do today or can we bumb it post-demo on tues?12:50
lucarick_h_: I was literally just about to cancel12:51
rick_h_luca: <312:51
lucarick_h_: hehe12:51
jcsackettmorning all.12:57
rick_h_morning jcsackett 12:57
rick_h_frankban: qa ok and thanks for making me find a couple of other issues :)13:00
redirmorning13:00
frankbanrick_h_: thanks for QAing I also filed two new bugs related to the left inspector13:01
jcsackettrick_h_: so, i seem to now only have "view" access to the juju ui calendar--it won't let me make or move an appointment. though it did let me delete it. very strange.13:01
rick_h_frankban: yep, putting them on the board as well13:01
rick_h_jcsackett: :/ ok will look13:01
frankbanrick_h_: mine are already on the board13:01
frankbanrick_h_: in backlock/deck13:02
rick_h_frankban: oh ok cool then13:02
kadams54guihelp Got a PR that needs review (and more QA wouldn't hurt either): https://github.com/juju/juju-gui/pull/28913:07
rick_h_kadams54: yea, all branches need one review and one qa to start13:08
rick_h_kadams54: I'll peek in a bit thanks for the ping. 13:09
kadams54rick_h_: Looking for another card. Got any suggestions?13:09
rick_h_antdillon: how are you doing? Need a hand with anything? kadams54 might be able to?13:09
antdillonrick_h_, All good, styling up the panel now13:10
rick_h_kadams54: some more qa on frankban's branch would be good, helping out antdillon on the summary view, or looking at the "do not load the real inspector after the deploy" card13:10
rick_h_kadams54: are the top of the list atm13:10
kadams54kk13:11
kadams54frankban: https://github.com/juju/juju-gui/pull/282 right?13:11
frankbankadams54: yes thanks13:11
rick_h_kadams54: added another bug card that should be a nice one to look at around the missing hardware info.13:14
jcsackett...nothing like figuring out conflicts when all the code you were working on gets smashed by other code...13:16
rick_h_jcsackett: that smashed/13:16
rick_h_?13:16
frankbanguihelp: I have three QA ok for my branch. Can I assume I also have a +1 to land the code?13:30
rick_h_frankban: just did it13:30
rick_h_frankban: so got you in line after huw's two13:31
frankbanrick_h_: :-) cool thanks13:31
redirbac: yt?13:31
bacredir: hib13:33
redirbac: I had no problem getting the local demo going. heartbeat shows 3 fails: API* interesting and bundles collection. It is still ingesting though.13:36
rick_h_redir: yea, bundles ingest last and part of insteresting is having featured which you don't get oootb13:36
redirso it works13:36
bacredir: that is good13:36
bacredir: thanks for proofing that doc.  i thought things may have changed since it was written.13:37
redirnp13:37
redirI did kill my net and verify that I could find charms too.13:38
redirFWIW13:38
rick_h_woot13:38
jcsackettrick_h_: it's moderately awful. virtually every function i touched has been modified in landed branches. every step has non trivial conflicts.13:39
rick_h_jcsackett: ok, let me know if you want to run through it in a pair for an extra set of eyes13:39
rick_h_jcsackett: and :( that we managed to overlap that much13:39
jcsackettrick_h_: looks like it's fallout from the "don't re-render the entire machine view" and the bit that gets units on machine tokens.13:40
jcsackettso maybe once i'm done touching those bits the rebase will calm down.13:40
rick_h_jcsackett: cool13:44
hatchluca was our call to be rescheduled? 13:57
lucahatch: I cancelled it because I didn’t want to take up your time when your all so busy13:58
lucahatch: it’s low priority for the time being so we can do it some other time13:58
hatchalright no problem13:58
rick_h_kadams54: heads up, that bad machine data shows up in a live lxc deploy as well. So we need to hit it from both a new server note deployed yet, and an existing lxc one without that data14:01
kadams54ok14:02
kadams54rick_h_: Would be good to have a pre-impl chat14:02
rick_h_ugh, we need cleaner ghost names for services now. 6349192$:db → 63449111$:slave lol14:03
rick_h_kadams54: k, shoot me a link14:03
kadams54rick_h_: https://plus.google.com/hangouts/_/72cpikalb7ek14gkppcfots2so14:04
kadams54I am hungry for lunch.14:11
kadams54At 10 AM.14:11
kadams54Clearly I am missing the Vegas brunch buffets.14:11
kadams54;-)14:11
rick_h_frankban: do you have time to look at esc-enabling the add-unit call in the env ?14:12
hatchkadams54 haha14:13
frankbanrick_h_, kadams54: FYI lxc containers only provide arch14:13
frankbanrick_h_: add_unit in ecs?14:13
rick_h_frankban: yea, so we're just going to go with "Hardware characteristics unavailble"14:13
rick_h_frankban: add_unit in the env needs to go through the ecs and then be added to your unit list as a ghost?14:13
frankbanrick_h_: is there a UX reason why we don't show machines' architetcure?14:13
rick_h_frankban: just wasn't on the list from UX14:14
rick_h_frankban: I think it's rare for them to vary a lot in an env so it's repeat info14:14
frankbanrick_h_: ok, so in mass scale when we add units we need 1) to create unplaced units in the db and 2) to register corresponding calls on ecs right?14:15
rick_h_frankban: well, I'm thinking all around. When we drag/drop a service we'll create a new service (ghost) but it won't show up in machine view as an unplaced unit unless there's also a ghost-unit on that service14:16
rick_h_frankban: so it would work for both the mass scale up, but also just for the demo path of drag/drop a service14:16
rick_h_is what I'm thinking14:16
rick_h_frankban: and then the machine view panel, watching that new unit list, would update the list of unplaced units in the UI14:17
frankbanrick_h_: sounds good, I'll tackle that once the units branch is landed. is there a card for that?14:18
rick_h_frankban: there is now14:19
frankbancool thanjks14:19
frankbanthanks even14:19
rick_h_frankban: cool, your branch should land in about 15min14:19
rick_h_it's running through now14:19
frankbanyeah14:19
hatchluca maybe we should also add to this naming thing other 'required' settings too14:24
lucahatch: ok will do14:28
hatchluca, so if I drag a service to the canvas and then click the 'deploy' should it auto put the unplaced unit on a machine?14:29
hatchI'm working on this interaction right now14:29
rick_h_hatch: for the demo what we're doing is to create a ghost service with a single unit that frankban is going to make a ghost-unit14:29
rick_h_hatch: using the add_unit call, like the mass scale up14:30
hatchok, and for the not-demo?14:30
rick_h_hatch: we'll implement the scale up journey in the inspector for existing services and we're in talks with luca on the path for non-existing services14:31
rick_h_hatch: probaly on the deployment confirmation page asking you to go and place those units or something14:31
rick_h_hatch: but there's some workflow TBD there 14:31
hatchoh...ok14:31
rick_h_the 'no inspector' was new in vegas and we've not had time to chase the path all the way through yet14:32
hatchok, I've just removed the inspector opening from the charmbrowser right now and I've been finding all of these use cases which seem broken now14:33
hatchso that's why Im' asking heh14:33
rick_h_hatch: definitely14:33
rick_h_hatch: and we'll be asking luca a lot...wed :)14:33
* hatch shakes fist like an 80s cartoon baddie....."and he better have answers"14:34
lucarick_h_: hatch haha We’ll see how the no inspector thing works out14:34
lucarick_h_: hatch I would like to test it and see how it feels14:34
rick_h_luca: yep14:35
hatchatm, not very good :P14:35
lucahatch: f u :P14:35
hatchlol!14:35
rick_h_frankban: landed woot14:37
rick_h_jcsackett: Makyo frankban's branch has hit for a nice rebase from develop14:37
frankbanrick_h_, hatch: thinking about add_unit: I guess we'll need an important change when under mv flag: currently when we deploy from the inspector we pass the provided units to env.deploy. this means right now with a single call we deploy the service, add machines and place units to those machines. we need to instead deploy with numUnits=0, then have the ecs calls reflect this dependency chain: deploy -> addMachines -14:37
frankban> place units14:37
rick_h_frankban: hmm, can we update the ecs deploy to add the ghost service we need using the existing path?14:38
rick_h_frankban: I mean the add_unit needs to be ecs-able, but that's mainly for scaling exisint units which we can come back to if it's not in the line of sight we need for the demo14:39
rick_h_existing14:39
hatchfrom what I understand, the deploy will now do nothing but create an unplaced unit14:39
hatchso the user will have to take 3 extra steps in this new UI14:40
rick_h_hatch: right, but hte service needs to be there as well so that you see it in the service view and when you hit deploy you get the service info14:40
rick_h_hatch: right, from the UI perspective right now yes14:40
jcsackettrick_h_: whoo!14:41
frankbanrick_h_: if we need a ghost service that's doable, but when we click deploy we still need things to happen in a specific order14:41
hatchyeah we still need the ghost14:41
rick_h_frankban: right, which is why I'm wondering if we can work with the current chain 14:41
rick_h_frankban: hatch hop on the standup call early?14:41
hatchsure14:41
hatchecs supports this type of requirement14:41
frankbansure14:41
hatchso we can modify the ecs deploy to add a machine if it doesn't have one14:42
hatchI think anyways....14:42
hatchoh hmm14:42
hatchmaybe not...14:42
rick_h_forget the machine part for now, it'll be manually done and its own ecs line item before services go onto it14:42
hatchok ecs doesn't support adding machines right now14:43
rick_h_right, but the env has the call and it's next on the list14:44
rick_h_hatch: coming on the call?14:44
hatchoh, I wasn't sure HOW early14:44
hatchhaha omw14:44
jcsackettjujugui: call in 2.14:58
rick_h_jujugui call now 15:01
rick_h_antdillon: you're welcome to join https://plus.google.com/hangouts/_/calendar/cmljay5oYXJkaW5nQGNhbm9uaWNhbC5jb20.t3m5giuddiv9epub48d9skdaso?authuser=115:01
antdillonrick_h_, Sure15:02
hatchrick_h_ I was joking about it being Makyo's fault :) but you will probably want to start with the code in ghost-service-inspector.js line 18515:18
MakyoWhew!15:18
hatchthat's where it determines if it should open an inspector or not after clicking deploy15:18
rick_h_hatch: yep, will do. I was going to start hunint down anything that creates an inspector15:18
hatchthe odd part is that it also opens the machine view15:18
hatchso there are some crossed wires there somewhere15:18
rick_h_yea, will look15:18
* rick_h_ goes for a little walk for a breather. biab15:22
hatchjujugui lf a really quick review/qa https://github.com/juju/juju-gui/pull/29215:34
hatchkadams54 when you get a chance can you rebase your animation branch into logical commits plz15:36
kadams54hatch: Well now, that's pretty subjective :-) Yeah, I'll rebase it down.15:37
hatchhaha - I consider a logical commit one that, when landing on in a bisect, doesn't break :)15:37
kadams54Done15:41
kadams54hatch: --^15:42
hatchkadams54 thx, review done with trivial15:53
hatchs15:53
hatchjujugui so do we have unplaced units now on develop?15:54
frankbanhatch: we have a db.units model list. so if you use db.addUnits passing a unit with no machine field it is unplaced15:55
hatchok but the UI isn't hooked up to that yet15:56
hatchcorrect?15:56
hatchantdillon I just saw the work you did, gw thx15:56
frankbanhatch: in the machine view panel I see this.get('db').serviceUnits. it should be this.get('db').units;15:57
antdillonantdillon, Thanks, little quick15:57
antdillonantdillon, Should have the deply summary with you shortly15:58
frankbanhatch: we also have db.units.filterByMachine(null) which returns all unplaced units15:58
hatchfrankban yeah ok, I'll take that card to hook the UI up15:58
hatchantdillon talking to yourself? ;)15:58
antdillonhatch, long week15:58
hatchlol15:58
rick_h_hatch: you rerunning your tests? That's a spurious IE10 one that hit you16:03
rick_h_hatch: do you have a reviewer for yours yet or still need one?16:03
frankbanrick_h_, hatch: maybe we have a conceptual problem here: to create a new container in the juju-core API we must call addMachines([{parentId: '1', containerType: 'lxc'}]). As you can see, we must know the parentId. Assume (like in the demo) we create a new machine and then a container in that machine. For the second call we must know the id of the machine in the first call. And we only know that when the first call 16:04
frankbanreturns data.16:04
hatchrick_h_ I don't think anyone stepped up yet16:04
hatchI can re-run it16:04
rick_h_hatch: k, will look16:04
hatchthx16:04
rick_h_frankban: :/ so we have this with services and relations right? We use the temp service name and update it?16:05
hatchwhat he said16:05
hatch:)16:05
jcsackettrick_h_: ok, i've fixed up the merge of doom, but we have a problem that may or not be minor.16:05
frankbanrick_h_: for services we already know the service name at the time of the deploy call (we provide the service name)16:05
rick_h_frankban: can the ghost machine (representing the container) have a ghost id that's 9999 or z1 or something?16:05
rick_h_frankban: and have that updated when we get the parent call back with the new model data?16:06
rick_h_jcsackett: heh, hit me. 16:06
rick_h_frankban: if not, can we mold the demo so that he first creates the machine and then goes back to create hte container as as second step and be ok?16:07
jcsackettrick_h_: so, the logic that now updates the machine tokens only fires when a machine is added--not when a container is.16:07
jcsackettso we don't get new service icons on the machine tokens as they're added.16:07
jcsackettyou can  see them just fine if you click the machine and get the containers, but you'll only see the first service unit icon on the machine token.16:07
rick_h_"Hey, let's go deploy mysql, create a new machine yay" hit deploy, go watch it come up in service view, "now let's deploy phpmyadmin, but in a container on that machine" frankban 16:07
rick_h_jcsackett: a container is a machine16:07
rick_h_jcsackett: so it should fire if I understand things correctly16:08
hatchfrankban There is a callback which is called after each task executes so we should be able to parse out the new machine names there.... Makyo  this is supported with your executioner right?16:08
jcsackettrick_h_: nope. machine tokens are only updated when what the machine view sees as a machine is added.16:08
jcsackett(or removed)16:08
rick_h_jcsackett: right, but a container is just a machine with a parent id16:08
rick_h_jcsackett: so can we not either listen more closely on machine update?16:09
jcsackettshorter answer: containers being added to not update machine tokens.16:09
rick_h_jcsackett: or something16:09
jcsackettrick_h_: we can, i'm just updating you on the branch.16:09
rick_h_jcsackett: ok thnking16:09
jcsackettas it expands into endless changes. :p16:09
frankbanrick_h_, hatch looking at the ecs code16:09
rick_h_jcsackett: ok, that's fine. It's a step forward and we can hit it up as follow up16:09
jcsackettrick_h_: so put it up for review?16:09
rick_h_jcsackett: yes16:09
rick_h_let's keep the chunks moving16:09
jcsackettrick_h_: got it.16:09
rick_h_jcsackett: just add a card at the end of the line, but leave it in the ready to code in case we can get to it16:10
rick_h_jcsackett: a quick test if a flash back to service view and back to machine view helps the situation?16:10
hatchfrankban thanks, Makyo did the execution stuff but I remember he built on the callback wrapper which I added already to progress each item in the graph16:10
rick_h_jcsackett: e.g. "in the demo, go look at the new block here and back to machine view to get the updated UI"16:11
rick_h_jcsackett: the old trick them by never keeping your hands still enough for them to track :)16:11
jcsackettrick_h_: i'll check that.16:14
jcsackett...i think that should work, actually.16:14
rick_h_hatch: qa issue with your branch, I can't add the relation16:18
rick_h_hatch: it needs to also trigger the deploy button function in the inspector16:18
hatchohh ok16:19
hatchmy bad16:19
rick_h_hatch: so the qa steps I'm trying is "drag/drop mysql, drag/drop mediawiki, relate them, go to machine view, hit deploy button, go back to service view"16:19
hatchahhh this UX is so messing with my head16:19
rick_h_hatch: yea, undersstand16:19
* hatch whispers to himself, it's just a demo, it's just a demo16:20
hatch:D16:20
rick_h_yea, just a demo behind feature flags16:20
hatchok sorry I'll add that in16:20
rick_h_thanks16:20
rick_h_jcsackett: for the follow up tests add a card please and mark it high priority16:22
rick_h_jcsackett: in the on deck lane in backlog16:22
* jcsackett nods16:22
jcsackettrick_h_: for the next thing shall i go ahead and jump on the service units updating on machine token?16:23
rick_h_jcsackett: no, hatch did you add the card for showing the unplaced units?16:23
Makyorick_h_, Man, ec2 is slow today.  Confirmed that services are now placed with annotations.16:23
hatchrick_h_ I put my head on it, but I wont be able to start on it for a bit16:23
rick_h_jcsackett: that card can wait if we've got the "flip views" workaround. We need to get unplaced units showing asap and then start the drag/drop work16:24
rick_h_hatch: k, jcsackett can you start with ^16:24
rick_h_jcsackett: notes that frankban noted how to update it in irc above ^16:24
hatchoooo boy this is quite a bit more work than I had thought......16:25
jcsacketthatch: everything on this is more work than we thought. :p16:26
* rick_h_ ponders evil evil ness16:26
hatchhaha16:26
rick_h_hatch: so let's just say....16:26
jcsackettrick_h_: i'm fixing some lint and goofiness on my PR, then i'll check the flip views workaround.16:26
rick_h_hatch: that we render the inspector off screen, simulate click deploy button, simulate click close button, carry on16:26
rick_h_bah, can't do that 16:27
rick_h_when he clicks on the service to make the relation it'll blow up16:27
hatchit should be ok, just more work than I thought16:27
hatchbecause we parse the UI for the config options now16:27
rick_h_hatch: ok16:27
frankbanrick_h_, hatch: assume you add two machines and then a container to the first one: from the environment perspective (go.js) we only see something like: addMachines([{}]); addMachines([{}]); addMachines([{containerType: 'lxc', parentId: ?????}]). I can surely add a change focused on the demo (assume the machine added will be the "1") but in general the current design should be improved in some way AFAICT16:28
rick_h_hatch: yea, was worried about that. Can we jsut not pass for defaults16:28
hatchI've got to compare the formatting but I think we can just pass in the defaults if everything maps correctly16:28
rick_h_frankban: agreed, I think we could look at adding a new method like addContainer that can keep some metadata to help track things16:28
rick_h_frankban: or update the ecs to start to tag items with a unique id and parentid turns into a ecs parent id?16:29
hatchfrankban yes the add machine ecs call should generate a uuid for the machine id when it's a 'ghost' machine which others can reference for it's parents16:29
hatchuid? uuid? id? 16:29
rick_h_so ecs adds machine one and gives it and id $@!# and then the second one gets *(U&& and when you add the container the parent is $@!#16:29
hatchd?16:29
hatch?16:29
hatch 16:29
kadams54guihelp https://github.com/juju/juju-gui/pull/294 is a short QA/review16:30
rick_h_kadams54: will look in a sec16:30
hatchrick_h_ were you just swearing a lot there? :P16:30
rick_h_hatch: :P16:30
Makyokadams54, rick_h_  on it - throw reviews my way.16:30
rick_h_Makyo: k16:31
rick_h_Makyo: so is your wip card jc's as well?16:31
rick_h_they can both go to reviwe?16:31
rick_h_review16:31
Makyorick_h_,  I believe the icons-in-tokens work is one branch, so the two have merged.16:32
rick_h_Makyo: k16:32
jcsackettrick_h_: that's correct--i was doing the exact same thing for both tokens so threw my head on it too.16:32
jcsackettrick_h_: checking the "flip" now.16:35
Makyokadams54, +116:37
kadams54Sweet, thanks16:37
kadams54Ah hah… poor Jenkins: http://cl.ly/image/2H0I2N3z1e1916:38
rick_h_heh, scale scale!16:39
kadams54Well then, I'm going to go get lunch. Hopefully I'll have two successfully built branches ready to ship when I get done.16:39
rick_h_jcsackett: :1:'d16:40
jcsackettrick_h_: is that thumbs up?16:40
rick_h_jcsackett: yes16:40
jcsackettrick_h_: flipping works.16:40
rick_h_jcsackett: ok awesome, good to know16:41
rick_h_we'll have to remember that when we get the script going 16:41
* jcsackett nods16:41
kadams54rick_h_: any prefs on what card to tackle next? Looking at the two drag-n-drop ones right now…16:41
rick_h_kadams54: well those need jc's to have tokens to drag/drop16:42
rick_h_kadams54: go grab lunch and we'll organize around seeing tokens and drag/drop when you get back16:42
kadams54OK16:42
jcsacketthm. lunch. there's a good idea.16:42
jcsackettrick_h_: so, last test run failed, make check passes, shall i just :shipit: so kadams54 and others can start work?16:44
rick_h_jcsackett: why did it fail?16:44
rick_h_jcsackett: I see lint issues16:44
jcsackettrick_h_: right, which i fixed in a subsequent push, thus make check is working now. i'm happy to wait for CI to catch the new changes and update.16:45
rick_h_jcsackett: oh, gotcha. Sure 16:45
jcsackett...we just seem to be in a sort of panicy hurry. :p16:45
rick_h_well let's not panic. 16:45
rick_h_but not waste any time :)16:45
* jcsackett laughs16:47
jcsacketta *non-wasteful* hurry, then. :p16:47
Makyojujugui What's a good next card, or does anyone need a second set of eyes?16:54
frankbanMakyo: I am near my EOD, so if you want to continue my work we can have a quick call16:55
rick_h_Makyo: frankban +116:55
hatchMakyo in your ghost relations did you ever run into an error "Charm not loaded" ?16:55
Makyofrankban, sounds good.16:55
frankbanMakyo: cool16:55
Makyohatch, not really, no.16:55
hatchok np16:55
frankbanMakyo: the branch is in https://github.com/frankban/juju-gui/tree/more-ecs-calls .  I am in https://plus.google.com/hangouts/_/calendar/cmljay5oYXJkaW5nQGNhbm9uaWNhbC5jb20.t3m5giuddiv9epub48d9skdaso17:00
jcsackettguihelp: ci is complaining about my branch in a way i cannot reproduce locally. http://ci.jujugui.org:8080/job/juju-gui/933/console17:07
hatchoh that error17:07
hatchjcsackett it's a sauce labs issue17:08
hatchthere is actually some poorly written code somewhere in python land17:09
rick_h_jcsackett: yea, spurious sauce labs issue17:09
rick_h_jcsackett: just kill the "merge request accepted" and let it pick it up again17:09
hatchI traced it down at some point but wasn't sure the proper way to fix it17:09
rick_h_we're hammering on CI and sauce hard today so spurious seems a bit not so spurious today17:10
hatchI wonder if we paid for sauce if we would get better service17:10
hatchor if it's the same for open source vs not17:10
rick_h_possibly for sure17:10
rick_h_jujugui I'm going to go pick up my camper from the dealer and bring it back. I'll be back in a bit. I've given up my card to take one to write out the demo. 17:12
rick_h_jujugui the next things are getting the unplaced tokens and then drag/drop to call the add_machine calls in the env. 17:13
antdillonrick_h_, I'm going to sumbit my branch now17:13
rick_h_antdillon: awesome, kadams54 when you get back from lunch can you look that over, look at possible tests, and qa that ^  please?17:13
rick_h_jujugui if anyone has a question or issue while I'm afk call me 248-956-1024 17:14
hatchso trusting....so so trusting17:14
hatch"for a good time call...."17:14
rick_h_:P17:14
hatchhaha17:14
rick_h_I <3 everyone here :P17:14
hatchMakyo I can't seem to get add_relation to work on comingsoon via the ecs17:17
hatchthis did work at one point right? 17:17
hatchI can probably bisect to find the issue17:17
rick_h_hatch: it does work now. I tested it this morning17:18
hatchon comingsoon?17:18
hatchI drag mysql and wordpress, long click, relate, then click Deploy17:18
hatchthen I get Uncaught TypeError: Cannot read property 'command' of undefined17:18
rick_h_bah, yea something broken just today17:19
hatchpoop17:19
hatchok I'll track this down17:19
rick_h_oh, reloaded and it worked17:19
rick_h_cache/js issue?17:20
rick_h_so just worked for me on comingsoon17:20
rick_h_http://comingsoon.jujucharms.com/:flags:/il/mv/ deploy and all17:20
hatchyeah ok works now17:20
hatchwhat the heck hah17:20
jcastrorick_h_, rails bundles still missing for me on jujucharms.com17:20
hatchok I'll update my branch17:20
rick_h_jcastro: ok17:21
jcastrorick_h_, ok weird17:21
rick_h_jcastro: if you get time try it as a differnet branch vs in the same. something is odd, but we keep working on it and then it shows up17:21
rick_h_jcastro: but we're in pure demo mode through the weekend until Tues so no bandwidth to look until after Tues17:22
jcastroack, I am also in demo mode to make a bundle, lol17:22
rick_h_:)17:22
rick_h_we think there's something with the multiple bundles in a file but can't prove it17:22
* rick_h_ goes afk now for a few17:23
antdillonrick_h_, kadams54 deploy summary branch https://github.com/juju/juju-gui/pull/29517:23
jcastrodoes anyone know how I can deploy a personal branch from the gui to the canvas?17:31
jcastrohttp://manage.jujucharms.com/~michael.nelson/precise/elasticsearch17:31
jcastroI can't find that branch in the gui17:32
hatchjcastro download the charm as a zip?17:35
jcastronm, I had "elastic search" in my terms instead of "elasticsearch"17:35
hatchoh :)17:36
jcastro- _ -17:36
kadams54Back from lunch. Looking at antdillon PR.17:38
kadams54guihelp Anyone else been experiencing flakiness with their icons? I've been seeing stuff like this since mid-sprint: http://cl.ly/image/452g3m461j2M17:43
hatchcan't say I've seen that17:44
jcsackettkadams54: yeah, i don't have that happen.17:45
jcsackettkadams54: local, on jujucharms.com, both?17:45
kadams54local… haven't checked upcoming…17:45
jcsackettkadams54: i would guess than that it's something on your vagrant/host issue.17:45
kadams54Probably17:46
hatchsweet got the bug17:50
hatchkadams54 time to install 14.04 on metal - on your machine there are lots of drivers for it17:50
hatchso you won't run into the same issues I'm having17:51
kadams54I wish JS had string substitution…17:53
hatchit....does?17:54
hatchkadams54 what are you trying to do?17:54
kadams54https://github.com/juju/juju-gui/pull/295/files#diff-e6baa739d19ae967f00d894884a065acR26517:55
hatchso you want to do something like a printf instead?17:55
kadams54In python, I'd handle that like so:17:56
kadams54url = 'https://manage.jujucharms.com/api/3/charm/precise/%s/file/icon.svg'17:56
kadams54single = dict(icon=url % ecs.changeSet[key].command.args[1],17:56
kadams54              name: ecs.changeSet[key].command.args[1])17:56
kadams54Yes17:56
kadams54Much nicer way of inserting vars into long strings17:57
hatchhttp://yuilibrary.com/yui/docs/api/classes/Lang.html#method_sub17:57
hatchit's not quite the same, but close17:58
hatchenough17:58
kadams54Oh sure, there are plenty of libraries that add the capability17:58
kadams54I just wish it was baked in17:58
hatchyeah....js is missing....everything17:59
hatchlol17:59
kadams54I wish python had JS' more flexible lambda function17:59
hatchbut at least the prototypal system is very flexible 18:00
kadams54And I wish JS had python's list comprehensions, string substitutions, and syntactical succinctness18:00
kadams54But they're just never going to hook up and make babies, so all I can do is hang my hopes on ECMAScript 6/7/8 :-)18:01
hatchhaha18:01
hatchmaybe by 2020 it'll be caught up18:01
hatchbut by then Dart will be in all the browsers and people will use it instead.....*snort*18:02
kadams54I'm pretty sure that by 2020 we'll be mired in WW318:02
kadams54After which JS will be everywhere and dead at the same time18:02
hatchyeah you're probably right on that18:03
kadams54No, no… Bernhardt's right.18:03
hatchI don't get the reference18:04
kadams54https://us.pycon.org/2014/schedule/presentation/186/18:05
kadams54Pretty sure you saw the video of this talk?18:05
hatchoh yeah18:05
hatchapparently deploying a service with 0 units is a nono18:14
kadams54Were explosions involved?18:16
hatchnot sure, I walked away, cool guys don't look at explosions 18:18
hatchMakyo you kickin around?18:20
hatchMakyo when you get a chance do you remember what lines 39-45 are for? https://gist.github.com/hatched/cdc73083450dc0eaa02b I've rewritten this callback handler and it doesn't seem like they have any effect...18:21
Makyo1 sec.18:23
hatchyeah no rush18:24
MakyoThe topo retains a list of wrapped services in service_boxes.  The ids of those are the <randomNumber>$ style, so on success, this replaces that object in topo.service_boxes with something the more closely matches what will be received in the delta.  Without it, in a real env, the box would disappear, then reappear on the delta, anything from a flicker to a disappearance.18:26
hatchahh ok cool I'll add a comment to that effect18:30
hatchthx18:30
Makyonp, sorry it wasn't well commented18:30
rick_h_how goes?18:32
rick_h_kadams54: so with ant's branch can you take that over, clean up the items you had questions on and work towards a landing18:34
rick_h_kadams54: file a new card in the on deck land marked high priority for missing tests18:34
rick_h_kadams54: and no not seen the icon issue18:35
* jcsackett hates CI.18:37
jcsackettbut is in a better mood, having finally had lunch.18:37
rick_h_jcsackett: I kicked it for you18:38
jcsackettrick_h_: it looks like there might be another damn merge conflict.18:41
* jcsackett is *never* getting this done.18:41
rick_h_jcsackett: :(18:41
rick_h_almsot there?18:41
rick_h_happy happy18:41
jcsackettyeah, i'm almost there.18:41
jcsacketthating on tools, but almost there.18:42
jcsackettdoes git have other merge patterns? b/c it's dying on *stupid* shit. :p18:42
kadams54rick_h_: Yup, no problem. I'd already started on the tests.18:44
rick_h_crap, I think I left my nice notebook at the grocery store doh18:44
* rick_h_ bangs head on wall18:44
kadams54Notebook on aisle 5, notebook on aisle 5.18:51
jcsackettthat's a fine notebook, dude. my condolences.18:54
jcsackettalso: conflict fixed. let's try this *again*.18:54
rick_h_ yay18:54
jcsackettrick_h_: do i need to :shipit: again?18:54
rick_h_hatch: how goes your branch?18:54
rick_h_jcsackett: no, just remove the "merge accepted" message18:54
rick_h_jcsackett: if that's not there it'll repick it up18:54
hatchrick_h_ done, just need tests for this new setup now18:54
rick_h_hatch: woot18:54
hatcheating lunch now18:55
rick_h_hatch: gotcha, cool thanks. 18:55
hatchthe only downside is that you must deploy a service with a single unit18:55
hatchso I'm doing that part in a follow-up18:55
rick_h_hatch: ok18:55
jcsackettok, i've completely lost mental state.18:55
hatchto make a 'non attached' unit18:55
hatchjcsackett spend too much time in Colorado? 18:55
hatchkehehe18:55
jcsacketti live in the south dude. we kill our brain cells with moonshine, not plants. :p18:56
hatchhaha18:56
rick_h_ok, going to dare to run to the store and hope my notebook is there while I wait for a call :/18:57
rick_h_wish me luck18:57
jcsackettrick_h_: i know you said something about this earlier, but i've lost track. what should i throw myself at, kamikaze like, next?18:57
jcsackettalso: good luck.18:57
* jcsackett waits to see if the question was sent in time...18:57
jcsackettguess not. jujugui, anyone need reviews or something?18:59
hatchnothing here yet18:59
jcsackettblast.19:04
rick_h_jcsackett: ok so next is the unplaced unit tokens19:09
rick_h_frankban had notes in irc easlier on the fix19:09
rick_h_don't look at serviceUnits but just .units and something else19:09
rick_h_and got my notebook back yay!19:10
jcsackettrick_h_: ...while i recognize those as words that relate to machine view, they aren't coming up in a cogent form for me. chat?19:11
rick_h_jcsackett: sure thing19:11
jcsackettrick_h_: https://plus.google.com/hangouts/_/gzrh7sh4g3zbscs42oajucofsia?authuser=2&hl=en19:12
antdillonkadams54, thanks for the review19:14
Makyojujugui Does anyone besides frankban know how the AddMachines API call works?19:33
Makyo(specifically whether or not you can refer to a machine later on in the list of MachineParams, i.e.: [{create machine 1}, {create lxc on machine 1}] in the same API call.)19:35
rick_h_Makyo: I'm not sure on that. Honestly, I'd just try it and see if it blew up or errored. Maybe ping someone in core?19:40
Makyorick_h_, doing that now.19:41
MakyoHave a path forward for the moment, at least.19:41
rick_h_Makyo: cool, looking for the code atm19:41
antdillonkadams54, Added your QA things to the branch20:11
kadams54OK, thanks20:12
antdillonkadams54, Thanks20:12
antdillonrick_h_, the deploy summary only supports deploys and add relations at the moment as it seems to be all the ecs records20:13
kadams54What about the expand icons? Is that in scope, or to be implemented in a different card?20:13
antdillonOh sorry yea, they are placeholder at the moment20:13
kadams54OK, thanks20:13
antdillonkadams54, They jump to much different views20:13
kadams54cool20:14
antdillonAlso click the number of changes in the bottom left doesnt open the small summary20:14
bacping rick_h_20:14
kadams54Yeah, I noticed :-)20:14
antdillonkadams54, Another branch for that stuff, I reckon20:15
Makyorick_h_, got an answer, adding it to our yuidocs20:15
rick_h_bac: pong20:24
rick_h_Makyo: cool20:24
rick_h_antdillon: ok, we're working on getting add machine/container going right now20:24
rick_h_antdillon: so we'll look if we get that working adding or whatever20:24
bacrick_h_: do you have time for a quick update call?20:27
rick_h_bac:  sure thing20:27
bacok, standup20:27
rick_h_bac: can you invite me there please?20:28
rick_h_jcsackett: landed yay20:28
bacrick_h_: let me just call your cell20:31
jcsackettrick_h_: oh hallelujah.20:33
jcsackettrick_h_: so, we're getting unplaced units and generating tokens, but they're not rendering right. this is slightly more involved, but i'll keep digging.20:44
jcsackettwhereever i am by EoD i'll push up so someone else can grab and run if they're working over the weekend.20:44
jcsacketts/rendering right/rendering at all/20:44
hatchrick_h_ https://github.com/juju/juju-gui/pull/292 ok all ready not20:47
hatchnow20:47
hatchyou can now, deploy mysql/wordpress/relate them, click deploy20:47
hatchall without the inspector20:47
hatchrick_h_ are you no longer working on the inspector opening after deploy?20:49
hatchrick_h_ well it appears that my branch has fixed that bug by bypassing that codepath entirely20:50
hatchjcsackett how goes the battle? When is your EOD?20:51
huwshimirick_h_: Just wanted to check in and see how things are going?20:51
hatchhuwshimi well, some of us are going to be picking up some hours this weekend to try and get the board cleared20:52
hatchfor the demo20:52
jcsacketthatch: EoD is at six. battle's is indeterminate. not yet sure why the service icons don't go poof.20:53
jcsacketter, go poof.20:53
hatchjcsackett what's that in UTC? 20:53
hatchtimezones are for suckers20:53
jcsackettuh...22UTC, maybe?20:54
jcsackettshit i dunno. i'm on EST.20:54
rick_h_jcsackett: yea push and I can look20:54
hatchok in an hour then20:54
hatch:)20:54
rick_h_hatch: will check it out20:54
rick_h_hatch: jcsackett yea, please push your stuff, with good notes in the pull requests20:54
rick_h_it's time for me to take the camper to the campground (actuall 3hrs late)20:55
rick_h_once we get setup I'll go through stuff tonight20:55
rick_h_so will be afk for a few hours driving and setting up the trailer20:55
rick_h_thanks!20:55
* rick_h_ runs away20:55
hatchcya20:55
bacredir: you around?20:57
redirbac: yep20:58
bacredir: i was having a mapping format exception issue with ES.  but now it looks like it may be working!20:59
redirbac: not for much longer. we have out of town guests coming for a dinner party this eve20:59
bacohh, a dinner party!  will you be serving negronis?20:59
* redir blinks20:59
redirheh20:59
jcsackettoh ho, someone didn't put `this` into a loops scope.20:59
jcsacketthuzzah, this may be easy.20:59
redirthey don't drink20:59
bacmore negronis for you then21:00
* bac cannot stand camparai21:00
* bac cannot spell campari21:00
bacsweet, i just ingested a directory full of local charms.21:00
huwshimihatch: That card you just picked up, how do you get a unit in the unplaced column?21:06
hatchatm, you don't21:06
hatchjcsackett is working on that right now21:06
huwshimiAh21:07
hatchyou can create unplaced units not but I'm pretty sure they don't show up in the UI yet21:07
hatchI'm just going to make the headers drop targets21:07
huwshimihatch: In the header widget I've added the drop state to the headers (just the styling at this point)21:08
huwshimihatch: So you can do .setDroppable and it will switch to the correct state.21:09
jcsacketthatch, huwshimi: to be clear, i'm just making sure they render in the UI.21:09
jcsacketti'm doing nothing about placement etc into that unplaced thing.21:09
jcsacketti'm about to push it up for PR, just doing some CSS tweaks now.21:09
hatchjcsackett when you're done, unplaced units will be listed in the first column through right?21:09
redirbac: you have local demo all tidy?21:09
bacit looks pretty tidy21:10
bacredir: you can play with it if you're intersted21:10
hatchin your PR can you include the commands/process to get the units to show up there plz 21:10
hatch^ jcsackett 21:10
hatchhuwshimi I see, thanks21:10
huwshimihatch: Also, on the scale up UI, it seems that the form should close when you click "add units"21:10
hatchPR's accepted21:11
jcsacketthatch: planning on it.21:11
hatch.....lol21:11
hatchjcsackett thanks21:11
bacredir: it is at ~bac/charmworld/ingest-local-charms21:11
bacer, lp:~bac/charmworld/ingest-local-charms21:11
kadams54Taking a break for family stuff. Will be back on after the kids are in bed tonight. Planning on landing ant's deployed changes summary panel work at that time.21:11
bacredir: i simply introduced a new cmd-line option to ingest-queued:  --local-repo=<path>21:12
* Makyo -> dogwalk21:14
redirbac I'll try it monday21:14
redirI'll need to get a directory of charms from somewhere though21:15
bacredir: 'charm-tools get'.  that may be more than you want...21:20
* bac walks dog21:20
jcsacketthatch: take a look at https://github.com/juju/juju-gui/pull/296 ?21:20
hatchjcsackett on it21:21
redirbac: I have charm-tools which gives me charm-get, is that what you mean?21:22
redirand download them one at a time/21:23
* redir goes to start making dinner RSN21:23
hatchjcsackett it doesn't work21:26
jcsackettzuh?21:26
hatchwhen I run the cli command the inspector shows that there are more units21:26
hatchbut there are none in the unplaced units column21:26
hatchI have to close/open it21:27
jcsackettright, _renderServiceUnit only executes when the machineviewpanel is first rendered.21:27
hatchor is that what branch was supposed to accomplish?21:27
jcsackettthat's all this does.21:27
hatchohh ok21:27
jcsackettjust gets the _render thing to work as it is now.21:27
jcsackettthere are still bugs.21:27
hatchcan you create a card for the databdinging units list21:27
hatchplz21:27
jcsackettsure.21:27
hatchthanks21:27
hatchlooks like we'll need some styling on it too21:28
hatchit being the unit tokens21:28
huwshimijcsackett: Feel free to give me a card to style them.21:28
jcsacketthuwshimi: okay.21:29
hatchhuwshimi it will be a bit, I need to do the review and then it needs to land, just fyi21:29
hatchjcsackett how come there are no tests? 21:29
hatchare they coming?21:30
jcsacketthatch: b/c all i did was update existing code.21:30
jcsackettand yeah, i'm adding high priority on deck cards.21:30
huwshimijcsackett: No problems. I'll have my Monday while you guys are sleeping too.21:30
hatchthat's a little creepy 21:31
hatchlol21:31
hatchjcsackett so are there no tests for this functionality then?21:32
jcsacketthatch: only what tests were there before, and i can't imagine they were very good.21:33
jcsacketthatch: i can try to get tests in the next 30 min, but we don't have much setup in the way of isolation for these bits right now.21:34
jcsackettnot sure i'll get anywhere.21:34
hatchjcsackett see test_machine_view_panel.js21:34
hatchlots of tests there21:35
jcsacketthatch: yeah, i just realized i was running make test-debug on develop, which is why everything passed. :p21:35
hatchhaha21:36
hatchI have it a +1 so once tests pass and there are new ones it can be landed21:36
hatchif you don't get all the way finished I can take over21:36
jcsacketthatch: do our tests not use our css in the less files?21:44
hatchnop21:44
hatchwell21:44
hatchthat's a lie21:45
hatchunless the module loads it in itself21:45
hatchit's not there21:45
jcsackettah. how does the module load it?21:45
hatchI don't think any do21:45
jcsacketthm.21:45
hatchnot anymore anyways21:45
hatchwhat did you need the css for?21:46
hatchshould be functional without?21:46
jcsackettthere's some stuff in the serviceunit token that had style="display: none" in the html, which i moved into the css.21:46
jcsackettbut there are tests making sure those bits don't start out visible.21:46
jcsackett...should that whole block just start with the hidden class, come to think of it?21:46
jcsackettor is that only display: none by default for actual YUI widgets?21:47
huwshimijcsackett: It might be fine to just check the css class is applied21:47
huwshimi(without knowing if that css applies the display: none)21:47
jcsacketthuwshimi: eh, i guess. but just checking "class=details" seems like an unnecessary test.21:48
hatchall we got, until we start doing real renderings in the tests21:48
jcsacketthatch: can you call "show" and "hide" on arbitrary nodes?21:49
hatchif they are Y.Node instances yes  - http://yuilibrary.com/yui/docs/api/classes/Node.html#method_show21:49
jcsacketthatch: and that just applies ".hidden" right, or does that actually set the style?21:50
hatchboth I think - sec21:51
hatchhttp://yuilibrary.com/yui/docs/api/files/node_js_node-view.js.html#l3421:51
hatchadds a hidden attribute21:51
hatchand sets the style on the element21:51
jcsackettyeah, i just found it too.21:51
jcsackettok, so i'll update the "style=None" to start with .hidden class and check for that in tests.21:52
hatchso confused21:53
hatchI'll take your word on it 21:53
jcsacketthatch: it'll make sense when you see the updated PR.22:12
hatchoh kay!22:12
jcsacketthatch: i've pushed to the PR--the test isn't actually passing yet, but i'm going to have to let you run with it.22:13
jcsacketti've got to EoD and get to a dinner.22:13
hatchsure np22:14
hatchenjoy22:14
jcsackettthanks.22:14
jcsacketthave a good weekend, all.22:14
rick_h_howdy23:56
rick_h_from the campground23:56
rick_h_4g in the wood yay23:56
rick_h_woodsd23:56
rick_h_woods23:56
rick_h_hatch: so you're running with jc's branch on the test side?23:58
hatchyeah, just doing some house stuff now23:59
hatchwill try and get it in and landed tonight23:59
rick_h_hatch: ok cool, going back to your branch now23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!