| Elleo | kenvandine: haven't seen that before, will have a poke at it tomorrow and see if I can reproduce it | 00:12 |
|---|---|---|
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| === chihchun_afk is now known as chihchun | ||
| boren | Can anyone do apt-get update on Touch? | 04:38 |
| zsombi | nik90: ping | 05:34 |
| zsombi | nik90: here's the layouts visibility related bug fix: https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/layouts-visibility/+merge/218916 | 05:59 |
| zsombi | nik90: pls have a test round with it | 05:59 |
| Aki-Thinkpad | Morning almost all | 05:59 |
| dholbach | good morning | 06:47 |
| justCarakas | Good morning | 07:11 |
| popey | zbenjamin: you about? I'd love to figure out why I get this when I open qtc and start a brand new project.. paste.ubuntu.com/7420112/ | 07:47 |
| popey | the bit at the top happens when I open qtc | 07:47 |
| dpm | popey, I had a problem with the chroot a couple of days ago. I can't help with the rest of errors, but running the chroot command at the top gave me more context as to why it was failing (missing python3 installation in my case), perhaps that might help? | 07:49 |
| popey | dpm: which command? | 07:50 |
| popey | the schroot one? | 07:50 |
| dpm | popey, the one on line 4 | 07:50 |
| dpm | yes | 07:50 |
| popey | it just echos the lines 1-3 to me | 07:51 |
| dpm | actually, on line 2 it seems you've got a stale chroot? | 07:51 |
| dpm | or a stale chroot session | 07:51 |
| popey | stale as in not updated? | 07:54 |
| popey | i have a build target in qtc | 07:54 |
| * popey presses "update" | 07:54 | |
| zbenjamin | popey: check your mount output, is the chroot still shown as mounted? | 07:54 |
| popey | http://paste.ubuntu.com/7420150/ doesnt look like it | 07:55 |
| zbenjamin | popey: weird, did you delete and recreate the chroot when you had that error before? | 07:55 |
| popey | i deleted them, yes. | 07:56 |
| popey | re-created a click target in qtc yesterday | 07:56 |
| popey | ahhh, overlayfs is a kernel thing.. right? | 07:57 |
| popey | I am running an upstream kernel, not an ubuntu kernel | 07:57 |
| popey | due to intel video driver being made out of grass-cuttings and dogshit. | 07:57 |
| * popey reboots back to an ubuntu kernel to see if that makes a difference, guess we have patches that I am not using right now. | 07:58 | |
| zbenjamin | popey: that could be+ | 07:58 |
| JamesTait | Good morning all; happy Friday, and happy Lost Sock Memorial Day! :-D | 08:02 |
| popey | well.. that was a lesson learned! | 08:02 |
| popey | rebooted into ubuntu kernel and started sdk, now I get this zbenjamin /usr/share/qtcreator/ubuntu/scripts/qtc_chroot_cmake2: line 19: CLICK_SDK_ARCH: Need to set CLICK_SDK_ARCH non-empty | 08:02 |
| popey | which is certainly good progress! | 08:03 |
| zbenjamin | popey: that one can be ignored | 08:03 |
| popey | \o/ | 08:03 |
| zbenjamin | popey: its somewhere in the initialization process where QtC seems to miss a env var. I need to investigate more but it still works so its a minor issue | 08:06 |
| popey | ok | 08:06 |
| popey | zbenjamin: ok, how about all this gubbins when I create a project? paste.ubuntu.com/7420207/ | 08:14 |
| zbenjamin | popey: thats qmlplugindump. Its not from us | 08:14 |
| zbenjamin | popey: thats the process that tries to read information from shared libraries so they can be used in the qml sourcecode completion and highlighting | 08:15 |
| zbenjamin | popey: for example if you register a new type from a qml c++ plugin, qmlplugindump will read the informations and tell the QtC editor the types and properties exported by a shlib | 08:16 |
| popey | seems its looking for a file that doesn't exist | 08:17 |
| popey | /usr/lib/x86_64-linux-gnu/qt5/qml/CordovaUbuntu.2.8/typelist.qml doesn't exist on my system | 08:17 |
| popey | /usr/lib/x86_64-linux-gnu/qt5/qml/CordovaUbuntu.2.8 does | 08:17 |
| popey | zbenjamin: managed to build my app and run on device, so it all seems to be working now, thank you! | 08:20 |
| zbenjamin | popey: np | 08:20 |
| justCarakas | JamesTait: nice followup greeting :p | 08:29 |
| JamesTait | justCarakas, I thought so! ;) | 08:31 |
| dpm | morning oSoMoN_ - we're using UbuntuWebView in the Reminders app to display HTML from Evernote (well, it's their own XHTML format called ENML). One thing I've noticed is that the standard font sizes are tiny when we load the notes. Here's an example: http://i.imgur.com/114l3Oj.png - so if I create a note on the web at sandbox.evernote.com, the default size is 11. When I load that note in Reminders, it's not very readable, as it's really small | 08:35 |
| dpm | how do you deal with this in UbuntuWebView? Can e.g. a scaling factor be applied for display? | 08:36 |
| oSoMoN_ | dpm, we discussed this yesterday with mzanetti and rpadovani, there is a way to set the default font size on a webview using the preferences | 08:36 |
| oSoMoN_ | dpm, it might not fully work with the qtwebkit-based webview, but it definitely does with the new one based on oxide | 08:36 |
| dpm | oSoMoN_, ah, cool how does this override the sizes set in the original document? | 08:37 |
| dpm | i.e. if I've got a mixture of sizes in my original doc | 08:37 |
| oSoMoN_ | dpm, it won’t, that’s the default size for when no size is explicitly specified | 08:37 |
| dpm | oh, I see | 08:37 |
| oSoMoN_ | dpm, note that if you switch to the new webview based on oxide, I believe the default zoom factor is larger, and it may automatically fix the issue you’re seeing without the need for any explicit setting | 08:38 |
| dpm | awesome! | 08:39 |
| === oSoMoN_ is now known as oSoMoN | ||
| dpm | oSoMoN, so what's needed for the switch? Do we need any particular dependencies? I.e. will it work in trusty or does it have to be utopic? | 08:39 |
| dpm | it'd be nice for it to work in trusty, so that we can test it on the desktop too while developing | 08:40 |
| oSoMoN | dpm, it will work in trusty, (almost) all you need to do is change the import of Ubuntu.Components.Extras.Browser from 0.1 to 0.2 (and you may need a few minor adaptations depending of how much you rely on QtWebKit specifics) | 08:42 |
| dpm | oSoMoN, IIRC, we don't do much with it other than displaying the notes, I don't think we rely on any webkit specifics | 08:43 |
| oSoMoN | excellent, so trying it will only be a matter of updating the version on the import line | 08:43 |
| dpm | I'll give it a go | 08:43 |
| oSoMoN | dpm, where can I check out the code of the app, out of curiosity? | 08:44 |
| dpm | oSoMoN, lp:reminders-app - any feedback/MPs to improve how we display the notes with UbuntuWebView welcome :) | 08:44 |
| dpm | oSoMoN_, is there a setting for font family that works equally the same as the default size? I.e. can I set the font to be 'Ubuntu' by default and it will be used for display if no font is specified? | 08:45 |
| dpm | that'd be essentially the MP rpadovani sent yesterday, I just want to understand whether it does that already ^ | 08:45 |
| oSoMoN | dpm, yes, I also explained rpadovani and mzanetti how to do that yesterday | 08:49 |
| dpm | excellent, thanks! | 08:50 |
| === hunger_ is now known as hunger | ||
| dpm | rpadovani, mzanetti, I believe the new design looks good enough to land. This will give us something to test and iterate on small polish details. What do you think? Is there anything big that still needs looking at before you're comfortable with landing it? | 08:54 |
| mzanetti | dpm: once you've approved the new-reminders-design branch (I'm a bit lost with the initial offset) we need to do a test of the whole new-design branch. | 08:54 |
| mzanetti | dpm: if happy with it, we're good to go | 08:55 |
| mzanetti | dpm: I don't think anything big is still missing | 08:55 |
| dpm | mzanetti, yeah, I saw your comment on the MP, that's what prompted me to give it a go. If the offset is a Qt issue, I wouldn't want the whole new design to block on it | 08:56 |
| dpm | so let me approve the reminders branch | 08:56 |
| mzanetti | dpm: well, I haven't really tracked it down so I'm not 100% sure its an issue in qt. but given that my code doesn't do any positioning really, I suspect that | 08:56 |
| dpm | ok | 08:57 |
| dpm | mzanetti, ok, top-approved | 08:59 |
| mzanetti | dpm: ok... I'll merge it | 08:59 |
| dpm | mzanetti, while you're at manually merging, would you mind having a look at https://code.launchpad.net/~rpadovani/reminders-app/little-fixes-new-design/+merge/218856 and merging it too if you think everything's ok? | 09:00 |
| mzanetti | ok | 09:00 |
| dpm | mzanetti, thanks. Shall we set https://code.launchpad.net/~reminders-app-dev/reminders-app/new-design/+merge/218341 as "Needs review" as the next step? | 09:11 |
| mzanetti | dpm: yes | 09:11 |
| dpm | \o/ | 09:11 |
| dpm | mzanetti, also a quick heads up that qtdeclarative5-quicklayouts-plugin is already on a promoted image (#17) | 09:13 |
| mzanetti | dpm: awesome :D | 09:13 |
| dpm | so pending review, there's nothing else blocking this for landing :) | 09:13 |
| dpm | mzanetti, I think once that's landed, the next steps will be polish, and the next big feature requests will be RTF and tags. I remember we discussed RTF a while ago and we left it for later. Was it because of any particular blocker, or just because it was a non-trivial job and there were other more important things to do? | 09:17 |
| mzanetti | dpm: the latter | 09:18 |
| dpm | ok, glad to hear that, thanks :) | 09:18 |
| mzanetti | dpm: just found out that if I don't set the size on the delegates, the issue isn't happening :/ | 09:18 |
| mzanetti | the one with the offset | 09:19 |
| mzanetti | obviously we need to set the size to follow the design | 09:19 |
| dpm | hm | 09:19 |
| mzanetti | dpm: even weirder: if i don't set the size its fine, if I set it to 6 gus, which is the same as the default, it happens again | 09:22 |
| dpm | weird | 09:23 |
| dpm | mzanetti, another quick question: I noticed that the new refresh action works well and refreshes the list of notes. But it doesn't refresh their content. Is there a way, when I click on a note to view it, to check if there have been changes done externally and load it if there have been? So I'm trying to see if there is a compromise between refreshing the note upon each load of the page and using the cached version | 09:24 |
| dpm | I'm guessing we don't want just the content of _all_ notes to be refreshed when we press the refresh button, as that might take a while with a long list of notes? | 09:25 |
| mzanetti | dpm: the note content is refreshed each time a note is scrolled into the view and also when its opened | 09:25 |
| mzanetti | dpm: I think thats fine | 09:26 |
| dpm | mzanetti, it's not refreshed when it's opened, I just noticed that | 09:26 |
| mzanetti | dpm: err. no. its not refreshed when scrolled into view. only if the content was empty | 09:26 |
| mzanetti | dpm: huh... I'm sure it was at some point. let me check | 09:26 |
| mzanetti | dpm: right... its only refreshed if it was empty too | 09:27 |
| mzanetti | dpm: I guess we should refresh it each time we open it | 09:27 |
| mzanetti | dpm: I'll propose a branch for it | 09:27 |
| dpm | mzanetti, yeah, but that would decrease responsiveness if we load the note every time. I'm wondering if we can check the last modified date and only load it if it differs | 09:28 |
| mzanetti | let me see | 09:28 |
| dpm | cool, thanks | 09:28 |
| mzanetti | dpm: not really... There is a timestamp propoerty in the note.. so I could do a fetchNote(), then compare if the timestamp matches and if not, do a fetchNoteContent() | 09:30 |
| mzanetti | dpm: however, I'm not sure if thats any better than directly refreshing the content | 09:31 |
| mzanetti | it would be better for notes with like a full MB of text... but that's a really rare case I think | 09:31 |
| mzanetti | for small notes with just a few words It would make it a little worse actually | 09:31 |
| dpm | mzanetti, I don't know. Having notes with images might well be a common case | 09:31 |
| mzanetti | dpm: no... we don't refresh the images when refreshing the content | 09:32 |
| dpm | ah, ok | 09:32 |
| nik90 | t1mp: ping | 09:32 |
| mzanetti | dpm: all notes are always refreshed without images (and other attachments). | 09:32 |
| nik90 | Good morning everyone | 09:32 |
| mzanetti | dpm: when we see an incoming note that has a new attachment we haven't cached yet, we'll fetch the note again including resources | 09:33 |
| t1mp | nik90: hi | 09:33 |
| nik90 | t1mp: the new tab header icon ...is it possible to change the color? | 09:33 |
| nik90 | t1mp: the grey color looks weird on the clock app..let me share a screenshot | 09:33 |
| nik90 | t1mp: https://imgur.com/0CEhXUh | 09:34 |
| dpm | mzanetti, that sounds good. So we'd just refresh the content (but not attachments) always when we open a note to view it, correct? | 09:34 |
| mzanetti | dpm: yes | 09:34 |
| t1mp | nik90: there is no property for the apps to change it | 09:35 |
| t1mp | nik90: the header text automatically has the right color? I guess using that color would work | 09:35 |
| t1mp | nik90: can you create a bug for that, and also add it to the ubuntu-ui-toolkit and ubuntu-ux projects? I'll discuss the correct coloring with a designer then | 09:36 |
| nik90 | t1mp: indeed..it should take the color of the header text at least ...which would be white | 09:36 |
| nik90 | t1mp: sure..will do | 09:36 |
| dpm | mzanetti, sounds great to me. I'm wondering if we should also then add a refresh button on a single note view that refreshes the cached attachments too. This way we'd allow the user to refresh the attachments too on demand, without sacrificing overall responsiveness. Otherwise, there wouldn't be a way for users to refresh their images other than restarting the app. What do you think? | 09:36 |
| mzanetti | dpm: if an image changes it gets a new hash and won't match our cached version any more | 09:37 |
| mzanetti | so it'll be automatically refreshed when the note refreshes | 09:37 |
| dpm | mzanetti, but you said that we're not refreshing attachments? | 09:37 |
| mzanetti | dpm: I said that if we get a note update and find an attachment in there which we haven't cached, we'll update that | 09:38 |
| mzanetti | dpm: a changed image is the same as a deleted image and a new image | 09:38 |
| dpm | aha | 09:38 |
| dpm | gotcha, that sounds quite good | 09:39 |
| nik90 | t1mp: https://bugs.launchpad.net/ubuntu-ux/+bug/1317816 | 09:39 |
| nik90 | zsombi: testing your branch now | 09:39 |
| t1mp | nik90: thanks | 09:41 |
| dpm | mzanetti, ok, filed https://bugs.launchpad.net/reminders-app/+bug/1317819 for that, let me know if it contains enough info | 09:43 |
| dpm | popey, would you happen to know who to poke to bring the bug bot back to life in this channel? | 09:44 |
| === chriadam is now known as chriadam|away | ||
| mzanetti | dpm: https://code.launchpad.net/~mzanetti/reminders-app/refresh-note-on-view/+merge/218951 | 09:51 |
| nik90 | zsombi: hey so on testing your layout branch, the visibility issue is fixed (yay)...however I noticed that when switching from a conditional layout to the default layout, the elements in the default layout are no positioned in the same order they were as defined in the code. | 09:55 |
| zsombi | nik90: ok, so the parenting order is not the same... | 09:56 |
| nik90 | zsombi: yup | 09:56 |
| zsombi | nik90: good. beside that, could you also check this? https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1298886 | 09:56 |
| zsombi | nik90: I mean the fix branch for that... | 09:57 |
| nik90 | zsombi: sure | 09:57 |
| zsombi | nik90: I'll check what can I do about the children order | 09:57 |
| nik90 | ok | 09:57 |
| popey | dpm: yes | 10:00 |
| nik90 | zsombi: This issue seems to be fixed as well with your MP. I tested it on the sample code I attached in the bug report | 10:07 |
| zsombi | nik90: me too, just wanted to know whether you can see the same as me ;) | 10:07 |
| nik90 | zsombi: :) | 10:07 |
| zsombi | nik90: so, the only thing is to restore the children order | 10:08 |
| zsombi | nik90: and that's a bit tricky, but doable | 10:08 |
| nik90 | zsombi: yup | 10:08 |
| nik90 | zsombi: yay I can now finish flashback's convergence to tablet | 10:08 |
| zsombi | nik90: as the time an item is restored to its original parent, its former neighbors may still not be restored yet | 10:09 |
| zsombi | nik90 :) | 10:09 |
| nik90 | t1mp: erm I found a bug with pagestacks. this is also reproducible on the phone and may be causing the clock app AP tests to fail. | 10:14 |
| nik90 | t1mp: with the old headers, in the clock app, when I go to the add alarm page by pushing a page into the pagestack, when I press back it does not return to the original Alarm tab. But instead it returns to the clock tab | 10:15 |
| nik90 | t1mp: so Clock Tab -> Alarm Tab -> Push Page to go into Add Alarm Page -> Press Back Button -> Returns to the Clock Tab | 10:15 |
| nik90 | t1mp: this bug is not happening with the new headers | 10:15 |
| nik90 | zsombi: In the Alarms API, it is mentioned that the sound property takes a url. Is this the file path to the ringtone? | 10:24 |
| zsombi | nik90: that supposed to be, however that particular field has not been agreed 100% yet... we should check with renato/charles on what attachments can be stored there | 10:26 |
| nik90 | zsombi: ok..I just talked to popey about this. I will be adding a ringtones field in the add alarm page so that a user can choose a ringtone per alarm if he wants to | 10:28 |
| zsombi | nik90: good. if you see something not working, then we should rise a bug against the whole chain | 10:29 |
| nik90 | zsombi: I will check with renato/charles in the evening about this. So as of now, the SDK expects a file path url. I will see what charles/renato expects there | 10:29 |
| zsombi | nik90: the SDK does not expect anything, it passes whatever it gets to QtOrganizer | 10:30 |
| nik90 | zsombi: ah ok | 10:30 |
| t1mp | nik90: is it this bug? https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1316736 | 10:32 |
| nik90 | t1mp: yup that's the bug | 10:32 |
| nik90 | t1mp: can we raise its priority since it is causing all my alarms tests to fail essentially blocking code merges | 10:33 |
| t1mp | nik90: I didn't realize that it happens with the old tabs only.. that's a regression | 10:33 |
| t1mp | yes | 10:33 |
| nik90 | thnx | 10:33 |
| mihir | popey: my almost all branches are about to merge | 10:36 |
| mihir | popey: just left with kunal's input on last limit functionality , rest are done. | 10:36 |
| mihir | will pick any high priority bug and will work on that stuff now. | 10:36 |
| popey | mihir: great news! | 10:42 |
| === chihchun is now known as chihchun_afk | ||
| Mirv | popey: I don't know if you've been in discussions with the developer who had the keymap problem, but earlier this I copied the fix also to trusty SDK PPA users (already in utopic) | 11:20 |
| Mirv | this week | 11:20 |
| t1mp | nik90: are you still around? | 11:22 |
| nik90 | t1mp: yeah | 11:22 |
| popey | Mirv: I dont recall who that was | 11:23 |
| t1mp | nik90: I have a branch that I believe fixes the pagestack/tabs bug :) I'm creating an MR now | 11:23 |
| nik90 | t1mp: nice. I will test it once I have the MR link | 11:24 |
| t1mp | nik90: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/popToTabs/+merge/218971 | 11:24 |
| t1mp | mhall119: ^ that fixes https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1316736 | 11:26 |
| nik90 | t1mp: yup that fixes the issue | 11:31 |
| t1mp | hurray :) | 11:32 |
| nik90 | t1mp: btw, the tab drawer..sometimes it says 4 tabs underneath the icon, and sometimes it doesn't. | 11:32 |
| t1mp | kalikiana_: do you have time for a review? https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/popToTabs/+merge/218971 | 11:32 |
| nik90 | t1mp: When is it supposed to show the text and vice versa? | 11:32 |
| t1mp | nik90: the initial version had text, but in newer versions where you also have actions in the header, I removed the text because it looked too cluttered | 11:32 |
| ahayzen | zsombi, ping | 11:33 |
| nik90 | t1mp: ah ok..looks much better without the text | 11:33 |
| zsombi | ahayzen: pong | 11:33 |
| t1mp | nik90: I still need to find a designer to discuss the final looks with, but for the moment I just tweaked it the way I thought looks better | 11:33 |
| ahayzen | zsombi, when you get a moment could you have a look at this MP, Tim said you would likely be best for review as you have been doing alot with events and wrote the InverseMouseArea, thanks. https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-1315775/+merge/218206 | 11:33 |
| nik90 | t1mp: https://imgur.com/HVBoKWp | 11:33 |
| t1mp | nik90: yeah, until I get official designs it will simply look the way I like it :) | 11:33 |
| nik90 | t1mp: heheh...we got the POWER! | 11:34 |
| t1mp | :) | 11:34 |
| t1mp | nik90: for now... ;) | 11:34 |
| kalikiana_ | t1mp: not really right now, preferrably pass it to somebody else | 11:34 |
| zsombi | ahayzen: ah, nice catch!!! | 11:35 |
| t1mp | kalikiana_: okay | 11:35 |
| t1mp | zsombi: can you review this? https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/popToTabs/+merge/218971 it fixes a regression | 11:35 |
| ahayzen | zsombi, thanks :) | 11:36 |
| t1mp | nik90: ^ probably it helps if you comment there that you tested and it works :) | 11:36 |
| nik90 | t1mp: sure | 11:36 |
| zsombi | t1mp: ahayzen: we ned to run CI on the https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-1315775/+merge/218206 | 11:37 |
| ahayzen | zsombi, i don't have permission to run that right? | 11:39 |
| zsombi | ahayzen, no, I already asked for it in #ubuntu-ci-eng | 11:39 |
| ahayzen | zsombi, cool thanks :) | 11:39 |
| zsombi | t1mp: I'm in the middle of some heavy Layouts change, I'll get that MR reviewed once I'm done with that... and that may not be this week, so if you need it faster, pls go ask Kaleo | 11:41 |
| t1mp | zsombi: ok | 11:56 |
| zsombi | t1mp: thx | 11:57 |
| === _salem is now known as salem_ | ||
| rpadovani | dpm, mzanetti some beatiful news this morning :-) | 12:10 |
| mzanetti | rpadovani: which is? | 12:10 |
| rpadovani | mzanetti, that new design is ready :-) | 12:11 |
| mzanetti | ah, yeah :) | 12:11 |
| mzanetti | rpadovani: well done btw | 12:11 |
| rpadovani | mzanetti, thanks, you too :-) | 12:12 |
| mzanetti | rpadovani: regarding the gradient: I think its smoother if you make it from 0 to 1 instead of 0.9 to 1 | 12:12 |
| rpadovani | mzanetti, so I need two rectangle, one with rotation of 90 and one with rotation of 270? | 12:12 |
| mzanetti | rpadovani: yeah | 12:14 |
| rpadovani | mzanetti, isn't too expensive for phone hardware? | 12:15 |
| mzanetti | rpadovani: should be ok still... but you're right... always try to keep items in delegates to a minimum | 12:16 |
| mzanetti | rpadovani: but that one added gradient shouldn't make it much worse | 12:16 |
| rpadovani | mzanetti, k, I'll do some test in next hours | 12:16 |
| dpm | rpadovani, indeed, I think we should be able to land it today, what do you think? I'd like to do a bit of dogfooding, but overall it looks and feels great! | 12:19 |
| rpadovani | dpm, I think is ready, some little details (like gradient in image) aren't perfect yet, but we can fix them after the land :-) | 12:21 |
| dpm | indeed, that's the idea, this is the initial iteration, and we can do polish later | 12:21 |
| dpm | I'd also like to have it in the store for Lucas to test it and give us his feedback | 12:21 |
| rpadovani | sounds good to me | 12:24 |
| === jhodapp|afk is now known as jhodapp | ||
| popey | dpm: if you want me to trigger a click package on jenkins, just say, and I'll test locally then ask balloons to upload to the store | 12:33 |
| dpm | awesome, thanks popey. Right now Jenkins is failing for an unknown reason on Reminders, I've been waiting for a vanguard to be on -ci-eng to poke someone about it | 12:34 |
| nik90 | popey: btw, with the switch to the new framework, we are deciding to no longer trusty? I am asking since then the switch to the new tab headers wouldn't need any backwards compatibility code | 12:39 |
| nik90 | support trusty* | 12:39 |
| popey | nik90: it would be good if we could support trusty so the desktop ppa works | 12:43 |
| nik90 | popey: no I meant on the phone | 12:43 |
| popey | on phone, no | 12:44 |
| nik90 | popey: on the desktop, things will work as long as the user has the SDK PPA added | 12:44 |
| === randomcpp_ is now known as gcollura_ | ||
| === jhodapp is now known as jhodapp|brb | ||
| mzanetti | dpm: fixed | 13:03 |
| mzanetti | mhall119: hey, tagger should now work again. thanks again for letting me know | 13:04 |
| dpm | man, you guys are quick! | 13:04 |
| rpadovani | dpm, https://code.launchpad.net/~rpadovani/reminders-app/1316950/+merge/218829/comments/522046 | 13:06 |
| rpadovani | what's the problem? | 13:06 |
| nik90 | t1mp: What is the recommended method to hide a toolbar button? Currently I am setting the visibility property of a toolbar button to false to hide it. However that doesn't seem to work with the new headers. Regression or am I doing it wrong? | 13:06 |
| dpm | rpadovani, I don't know, I asked on #ubuntu-ci-eng a few minutes ago, they're looking into it | 13:06 |
| mzanetti | dpm: its really taking shape now :) | 13:06 |
| === jhodapp|brb is now known as jhodapp | ||
| dpm | mzanetti, indeed, I've now got a bunch of notes with images from testing, and it looks like it's scaling well (and looking awesome) for something that's closer to daily use | 13:07 |
| rpadovani | dpm, thanks! | 13:08 |
| renato | dpm, could you help me reviewing this MR: https://code.launchpad.net/~renatofilho/sync-monitor/i18n/+merge/215943 | 13:09 |
| dpm | renato, sure, give me a few minutes and I can review | 13:09 |
| renato | thanks | 13:09 |
| dpm | rpadovani, the job on your MP is running now, we should have a new Jenkins result, hopefully positive :) soon | 13:12 |
| rpadovani | \o/ | 13:12 |
| t1mp | nik90: it doesn't work at the moment | 13:15 |
| t1mp | nik90: it should be Action.visible, see https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1316631 | 13:15 |
| nik90 | t1mp: but when I use Action.visible, it says that "Action.visible is a DEPRECATED property. Use ActionItems to specify the representation of an Action." | 13:15 |
| nik90 | which is what made me concerned about using it | 13:15 |
| === randomcpp_ is now known as gcollura_ | ||
| t1mp | nik90: right. I added that as a point to be included in the Header API discussion https://docs.google.com/a/canonical.com/document/d/1wUUKtPmRmwbUELC1BUB9l0VOAwS_zAPRSCqMopUxR1c/edit# | 13:17 |
| t1mp | nik90: at the moment I don't see another way than to start using Action.visible again.. | 13:18 |
| nik90 | t1mp: ok | 13:18 |
| nik90 | t1mp: I also noticed that if there is only 1 toolbar visible and then other 2 toolbar actions are hidden, it still shows a arrow just for one toolbar button | 13:19 |
| t1mp | nik90: huh? how did you make the other 2 hidden? | 13:21 |
| nik90 | t1mp: using Action.visible | 13:22 |
| nik90 | t1mp: https://imgur.com/2K5iTjQ | 13:22 |
| t1mp | nik90: ah yes | 13:24 |
| t1mp | nik90: that's part of the bug. I'll work on that after I finish some other header improvements | 13:24 |
| nik90 | t1mp: ok | 13:25 |
| t1mp | nik90: it will work correctly when the header is done. It is still work in progress now | 13:25 |
| nik90 | t1mp: np, I am just getting the clock app transition branch ready..I will wait for the header to be ready before merging | 13:26 |
| t1mp | nik90: but keep reporting issues that you find. That's very useful :) | 13:26 |
| nik90 | :) | 13:26 |
| dpm | renato, reviewed your MP. You might want to ask mhr3 or dobey too, who recently enabled i18n with CMake + C++ in scopes | 13:30 |
| === oSoMoN__ is now known as oSoMoN | ||
| dpm | mzanetti, approved the refresh notes MP | 13:30 |
| mzanetti | dpm: merged | 13:31 |
| dpm | \o/ | 13:31 |
| mzanetti | dpm: please give the whole new-design branch another test. | 13:31 |
| mzanetti | if happy, lets merge it | 13:32 |
| dpm | mzanetti, yes, that was my plan | 13:32 |
| mzanetti | otherwise let me know what to fix | 13:32 |
| dpm | cool | 13:32 |
| t1mp | artmello: I marked https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1317713 as a duplicate of a bug that I just fixed, | 13:34 |
| t1mp | artmello: but I realized that your bug describes two bugs, so maybe the dupe is incorrect. | 13:34 |
| t1mp | artmello: could you check/test if the first bug is the same as the second one? | 13:35 |
| dpm | rpadovani, mzanetti, the refresh action in the toolbar works really well, so I'm happy we landed that. But I'm wondering if it might be better to move it out of the toolbar and trigger a refresh when the user pulls the list of notes from the top. With the new design, I've found myself unconciously pulling the list to do refreshes, although I know that the action is actually in the toolbar :) What do you think? | 13:36 |
| mzanetti | dpm: +1 for the general idea | 13:37 |
| mzanetti | dpm: don't have time for it right now | 13:37 |
| dpm | mzanetti, that's cool, I just wanted to hear your thoughts | 13:37 |
| dpm | I'm more interested in landing the new design right now than adding new features :) | 13:38 |
| rpadovani | dpm +1, I could add this to the weekend to-do list, if I have time I can try :-) | 13:39 |
| dpm | awesome | 13:39 |
| dpm | thanks guys | 13:40 |
| === oSoMoN_ is now known as oSoMoN | ||
| JoeyChan | Hello guys, is it a duplicate bug ? https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1317850 | 13:44 |
| dpm | hi JoeyChan, you might want to ask t1mp, he's the master of tabs! :-) | 13:48 |
| JoeyChan | Thanks dpm :) | 13:50 |
| JoeyChan | Hi t1mp, r u already fix this ? https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1317850 | 13:50 |
| dpm | JoeyChan, I've not been attending the RSS meetings for a while, how are you doing? And btw, thanks for pointing out the bug in translations from click packages :) | 13:51 |
| === chihchun_afk is now known as chihchun | ||
| JoeyChan | dpm Now Shorts is very stable, no feature added since early this year, we just fix bugs recently | 13:53 |
| dpm | glad to hear it's very stable! | 13:55 |
| JoeyChan | dpm Alan told me that there won't be any design support for Shorts, but Roman and I have not enough experience about design | 13:55 |
| JoeyChan | looking for some help from somewhere ... | 13:55 |
| popey | JoeyChan: one thing you can do, is implement the new toolbar, as nik90 is doing for clock, and ahayzen has done for music.. they can probably point you to a simple code sample | 13:57 |
| JoeyChan | popey the new header ? I saw it in G+ | 13:58 |
| popey | https://code.launchpad.net/~vthompson/music-app/use-sdk-back-button-take2/+merge/218534 | 13:58 |
| popey | I *think* that's it. | 13:58 |
| popey | right ahayzen ? | 13:58 |
| JoeyChan | wow, does the new header land already ? | 13:59 |
| JoeyChan | I am using Utopic r17 | 13:59 |
| popey | its in progress, but it's usable. | 13:59 |
| popey | maybe try it, and see how it works with rssreader? | 14:00 |
| popey | I suspect it might get interesting if you have a lot of tabs | 14:00 |
| JoeyChan | sounds cool lol | 14:00 |
| ahayzen | popey, whts up? | 14:04 |
| * ahayzen reads scrollback | 14:04 | |
| artmello | t1mp: I will test to see if its fixed. thx | 14:05 |
| ahayzen | popey, yeah that mp makes the tabs use the drawer | 14:05 |
| t1mp | artmello: great, thanks | 14:05 |
| artmello | t1mp: I thin both bugs (BUG1/BUG2) are the same | 14:05 |
| artmello | *think | 14:06 |
| ahayzen | popey, we have another one that adds the toolbar item to the header (this one https://code.launchpad.net/~andrew-hayzen/music-app/search-toolbar-item/+merge/218614) | 14:06 |
| popey | that will also be handy for JoeyChan, for adding the buttons | 14:06 |
| JoeyChan | got it :) | 14:07 |
| nik90 | popey: I updated the core apps blocker google doc with one for clock | 14:07 |
| popey | thanks nik90 | 14:08 |
| ahayzen | popey, JoeyChan note we had to lock the toolbar to closed as we have a custom toolbar and did not want the old one showing over the top of ours in older images, you probably won't have to do this | 14:08 |
| JoeyChan | ahayzen Do u mean ... if the toolbar is unlocked, it will show up over the top ? | 14:10 |
| ahayzen | JoeyChan, in older images without the new header stuff, the SDK toolbar would have been shown. We have a custom toolbar and do not want the SDK one to be shown... basically you probably don't need the opened: false locked: true in the ToolbarItem | 14:11 |
| ahayzen | JoeyChan, just adding useDeprecatedToolbar: false to the mainView will probably be enough | 14:12 |
| JoeyChan | ahayzen Thanks, I saw that in Music-app | 14:14 |
| dpm | hi kenvandine, did you find out more yesterday about that bug whereby on loading a second image from the Gallery via content hub Reminders got stuck? Was it a bug in Gallery? | 14:14 |
| ahayzen | JoeyChan, :) you'll probably need UITK staging to get the header items to work (instructions in the second mp on how to test/setup on desktop) | 14:15 |
| JoeyChan | ahayzen is it landed on Utopic (Phone) ? | 14:19 |
| ahayzen | JoeyChan, erm i'm not sure haven't checked recently, nik90 ? | 14:19 |
| ahayzen | JoeyChan, i know the drawer for tabs had...but not sure about the toolbar items in header | 14:20 |
| nik90 | ahayzen, JoeyChan: The tab drawers part has landed | 14:20 |
| nik90 | the header actions hasn't | 14:20 |
| JoeyChan | i c | 14:20 |
| ahayzen | nik90, thanks | 14:20 |
| JoeyChan | thanks :) | 14:21 |
| boren | Can anyone do apt-get update on Touch. | 14:22 |
| ahayzen | JoeyChan, let us know if u need any more help | 14:22 |
| JoeyChan | ahayzen So how can I test the new header ? | 14:23 |
| JoeyChan | add PPA ? | 14:23 |
| ahayzen | JoeyChan, i tested using the instructions under 'TESTING' on this mp https://code.launchpad.net/~andrew-hayzen/music-app/search-toolbar-item/+merge/218614 | 14:23 |
| nik90 | JoeyChan: if you are on trusty, you need the SDK PPA | 14:23 |
| dpm | mzanetti, rpadovani, approved the new design branch, it's looking fantastic, I'll let you guys do the honours and top-approve ;) | 14:24 |
| ahayzen | nik90, does the SDK PPA have the staging changes though, cause i had to build it from staging to test the toolbar items in header | 14:24 |
| mzanetti | :D | 14:24 |
| mzanetti | rpadovani: go ahead if you whish | 14:24 |
| nik90 | ahayzen: the PPA doesn't have the staging changes..you are right | 14:24 |
| nik90 | ahayzen: I thought JoeyChan wanted the new header | 14:24 |
| JoeyChan | nik90 How about phone ? I am using Utopic r17 | 14:24 |
| ahayzen | JoeyChan, i don't think either have staging changes yet right nik90 ? | 14:25 |
| nik90 | JoeyChan: on the phone, r17 should have the new header but *NOT* the header actions | 14:25 |
| rpadovani | mzanetti, all for you, my Jedi (QML) Master | 14:25 |
| ahayzen | yeah | 14:25 |
| nik90 | what ahayzen said ^ | 14:25 |
| nik90 | JoeyChan: Basically the new header actions are in staging..so not available on desktop or phone | 14:25 |
| ahayzen | JoeyChan, setting up staging on the desktop is quite easily thankfully | 14:26 |
| mzanetti | dpm: the missing separator in reminders happens if you mark one as done... I think renato has an upcoming fix for that in the component | 14:28 |
| dpm | mzanetti, ah, good to know, thanks | 14:28 |
| JoeyChan | ahayzen So I only need is add the SDK PPA on trusty(desktop) ? | 14:29 |
| ahayzen | JoeyChan, depends wht u want to do, adding the SDK PPA will bring you up to pretty much the same as the utopic image SDK | 14:30 |
| ahayzen | JoeyChan, but if you branch and build the staging then you get the latest and greatest | 14:30 |
| JoeyChan | ahayzen DO u mean download the source code then make install ? | 14:32 |
| ahayzen | JoeyChan, something like this would work for the music-app http://pastebin.ubuntu.com/7421680/ | 14:33 |
| ahayzen | JoeyChan, i doesn't replace the installed version of the SDK and is only for that session of the terminal | 14:34 |
| ahayzen | *it doesn't | 14:35 |
| JoeyChan | ahayzen wow thanks about that :) will have a test | 14:35 |
| ahayzen | JoeyChan, yeah t 1mp gave it to me pretty useful :) | 14:35 |
| kenvandine | dpm, yeah, maybe a regression in the sdk https://bugs.launchpad.net/ubuntu/+source/gallery-app/+bug/1317713 | 15:01 |
| rpadovani | dpm, could you give a try to https://code.launchpad.net/~rpadovani/reminders-app/betterGradient/+merge/219003 please? | 15:04 |
| rpadovani | I don't know if is enough as improvement, but it's an attempt | 15:04 |
| dpm | kenvandine, ah, thanks a lot for following that up | 15:05 |
| dpm | rpadovani, cool, testing now. Also, you know the bugfix you did for font family to be 'Ubuntu' by default? If you've got a minute, do you think you could do the same with setting the default font size? | 15:07 |
| rpadovani | dpm, I tried it yesterday but experimental.preferences.defaultFontSize didn't work, but I didn't investigate much more. I can take a look, but I promise nothing | 15:08 |
| dpm | rpadovani, no worries, thanks! | 15:12 |
| kenvandine | dpm, no problem | 15:16 |
| dpm | rpadovani, looks great to me now, nice work! Are you still concerned about the performance, though? | 15:20 |
| rpadovani | dpm, dunno, I don't tried it on device, but I think on mako should works well | 15:21 |
| === gatox is now known as gatox_lunch | ||
| dpm | bbiab, really late lunch :) | 15:34 |
| dpm | popey, I think when the next reminders branches land in trunk we should be good to go for a store upload, but let's sync later on if you've got time | 15:34 |
| popey | I'll be around dpm, just ping me | 15:35 |
| === gatox_lunch is now known as gatox | ||
| dpm | rpadovani, could you perhaps remove the prerequisite branch from https://code.launchpad.net/~rpadovani/reminders-app/betterGradient/+merge/219005 and do an empty commit? I'm not sure what's happened with the diff after the new-design branch landed. I've tested the branch, but I'd prefer to see a diff before top-approving | 16:12 |
| dpm | I'm hoping that the commit might trigger an update to the diff | 16:13 |
| rpadovani | dpm, mh, strange, I do it now | 16:13 |
| rpadovani | dpm, well, now diff works :-) https://code.launchpad.net/~rpadovani/reminders-app/betterGradient/+merge/219015 | 16:14 |
| dpm | aha! | 16:15 |
| dpm | balloons, nik90, would you be happy to go with the suggestion here? -> https://code.launchpad.net/~popey/ubuntu-clock-app/fix-1315318/+merge/218067 | 16:26 |
| dpm | also balloons, I guess this branch can be marked as Rejected as superseded by elopio's new test branches for Reminders? -> https://code.launchpad.net/~nskaggs/reminders-app/oauth-ap/+merge/204107 | 16:31 |
| dpm | popey, ok, I think we're good to go with Reminders' new design, could you trigger a click build from the latest trunk (r131)? | 16:33 |
| popey | yup | 16:34 |
| dpm | \o/ | 16:34 |
| popey | building r131 now | 16:35 |
| nik90 | dpm: yes | 16:39 |
| balloons | dpm, yes my old branch can be rejected | 16:43 |
| nik90 | dpm: for that MP, jenkins wont merge it though..will balloons force it? | 16:43 |
| balloons | dpm, right we would have to force it | 16:44 |
| dpm | how do we force it? Do we ask nicely? | 16:44 |
| nik90 | dpm: well balloons does his magic and then jenkins listens :) | 16:46 |
| dpm | aaah, that's how he works! :-) | 16:46 |
| balloons | lol | 16:46 |
| popey | looking forward to writing next weeks core apps update | 16:48 |
| popey | it's going to be a monster | 16:48 |
| popey | s/next/this/ | 16:48 |
| dpm | indeed! | 16:50 |
| dpm | popey, and wait until you see the new reminders design :) | 16:50 |
| popey | just pushed to my phone | 16:50 |
| dpm | cool :) | 16:51 |
| popey | it says no notes | 16:51 |
| popey | but i have it setup to my sandbox account | 16:51 |
| popey | and i can't add an evernote account on my flo | 16:52 |
| popey | the online accounts plugin dies | 16:52 |
| dpm | hm, does it show an activity indicator? Can you use the new Refresh button in the toolbar? Do you actually have notes (sorry, obvious question, but had to ask)? | 16:52 |
| popey | i refreshed, and yes i have notes | 16:52 |
| * popey reboots phone to start again | 16:53 | |
| dpm | on another subject popey, renato, I don't seem to be able to run Calendar on my trusty desktop. Am I missing any EDS fixes or something? This is what I'm getting -> http://pastebin.ubuntu.com/7422308/ | 16:53 |
| popey | dpm: i have seen that before, uncheck your google accounts in online accounts and see if you can open it | 16:54 |
| popey | then try and re-enable them | 16:54 |
| dpm | ok | 16:54 |
| popey | rebooted phone, i do have an evernote account setup, and see no notes | 16:55 |
| popey | refresh does nothing | 16:55 |
| nik90 | t1mp: I thought I saw a MP by bzoltan which merged the new header actions into trunk...Did it get merged? | 16:56 |
| popey | dpm: paste.ubuntu.com/7422329/ | 16:56 |
| popey | dpm: will try removing evernote account and re-adding | 16:57 |
| t1mp | nik90: I think it landed half an hour ago | 16:58 |
| nik90 | t1mp: awesome..when will the next landing take place? the one with the critical pagestack bug | 16:58 |
| t1mp | nik90: we will start it Monday | 16:59 |
| nik90 | t1mp: ok | 16:59 |
| dpm | mzanetti, any ideas why popey cannot get Reminders to work on his device? Seems to be something related to online accounts: http://paste.ubuntu.com/7422329/ | 16:59 |
| popey | dpm: what image you on? mine are #19 | 16:59 |
| t1mp | nik90: that fix just landed in our staging | 16:59 |
| nik90 | t1mp: yeah I noticed | 17:00 |
| popey | dpm: the online accounts system is broken completely - i can't add a twitter account | 17:00 |
| dpm | popey, I'm on #17 | 17:01 |
| rpadovani | dpm, popey I'm bootstraping a device, hope to give a try in ~15 minutes | 17:01 |
| popey | try adding any account in online accounts | 17:01 |
| popey | i cant add _anything_ | 17:01 |
| dpm | popey I did already for Evernote and it worked, but let me try another one | 17:01 |
| popey | on #19? | 17:01 |
| dpm | popey, I'm still on #17 | 17:02 |
| popey | people.canonical.com/~ogra/touch-image-stats/19.changes | 17:02 |
| popey | libonline-accounts-client1:armhf from 0.3+14.04.20140328-0ubuntu3 to 0.3+14.10.20140506.1-0ubuntu1 | 17:02 |
| popey | bet that broke it | 17:02 |
| popey | ubuntu-system-settings-online-accounts from 0.3+14.04.20140328-0ubuntu3 to 0.3+14.10.20140506.1-0ubuntu1 | 17:02 |
| popey | or that ☻ | 17:02 |
| popey | mardy: ^ | 17:02 |
| dpm | popey, ok, then it needs to be tested on #17 or #18, I guess. Do you have the link to the .click? I'll give it a go | 17:03 |
| popey | dpm: http://popey.com/~alan/com.ubuntu.reminders_0.5.131_armhf.click | 17:03 |
| popey | that link work? | 17:03 |
| dpm | popey, thanks. It downloaded something, at least :) | 17:04 |
| * popey files a bug | 17:04 | |
| dpm | bah, can't get Calendar to start at all, only if I disable online accounts :( | 17:05 |
| popey | irritatingly this is a friday image so it's going to be broken over the weekend | 17:05 |
| popey | dpm: try my ppa... | 17:05 |
| dpm | oh, you managed to build all that stuff for trusty? awesome! | 17:06 |
| popey | dpm: https://launchpad.net/~popey/+archive/qtpim add that ppa and upgrade, if it doesn't work then ppa-purge it again | 17:06 |
| popey | yeah | 17:06 |
| ogra_ | popey, y'know ... there were dogfooders approving it :P | 17:06 |
| popey | i didnt | 17:06 |
| dpm | popey, will give it a go after Reminders | 17:06 |
| popey | ok | 17:06 |
| ogra_ | dpm, did you see #ubuntu-devel ? wrt reminders | 17:07 |
| dpm | nope, looking now... | 17:07 |
| rpadovani | popey, I can confirm your issues: only account I can add is the Ubuntu one, and I'm on a fresh installation :/ | 17:17 |
| dpm | rpadovani, on what image are you? This seems to have happened with #19, but it's ok with #17 (and I guess with #18 it's ok too) | 17:17 |
| rpadovani | dpm #19 | 17:18 |
| nik90 | balloons: looks like jenkins isn't listening to you | 17:18 |
| dpm | rpadovani, mzanetti, so unfortunately, we'll have to postpone the upload with the new design to th store until Monday -> we'll need to fix this one first: https://bugs.launchpad.net/reminders-app/+bug/1317977 | 17:33 |
| dpm | rpadovani, mzanetti, in any case, perhaps it's better so, as it's not always the best idea to release on a Friday. Calling it a day now, thanks so much for the awesome awesome job in getting the app not only in shape, but also to land a full new design this week. | 17:36 |
| rpadovani | :-) | 17:36 |
| renato | dpm, I am not sure if the fix landed on trusty | 17:37 |
| dpm | thanks renato, I'll test again from popey's backport PPA | 17:38 |
| === gcollura is now known as gcollura|afk | ||
| === salem_ is now known as _salem | ||
| gerlowskija | How long does the emulator take to start the first time around? | 21:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
