| xnox | \o/ released | 00:22 |
|---|---|---|
| Saviq | thomi, now | 07:43 |
| Saviq | thomi, I saw your ap 1.5 change | 07:43 |
| thomi | Saviq: cool - any chance you can get it reviewed, merged, and landed? :) | 09:13 |
| Saviq | thomi, some, yes ;) | 09:14 |
| thomi | Saviq: for the price of a beer in Malta? | 09:14 |
| Saviq | thomi, ;) | 09:14 |
| nik90 | elopio, balloons: Do you happen to know if the new SDK Headers are support by the emulator helper functions? Just curious since I am getting a branch ready in the clock app to make the transition but wondering the AP side of things. | 11:42 |
| nik90 | s/support/supported | 11:42 |
| balloons | nik90, elopio is the best person to answer that | 13:33 |
| balloons | however, I believe work was being done in conjunction. I'd have to dig to find the mp | 13:34 |
| nik90 | balloons: ok. I sort of remember t1mp fixing the AP while implementing the new transitions but wanted to confirm with you guys. | 13:47 |
| nik90 | s/transitions/headers | 13:48 |
| elopio | nik90: yes, you should have helpers for the new features of the header. | 14:20 |
| nik90 | elopio: awesome | 14:25 |
| xnox | autopilot gurus, please help =) | 16:26 |
| xnox | http://paste.ubuntu.com/7468524/ says in the end 4 failures, yet, i can only find one FAIL | 16:26 |
| xnox | FAIL: gallery_app.tests.test_album_view.TestAlbumView.test_add_photo | 16:27 |
| xnox | what are the other failures? | 16:27 |
| elopio | nuclearbob, cgoldberg: do you know what could cause this? | 16:32 |
| elopio | AttributeError: 'module' object has no attribute 'get_classname_from_path' | 16:32 |
| elopio | http://91.189.93.70:8080/job/generic-mediumtests-utopic/190/testReport/junit/reminders.tests.test_reminders/RemindersTestCaseWithoutAccount/test_go_to_account_settings_with_mouse_/ | 16:32 |
| cgoldberg | elopio, this looks suspicious in the log: | 16:36 |
| cgoldberg | file:///usr/share/reminders/qml/ui/NotesPage.qml:83: TypeError: Cannot read property 'reminder' of null | 16:36 |
| cgoldberg | file:///usr/share/reminders/qml/ui/NotesPage.qml:79: TypeError: Cannot read property 'reminder' of null | 16:36 |
| cgoldberg | file:///usr/share/reminders/qml/reminders.qml:287:30: Unable to assign null to QQuickAnchorLine | 16:36 |
| elopio | cgoldberg: I think that's safe to ignore, as the videos show the application being properly displayed. | 16:37 |
| balloons | elopio, this is from https://code.launchpad.net/~dpm/reminders-app/fix-1317683-update-template/+merge/219669? basically showing that trusty works, while utopic doesn't right/ | 16:40 |
| cgoldberg | elopio, can I see reminders/__init__.py ? | 16:40 |
| elopio | cgoldberg: http://bazaar.launchpad.net/~reminders-app-dev/reminders-app/trunk/view/head:/tests/autopilot/reminders/__init__.py | 16:41 |
| cgoldberg | elopio, dbus.get_classname_from_path ? | 16:42 |
| cgoldberg | it overrides validate_dbus_object and calls that ^^ but what is that? | 16:44 |
| elopio | that's how nuclearbob told me to use a python class that's different from the qml class. | 16:50 |
| elopio | hey, the method was removed! | 16:55 |
| cgoldberg | weird.. i tried from command line and I can see that attribute fine | 16:55 |
| cgoldberg | elopio, but it's not in API docs | 16:55 |
| cgoldberg | elopio, in changelog for 1.5: Autopilot introspection package now has a cleaner API | 16:57 |
| elopio | balloons: on trusty we have autopilot 1.5 and on utopic 1.4? or something like that? | 16:59 |
| cgoldberg | elopio, locally... i have 1.4 on trusty.. but 1.5 landed in utopic afaik | 17:01 |
| nuclearbob | elopio: sorry about that, I was in a meeting, I'm reading the scrollback now, did you get something resolved? | 17:02 |
| cgoldberg | elopio, so did 1.5 break tests? | 17:04 |
| elopio | cgoldberg: yes | 17:05 |
| cgoldberg | doh! is it isolated to that one? | 17:05 |
| elopio | nuclearbob: well, now I know the reason. The new introspection api breaks our reminder tests. | 17:05 |
| elopio | should I put a depends autopilot (= 1.4) ? | 17:05 |
| nuclearbob | I'll echo cgoldberg's doh | 17:06 |
| nuclearbob | elopio: which tests was it breaking? I'd like to look back through the testing we did and see how we could have caught that | 17:06 |
| elopio | http://91.189.93.70:8080/job/generic-mediumtests-utopic/190/testReport/junit/reminders.tests.test_reminders/RemindersTestCaseWithoutAccount/test_go_to_account_settings_with_mouse_/ | 17:07 |
| elopio | nuclearbob: can you put a deprecation warning instead of removing that function? | 17:08 |
| nuclearbob | elopio: I'll propose that in the meeting today | 17:12 |
| balloons | elopio, nuclearbob ohh.. I'll bet you didn't test reminders did you? since it's not in the image | 17:27 |
| balloons | I should go look | 17:28 |
| nuclearbob | balloons: let me know what you find out, I'd like to make sure it's tested in the future | 18:09 |
| balloons | nuclearbob, I couldn't find the doc thomi shared with me highlighting everything | 18:14 |
| balloons | but yea, just make sure it's on the list :-) | 18:14 |
| Letozaf_ | balloons, elopio hi | 19:06 |
| balloons | Letozaf_, hello | 19:06 |
| Letozaf_ | balloons, I saw elopio's branch for evernote sdk | 19:08 |
| balloons | Letozaf_, yes, essentially he wants to use the python3 version of the sdk which hasn't been packaged yet | 19:08 |
| Letozaf_ | balloons, ok so this means that we will have to wait I suppose | 19:09 |
| elopio | Letozaf_: but we can work on your test on the mean time. | 19:10 |
| Letozaf_ | elopio, ok :) | 19:10 |
| elopio | you can just set the PYTHONPATH to point to the right thrift module. | 19:10 |
| elopio | Letozaf_: do you have some time now? | 19:11 |
| Letozaf_ | elopio, yes sure | 19:11 |
| elopio | Letozaf_: ok, first thing, merge your branch with mine. | 19:11 |
| elopio | bzr merge lp:~elopio/reminders-app/evernote-sdk | 19:11 |
| Letozaf_ | elopio, ok just a second | 19:12 |
| Letozaf_ | elopio, done, got 4 conflicts... | 19:14 |
| * Letozaf_ is looking at the conflicts | 19:15 | |
| Letozaf_ | elopio, should be ok now, no more conflicts | 19:29 |
| elopio | Letozaf_: great. so, next, github clone https://github.com/evernote/evernote-sdk-python3.git | 19:30 |
| elopio | anywhere on your workspace. | 19:30 |
| Letozaf_ | elopio, haven't got the github command, in what package is it ? still looking for it... | 19:33 |
| elopio | Letozaf_: sudo apt-get install github | 19:33 |
| elopio | oh, no, sorry. | 19:33 |
| elopio | it's not github, just git | 19:33 |
| elopio | sudo apt-get install git. | 19:33 |
| Letozaf_ | elopio,ok thanks | 19:33 |
| Letozaf_ | elopio, ok done | 19:35 |
| elopio | Letozaf_: now, when you run the tests, you will have to do PYTHONPATH=path/to/your/workspace/evernote-sdk-python3/lib autopilot3 run reminders | 19:36 |
| Letozaf_ | elopio, ok let me try | 19:37 |
| Letozaf_ | elopio, got some errors :( trying to figure out what they are | 19:41 |
| elopio | Letozaf_: paste them here, I might be able to help. | 19:41 |
| Letozaf_ | elopio, ok | 19:41 |
| Letozaf_ | elopio, http://paste.ubuntu.com/7469435/ | 19:42 |
| elopio | Letozaf_: do you have the applications ppa on your machine? | 19:43 |
| Letozaf_ | elopio, I have the ubuntu-touch-coreapps-drives one | 19:44 |
| Letozaf_ | elopio, I am running utopic on my desktop | 19:44 |
| elopio | Letozaf_: yes, then just install evernote-sdk-python3 | 19:45 |
| elopio | that will solve your missing dependencies. | 19:45 |
| Letozaf_ | elopio, ok | 19:45 |
| Letozaf_ | elopio, now I got this: http://paste.ubuntu.com/7469469/ | 19:48 |
| elopio | agh, you updated autopilot | 19:49 |
| elopio | it has a regression, they changed the api breaking our tests. | 19:49 |
| Letozaf_ | elopio, :( | 19:49 |
| balloons | Letozaf_, you are on utopic yes? | 19:49 |
| Letozaf_ | balloons, yes sir | 19:49 |
| balloons | Letozaf_, I'll give you the old package to install | 19:49 |
| Letozaf_ | balloons, ok thanks | 19:50 |
| balloons | https://launchpad.net/ubuntu/+archive/primary/+files/python3-autopilot_1.4%2B14.04.20140416-0ubuntu1_all.deb | 19:52 |
| balloons | https://launchpad.net/ubuntu/+archive/primary/+files/python-autopilot_1.4%2B14.04.20140416-0ubuntu1_all.deb | 19:52 |
| balloons | start with those.. might need more packages | 19:52 |
| * Letozaf_ is installing | 19:53 | |
| Letozaf_ | balloons, done | 19:55 |
| balloons | Letozaf_, if that doesn't fix it we'll need to backdate libs too | 19:56 |
| balloons | give it a try | 19:56 |
| balloons | and yea, don't update ;-) | 19:56 |
| * Letozaf_ is running the tests | 19:58 | |
| balloons | hey thomi.. morning to you | 20:03 |
| Letozaf_ | balloons, elopio got this: http://paste.ubuntu.com/7469563/ | 20:03 |
| thomi | morning | 20:04 |
| thomi | barry: did you get time to look at the packaging stuff? </daily nag> | 20:04 |
| barry | thomi: somehow, i knew that was coming. :) no, but i am finishing up my Big Project today and you're tops on my list | 20:05 |
| thomi | OK :) | 20:05 |
| thomi | I'll keep nagging, although my next working day will be the first day in Malta | 20:05 |
| barry | thomi: safe travels! i'll follow up to the email | 20:06 |
| thomi | awesome, thanks - and sorry for the nagging | 20:06 |
| balloons | thomi, can you share the paste you had showing the the tests you run before ap 1.5? | 20:06 |
| barry | no, it's cool. i *want* you to nag me 'til its done | 20:06 |
| elopio | Letozaf_: try this before running the tests from the root of the branch | 20:07 |
| elopio | cmake . | 20:07 |
| elopio | make | 20:07 |
| Letozaf_ | elopio, ah yes! I had forgot about this :P | 20:07 |
| Letozaf_ | elopio, well it's better now but still got some failures: http://paste.ubuntu.com/7469632/ | 20:18 |
| elopio | Letozaf_: yes, your online accounts is crazy | 20:19 |
| elopio | May 15 22:15:44 letozaf-PC signond[19627]: ../../../../src/signond/signondaemon.cpp 388 init Failed to SUID root. Secure storage will not be available.}}} | 20:19 |
| elopio | process-return-code: {{{-15}}} | 20:19 |
| elopio | May 15 22:16:06 letozaf-PC kernel: [ 9309.074638] reminders[19638]: segfault at 10 ip 00007f63f0d63950 sp 00007fff8f1f2110 error 4 in libsignon-qt5.so.1.0.0[7f63f0d57000+34000]}}} | 20:19 |
| elopio | process-return-code: {{{-11}}} | 20:19 |
| elopio | Letozaf_: can you remove all your evernote accounts? That might help. | 20:20 |
| Letozaf_ | elopio, :) I was looking but I have no Evernote accounts in online accounts :O | 20:20 |
| Letozaf_ | elopio, must be somewhere else | 20:20 |
| elopio | Letozaf_: I don't know what to do with that. mardy is the only one that knows about online accounts. | 20:22 |
| Letozaf_ | elopio, could it be I have to remove the ~/.local/share/com.ubuntu.reminders | 20:22 |
| Letozaf_ | elopio, directory ? | 20:22 |
| elopio | unlikely as we are using a tmp home. | 20:22 |
| elopio | but remove it if you are not going to miss it. | 20:23 |
| Letozaf_ | elopio, ok | 20:23 |
| Letozaf_ | elopio, this did not solve the problem, not that I thought it would but I tried all the same | 20:26 |
| elopio | Letozaf_: try pkill -f signon* | 20:26 |
| Letozaf_ | elopio, done, let me run the tests again | 20:27 |
| Letozaf_ | elopio, http://paste.ubuntu.com/7469680/ | 20:30 |
| Letozaf_ | elopio, looks the same | 20:31 |
| elopio | Letozaf_: I don't know what else to look for. balloons: any idea? | 20:34 |
| * balloons is busy editing docs | 20:34 | |
| balloons | let me have a look | 20:34 |
| balloons | my eyes need a break heh | 20:34 |
| balloons | ok, so Letozaf_ it might be worth doing a fresh build if you haven't done one recently | 20:35 |
| balloons | I like to clean up all the cmake stuff first | 20:35 |
| Letozaf_ | balloons, ok | 20:36 |
| balloons | find -iname '*cmake*' -not -name CMakeLists.txt -exec rm -rf {} \+ | 20:36 |
| balloons | make clean | 20:36 |
| balloons | meanwhile, I'll try. | 20:36 |
| Letozaf_ | balloons, done | 20:36 |
| Letozaf_ | balloons, form reminders-app main dir | 20:37 |
| Letozaf_ | from | 20:37 |
| balloons | Letozaf_, yep.. top level of reminders-app | 20:37 |
| Letozaf_ | balloons, ok so done | 20:37 |
| balloons | what's the branch | 20:38 |
| balloons | Letozaf_, then rebuild it using cmake . | 20:38 |
| balloons | make | 20:38 |
| Letozaf_ | balloons, ok | 20:38 |
| Letozaf_ | balloons, witch branch mine ? | 20:38 |
| balloons | Letozaf_, whichever branch I need to reproduce what you and elopio are doing | 20:39 |
| balloons | I'm lost | 20:39 |
| Letozaf_ | balloons, let me push this to a new one, just in case | 20:39 |
| elopio | Letozaf_: resubmit the merge proposal with my branch as a prerequisite, please | 20:40 |
| Letozaf_ | elopio, you mean push lp:~elopio/reminders-app/xxx ? | 20:41 |
| elopio | Letozaf_: no, I mean, go to the website https://code.launchpad.net/~carla-sella/reminders-app/download-list-of-notebooks-and-notes/+merge/218325 | 20:42 |
| elopio | you'll see a button on the top-right that says resubmit proposal | 20:42 |
| elopio | on the for that will be opened, there's a field for the prerequisite branch. | 20:42 |
| Letozaf_ | elopio, yes got it | 20:43 |
| elopio | put lp:~elopio/reminders-app/autopilot-add_notebook there | 20:43 |
| elopio | no, that's not the one. | 20:43 |
| elopio | lp:~elopio/reminders-app/evernote-sdk | 20:43 |
| Letozaf_ | elopio, ok done, so now I should push what I've got here ? | 20:44 |
| elopio | Letozaf_: yes. | 20:45 |
| Letozaf_ | balloons, ok so lp:~carla-sella/reminders-app/download-list-of-notebooks-and-notes | 20:46 |
| Letozaf_ | balloons, is the branch | 20:46 |
| Letozaf_ | elopio, looks like I made a mess I have conflicts | 20:47 |
| Letozaf_ | elopio, let me see if I can fix | 20:48 |
| elopio | Letozaf_: I see it fine here: https://code.launchpad.net/~carla-sella/reminders-app/download-list-of-notebooks-and-notes/+merge/218325 | 20:48 |
| Letozaf_ | elopio, oh! wonder what I was lookig at :P | 20:49 |
| * Letozaf_ is rebuilding with cmake | 20:50 | |
| elopio | I'm sorry, I need to go and have lunch now. | 20:52 |
| elopio | I'll be back later. | 20:52 |
| Letozaf_ | elopio, I will be back tomorrow, it's late here | 20:53 |
| elopio | ok, have a good night. | 20:54 |
| Letozaf_ | elopio, thank you and enjoy your lunch | 20:54 |
| Letozaf_ | balloons, this is what I got after rebuilding with cmake http://paste.ubuntu.com/7469814/ | 20:58 |
| thomi | balloons: http://etherpad.ubuntu.com/B2Wt9rUiHX | 20:58 |
| thomi | sorry for the delay | 20:58 |
| Letozaf_ | balloons, I think I will go to bed now it's quite late, I will be back tomorrow ok ? | 20:59 |
| balloons | thomi, ok so I wanted the pad link to confirm one thing. And indeed,it seems you did not test reminders | 21:19 |
| balloons | Which is fine, just if you could add that to the list. I've been trying to get it into the image, but they are waiting for it to use the production evernote servers. It should happen soon. | 21:20 |
| balloons | anyways, those tests were broken by ap 1.5 | 21:20 |
| thomi | balloons: we're just talking about it now | 21:26 |
| thomi | balloons: care to join our hangout? | 21:26 |
| nuclearbob | elopio: are you still there? | 21:26 |
| thomi | balloons: or elopio: https://plus.google.com/hangouts/_/calendar/Y2Fub25pY2FsLmNvbV91bnZxZzdzamhoMW11YzJxZ2FxZjA5a2p2NEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t.fk2gi9fumct9rei9q2fatpq7u0?authuser=1 | 21:26 |
| thomi | elopio: balloons: too slow! | 21:32 |
| balloons | sorry, didn't see ;-( | 21:32 |
| thomi | balloons: so the conclusion is that we messed up, and didn't include that function in the API. I'll propose an MP that fixes that toda | 21:33 |
| thomi | y | 21:34 |
| thomi | balloons: However, we're reluctant to start running test suites that aren't in the dashboard list | 21:34 |
| balloons | thomi, I do get that.. but reminders is a bit special. Still, it's fine if you don't want to add it now. It will be in the list soon enough | 21:34 |
| thomi | yeah - when it's in the list we'll start running those tests magically | 21:35 |
| thomi | sorry about missing that function from our public API. We're trying to get better this cycle at separating our public from our private API | 21:35 |
| balloons | I'm ok with the mistake.. glad we caught it. It's just annoying to have this stuff come up when I've been pushing for reminders to be on the dash.. | 21:36 |
| balloons | stuff like this is the reason why.. if the tests aren't on the dash, they aren't being exercised. And they could break.. and in general they serve no purpose unless they are being run | 21:37 |
| thomi | yup | 21:37 |
| thomi | veebers: any chance you could glance at https://code.launchpad.net/~thomir/autopilot/temp-dev-add-get_classname_from_path-to-public-api/+merge/219765 please? | 22:00 |
| veebers | thomi: sure thing | 22:01 |
| thomi | veebers: also, I realise I forgot to scope that task | 22:01 |
| veebers | thomi: have you run it over reminders app to make sure it fixes the issue? | 22:01 |
| veebers | thomi: heh, d'oh :-P | 22:01 |
| thomi | no | 22:01 |
| thomi | but this is the only place I'm willing/able to expose that function, so if it's not right, they'll need to import it from here | 22:02 |
| veebers | thomi: ok | 22:09 |
| cgoldberg | thomi, hey.. reminders was calling get_classname_from_path on autopilot.introspection.dbus | 22:11 |
| cgoldberg | http://bazaar.launchpad.net/~reminders-app-dev/reminders-app/trunk/view/head:/tests/autopilot/reminders/__init__.py#L68 | 22:16 |
| thomi | cgoldberg: yeah, but that's not going to be public for much longer | 22:21 |
| thomi | balloons: who's working on that app? | 22:21 |
| cgoldberg | thomi, Leo notified us today.. so he will need to change his import to use your fix | 22:22 |
| balloons | thomi, elopio and carla atm.. I've not done much but comment and help :-) | 22:22 |
| thomi | balloons: OK, well, I guess their approach is to import it from the private module today | 22:22 |
| thomi | and when we do the new release y'all will have to import it from the autopilot.introspection package instead | 22:23 |
| thomi | but that can be done at your leisure | 22:23 |
| balloons | :-) | 22:23 |
| veebers_ | thomi: oh, approved btw | 22:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!