| elopio | thomi: thanks for fixing it. | 00:03 |
|---|---|---|
| thomi | elopio: well, as mentioned above you'll still need to patch it in the short-term, and then again once our point release is out | 00:03 |
| elopio | thomi: yes, that's ok. | 00:05 |
| elopio | it's also ok if you don't want to expose that function as public, as long as you give us an alternative. | 00:05 |
| thomi | elopio: no, it really should be part of the public API, we just forgot aboutit | 00:05 |
| thomi | since we're exposing validate_dbus_object we really have to expose that as well | 00:06 |
| thomi | we just forgot to put it in the __init__ file | 00:06 |
| elopio | thomi: and now we have two different APIs, one in trusty and one in utopic. | 00:06 |
| thomi | elopio: yeah, but that's been the case for every release for the last 2 years | 00:07 |
| elopio | are you going to release ap1.5 to trusty? or do I have to add check for the current installed version? | 00:07 |
| thomi | elopio: we'll release to a PPA for trusty, but not in the distro itself | 00:07 |
| thomi | in fact, I might start that work today | 00:08 |
| thomi | elopio: your tests that mocked DBusIntrospectionObject - they haven't landed yet, right? | 00:12 |
| thomi | veebers: could you please review https://code.launchpad.net/~thomir/autopilot/temp-dev-fx-docs/+merge/219630 for me? | 00:29 |
| veebers | thomi: sure thing (sorry for the delay) | 01:56 |
| thomi | veebers: nw | 01:56 |
| thomi | veebers: I also wonder if you have any insight into the CI failure here: https://code.launchpad.net/~thomir/autopilot/begin-renaming-of-emulatorbase/+merge/219625 | 01:56 |
| veebers | thomi: I'll take a look at that too | 01:57 |
| veebers | thomi: with yout docs changes, did you want to fix the mentions of 'CustomEmulatorBase' (i.e. change to ProxyBase) within the "Writing Custom Proxy Classes" section in this MP? | 02:06 |
| veebers | s/with yout/wirh regards to your/ | 02:06 |
| veebers | close enough | 02:06 |
| thomi | hmmm, probably should eh | 02:06 |
| thomi | thanks :) | 02:06 |
| veebers | nw :-) | 02:07 |
| thomi | veebers: that, and a few other instances have been fioxed & pushed. revno 501 | 02:09 |
| * veebers pulls | 02:12 | |
| veebers | thomi: looks awesome, approved | 02:16 |
| veebers | thomi: re: that test failure I wonder if it's an infrastructure thing (otto perhaps?) I really don't know as it's not consistent and passes for me here | 02:21 |
| veebers | thomi: further more, your docs change branch has the same code changes as the one with the failing test (minus the __name__ renaming) and that passes fine | 02:27 |
| thomi | veebers: I think it's not consistently failing | 02:42 |
| thomi | have restarted the CI run to see | 02:42 |
| veebers | thomi: awesome, cheers | 02:43 |
| veebers | thomi: any idea on how long the CI run takes? | 02:43 |
| thomi | far too long | 02:43 |
| thomi | about 2 hours | 02:43 |
| thomi | veebers: ugh, this failed to land as well: https://code.launchpad.net/~thomir/autopilot/temp-dev-fx-docs/+merge/219630 | 02:52 |
| thomi | on the same test | 02:52 |
| veebers | thomi: ugh, that is very odd. :-\ they both have the same code changes now too I guess | 02:53 |
| thomi | I guess I'll delete the smaller MP | 02:54 |
| thomi | what happened was I assumed it would land quickly | 02:54 |
| veebers | aye, makes sense | 02:55 |
| thomi | oooh, I just got it to fail locally as well :) | 02:57 |
| thomi | try running: | 02:57 |
| thomi | nice -n20 python3 -m autopilot.run run -r -v autopilot.tests.functional.test_autopilot_functional.AutopilotVerboseFunctionalTests.test_no_video_session_dir_saved_for_passed_test | 02:57 |
| * veebers tries | 02:58 | |
| veebers | thomi: that still passes for me :-\ | 02:58 |
| thomi | veebers: I had to run it a few times before it failed | 03:04 |
| veebers | thomi: ah ok, let me try and spam it | 03:09 |
| veebers | thomi: just ran it a bunch and still no failure. Perhaps I should try it on a single core VM | 03:11 |
| thomi | veebers: interesting | 03:11 |
| thomi | well, since I can reproduce it, I'll dig into it soon | 03:11 |
| thomi | just trying to help plars with a subunit issue | 03:11 |
| veebers | thomi: ack | 03:16 |
| thomi | ugh, now I can't reproduce it | 03:25 |
| veebers | :-( | 03:25 |
| thomi | even using 'stress' to load the machine | 03:25 |
| thomi | oh, there we go :) | 03:26 |
| veebers | heh :-) | 03:27 |
| thomi | hmmmm "CPU5: Core temperature above threshold, cpu clock throttled (total events = 1429060)" | 03:27 |
| veebers | thomi: heh, don't burn out your laptop just before a sprint :-P | 03:28 |
| thomi | ahh, I think I see the issue here | 03:28 |
| thomi | there's a race condition in the test | 03:28 |
| thomi | hmmm | 03:28 |
| thomi | not sure how to fix this | 03:30 |
| thomi | veebers: TBH, I don't think we can test this easily - care to take a look? | 03:31 |
| veebers | thomi: whats the race condition? | 03:39 |
| thomi | we're assuming that on the second line, the recording session for rmd hasn't been created yet | 03:39 |
| thomi | but that might not be the case | 03:39 |
| thomi | line 501 I mean | 03:39 |
| veebers | line 501 of test_autopilot_functional.py? | 03:40 |
| * veebers opens editor | 03:40 | |
| thomi | yeah | 03:40 |
| thomi | we could patch rmd's working dir, but I don't think you can do that via an environment variable | 03:41 |
| thomi | hmmm | 03:42 |
| veebers | thomi: yeah, only --workdir option looks like it can do that | 03:44 |
| thomi | veebers: aha - got it! | 03:46 |
| thomi | I can remove the AutopilotTestCase class form the equation comepletel | 03:46 |
| thomi | y | 03:46 |
| veebers | thomi: oh, in the created test file? | 03:46 |
| elopio | thomi: my branch with DBusIntrospectionObject mocks is about to land to staging. | 03:47 |
| elopio | just waiting for jenkins to stop being crazy. | 03:47 |
| veebers | elopio: heh, you might be waiting a while. You may have to make do with it being 'less crazy' ;-) | 03:49 |
| thomi | elopio: hmmm, with 1.5 out, you could now mock things out properly | 03:50 |
| elopio | thomi: actually, kalikiana prepared an alternate runner that lets us test with a qml, instead of mocking. | 03:51 |
| elopio | it looks prettier. But needs a couple of fixes, so we will have the ugly test around for a week or less. | 03:51 |
| thomi | elopio: right, but now you don't need your ap test to be ugly at all :) | 03:52 |
| elopio | thomi: well, I would still need it to be ugly for trusty. | 03:59 |
| thomi | elopio: not for long | 03:59 |
| thomi | elopio: you can add the 1.5 ppa | 03:59 |
| elopio | thomi: I would have to add the ppa for all the runners. I'd prefer not to do that today. | 04:06 |
| thomi | elopio: ok, I guess you'll either need to stop using trusty, or do that eventually anyway | 04:07 |
| elopio | yes, I suppose not using trusty is not an option. | 04:09 |
| thomi | veebers: fix pushed - you wanna take a look? revno 502 | 04:14 |
| thomi | would love to get a review | 04:14 |
| veebers | thomi: awesome ^_^ | 04:17 |
| * veebers looks now | 04:17 | |
| veebers | thomi: diffline 98 commented out pudb | 04:18 |
| thomi | ugh - forgot to save it :) | 04:19 |
| veebers | :-) | 04:19 |
| thomi | revno 503 comin at you ....now! | 04:19 |
| veebers | thomi: sorry didn't notice before, I'm getting flake8 errors | 04:25 |
| veebers | (2 of them) | 04:25 |
| thomi | ugh, I shoulda checked that | 04:25 |
| thomi | veebers: thanks, revno 504 pushed... now! | 04:26 |
| * veebers pulls | 04:27 | |
| thomi | veebers: I need to go start making dinner. I'll be back later - could I get you to make sure that branch gets approved please? | 04:36 |
| thomi | I need it to land before I can land my other MP | 04:36 |
| veebers | can do | 04:36 |
| thomi | thanks. I'll bbl | 04:37 |
| veebers | thomi: branch (top) approved just waiting on CI now. I'll come back later to check it | 04:46 |
| belkinsa | Hello, I think this page: https://wiki.ubuntu.com/Touch/CoreApps/Testing/ContributeAutopilotTestcase is outdated because I try get it going and I got this:http://paste.ubuntu.com/7473449/ | 15:15 |
| belkinsa | It looked like I had the PPA already. | 15:23 |
| belkinsa | I have a question. Can anyone do the autopilot test once one is created with noone assigned to it? | 17:59 |
| balloons | belkinsa, howdy | 17:59 |
| belkinsa | Hey there, balloons. | 18:00 |
| balloons | if you are speaking about a bug, yes. If no one is assigned, feel free to work on it | 18:00 |
| belkinsa | Yes, bugs that say Autopilot need in Ubuntu Touch Core apps | 18:00 |
| balloons | ohh I see the page still mentions the ppa.. you shouldn't need it. I'll remove it | 18:00 |
| belkinsa | Thanks. | 18:01 |
| balloons | let me know if you need any help.. This is the channel to ask, but it's a little lonely at this hour, as it's late friday night / saturday morning for most folks :-) | 18:02 |
| belkinsa | Alright. | 18:02 |
| balloons | i'll be here for a few more hours, so :-) | 18:03 |
| belkinsa | Alright, I could ask you how to get started with a test. I assigned myself to this one https://bugs.launchpad.net/dropping-letters/+bug/1317214 and I don't know how to start it. | 18:03 |
| ubot5 | Ubuntu bug 1317214 in Dropping Letters "Autopilot test needed: check for game over" [Medium,Confirmed] | 18:04 |
| balloons | ahh excellent. So first, grab the branch for dropping letters and make sure you can run the existing tests | 18:04 |
| balloons | first things first right? ;-) | 18:04 |
| balloons | Are you running trusty? | 18:04 |
| belkinsa | Yup, trusty and I have the branch already. | 18:04 |
| belkinsa | And I have the game both on my Nexus 7 2013 and PC. | 18:05 |
| balloons | awesome.. so inside is a test folder | 18:05 |
| balloons | and inside that is a folder named autopilot | 18:05 |
| belkinsa | Found it | 18:07 |
| balloons | sorry, got interrupted :-)( | 18:15 |
| belkinsa | It's cool | 18:15 |
| balloons | anyways, belkinsa to list the tests do 'autopilot list MODULE_NAME' | 18:15 |
| balloons | I think it might be dropping_letters? | 18:15 |
| belkinsa | Yup, you are right | 18:16 |
| belkinsa | This one? test_dropping_letters.py | 18:17 |
| balloons | belkinsa, if you ls in that subdirectory you will see a folder containing the testsuite | 18:17 |
| balloons | the folder name is the module name, and it's what you want to use | 18:18 |
| belkinsa | svetlana@svetlana-TECRA-M5:~/autopilottests/dropping-letters/tests/autopilot/dropping_letters_app$ ls | 18:19 |
| belkinsa | emulators.py __init__.py tests | 18:19 |
| belkinsa | ? | 18:19 |
| balloons | belkinsa, ahh you need to be at :~/autopilottests/dropping-letters/tests/autopilot/ | 18:19 |
| balloons | then you see dropping_letters_app? | 18:20 |
| balloons | so autopilot list dropping_letters_app | 18:20 |
| belkinsa | I think I might be missing that directory. | 18:20 |
| belkinsa | no, I have it | 18:21 |
| belkinsa | svetlana@svetlana-TECRA-M5:~/autopilottests/dropping-letters/tests$ ls | 18:22 |
| belkinsa | autopilot | 18:22 |
| balloons | cd into the autopilot directory | 18:22 |
| balloons | belkinsa, http://unity.ubuntu.com/autopilot/tutorial/getting_started.html#files-and-directories | 18:23 |
| belkinsa | done | 18:23 |
| belkinsa | Thanks. I will read that. | 18:23 |
| balloons | the entire tutorial will help | 18:23 |
| balloons | anyways, autopilot list dropping_letters_app will know show you the tests | 18:24 |
| balloons | *now | 18:24 |
| belkinsa | Oh, I see. you to write the test. | 18:25 |
| balloons | belkinsa, yes to run the testsuite as-is, you can issue an autopilot run dropping_letters_app. | 18:29 |
| balloons | I like to pass the -v argument, which makes the logging verbose so you get alot more output. This will be useful when you are writing the test | 18:29 |
| balloons | it's important you execute the autopilot run step from the proper directory. autopilot won't find the tests if they are in the local path or installed. So practically that means as a test author writing local tests, make sure you launch from that directory | 18:30 |
| balloons | *won't find the tests if they are NOT in the local path or installed | 18:31 |
| belkinsa | I see and that requires knowing the code of that app, right? | 18:35 |
| balloons | belkinsa, what do you mean? | 18:36 |
| belkinsa | Don't you need the code to know what to test for? | 18:37 |
| belkinsa | (of that app) | 18:37 |
| xnox | do we have a rough idea as to which qt4 based apps use autopilot? | 18:43 |
| Letozaf_ | balloons, elopio hi | 18:44 |
| balloons | belkinsa, you have the entire source of the app right there.. the tests and the source code for the app. You can run the app using qmlscene on your pc as well | 18:44 |
| belkinsa | Thanks, I guess I need to do my homework before driving in | 18:44 |
| balloons | belkinsa, you should go through the tutorial, it will help :-) | 18:44 |
| belkinsa | Okay. | 18:45 |
| balloons | http://unity.ubuntu.com/autopilot/tutorial/tutorial.html | 18:45 |
| balloons | that said, you can run the tests right now.. did you try it? | 18:45 |
| balloons | issuing the run command will take over your keyboard / mouse, launch the app and click away | 18:45 |
| belkinsa | Not yet. | 18:45 |
| balloons | you can also push it to your device and run them there, but we'll save that | 18:45 |
| balloons | Letozaf_, sorry, missed your message snuck in there! | 19:00 |
| balloons | Letozaf_, elopio is not around at the moment. I hope you had a good week and ready for the weekend! | 19:01 |
| Letozaf_ | balloons, no worries :) have you guys got new on reminders-app ? | 19:01 |
| Letozaf_ | balloons, yes sure I am | 19:01 |
| balloons | Letozaf_, we are waiting for python3-thrift to be packaged still. But I'm sorry I haven't gotten further on your branch | 19:02 |
| balloons | I'm looking at a calendar app problem , it's been a bit tough :-) | 19:02 |
| Letozaf_ | balloons, ok just wanted to know thanks | 19:02 |
| Letozaf_ | balloons, what problem ? | 19:02 |
| balloons | Letozaf_, weird apparmor errors, and failing tests ofc | 19:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!