/srv/irclogs.ubuntu.com/2014/05/19/#ubuntu-unity.txt

=== jono is now known as Guest96931
=== _salem is now known as salem_
SaviqWellark, hey, could we get a review of https://code.launchpad.net/~mterry/indicator-network/watch-nm-dbus/+merge/219705 and https://code.launchpad.net/~mterry/indicator-network/greeter-profiles/+merge/219897 please?07:37
=== zequence_ is now known as zequence
tsdgeosSaviq: 7.85+14.10.20140428.2-0ubuntu1 ?08:07
tsdgeosit is back08:07
Saviqtsdgeos, yeah, that one we never properly removed08:08
Saviqtsdgeos, and we probably don't care enough08:08
tsdgeosok08:08
Saviqtsdgeos, it got added by the train08:08
Saviqtsdgeos, some hiccup there08:08
=== salem_ is now known as _salem
tsdgeosmhr3: ping09:02
mhr3tsdgeos, pong09:03
=== vrruiz_ is now known as rvr
tsdgeosmhr3: mzanetti is complaining in the unity-api thing why Scopes::get returns a QVariant and not a ScopeInterface* while MockPreviewStack::get returns a PreviewModelInterface* and not a QVariant09:04
tsdgeosmhr3: what do you think of changing the first get to return a ScopeInterface* ?09:04
tsdgeosi just mimic''ed what we had in the old code09:04
tsdgeosbut maybe this is better?09:04
mhr3tsdgeos, i think there's a more fundamental issue - what should the get() return09:07
mhr3in some cases it's return a dict of all row properties09:07
mhr3in others it's returning one specific thing09:07
mzanettifwiw, all the other unity-api's return a non-variant-wrapped pointer to a single object09:08
mzanettion get() that is09:08
tsdgeosmhr3: well i think it should return what it is, so if it's going to be a QVariantMap, write QVariantMap instead of QVariant, if it's a ptr, the same, return the ptr instead of a QVariant09:10
tsdgeosSaviq: your opinion ↑↑↑↑ ?09:10
Saviqtsdgeos, mhr3 has a point - 'get' is not an established thing - sometimes we return an object "behind" the model, sometimes the QVariantMap09:12
mhr3tsdgeos, yea, sure, the question remains whether those get() methods should always return a QVariantMap09:12
mhr3tsdgeos, imo best would be get() -> QVariantMap and anything not returning a QVariantMap should be getXyz()09:12
Saviqmhr3, I think yes, and if we want the object behind it, we should use getObject, getRaw or something (that's what's in notifications)09:12
Saviqmhr3, violent agreement then09:12
mhr3indeed09:13
tsdgeosSaviq: mhr3: ok, i'll make get() return a QVariantMap and the ptr be getScope, getPreviewModel, etc09:13
mhr3tsdgeos, cool, thx09:14
Saviqtsdgeos, mhr3, do we need the get() at all?09:14
mhr3just came to my mind :)09:15
Saviqwe should avoid it with fire09:15
tsdgeosSaviq: i do not know, i'm just copying code around09:15
mhr3i think shell indeed it in one case09:15
* Saviq greps09:15
mhr3but who knows maybe it doesn't anymore09:15
tsdgeosthis is starting to look like those Qt code reviews where people ask me to fix some other bugs unrelated to the one i'm fixing :D09:15
Saviqtsdgeos, no no, I thought you were renaming09:16
mhr3tsdgeos, i guess that's a good thing? :)09:16
mhr3tsdgeos, quality++ ;)09:16
tsdgeosmhr3: in general is a bit frustrating tbh09:16
Saviqtsdgeos, *but*, unity-api is meant to sanitize after all...09:16
tsdgeossure09:17
mhr3> <mhr3> i think shell indeed it in one case09:18
mhr3wow09:18
mhr3i use indeed to much :)09:18
mhr3was meant to be needed :)09:18
Saviqmhr3, we get it on activate09:18
Saviqmhr3, to pass .result09:19
mhr3right, so that's the one use-case09:19
mhr3we could at least get rid of all the other get()s09:19
tsdgeosSaviq: but we can get it somehow else09:19
tsdgeosmhr3: you mean the getScope?09:20
mhr3tsdgeos, i meant we could get rid of the other QVariantMap get(), if there are any09:20
tsdgeosno, there's none else09:21
mhr3otherwise ScopeInterface* get() -> ScopeInterface* getScope()09:21
tsdgeosok09:22
* tsdgeos changes09:22
mhr3but yea, now we'll need to land unity-api, -scopes-shell and u8 in the same go09:24
mhr3since we're renaming09:24
SaviqCimi, you broke video carousel: http://imgur.com/p0oiNEo09:26
tsdgeosmhr3: you can still land unity-api first09:28
tsdgeossince it's "unused"09:29
tsdgeosand then land scopes-shell and u8 in one go09:29
mhr3right09:29
Mirvtsdgeos: Saviq: so far the story sounds like that if we want to switch to 5.3 it has to be ~now and not any lingering later plan. hopefully once unity8 starts working the functionality would look good, but when I for example was not able to launch system settings from indicator last week when I tried and I'm not sure why (in addition to scopes problem)09:31
CimiSaviq, let's revert it09:32
SaviqCimi, why can't it adapt to the card size?09:32
mhr3Mirv, what scopes problem?09:34
CimiSaviq, I did it externally in cardCarousel09:34
SaviqCimi, yeah, and? it knows the card size of course?09:35
tsdgeosMirv: define "now"09:35
CimiSaviq, you remember my fear of the anchors fill?09:35
Mirvmhr3: broken with Qt 5.3, since it relies on the delegate range patch that was not accepted by upstream. also the new unity8 branch somehow just crashes on 5.3 even though it works with the 5.3-way-of-doing-things-backported-to-5.2-qtdeclarative09:35
CimiSaviq, could be that issue09:35
Saviqmhr3, ours09:35
CimiSaviq, I am not anchoring to the artShape09:35
CimiI am just filling the card09:35
Mirvtsdgeos: 2-3 weeks probably09:35
Cimiwe thought filling card was enough09:35
tsdgeosMirv: even without the .0 out?09:36
mhr3Mirv, right, thx09:36
mhr3Saviq, see that now :)09:36
Ciminot in case of video apparently09:36
Mirvtsdgeos: well we can work on 5.3 rc for now and .0 should be out this week (or at latest next if it gets delayed)09:36
SaviqCimi, and? the carousel knows about the size of the card, there's no reason why it shouldn't work (with a borderimage on the shadow)09:36
Mirvtsdgeos: it's just that the schedule is such that we shouldn't do major things like this anymore later in June for example09:37
Mirvanyhow, more discussion on the subject will happen on Wed09:37
mhr3Saviq, Cimi, i'd also say the height of the video carousel is weird... maybe fixing that would magically fix this ;)09:37
Saviqmhr3, https://docs.google.com/a/canonical.com/file/d/0B8T-xKCA6bikUm56SG1pVEktZUk/edit09:38
Saviqmhr3, and anyway, kinda a mediascanner scope thing ;)09:38
mhr3Saviq, no, i mean there's loads of empty space beneath the carousel09:39
mhr3the visual design looks ok09:39
mhr3the real thing is empty09:39
Saviqmhr3, in any case it's just the padding09:40
Saviqmhr3, but agreed it seems to think it's bigger than it really is09:44
mhr3it's scary when the tech lead says that the qml components think :)09:46
mhr3although with all that code generation, who knows how sentient u8 is now :)09:48
veebersSaviq: should I be able to run unity8 on my desktop using 'start unity8' or has something changed?09:50
Saviqveebers, should work, make sure you don't have some stale job .conf in ~/.config/upstart09:51
Saviqveebers, anything in ~/.cache/upstart/unity8.log?09:52
Saviqveebers, and what does `initctl status unity8` say?09:52
veebersSaviq: ah ok, will check and try (this is from ~last week)09:52
veebersSaviq: `initctl status unity8` gives (before starting): unity8 stop/waiting, `initctl start unity8` hangs for ages and I accidently just Ctrl-C it :-\ but trying to start it again states ..'job is already running..'09:55
veebersand now `stop unity8` is hanging for ages :-\ will ctrl-c soon09:56
Saviqveebers, and that's current unity8? trusty or utopic?09:56
veebersSaviq: Hmm, trusty and should be up-to-date09:57
Saviqveebers, right, we should SRU this09:57
Saviqveebers, http://bazaar.launchpad.net/~unity-team/unity8/trunk/revision/866/data/unity8.conf09:58
veebersfyi: while stop was hanging status output is "unity8 stop/pre-start, process 13935"09:58
* veebers looks09:58
Saviqveebers, you need to kill any initctl still hanging, make that ↑ change to the unity8.job (you can just put current trunk's data/unity8.conf in ~/.config/upstart) and all should be good again09:59
Saviqveebers, and you should move to utopic already ;)09:59
veebersSaviq: heh right, I intend to upgrade after the sprint (knowing my luck a fresh install just before a sprint would have borked my laptop :-) )10:00
xnoxveebers: initctl start --no-wait unity810:00
* veebers tries10:00
xnoxveebers: you are probably blocked on jobs that start on starting/started unity8, yet other conditions for them have not been satisfied and thus you are blocked.10:00
Saviqxnox, that won't help for actually starting unity8, which didn't do --no-wait when starting indicators10:00
Saviqxnox, nope, he's blocked on starting indicators (which unity8's pre-start does)10:00
xnoxSaviq: horum.10:01
Saviqxnox, yeah, we added --no-wait since then10:01
Saviqneed to SRU10:01
veebersSaviq: put trunk http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/866/data/unity8.conf as ~/.config/upstart/unity8.conf `initctl start unity8` and it still hangs there (nothing popsup)10:04
Saviqveebers, that's because the previous job is still hanging10:05
Saviqveebers, make sure no initctl is still going10:05
veebersSaviq: ah ok, will do10:05
Saviqveebers, last resort restart your session...10:05
xnoxveebers: new config takes effect, only after the job is fully stopped.10:05
veebersxnox, Saviq: ah ha awesome that works a treat thanks guys /me finds it amusing when IRC notifications pop up in the windowed unity8 :-)10:06
Saviqveebers, ;)10:07
tsdgeosmhr3: any idea about this?10:49
mhr3tsdgeos, "this"?10:49
tsdgeosmhr3: http://paste.ubuntu.com/7487951/10:49
tsdgeosunity::scopes::ConfigException: invalid config file name: "/tmp/Runtime.ini.J10927": missing .ini extension10:49
mhr3fix for that is being landed right now10:50
mhr3in u8 approved mps10:50
mhr3tsdgeos, but just run it without params10:50
mhr3that will work10:50
tsdgeosmhr3: somehow my scopes are not running :/10:53
tsdgeosthis was an attempt at getting it to run10:53
tsdgeosi get the10:53
tsdgeosERROR! Caught unity::scopes::TimeoutException: Request timed out after 300 milliseconds10:53
tsdgeosand nothing happens10:53
mhr3tsdgeos, stop scope-registry && stop smart-scopes-proxy && start smart-scopes-proxy10:53
tsdgeosmhr3: done that like 10 times already :D10:53
* tsdgeos does again10:53
tsdgeossame10:54
mhr3tsdgeos, hm, what's in ~/.cache/upstart/scope-registry.log?10:54
mhr3oh wait, you had the perm issue earlier didn't you?10:54
tsdgeosi did10:54
mhr3so i guess you still do?10:54
tsdgeosno10:54
tsdgeoshttp://paste.ubuntu.com/7487972/10:55
tsdgeosthat was fixed somehow10:55
mhr3ok, it's saying the ss-proxy doesn't work10:55
mhr3so pastebin that pls10:55
tsdgeosmhr3: http://paste.ubuntu.com/7487977/10:56
mhr3see, still the perm issue :P10:56
tsdgeosok10:56
mhr3at least that's what the catalan message look like :)10:56
tsdgeosa chmod fixed it10:57
tsdgeoswhere do i open a bug so this doesn't happen again?10:57
mhr3lp:unity-scopes-api10:57
tsdgeosok, tx10:58
=== zequence is now known as GrumpyStudio
=== GrumpyStudio is now known as zequence
=== MacSlow is now known as MacSlow|lunch
Saviqgreyback, hey, sorry to be pushing, what do we do with the close fix branch?11:25
tsdgeosmhr3: ping again11:28
tsdgeosmhr3: Saviq: after all the get() changes only remaining comment's from mzanetti in the unity-api branch is http://paste.ubuntu.com/7488090/11:29
tsdgeoswhat do you guys think?11:29
Saviqtsdgeos, I think we should kill it with fire... but we probably can't, yet11:29
tsdgeosso just leave it be?11:30
Saviqtsdgeos, let's see what mhr3 says, but I'm afraid so...11:30
mzanettikill me with fire? :D11:30
mzanettigood thing there's lots of water around Malta11:30
Saviqwell, we could drop it from the shell API and deprecate it in the scope api in due course...11:30
Saviqmhr3, ?11:31
SaviqCimi, so what's the verdict for the carousel shadow?11:32
mhr3tsdgeos, Saviq, well we still need to send it to the scopes, and someone needs to provide it11:32
Saviqmhr3, no, we don't11:32
CimiSaviq, I am looking at the padding first11:33
Saviqmhr3, we really don't, not in the current meaning of form factor11:33
CimiSaviq, had to download and push few videos11:33
mhr3Saviq, you're free to rename it ;)11:33
Saviqmhr3, only I don't know what to rename it to, yet11:33
mhr3Saviq, but scopes should know what layout they're providing results for11:33
Saviqmhr3, what "layout"?11:33
mhr3Saviq, tv, touch, mouse11:34
mhr3i don't know11:34
Saviqmhr3, yeah, sure, but we can't define those yet11:34
mhr3but they specify the renderers, some might make more sense than others11:34
mhr3for specific layouts11:34
Saviqmhr3, doesn't feel convergent, tbh :P11:35
mhr3Saviq, convergence is about proper ui, right? :)11:35
Saviqmhr3, yeah, one that's not changing for no reason11:35
tsdgeosok, so ignore that for the moment i guess?11:35
mhr3and since scopes define renderers, they define ui11:36
mhr3so should be smart about it11:36
tsdgeosmhr3: do you feel like adding docu for roles or shall we convince mzanetti it will just say "result returns results"11:36
Saviqmhr3, well, then form factor doesn't give enough info anyway11:36
mhr3tsdgeos, i'd say add a FIXME, and it will be just a doc fixme11:37
Saviqmhr3, because 7" tablet would be the same as a 20" tablet11:37
tsdgeosmhr3: fixme for what?11:37
mhr3tsdgeos, "document what values are supported"11:37
Saviqmhr3, tsdgeos asked about model roles11:38
tsdgeosmhr3: can you do it since you know what you want to do? :D11:38
mhr3Saviq, tsdgeos, eh sorry, i was still talking about the formFactor11:38
mhr3if the roles need documenting, we're doing it wrong11:39
SaviqI agree11:40
mhr3ie the enum value is not good :)11:40
tsdgeosmhr3: so document the fixme for the formfactor and done?11:41
mhr3yep11:42
greybackSaviq: it needs a little updating against the short app Id change, and trying to fix as best as possible the issue you reported. Hopefully have something in a couple of hours11:42
Saviqgreyback, ok, just let me know if this is taking too much of your time (MAE higher prio)11:42
greybackSaviq: sure11:42
tsdgeosmhr3: ok, i'll do it11:42
mzanettitsdgeos: just saw this one in the MR: 9+ -- Albert Astals Cid <tsdgeos_work@xps> Thu, 15 May 2014 17:20:44 +020011:43
mzanettiI guess should be your canonical mail11:43
tsdgeosprobably11:43
mhr3alright, i have half day off today, so cya tomorrow11:45
=== mpt_ is now known as mpt
tsdgeosmzanetti: fixed11:46
CimiSaviq, ok so the delegate of the carousel video has empty space at the bottom11:59
SaviqCimi, fix it!11:59
CimiSaviq, I am :D11:59
SaviqCimi, tx11:59
CimiSaviq, looking to see if it comes from card11:59
=== alan_g is now known as alan_g|lunch
CimiSaviq, cardCarousel.components && cardCarousel.components["art"]["aspect-ratio"] || 1.012:01
CimiSaviq, this seems 1.0 in video carousel12:01
SaviqCimi, unlikely12:02
SaviqCimi, at least the scope sends 1.512:02
SaviqCimi, you can see in the scope tool12:02
CimiSaviq, TypeError: Cannot read property 'art' of undefine12:02
CimicardCarousel.components is undefined12:02
SaviqCimi, can we please not do IRC debugging again?12:02
CimiI'm live digging12:02
Cimiah ok12:02
CimiI like it12:03
SaviqCimi, get your own channel then ;P12:03
CimiSaviq, yeah but nobody will join >D12:03
SaviqCimi, yeah, that's 'cause it's really unproductive for the other party12:04
CimiSaviq, yes12:05
CimiSaviq, btw bug is fixed12:05
CimiSaviq, s/cardCarousel/cardTool/g12:05
Saviqgood12:05
Cimipushing soon12:05
SaviqCimi, testable?12:05
CimiSaviq, looks more like someone mistake12:05
Cimimaybe yeah,,,12:06
SaviqCimi, that's what tests are for ;)12:06
Cimiwe should test if the carousel tile width and height have same aspect ratio of the backend data12:06
Cimican be done with some objectName magic maybe, othewise aliasing properties12:07
Saviqtsdgeos, will you have a look at what Mirv reported about Qt 5.3 and your patch?12:10
Saviq/latefood12:11
CimiSaviq, ping me when you back12:13
Cimimhr3, you in the office one of these days?12:20
mhr3Cimi, wed probably12:20
Cimiok12:21
Cimimhr3, want to try my wifi card?12:21
Cimior flashing your bios together?12:22
mhr3Cimi, oh yea, do you want mine?12:23
mhr3Cimi, i can give you mine and try to do nasty things to yours :)12:23
Cimimhr3, not that I want yours12:23
Cimimhr3, mine works fine12:23
mhr3Cimi, but is it ac?12:23
Cimimhr3, nope12:23
mhr3Cimi, see, so you can have an upgrade12:24
Cimimhr3, but I don't have an AC ap anyway12:24
Cimimhr3, neither I know anyone with one12:24
mhr3give it few months :)12:24
mhr3but yea, i was trying to flash my bios back and forth and all the way around, but couldn't make it work12:25
mhr3the latest bioses have some stupid security features12:26
mhr3and i have a feeling that if i play a bit more with it, my laptop will just stop booting12:26
Cimiok >D12:26
Cimilet's try mine, otherwise send it back12:26
mhr3it won't just work out of box12:27
=== MacSlow|lunch is now known as MacSlow
mhr3there's only one wifi/wimax intel card that this laptop supports12:27
Cimiit could work12:27
mhr3but i could flash the epprom on the card ;)12:27
Cimihow do you know if a card is supportd or not?12:27
mhr3there's a list12:28
Cimilink12:28
Cimimhr3, my 5100 is bundled with some thinkpads, so it might be that it works12:30
mhr3Cimi, http://download.lenovo.com/parts/ThinkPad/ThinkPadEdgeE430_2012-04-10.pdf12:33
Cimimhr3, nothing basically :D12:34
mhr3pretty much :)12:34
Cimimhr3, https://www.diggloving.com/product_info.php?language=en&currency=GBP&products_id=2233 ?12:35
mhr3yea, that's the one intel it supports12:35
mhr3Cimi, but you still need to buy it from lenovo for about 25 pounds...12:37
mhr3so... yea12:37
greybackSaviq: close fix branch updated, please lemme know if I succeeded, or if I broke something else12:37
cwayne1Saviq: heya, is the whole removing "Preview" from the preview titlebar going to be discussed in Malta?12:37
SaviqCimi, back12:53
Saviqgreyback, ok, looking12:53
pstolowskisil2100, ping12:53
sil2100pstolowski: pong :)12:53
Saviqcwayne1, not sure, it might come up in the dash design session12:55
cwayne1Saviq: would you mind making sure it's discussed?  it looks not great when we send screenshots to partners and the preview title is cut off...12:58
Saviqcwayne1, hmm with the planned design it might get even worse https://sites.google.com/a/canonical.com/unity8dash/toolkit/14-previews12:59
Saviqcwayne1, since it's meant to hold content title after all13:00
Saviqcwayne1, that's not signed-off design, yet, though13:00
=== alan_g|lunch is now known as alan_g
Saviqcwayne1, in any case, I'll make sure to mention it, yes13:02
cwayne1Saviq: thank you13:04
=== pete-woods is now known as pete-woods-lunch
cwayne1Saviq: so next thing i have to bother you about :) any update on shell rotation?13:05
Saviqcwayne1, you can check the status out in https://launchpad.net/~unity-team/+archive/phone-right-edge13:06
Saviqcwayne1, there's rough edges, but just upgrading from that PPA should give you a rotating shell13:06
tsdgeosSaviq: sure i will13:08
cwayne1Saviq: do we plan on having it landed before MAE? or are we going to need to hack it again like MWC13:09
Saviqcwayne1, we'll need a custom image for sure13:10
Saviqcwayne1, but only one13:10
cwayne1daw13:11
CimiSaviq, sorry I am busy with the test13:18
SaviqCimi, nw, it's you who's asked me to ping when back ;)13:18
CimiSaviq, anyway I noticed that there is more padding above the carousel then at the bottom (in music)13:18
CimiSaviq, this is due to the sum of internal padding of carousel centering the items13:19
SaviqCimi, mhm13:19
CimiSaviq, plus the empty space of the header of the category13:19
Cimiin Music scope13:19
Cimi"Songs                                                       "13:20
Cimino idea how to best fix this13:20
Cimidesign wise...13:20
Cimiit doesn't look nice13:20
CimiSaviq, carousel has even padding top and bottom of tiles13:21
CimiSaviq, but at top you add the empty space next to the label13:21
Cimiwe should probably remove the carousel top padding13:22
Cimibecause we know we have the padding due to the label13:22
Saviqgreyback, only thing I didn't expect: upstart-app-stop does not remove the app from the list, but that's probably correct - until you remove it from the dash, it's meant to be restartable, even though the job goes away?13:23
greybackSaviq: nope, it should go away. Darn13:24
Saviqgreyback, orly?13:24
Saviqso you can distinguish "expected" stop vs. "unexpected" stop?13:24
greybackSaviq: how does a user stop an app from the CLI?13:24
greybackSaviq: upstart can distinguish those events13:25
Saviqgreyback, ok, so yeah, that'd be a problem still13:25
greybackso I broke something...13:25
greybackweird, I've a test for that and all13:26
Saviqgreyback, to make sure we're on the same page: https://code.launchpad.net/~gerboland/unity-mir/fix-upstart-closed-apps2/+merge/218721/comments/52552113:27
Saviqgreyback, that'd be the only thing, all the other issues are fixed!13:29
greybackSaviq: ack, on it13:29
=== _salem is now known as salem_
* greyback sees his test in wrong....13:37
greybackSaviq: what do you think it should do? Second opinion wanted :)13:37
kgunnmzanetti: phone right edge ppa looks likes its got all new goodies...i was gonna try, just checking if there was a reason i shouldn't ?13:42
Saviqgreyback, I *think* you're right, it probably should close13:42
mzanettikgunn: hit it!13:42
greybackSaviq: yep, I agree13:43
Saviqgreyback, it should only restart when upstart didn't expect it13:43
mzanettikgunn: it'll crash after screen blanking right now, and can't start apps currently.13:43
Saviqgreyback, basically, retcode !=013:43
mzanettikgunn: but it respawns if it crashes and it rotates13:43
greybackmzanetti: any idea why apps don't launch?13:43
Saviqmterry, first of all thanks for taking time out of your weekend to fix the conflicts13:43
mzanettigreyback: no. dandrader has the suspicion because of newer mir and we need to update something13:44
Saviqmterry, unfortunately it was a nail to your own coffin - I was able to test stuff ;)13:44
Saviqmterry, and found a bunch of issues that still need attention13:44
mterrySaviq, oh did you find a problem?  (Good ish?)13:44
Saviqmterry, https://code.launchpad.net/~mterry/unity8/split/+merge/21314913:44
greybackmzanetti: hmm ok13:44
dandradergreyback, has the launching scheme changed in the meantime (the way appids are handled, I don't know)13:44
dandrader?13:44
dandraderor the appid format13:44
mzanettidandrader: actually... it works here13:44
greybackdandrader: nothing that should break anything13:45
greybackany changes were backward compatible13:45
CimiSaviq, in the mock of fake_categories.cpp13:46
CimiSaviq, can you explain me if (index.row() < m_specialCategories.count()) at line 9713:46
mterrySaviq, OK, will comment in MP, thanks for the testing!13:46
Cimibasically why we have this if/else13:46
dandraderyeah. it's working. was able to launch gallery, system settings and phone app13:47
Saviqmterry, yeah, some things I'm sure are expected13:47
Saviqmterry, just wanted to write all down13:47
Saviqmterry, but there's a few blockers still13:47
SaviqCimi, IIUC it checks if it's not the last category13:47
dandraderbut not calculator13:48
CimiSaviq, dunno, I will copy to both if/else13:49
CimiSaviq, I want to play with different aspect ratio here13:49
Cimiand check in test DashContent13:49
=== salem_ is now known as _salem
Cimithe aspect ratios13:49
SaviqCimi, m_specialCategories is a QList that you can override in tests13:51
SaviqCimi, altho looks like it's not used any more13:51
SaviqCimi, ah no, it is13:51
SaviqaddSpecialCategory13:51
SaviqCimi, Apps is a special category13:51
SaviqCimi, I mean running apps in the Apps scope13:52
SaviqCimi, we need to inject that category to display the running apps (not for long, though! so we'll be able to get rid of all that)13:52
* mzanetti likes how launchpad estimates a build completed a minute ago while its still running13:54
=== _salem is now known as salem_
mzanettikgunn: hmm... I'd need to delete a package in the ppa (cause I messed up with versioning). What's your eta?13:58
kgunnmzanetti: i just flashed....so whenever, no rush13:58
mzanettikgunn: ok... then do the upgrade and let me know onces you fetched it13:59
=== dandrader is now known as dandrader|afk
CimiSaviq, in make tryDashContent, I have few empty categories14:00
CimiSaviq, do you have the same?14:00
SaviqCimi, doesn't look like it14:01
SaviqCimi, sounds like one of your renderers fails to parse14:01
Saviqkgunn, fyi, I cleaned up the old recipes we had in https://code.launchpad.net/~unity-team/+recipes14:03
kgunncool, thanks, it was a mess14:04
mterrySaviq, thanks so much for the testing!  I should have tested manta more recently.  Got complacent with mako14:04
mterrySaviq, but SIM unlocking is a pain, since I don't have a SIM that unlocks to test14:05
Saviqmterry, nw, I'm only just flashing now properly, will test there again14:06
Saviqmterry, you should be able to set a PIN in Android, or do you mean there are SIMs which don't support it at all?14:06
mterrySaviq, I'm sure there will still be some problems, since I haven't given malta the attention it deserves14:06
* mterry busts out his manta14:06
ehuHi! a little help please.  If you have user accounts authenticated with LDAP (say), and use nss tables other than passwd to store user information, then you find that the system automatically creates an entry in the user account database on login. This is handy: it means the user gets listed by lightdm in the greeter, for example.  However, these users cannot be deleted. If you use the accounts-daemon from the control center to remove them, you get that th14:13
ehue user isn't in /etc/passwd14:13
Cimitsdgeos, builddir/plugins/Dash/createCardComponent:40:51: Unable to assign [undefined] to QString where is that?14:13
tsdgeosCimi: the card creator14:15
Cimitsdgeos, yeah, but how do I get the line?14:15
tsdgeosit's there14:16
tsdgeosline 4014:16
tsdgeosobviously line 40 of the generated code14:16
tsdgeosyou'll have to print the generated code14:16
Cimitsdgeos, and where is the generated code?14:16
tsdgeosCimi: ?14:16
Cimilike CardCreator.createCardComponent(root, template, components);14:17
Cimiprinting this?14:17
Cimiouch... might be a lot14:17
tsdgeos./plugins/Dash/CardCreator.js:519:    return Qt.createQmlObject(code, parent, "createCardComponent");14:18
tsdgeosthat's where createCardComponent comes from14:18
CimiI found it btw14:18
tsdgeosCimi: anyway if this warning is the warning i think it's basically harmless14:19
Cimitsdgeos, it's14:19
Cimitsdgeos, borderSource: artShapeBorderSource; \n\14:19
tsdgeos?¿14:20
Cimitsdgeos, with property var artShapeBorderSource; - question is, where do we want to put the override check?14:20
Cimitsdgeos, I added this for the carousel, to remove the borderSource of the art ubuntu shape14:20
tsdgeosi know14:20
tsdgeosbut there can't be a \n\ in the generated code14:20
Cimitsdgeos, it is not generated, this is the js code14:21
Cimianyway14:21
tsdgeosyou don't understand14:21
Cimiwe need a default value14:21
tsdgeosthe line of the error is not the .js14:21
tsdgeosbut the generated code14:21
tsdgeosso don't look at line 40 of the .js14:21
=== dandrader|afk is now known as dandrader
Cimitsdgeos, and this js, generated the qml that causes the warning14:21
tsdgeoscorrect14:22
Cimitsdgeos, this is the js line that corresponds to line 4014:22
tsdgeosok14:22
tsdgeosyou made it pretty hard to understand ^_^14:22
=== alan_g is now known as alan_g|tea
Cimitsdgeos, now, I either put the default back at property var artShapeBorderSource: "";14:22
Cimitsdgeos, or I do borderSource: artShapeBorderSource || "";14:23
tsdgeosthat's both bad14:23
tsdgeosshould be the default value of artShapeBorderSource14:23
tsdgeosnot ""14:23
tsdgeosbut we don't have a way to get the default value of artShapeBorderSource14:23
Cimitsdgeos, default value in current ubuntu shape is "radius_idle.sci"14:24
tsdgeosso why would we set "" there as default?14:24
Saviqmzanetti, what happened in the PPA? I don't think you'll be able to upload a source that's older than the one in the PPA already14:25
mzanettiSaviq: I think after deleting the package it should work again...14:25
mzanettiSaviq: before I had the recipies I bumped the version a bit too much14:25
Cimitsdgeos, undefined complains14:25
Saviqmzanetti, mhm, I'm worried it will take a few hours to drop the previous source14:26
tsdgeosCimi: my suggestion is turn it into an alias or a dummy variable depending if you have art or not14:26
Saviqmzanetti, you might want to just bump the epoch...14:26
tsdgeosCimi: if you have art artShapeBorderSource aliases to artShape.borderSource14:26
tsdgeosotherwise artShapeBurderSource is just a int14:26
tsdgeosor a string or some other crap14:26
mzanettiSaviq: I deleted packages on friday already. was instant, but not sure if that really cleaned history in the background as well14:26
Cimitsdgeos, but what if artShape does not exist?14:26
mzanettiSaviq: good idea with the epoch14:27
tsdgeosCimi: if it doesn't exist, just let people set it and do nothing, it doesn't exist anyway ;)14:27
Cimitsdgeos, qml will complain, no?14:27
tsdgeos?14:27
tsdgeoswhy would it complain?14:27
Cimitsdgeos, setting alias to inexisting id14:27
Saviqehu, sounds like you should file a bug, or at least post to ubuntu-devel mailing list, it's going to be rather difficult getting a response here14:27
tsdgeosCimi: you are generating code, don't alias it to an existing id14:28
tsdgeosdo what i said and just create the variable as not an alias14:28
tsdgeoswhen there's nothing to alias to14:28
Saviqdandrader, re: "rotate application thumbnails in dash to follow shell rotation: INPROGRESS", keep in mind we should probably not rotate those that will only support one orientation14:29
=== pete-woods-lunch is now known as pete-woods
tsdgeosCimi: otoh i'm not sure you can alias to a loader item14:30
dandraderSaviq, once we have that information. There's also the case that shell should not rotate at all if the focused/foreground app does not support it14:31
Saviqdandrader, of course14:31
Saviqdandrader, just wanted to make sure we're on the same page14:31
ehuSaviq: thx14:40
dandradermzanetti, is the qt compositor ppa using ubuntumirclient or ubuntuclient QPA for apps?14:46
Cimitsdgeos, indeed doesn't find the id inside the loader14:46
mzanettidandrader: not the new one14:46
mzanettidandrader: greyback voted for keeping it with the old one for now.14:47
Cimihold on, artShapeLoader.item might work14:47
mzanettidandrader: however, the new one is installed along with the old one. you should be able to just export the env var to use the new one14:47
dandraderright14:47
mzanettidandrader: the fact that its installed right now is probably a bug, but you can use it for good14:47
greybackdandrader: mind testing lp:~gerboland/qtubuntu/qtCompositorCompatibility/ to see if it implements the core functional changes you made in ubuntuclient QPA?14:48
Cimitsdgeos, nope, alias doesn't work14:48
Cimitsdgeos, running out of ideas14:50
dandradergreyback, after I'm done with the tasks at hand14:54
greybackdandrader: sure14:55
tsdgeosCimi: this http://paste.ubuntu.com/7488876/ is a bit silly and recursive, but does it work?15:01
CimiborderSource: artShapeBorderSource || borderSource ?15:01
Cimican we do that? :D15:01
tsdgeosCimi: it looks kind of evil right?15:03
tsdgeos:/15:03
Cimitsdgeos, hah15:04
tsdgeosCimi: if it works we could have it15:04
tsdgeosCimi: the other solution is only ever doing the binding in the art level if we know we're going to set it15:05
dandraderI wanna check in javascript if a property exists (not check if it has an assigned value or anything like that). Will that do it? "if (item.propertyName != undefined)"15:05
=== gatox is now known as gatox_lunch
tsdgeosdandrader: for strict stuff better use the triplet comparers (i.e. === !==)15:06
Saviqdandrader, `if typeof foo !== "undefined"`15:06
Saviqdandrader, and in case of props15:06
Saviqdandrader, item.hasOwnProperty('foo')15:06
dandraderah, that's nice. thanks15:06
Cimitsdgeos, file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/UbuntuShape.qml:103:5: QML Shape: Binding loop detected for property "stretched"15:06
tsdgeosCimi: the other solution is defaulting to whatever ubuntu shape defaults15:06
tsdgeosCimi: but that's kind of bad if they change15:07
Cimitsdgeos, the latter is the new warning15:07
tsdgeosCimi: so i'd prefer you investigate the possibility of only generating the code when we know we're going to use it15:07
Cimitsdgeos, yes15:07
Cimitsdgeos, sucks though15:08
Cimitsdgeos, so in qml we don't have a way to default a property?15:09
dandraderSaviq, what about: if ("propertyName" in item)   (from http://www.nczonline.net/blog/2010/07/27/determining-if-an-object-property-exists/)15:10
tsdgeosnot that i know15:10
Cimiok15:10
Saviqdandrader, that's not only for properties, would be true for methods, too, for example15:10
Saviqdandrader, not sure hasOwnProperty would have the same issue TBH15:10
Saviqdandrader, but good enough15:11
Cimitsdgeos, Component.onCompleted { if (artShapeBorderSource !== undefined) borderSource = artShapeBorderSource; } ?15:12
Cimiworks here15:15
tsdgeoshmmm15:17
tsdgeosCimi: don't we set the bordersoure after comlpetion?15:17
tsdgeosi.e. it will never get any set?15:18
Cimitsdgeos, it is set in the loader of CardCarousel15:18
tsdgeosCimi: yes, after on loaded15:19
tsdgeosis that before on completed?15:19
Cimiapparently :D15:19
Cimiseems to work here15:19
tsdgeosCimi: can i see the patch?15:20
Cimihttp://paste.ubuntu.com/7488943/15:20
=== alan_g|tea is now known as alan_g
tsdgeosCimi: yeah seems loaded is before completed15:26
tsdgeosweird15:26
tsdgeosCimi: still if we're going to go that route15:26
tsdgeosCimi: i think it's better if you add a onArdShapeForcedSourceChanged15:26
tsdgeosand set it to the somethingLoader.item.borderSource15:26
tsdgeosif it's not null15:26
tsdgeoswhat do you think?15:26
Cimitsdgeos, onArtShapeBorderSourceChanged you mean?15:27
tsdgeosyes15:28
tsdgeostypos--15:28
tsdgeosi think it's less "racy" and a bit easier to understand15:29
tsdgeosyou can even add a comment there in why this is not a binding because we don't want to change the default bla bla15:29
tsdgeoswhat do you think?15:29
Cimitsdgeos, I am wondering if this is called before the item is loaded?15:32
tsdgeoswhat?15:32
tsdgeosthe onChanged?15:32
Cimitsdgeos, yes15:32
tsdgeosit has to be called every time it changes15:32
Cimitsdgeos, so artShapeLoader.item is not set15:32
tsdgeoswell so you check for it in the code15:32
tsdgeosor not15:32
tsdgeosi mean it's the same you do now15:33
Cimitsdgeos, now I do from the loader15:33
Cimitsdgeos, when it is loaded (completed)15:33
tsdgeosah right15:33
tsdgeosit's an async loader15:33
tsdgeossorry15:33
Cimitsdgeos, we can have both15:33
tsdgeosCimi: right, so have both15:34
tsdgeosin case someone changes it "later"15:34
tsdgeosor15:34
Cimiok15:34
tsdgeospropose a patch for ubuntushape so they expose their default bordershape value15:35
tsdgeosso we can do something like15:35
tsdgeosproperty var artShapeBorderSource: UbuntuShape.defaultBorderSource; \n\15:35
Cimitsdgeos, better not to ask more stuff for them15:35
Cimitsdgeos, first thing I want the new ubuntushape15:36
Cimithen this is an easy patch15:36
tsdgeosok :/15:38
greybackSaviq: 3rd time lucky? https://code.launchpad.net/~gerboland/unity-mir/fix-upstart-closed-apps2/+merge/21872115:39
Saviqgreyback, will do first thing tomorrow15:43
kgunndandrader: mzanetti ...i assume you guys already found the dash bug on rotation (like it changes scopes)15:43
greybackSaviq: thanks15:44
mzanettiI didn't, no... but not currently focusing on rotation15:44
dandraderkgunn, yes15:45
tsdgeosMirv: there?15:47
Mirvtsdgeos: here15:50
tsdgeosMirv: see https://code.launchpad.net/~aacid/unity8/useDisplayMargin/+merge/219709/comments/52566815:50
tsdgeosMirv: can you confirm that https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily/+packages doesn't carry my lp:~aacid/unity8/useDisplayMargin  changes?15:51
Mirvtsdgeos: ah, now the autobuild has overwritten it15:51
Mirvtsdgeos: yes15:51
tsdgeosok15:51
tsdgeosstill yes, the phone is crashing15:51
Mirvso I need to rebuild it15:51
tsdgeosi'll try to find out why tomorrow15:51
tsdgeosit's weird15:51
Mirvtsdgeos: but, I just heard from jhodapp that beta2 was crashing for him too, so it might be that it was not the unity8 patch that broke it, but that while waiting for it something else changed that broke stuff, for example the problem we have with unity*-api tests that requires a manual rebuild (just happening in qt5-beta2) or otherwise the build fails and falls out of sync with archive version15:52
tsdgeosMirv: i see15:52
tsdgeosMirv: do you want me to try to do some investigation?15:53
MirvI was meaning to look at it more today but I got stuck with qtpim, so I just now only launched the beta2 manual rebuilds15:53
Mirvtsdgeos: well any trying out of 5.3 woud be appreciated to have more idea on whether we have possibilities of migrating to it or not15:53
Mirvhopefully after this round of rebuilds in qt5-beta2 it works again, and then I can copy the rebuilds to qt5-daily too to have a separate PPA for testing the qtdeclarative + your unity8 branch15:53
Mirvso if the unity8 branch also works with 5.3, then stuff starts to be in better shape for getting an idea of how 5.3 looks like15:54
tsdgeosMirv: yeah on the desktop it works fine15:55
tsdgeosif i run my own compiled unity815:55
tsdgeosnot the ppa since it doesn't have the patch15:55
Mirvyeah I just pushed a new unity8 again to the qt5-daily15:55
tsdgeoscool tx15:56
Mirvand well I'll copy the rebuilds I put to beta2 to daily already now so that I won't need to wait15:56
tsdgeosok, so tomorrow i'll do another check on how it works on both desktop and phone and try to find out what's wrong if something fails/crashes15:56
Mirvthanks!15:56
MirvI also wasn't able to launch settings from indicator which I tried to use as a workaround when scopes were absent, but let's see how it is after the scopes start working15:57
=== gatox_lunch is now known as gatox
CimiSaviq, I have this to check aspect ratio http://paste.ubuntu.com/7489159/16:10
CimiSaviq, currently only testing a static 1.5 for all carousels16:10
CimiSaviq, how do I get the aspect ratio property of scopes? for this category?16:11
Ciminevermind, found a way16:17
CimiSaviq, I need lil help with C++16:22
CimiSaviq, I'd like to have artMap["aspect-ratio"] = "1." + index.row();16:22
Cimiso 1.1, 1.3, 1.5...16:23
CimiartMap["aspect-ratio"] is a char*16:23
CimiI am trying to look for concatenation operator  in C++ and I only see to use strings16:23
CimiI was wondering if you know a trick16:23
=== dandrader is now known as dandrader|lunch
=== salem_ is now known as _salem
CimiSaviq, got it to work with QString, let me know if it is fine for fake_categories.cpp http://paste.ubuntu.com/7489256/16:40
=== alan_g is now known as alan_g|EOD
=== dandrader|lunch is now known as dandrader
dandraderSaviq, what's the idea of this "nonmirplugins"?17:30
dandraderin tests/mocks/Unity/Application17:30
mzanettiWellark: hey17:41
mzanettiWellark: https://code.launchpad.net/~mzanetti/unity8/lockscreen-enhancements/+merge/22011817:41
mzanettidandrader: can I help regarding the mockApplicationManager?17:41
dandradermzanetti, yeah, I was thinking about moving the Unity.Application mock to Mir.Application. but when looking at tests/mocks/Unity/Application/CMakeLists.txt I was puzzled at this NonMirUnityApplicationQml lib and the nonmirplugins dir17:44
* mzanetti takes a look17:44
mzanettidandrader: that's strange indeed. But I guess the idea is to have this around in case you want to run the shell on anything non-mir17:46
mzanettidandrader: say you really need to test it on surfaceflinger for some reason, you could use this to start it17:46
greybackdandrader: hey, I've found a crash bug in qtmir's QtEventFeeder - the volume up/down & power key codes are not in the kkeyCode table17:46
greybackdandrader: was there any reason you didn't use xbk stuff there?17:47
dandradergreyback, no. that key code table is essentially a copy&paste from qtubuntu. Also, I know next to nothing about xkb17:48
greybackdandrader: ok.17:48
greybackI'll see what I can do17:48
mzanettiI'm still not sure why we want to rename the plugin from Unity.Application to Mir.Application17:50
mzanettiI mean, isn't the idea of unity-api somehow that we could replace the plugin with another implementation and it still would work?17:50
mzanettiand it's in fact Unity's application plugin, which just happens to implement a Mir backend17:51
greybackmzanetti: my thinking behind the rename is to indicate the plugin is not Unity specific, but can be used by other shells. But yeah, in basing it on unity-api, we contradict ourselves17:53
greybackmzanetti: but for now, I don't think the rename needed17:53
mzanettigreyback: it kinda is unity specific, no?17:53
greybackmzanetti: dandrader sounds like a chat to have next week ;)17:53
mzanettigreyback: probably not the libmirserver behind it17:54
greybackmzanetti: if we want to upstream this, we don't want it to be unity specific17:54
mzanettigreyback: sure... but that would the libmirserver/libmirclient, not the plugin, no?17:54
greybackmzanetti: without the plugin, it's not a shell. It can't do anything, start/stop apps, get & control surfaces...17:55
mzanettihmm... fair enough17:55
mzanettiin which case, Unity.Application would be wrong17:56
mzanettiok well... its not urgent anyways... lets discuss that in Malta17:56
greybackmzanetti: dandrader: I pushed a fix for qtmir crashing with screen blank, let me know if it causes issues18:34
dandradergreyback, ok, good18:34
mzanettigreyback: dandrader: the ppa is automatically built daily if there are changes. You both should have permissions to kick builds more often if you need so.18:35
greybackmzanetti: magic! Was just about to write a recipe :)18:35
mzanettigreyback: all there18:35
mzanettigreyback: https://code.launchpad.net/~unity-team/+recipe/qtmir-qtcompositor18:35
greybackdandrader: just a note, best to use the ./run.sh script in unity8, as that sets all the vars unity8 needs to run properly18:36
greybackif you run unity8 as usual user, it'll crash on screen blank with hwc error - this harder to fix, will take longer18:36
dandradermzanetti, does Ubuntu SDK have the equivalent of a combo box (a component where you select one out of N available options)18:47
mzanettidandrader: OptionSelector18:48
dandradermzanetti, ah, nice18:49
dandraderinterestingly it's not listed here: http://developer.ubuntu.com/api/qml/sdk-1.0/Ubuntu.Components/18:49
dandraderbut here http://developer.ubuntu.com/api/qml/sdk-1.0/Components.Components.OptionSelector/18:49
dandraderprobably a documentation bug18:49
mzanettidandrader: yep. can you report it to the SDK?18:50
mzanettidandrader: also the example says "import Components.Components 0.1" :)18:52
dandradermzanetti, https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/132098518:54
ubot5Ubuntu bug 1320985 in Ubuntu UI Toolkit "OptionSelector documentation does not show up in the proper page" [Undecided,New]18:54
mzanettidandrader: confirmed. Yes. this is the right place to report the bug18:56
mterrySaviq, how did you set your locale which shows different in greeter and shell?  Setting to "spain" or some non-US locale didn't do it for me18:59
=== dandrader is now known as dandrader|aflk
=== dandrader|aflk is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
josharenson1kgunn, for performance testing w/ shell rotation... Do you just want glmark2 numbers w/ unity8 runnint?19:51
josharenson1running*19:51
=== josharenson1 is now known as josharenson
kgunnjosharenson: yeah...19:56
kgunnjosharenson: i suppose it won't matter a bit...other than testing out plugin compositor, which expect will mean nothing to glmark219:57
josharensonkgunn, yes I wouldn't expect any differences really19:58
kgunnjosharenson: but than we can say "we did it" :)19:59
kgunnyou know the deal19:59
josharensonkgunn, :-) im on it19:59
josharensonkgunn, during rotation the shell peeks through the fullscreen benchmark for a frame20:18
josharensonkgunn, i think ive seen this before... not sure if its a real problem or not20:18
kgunnjosharenson: noteworthy...if the numbers are in the neighborhood its fine20:18
josharensonkgunn, sure...20:19
=== zequence_ is now known as zequence
=== naee is now known as eean

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!