[01:02] wgrant: can you look at what I have and explain to me what your wanting things to look like please? [01:02] with all your changes, I'm not sure that I know [01:06] cjohnston: My branch doesn't impact publish-ic-link at all [01:06] I only changes stuff inside the diff table. [01:06] correct... [01:06] I'm talking about your branch [01:07] Oops, missed the fact that the MP you linked was more than two hours ago, not relevant to this convo. [01:07] Looking [01:08] cjohnston: What do you have? [01:08] I don't see a branch. [01:08] wgrant: I have it up (plus one small change) at 162.213.35.40 [01:08] https://code.launchpad.dev/~name16/myproject/team/+merge/1 [01:10] cjohnston: The main issue I see is the width. [01:10] cprov's comment blows things up, and opening a draft comment (at least in Firefox) has ridiculous padding on the right. [01:11] what ? who ? me ? [01:11] Oh [01:11] yes, you [01:11] cprov's comment is actually fine, until the draft super-padding appears. [01:11] wgrant: so, the IC's, should they be 100% of the table.diff width? [01:14] cjohnston: I deliberately added some horizontal margin to make the comments not just look like another line of the diff. [01:14] My intent (feel free to do something less terrible) was to have them always fit inside the normal diff width [01:15] That all works well until you invoke a draft editor [01:15] The editor isn't meant to change the width at all. [01:15] ok.. so you like the width as it is.. [01:15] (except the edit) [01:15] It's marginally the least bad so far, IMO. [01:16] But I'm very much open to suggestions. [01:16] And it's easy to change now we're not tied to the table-based layout. [01:16] personally, I liked it the way it was.. but as we aren't designers, I don't care to play for hours on this [01:17] It was really hard to see the comments in the old one. [01:21] I want a new icon for adding a comment [01:21] I don't like that one [01:21] (not your fault, just my opinion) [01:28] Oh yeah, that's by no means even vaguely final, I just needed one to throw in the CSS for experimentation. [01:28] And I remembered the name of that one :) [01:29] lol [01:36] wgrant: can you check qastaging mbox ? there should be a MP email with non-ascii diff content. [01:37] cprov: There are errors, rather [01:37] See #launchpad-ops; DB perms not there yet. [01:37] putz [01:41] cprov: Fixed now, can you try again? [01:41] I just ran an ASCII one through, and the email worked fine. [01:42] brb [01:43] done [02:02] > +Now let's mess with encoding áéíóúçã [02:02] > [02:02] zoing! [02:02] > [02:03] cprov: Looks good [02:03] wgrant: great! === jml_ is now known as jml === jtv_ is now known as jtv === timrc is now known as timrc-afk === timrc-afk is now known as timrc [13:44] wgrant: any chance you can look at adding a draft comment on my instance? [13:49] cjohnston: ! [13:49] It looks like not totally terrible [13:49] Well done [13:50] I just s/edit/add for the button, if you refresh you should be able to see that [13:50] I think that's slightly better than edit [13:50] Indeed [13:51] what other changes are needed for this branch? [13:57] cjohnston: We should monospace and fix the word breaking in the comments if possible. [13:58] cjohnston: word-wrap: break-word; works if the div is width-constrained. Somehow convincing it to not extend outside the table would work. [14:23] yo [14:24] hey daker [14:25] wgrant: hi [14:27] technically you can't set the width to px since launchpad is using a fluid layout (% & auto so no fixed width) [14:27] i those cases, i think we can use "calc" [14:27] in* [14:28] calc(100% - Xpx) [14:28] width : calc(100% - Xpx); [14:34] daker, cjohnston: Or what about setting table-layout: fixed on table.diff, and then a fixed px or % width on table.diff .line-no? [14:34] That'll prevent the comment divs from causing the table to expand. [14:35] cjohnston: can you test that ? [14:35] Throw in a font-family: monospace and a word-wrap: break-word on the comment bodies, and it starts to look at bit more sane. [14:35] The only real problem with that approach is that the line-no column is no longer dynamically sized, but that's a bit weird anyway. [14:38] wgrant: how's that look? === Ursinha is now known as Ursinha-afk [14:45] cjohnston: Not bad! The line-no needs to be able to cope with up to four digits plus space for the icon, but that's a trivial tweak. [14:47] do you know how big that would need to be? [14:48] and what happens when people give you 10000 + line MPs? ;-) [14:48] I think we trim it after like 10000 lines === Ursinha-afk is now known as Ursinha [15:13] wgrant: would the problems from last night effect branch scanning at all? [15:14] cjohnston: At the moment? No. [15:14] just LP being slow [16:03] cjohnston: !! it finally scanned [16:03] yay! [16:16] wgrant: just pushed a new rev.. now the big question... will it scan. lol [16:16] The button text doesn't show up in other places. Can you find out why? [16:16] We shouldn't be hiding it with an outrageous text-indent :) [16:18] lbox propose gives me this error: error: Failed to update merge proposal log: Server returned 401 and body: (, 'description', 'launchpad.Edit') - no idea, what's it about, though.. [16:18] tasdomas: You don't have permission to edit that merge proposal. [16:19] wgrant, you mean the merge proposal on launchpad? [16:20] tasdomas: Correct. [16:20] wgrant, how can that be possible? (or, in other words, what do I do to fix this?) [16:22] wgrant: and their is a nasty bug in caused by the help modal [16:22] tasdomas: Should you have permission to edit that merge proposal? Which is it? [16:23] wgrant, https://code.launchpad.net/~tasdomas/juju-core/ensure-availability-more-output/+merge/220306 [16:24] return (user.inTeam(self.obj.registrant) or [16:24] user.inTeam(self.obj.source_branch.owner) or [16:24] self.forwardCheckAuthenticated( [16:24] user, self.obj.target_branch) or [16:24] user.inTeam(self.obj.target_branch.reviewer)) [16:24] Are you sure your client was authenticated as the correct user? [16:30] wgrant, sorry to have bothered you - it was my own mistake [16:31] but your replies pointed me in the right direction [16:32] tasdomas: What was the issue? [16:32] Wrong MP URL, or wrong creds? [16:32] wrong creds [16:32] Ah, great :) [16:36] cjohnston, cprov: I'll be back in a few hours, please try to poke holes in inline comments. [16:36] Night [17:07] Is there some documentation somewhere of how to upgrade local development Launchpad instances to PostgreSQL 9.3, so that we can stay in sync with production? [17:41] cjwatson: The production docs would walk you through it, but I suspect the pg_upgradecluster provided by the Debian package would work a treat. === timrc is now known as timrc-afk [17:43] cjwatson: https://pastebin.canonical.com/110495/ is the current draft for the production upgrades === timrc-afk is now known as timrc [17:44] Thanks. Will have a try tomorrow, maybe ... [19:31] cprov: r17011 qa-ok === broder_ is now known as broder [23:53] cjwatson: You can also just pg_dropcluster 9.1 main, install launchpad-database-dependencies-9.3, purge postgresql-9.1, and then rerun utilities/launchpad-database-setup and make schema