| waigani | thumper: ping | 01:25 |
|---|---|---|
| waigani | thumper: emailed you my question | 01:29 |
| thumper | ok | 01:33 |
| thumper | waigani: you need to cast it to what you know it is | 01:34 |
| waigani | oh, so simple | 01:34 |
| wallyworld | mramm: can i get editing perms for that doco? | 01:43 |
| axw | wallyworld: what is the card "mass provider picks maas name using placement" ? | 02:18 |
| axw | wallyworld: I already implemented maas-name placement | 02:18 |
| axw | is there something missing? | 02:19 |
| wallyworld | axw: i got that from the next steps on a previous mp | 02:19 |
| wallyworld | maybe it's been done | 02:19 |
| wallyworld | all those 4 cards are from the same source | 02:19 |
| axw | probably talking about supporting it in "juju deploy --to" and "juju add-unit --to" | 02:20 |
| wallyworld | yeah | 02:20 |
| axw | I spoke with William at Vegas about placement, and he reckoned we should just stick with machine-id in those commands for now | 02:20 |
| wallyworld | ok | 02:21 |
| wallyworld | feel free to update the cards as necessary | 02:21 |
| axw | supporting placement in those is a little trickier | 02:21 |
| axw | ok | 02:21 |
| wallyworld | i just wanted to capture out of the mp the next steps | 02:21 |
| axw | wallyworld: going o delete the maas-name one, since that's done. anything remaining is provider-independent | 02:23 |
| wallyworld | sounds good | 02:23 |
| axw | I'm going to prod my AZ changes along at the same time as this address stuff | 02:24 |
| wallyworld | ok | 02:26 |
| * thumper has hit friday afternoon itis | 03:12 | |
| * thumper makes a sad face | 03:57 | |
| thumper | ugh... | 03:57 |
| bodie_ | on that note, if anyone feels like having a look at this to see why $schema values are causing nil exceptions in gojsonschema, input would be welcome | 04:04 |
| bodie_ | https://codereview.appspot.com/94540044 | 04:04 |
| bodie_ | I'll be looking at it tomorrow | 04:04 |
| bodie_ | going to bed in a minute here | 04:04 |
| === vladk|offline is now known as vladk | ||
| jcw4 | Anyone wanna chat about logging / mongo and the state package? | 05:22 |
| bodie_ | https://codereview.appspot.com/94540044 fwereade mgz | 05:22 |
| jcw4 | I'm working on adding a 'results' collection for Actions, and if I'm reading it right the 'log' collection on watchers is in a separate mongo db from the state db? | 05:23 |
| jcw4 | okay.. I see now there are 3 db's: juju, presence, and admin | 05:31 |
| jcw4 | and I now see that the watcher logs are on the juju db | 05:48 |
| === Ursinha-afk is now known as Ursinha | ||
| === vladk is now known as vladk|offline | ||
| wallyworld | axw: i have to go to soccer so won't get to look at your branch before i got, i'll look when i get back later if it's still unreviewed | 06:51 |
| axw | wallyworld: thanks | 06:52 |
| axw | no particular rush | 06:52 |
| axw | I'm going to work on manual AZ support now | 06:52 |
| wallyworld | ok | 06:56 |
| wallyworld | you might be EOD before I get back so have a good long weekend :-) | 06:56 |
| axw | thanks wallyworld . enjoy soccer | 07:03 |
| === Ursinha is now known as Ursinha-afk | ||
| fwereade | jcw4, if you're still around, I can talk about it: I suspect if you're needing to look at the log collection you're doing it wrong somehow | 07:11 |
| fwereade | axw, just responding to your review | 07:11 |
| axw | fwereade: thanks | 07:12 |
| fwereade | bodie_, I might not get to that in time for this evening, hopefully mgz will though | 07:13 |
| === Ursinha-afk is now known as Ursinha | ||
| fwereade | axw, so, I wrote you an essay: https://codereview.appspot.com/102860043/ | 07:36 |
| fwereade | mgz, are you around? in dimitern's absence I'd like what clarity you can provider on container addresses -- see my comment in that review ^ | 07:37 |
| axw | fwereade: thanks. when I said "relation unit in state", I really meant the scope doc (but that doesn't invalidate anything) | 07:38 |
| fwereade | axw, I don't think the unit wants to watch its own scope/settings docs though | 07:39 |
| fwereade | axw, it wants to watch something else, and the settings only get updated according to the unit's having responded to those changes, detected elsewhere | 07:39 |
| fwereade | axw, anyway, I'm going to make some coffee and have a ciggie; ping me when you're ready to talk and I'll be there soon | 07:40 |
| axw | fwereade: thanks, I'll just digest this first | 07:41 |
| axw | fwereade: cool, it all makes sense. I kinda came to the same conclusion, after assuming that we could allow the RU to enter scope first. you mentioned the addresses-watching worker the other day, but it didn't click at the time | 07:44 |
| === lazyPower is now known as lazypower-travel | ||
| fwereade | axw, also I suspect we already have the seed of that worker underway, because the networker is going to be responsible for setting up the machine's networks in the first place; having it update the machine with its addresses seems entirely natural to me | 07:55 |
| * axw nods | 07:55 | |
| fwereade | axw, btw, is there anything new for review in that or can I wip it? | 07:58 |
| axw | fwereade: nope, it can go to WIP | 07:58 |
| fwereade | axw, (btw, if you want to propose that driveby cleanup on its own I would look favourably on such an endeavour :)) | 07:58 |
| axw | certainly | 07:59 |
| axw | fwereade: not sure what else there is to discuss, but I am free now if you want to chat still | 08:00 |
| fwereade | axw, the main thing that's on my mind is whether we can and/or should combine the relation model with the exposure model, and if so what it'd take to do so | 08:01 |
| fwereade | axw, but that's not directly relevant to what you're doing | 08:01 |
| axw | fwereade: frankly I don't think I know enough to have any useful input on that right now | 08:01 |
| axw | maybe once I've gotten through the initial bits I will | 08:02 |
| fwereade | axw, yeah, nobody does really tbh, I should probably find a cuddly toy and explain my thoughts to them and see if I still think they're a good idea afterwards | 08:03 |
| axw | ;) | 08:03 |
| voidspace | Morning all | 08:13 |
| === vladk|offline is now known as vladk | ||
| axw | morning void | 08:20 |
| axw | voidspace rather | 08:20 |
| * axw looks into the void | 08:20 | |
| mgz | fwereade: I'll take a look | 08:24 |
| voidspace | axw: you know what they say - the void looks back | 08:28 |
| axw | heh :) | 08:31 |
| fwereade | axw, https://codereview.appspot.com/99660047/ LGTM but might benefit from a gentle massage to move some of the functionality to slightly more natural-feeling places | 08:51 |
| fwereade | axw, let me know if the review doesn't give enough direction | 08:51 |
| fwereade | wallyworld, hey, are you around? I wanted to talk about md5 vs sha256 | 08:52 |
| axw | fwereade: thanks, sounds fine | 08:53 |
| axw | fwereade: my predilection for methods is to avoid polluting the namespace, but I understand the desire to keep methods near their types too | 08:54 |
| fwereade | axw, one thing that floats around my mind is the idea that the functionality that depends entirely on the exposed interfaces of exposed types should probably be kept separate from the stuff that needs access to the internals | 09:09 |
| axw | fwereade: yeah, that makes sense | 09:09 |
| fwereade | axw, it's tricky especially in go, though, because if you want to use them in-package (which you very often do) you can't move them out (lest import cycles) and therefore you can't actually enforce those boundaries | 09:09 |
| fwereade | axw, but free funcs in their own files are probably the closest we have | 09:10 |
| fwereade | axw, (or ofc you can explode the package into a *load* of smaller packages but that's often a dauntingly big job even for a small package, and with something like state it's devastatingly hard | 09:11 |
| fwereade | ) | 09:11 |
| axw | yeah, I'll just go with free funcs ;) | 09:12 |
| niemeyer_ | <mikespook> `Added charm "cs:precise/ntpmaster-3" to the environment. | 10:01 |
| niemeyer_ | <mikespook> ERROR cannot assign unit "ntpmaster/0" to machine: cannot assign unit "ntpmaster/0" to new machine or container: cannot assign unit "ntpmaster/0" to new machine: use "juju add-machine ssh:[user@]<host>" to provision machines` | 10:01 |
| niemeyer_ | That's a pretty bad error message | 10:01 |
| === niemeyer_ is now known as niemeyer | ||
| fwereade | niemeyer, it is, isn't it :/ do we have a bug fior it? | 10:09 |
| fwereade | niemeyer, we definitely ought to catch that case earlier, regardless -- axw, are you still around? | 10:10 |
| niemeyer | fwereade: That seems rooted on how these new error helper libraries work.. I bet this is not the only one | 10:10 |
| fwereade | niemeyer, it's rooted in the old way of doing things, actually, it's a balance it's been difficult to maintain across the board | 10:11 |
| fwereade | niemeyer, I have pretty high hopes that they'll help us present clearer error messages to users but record the context usefully as well | 10:12 |
| fwereade | niemeyer, nobody ever said that too much annotation is not a problem when it leaks up to the user | 10:12 |
| fwereade | dimitern, would you take a look at https://codereview.appspot.com/102860043/ and contribute your understanding of how we'll be handling the container-address/machine-address issues? | 10:13 |
| niemeyer | fwereade: The problem is not just leaking to the user.. this is adding the same annotation repeatedly, which isn't helpful to developers either | 10:13 |
| fwereade | niemeyer, quite -- it's a failure to annotate helpfully, which is orthogonal to the mechanism we use for annotation | 10:14 |
| niemeyer | fwereade: It might be orthogonal, or it might not | 10:14 |
| niemeyer | fwereade: If you stipulate that every level should annotate, this encourages developers to add boilerplate to fill up the form | 10:15 |
| fwereade | niemeyer, and fwiw it's not *quite* the same annotation each time -- it does give you a trail of breadcrumbs that helps me as a developer see how we came to be in that situation | 10:15 |
| fwereade | niemeyer, this is not a defence of the UX, or of the particular sequence of messages | 10:16 |
| fwereade | niemeyer, on a separate note, I was thinking I would grab a lift from cath when she comes into town this pm, so I could come and see you -- do you have any time this pm? | 10:21 |
| fwereade | niemeyer, and this evening I was thinking of going into floriana (easy frequent bus ride from sliema) for http://www.whatson.com.mt/en/home/events/9093/ghanafest-2014.htm?fb_action_ids=10152073938286851&fb_action_types=og.likes&fb_ref=.U4gRG8XT_7Q.like (if you or anyone else might be interested) | 10:22 |
| fwereade | niemeyer, I have no idea if it's any good | 10:22 |
| niemeyer | fwereade: Oh, that looks nice | 10:23 |
| niemeyer | fwereade: Yeah, pm is mostly free, besides a few events | 10:23 |
| fwereade | niemeyer, ok, I'll probably get to the meridien a bit after 3 | 10:27 |
| niemeyer | fwereade: Cool | 10:29 |
| wwitzel3 | fwereade: I was wondering if you would pair with me on a review at some point today. I find it beneficial to do a review, thinking out loud, and then watch someone else do the same review. | 10:35 |
| dimitern | fwereade, looking | 10:36 |
| fwereade | wwitzel3, it would be a pleasure, we should do it in the next 2 hours or so, but not right now I think, I need a bit of a lunch break | 10:37 |
| wwitzel3 | fwereade: at your convenience, just ping me | 10:38 |
| voidspace | wwitzel3: morning | 10:38 |
| fwereade | wwitzel3, it would be great if you would take a pre-look at https://codereview.appspot.com/92610043/ https://codereview.appspot.com/100810045/ https://codereview.appspot.com/94540044/ in the meantime -- and if you can come up with comments please go ahead and post them | 10:39 |
| wwitzel3 | voidspace: morning :) and any break on that precise regression? | 10:39 |
| voidspace | wwitzel3: nope, although I have one indication it may just be a timing issue - I wonder if sleeping and retrying would help :-) | 10:39 |
| fwereade | wwitzel3, regardless it will be good if you have a bit of context loaded for them before we begin | 10:39 |
| voidspace | wwitzel3: http://efreedom.net/Question/1-9992535/Azure-MongoDB-Replica-Sets-Initialization-Error-Localoplogrs-Empty | 10:39 |
| voidspace | There was no problem at all. This exception is normal behavior. Just need to wait couple of seconds and replica set will be initialized. | 10:40 |
| voidspace | - See more at: http://efreedom.net/Question/1-9992535/Azure-MongoDB-Replica-Sets-Initialization-Error-Localoplogrs-Empty#sthash.sbXHTaFd.dpuf | 10:40 |
| voidspace | Hah, original reference for that: http://stackoverflow.com/questions/9992535/azure-mongodb-replica-sets-initialization-error-local-oplog-rs-is-not-empty | 10:40 |
| wwitzel3 | fwereade: indeed | 10:40 |
| voidspace | or maybe even that the replica set is already initialized | 10:41 |
| voidspace | we see many logging lines of the same failure - maybe we're trying to initiate multiple times | 10:41 |
| dimitern | TheMue, vladk, fwereade, standup? | 10:45 |
| voidspace | I have to nip out for an early lunch | 10:48 |
| voidspace | biab | 10:48 |
| === Ursinha is now known as Ursinha-afk | ||
| === vladk is now known as vladk|offline | ||
| wallyworld | fwereade: i am now | 11:19 |
| wallyworld | i used md5 cause it was native in gridfs, but can change it | 11:20 |
| === Ursinha-afk is now known as Ursinha | ||
| wallyworld | fwereade: just ping me if you want to chat | 11:33 |
| perrito666 | hi ppl | 11:41 |
| === vladk|offline is now known as vladk | ||
| natefinch | morning | 11:42 |
| hazmat | g'morning | 11:47 |
| fwereade | wallyworld, bugger, my schedule is becoming problematic | 11:52 |
| fwereade | wallyworld, did that review make any sense to you? | 11:52 |
| fwereade | wallyworld, I fear it was a bit light on direction | 11:52 |
| fwereade | wallyworld, mainly I really want us to get the existing storage api in place against gridfs before we try to build in the content-addressability stuff | 11:53 |
| fwereade | wallyworld, or at least deduplication, sorry, my brain is firing on relatively few cylinders today | 11:54 |
| wallyworld | fwereade: the gridfs storage is already impelemnted | 11:56 |
| wallyworld | this is the next step | 11:56 |
| wallyworld | i also considered pulling out a separate txn type base class but wanted to wait till see how it evolved | 11:57 |
| wallyworld | there's a few more brnaches to go | 11:57 |
| wallyworld | the next step will be a ManagedResource service which uses ResourceCatalog and ResourceStorage to provide an exported, authenticated storage manager which handles dups etc | 11:59 |
| wallyworld | we probably need to talk face-face. if you get a break in your schedule, ping me or we can do it later, whatever suits | 12:00 |
| sinzui | voidspace, I am rebooting juju-ci-vapour.ws; my last desperate effort to address the lxc deploy issue | 12:56 |
| * sinzui waits for jenkins to return | 12:58 | |
| perrito666 | sinzui: still not able to reproduce that somewhere else? | 12:59 |
| sinzui | perrito666, I have tried else where, but I played over revisions of juju and the test passes. | 13:00 |
| * sinzui rebuilds after upgrade and restart | 13:01 | |
| rogpeppe | so... import aliases: import (coretesting "launchpad.net/juju-core/testing"; jujutesting "launchpad.net/juju-core/juju/testing"; ???? "github.com/juju/testing") | 13:33 |
| rogpeppe | oh yeah, i missed: stdtesting "testing" | 13:34 |
| dimitern | and apiservertesting as well :P | 13:34 |
| rogpeppe | any suggestions for github.com/juju/testing. i'm currently using gitjujutesting. | 13:34 |
| wwitzel3 | is the github package specific to juju or just living in that org namespace? | 13:35 |
| rogpeppe | wwitzel3: it's under juju control, but it's not specific to -core | 13:35 |
| rogpeppe | wwitzel3: i believe that juju-core/testing will continue to exist | 13:36 |
| rogpeppe | ha, envtesting, toolstesting | 13:38 |
| wwitzel3 | rogpeppe: I haven't explored, but I've always wondered the difference between juju-core/testing and juju-core/juju/testing | 13:38 |
| rogpeppe | wwitzel3: the former can be used by lower level packages - it doesn't import state | 13:38 |
| wwitzel3 | rogpeppe: ahh, ok | 13:38 |
| wwitzel3 | ugh yuck | 13:39 |
| wwitzel3 | rogpeppe: no matter what you do, you won't like it | 13:40 |
| wwitzel3 | rogpeppe: does that help? lol | 13:40 |
| rogpeppe | wwitzel3: lol | 13:41 |
| wwitzel3 | I guess my initial reaction was to name the gh/juju/testing package something else | 13:41 |
| wwitzel3 | rogpeppe: also I really hate that we alias the go stdlib testing package as stdtesting .. if anything should just be testing, it should be the stdlib package, but I digress. | 13:43 |
| wwitzel3 | rogpeppe: I guess gitjujutesting .. it will only make your eyes bleed occasionally | 13:43 |
| wwitzel3 | if we just stopped writing tests this wouldn't be a problem ;D | 13:44 |
| wwitzel3 | rogpeppe: you could name it something like .. yatp | 13:47 |
| wwitzel3 | moartesting | 13:47 |
| jcw4 | fwereade: wrt. the log collection, I was just trying to understand where actionResults would go. It seems clear now that it would be a collection in the juju db in mongo | 13:52 |
| perrito666 | hey, perhaps some of you might find this useful, patches are welcome, it is a pretty quick hack https://github.com/perrito666/golazytools/blob/master/gogrep | 13:53 |
| jcw4 | and probably held in the state struct like actions too | 13:53 |
| natefinch | wwitzel3, voidspace: standup? | 14:02 |
| wwitzel3 | natefinch: yep, thanks | 14:02 |
| fwereade | jcw4, yeah, I think it's just another collection, like actions | 14:08 |
| bodie_ | morning all | 14:08 |
| fwereade | bodie_, heyhey | 14:08 |
| jcw4 | fwereade: yeah. I started looking for logs 'cause it was the closest analog I could think of, and noticed that the watchers had their own mgo.Collection on them, and that's what led me astray | 14:09 |
| jcw4 | hi bodie | 14:09 |
| fwereade | jcw4, yeah, the logs are really at a level below state | 14:09 |
| jcw4 | fwereade: I think I'm clear on where the collection should be now, but I'm not sure how much detail to put in the results... timestamp, unit?, output, error?, running time? etc. etc. | 14:11 |
| mgz | jcw4: good questions | 14:12 |
| mgz | all of htat sounds good, I'm not sure on the form of the unit link though | 14:14 |
| jcw4 | mgz: I suppose we can start light just action name, unit id?, and output, and then add more detail later as needed? | 14:14 |
| jcw4 | mgz: yeah, globalKey? u.doc.Name? etc. | 14:14 |
| jcw4 | mgz: encoded in _id like the actions collection | 14:14 |
| bodie_ | okay, I'm going to see about getting the next steps plugged in, I guess an Actions() method on the Charm interface | 14:19 |
| jcw4 | bodie_: sounds good to me | 14:20 |
| bodie_ | anyone have a few spare cycles to give me a quick LGTM on https://codereview.appspot.com/94540044 ? | 14:21 |
| bodie_ | I think we've just about beaten out every possible flaw there, heh | 14:21 |
| bodie_ | unless fwereade has input about whether to move the yaml back to global scope | 14:21 |
| bodie_ | or to a file? | 14:21 |
| mgz | bodie_: I wouldn't go *that* far :) | 14:21 |
| bodie_ | lol | 14:22 |
| jcw4 | "that far" being "beaten out every possible flaw"? | 14:22 |
| jcw4 | lol | 14:22 |
| mgz | :D | 14:22 |
| bodie_ | I'm more than willing to go back over it with an industrial-strength iron, but I'd personally really like to be out of that file | 14:23 |
| fwereade | wwitzel3, did you get a chance to look at that one? ^^ | 14:23 |
| wwitzel3 | fwereade: that is the one I was just pulling up now, I just did them in the order you linked them and that one happened to be last :) | 14:24 |
| mgz | bodie_: lgtm, land it. go to the launchpad page, set the commit message, and mark approved | 14:24 |
| bodie_ | aye-aye :) | 14:24 |
| fwereade | mgz, you might need to land it for him? | 14:24 |
| mgz | fwereade: I may need to toggle the approved | 14:24 |
| mgz | he can set the commit message | 14:24 |
| fwereade | wwitzel3, it's worth casting an eye over it anyway (but this is not a blocker on landing it) | 14:25 |
| fwereade | mgz, +1 | 14:25 |
| mgz | ...I guess making him do it isn't that useful as we're changing all this, but hey | 14:25 |
| wwitzel3 | fwereade: sure, doing that now | 14:25 |
| vladk | dimitern: machine-1-lxc-0 can't authorize machine-1/lxc/0, is it a bug? | 14:26 |
| jcw4 | mgz: it got pushed back at least once... maybe again... | 14:27 |
| wwitzel3 | fwereade: the first one I reviewed, add user info to juju switch, was fairly heavily reviewed, so I didn't have any comments on it. But I did read through the progression of the code and all the comments. | 14:27 |
| fwereade | wwitzel3, I'm afraid I'm disappearing for half an hour to regather my sanity, because today has somehow been stupidly relentless, and you have been very nice about my inattention so I propose to trespass upon it further :/ | 14:27 |
| mgz | jcw4: I'll get yelled at if it does | 14:27 |
| jcw4 | mgz: lol | 14:28 |
| fwereade | vladk, machine-1/lxc/0 is not a thing, is it? | 14:28 |
| fwereade | vladk, it's a mix of tag and id syntax | 14:28 |
| fwereade | vladk, machine-1-lxc-0 is the tag, 1/lxc/0 is the id | 14:28 |
| wwitzel3 | fwereade: haha, no worries, I'm here for hours yet :) enjoy your siesta | 14:28 |
| vladk | fwereade: thanks | 14:29 |
| fwereade | vladk, (or possibly my brain has turned to cheese, double-check in the juju-core/names package) | 14:29 |
| wwitzel3 | head cheese | 14:29 |
| perrito666 | uhh, cheese | 14:30 |
| * perrito666 is near lunchtime | 14:30 | |
| perrito666 | I see there is no much consistency on the tests about jc.IsTrue vs gc.Equals, true) sounds to me like jc.IsTrue is the best way to express the assertion, is there any reason not to use it? | 14:32 |
| rogpeppe | perrito666: nope | 14:33 |
| rogpeppe | perrito666: the latter is what we had to use before jc.IsTrue | 14:33 |
| perrito666 | ah, I see | 14:33 |
| rogpeppe | perrito666: (personally, i think gc.Equals expresses the logic perfectly, but i think some people begrudged the extra characters) | 14:34 |
| rogpeppe | frankban, anyone else: review appreciated: https://github.com/juju/testing/pull/7 | 14:34 |
| bodie_ | btw mgz, I think the nil exception was coming from a logical error in my tests | 14:34 |
| bodie_ | I caught that thanks to your suggestion to test the one edge bit | 14:34 |
| bodie_ | so, thanks :) | 14:35 |
| mgz | :D | 14:35 |
| bodie_ | how detailed / verbose do we like our commit messages to be? | 14:35 |
| rogpeppe | frankban: it's trivial BTW | 14:35 |
| rogpeppe | bodie_: i generally prefix the commit message with the package name(s) where reasonable, and a single line that describes the change to some degree | 14:36 |
| rogpeppe | bodie_: the important one is the MP message, which turns into the eventual trunk commit msg | 14:36 |
| bodie_ | I see, thanks | 14:37 |
| frankban | rogpeppe: done | 14:37 |
| rogpeppe | frankban: thanks | 14:37 |
| wwitzel3 | rogpeppe: why do you have to skip C (cgo)? for it to work. | 14:38 |
| rogpeppe | wwitzel3: because build.Default.Import fails for cgo's import "C" | 14:38 |
| rogpeppe | wwitzel3: and the net package uses cgo | 14:38 |
| rogpeppe | wwitzel3: "C" is a fake package - it doesn't actually exist anywhere | 14:39 |
| wwitzel3 | rogpeppe: reading about that now, it is essentially a marker for C preamble. | 14:39 |
| rogpeppe | wwitzel3: yeah | 14:40 |
| rogpeppe | wwitzel3: and C names are inside its name space | 14:40 |
| wwitzel3 | rogpeppe: yep, makes sense | 14:40 |
| bodie_ | rogpeppe, fwereade, mgz do you think I need to amend the code with a comment for the spec the Actions YAML is expected to take, or is that more of a docs/ addition? | 14:59 |
| bodie_ | I'm just combing the last kinks out of the MP message | 14:59 |
| rogpeppe | bodie_: i think that a doc comment is always good | 14:59 |
| rogpeppe | bodie_: for anyone trying to parse charms from go and using the package, that's all they'll see | 15:00 |
| rogpeppe | bodie_: although you could add a link to the spec instead | 15:00 |
| bodie_ | hmm | 15:00 |
| bodie_ | okay | 15:00 |
| bodie_ | give me a few minutes to land something appropriate, I'm just putting my kid down for a nap | 15:00 |
| bodie_ | then hopefully we can finally get this thing in | 15:00 |
| mgz | bodie_: sorry, can we land your branch yet? | 15:04 |
| rogpeppe | review appreciated of this: https://codereview.appspot.com/99670045/ | 15:07 |
| rogpeppe | pretty trivial stuff - mostly just code movement | 15:07 |
| voidspace | natefinch: wwitzel3: perrito666: hey guys, sorry I missed standup | 15:12 |
| voidspace | natefinch: wwitzel3: perrito666: got stuck in traffic and have been out a stupidly long time | 15:12 |
| voidspace | natefinch: I assume you didn't make any progress on the precise CI problem yesterday? | 15:13 |
| bodie_ | mgz, I'd like to basically copy the MR message into a comment for the Actions type, just give me a minute here | 15:13 |
| bodie_ | sorry for the delay | 15:13 |
| voidspace | natefinch: from "further research" this morning I have a theory - going looking in the code to see if it could be correct | 15:13 |
| bodie_ | mgz, do I need to re-propose? | 15:15 |
| bodie_ | (I know I'd want this change as a user of the type) | 15:16 |
| natefinch | voidspace: yeah, no, sorry, no progress | 15:16 |
| mgz | bodie_: nope | 15:16 |
| bodie_ | mkay | 15:17 |
| bodie_ | okay, it says I need review since I pushed a change, even though it's a simple one... | 15:19 |
| bodie_ | just a richer comment on the type | 15:20 |
| bodie_ | so I guess that means I need to lbox propose | 15:20 |
| bodie_ | I promise the next iteration won't have such a low signal to noise ratio :/ | 15:21 |
| fwereade | bodie_, you just need to refresh the launchpad page and approve on the frsh page, I think | 15:22 |
| bodie_ | alrighty | 15:22 |
| bodie_ | fwereade, I'm not seeing the approved button any longer | 15:26 |
| bodie_ | can I just get a quick approval here... https://codereview.appspot.com/94540044 | 15:26 |
| bodie_ | someone/anyone? All I added was a couple of comments to types that needed to be more informative | 15:37 |
| bodie_ | https://codereview.appspot.com/94540044/ | 15:37 |
| bodie_ | fwereade, mgz, natefinch, rogpeppe, just want to land this thing already, sorry to pester but apparently the comments I added to the code mean it needs a fresh review | 15:38 |
| bodie_ | just so it's on your radar | 15:38 |
| mgz | bodie_: landing | 15:38 |
| bodie_ | thank ye sir | 15:39 |
| bodie_ | was that for merge 219926? | 15:46 |
| mgz | why does their url for v4 have /latest/ rather than /v4/ or something >_< | 15:46 |
| mgz | bodie_: I poked the commit mesage a little and flagged for the bot | 15:47 |
| bodie_ | oy... I thought I linked the v4 draft. bleh | 15:47 |
| bodie_ | yeah, that fact was driving me nuts | 15:47 |
| mgz | oh, poo, I need to go pull in the deps | 15:47 |
| bodie_ | I think I made up for it by linking the v4 _schema_ rather than the draft since I couldn't find a copy of the v4 draft | 15:48 |
| bodie_ | technically, JSON-Schema lets you include a $schema key to define the schema to use -- however, I noticed the "latest", i.e. v4 draft, is from last august | 15:48 |
| bodie_ | I don't even know if they landed a final version, or if it fell out of date, or what's up with all that | 15:48 |
| mgz | heh `fail`... I should totally make that tyop an alais for `tail -f` | 15:50 |
| mgz | bodie_: bot is chewing on it | 15:50 |
| jcw4 | mgz lol | 15:50 |
| mgz | bodie_: landed | 16:04 |
| jcw4 | woot | 16:05 |
| mgz | everyone: you'll want to pull trunk and get the new gojsonschema related dependencies | 16:05 |
| bodie_ | pilgrim's progress | 16:05 |
| === Ursinha is now known as Ursinha-afk | ||
| === vladk is now known as vladk|offline | ||
| === vladk|offline is now known as vladk | ||
| === vladk is now known as vladk|offline | ||
| bodie_ | fwereade, anyone else, where do you think the Actions params validator should go? since Actions is a map belonging to Charm, which needs to be loaded by gojsonschema in order to validate a Params map, it seems really sensible to me to implement that as a member of the Charm interface | 17:07 |
| bodie_ | something like func (c *Charm) Validate(map[string]interface{}) error { ... } | 17:08 |
| bodie_ | however, I could also see that being the responsibility of a method in State | 17:08 |
| jcw4 | bodie_: I don't think Charms or State should know about Action parameter validation (directly), I would expect the Validate to be on an ActionDefinition type (not sure what we'll call that type) | 17:10 |
| jcw4 | bodie_: in the example you give... How does Charm know *which* action you're validating? | 17:10 |
| bodie_ | sorry, one moment, helping the girls up | 17:12 |
| * jcw4 wil brb | 17:13 | |
| bodie_ | maybe we could use an Action interface to tie it all together? | 17:18 |
| bodie_ | like Charm | 17:18 |
| bodie_ | that probably isn't what we need since Charm has a different meaning for Actions then State will have | 17:19 |
| bodie_ | than* | 17:19 |
| voidspace | natefinch: I'm approaching EOD, and it still looks like we're no nearer a solution | 17:22 |
| voidspace | natefinch: although interestingly it looks like the specific failure has changed - we're now seeing "Closed explicitly" as the error message | 17:22 |
| voidspace | natefinch: we need to time bound how long we're going to continue looking at this I think | 17:23 |
| sinzui | natefinch, voidspace : do you have a minute to review https://codereview.appspot.com/100880046 | 17:23 |
| voidspace | sinzui: looking | 17:24 |
| voidspace | that was tricky :-) | 17:24 |
| voidspace | natefinch: although this reference implies that the call to replSetInitiate can error, but be successful | 17:29 |
| voidspace | http://stackoverflow.com/questions/9992535/azure-mongodb-replica-sets-initialization-error-local-oplog-rs-is-not-empty | 17:29 |
| voidspace | There was no problem at all. This exception is normal behavior. Just need to wait couple of seconds and replica set will be initialized. | 17:29 |
| voidspace | Inside Initiate we wait 1 second (well, ten sleeps of 100ms) | 17:29 |
| voidspace | we could wait a bit longer (up to a few seconds) whilst polling for the replica set status | 17:31 |
| voidspace | it could be a timing issue (slow machine) which is why it only happens on the build machine | 17:31 |
| natefinch | voidspace: back | 17:32 |
| natefinch | voidspace: hmm slow machine sounds possible | 17:33 |
| voidspace | natefinch: hey, hi - only a few lines of scrollback | 17:33 |
| voidspace | natefinch: the question is whether or not that specific error is genuinely recoverable | 17:33 |
| voidspace | natefinch: we have replicaset.CurrrentStatus() | 17:34 |
| voidspace | natefinch: I could add polling for that - if we get an alive status (or equivalent) then continue | 17:35 |
| natefinch | upping the timeout seems harmless. bootstrap is already relatively slow, making it a few seconds slower in the edge case where there's a non-recoverable error seems like not a big deal | 17:35 |
| voidspace | natefinch: MaybeInititiateMongoServer only returns an error | 17:35 |
| voidspace | natefinch: ok I'll create an mp adding that and we can see if it fixes the problem | 17:36 |
| natefinch | I hate this blindly swinging at invisible errors stuff. | 17:36 |
| voidspace | me too :-/ | 17:36 |
| voidspace | natefinch: this log with debug (the CI console output logs are INFO only) shows us attempting to call replSetInitiate multiple times | 17:37 |
| voidspace | http://pastebin.ubuntu.com/7544771/ | 17:37 |
| natefinch | gustavo might have a better idea of what's going on, but he's playing squash or something in Malta, I believe | 17:37 |
| voidspace | and if it's "in progress" it makes sense that subsequent calls fail with this error | 17:37 |
| voidspace | effectively meaning "I'm already initiating a replSet for you"... | 17:37 |
| voidspace | you are only supposed to call it once | 17:37 |
| natefinch | ahh right, good point | 17:38 |
| voidspace | the odd thing is that the loop for multiple calls is explicitly checking for unreachable servers | 17:38 |
| perrito666 | voidspace: well the first call declares it fails, those can be retries | 17:38 |
| voidspace | perrito666: we actually have two loops | 17:39 |
| voidspace | one inside initiate.go and one inside replicaset.go | 17:39 |
| voidspace | the initiate.go one logs "replica set initiation failed, will retry" and we're *not* seeing that | 17:39 |
| voidspace | so it must be the replicaset.go one | 17:39 |
| voidspace | hmmm... ah wait | 17:40 |
| voidspace | the other loop is: if err != nil && err.Error() == rsMembersUnreachableError | 17:40 |
| voidspace | looks like a debug log has been removed | 17:41 |
| voidspace | perrito666: http://pastebin.ubuntu.com/7544771/ | 17:41 |
| perrito666 | voidspace: migration step? | 17:42 |
| voidspace | that log is showing repeated retries inside Initiate - but not repeated calls to the initial logging line | 17:42 |
| voidspace | perrito666: what do you mean? | 17:42 |
| perrito666 | voidspace: sounds like something intended to introduce peergrouper in a harmless way | 17:43 |
| perrito666 | 31 // MaybeInitiateMongoServer checks for an existing mongo configuration. | 17:43 |
| perrito666 | 32 // If no existing configuration is found one is created using Initiate. | 17:43 |
| perrito666 | also there is a comment by rogpeppe | 17:44 |
| perrito666 | 43 // TODO(rog) remove this code when we no longer need to upgrade | 17:44 |
| perrito666 | 44 // from pre-HA-capable environments. | 17:44 |
| voidspace | perrito666: right, but the logging shows we go into Initiate and then retry multiple times inside there | 17:44 |
| voidspace | perrito666: and this reference implies that this error can be non fatal (i.e. initiation is still happening) | 17:45 |
| voidspace | http://stackoverflow.com/questions/9992535/azure-mongodb-replica-sets-initialization-error-local-oplog-rs-is-not-empty | 17:45 |
| voidspace | ok, I need to EOD | 17:47 |
| voidspace | g'night all | 17:47 |
| perrito666 | voidspace: well in restore, after running init of rs I do run a loop trying to connect as the client until it actually works | 17:47 |
| perrito666 | voidspace: bye | 17:47 |
| natefinch | night voidspace, thanks for the help. Sorry it's been such a hassle | 17:47 |
| voidspace | natefinch: heh, such is life | 17:48 |
| rogpeppe | voidspace: the reason to remove that code is that in post HA-version environments, MaybeInitiateMongoServer should only be called once, at bootstrap time. at that time, there are no users, so there's no need to connect as a specific user | 17:48 |
| voidspace | rogpeppe: right, but it's currently harmless and definitely *not* the source of the current problem | 17:49 |
| rogpeppe | voidspace: ok, that's fine | 17:50 |
| voidspace | which is a problem of initiating failing at bootstrap time | 17:50 |
| voidspace | on one machine | 17:50 |
| voidspace | and that machine only so far... | 17:50 |
| rogpeppe | voidspace: ok, that's what i was about to ask | 17:50 |
| voidspace | so, latest theory is that initiating is just slow on that machine | 17:50 |
| voidspace | so I'll poll replicaset status and if we see a healthy replica set within a few seconds we'll ignore that error | 17:51 |
| voidspace | as I've found one reference saying that this can be the case | 17:51 |
| voidspace | if that fixes the problem then great | 17:51 |
| voidspace | but for now... | 17:52 |
| voidspace | good night :-) | 17:52 |
| natefinch | rogpeppe: yeah, it's just the precise CI machine that can't run local provider with --replset for whatever reason. | 17:53 |
| natefinch | rogpeppe: works on other peoples' precise VMs | 17:53 |
| rogpeppe | natefinch: have we tried doing it manually on the CI machine? | 17:53 |
| natefinch | I think Michael had said he tried it manually, but I'm not 100% sure | 17:55 |
| natefinch | certainly worth testing out | 17:55 |
| natefinch | sinzui: is there a way I can get on the precise CI machine to noodle with mongo? | 17:56 |
| === alexisb is now known as alexisb_lunch | ||
| perrito666 | natefinch: I think Michael mentioned not having access to the machine to try it manually | 18:04 |
| natefinch | perrito666: ahh yeah, right, well, we should get on there. | 18:07 |
| bodie_ | okay, so I've gone and forgotten to switch branches before writing code, and committed to master | 18:40 |
| bodie_ | is there a quick and dirty way to just yank that commit into a new branch somehow without taking the fact that it came from master? | 18:40 |
| bodie_ | I'm not entirely clear on how much bzr cares about branch history vs file contents | 18:41 |
| bodie_ | like a cherry-pick | 18:42 |
| bodie_ | I guess that's a merge -c | 18:43 |
| natefinch | sorry, no idea | 18:44 |
| jcw4 | bodie_: If that doesn't work, I would personally just generate a patch of the changes and then remove your local repo and start again | 18:44 |
| jcw4 | bodie_: otherwise, you'll be fighting the changes in master when you pull from lp:juju-core, and when you try to create new branches | 18:45 |
| bodie_ | right | 18:45 |
| bodie_ | I think I can merge -r 1 and then cherry-pick the incorrect changes from master, which should bring them in free of branch history info | 18:45 |
| bodie_ | then go back to master and merge -r 1 | 18:45 |
| mgz | bodie_: you just committted on master? | 18:46 |
| jcw4 | bodie_: unless you can actually remove those revisions from master I think you'll have issues | 18:46 |
| mgz | oh, god, but you're using cobzr so I'm not sure how you address trunkk >_< | 18:47 |
| jcw4 | mgz: :) | 18:47 |
| bodie_ | I think I can just refer to it as master | 18:47 |
| bodie_ | I was thinking if I could just cherry-pick the changes into a feature branch without branch history, then I could revert master to its rightful state | 18:48 |
| bodie_ | so, like john was saying, a patch would accomplish that | 18:48 |
| bodie_ | then just nuke my repo and start over, then apply the branch | 18:48 |
| mgz | bzr branch -r-2 co:trunk co:prevtrunk | 18:48 |
| mgz | is what's I'd do | 18:48 |
| mgz | give youself a new branch of clean trunk | 18:48 |
| mgz | then you can pull of the changes from trunk to a new branch of that | 18:49 |
| mgz | and finally push --overwrite prevtrunk over trunk | 18:49 |
| sinzui | Hi Does juju not think that 1.19.3 is the last dev version? My branch that changes juju to 1.19.4 has the same failure in repeated tests. https://code.launchpad.net/~sinzui/juju-core/inc-1.19.4/+merge/221570 | 18:54 |
| bodie_ | jcw4, do you know if bzr has a built in patching mechanism? | 19:21 |
| jcw4 | you mean like git apply? | 19:21 |
| bodie_ | this | 19:22 |
| bodie_ | http://doc.bazaar.canonical.com/plugins/en/bzrtools-plugin.html#patch | 19:22 |
| bodie_ | but my bzr is telling me it doesn't know what "patch" means | 19:22 |
| bodie_ | bzr patch --usage | 19:23 |
| bodie_ | cobzr: /usr/bin/bzr patch --help: exit status 3 | 19:23 |
| bodie_ | bzr: ERROR: unknown command "patch" | 19:23 |
| jcw4 | seems like you don't have the bzrtools plugin? | 19:23 |
| bodie_ | ah | 19:24 |
| bodie_ | I wonder if that would mess with cobzr... | 19:24 |
| bodie_ | meh. | 19:24 |
| jcw4 | I don't think so | 19:24 |
| bodie_ | I think cobzr only filters out commands that it knows | 19:24 |
| jcw4 | http://doc.bazaar.canonical.com/plugins/en/plugin-installation.html | 19:24 |
| jcw4 | I bet you could cd to $HOME/.bazaar/plugins/ and then just do bzr branch lp:bzrtools | 19:25 |
| bodie_ | oh, good find | 19:29 |
| sinzui | natefinch and his esteemed minions. We have two critical bugs :( | 19:44 |
| sinzui | https://bugs.launchpad.net/bugs/1325074 | 19:44 |
| _mup_ | Bug #1325074: Juju version cannot be set to 1.19.4 <packaging> <juju-core:Triaged> <https://launchpad.net/bugs/1325074> | 19:44 |
| sinzui | https://bugs.launchpad.net/bugs/1325072 | 19:44 |
| _mup_ | Bug #1325072: unit tests fail on utopic <ci> <test-failure> <utopic> <juju-core:Triaged> <juju-core 1.18:Triaged> <https://launchpad.net/bugs/1325072> | 19:44 |
| natefinch | sinzui: looking | 19:44 |
| sinzui | oh, but I see arm64 unit tests run for the first time ever. Even if they fail, this is a big improvement over the compilation errors I have gotten over the last 3 months | 19:46 |
| * sinzui finds children | 19:48 | |
| bodie_ | hmm | 19:55 |
| bodie_ | jcw4, did we decide it made more sense to permit Actions to come back nil? | 19:56 |
| bodie_ | or to return an empty struct | 19:56 |
| jcw4 | from a Charm? | 19:56 |
| natefinch | sinzui: unfortunately, I don't know what the log is supposed to look like when this kind of thing succeeds. I can't imagine just bumping the revision just broke something.... is there no simplestreams data for 1.19.4, is that the problem? | 19:56 |
| bodie_ | yeah | 19:56 |
| jcw4 | I *think* empty struct... but I could convinced either way | 19:57 |
| bodie_ | hmm | 19:57 |
| * jcw4 goes to pick up his kids from school | 19:57 | |
| bodie_ | if we model it on Config, it'll come back empty | 19:58 |
| bodie_ | ah | 20:00 |
| bodie_ | fwereade, mgz, natefinch -- I noticed Config comes back with an empty Options member if there's no config.yaml | 20:04 |
| bodie_ | why not just return an empty Config? | 20:04 |
| bodie_ | I guess because then you can iterate on := range c.Config().Options without checking for nil | 20:05 |
| sinzui | natefinch, that you for looking. I could consider this issue a offer from fate to let me take the weekend off. | 20:08 |
| === vladk|offline is now known as vladk | ||
| natefinch | sinzui: sounds like it to me | 20:11 |
| natefinch | bodie_: empty is probably nicer | 20:15 |
| bodie_ | natefinch, I realized it's coming back empty now, but its members aren't instantialized | 20:17 |
| bodie_ | I think I'm going to return empty members | 20:17 |
| bodie_ | or uh, a struct with empty but instantiated* members | 20:17 |
| bodie_ | does that sound reasonable? | 20:18 |
| natefinch | bodie_: but I don't think we have a convention | 20:21 |
| natefinch | bodie_: depends on the struct. Not sure exactly what you're making. The fields all default to the zero value, which, if designed well, is an ok default | 20:23 |
| === vladk is now known as vladk|offline | ||
| === vladk|offline is now known as vladk | ||
| === vladk is now known as vladk|offline | ||
| bodie_ | natefinch, perhaps I was getting a nil value for a different reason | 20:46 |
| === vladk|offline is now known as vladk | ||
| bodie_ | thanks for helping me understand :) | 20:46 |
| === vladk is now known as vladk|offline | ||
| bodie_ | jcw4, if you have spare time tonight, if you'd like you can check out the state side of the Charm Actions() interface method | 21:04 |
| bodie_ | I got the dir and bundle stuff put together and tested | 21:04 |
| bodie_ | I think it's good | 21:04 |
| jcw4 | cool. pushed up to lp? | 21:04 |
| bodie_ | yeah, http://launchpad.net/~binary132/juju-core/charm-interface-actions | 21:04 |
| bodie_ | testing whole thing now | 21:05 |
| bodie_ | I think the only places the implementation needs to be locked down are state/store and state/charm | 21:07 |
| jcw4 | k | 21:07 |
| bodie_ | pushed another minor fix | 21:14 |
| jcw4 | k | 21:16 |
| bodie_ | jcw4, with that change I believe it's in the clear | 21:32 |
| jcw4 | in the clear meaning ready for me to refer to when looking at the state side implementation? | 21:33 |
| bodie_ | I'm going to propose -wip | 21:33 |
| bodie_ | just need to add a few tests, methinks | 21:33 |
| bodie_ | heading out for the night, laters | 21:33 |
| jcw4 | ttyl | 21:34 |
| bodie_ | lbox proposed -wip :) https://codereview.appspot.com/99640044 (fwereade, mgz?) | 21:37 |
| bodie_ | Still needs a few tests implemented | 21:37 |
| jcw4 | cool | 21:37 |
| === Ursinha-afk is now known as Ursinha | ||
| === alexisb_lunch is now known as alexisb | ||
| jcw4 | long lunch alexisb | 21:56 |
| alexisb | jcw4, yes it was | 21:57 |
| jcw4 | :) | 21:57 |
| alexisb | I met a colleague in town, but town for me is a long ways away | 21:57 |
| alexisb | so I took the opportunity to run some in town errands | 21:57 |
| jcw4 | ... I was thinking you were east coast like most of the folks, but I forgot you were in my old stomping grounds | 21:58 |
| alexisb | o yeah? where are your old stomping grounds? | 21:58 |
| jcw4 | I lived in Vancouver (WA) and worked in Portland from 2004 until January | 21:59 |
| jcw4 | Now I'm down in Sacramento | 21:59 |
| alexisb | heh that is funny, I was born in Sacramento | 21:59 |
| jcw4 | haha | 22:00 |
| alexisb | jcw4, where in Sacramento do you live? | 22:00 |
| jcw4 | Natomas, basically two blocks from the fields to the north | 22:00 |
| alexisb | nice | 22:00 |
| jcw4 | alexisb: reprieve from the rain for sure | 22:00 |
| alexisb | yes, Sacramento is not a bad town, when I graduated we looked at living there and me working in folsom at Intel | 22:01 |
| jcw4 | that would have been nice. Folsom is quite pretty | 22:01 |
| alexisb | but ultimately the commute was more then I wanted to deal with | 22:01 |
| jcw4 | I dunno, PDX traffic was way worse than any I've encountered here | 22:02 |
| jcw4 | although I AM working from home | 22:02 |
| jcw4 | :) | 22:02 |
| alexisb | :) | 22:02 |
| alexisb | if you have to be in portland yes, traffic sucks, especially vancouver to pdx | 22:03 |
| jcw4 | yeah... that was the main problem. Two bridges | 22:03 |
| alexisb | but I actually live in yamhill and also wfh :) | 22:03 |
| jcw4 | Oh, very nice... LOVE yamhill county and IIRC the little town of yamhill is very very nice | 22:03 |
| alexisb | yes we really like it here | 22:04 |
| jcw4 | thats on the back road between dundee and forest grove right? | 22:05 |
| alexisb | yep | 22:05 |
| jcw4 | I'm suprised you get decent internet there? | 22:05 |
| alexisb | a very good local company called coho | 22:05 |
| alexisb | they do a nice job and give very reliable service | 22:05 |
| jcw4 | very nice | 22:06 |
| === hatch__ is now known as hatch | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!