/srv/irclogs.ubuntu.com/2014/06/13/#juju-gui.txt

rick_h_wheee bug spam 02:53
rick_h_but with that I think I'm spent. party on 02:53
rick_h_huwshimi: though can you update your card? I thought I saw a pull request for your card that's in branch start02:53
* rick_h_ runs away02:54
huwshimiAh yes03:10
frankbanrogpeppe1: morning and LGTM. If you agree, we can proceed like the following: you remove cmd stuff from core and I move the store commands from core to store. How does it sound?09:48
rogpeppe1frankban: sgtm09:49
frankbanrogpeppe1: cool, I just found a typo on the cmd branch09:49
rogpeppe1frankban: oh yes?09:50
frankbanrogpeppe1: yes, in a comment, so nothing bad09:50
frankbanrogpeppe1: what's the idiomatic way to add a command to a package? creating a cmd dir and subdirs for each command, each one including a main package?10:10
rogpeppe1frankban: yup10:10
frankbanrogpeppe1: cool thanks10:10
frankbanrogpeppe1: I encountered code like this: http://pastebin.ubuntu.com/7638321/ . Do we have any conventional meaning for those kind of blocks?10:48
rogpeppe1frankban: looks a bit weird to me - it doesn't seem like there's any purpose to the extra scope10:49
rogpeppe1frankban: where's the code?10:50
frankbanrogpeppe1: you can found those additional scopes in both cmd/charm-admin test files10:51
rogpeppe1frankban: ha10:51
rogpeppe1frankban: i found three almost identical places10:51
rogpeppe1frankban: definite copypasta10:51
frankbanrogpeppe1: ok I'll fix those in charmstore10:51
rogpeppe1frankban: i see no reason for the block at all10:51
frankbanrogpeppe1: are there cases where blocks like them are not meaningless?10:52
rogpeppe1frankban: ah, i *think* i see what they were trying to do10:52
rogpeppe1frankban: i think they thought that defer is block-scoped10:52
frankbanrogpeppe1: yes, each block has its own defer10:53
frankbanrogpeppe1: AFAICT there is no need to do that, and also defer should come right after the error check10:54
rogpeppe1frankban: they should do the close (not deferred) just after the Fprintf10:54
rogpeppe1frankban: but this would be a better way to do it:10:55
rogpeppe1frankban: http://paste.ubuntu.com/7638340/10:55
frankbanrogpeppe1: right ioutil.WriteFile10:55
frankbanrogpeppe1: ok I'll change all the occurrences10:56
rogpeppe1actually, it needs configPath to be saved: http://paste.ubuntu.com/7638343/10:57
frankbanrogpeppe1: could you please take a look at https://github.com/juju/charmstore/pull/3 ?11:34
rogpeppe1frankban: looking11:35
bacfrankban: thanks for the review11:40
frankbanbac: yw, what do you think?11:41
bacfrankban: still digesting.  i think it is probably a good idea.11:41
rogpeppe1frankban: reviewed11:44
frankbanrogpeppe1: thanks11:46
frankbanrogpeppe1: do you want to remove those commands from core as part of your cmd removal branch?11:46
bacfrankban: one issue, is in setup we need the platform before calling _get_packaging_info, which is needed to create the parser.  so there is a chicken-egg thing to sort out11:47
rogpeppe1frankban: feel free to do it independently if you like11:47
bacfrankban: your suggestion has a parser before determining the platform11:48
rogpeppe1anyone know how to do in git the equivalent of "bzr revert somefile.go otherfile.go" ?11:48
rick_h_frankban: were we able to keep updating the older precise charm? I thought we had something that didn't work so we were only updating precise. 11:48
rick_h_rogpeppe1: git checkout file.go 11:48
rick_h_rogpeppe1: will return it back to the original state11:49
rogpeppe1rick_h_: and that doesn't affect HEAD ?11:49
rogpeppe1rick_h_: thanks11:49
rogpeppe1rick_h_: that worked beautifully and extracted me from a nasty situation...11:50
frankbanbac: IC. In this case let's keep retrieving the platform at the beginning of setup, and then call _validate_platform(platform, parser) near the end11:51
bacfrankban: yeah, that's doable and avoids the program exit11:52
bacsounds good11:52
frankbanrick_h_: trusty and precise charms share the same development codebase. We just need to push to both cs locations when releasing. IIRC the only broken bit in the precise charm is juju-gui-source={some git branch}11:53
frankbanbac: great11:54
frankbanrogpeppe1: ok, I'll do that after lunch11:54
rick_h_frankban: ah, maybe that's what I was thinking. I thought it was something in changes in git. 11:55
rick_h_frankban: thanks, we'll get the precise one updated today as well11:55
frankbanrogpeppe1: I see your point re VCS history, but at this point I'd be inclined to just merge it. Sounds good?11:56
rogpeppe1frankban: yeah, sgtm11:56
frankbanrogpeppe1: thanks11:56
rogpeppe1frankban: the history that gets imported is all mangled anyway.11:56
rogpeppe1frankban: i just go back to lp...11:57
* frankban lunches12:14
rick_h_bac: frankban should we wait on a release blog post for quickstart until 1.4? 13:05
bacrick_h_: yes, i think so13:05
rick_h_bac: frankban I was going to write up a small blurb for the blog for 1.3.5 but notice the 1.4 card 13:05
rick_h_bac: ok cool, will hold off13:05
rick_h_jujugui very small docs branch for review please. https://github.com/juju/juju-gui/pull/38713:16
frankbanrick_h_: done13:17
rick_h_frankban: ty much13:18
frankbanrogpeppe1: could you please review https://github.com/juju/juju/pull/92 ?13:41
rogpeppe1frankban: looking13:42
rogpeppe1frankban: reviewed13:43
frankbanrogpeppe1: thanks +1 on adding a dependencies.tsv to charmstore13:44
frankbanrogpeppe1: and here it is: https://github.com/juju/charmstore/pull/413:52
bacfrankban: changes made, so please have a look when you can: https://codereview.appspot.com/10893004513:52
bacfrankban: the changes did simplify the tests somewhat, which is always a good sign13:52
frankbanbac: I'll look in a minute13:52
frankbanbac: great13:52
rogpeppe1frankban: LGTM13:53
frankbanrogpeppe1: thanks13:56
rick_h_hatch: morning, happen to still have the charm files downloaded? 14:03
rick_h_hatch: I was mistaken in not doing the precise charm14:03
hatchI do yep14:03
hatchoh ok14:03
rick_h_luca: heads up, shot down on a deploy on friday by IS so I'm on the schedule for a deploy first thing monday morning14:06
rick_h_hatch: cool, if you can merge/update the precise one as well and let me know I'd appreciate it. I want to hold off on the blog post until that gets ingested. 14:07
lucarick_h_: bloody IS! jk no problem, monday might be a better day to do it14:16
rick_h_luca: yea, sorry for the delay. We didn't quite get things wrapped up in time yesterday14:16
frankbanbac: review done, thanks for the changes14:16
lucarick_h_: did we solve the onboarding issue?14:16
rick_h_luca: well after looking at it it's not a total mishap. It doesn't show in the right place, but the image is still good/sound so we decided we could release as is and update it14:17
lucarick_h_: ok, can I see it on comingsoon/mv?14:18
rick_h_luca: no mv needed. Just go to comingsoon, click in the "Help and feedback" and click on tutorial14:18
rick_h_luca: then go next/next until you see the inspector one14:19
lucaok, thanks. Will check it out14:19
rick_h_yea, appreciate the look and we'll be bugging you to find out how you want to handle moving/adjusting it. 14:19
rick_h_luca: then again, with the MV and other onboarding stuff on the schedule not sure if it's worth the time to update. 14:19
lucarick_h_: yeah14:20
lucarick_h_: in the onboarding the inspector is still on the right hand side14:20
rick_h_luca: right, that's what we're talking about. It's kind of tossed up there like a headless ghost14:21
rick_h_luca: but to move it over to the left doens't quite work out as a static image since the height is 'whatever the user's browser is'14:21
rick_h_luca: but as for a tutorial of "here's what a cool inspector looks like' the image is accurate and recognizable so left it for now14:21
hatchI am inspector, hear me roar 14:32
hatchrick_h_ ok the precise charm has been updated - so I'm guessing 30mins or so and it should be live14:35
rick_h_hatch: rgr, thanks. I'll keep an eye on ingestion14:35
hatchrick_h_ after the call today did you want to chat about that rendering perf stuff? Or beore?14:37
hatchbefore14:37
rick_h_hatch: either or works for me14:37
hatchsure, I'll hop in the friday room now14:37
rick_h_k, /me finds headphones14:37
lucarick_h_: it’s looking all good to me and Ale, lets launch. We’ll change it soon.14:47
rick_h_luca: sounds good, will launch it monday14:47
rick_h_I'll have a release blog post up in a bit here once the charms are loaded into charmworld14:47
lucarick_h_: thanks rick + team :)14:47
rick_h_jujugui team rocks :) and call in 12 so kanban it up please. 14:48
hatchfor those who use w=1 on github....are you still able to comment on the code with w=1? the commenting functionality doesn't work for me14:55
bacjujugui: i cannot get to the calendar so i don't have the URL.  can someone paste it please?14:59
rick_h_sure thing14:59
rick_h_bac: https://plus.google.com/hangouts/_/calendar/cmljay5oYXJkaW5nQGNhbm9uaWNhbC5jb20.t3m5giuddiv9epub48d9skdaso?authuser=114:59
rick_h_jujugui call about now14:59
rick_h_jcsackett: ^15:01
rick_h_kadams54: ^15:01
jcsackettrick_h_: freaking google is saying i don't have the plugin *again*.15:01
jcsackettworking on it.15:01
* jcsackett is growing to loathe google.15:01
kadams54having problems connecting as well15:01
kadams54The little green quotes icon just keeps jiggling away15:01
rick_h_kadams54: chrome did that to me yesterday had to use FF15:01
hatchrick_h_ hey when you get a chance I need a set of tasks for focus on15:23
hatchshall I do the cleanup now?15:24
rick_h_hatch: yea, I think if you don't mind I'd like to move forward on those15:24
rick_h_and then we'll pull makyo back over from IL to MV 15:24
hatchsure, sounds like a plan15:25
hatchwoah I'm working on something that's not unsched15:26
rick_h_hatch: but let me know if you want a break and work on something else. Nothing in there is required this week kind of stuff15:26
rick_h_:)15:26
hatchnah it's ok - unless you want me to go work on some three.js for fun today....15:26
hatchno?...15:26
hatch:P15:26
rick_h_hah15:26
hatchI swear it has implications for the GUI!15:27
hatchhaha15:27
rick_h_hey, you were all happy to be working on sched work for a change. Why mess it up? :P15:27
hatchhaha15:27
hatchliving closeish to the airport is kind of cool, there are so many cool planes 15:28
bacfrankban: hey, got a second to look at jenkins for brew? http://bot.brew.sh/job/Homebrew%20Pull%20Requests/11953/version=mavericks/console15:28
bacfrankban: it looks like even calling '--version' is pulling in urwid that is failing on their test platform, likely due to being headless15:29
frankbanbac: sure15:29
frankbanbac: looking15:32
bacfrankban: it is in manage/_create_save_callable.  i wonder if we moved the import of cli.views locally if it would go away15:34
frankbanbac: importing views should not run anything at module level15:35
frankbanbac: _start_interactive_session is explicitly cvalled in the traceback15:35
bacfrankban: yeah, i see that now15:36
frankbanbac: this smells: pkg_resources.run_script('juju-quickstart==1.3.5', u'juju-quickstart')15:36
frankbanbac: it seems quickstart is run without --version for some reasons15:36
bacfrankban: i think that is ok b/c sys.argv is being set prior15:42
frankbanbac: yeah15:42
bacfrankban: this works for me:15:42
bac[bac@sol ~]$ /usr/local/Cellar/juju-quickstart/1.3.5/libexec/bin/juju-quickstart  --version15:42
bacjuju-quickstart 1.3.515:42
bacfrankban: i think the problem is we're deciding whether it is interactive or not before processing the command line args15:43
bacso we see it is interactive even though --version won't take advantage of it15:43
frankbanbac: if --version is set, parser.parse_args() should call sys.exit before even caling _setup_env15:45
bacfrankban: yep, verified15:47
frankbanbac: so something in their environment is preventing argparse to exit15:47
bacfrankban: or it isn't getting the argument15:48
frankbanbac: yes15:48
bacfrankban: shifting gears, any thoughts on the precise / mock version issue?  we rely on mock >= 1.0.1 pretty heavily.  seems like a backport is in order.15:52
frankbanbac: to launch tests on precise?15:52
bacfrankban: yes, the tests fail on precise.  let me grab the log15:52
frankbanbac: don't we install mock with pip? 15:53
bacfrankban: https://launchpadlibrarian.net/177510623/buildlog_ubuntu-precise-i386.juju-quickstart_1.3.5%2Bbzr80%2Bppa23%7Eubuntu12.04.1_FAILEDTOBUILD.txt.gz15:54
bacfrankban: the build farm doesn't appear to use pip.  only installs ubuntu packages15:55
bacmakes sens15:55
bacs/sens/sense/15:55
frankbanbac: so I guess you updated the packaging repo to run the tests before building 15:56
frankbanbac: and that's really good15:56
bacfrankban: i did not consciously do that15:57
frankbanbac: :-) but it is there (in debian/rules) I think we have two options: 1) as you mentioned, backport mock, and put it on the PPAs (it should be easy) or 2) change debian/rules so that tests are run with make check16:01
frankbanbac: if the current packaging setup reflects the one used by the distro release, then I'd vote 1)16:02
bacfrankban: oh, ok, that was part of the reconciling with the ubuntu package that robie requested16:02
bacfrankban: yes, that is the case16:02
bacfrankban: yeah, backport seems the way to go16:03
frankbanbac: yes, the brew stuff instead is weird16:03
bacfrankban: back to the brew issue, i've got no ideas.  testing is pretty heavy weight, too16:04
bacfrankban: going to grab lunch.  if you have any bright ideas before your EoD i'm all ears! :)16:07
frankbanbac:  I see a problem16:08
frankbanbac: "JUJU_HOME=/tmp/frack juju-quickstart --version" works16:08
frankbanbac: "JUJU_HOME=/tmp/frack juju quickstart --version" starts the interactive session16:09
frankbanspot the difference16:09
rick_h_dashes are important? :)16:10
hatchrick_h_ fyi - I have an env spinning up to test that latest bug report16:16
rick_h_hatch: ok cool. I replied and added a card for that. Kind of floored. 16:19
hatchI'm guessing that I won't be able to reproduce :)16:20
hatchit's a little sparse on the details but who knows, maybe Ill get luky haha16:20
rick_h_heh, yea it is a bit vague but sounds like "gaaahhhh the horror everyone is dead!"16:21
hatchlol!!16:21
hatch"I'm not dead yet"16:21
rick_h_and you can't help but want to ask "it's ok now...tell us what happened out there?"16:21
hatchhaha16:22
frankbanbac: I've found the problem: it is a juju-core bug: in juju/cmd/envcmd/environmentcommand.go:environCommandWrapper.Init, if the default environment cannot be retrieved, the wrapped EnvironCommand.Init is not called. For this reason, without a juju environment, basically juju does not pass the arguments to the plugin16:32
frankbanrogpeppe1: ^^^16:32
kadams54guihelp: any of the US/CA folks know if we need to stay a Saturday night for the sprint?16:33
frankbanbac: so, a solution for brew could be testing juju-quickstart --version and not "juju   quickstart"16:33
hatchkadams54 why?16:34
rick_h_kadams54: I found if I flew out sat I was ok. 16:34
hatchoh I see16:34
kadams54I was initially planning on flying out Sunday, 7/20 and coming back Friday, 7/2516:34
rogpeppe1frankban: hmm, i don't understand how this is a bug16:34
rick_h_kadams54: the price diff for the extra day wans't that much16:34
hatchkadams54 I find it best if you pick a flight that gets there in the MORNING on sunday16:34
rogpeppe1frankban: if Init fails, surely things should progress no further?16:34
kadams54Is the price diff just in flights, or does it have to do with the hotel as well?16:35
rick_h_kadams54: yea, I'd plan on flying out sat and arriving sunday on the overnight flights. At least what I tend to do. 16:35
hatchthen you stay up until about 9pm, and you're minimally jet lagged on monday16:35
frankbanrogpeppe1: IMHO Init should not fail if there is no default env16:35
hatchyep same here16:35
kadams54OK, will do.16:35
rogpeppe1frankban: it only fails if there's no default env and no environment has been explicitly specified16:35
hatchit was considerably cheaper for me to stay an extra day on the front16:35
hatchlike $400 16:35
rick_h_right16:35
frankbanrogpeppe1: no default env, and even no juju home can be an expected use case for plugins. e.g. that's the exact case for quickstart16:36
hatchbut I haven't booked the flights yet so will see :)16:36
hatchbut as it stands right now I'll be landing there Sat morning16:36
rogpeppe1frankban: so how is an environment command supposed to know what environment to operate on?16:36
rogpeppe1frankban: if there's no default env and no env specified16:36
frankbanrogpeppe1: right now juju still calls the external plugin but doesn't pass arguments, and that seems broken16:36
hatchkadams54 the hotel rooms are about $200USD/night so you can take that into consideration16:36
kadams54Are we flying into Heathrow?16:36
hatchyes16:36
hatchLHR16:37
hatchthere are some tricks to getting around too which we can fill you in on16:37
hatchI've spent a bunch of time exploring :)16:37
rick_h_lol, don't walk there :O16:37
hatchwhy noT!!!!16:37
hatchlol16:37
frankbanrogpeppe1: quickstart is a plugin, and handles the fact there is no default env pretty well16:37
rogpeppe1frankban: ha, so all plugins have to be env commands16:38
rogpeppe1frankban: i'd missed that16:38
frankbanrogpeppe1: in general, I think finding the environment to work with should be plugins' business16:38
rogpeppe1frankban: yeah, i'm not sure why RunPlugin is doing what it's doing16:39
kadams54I've heard the Jack the Ripper Walking Tour is not to be missed.16:40
frankbanrogpeppe1: that's not an urgent bug, we can work around that: bac: I am +1 on avoid testing both juju and quickstart in brew. we are interested in quickstart, and I assume juju is tested as well when installed by brew. so just adding the dash hopefully will fix the problem16:41
rogpeppe1frankban: ah, it's just so that the juju env can be passed in an env var rather than as a flag. i guess it saves the plugin doing all the JUJU_ENV magic16:41
rogpeppe1frankban: ha, and extractJujuArgs is horribly bogus16:41
rogpeppe1frankban: it won't work if you do juju someplugin -e=foo16:42
rogpeppe1frankban: or (assuming there's another single-letter flag, say -z) -ze foo16:42
frankbanrogpeppe1: yeah, there is area for improvements in that part of the code: silently removing arguments is not good16:43
rogpeppe1frankban: silently *perhaps* removing the *possibly wrong* arguments is even worse16:44
frankbanrogpeppe1: :-)16:44
rogpeppe1anyway, it's trivial to work around16:44
rogpeppe1for the time being16:44
rogpeppe1just set JUJU_ENV=xxx16:44
hatchrick_h_ on the latest Safari even accepting the self signed cert isn't making the GUI load16:56
hatchinvalid certificate chain on the websocket it's saying16:56
rick_h_hatch: there's a trick to it17:04
rick_h_hatch: you have to hit an extra button and accept. 17:04
rick_h_hatch: let me get my laptop, sec17:05
hatchohh lol17:05
rick_h_hatch: is there an env you have up and running?17:05
hatchyep17:05
rick_h_sec, let's hangout and I can show it, easier that way17:05
rick_h_hatch: standup?17:05
hatchsure sec17:05
kadams54US peeps: am I correct in thinking that I don't need a visa?17:18
hatchare you a criminal?17:18
kadams54Nope17:18
hatchthen you should be ok lol17:18
rick_h_lol17:18
hatchsorry that was phrased wrong17:18
hatchhave you ever been CAUGHT 17:18
kadams54British Embassy web site is telling me I don't need one, so I think I'm good :-)17:18
hatch:P17:18
kadams54lol17:18
* rick_h_ goes to get lunchables. 17:19
hatchI'm in the common wealth - I walk in, fist bump the guards and carry on17:19
kadams54Ha!17:19
hatchrofl17:19
kadams54In my head you said "G'day mate" while doing that.17:20
kadams54So a lovely mismash from across the commonwealth.17:21
bacgoing through customs to enter montreal was one of the most pleasant of those experiences17:23
bacdude was bored, i guess, wanted to talk about agile development, etc.  was very odd.17:23
bacwell, bored and nerdy17:23
hatchkadams54 lol!!17:26
hatchbac haha cool17:27
* rogpeppe1 is done for the day17:47
rogpeppe1happy weekends all17:47
hatchenjoy your weekend rogpeppe1 17:49
bacwow, backportpackage is the world's best thing ever!18:13
bacbackportpackage -d precise -s trusty -u ppa:juju-gui/quickstart-beta python-mock18:13
bacdone18:13
rick_h_bac: you don't say...that looks kind of cool18:27
baceasy and worked.  usually you don't get both.18:28
rick_h_ok, I'm outta here. Time to pack the camper. Everyone have a great weekend!18:47
hatchcya lata rick_h_  have a good one18:52
jcsackettjuju-gui: can someone tell me where existing services get loaded into the db?18:55
jcsackettmy ack and grep fu is weak.18:56
kadams54jcsackett: ugh, I'm pretty sure frankban told me this once…18:57
kadams54jcsackett: …but I've slept since then!18:57
* jcsackett laughs18:57
kadams54Looking…18:58
kadams54I think in models/handlers.js19:00
kadams54Beginning on line 21719:00
kadams54https://github.com/juju/juju-gui/blob/develop/app/models/handlers.js#L21719:00
jcsackettkadams54: thanks.19:04
hatchstepping away for lunch19:08
hatchjcsackett if you're looking from via the delta path then the handlers.js is correct19:09
hatchyou can also grep for db.services to find places where it's interacted with19:09
bacjujugui: anyone got travel auth from teh ramm yet?19:09
kadams54Nope.19:09
hatchbac yep and purchased19:10
bachuh19:10
bacwhat'd it cost?19:10
hatchmaybe I just got lucky19:10
hatchor maybe I bought him a doughnut 19:10
=== alexpilotti_ is now known as alexpilotti
hatchok now I'm really leaving for lunch :) 19:13
rick_h_bac: not gotten anything either20:14
rick_h_bac: on either of my trips20:14
bacok.20:14
hatchholy smokes I almost forgot my juju env running20:17
hatchjujugui do we know if an orange box can be hooked up to the interwebs for us to play with remotely for testing the gui?20:21
rick_h_hatch: yes, they have a network attached to them21:26
hatchrick_h_ ok cool thanks - I was hoping so, so maybe we could hook into an orange box to try and repro that bug21:26
rick_h_hatch: removing luca from the sidebar bug. We've had the chat and the decision was to make hiding the sidebar a keyboard shutcut for pro users that don't need the show/hide handholding21:30
rick_h_hatch: there's a card to work on it, I've added the bug number to the card21:30
hatchohh ok cool I didn't know about that - that's a good idea though21:31
rick_h_yea, decent compromise and I think we can make machine view flexible enough to runwithout the widebar (hopefully)21:31
hatchyeah I am pretty sure it's good to go css wise21:31
hatchare you camping now?21:32
hatch:)21:32
rick_h_not yet, just finished loading up21:32
rick_h_waiting for the wife to get home in 521:32
rick_h_and getting the boy prepped21:32
rick_h_will probably be 'camping' in 2hrs ish21:33
hatchahh :)21:35
hatchso much for 5pm camping :)21:35
rick_h_yea, took a bit extra time to get everything ready. Really have to do some prep during hte week. 21:36
rick_h_ok, well going to get finish up .21:36
rick_h_have a good weekend!21:36
hatchyou too cya21:44

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!