[07:27] morning guys [07:33] Cimi: morning [07:33] fginther: did you have time to check why all qmluitests are failing? [07:33] Saviq: so was the code review i did for unsplit enough or are you guys expecting more? [07:34] tsdgeos_, go for it [07:34] Saviq: also can we get a silo with paul's logout branch + all the things we need? [07:34] tsdgeos_, yeah, will take care of that soon [07:34] Saviq: i already went for it yesterday :D Not sure if people blocked on me just because i didn't top approve or not though [07:35] tsdgeos_, basically no one else reviewed it [07:35] I tried, but couldn't focus... [07:35] well, i just diffed this one and the other one and made sure they were 1:1 changes [07:36] tsdgeos_, good enough [07:36] also the regular packaging is failing for some reason in CI [07:36] works here === tsdgeos_ is now known as tsdgeos [07:37] Saviq: so i'll approve from my side, and if you want top approve too [07:38] tsdgeos, yup, do that [07:43] Saviq, tsdgeos I was thinking of working from 8-8:30 in summer... shifting a bit, you would prefer? [07:44] Cimi, sounds kinda short ;) [07:44] ahahah [07:44] Saviq, basically CEST [07:44] Cimi, yeah, I see no reason why not [07:44] Cimi, but you have to check with Kevin [07:44] Saviq, sure of course [07:45] Saviq, ola wakes me up at 7ish... then instead lying in bed like a zombie for another hour I should start working earlier i thought [07:47] Cimi, ;) [07:48] Saviq, waiting your mail about qtcs :) [07:48] easy one https://code.launchpad.net/~aacid/unity8/no_preview_in_preview_title/+merge/223027 [07:49] tsdgeos, + .pot [07:49] damn [07:49] there's never an easy one :D [07:50] and we didn't ever get teh pot file generation to be stable [07:50] grr [07:50] zillions of unneeded changes [07:51] tsdgeos, "stable"? [07:51] tsdgeos, the unneeded changes are probably mostly line number changes? [07:51] no [07:51] the globbing in my hd is different than in yours [07:51] so qml/Components/PassphraseLockscreen.qml gets repositioned in the file [07:51] see http://paste.ubuntu.com/7637686/ [07:52] huh [07:52] that's interesting... [07:52] ah wait [07:52] no [07:52] it's a different file name [07:52] test.qml:7 [07:52] so it's the same string but the file was renamed [07:52] tsdgeos, you got my message here? https://code.launchpad.net/~aacid/unity8/obeyArtShapeFixedSize/+merge/222294 [07:53] tsdgeos, maybe base on unsplit? the changes should be smaller there I think? [07:53] I based on unsplit the infographics [07:53] Saviq: probably, ok let me do that [07:59] Saviq: ok, so it's smaller diff https://code.launchpad.net/~aacid/unity8/no_preview_in_preview_title/+merge/223029 [07:59] Cimi: ok, i see what you mean, will try to do that [07:59] tsdgeos, kk [08:18] Saviq: ok, approved the unsplit branch [08:20] tsdgeos, tx [08:35] * Saviq needs to spend the day catching up on email :| [08:35] Saviq, right click -> mark all as read [08:35] Cimi, yeah, not gonna fly ;P [09:18] Trevinho, I still have bad crashes with unity on my laptop [09:18] is there a bugreport? [09:35] Cimi: test added [09:41] tsdgeos, tested test... indeed failing without your branch, good [09:56] tsdgeos, would still prefer to have another look by Saviq [09:57] tsdgeos, seems quite nested in terms of connections and variables [09:57] +1 [09:58] tsdgeos, found mistake [09:58] root.fixedArtShapeSize.height / root.fixedArtShapeSize.height [09:59] wops [10:01] Cimi: fixed [10:02] tsdgeos, shall we also check it is not 0? [10:02] root.fixedArtShapeSize.height [10:02] i can change != -1 to >= 0 [10:02] if you want [10:03] this is javascript so dividing by 0 won't crash anything [10:03] but still will make things go weird [10:03] otoh if we're setting fixedShapeArtSize to be 0 [10:03] something is wrong somewhere elese [10:04] tsdgeos, so > 0 [10:04] not >+ [10:04] >= [10:04] right [10:04] in cardtool we have [10:04] readonly property size artShapeSize: cardLoader.item ? cardLoader.item.artShapeSize : 0 [10:05] again code is quite nested so is confusing a bit [10:05] yeah [10:05] but it's a loader [10:05] it will have stuff [10:05] except in the startup [10:05] okl [10:05] but sure, will make it > 0 [10:05] noone will get hurt [10:06] pfff [10:06] or not [10:06] hah [10:06] we already had code that was using -1 [10:06] as condition [10:06] now i either change it all [10:07] and then i'm making changes not related to this bugfix [10:07] or end up with code that sometimes checks for -1 and sometimes for >0 [10:07] talk to Saviq when he finished mails [10:07] to me doing division and not checking for 0 is a mistake [10:08] ok it's javascript, but we should handle those cases [10:12] Cimi, I don't have to be a tie-breaker here, just use reason [10:14] tsdgeos, can we change to > 0 then? [10:16] done [10:26] tsdgeos, tests too [10:27] Cimi: right [10:31] tsdgeos, Cimi, the mistake you found, do we have a test for that? [10:32] Saviq: test_art_shape_fixed_size [10:33] tsdgeos, so when you fixed that, you added more test? [10:34] Saviq: i'm confused :D [10:34] Saviq: what is exactly that in "test for that"? [10:34] tsdgeos, " tsdgeos, found mistake [10:34] root.fixedArtShapeSize.height / root.fixedArtShapeSize.height" [10:35] Saviq: no, we don't have a test except the test that make sure the output is verbatim correct [10:36] Saviq: tbh i don't know how to create a test for that [10:37] tsdgeos, mhm :| === dandrader is now known as dandrader|afk [10:39] tsdgeos, you check the result of that property? [10:40] fixedArtShapeSizeAspect [10:41] yeah [10:41] i guess i can === dandrader|afk is now known as dandrader === MacSlow is now known as MacSlow|lunch [11:31] aaaaaaaaaaand we are unsplit [11:33] tsdgeos, ok, I'll prep silo, any reason to separate the logout? [11:34] or should we just land our current queue + logout? [11:35] Saviq: well, logout needs lots of other stuff to land at the same time [11:35] Saviq: and i'm not even sure it works [11:35] tsdgeos, mhm ok [11:36] that's why i want a silo so it can be properly tested [11:36] last time i did try didn't work again [11:36] but i may have failed at compiling all the repos properly [11:37] ok, I'll ask for two silos thne [11:38] Saviq, tsdgeos: there is only an indicator-session commit to include with it, maybe put it in the same silo? [11:39] seb128: and lp:~aacid/unity8-desktop-session/fix_logout at least [11:39] tsdgeos, that's already in https://launchpad.net/~ci-train-ppa-service/+archive/landing-008/+packages [11:40] ok [11:40] it's a bit sad there's no way to know that [11:40] tsdgeos, sure there is http://people.canonical.com/~rbpark/citrain/ [11:40] Saviq: but i need to go there and f5 stuff every second [11:40] seb128, so maybe we should just add the logout to that silo instead? [11:40] tsdgeos, it f5s for you automagically ;) [11:41] tsdgeos, and then there's #ubuntu-ci-choo-choo [11:41] tsdgeos, where you can talk to CI-SNCF [11:41] Saviq, we had the logout in a silo earlier in the week and had to clear it out because the unity8 side was not landed and we couldn't test it [11:41] Saviq: it'd be much better imho if it could be a push method in which the MR gets a comment saying "this has been added to silo XYZ" than me having to listen to side channels [11:41] Saviq, oh, you mean adding unity8 in that silo? that would lock your other landing no? [11:41] seb128, is fine, we should just land it then ;) [11:41] yeah [11:42] seb128, nothing very pressing in my queue yet either [11:42] Saviq, and even if it's not fully working or tested, as long as it create no regression [11:42] I would just include it [11:42] seb128, just get it in [11:42] or I can for that matter [11:42] yeah, please include the unity8 change [11:43] meh [11:43] doesn't merge anymore [11:43] paulliu: https://code.launchpad.net/~paulliu/unity8/logout/+merge/216373 needs remerging [11:44] paulliu, you around to merge ↑? [11:47] * Saviq resubmits under unity-team then [11:48] Saviq: ok. [11:51] paulliu, oh you're here, please merge and let me know === alan_g is now known as alan_g|lunch === MacSlow|lunch is now known as MacSlow [12:16] Saviq, done. === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === alan_g|lunch is now known as alan_g === _salem is now known as salem_ === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [13:03] paulliu, thanks [13:04] paulliu, did you clean up the CMakeLists.txt there as well? [13:07] dandrader: yes. cleaned [13:08] paulliu, you missed plugins/Unity/Session/CMakeLists.txt [13:10] dandrader: ok..wait [13:14] dandrader: done. === dandrader is now known as dandrader|afk [13:23] karni, you asked about depts (somewhere...), best to follow bug #1320847 [13:23] bug 1320847 in Unity 8 "Need departments choices in the Amazon and Ebay dash pages " [High,In progress] https://launchpad.net/bugs/1320847 [13:23] Saviq: aha. this bug is used to track progress on departments I gather? :D [13:24] karni, it *can* be used for that, yes [13:24] subscribed, thanks! [13:25] mhr3: has ETA (for this week) changed for departments, or you guys still plan to wrap some work today? no rush, just asking. [13:27] karni, definitely not today [13:27] we're breaking abi, so it's all waiting for more changes [13:28] mhr3: Is there a chance to have it next week? How's the work coming along? [13:30] karni, yes, next week is the target [13:30] thanks === dandrader|afk is now known as dandrader === alan_g is now known as alan_g|tea [14:10] mhr3_, tsdgeos is of the opinion we shouldn't touch Scopes much, either [14:10] mhr3_, here's what Albert wrote about the "needs" http://paste.ubuntu.com/7638985/ [14:11] mhr3_, tsdgeos, I'm just not sure of the "includes all, also invisible ones" is needed, though [14:12] as long as we can get(QString name) (which we actually can already) [14:13] Saviq: yeah i'm unsure on that, i thought it'd be easier "for the world" if Scopes would include all the Scope objects [14:13] tsdgeos, I don't think it does, even now [14:13] since it'd be weird doing a get("hardocdedNameForScopesScope") [14:13] tsdgeos, waste of mem [14:13] if Scopes doesn't have it [14:13] but if it is not like that now [14:13] i totally can live without that :D [14:13] tsdgeos, that depends on the definition of what model Scopes is, really [14:14] Saviq: sure, if it doesn't include visible scopes, we might as well remove that role and the proxymodel that makes sure only visible ones are shown :D [14:14] you could say Scopes is an "entry-point" to the scopes system (which it kind of is), and a model of favourite scopes [14:14] tsdgeos, I think we should, yes [14:14] tsdgeos, this feels legacy (pre-new-scopes) actually [14:14] maybe :) [14:15] mhr3_: comments on ↑ ? === alan_g|tea is now known as alan_g [14:30] Okay, let me see. I know everything in here want to porting the biggest revolution Unity 8, but will it be only-default option to using that?. === dandrader is now known as dandrader|afk [14:33] It's totally unclear and confusing my head always. [14:42] tsdgeos, i like the idea of keeping Scopes and adding ScopesOverview [14:43] mhr3_: oh, ScopesOverview in that document is something in my side :D, in you side it would just be ScopesScope [14:43] but seeing how special the scopes scope is, i'm not sure if regular cards is enough there [14:43] mhr3_, they are built with the toolkit, they're regular cards [14:43] but we can also make Scopes have a Scopes::getOverview instead of doing Scopess::get("harcodedName") [14:44] yea, detail [14:44] Saviq, hmm... [14:44] Saviq, it's more about the interactions though [14:44] Saviq, for example what happens when you tap on a scope in all? [14:45] mhr3_, you tell me ;) [14:45] does that open new temp dash page and pan to it? [14:45] mhr3_, but I believe we open that scope in the dash and zoom in again [14:45] when does it disappear? [14:45] mhr3_, opening a scope always takes you back to the dash [14:45] when you do the zoom out? [14:46] mhr3_, on bottom edge again [14:46] mhr3_, but that's a question I did ask (what does the back button do in non-favourite scope) [14:46] should it even have a back button? [14:47] mhr3_, please read/add comments under https://sites.google.com/a/canonical.com/unity8dash/dash-overview [14:47] yea, kinda didn't scroll all the way down :) [14:51] mhr3_, but also, we'll be displaying smart scope results in the "all" category, so those need to be cards [14:51] mhr3_, only real thing we don't have is the horizontal list in Favourites [14:51] indeed [14:52] mhr3_, but that we can make custom no issue [14:52] i wonder where do the icons come from === gatox is now known as gatox_lunch === alan_g is now known as alan_g|EOW === dandrader|afk is now known as dandrader === gatox_lunch is now known as gatox === dandrader is now known as dandrader|afk [19:36] quit === dandrader|afk is now known as dandrader === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === salem_ is now known as _salem === dandrader is now known as dandrader|afk