=== chriadam|away is now known as chriadam === _salem is now known as salem_ === salem_ is now known as _salem === chihchun_afk is now known as chihchun [05:28] Good Morning === chriadam is now known as chriadam|away [07:14] good morning [08:01] good mornign [08:19] maybe someone can use this for an World cup app [08:19] http://worldcup.sfg.io/ [08:26] Good morning all; happy International Panic Day! :-D [08:29] AAAAAAAAAAAAGGGGHHHHHHHHH RRRUUUUUUUUUUNNNNN [08:38] kalikiana, does U1Db has a public C++ API? [08:40] * DanChapman would like to know that ^^ one aswell :-D [08:42] Good Morning all [08:51] is U1Db accessable for HTML5 apps ? [09:06] popey, https://code.launchpad.net/~brendan-donegan/ubuntu-calendar-app/remove_osk_hide/+merge/223523 [09:08] brendand: will take a look now. [09:11] popey, it's not guaranteed to fix the failures, because i could never reproduce them locally anyway [09:12] I'm running Ap on a device with that branch now [09:23] brendand: all passed [09:29] popey, good [09:31] brendand: does the music app do the same? [09:31] oh, no [09:32] popey, clock does [09:32] popey, clock doesn't seem to have many issues though. except for todays hang [09:59] oSoMoN: hello [10:00] oSoMoN: do you do reviews for notes-app? I have one https://code.launchpad.net/~tpeeters/notes-app/remove_get_header/+merge/223218 [10:00] oSoMoN: it is needed for a change I will do in UITK [10:00] t1mp, I can review it [10:01] I’ll take a look in a minute [10:01] oSoMoN: thanks [10:17] popey: ping [10:17] popey: it fails on desktop [10:29] mihir: the one I just commented on? [10:29] trusty desktop failure? [10:29] (sorry, commented on a bunch of merges, gimmie a link for context) :D [10:33] popey: on AP fails [10:33] https://code.launchpad.net/~gang65/ubuntu-calendar-app/ubuntu-calendar-autopilot-edit-event/+merge/221127 [10:33] yeah, is it missing something that's only in the sdk on uptopic we wondered [10:33] popey: on repetition option , does it function well on device ? [10:33] let me test here.. gimmie 5 mins [10:34] popey: sure :) [10:34] thanks mihir [10:36] mihir: with that branch I'm getting the odd thing where it doesn't fit on screen - http://popey.mooo.com/screenshots/device-2014-06-18-113549.png [10:37] popey: sorry , i lost which branch give you this output ? [10:37] 11:33:09 < mihir> https://code.launchpad.net/~gang65/ubuntu-calendar-app/ubuntu-calendar-autopilot-edit-event/+merge/221127 [10:37] that one [10:37] popey: hmm that's weird [10:38] mihir: left a comment on the merge [10:38] popey: the thing is , it is just updating AP no UI changes i can see in change log [10:44] hm. [10:45] lemme remove the app and re-install, i have all kinds of rubbish on this device [10:47] same [10:48] mihir: does it need remergeing from trunk? [10:48] didnt we fix this before. [10:50] popey: may be [10:50] it required latest merge === MacSlow is now known as MacSlow|lunch === MacSlow|lunch is now known as MacSlow === _salem is now known as salem_ [12:37] popey, are you inclined to land the calendar-app change? === chihchun is now known as chihchun_afk [12:52] I'm having problem click packaging a scope. Can anyone advise? http://paste.ubuntu.com/7663564/ scope name has been replaced with "Foo" [12:54] karni, I've not yet packaged any scope with click, but perhaps mhr3 on #ubuntu-unity can help? Or perhaps some of the security or click guys (jdstrand or cjwatson) [12:55] dpm: yes, I pinged both, will also poke Michal, thanks [12:55] ok [13:01] rpadovani, mzanetti, sorry, I'll have to skip the Reminders meeting today, I'll reschedule for Friday [13:01] ack [13:03] bzoltan, ever seen this before? http://paste.ubuntu.com/7663604/ [13:03] zbenjamin, ^ too [13:03] dpm, k [13:03] that's a crash on startup on current utopic [13:05] dholbach: no, but looks like the sensors plugin does something bad [13:07] dholbach: is this when starting QTCreator? [13:07] zbenjamin, yes [13:08] dholbach: what qtcreator-plugin-ubuntu package version do you have installed? [13:09] zbenjamin, http://paste.ubuntu.com/7663636/ [13:09] * zbenjamin wonders why QtC would initialize a accelerometer [13:10] nik90: have you had time to test the pullToRefresh stuff? [13:10] dholbach: looks like you have the most recent version installed [13:11] nik90: can you check that this branch has everything you need for the pull-to-add-alarm in clock-app? https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/pullToRefresh/+merge/219090 [13:11] dholbach: and it just starts and immediately dies? [13:11] zsombi_: sry, no [13:11] zsombi_: Can I test it this evening? [13:12] zbenjamin, http://paste.ubuntu.com/7663650/ [13:13] nik90: I'm doing a final review now. If you tell me this evening that it is good for you I can happrove it [13:13] dholbach: that looks suspicious "Ubuntu Platform API: Unable to find module configuration file -- Aborting" [13:13] zsombi_: ^^ [13:13] nik90: t1mp is reviewing it again, so if you have some issues, make a note in the MR [13:14] zsombi_: can you make any sense from that error? Ubuntu Platform API: Unable to find module configuration file -- Aborting [13:14] zbenjamin: no idea... [13:14] zbenjamin: or at least I don't remember what is teh issue there... [13:15] zbenjamin, the warning is from ./src/ubuntu/application/base_module.h in platform-api [13:15] looking for /etc/ubuntu-platform-api/application.conf [13:15] which is not shipped in any package [13:15] why would we do that? [13:16] hmm yeah i remember i saw that before but i could not reproduce it. Maybe its some special plugin that only loads when its installed? [13:16] zbenjamin, looks like a question for ricmm [13:17] I'm going to go over to the office now - should be back in 10m [13:17] dholbach: ok === dholbach_ is now known as dholbach [15:01] vthompson, ahh you are in here now.. I looked earlier === chihchun_afk is now known as chihchun === wendar_ is now known as wendar === gatox is now known as gatox_lunch [17:01] vthompson, o/ [17:01] 'ello! [17:02] vthompson, hows things going? [17:02] vthompson, crummy! [17:02] ha, man--I also need sleep [17:02] vthompson, has balloons got any hair left? or does he need some of mine [17:02] ahayzen, still trying to battle the tests [17:02] oh god :( [17:03] ahayzen, howdy [17:03] balloons, o/ [17:03] balloons, vthompson, so what is the situation now? (i've been at work all day) [17:03] I think as vthompsons has discovered, nothing is wrong with the test setup really.. instead, we don't know how to set it up to run [17:03] meaning, the implementation is fine, it's just wrong [17:04] ahayzen, we have the backing up of the dirs working now. Even adding a start and stop of ms2 and a sleep doesn't cause the app to see the new db [17:04] vthompson, yeah i tried start/stopping msw [17:04] *ms2 before [17:05] ahayzen, if you look in the ms2 logs it's picking up the files, it's just that the plugin isn't reporting the new db [17:05] i started looking into it and it uses some Qt thing for $HOME? i couldn't really figure it out [17:06] * ahayzen can't remember if the dbus part of the service was a separate process that didn't get stopped or something? [17:06] i'll fire up my VM so i can battle along with u guys :) [17:06] what I was suggesting to balloons over in #ubuntu-touch was that we perhaps ship the image with the test songs in ~/Music and then also create our own script that we run before and after we execute the tests manually. We'd also need to fix the desktop tests--which I haven't done yet [17:07] vthompson, so why doesn't moving ~/Music to ~/Music.bak and then filling ~/Music with the test data work? [17:07] vthompson, or does it bit thats the 2nd option in Alan's mail? [17:08] ahayzen, we're trying to do #2 and it still isn't reflecting what's in the new db [17:08] vthompson, ok [17:10] ahayzen, balloons, I'll be back in a bit--getting some lunch [17:10] vthompson, cool :) [17:11] popey, so you are in the loop, see above. The backup and restore still doesn't work :-) [17:12] balloons, popey was 'on holiday' for this afternoon no? [17:12] ahayzen, yes.. he'll see the log later [17:12] balloons, ah right :) [17:12] balloons, so we are trying to do option 2 right? [17:13] t1mp: ping [17:13] ahayzen, yes [17:13] balloons, ok i'm just updating my VM then i'm ready to rock until dinner :) === gatox_lunch is now known as gatox [17:21] balloons, that was odd it actually nearly worked the first time on utopic desktop [17:22] balloons, but is was weird because mediascanner2 crashed...apport came up... then music-app with the correct test library!... then the test failed because of the apport dialog... but when i run again it displays no music so i wonder what was different/caused mediascanner2 to crash? [17:23] balloons, it was as if the delay that apport created in starting the music-app was long enough for ms2 to rescan or something?! [17:29] ahayzen, so if mediascanner2 isn't running it worked eh? [17:29] victor reportedly tried stopping it before the test [17:30] balloons, well i haven't been able todo it again but it basically crashed while ap was starting [17:30] balloons, and then i guess as it was restarting it saw the test music files [17:30] hmmm [17:33] balloons, you have tried restart ms2 service after copying the files across right? [17:34] ahayzen, that's what I'm doing when testing on the device, also waiting 10 seconds afterward [17:34] vthompson, does it work? [17:34] ahayzen, nope [17:34] hmmm [17:35] tht is where i got up to last time IIRC [17:35] ahayzen, I take it you are just testing in your VM now [17:35] yep [17:35] vthompson, but it worked the first run! then won't do it again [17:35] ahayzen: just to confirm one last time, you wouldn't be able to make it to the meeting tomorrow afternoon? [17:35] vthompson, like ms2 crashed while ap was starting up and then it showed the correct library [17:36] ahayzen, odd [17:36] nik90, yeah sorry as we have music/coreapps back2back and i only get 1hr for lunch [17:36] ahayzen: no worries. I am going to cancel this week's meeting then [17:36] ahayzen: I will send a mail out later tonight [17:36] nik90, unless vthompson can make it :) [17:37] ahayzen: well even then we will only have 3 people in it which is less to start of with. [17:37] nik90, ahayzen, I *could* try to make it, but I should be out of the house by then [17:37] nik90, vthompson maybe we should try a different day/time that works a bit better? [17:37] damn work getting in the way of fun :P [17:38] ahayzen: tbh I have an exam next week tuesday, so I am going to need time to prepare for that. This is why I don't want to take work items this week anyway [17:38] nik90, ah good luck :) [17:38] ahayzen: also I really want to get bzoltan again in the meeting [17:38] ahayzen: thnx [17:41] nik90, yeah it was really useful having someone from SDK in the meeting [17:43] vthompson, ok so why does stopping and starting ms2 and waiting for a long period of time after doing create_music_library() not work? [17:44] ahayzen, if I knew I'd have fixed it by now [17:44] :) [17:44] vthompson, hah [17:44] ahayzen, I was suggesting earlier that it must be some sort of dbus/contention thing [17:45] vthompson, ok so wht about doing the process manually does that work? [17:45] vthompson, as in manually go and move your music folder, patch and restart ms2? [17:45] * ahayzen tries [17:45] ahayzen, like how I was suggesting? copying the files first then doing a restart of ms2? Yes that works--I haven't ran the whole test suite though [17:46] vthompson, yeah basically hmmm ok so what is different then :P [17:46] * balloons is following along [17:46] vthompson, how are you restarting ms2 just doing os.system("stop mediascanner-2.0") right? [17:46] ahayzen, some sort of issue with the plugin not seeing the updated db when the tests are running... I blame dbus [17:46] ahayzen, yep [17:47] vthompson, but wht is different in/out side of autopilot... [17:48] ahayzen, both are using dbus and, again, I blame dbus [17:48] hah [17:48] ahayzen, we probably just need someone who knows about this sort of stuff to help us out. I have no idea, thus I blame dbus [17:49] vthompson, any ideas on the 'someone who knows' :) [17:50] vthompson, why do we need to run patch_mediascanner_home() if we are just copying directly into ~/Music ? [17:50] maybe Thomas Voss? [17:50] vthompson, could you push to the branch? [17:50] ahayzen, we don't my local isn't doing it anymore [17:50] balloons, will do [17:51] * ahayzen is just looking at whtever was pushed [17:52] balloons, ahayzen, pushed. [17:52] vthompson, thanks [17:53] vthompson, yeah tht is basically wht i'm doing to restart it [17:53] ahayzen, you can also "tail -f /home/phablet/.cache/upstart/mediascanner-2.0.log" to see that the files are being added [17:53] so it looks like all should be right in the world [17:54] nik90: hello [17:54] t1mp: hey, I was testing zsombi's branch but got stuck at a few things [17:55] nik90: zsombi has many branches ;) [17:55] t1mp: sry, I was referring to the pulltorefresh branch that you wanted to review this evening [17:55] t1mp: I had trouble executing an example he listed in the MP. I will need to talk to him tomorrow morning [17:56] vthompson, nothing appears in the log when i run ap [17:56] t1mp: would you still be doing the reviewing today? [17:56] nik90: now that you remind me, yes :) [17:56] ahayzen, running from your VM? maybe the added stop/start is for click only [17:56] maybe [17:56] t1mp: lol [17:57] nik90: if something is wrong or unclear, please leave a comment on the mr [17:57] t1mp: ok. Will do in another 15 mins..having dinner atm [17:57] nik90: sure [17:57] thanks [17:58] vthompson, so i got this pastebin.ubuntu.com/7664879 [17:58] vthompson, so it looks like the files are appearing...but they don't appear in music-app ?! [17:59] ahayzen, yep. [17:59] vthompson, do u get the same for u on device? [17:59] ahayzen, you have now joined us in our confusion [17:59] yes [18:00] that's why I think the plugin just doesn't know that the db is updated until AP is done [18:00] vthompson, at least it is consistently weird rather than randomly weird like before :P [18:00] brb, I have to dial into another mtg [18:00] vthompson, cool i'll probably have dinner in a bit [18:03] vthompson, balloons, there is a process on my machine called mediascanner-dbus-2.0 that doesn't stop when i call 'stop mediascanner-2.0' ... could this be the issue? [18:04] ok, I have time now to dive deeper in this again.. heh, here goes [18:05] where did that process even come from i can't get it back now :P grrr [18:05] balloons, do u have a mediascanner-dbus-2.0 on your machine? [18:06] ahayzen, I have mediascanner-service-2.0 [18:07] balloons, i had another one it was weird... [18:07] balloons, yeah if u start the music-app notice that a dbus process starts up [18:08] ahayzen, yep /usr/lib/x86_64-linux-gnu/mediascanner-2.0/mediascanner-dbus-2.0 [18:08] balloons, could that be anything todo with it [18:09] balloons, also when the music-app closes dbus crashes at the moment.... and tht process doesn't disappear? [18:09] ahayzen, I just realized ms2 still thinks I have all the music that got wiped [18:09] haha [18:09] hah [18:09] and it's playing? [18:10] what on earth... [18:10] wtf as in playing or attempting to play? [18:10] no it's playing [18:10] maybe it has stored all ur music in a magical place [18:10] balloons, look at the music-app log it'll tell you the URL of the file it thinks it is playing [18:11] ahayzen, ohh interesting [18:12] it cataloged stuff from a phone backup [18:12] ah [18:13] it found music I didn't realize I had, so :-) [18:15] balloons, so running the mediascanner-dbus-2.0 manually works fine.... but if i run inside autopiliot it claims the the schemas of the db is an 'unsupported version' [18:15] balloons, ^^ maybe causing the 'no music found' issue [18:16] balloons, anyway i've go dinner now i'll be back in ~1hr [18:16] ahayzen, I'm gonna play with it manually === chihchun is now known as chihchun_afk [18:16] enjoy [18:16] balloons, i think it *may* have something todo with the dbus process not starting correctly [18:17] ahayzen, I can follow that line of thought [18:17] somehow it's not using the new db.. old process, whatever [18:27] * popey waves [18:27] hows it going chaps [18:27] summarise it for me in one word [18:27] F [18:27] https://www.youtube.com/watch?v=CH1Q738UEsQ [18:27] sorry, that's a letter [18:28] popey, I'm reading the latest between balloons and ahayzen, but really it seems that the plugin isn't getting updated when we make these changes while running the tests [18:29] this packaging process is ROUGH [18:31] Here for the distribution: http://bpaste.net/show/VwD6SRP5j9D3HvlxYq1b/ Do i put the lowest possible that i can support? [18:34] bluezone: debian packaging? [18:34] popey, well yeah i'm following this http://developer.ubuntu.com/publish/apps/other-forms-of-submitting-apps/packaging-commercial-apps-part-1-get-set-up-overview-of-debian-packaging/ [18:35] ah [18:35] That's the reviewer guy told me to double check because i seem to not be following it exactly [18:36] He told me i'm only allowed to save to home and /opt/ too? [18:37] vthompson, I'm on to something in regards to this [18:37] vthompson, it's important the mediascanner process also thinks HOME is where it should be [18:37] bluezone: yes, for commercial apps thats right [18:37] so I'm going to tweak things to start it with the proper env.. I notice it's still writing in home [18:37] balloons, but we aren't fiddling with the location of $HOME anymore [18:38] popey, so then how do i go about adding a launcher if i can't save in /usr/share/applications [18:38] vthompson, yes I know.. still [18:39] bluezone: not sure, I'm not a packaging expert, davmor2 may be able to help if he's around [18:39] It's not necessarily commercial but i guess i selected proprietary during the process haha [18:39] Ok thanks [18:40] bluezone: so Your application needs to live in /opt/appname and then anything it saves can live in /home/$user/appname preferably [18:40] bluezone: what did you need to know [18:41] bluezone: launcher is /usr/share/applications is fine [18:42] bluezone: it's the main app that needs to live in /opt/ see the dos and donts on this end of this link http://developer.ubuntu.com/publish/apps/other-forms-of-submitting-apps/packaging-commercial-apps-part-2-packaging-software-additional-notes/ [18:42] ok, i can also save to /usr/share/icons ? (Although for some reason my icon never appears as the launcher icon but that's a different problem) [18:42] ok [18:43] bluezone: again icons in /usr/share/icons/hi-color iirc is fine [18:43] bluezone: in your .desktop file you only need to name the icon not the path to the icon that might be the issue [18:44] yeah haha i'm going to try that thanks so much :) [18:47] vthompson, is this trunk for ms2? https://code.launchpad.net/~mediascanner-team/mediascanner/v2 [18:47] no updates in awhile.. surely I must be looking in the wrong place [18:47] balloons, no [18:47] let me get it [18:47] ty [18:48] https://code.launchpad.net/~mediascanner-team/mediascanner2/trunk [18:48] so vthompson one of the issues with backup / restore is it doesn't just look inside the Music folder [18:49] balloons, what do you mean? [18:50] vthompson, I'd really like to have better control over the ms service.. [18:50] I mean if you backup the Music folder, it's going to find and index that music anyway [18:51] if you have any music on the device other than the provided songs it will find it and index it [18:51] because it's still under home? [18:51] afaict [18:51] yes [18:51] yea, can we move it to /tmp? [18:51] hehe vthompson .. move every bit of media? I'm still messing with the patching concept [18:52] I believe if I can get the scanner to start with the proper context i should be good.. as it stands, it's ignoring me [18:52] I have your backup code included.. I'm happy to go either way.. I just don't see it as working [18:52] sadly ;-( [18:52] balloons, doesn't it seem to be the same issue as why the backup/restore isn't taking hold as well [18:52] ? [18:53] vthompson, yes.. I believe the issue is the same no matter how you do it. namely ms is ignoring us and indexing things and using it's db as it feels like [18:53] agreed, if we can get this issue resolved, going back to mocking seems possible and is clearly a better option [18:54] so again, I'm for the simplest thing possible.. I just need to find more about forcing ms to scan certain ways [18:54] I mean we shouldn't neven need to scan. we are patching the mediascanner db [18:54] I think I'll look at the ms2 code to see what mediascanner-dbus-2.0 is doing [18:55] vthompson, right.. most certainly we should be able to get ms to behave for us [18:55] I'm looking at the code now for insights ;-) [18:55] balloons, I almost think it's autopilot preventing mediascanner2 from being able to get things proper [18:56] vthompson, well actually since ap isn't launching it, that seems a bit off.. [18:56] that was my concern the other way.. that we were launching music inside AP with all our tweaks, but the service wasn't being done that way [18:58] balloons, I'm going to at least draft up an email to the ms2 guys and explain our testing issue and see if we can "command" ms2 to restart it's dbus connection, or otherwise pickup the latest db or a mocked db [18:59] vthompson, james should be around in a few hours [18:59] I'll pounce on him too [19:00] balloons, perfect. I'll add you to the email I send [19:00] If my copyright file is empty, so i still have to place an empty file in /usr/share/doc/$(package_name)/copyright ? [19:00] so -> do* [19:08] vthompson, mm.. tasty.. time to dive in and see if ms is taking our /home or not [19:09] balloons, good luck! Don't let it also take your hair! [19:09] OMGOMGOMGMOG [19:09] i can see my music!!!!!!!!!!!!1 [19:09] ahayzen, you mean test music? [19:09] yeah! [19:09] how, through what voodoo? [19:09] ahayzen is excitied :-) [19:09] by why is autopilot not clicking things... [19:09] but the music ! [19:09] win [19:10] how did you get it to pick it up? [19:10] ah its clicking things now just a massive delay [19:10] vthompson, it'll cost u ;) ... no i'll push/post a diff in a bit [19:10] 'Run 1 test in 92s Ok' :D [19:10] now to optimise [19:10] what's the tl;dr of the fix? [19:11] run dbus manually after waiting for ms to write the db [19:11] mediascanner-dbus-2.0? [19:11] yah [19:11] cool, I had tried to kill it and restart it, but that wasn't doing anything for me [19:12] so, that means we might be able to go back to mocking [19:12] hmm maybe [19:13] terminate called after throwing an instance of 'std::runtime_error' [19:13] what(): Tried to open a db with an unsupported schema version. [19:13] Aborted (core dumped) [19:13] this whole time I assumed the fix was 1. setup 2. shotgun to dbus 3. run test [19:13] is our mocked db correct? [19:13] balloons, put a sleep between starting ms2 and running dbus [19:13] looks like I was right ;) [19:13] balloons, i put a 10s sleep and it was fine [19:14] balloons, i assume it is because ms2 has the db open and is writing to it so if u wait for it to finish then it works [19:14] * ahayzen would post a diff but xterm won't copy grrr [19:15] ahayzen, you aren't calling dbus first? If I call mediascanner first it seems to not work [19:15] no u start mediascanner2 first [19:15] it rescans [19:15] then start dbus [19:15] balloons, pastebin.ubuntu.com/7665194 [19:16] vthompson, balloons ^^ is working for me it is a bit slow but gets there [19:16] balloons, i can commit'n'push if u think it looks good but it needs cleanups etc [19:17] ahayzen, I'm going to try reverting the backup/restore and add the dbus call [19:17] vthompson, cool shall i make mine cleanup etc so it is ready as a fallback? [19:17] vthompson, I confirmed ms sees the fakehome [19:18] \o/ [19:21] cool.. ok, so it's not writing files in /home anymore [19:21] balloons, so is this it ? we're on the way to getting it working lol? [19:23] ok, so if you use subprocess and copy the env and launch with it, all is well with the mocking it seems.. [19:23] balloons, awesome! [19:23] ahayzen, this line is going to be a problem.. it's arch specific [19:23] os.system('/usr/lib/x86_64-linux-gnu/mediascanner-2.0/mediascanner-dbus-2.0 &') [19:24] balloons, can we not detect? [19:24] ahayzen, we'll do what we need to do :) [19:24] yea, also 'killall' isn't found on phone [19:24] vthompson, pkill ? [19:24] ahayzen, yep, pkill is there [19:24] \o/ [19:26] Calling this seems to work: /usr/lib/*/mediascanner-2.0/mediascanner-dbus-2.0 & [19:26] balloons, so we need it to do arm-linux-gnueabihf/x86_64-linux-gnu/i386-linux-gnu? is there no way of it just ... oh ^^ [19:26] ahayzen, yes there's many ways.. vthompson's way my end up being fine [19:27] it could call several dbus's :-) [19:27] or blow up.. unsure which would happen [19:27] perhaps blow up [19:27] vthompson, yeah tht works :) on my machines [19:27] in looking at what kill options were avail on the device I accidentally ran killall5--which was new to me [19:28] needless to say it killsall in a very brutal fashion [19:28] vthompson, i think the only reason that process stays around is because our app crashes with dbus errors at the moment? [19:29] vthompson, because if u restart ur machine and start ms that dbus process doesn't exist? [19:29] ahayzen, not sure [19:29] vthompson, but it need restarting anyway [19:33] ahayzen, balloons, I can't seem to kill it on the device [19:33] vthompson, same [19:36] vthompson, hmmm how can we kill it on device then? [19:36] well, you can kill -9 it [19:39] vthompson, does that work on the desktop as well? [19:41] ahayzen, my bash-foo is not very good this afternoon. we can get the pid here: "ps -L u n | tr -s " " | grep mediascanner-dbus-2.0 | grep -v grep | cut -d " " -f3" and then do a kill -9 of the pid [19:42] vthompson, blimey.... [19:44] vthompson, pidof /usr/lib/arm-linux-gnueabihf/mediascanner-2.0/mediascanner-dbus-2.0 ? [19:45] ahayzen, yea, that works [19:45] :) [19:45] vthompson, so now to put the /*/ and add it to autopilot.... then win ?! [19:47] vthompson, are you adding it to the autopilot.... is balloons? or am i ...i'm lost who is trying/doing wht now lol [19:47] ahayzen, I'm just seeing if I can get it to work on the device [19:48] I'm still having fun chasing env -) [19:49] hah === karni is now known as karni-holiday [19:55] ok, I think last thing is the provided db isn't correct [19:55] is backup / restore working on device too? [19:55] balloons, for the env u'll have to use Victor sql patching right? [19:56] ahayzen, for mocking yes.. dbus complains the db is invalid.. and I get no music. However, it writes the files properly, etc. So I think that's the only thing left to solve [19:56] hmmm [19:56] mm.. well, whoops, one more thing to change [19:56] balloons, could you push that? [19:56] vthompson, it is quite a mess, but yes I'll push it, heh [19:57] balloons, we can tidy it up :) [19:57] balloons, I don't know what I did, but suddenly my device can't find the tests module for music_app... [19:57] so I might revert to trying to test on my vm [19:58] vthompson, probably should push the tests again [19:58] adb push tests/autopilot /home/phablet/autopilot [20:01] balloons, doesn't click-buddy --dir . --provision do this? [20:02] vthompson, yes it does [20:23] balloons, ahayzen, this is like pulling teath [20:24] vthompson, whats up? [20:24] * ahayzen is patiently waiting for all the ap tests to run on his VM [20:24] ahayzen, still can't get the tests to run on the device [20:25] ahayzen, I'm trying to go the route of mocking still though [20:25] vthompson, what happens? [20:25] vthompson, there's alot you need to mock [20:25] vthompson, let me clean and push.. I'm fairly confident I've mocked properly now.. it took a bit [20:26] balloons, then we can all run on our devices/vms \o/ [20:26] ahayzen, same issue as before--not using the test music [20:26] however, it doesn't like the db we are supplying [20:26] vthompson, hmmm :/ [20:26] ah [20:26] so the service blows up.. but that's progress :-) [20:26] ahayzen, even better then that, then we can push to trunk, to the store and solve world hunger! [20:27] and i can propose my mp to remove grilo :) [20:27] yeah aha all our bugs will be fixed! ... not [20:31] I guess I'll push straight to the branch? I don't want to overlay what you might find useful [20:31] vthompson, ahayzen what do you think? ^^ [20:32] balloons, yeah thts fine with me [20:33] balloons, fine w/ me. I've stashed away the changes I was making [20:33] k, pushing [20:33] rev 505 [20:33] \o/ [20:34] 'slightly saner version ' :) [20:34] so vthompson to further the mocking effort I use subprocess env=env and also set the upstart env HOME..it's crazy [20:34] well, it is insane that the tests would actually run [20:35] balloons, shouldn't 'killall mediascanner-dbus-2.0' be ... 'kill -9 `pidof /usr/lib/*/mediascanner-2.0/mediascanner-dbus-2.0`' ? [20:35] I didn't bother fixing the horrible os.system calls at the top [20:35] balloons, as the device doesn't have killall [20:36] ahayzen, yes.. it should be whatever you and vthompson determined to work [20:36] balloons, ah cool [20:36] balloons, vthompson, shall i mod those and add the cleanups? [20:36] ahayzen, feel free to clean at will. I'm going to look at the db now [20:36] 'Ran 17 tests in 1277s ... 1 failed' .... so close [20:36] ahayzen, sure go for it [20:37] cool [20:37] notice the output from launching ms " terminate called after throwing an instance of 'std::runtime_error'\n what(): Tried to open a db with an unsupported schema version" [20:37] balloons, are u waiting long enough? [20:37] ahayzen, I'm assuming there's a db problem.. maybe not though [20:38] balloons, where does urs start dbus? [20:38] mm.. actually since dbus doesn't use usptart we could pull that bit out [20:38] the starting of dbus needs to change so the armhf version will also work [20:39] hehe more tweaks [20:39] let me split them again [20:39] balloons, shall i continue moding or wait lol [20:39] no we won't overwrite each other [20:40] keep going [20:40] it'll merge fine [20:40] balloons, cool shall i resolve ur long lines....PEP8 is gonna catch us otherwise ;) [20:40] I'm not worried till it's done [20:41] i pushed [20:41] cool i'll pull [20:42] yey text conflicts :) [20:42] guess I lied [20:46] balloons, pushed my cleanups could u check over them [20:46] balloons, also don't think we needed killall mediascanner-service-2.0 as stop mediascanner-2.0 does tht === salem_ is now known as _salem [20:47] balloons, changes here http://bazaar.launchpad.net/~music-app-dev/music-app/use-mediascanner2.0/revision/507 [20:47] cool [20:47] ahayzen, balloons, agreed that we don't need killall ms2 [20:47] :) [20:48] balloons, right i'm just pulling down to my VM so ur issue is the db ? [20:48] something about starting it isn't working on my device though [20:48] vthompson, I dumped the schema and it does seem different than what's in there now [20:49] balloons, vthompson, it is running on my VM and is showing the correct library...haven't seen the console output yet though [20:49] balloons, why do we need to '#wait a few seconds for the magic' ? [20:50] balloons, is that as the mocking stuff is running? [20:50] ahayzen, it probably isn't needed... [20:50] it's working for you though? [20:51] balloons, at the moment it is just sitting with the app launched doing nothing... [20:51] i'm working on changing the schema to match what I see now [20:51] balloons, but i can see that the app has the correct library [20:51] balloons, note this is on a utopic VM .. not device [20:52] wtf i move the window (so i can see the console) and then it says 'ran 1 tests in xxxx Ok' [20:54] ahayzen, yea, I'm running on utopic too [20:54] uhoh something has corrupted my ~/Music so it contains the test music :P FFS [20:56] few at least the old patching is working i thought i may have mistaken it for working when it wasn't.... [20:57] *phew [20:58] vthompson, what state is yours in? [21:00] ahayzen, not working the device tests stop after starting ms2 [21:00] vthompson, ok have u got a VM to test in? ... i'm just about to try my device... [21:02] ahayzen, I do. I'll run a test there as well [21:03] ahayzen, on my vm it didn't like the kill command and my library is still shown [21:04] the kill cmd will appear in the console if the dbus process wasn't running [21:04] vthompson, and yeah my library is broken in that as well :/ [21:04] vthompson, i thought it was working for a second but a previous run had copied the test music to ~/Music lol [21:05] ahayzen, I'll put my update to the kill in and push [21:05] vthompson, is there a way to get it to do nothing if the proc isn't found? [21:05] k, time to try with the new db [21:06] ahayzen, yea, my branch kinda does nothing in that case [21:06] vthompson, ok [21:06] vthompson, same [21:07] ahayzen, pushed. the test still hangs for me on the device [21:08] vthompson, cool looks good [21:09] ahayzen, oh I need to fix it a bit [21:10] ahayzen, why are we doing a kill -9 on the mediascanner service? [21:11] vthompson, mediascanner-dbus-2.0 [21:11] vthompson, the dbus service [21:11] vthompson, if u run the music-app and then close it this process is still running... and it needs to be stopped or bad things happen [21:11] vthompson, i think it doesn't stop because of those dbus errors on exit of the app [21:12] vthompson, oh no u mean my cleanup [21:12] vthompson, yeah thts a typo that should be -dbus- not -service- [21:13] * ahayzen fixes [21:14] ahayzen, there are a few things wrong here. We also need to use balloons's env stuff in the subprocess calls [21:14] * ahayzen pushes... [21:14] vthompson, which subprocess calls? [21:16] I'll try to fix em [21:16] vthompson, i just fixed the -service- which should have been -dbus- [21:19] having a little trouble making the db [21:23] balloons, whats happening? [21:25] ahayzen, vthompson sorry.. t-storm here lost power [21:25] uhoh [21:27] balloons, mother nature does not like the idea that we are getting closer [21:27] hah [21:28] lol [21:32] on my VM I get the wrong music, but the test I'm using says it passes after 74 seconds [21:33] vthompson, yeah same lol [21:35] vthompson, balloons, so what is going wrong is the patching of the DB? [21:41] ahayzen, well I'm not able to get it to build a db that passes through patching [21:41] :/ [21:42] vthompson, you don't build the whole db on the fly, but just massage a table or two [21:42] balloons, what you might need to do is redump the db to an sql file of commands and use the same table I have in the sql file [21:43] that's what I've tried [21:43] what's changed? [21:43] I guess I should say.. dbus doesn't like it [21:43] * ahayzen hides [21:43] vthompson, turns out I think it was the same.. your media table tho is smaller. and the schema is 6 now not 5 [21:43] but your bigger dump seems to have all the columns missing from media [21:44] it's weird why your insert is different [21:44] can you post your dump to a paste? [21:46] ohh.. that's a problem [21:46] still has your old schemversion in it :-) [21:46] so it has 2 rows, hehe [21:46] there's lots of extra junk in here actually [21:47] looks like schema 6 added a width, height, latitude, and longitude field to the media table [21:48] yep, that's pretty much it [21:48] gonna remove the extra row and try [21:58] ok, trying again [22:00] so you're trying to 1) caputure the new db with the test songs, 2) dump the db to an sql file and 3) update that file to just have the media table? [22:01] vthompson, so I updated your old db to have the new schema version, and I emptied all the other tables [22:01] hm [22:01] that might work, it would have been easier to put the test songs on the device and caputure the resulting db file [22:01] lol [22:01] perhaps I'll do that now [22:02] now mediascanner doesn't seem to finish starting up [22:02] err wait no [22:02] it started,, [22:02] then you can dump it to sql and truncate the file to just drop and create the media table [22:06] * balloons deletes pics and videos [22:08] ok, trying again with the new db [22:10] vthompson, I pushed what I have [22:11] bah, diverged branches? [22:11] you prob need to pull [22:11] yea, done.. rev 509 [22:12] so mediascanner-dbus doesn't crash on load anymore, but it's spinning [22:13] balloons, mine is just sitting there at the bit trying to kill mediascanner-dbus [22:13] I'm going to try on the device now heh [22:15] balloons, oh no i can see it is stuck at 'launching mediascanner-dbus' when running with -v not killing [22:15] btw, if backup / restore is / was successful, let's have it ready to slide in :-) [22:15] ahayzen, yes it hangs there now [22:15] balloons, shall i add that as a fallback branch? [22:15] looks like the same result on the device [22:15] balloons, mine was working other than 1 test IIRC [22:15] well we have to call it at some point [22:16] so, next I guess we should trace the run for dbus and see what'sup [22:19] ahayzen, yea go ahead and incoporate what's needed and what we're learned [22:20] I think at this point we can push it on top.. unless vthompson has other ideas [22:20] so ahayzen what you had working on the vm was for backing up/restoring right? [22:21] vthompson, yeah [22:21] vthompson, hang on i'll figure out the best way of getting the code off the VM .... [22:21] let's try to get that working on the device as well and we can call it good [22:21] yep, I'm down with that [22:21] vthompson, gimme like 5-10 mins need to revert/copy code across push [22:23] ahayzen, sounds good [22:27] slowest bzr push ever! [22:27] tracing the launch shows dbus launches and looks good.. weird [22:29] balloons, vthompson, does this work for u on ur VM? https://code.launchpad.net/~music-app-dev/music-app/use-mediascanner2.0-fallback-plan [22:29] it does take a while to click the first thing which is weird... [22:30] ahayzen, tyring on device [22:31] balloons, i've never tried tht one on device that could be interesting ;) [22:31] balloons, it runs on my VM :) [22:31] Hi [22:32] ahayzen, I'll try it on my VM [22:32] vthompson, cool :) [22:32] sh: 1: /usr/lib/*/mediasscanner-2.0/mediascanner-dbus-2.0: not found [22:32] vthompson, it doesn't have ur protection to kill mediascanner-dbus [22:32] see the error.. that said, it works [22:32] balloons, yeah tht should be fine? thts because the process it not running when it tries to kill it [22:33] balloons, the branch just needs vthompson's protection he added to the other [22:33] ahayzen, ohh, heh.. right :-) I thought it was happening later lol [22:33] anyways, looks good.. I say we ship it [22:33] balloons, but did it run correctly? [22:33] hah win \o/ [22:33] my head hurts on this mocking stuff again.. but we are much closer [22:33] balloons, only problem is i think 1 test failed when i tried on my VM [22:34] ahayzen, doesn't appear to show the correct music on my VM [22:34] and the calls to kill and start dbus don't seem to work [22:34] vthompson, wht? :( [22:34] vthompson, yeah the kill i would expect but it should show the right music [22:35] eh, pastebin is down [22:36] well.. works on my device.. ship it! [22:36] :-) [22:37] 'works for me' lol [22:37] ah damn i just broke it missing import... [22:38] i'm surprised it's not working for you [22:38] ok, I take that back.. that's not surprising I guess [22:39] vthompson, i tried added ur try except in and it still outputs the error in the console ... did that not work correctly or something [22:39] balloons, so it works for me and u...thts 2 vs 1...ship it! [22:39] wait.. I'm an idiot [22:40] balloons, you left the files in ~/Music didn't u? [22:40] ahayzen, I like your style [22:40] no, nothing wrong with yours ahayzen .. I confirmed it's backing up properly tas well [22:40] ahayzen, well if it isn't working on the device thats 2 vs 4, so I win [22:40] my branch has a wait on the dbus call [22:40] it works too [22:41] lolololol [22:41] balloons, hang on wht the preferred branch is working? [22:41] ahayzen, vthompson the dbus call was check_output.. it was just waiting forever [22:42] balloons, omg explaining it just sitting there :) [22:42] ROFL [22:42] balloons, push it [22:42] balloons, ha [22:42] man [22:43] "given enough eyeballs, all bugs are shallow" [22:43] ....as long as they aren't sleepy eyeballs [22:44] If we're dealing with shallow bugs, I don't want to see the deep ones [22:44] haha good point ;) [22:44] +1 [22:45] brb [22:46] i pushed rev 510. see what you think [22:46] we're shipping something [22:47] ooo, looking good on VM [22:47] ^ first time that's been true for me [22:47] vthompson, heh. woot [22:48] * ahayzen returns [22:49] running on my device now [22:49] andrew's finished.. one error on test_artists_tab_album [22:49] perhaps something we need to fix [22:49] This is what I get on the device: http://paste.ubuntu.com/7666084/ [22:50] balloons, what was the error i'll take a look [22:50] balloons, ur branch is working on my VM aswell \o/ [22:50] # stop mediascanner-2.0 [22:50] stop: Unknown job: mediascanner-2.0 [22:50] root@ubuntu-phablet:~# start mediascanner-2.0 [22:50] start: Unknown job: mediascanner-2.0 [22:51] ^^ tht isn't right is it? ... on device? [22:51] can't do it as root [22:51] oh [22:51] it's a user service [22:51] need to be phablet [22:51] vthompson, did urs pass in the VM ... mine 'passed' but didn't actually click anything [22:52] ahayzen, same. [22:52] which would make me believe it did nothing [22:52] balloons, any idea wht is going on? the app starts... then it just sits there not clicking anything and after 75s outputs 'pass' [22:53] ahayzen, was your branch doing the same [22:53] ok, so that sounds quite odd [22:53] ? [22:53] vthompson, mine was clicking things fine IIRC [22:53] on the device ahayzen's branch ran through things [22:54] balloons, its the main branch which has this oddity [22:54] hm [22:54] well back to shipping ahayzen :-) [22:54] * vthompson moves back over to testing ahayzen's branch [22:54] one does not simply 'ship ahayzen' [22:54] we can pick up the mocking silliness later.. should look at the one failed test and fix it [22:55] ok [22:55] ahayzen, we might need to fix your kil/start of dbus [22:55] vthompson, i added ur bits to my branch if u pull [22:55] seems like it might have worked this time around, but it didn't start dbus and it also isn't clicking anything [22:55] ahayzen, ah [22:56] still couldn't start dbus... but that might be OK? [22:56] still doesn't click anything [22:56] vthompson, yeah i think so...note it takes like 30s to click something [22:57] idk whts going on there [22:57] ahayzen, vthompson I'm an idiot again [22:57] I have a sys.exit() at the top of test_music [22:57] lovely [22:57] \o/ [22:57] I must have pushed it also [22:57] 3 != 2 ... ok ... [22:58] looks like one of our tests is actually properly failing? [22:58] maybe one of the filters with mediascanner2 is slightly differnt.... [22:58] * ahayzen investigates [22:58] the test_artists_tab_album one [22:59] well, I think I ctrl+c'd out of a test and things wheren't restored [23:00] ah i think i did tht before i'm assuming thts how my ~/Music suddenly had the test files in it [23:00] balloons, does the main branch now work ? lol [23:00] ahayzen, stay focused :-) [23:01] to many things! [23:01] balloons, ok so on the fallback branch why does autopilot take like 30s to click something? [23:01] ahayzen, no idea [23:01] any messages? [23:02] do we have a sleep stuck somewherE? [23:02] i can't see the console its behind the app hang on [23:02] ahayzen, main branch does the same I see [23:02] if it's the same, it's dbus timeouts [23:02] balloons, I'm running verbose and I don't see any console logs [23:03] same [23:03] oh no yeah dbus timeout [23:03] just saw one [23:03] ok, well on the main branch it sits for a long time.. prints 19:01:43.443 ERROR proxies:410 - Introspect error on :1.304:/com/canonical/Autopilot/Introspection: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) and then it goes [23:03] balloons, yeah thts wht i get then after a few seconds it starts clicking things [23:04] vthompson, can u look at the code for test_artists_tab_album why does it think there should be 3 tracks in the queue when there are only 2 tracks for the artist it is playing? [23:04] vthompson, is that because our music has changed? [23:04] I'll take a look [23:05] balloons, is that anything todo with us or is it autopiliot itself? [23:05] I do see console errors now, but paste is doen [23:05] down [23:05] vthompson, about line 523 in test_music.py is where it fails [23:06] Here's the error I get before it clicks on stuff: http://pastebin.com/gepn8CWF [23:06] vthompson, yeah same [23:11] ahayzen, yea, that should be 2. Really it should be 1, but one of the other dummy files is counted as being in the same album [23:11] that might be because of our messing with dbus.. which autopilot also uses [23:12] since it eventually works, I don't see it as a blocker [23:12] agreed and agreed [23:12] vthompson, should i or u update it to 2? [23:12] I can do it, running that way now [23:13] cool [23:13] you could add back in the sleep I had before laucnhing [23:14] that might help.. but likely you'll end up waiting either way [23:14] yeah i guess ... but it 'works' thts the main thing :) [23:15] balloons, vthompson, right i propose to propose the fallback for merging so jenkins can have a go at it? [23:16] balloons, vthompson, oh pep9 may spectacularly fail first [23:16] * ahayzen starts patching [23:16] would it be hard to just merge it into the currently proposed use-mediascanner2.0? [23:16] ahayzen, ohh yea [23:16] vthompson, could we not keep the use-mediascanner2.0 as a WIP solution to getting the isolation working? [23:17] we could, but it also has all the activity up until this point [23:17] ahayzen, either way is probably fine [23:18] hmm [23:18] and it has the bugs linked... [23:18] but then it has the progress of the isolation which nearly works :/ [23:18] yours only differs in that it doesn't have the isolation? [23:19] It's just that we already have been doing a code review on this, to review another merge is kinda silly [23:19] we could merge back ahayzen's branch and include both ways in __init__.py to be solved later [23:19] it should be the same merge [23:20] the main branch does work (since I took out the sys.exit, lol), but mocking doesn't seem to work on the device (story of our lives) [23:20] balloons, vthompson, pep8 fixes done :) [23:20] balloons, does the fallback work on device? [23:20] ahayzen, your branch times out before launching on my device [23:20] ahayzen, yes we've established that [23:21] I'm running the test_mp3 test [23:21] well it works for me [23:21] hmmm conflicting info there [23:21] vthompson, feel free to try the main branch on your device if you wish [23:21] I'm going to merge back ahayzen's branch and have backup/restore be the default [23:21] and we can merge it [23:21] that way the isolation code stays in [23:21] balloons, yeah i don't wanna lose that [23:21] balloons, as it is soo close [23:22] hm, I get timeout on the device for the main branch as well [23:23] timeout: http://paste.ubuntu.com/7666207/ [23:26] balloons, I pushed the test_artists_tab_album test fix to the main branch, r514 [23:26] vthompson, what image #? [23:27] balloons, I'm on 87, IIRC [23:27] system settings won't run right now [23:27] vthompson, yeah i usually have to restart the phone after running autopilot some crazy stuff happens [23:28] balloons, vthompson, ok just ran the fallback on my device and got 'no music found' [23:28] yea, rebooted. Could also have been why I was timing out during the test [23:28] vthompson, same [23:28] ok, I think I've merged the branches [23:29] here are my two logs...install http://pastebin.ubuntu.com/7666215/ and the running http://pastebin.ubuntu.com/7666213/ [23:30] balloons, rebooting the phone also causes the app not to time out anymore... [23:30] trying andrew's branch [23:30] magic [23:32] ahayzen, balloons, fantastic, andrew's branch works on the device. trying the main branch now [23:33] I'm inprocess merging andrews branch back.. just testing it now for sanity [23:33] balloons, vthompson, ok i can see my branch working now ... the restart fixed it :) [23:34] funny that we'd see the same issue [23:34] vthompson, probably because we both tried a failed ap earlier? i know i did [23:35] 'Ran 1 test in 94.622s [23:35] OK' \o/ [23:35] on your branch right? [23:35] yeah [23:35] the main branch still sees the user's library [23:35] on my device [23:35] now wht was wrong with the main branch that means we need to merge mine... [23:35] ah tht [23:35] vthompson, have u restarted ;) lol [23:35] balloons, ahayzen, something small is probably just missing from the merge [23:36] main branch merge with andrews needs more tweaks [23:36] working on it [23:36] vthompson, if it is something small tht is stopping the preferred branch can we not investigate tht .... or is it something more serious? [23:38] got it [23:38] ahayzen, I was assuming it was small. balloons is looking into what it is I'm sure [23:38] vthompson, yeah it does the same on my VM just displays whtever is in ur real library [23:39] balloons, so the main branch is now actually the fallback branch with the isolation code still there but not being used? [23:39] or have i misunderstood whts been going on lol [23:40] balloons shoots and he scores! [23:40] yep! [23:40] ahayzen, yes.. rev 517 [23:40] :D [23:41] now time to test on device... [23:41] so, one minor thing is that our call to start dbus with the * in it doesn't work on my vm... but maybe we don't need that call? [23:41] * ahayzen wonders how long jenkins will take to catch up [23:41] ahayzen, device actually worked for me [23:41] flake8 that and I think we're good.. I blocked the two methods so it should be as simple as removing one block and uncommenting the other in a few places [23:41] which call in particular? [23:41] awesome [23:42] the call to start mediascanner-dbus-2.0 [23:42] I think we just need to kill it [23:42] starting ms2 probably starts it if it needs it [23:43] hmmm maybe i thought the starting was important... [23:43] also, do stopping and starting the ms2 service need to be a cleanup task? [23:44] vthompson, yep tht restores it back to the users one [23:44] vthompson, you should end up with the same processes/state after running the tests then [23:44] ahayzen, ah right [23:44] vthompson, definitely need the kill of mediascanner-dbus [23:44] but the cleanup to kill dbus is probably not needed [23:44] hah [23:45] really [23:45] why [23:45] vthompson, as tht is the one tht causes the issue in the first place isn;t it? [23:45] yea, but only because of our dbus issue while running [23:45] vthompson, yeah but i think it is cleaner to stop the processes we are manually starting within ap [23:46] well, I also dont think we need to start dbus, just axe it [23:46] execution style [23:46] vthompson, try taking it out... i think maybe just the first kill is important if it is already running then? [23:47] ahayzen, that's my theory [23:47] :) [23:47] * ahayzen tries on his VM [23:48] ok, flake8 is happy now [23:49] * balloons runs on device again [23:49] vthompson, so remove the manual start of dbus and the cleanup... i've left the restart of mediascanner2... tht works for me [23:49] I pushed my cleanup [23:50] vthompson, check that if u start the app normally afterwards tht u can see ur real lib [23:50] I left the restart of ms2 as well [23:50] vthompson, yep agreed [23:50] ahayzen, good point [23:50] vthompson, time to try on device [23:51] ahayzen, ok, I did have to kill dbus again [23:51] I'll readd it [23:51] interesting [23:52] thought there was a reason it was there...but i assume if our app closed correctly tht process would be closed if no other apps were using the QML plugin? [23:54] vthompson, yeah it does need killing my device just finished [23:55] ahayzen, yea, I just repushed [23:55] reverted it [23:55] vthompson, cool retest time [23:56] ok jenkins should come back happen next run [23:56] balloons, so we also need to figure out what's up with jenkins [23:56] vthompson, pyflakes etc [23:56] hm [23:56] vthompson, it is a few rev's behind [23:56] vthompson, yep and it's fixed [23:57] I've kicked off 520 manually to catch it up :-) [23:57] :) [23:57] balloons, ok so if this is actually good and passes... will it then land in the store? [23:58] ahayzen, ohh yea.. fore sure [23:58] balloons, i'm asking as i need to know when to propose my branch to remove grilo from the image? [23:58] I'll push it asap [23:58] as soon as it's merged, it's store time [23:58] balloons, ok and then ^^ mp will unblock Qt5.3 :D [23:58] ahayzen, as soon as this is merged, propose it :-) [23:58] balloons, will do :D [23:58] balloons, then time to tick things off in trello [23:59] * ahayzen hopes Jenkins doesn't cause us pain [23:59] +1 [23:59] #520 = perfect on device for me