| veebers | thomi: hey when you have a moment I would like to run something past you | 01:30 |
|---|---|---|
| thomi | veebers: shoot | 01:31 |
| veebers | thomi: recent changes to the application launch code (in AP) has introduced a docs / api difference: http://pastebin.ubuntu.com/7661258/ | 01:31 |
| veebers | in this instance the argument used to be expected to be named 'launch_dir' and currently states that in the docs, but the actual argument name in the method is 'cwd' | 01:32 |
| veebers | considering that this code has already been released (although not that long ago) I'm considering just re-naming 'cwd' to be 'launch_dir' so that the docs and the arguments match up with what existed before this change | 01:32 |
| thomi | are people hitting this as an API incompatibility? | 01:33 |
| veebers | but that might trip up anyone who has recently read that docstring and is using cwd (as opposed to the developers who used launch_dir before this change) | 01:33 |
| veebers | thomi: balloons is using launch_dir (as the docs state it's the thing to use) and it throws an exception (as its expecting 'cwd' instead) | 01:34 |
| thomi | veebers: well, if you want to be super safe, ue both, but give a deprecation warning for the one you want to phase out | 01:34 |
| thomi | you can then scan the test run logs for the warning and fix up any test suites that use the old one | 01:35 |
| veebers | hmm, ok, that sounds better than just changing it back and letting people hit the error | 01:35 |
| veebers | cool, that is the safest option I think. Cheers thomi | 01:35 |
| thomi | nw | 01:36 |
| veebers | thomi: I've changed my mind :-) I'll be running all the test suites as part of the autopilot release anyway. I'll remove 'cwd' put 'launch_dir' back in place, and during release testing I can scan the logs for any failing tests due to using 'cwd' | 01:46 |
| thomi | veebers: that works as well | 01:50 |
| veebers | coolio cheers. It's also much less typing ;-) | 01:51 |
| === vrruiz_ is now known as rvr | ||
| thomi | barry: Are you around? | 23:47 |
| veebers | thomi: do you have a moment for a quick question? | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!