[01:30] thomi: hey when you have a moment I would like to run something past you [01:31] veebers: shoot [01:31] thomi: recent changes to the application launch code (in AP) has introduced a docs / api difference: http://pastebin.ubuntu.com/7661258/ [01:32] in this instance the argument used to be expected to be named 'launch_dir' and currently states that in the docs, but the actual argument name in the method is 'cwd' [01:32] considering that this code has already been released (although not that long ago) I'm considering just re-naming 'cwd' to be 'launch_dir' so that the docs and the arguments match up with what existed before this change [01:33] are people hitting this as an API incompatibility? [01:33] but that might trip up anyone who has recently read that docstring and is using cwd (as opposed to the developers who used launch_dir before this change) [01:34] thomi: balloons is using launch_dir (as the docs state it's the thing to use) and it throws an exception (as its expecting 'cwd' instead) [01:34] veebers: well, if you want to be super safe, ue both, but give a deprecation warning for the one you want to phase out [01:35] you can then scan the test run logs for the warning and fix up any test suites that use the old one [01:35] hmm, ok, that sounds better than just changing it back and letting people hit the error [01:35] cool, that is the safest option I think. Cheers thomi [01:36] nw [01:46] thomi: I've changed my mind :-) I'll be running all the test suites as part of the autopilot release anyway. I'll remove 'cwd' put 'launch_dir' back in place, and during release testing I can scan the logs for any failing tests due to using 'cwd' [01:50] veebers: that works as well [01:51] coolio cheers. It's also much less typing ;-) === vrruiz_ is now known as rvr [23:47] barry: Are you around? [23:59] thomi: do you have a moment for a quick question?