=== _salem is now known as salem_ === salem_ is now known as _salem [07:54] Saviq, czesc [07:54] Saviq, do we have a silo :) [07:54] Cimi, whatup? [07:54] ? [07:55] Cimi, let's see if I can get another one for us... [07:56] Cimi, I could also build you packages, that'd probably be even quicker [07:56] Saviq, I can do that as well [07:57] Cimi, even better [07:57] Saviq, I wanted to test it properly [07:57] camera app as well [07:57] Cimi, that's properly enough ;) [07:57] Cimi, building packages yourself and getting them on a phone is properly enough [07:57] at least until we're limited on silos [07:58] s/until/while/ [08:14] Saviq, I did sbuild update [08:14] Saviq,but now still having same issue as yesterday [08:14] libunity-mir-dev:armhf : Depends: libplatform-api1-dev:armhf but it is not installable [08:17] Cimi, try with a fresh chroot, looks like you have some dirty in there [08:18] yeah I was googling for the wiki [08:18] need to add to the bookmarks [08:18] Cimi, v [08:18] https://wiki.ubuntu.com/SimpleSbuild [08:18] Cimi, you could also use `click chroot` to bootstrap [08:19] Cimi, depends how much power you want to maintain [08:24] MacSlow, there are inline comments from my review on 06.06 in https://code.launchpad.net/~macslow/unity8/combo-button-support/+merge/221499 that you didn't address [08:25] * Saviq will say "see inline comments" in reviews now [08:25] MacSlow, and there's a new ap test failure [08:25] https://code.launchpad.net/~macslow/unity8/combo-button-support/+merge/221499/comments/535010 [08:35] Saviq, nope [08:35] Saviq, removed all chroots [08:35] Saviq, still same issue [08:35] Cimi, are you by any chance using proposed in the chroots? [08:35] mk-sbuild --target armhf utopic [08:35] Saviq, that might be [08:36] Cimi, --skip-updates --skip-proposed [08:36] SKIP_UPDATES="1" [08:36] SKIP_PROPOSED="1" [08:36] or that in ~/.mk-sbuild.rc [08:36] Saviq, I have without the " " [08:36] SKIP_PROPOSED=1 [08:36] Cimi, pastebin the whole log [08:37] Cimi, you should have a .build symlink to it [08:37] wherever you invoked sbuild [08:42] http://paste.ubuntu.com/7662639/ [08:45] Cimi, jeez, it's UITK that's broken (for 3 months now) ;( [08:46] Saviq, which doesn't answer the doubt, why is it working for you? :D [08:46] Cimi, I used a dirty chroot, sorry [08:47] maybe that's because I haven't had chicken wings that night [08:48] Saviq, silo! silo! silo! silo! [08:51] Cimi, ok, let's see [08:51] Saviq, I restarted ap [08:51] Saviq, qmltests are fine [08:52] Saviq, I am missing to retest the integration with camera app [08:58] Saviq: how would you propose to do the dash app startup? ApplicationManager taking care of that or an upstart job? [08:58] probably upstart I guess [08:58] mzanetti, upstart job [08:59] ok [08:59] mzanetti, appmgr injecting it into the window stack when it's running (or maybe always?) [08:59] since it's meant to run always... [08:59] well, its a regular app for AppManager (with a don't close flag) [09:02] mzanetti, well, sure, but suddenly it has to listen to all upstart notifications (and not only to ual ones) to see it [09:02] mzanetti, but maybe that's fine [09:03] oh, I see [09:05] Saviq, I know... still working on that one [09:05] MacSlow, oh ok [09:22] Saviq, ValueError: invalid literal for int() with base 10: 'start/running' [09:22] I have loads of this [09:22] 39 [09:23] Cimi, just pasting one line is not gonna tell me anything [09:23] Saviq, ap [09:24] _get_unity_pid [09:24] http://paste.ubuntu.com/7662776/ [09:25] feels like unity hanged :\ === vrruiz_ is now known as rvr [09:55] Saviq, ok ap doesn't run for me on the device [09:55] trying on desktop [09:55] mzanetti, can you remember me the required steps to run ap on desktop? [09:56] well I could install the package or duing from builddir [09:59] Cimi, ./build.sh; make -C builddir install; PYTHONPATH=tests/autopilot autopilot3 run unity8 [09:59] Saviq, the sound-hint related branches are ready for a final look (https://code.launchpad.net/~macslow/unity-notifications/sound-hint-support/+merge/218961, https://code.launchpad.net/~macslow/unity8/sound-hint-support/+merge/218962) [09:59] Saviq, can I add it here? https://wiki.ubuntu.com/Touch/Testing [09:59] Saviq, now that I remember... I think it's in the readme [10:01] Cimi, it's in CODING most probably, yes [10:01] Cimi, and it's a wiki, what are you asking me for ;D [10:08] Saviq, but unity session exits running ap on desktop [10:08] Saviq, ok how do we test ap here? [10:09] Saviq, on the phone seems to hang [10:09] Cimi, right, so you're in tsdgeos camp [10:09] on the dekstop ap doesn't run [10:09] Cimi, what hangs on the phone? [10:09] Saviq, I don't know [10:09] http://paste.ubuntu.com/7662776/ [10:09] Cimi, did the test start at all? [10:10] yep [10:10] after few ap it stops [10:10] Cimi, ran just fine here yesterday :| [10:11] Saviq, obviously merging without testing deeply is a no? === mhr3_ is now known as mhr3 [10:12] Cimi, I requested a silo, let's wait for that hten [10:14] Saviq, saw comments here? https://code.launchpad.net/~cimi/unity8/card_emblems/+merge/221880 [10:14] those inline comments are lesss readable imho [10:15] they should pop in back as well as a formatted comment to the MR [10:16] and some more feedback here is appreciated https://code.launchpad.net/~cimi/unity8/card_touchdown/+merge/221113 [10:16] Saviq, should be able to land everything department-related today, is it ok from your pov? [10:16] I don't think we need an animation at all [10:17] Cimi, hey, could you review/ack https://code.launchpad.net/~robert-ancell/overlay-scrollbar/only-x11/+merge/222466 [10:17] mhr3, there's issues I found on top of yours (that's fixed) [10:17] mhr3, UX ones, not even code (yet) [10:18] Saviq, landing-blocking issues? [10:18] mhr3, some of them, yeah, like I ended up with depts that don't open [10:19] Saviq, oh? tsdgeos looking into those? :) [10:19] mhr3, queued, yes [10:19] not yet [10:19] mhr3: i'm unsure it's my fault to be honest [10:19] but may be :) [10:20] tsdgeos, I think there's two parts to it - UI waiting for loaded = true and then it not ever getting true would be a lower level issue [10:20] tsdgeos, well, i'm not going to say that the plugin side is perfect :) not fun pretending to have state on top of stateless queries [10:21] Saviq: we need to wait for loaded = true, no? [10:21] tsdgeos, no, we could open and show the activity indicator [10:21] isn't that what i do? [10:21] tsdgeos, no, it just doesn't open [10:21] then it's wrong yes [10:21] but let me finish VJ first :D [10:21] yeah [10:22] Cimi, replied [10:23] Cimi, re: inlines, there's UI things to be improved for sure, but they're really useful already [10:23] Cimi, and less work in the first place - before I had to bzr diff and copy paste parts of the diff to the review, which was painful [10:24] Cimi, re: touchdown, it's definitely not good yet, since you tapping on the card only shows the effect on the art, it looks rather bad in a horizontal card layout [10:25] Saviq: meh... is it possible to use sbuild atm or does uitk break it for real? [10:25] mzanetti, you can force stuff in [10:25] * mzanetti struggling with the old qtgraphicaleffects dependency too [10:25] mzanetti, create a purpose-build chroot for unity8 and install deps manually [10:25] yeah... trying that, but even if I install the new qtgraphicaleffects stuff, uitk still wants the old one [10:26] mzanetti, or I could package a working one up for you, let's see [10:26] Saviq: shouldn't we just create a branch for uitk and fix it? [10:26] mzanetti, I did already [10:26] ah ok [10:26] mzanetti, tbh I thought it was done before :| [10:26] https://code.launchpad.net/~saviq/ubuntu-ui-toolkit/new-qt-dep-names/+merge/223522 [10:27] yeah. I remember someone told me months ago it'll be fixed with the next release or similar [10:28] Saviq, i don;t understand your comment [10:28] Not sure why. If we know the icon is always foo x bar, why? [10:29] Cimi, why do we need a container if we know the icon will always be a certain size? we need to force the size on it [10:29] Saviq, the icon changes with title dimension [10:29] Saviq, and title has to shrink when there is emblem [10:30] so title should anchor right when there is no emblem [10:30] or anchor to the emblem when there is one [10:30] Saviq: please have a look at the VJ branch again, let's see what you can find [10:30] Cimi, yes, still no need for a container [10:30] tsdgeos, will do [10:31] * tsdgeos hops onto departments [10:31] Saviq, it's harder to calculate width otherwise [10:31] Cimi, it's square, not sure why it becomes harder [10:31] if it is also possible [10:31] Saviq, because you have to do, in title [10:32] anchors.left mascot or border or anything [10:32] Cimi, why does emblem "change dimensions based on title"? based on title font size? [10:32] then you have to set a width that you don't know [10:32] Saviq, yes [10:32] Cimi, why "width that you don't know"? [10:32] Saviq, you don't know the length from left anchor of the title and the right edge [10:33] Saviq, it's inside a row [10:33] and then you'd have to use x and y instead anchoring I believe [10:33] because you cannot anchor something that is not a parent [10:33] Cimi, use an HBox [10:35] Cimi, but I still don't get why it'd be so difficult, it's just an image of a certain size that you need to right-anchor the title to [10:35] Saviq, you cannot right anchor is a row [10:35] Cimi, definitely not warranting a container in my mind yet [10:35] Cimi, why is it in a row? [10:35] Saviq, the title is inside a row [10:35] mascot, title... [10:35] both inside row [10:36] then if there is a subtitle they are also inside a column [10:36] it's easier to play rubik's cube than dealing with cardcreator.js [10:36] Cimi, ok then, use an HBox then, it will automagically expand the title (or column) to fit with the other elements [10:37] Saviq, what's hbox? [10:37] Saviq, google doesn't know about it [10:38] Cimi, http://qt-project.org/doc/qt-5/qml-qtquick-layouts-rowlayout.html [10:38] it's RowLayout in QML [10:39] Cimi, but you should have known HBox from gtk? [10:39] Saviq, yep but you were talking qml :) [10:39] my container is an hbox [10:41] Saviq, so you suggest to always put the title inside a rowlayout? [10:41] it is better to use the container then [10:41] unless you mean just to replace the container with the rowlayout when the emblem is displayed [10:42] Cimi, replace the Row with RowLayout [10:43] ah ok [10:43] let's see if still works [10:43] because then there is a column [10:43] Cimi, so? [10:43] Cimi, a column is just an item like any other [10:43] so you still need to put the title inside a container [10:44] Cimi, you just need to make sure that both title and Column get Layout.fillWidth: true [10:47] mzanetti, uploading to http://people.canonical.com/~msawicz/unity8-amd64-armhf.tar.xz, should be there in 4 [10:49] Saviq: hmm... that's unity8 trunk is it? [10:49] mzanetti, you can just `cp /etc/schroot/chroots.d/sbuild-{utopic,unity8}-amd64-armhf` and adapt it a bit [10:49] mzanetti, it's a chroot that you'll be able to cross-build unity8 with [10:49] oh [10:49] Cimi, ↑ [10:49] cool [10:49] Saviq, you still need a container I'm sorry [10:49] Cimi, otp [10:50] Saviq: btw. just tried to build your uitk branch, fails with "qmake: could not find a Qt installation of ''" [10:50] mzanetti, QT_SELECT=qt5 [10:50] (I know how to get around it for now, but something seems fishy) [10:50] Saviq: yeah, I shouldn't have to do that myself, should? [10:50] mzanetti, how were you trying to build it? [10:50] sbuild --build=amd64 --host=armhf -d utopic [10:53] mzanetti, qmake doesn't cross build [10:53] oh right [10:53] crap [10:58] mzanetti, Cimi, it's there, you can grab that chroot, unpack it into /var/lib/schroot and cp/adapt the above file to use it [10:58] Saviq: 247MB? [10:58] mzanetti, xz [10:58] it unpacks to 1500 [10:59] Saviq: yeah, just wanted to know if I have the full thing, as I started the download a minute ago === MacSlow is now known as MacSlow|lunch [11:11] Saviq, you back? [11:22] Cimi, no, but still I don't understand why you need a container ;) [11:23] Saviq, because there's a case where there is a row containing mascot on left, on right containing a column composed by top the title and bottom the subtitle [11:24] Saviq, when we have an emblem, we want the top part of the column having title + emblem (bottom subtitle full width) [11:24] and that's where you need the container [11:25] mhr3: ping [11:25] using rowlayout will limit the use of the container just to this case, but it won't reduce any code usage [11:25] It might require more code or less [11:29] Saviq: any idea for the departments activity indicator? [11:30] tsdgeos, pong [11:30] mhr3: there's something weird with the loaded property going on [11:31] mhr3: when i go back to all departments is immediately set to true [11:31] even if it is not correct [11:31] and then i get a signal changed [11:31] to true again :D === MacSlow|lunch is now known as MacSlow [11:31] tsdgeos, think this has something to do with it? :) [11:31] XFAIL : DepartmentsTest::testGoingBack() We have the department in cache, to it kind of is loaded [11:31] Loc: [/home/miso/projects/unity-scopes-shell/tests/departmentstest.cpp(202)] [11:31] PASS : DepartmentsTest::testGoingBack() [11:32] mhr3: i.e. http://paste.ubuntu.com/7663248/ [11:32] mhr3: looks like it [11:32] mhr3: that messes up a bit with the height stability code i have which tries not to resize the list until it's loaded [11:33] and now is resized twice [11:33] because it is loaded but empty and then loaded but not empty [11:33] so when going back it shrinks and grows unneededly [11:33] tsdgeos, will adding a simple check whether the prop really changed fix your issue? [11:34] mhr3: ? [11:34] although i think the scope is doing something nasty which invalidates too much of the tree [11:35] tsdgeos, you said you get a signal twice, right? [11:35] mhr3: no, i get it just once [11:35] but saying "hi man, i changed from true to true" [11:35] tsdgeos, ah ok [11:35] then i really need to do something with the invalidation [11:36] Cimi, ok now I know what you mean [11:37] Cimi, I missed the "subtitle full width" use case [11:37] np [11:37] Cimi, I wonder if we could get away with GridLayout then [11:37] hard to explain anyway [11:37] Cimi, mascot spanning two rows [11:38] Saviq, but what's ther advantage? [11:38] Cimi, and subtitle spanning two columns [11:38] mhr3: that'd be cool [11:38] is this making the code much simpler? [11:38] Cimi, it would simplify the whole thing, from being a column in a row to just a grid [11:39] Cimi, but maybe not now, we didn't use the layouts enough I to have a handle on them [11:41] Cimi, so if your trouble is moving the emblem in and out of the column, but you still know its height (based on title line height, I assume?), you know its width based on its height, what does the container give you? do you move the emblem in and out of the container? [11:41] * Saviq needs to read the code.. [11:41] Saviq, just approve :P [11:41] Cimi, unlikely ;) [11:41] Saviq, it saves you headaches in cardcreator.js [11:42] we need to rewrite this into something easier [11:42] but I have no idea how too [11:42] Cimi, we've been through that unfortunately [11:42] Cimi, and to keep the flexibility and the performance, we're in for code generation however you look at it :| [11:44] Saviq, separate files? :| [11:44] Cimi, yeah, will you update them every time? [11:44] Cimi, all of them, I mean? [11:44] Cimi, if you agree to maintain them, be my guest :P [11:45] hah [11:45] Cimi, we *might* go for compile-time generation of some of them [11:45] that could simplify it a bit here or there [11:45] Saviq, we could have something that includes qml files [11:45] into a big one [11:45] Cimi, effect is the same, maybe slightly more readable [11:45] maybe it's easier to read [11:45] Cimi, but also requires loading files from disk, so slower [11:47] Cimi, oh now I understand, you're putting *both* title and emblem into that container, so that to fight with the Column... [11:48] Saviq, yes they are one single entity [11:48] Saviq: fyi: there's also another breakage wrt build deps in sbuild :/ libunity-mir depends on libplatform-api1-dev while it should be libubuntu-application-api-dev afaict [11:48] mzanetti, that changed recently did it? [11:48] yeah, first time I see it [11:49] mzanetti, so you still can't build? [11:49] Cimi, so maybe we just need to replace the Column with an Item and use anchors instead of Column? [11:49] right... but I guess I'll be able to solve it... [11:49] yeah, you should be able to fix unity-mir and x-build locally [11:49] Saviq, why you don't like my approach? [11:49] just that it doesn't really help with acceptance of x-building [11:50] mzanetti, weird how I can build it with that same chroot? [11:50] Cimi, would save us the container, and there's only ever two items max in the column [11:50] Cimi, less items → faster [11:50] Saviq, "save us one item" ? [11:50] Cimi, yes, we really need to optimize the sh$t out of this [11:50] Saviq, it is probably 0.001s slower [11:50] Cimi, times 80 that's being loaded at any given time [11:50] Cimi, that's 80ms [11:51] Cimi, that's 5 frames :P [11:51] Saviq, then we lose 0.3 on loading images or shaders of the ubuntushape [11:51] Cimi, which doesn't mean that we should disregard anything else that is slow [11:51] strange... unity-mir trunk seems good [11:51] er [11:51] why does it then want the old dep in here :/ [11:51] mzanetti, go into the chroot, apt-cache policy libunity-mir-dev [11:52] Saviq, there are shits that are much slower than one item [11:52] http://paste.ubuntu.com/7663313 [11:52] js or properties too [11:52] Cimi, just do it, please [11:53] Saviq, I just virtually gave you another chicken wing to eat :P [11:54] Cimi, I will enjoy it then [11:54] /food [11:55] Saviq, at this point it's better to waste time for the grid === _salem is now known as salem_ [12:55] tsdgeos, pushed new rev to shell-plugin, should be better for you now [12:56] can you try it out? [13:02] mhr3: do i need to recompile or the ppa will update? [13:03] tsdgeos, will take a while to build it in ppa, you better recompile [13:03] ok [13:05] plus i'm about to break the ppa [13:05] oh wait, you won't be able to compile it [13:06] tsdgeos, it probably won't build for you, do reverse cherrypick of 130 to make it work with what's currently in the ppa [13:07] mhr3: ouch [13:07] mhr3: nothing in bzr+ssh://bazaar.launchpad.net/~mhr3/unity-scopes-shell/department-support/ ? [13:07] lp:~unity-api-team/unity-scopes-shell/department-support [13:10] mhr3: i did rever 130 [13:10] getting http://paste.ubuntu.com/7663644/ [13:11] tsdgeos, then nope, you didn't revert 130 [13:11] i did :D [13:12] tsdgeos, how? [13:12] mhr3: http://paste.ubuntu.com/7663652/ [13:13] given that it doesn't touch mock-scope [13:14] i don't see what 130 has to do there [13:14] lol stupid [13:14] bzr diff is not what i want there [13:15] well not that one [13:15] mhr3: ignore me ^^ [13:15] tsdgeos, yea, you just did revert to 130 [13:15] tsdgeos, bzr merge -r 130..129 . [13:18] mhr3: doesn't work, still get "all departments" loaded to be immediately true when going back [13:18] tsdgeos, yea, but it won't change now [13:18] well.. unless the scope is totally screwed [13:18] mhr3: i don't care it won't change, i want loaded to be what we agreed on [13:19] i.e. that all the children are there [13:19] now it's true and there's like 1 children there [13:19] but they are [13:19] if there's still just one child, it either doesn't work, or the scope is f*ed up [13:20] mhr3: this is my log [13:20] http://paste.ubuntu.com/7663672/ [13:20] don't know if it's the scope or not [13:20] but it's wrong :D [13:27] mhr3: any idea who is doing the scope so we can ping them' [13:27] ? [13:28] tsdgeos, ok, it's the scope [13:29] tsdgeos, did a few queries - http://paste.ubuntu.com/7663704/ [13:31] tsdgeos, although i guess i could handle it better - can give you the cached state, set it to loading, and if the scope decides to change everything, so be it [13:32] mhr3: don't know i guess it's something you can discuss with scope people? [13:32] tsdgeos, we'll always have to deal with scopes that give out weird data [13:33] tsdgeos, the question is - do you want to overlay the loading spinner on a cached department list even though it won't change? [13:33] which is what will happen to well behaved scopes because of that [13:34] mhr3: kind of kills the purpose of caching? [13:34] yep [13:34] i'd vote for fixing the scope to be correct [13:40] Cimi, stuff's built in https://launchpad.net/~ci-train-ppa-service/+archive/landing-009 [13:43] Saviq, thanks! [13:44] Saviq, if you are not using your mako/manta, can you run an ap? [13:50] Cimi, with this silo? [13:50] yup [13:50] let's try [13:50] since before was hanging for me [13:50] after few tests.. [13:53] Saviq: so about the departments stuff, the chevrons look like the designs to me, but maybe not [13:53] Saviq: how do we get it in hands of a designer so he can comment? [13:54] tsdgeos, we should be able to get someone to install the silo on their phones [13:54] tsdgeos, which designs, btw? [13:54] there was a screen somewhere i was copying i think [13:54] tsdgeos, https://sites.google.com/a/canonical.com/unity8dash/toolkit/2-navigation look much smaller [13:54] maybe it was just wireframe [13:55] tsdgeos, halfway down there's "visuals" [13:55] yeah [13:55] i don't think they are smaller [13:55] hum, they were huge for me [13:55] will try again in a mo [13:55] hello [13:55] can I get a review here, please? https://code.launchpad.net/~elopio/unity8/flake8/+merge/223495 [13:55] just cleaning up the py files. [13:56] Saviq: ok, yeah they are a bit smaller :D === dandrader is now known as dandrader|afk [13:56] tsdgeos, a *bit* ;) [13:56] i'm obviously not good at comparing sizes [13:57] mhr3: there's something veeeeeeeeery weird with leaves [13:57] it's like the tick doesn't get updated until like very far in the future [13:58] probably until the query ends [13:58] so if i open the menu before [13:58] greyback: https://code.launchpad.net/~nick-dedekind/platform-api/trust-sessions/+merge/223369 succeeded on jenkins. you need anything else for approve? [13:58] either i see no tick, or the tick is in the "old" leaf [13:58] tsdgeos: learn! https://www.youtube.com/watch?v=vh5kZ4uIUC0 [13:58] mhr3: anything you can do about that? [13:59] dednick: nope, will approve now then [13:59] greyback: thanks [14:00] tsdgeos, hmm.. doesn't the list close anyway? [14:00] mhr3: it does, but then i can go and open it again [14:00] tsdgeos, I wonder, could we have a single (clipping) background that would resize, instead of having background "per-page"? [14:01] though you aren't really seeing from that dep, so maybe it's good it's not ticked? [14:01] seeing results* [14:01]