| huwshimi | hatch: Is the "Consolidate deployer bar summary generation functions" card something you're doing or did you want me to take that? | 00:08 |
|---|---|---|
| hatch | huwshimi it can't start until the branch I'm working on lands because I used the current approach | 00:09 |
| hatch | so I can leave it for you for tomorrow if you like | 00:09 |
| hatch | I likely wont get time to do it by tomorrow | 00:09 |
| huwshimi | hatch: Ah no problems. I can take a look tomorrow then. | 00:09 |
| huwshimi | hatch: I might have to take a card out of the backlog unless you've got anything you need doing? | 00:12 |
| hatch | hmm lemme take a peek | 00:12 |
| hatch | huwshimi what about https://launchpad.net/bugs/1328981 ? | 00:13 |
| _mup_ | Bug #1328981: Reloading the inspector on upgrade of a charm creates blank sidebar <juju-gui:Triaged> <https://launchpad.net/bugs/1328981> | 00:13 |
| hatch | or the card "wire the new container header/actions" I have no idea what that even means lol | 00:14 |
| huwshimi | hatch: That's the link in the containers header column that says "Add container" | 00:16 |
| hatch | ohh, do you want to do that? | 00:16 |
| hatch | or is it blocked by something | 00:16 |
| huwshimi | hatch: kyle has a card that says "wire up new container (both link and drop target) to work properly" | 00:16 |
| hatch | ohh ok | 00:16 |
| huwshimi | so I assume that is covering part of the work, or at least blocking it | 00:16 |
| hatch | ok in Maintenance backlog https://bugs.launchpad.net/juju-gui/+bug/1331061 | 00:17 |
| _mup_ | Bug #1331061: bundle deployment delay in drag/dropping a bundle in live environments <juju-gui:Triaged> <https://launchpad.net/bugs/1331061> | 00:17 |
| hatch | er On Deck | 00:17 |
| hatch | should be really small one heh | 00:17 |
| hatch | but yeah looks like you can pull something from On Deck | 00:18 |
| huwshimi | ugh, my tests failed again | 00:18 |
| huwshimi | hatch: Any ideas? http://ci.jujugui.org:8080/job/juju-gui/1253/console | 00:21 |
| hatch | looking | 00:26 |
| hatch | huwshimi https://saucelabs.com/jobs/828b4d0f1c7645bfbb79ace92314af50 | 00:26 |
| huwshimi | oh so that's the same issue | 00:27 |
| huwshimi | I think | 00:27 |
| huwshimi | uh no | 00:27 |
| hatch | well it appears to be an IE only issue so you will probably want to view up an IE vm | 00:28 |
| huwshimi | hatch: yeah, it's because pointerEvents aren't supported in IE10 | 00:30 |
| hatch | well that sucks | 00:31 |
| huwshimi | I don't know how to do this :( | 00:51 |
| huwshimi | I could do it through CSS instead of JS and not test for it, but that seems less than ideal | 00:52 |
| huwshimi | And IE10 would just not have working hovered drop areas | 00:52 |
| huwshimi | (visually, they wouldn't have the background appear) | 00:52 |
| hatch | huwshimi sorry I had to step away - did you end up figuring out a solution? | 01:27 |
| huwshimi | hatch: Yeah, and it fixed an intermittent bug too :) | 01:27 |
| hatch | coolio, push it up whenever you're all done and I'll review it | 01:28 |
| huwshimi | hatch: Thanks, just fighting a really strange css linting bug and then I'll push | 01:28 |
| hatch | no rush I'm going to be having supper soon | 01:32 |
| huwshimi | hatch: Apparently we can't use the '*' selector? | 01:33 |
| hatch | oh...it's considered bad practice | 01:36 |
| huwshimi | hatch: How would you feel about allowing that in our lint? | 01:36 |
| hatch | but you should be able to override it | 01:36 |
| hatch | I'm ok with it | 01:36 |
| hatch | there -are- valid use cases for it | 01:36 |
| huwshimi | hatch: Well, in this case we want to make sure all children get applied the pointer-events: none for our drop targets | 01:37 |
| hatch | yeah sounds god | 01:38 |
| hatch | good | 01:38 |
| huwshimi | hatch: OK, changes up. | 01:42 |
| huwshimi | hatch: Oh, just need to fix a little bug | 01:48 |
| hatch | huwshimi hey I'm back - it's all ready to go? | 02:58 |
| huwshimi | hatch: Yeah, it's up, but I got this error from the safari tests: https://saucelabs.com/jobs/72a85e524b55401a82bd55338029394f | 02:58 |
| hatch | looking | 02:58 |
| hatch | huwshimi that's the intermittent issue - it can be ignored | 02:59 |
| huwshimi | ah ok | 02:59 |
| hatch | ...well it shouldn't be | 02:59 |
| hatch | heh | 02:59 |
| huwshimi | :) | 02:59 |
| hatch | but we have a card to figure out wth is going on | 02:59 |
| huwshimi | hatch: Are we having an aus call tomorrow? | 03:08 |
| hatch | well rick is not around tomorrow but if I hear of anything of interest to you I can fill you in | 03:09 |
| hatch | I suppose I could fill you in on the personas call that we had with design yesterday | 03:09 |
| hatch | you can probably get most of the information from looking at the slides though | 03:10 |
| huwshimi | hatch: Luca actually took me through the slides last night | 03:12 |
| hatch | ohh, well then, nope nothing new so far :) | 03:12 |
| hatch | huwshimi review done, just going to QA now | 03:23 |
| huwshimi | hatch: Thanks! | 03:23 |
| hatch | and qa done | 03:27 |
| hatch | I'm pretty confident that I don't like the jarring UI change when dragging | 03:27 |
| hatch | but it makes it's intentions known thats for sure | 03:28 |
| hatch | maybe that's a good thing | 03:28 |
| hatch | huwshimi ok both PR's reviewed and qa'd so you should be all good to go | 03:30 |
| huwshimi | hatch: Thanks! | 03:31 |
| hatch | np, now I'm going to try and catch up on my blogs | 03:31 |
| hatch | way too much content added to the internet every day for me to keep up with | 03:32 |
| huwshimi | haha | 03:33 |
| hatch | huwshimi is there any UI for the config changes in the deployer bar? ATM I just say 'configuration values changed in <serviceName>' | 03:36 |
| hatch | but I'm wondering if we should show which values somehow... | 03:36 |
| huwshimi | hatch: Not that I know of. I think we need an updated set of visuals for the deployer bar | 03:36 |
| hatch | ok I'll fire off an email to UX | 03:37 |
| huwshimi | hatch: Thanks | 03:37 |
| hatch | email sent | 03:39 |
| huwshimi | hatch: oh, this is broken. When I drop the unit on an existing machine or container it wants to create a new machine | 04:05 |
| hatch | huwshimi yeah | 04:06 |
| hatch | can you file a bug for that - I'm pretty sure there already is one, but I can't find it | 04:06 |
| huwshimi | hatch: I think that's something I broke in my branch right? | 04:10 |
| hatch | no I'm pretty sure it's broken on trunk | 04:10 |
| hatch | lemme see | 04:10 |
| huwshimi | comingsoon does other weirdness | 04:11 |
| hatch | heh yeah it's broken there too | 04:12 |
| huwshimi | hatch: With different results though. I think I have broken something here | 04:13 |
| hatch | I don't think so - I mean, it may be different broken from comingsoon, but it still doesn't work on comingsoon | 04:14 |
| huwshimi | hatch: Actually, it appears to be working for me on coming soon now. | 04:19 |
| hatch | yeah? Odd I can't get it to work | 04:19 |
| huwshimi | hatch: What happens for you? | 04:19 |
| hatch | it gives me a notification error that it can't find the container that I'm trying to deploy to | 04:20 |
| huwshimi | hatch: Oh, that's not what I've been getting | 04:21 |
| huwshimi | hatch: On my branch, when I drop a unit onto a container or machine it acts as if I'd dropped it on "Create new machine" | 04:23 |
| hatch | yeah I remember that bug used to happen | 04:23 |
| hatch | maybe as early as last week | 04:23 |
| hatch | huwshimi are you dropping on the machine or on the container on the machine? | 04:24 |
| huwshimi | hatch: on the machine | 04:26 |
| huwshimi | hatch: The container will sometimes work | 04:26 |
| huwshimi | hatch: Not sure why though | 04:26 |
| hatch | ok now it's working on comingsoon | 04:26 |
| hatch | lol | 04:26 |
| hatch | must have had some wako caching here | 04:27 |
| hatch | huwshimi sorry I've got to run, good luck :) | 04:28 |
| huwshimi | hatch: No problems, have a good one :) | 04:28 |
| rick_h_ | hey all | 04:36 |
| huwshimi | rick_h_: Morning? | 04:47 |
| huwshimi | oh, it's just very late | 04:47 |
| rick_h_ | huwshimi: yea, late day | 04:49 |
| rick_h_ | finally seeing email for the first time in about 12hrs | 04:49 |
| huwshimi | heh | 04:49 |
| frankban | morning rogpeppe1: I have a dentist apt in 50 mins :-/ Do you want to have a chat? | 08:23 |
| rogpeppe1 | frankban: sure | 08:23 |
| frankban | rogpeppe1: back and alive, this dentist was fracking accurate, which is good but also bad... | 11:04 |
| rogpeppe1 | frankban: hangout? (or perhaps you can't speak... :-]) | 11:05 |
| frankban | rogpeppe1: joining | 11:05 |
| rogpeppe1 | frankban: http://paste.ubuntu.com/7668667/ | 11:55 |
| rogpeppe1 | frankban: https://docs.google.com/a/canonical.com/document/d/1SF8hTBi6oVbki8V__beNij6wnQU-5cm6PZsy5gf0j_Y/edit?usp=sharing | 12:01 |
| rogpeppe1 | rick_h_, bac: ping | 12:08 |
| bac | hi rogpeppe1 | 12:09 |
| rogpeppe1 | bac: fancy having a look at our bundles proposal document? | 12:09 |
| rogpeppe1 | bac: link just above | 12:09 |
| bac | rogpeppe1: sure | 12:09 |
| rogpeppe1 | bac: feel free to join us in the standup hangout if you want to chat about it | 12:13 |
| bac | rogpeppe1: let me read first then i will | 12:13 |
| rogpeppe1 | bac: cool | 12:13 |
| bac | rogpeppe1: you still in the hangout? | 12:38 |
| rogpeppe1 | bac: yup | 12:38 |
| bac | rogpeppe1: normal daily standup? | 12:38 |
| rick_h_ | rogpeppe1: ooh docs thanks. | 13:43 |
| rogpeppe1 | rick_h_: np. would be good to have your feedback. | 13:43 |
| * bac is utterly utopic | 13:50 | |
| rick_h_ | bac: whoa, brave man | 13:51 |
| rick_h_ | bac: doesn't juju not work right on utopic still? | 13:51 |
| bac | rick_h_: just embarking | 13:51 |
| bac | fwiw, update-manger -d hangs but do-release-upgrade works great | 13:51 |
| rick_h_ | rogpeppe1: commented in the doc | 14:00 |
| rick_h_ | rogpeppe1: thanks for that, good stuff | 14:00 |
| rick_h_ | frankban: bac going to add a card to the backlog for this https://github.com/juju/juju/pull/77 | 14:01 |
| rick_h_ | just a heads up | 14:01 |
| bac | rick_h_: ok | 14:02 |
| rogpeppe1 | rick_h_: i've replied to most of your comments | 14:29 |
| jcastro | rick_h_, thanks for the doc review, I've made and pushed all those changes. <3 | 14:31 |
| hatch | hehe very cool http://gizmodo.com/this-audio-illusion-will-make-you-never-trust-your-ears-1593113324 | 14:43 |
| kadams54 | hatch: when you get the chance I have more questions about simulate | 14:46 |
| hatch | yeah shoot | 14:46 |
| kadams54 | It looks like the second arg for simulate lets you decorate the event object | 14:47 |
| hatch | yep | 14:47 |
| kadams54 | But in my case, I want to override the e.target attribute | 14:48 |
| hatch | you can hang some streamers, and such | 14:48 |
| hatch | aren't you simulating the event on the select which is the target? | 14:48 |
| kadams54 | Such that e.target.get('value') returns something | 14:48 |
| hatch | why would you want to override it? | 14:48 |
| hatch | oh you want the target to be the option | 14:48 |
| kadams54 | Because I want to simulate the select being changed to something other than the default value | 14:48 |
| hatch | why not loop through the options to find out which one is selected then get the value from that? | 14:49 |
| hatch | that's the 'proper' way to deal with selects cross browser | 14:49 |
| hatch | YUI tries to normalize it but it doesn't always work out as plannd | 14:49 |
| kadams54 | Not sure how that would help in the test? | 14:49 |
| hatch | set an option as selected | 14:49 |
| hatch | then simulate the change event | 14:50 |
| kadams54 | Ah, so container.one('option[value=foo]').setAttr('selected')? | 14:50 |
| hatch | well you'll have to remove any previous selected ones | 14:50 |
| Makyo | jujugui call in 6 | 14:54 |
| kadams54 | That audio illusion did not work for me. Not sure what that says about my brain. | 14:54 |
| hatch | uh oh! | 14:54 |
| rogpeppe1 | kadams54: worked for me | 14:54 |
| hatch | kadams54 maybe try again | 14:54 |
| kadams54 | I listened to the real sentence and the scrambled one three times | 14:54 |
| kadams54 | It kinda seemed like the beginning of the scrambled one sounded like the real one, but then it just sounded like r2d2 by the end. | 14:55 |
| kadams54 | Nothing ever really "popped" or seemed very different | 14:55 |
| hatch | hmm interesting | 14:56 |
| hatch | worked first try for me | 14:56 |
| rogpeppe1 | kadams54: i listened to the real sentence twice | 14:56 |
| rogpeppe1 | kadams54: ('cos i didn't understand it first :-]) | 14:56 |
| frankban | maybe it depends on how much time you spent with 8bit games: https://www.youtube.com/watch?v=i1_fDwX1VVY | 14:58 |
| hatch | frankban haha | 14:59 |
| hatch | jujugui call now | 15:00 |
| jcsackett | hatch: pushed lint fixes. | 15:11 |
| hatch | cool - could you put your qa instructions in the PR description instead of in a comment from now on :) | 15:11 |
| hatch | makes it easier to find :) | 15:12 |
| bac | rogpeppe1: did you send email about the bundles doc? i'm looking but don't see anything. if so, which list? | 15:13 |
| rogpeppe1 | bac: #juju-dev | 15:13 |
| rogpeppe1 | bac: juju-dev@lists.ubuntu.com | 15:14 |
| bac | rogpeppe1: thanks. | 15:14 |
| hatch | jcastro so the video is unlisted but not locked so if you have the url you can see the stream | 15:18 |
| hatch | just fyi | 15:18 |
| hatch | jcsackett wow this diff is all over the place lol | 15:22 |
| bac | thanks rogpeppe1. turns out i wasn't subscribed to that one. am now. | 15:22 |
| jcsackett | hatch: QA in a comment seems better--it's kind of bizarre to have the QA instructions become part of the commit log, don't you think? | 15:23 |
| bac | b/c i need more email | 15:23 |
| jcsackett | hatch: and yeah, for what is actually a simple bit of breaking out logic, git diffed it *really* oddly. | 15:23 |
| bac | jcsackett: i often put QA in with the lbox propose but try to edit them out when i do lbox submit | 15:23 |
| hatch | jcsackett the PR description doesn't get merged into the repo | 15:24 |
| bac | jcsackett: never mind. you're talking github and i'm just butting in with irrelevant comments. | 15:24 |
| hatch | I suppose it makes it into the merge commit | 15:24 |
| jcsackett | hatch: yup https://github.com/juju/juju-gui/commit/26ecc89e1e34152947d9ea71f12a6cb537a36a7f | 15:25 |
| jcsackett | bac: the same idea could work--just feels weird to edit the PR description after review. | 15:25 |
| hatch | well then! | 15:25 |
| jcsackett | hatch: i *agree* that the description shouldn't, mind you. :) | 15:26 |
| hatch | GH does some weird stuff | 15:26 |
| hatch | it's almost like they do the absolute minimum amount of work lol | 15:26 |
| jcsackett | yup. | 15:26 |
| hatch | jcsackett damn you updating while I'm still reviewing | 15:31 |
| hatch | lol | 15:31 |
| jcsackett | hatch: i'm not rebasing though. | 15:31 |
| jcsackett | just addressing your comments as i see them--you want me to hold off altogether? | 15:32 |
| hatch | if you could - it removes the comments associated with any changed lines | 15:32 |
| hatch | (which I just learnt) | 15:32 |
| hatch | :) | 15:32 |
| jcsackett | hatch: sure, no problem. | 15:32 |
| jcsackett | (as a note, it only removes them if that part of the diff goes away or is altered--which usually means your comment was just addressed) | 15:33 |
| jcsackett | but i need more coffee anyway, so i'll hold off. :) | 15:33 |
| jcsackett | hatch: re the 500ms, in my testing it needed only one round of 100ms, but i wasn't sure if we wanted to cut it that close. 5 really short retries seemed like a good guess, but i wonder if you have any thoughts? | 15:50 |
| hatch | jcsackett nope I'm good with whatever you found I was just more concerned about a comment to tell future us why the retries were as they were | 15:50 |
| jcsackett | hatch: ok. | 15:50 |
| hatch | jcsackett I've found over the past year we end up going back and are like 'what the....why....huh?....(1h later)...ohhhhhh now I get it' | 15:52 |
| hatch | lol | 15:52 |
| hatch | jcsackett your test failure was the intermittent one | 15:55 |
| jcsackett | hatch: well, i'll be pushing up changes shortly, so we'll get another run. | 15:56 |
| hatch | jcsackett so I get the bug mentioned in your PR when trying to view /inspector/juju-gui | 16:35 |
| hatch | is it supposed to do that? Or something else? | 16:35 |
| jcsackett | hatch: right. it's a separate issue, as it popped up while i was investigating this. | 16:35 |
| jcsackett | but "no model" is also "partial model". | 16:35 |
| hatch | ok so the 'not an inspector' mode works | 16:35 |
| hatch | but I get that bug when trying to view the juju-gui inspector | 16:35 |
| jcsackett | hatch: normally? or after reload? | 16:36 |
| hatch | after reload | 16:36 |
| jcsackett | hatch: ok, that's expected. | 16:36 |
| hatch | visiting /inspector/juju-gui gives me the bug mentioned | 16:36 |
| hatch | ok cool | 16:36 |
| jcsackett | hatch: that started happening after i rebased develop. | 16:36 |
| jcsackett | i'm actually going to see if i can find the cause and update the bug today. | 16:36 |
| hatch | ok qa ok | 16:36 |
| jcsackett | but our fix doens't fix that, sadly. :( | 16:36 |
| hatch | after you fix the comments plz rebase :) | 16:36 |
| jcsackett | hatch: will do. | 16:37 |
| hatch | jujugui looking for a review/qa on https://github.com/juju/juju-gui/pull/396 | 17:01 |
| hatch | jcsackett re my comment on property vs attribute http://jsperf.com/yui-attribute-vs-property/7 it's a monstrous difference but I figure we are ok with 3.8M ops/s :D | 17:03 |
| hatch | jcsackett you'll also notice I used your approach and put the QA notes in a comment :) | 17:05 |
| jcsackett | hatch: looking. | 17:14 |
| hatch | thanks | 17:18 |
| hatch | kadams54 how goes the battle? Would you like to pair to get that thing landed? | 17:38 |
| hatch | it's blocking Huw so would definitely like to get it landed today | 17:39 |
| jcsackett | hatch: two questions on your PR, just on stuff i'm not following--qa is good, if you can sort me on those i'll +1 now. | 17:40 |
| hatch | yup replied | 17:40 |
| kadams54 | hatch: Got it. Let me wrap up work on this test and then I'll be at a good spot for pairing | 17:41 |
| hatch | jcsackett comments replied to | 17:43 |
| jcsackett | hatch: in retrospect, the answer to my second question was obvious. :p | 17:44 |
| jcsackett | thanks, you're good to :shipit: whenevs. | 17:44 |
| hatch | haha np :) | 17:45 |
| hatch | hmm this ecs ghost config is going to be interesting | 17:56 |
| hatch | Makyo what about things like constraints, unit counts, etc? | 17:56 |
| hatch | atm you can't deploy more than 1 unit | 17:57 |
| Makyo | Isn't that part of the deploy args? | 17:57 |
| hatch | right - but there is no way to 'submit' changes to a ghost inspector | 17:57 |
| hatch | there is no 'save' button | 17:57 |
| hatch | so you can't actually set anything | 17:58 |
| Makyo | Isn't that in the plans, though? | 17:58 |
| hatch | no idea - I don't recall seeing any mockups with one | 17:58 |
| hatch | there is an issue here because if we allow the user to increase their units here, and define the constraints then that's going to much with the MV stuff | 17:59 |
| Makyo | Maybe it's purely a mv thing | 18:00 |
| hatch | it's like auto-placing a unit | 18:00 |
| Makyo | Yeah. | 18:00 |
| Makyo | I'd just focus on the current iteration until we get more direction. | 18:00 |
| hatch | yeah there isn't much I can do until we figure this out - because atm I'd have to save on blur in the config or something | 18:00 |
| hatch | which is a litle odd | 18:00 |
| hatch | or add a save button | 18:00 |
| hatch | crud I wish design was still awake | 18:01 |
| hatch | :) | 18:01 |
| Makyo | We've been talking about a save button for a while now. | 18:01 |
| Makyo | So whatever. Can you search for a stopping point that's landable? | 18:01 |
| Makyo | Like, even if it doesn't actually use the ECS config stuff, have that in there, etc. | 18:02 |
| hatch | I'm not sure I should even start on the ghost config ecs stuff until this is ironed out | 18:02 |
| Makyo | Sure | 18:02 |
| hatch | the deployed service ecs is done | 18:02 |
| hatch | but the ghost stuff just doesn't quite make sense heh | 18:02 |
| Makyo | My own task is turning out to be impossible without doing the whole thing at once, so I'm doubling or tripling LoC. If you want to snag another ECS card, no need to wait on me | 18:03 |
| hatch | the remove relation one? | 18:03 |
| hatch | oh the inspector double call thing | 18:04 |
| hatch | got it | 18:04 |
| hatch | I'm going to stew on this a bit longer then fire off an email | 18:04 |
| kadams54 | hatch: I may actually be ready to land this sucker. Waiting to see what happens in CI, as well as doing manual testing… I've updated the PR to reflect the not-a-WIP-any-more status. | 18:42 |
| hatch | cool I'll check it out | 18:43 |
| kadams54 | hatch: That said, I'm somewhat concerned that my work may conflict with Huw's stuff that's in review. | 18:43 |
| kadams54 | hatch: I'd be more comfortable if that stuff was shipped and I could rebase off it. | 18:43 |
| hatch | ok that's possible I suppose - he hopefully will solve his bug and get it landed tonight | 18:44 |
| hatch | then tomorrow you can rebase and go | 18:44 |
| kadams54 | hatch: so now that all automated tests pass, I'm running into problems doing manual testing. Time to write more tests. | 18:46 |
| kadams54 | hatch: feel free to hold off until I've sorted through these problems. | 18:46 |
| hatch | ok will do | 18:57 |
| hatch | kadams54 hthere is a card "wire the new container header/actions" is that taken care of in your branch? | 19:53 |
| hatch | Makyo so it's ok if I hop on the remove relation ecs card? | 19:55 |
| Makyo | Sure. | 19:56 |
| hatch | Makyo any idea why lazyAddMachine and lazyAddUnit aren't private (_) ? | 20:09 |
| hatch | typos? | 20:10 |
| Makyo | hatch, yeah, I think so. | 20:10 |
| hatch | alrighty | 20:10 |
| kadams54 | hatch: yes. | 20:41 |
| hatch | kadams54 ok cool, can you look at the ready to code cards and delete the ones which are already done in your branch | 20:41 |
| kadams54 | hatch: So I got everything working again, the CI build was passing, life was great. I squashed the commits down to one, pushed, and all hell broke loose. | 20:41 |
| kadams54 | hatch: manual testing and test-server still pass just fine. test-prod is totally borked. | 20:42 |
| kadams54 | So that's awesome. | 20:42 |
| hatch | Are you missing a dependency? That's usually the cause of test-prod going | 20:42 |
| kadams54 | I don't think so | 20:42 |
| kadams54 | test-prod passed just fine before I squashed | 20:42 |
| kadams54 | Squashing was the only diff between build #1268, which passed, and #1269, which didn't. | 20:43 |
| hatch | ok lemme see | 20:44 |
| hatch | kadams54 does test-prod run locally? | 20:45 |
| kadams54 | No | 20:45 |
| kadams54 | I can dup the same errors I see in CI in local test-prod. | 20:45 |
| kadams54 | But test-server runs just fine. | 20:45 |
| hatch | try test-prod-server | 20:46 |
| kadams54 | finished reviewing for dupe cards - only deleted the one you found. | 20:47 |
| hatch | ok | 20:47 |
| kadams54 | test-prod-server is fine. Just re-ran test-prod, errors galore. | 20:52 |
| kadams54 | whee! | 20:52 |
| hatch | look in the network tab | 20:52 |
| hatch | see what it's requesting | 20:52 |
| hatch | it is likely making additional requests | 20:52 |
| kadams54 | Time for a make clean | 20:52 |
| hatch | wellllll CI runs in a clean env all the time | 20:55 |
| kadams54 | So I'm running test-prod-server and I've got the network tab open - what am I looking for? | 20:56 |
| hatch | I'm pulling down your branch to see if I can reproduce | 20:56 |
| hatch | ok I can reproduce | 21:00 |
| hatch | when you rebased, did you rebase against develop again? | 21:01 |
| hatch | I'm just not sure how flattening could have caused this heh | 21:01 |
| kadams54 | I did "git rebase -i develop" | 21:05 |
| kadams54 | But there also weren't any changes in develop since the last time I'd rebase'd | 21:05 |
| kadams54 | I've narrowed it down to test_machine_view_panel.js, line 375 | 21:06 |
| hatch | kadams54 trying a hunch | 21:06 |
| hatch | hunch was not correct | 21:07 |
| kadams54 | :-( | 21:08 |
| kadams54 | Wow, I really hate this. Now test-prod is failing with out of memory exception before it even gets into the testing… really?!? | 21:08 |
| hatch | kadams54 here http://stackoverflow.com/questions/134882/undoing-a-git-rebase | 21:11 |
| hatch | undo your rebase so we can get it back to a passing state | 21:11 |
| kadams54 | I'll give it a whirl in just a moment… | 21:12 |
| hatch | kadams54 yeah I have no idea why lastArguments would return undefined but only in test-prod | 21:26 |
| hatch | I'd have to step through it which would take a while heh | 21:26 |
| kadams54 | I'm undoing rebase right now | 21:27 |
| kadams54 | Confirmed that skipping that one test fixes things | 21:27 |
| hatch | yeah, the callCount on addMachines is 0 | 21:27 |
| hatch | but only in test-prod | 21:27 |
| hatch | I'm guessing it's a race condition because of your simulates | 21:28 |
| hatch | trying that fix | 21:28 |
| kadams54 | Oh hey | 21:29 |
| kadams54 | One thing that puzzled me | 21:29 |
| kadams54 | When I setup the test to run with .only | 21:29 |
| kadams54 | There were two failures in one test | 21:29 |
| kadams54 | Which seems like there are extra instances being created and getting into a race condition with each other | 21:29 |
| hatch | yeah so it looks like the simulates are causing the issues | 21:30 |
| hatch | you're executing this synchronously but it's executing asynchronously | 21:30 |
| hatch | just seeing if I can hack it into passing | 21:31 |
| hatch | to confirm | 21:31 |
| hatch | TypeError: 'null' is not an object (evaluating 'e.target.one("option:checked").get') (http://0.0.0.0:8888/juju-ui/assets/modules.js:13) | 21:31 |
| hatch | kadams54 ok I fixed it | 21:38 |
| hatch | but you'll need to fix it properly heh | 21:38 |
| kadams54 | lol | 21:40 |
| hatch | I'm just cleaning it up and getting you the diff | 21:40 |
| hatch | kadams54 https://gist.github.com/d12e15eb80c894d7b2cb here you go | 21:42 |
| hatch | so two issues | 21:42 |
| hatch | the option:selected for whatever reason doesn't want to work properly in test-prod | 21:42 |
| hatch | and the simulates need to happen after the previous event is finished | 21:42 |
| * kadams54 shakes his fist at PhantomJS | 21:42 | |
| hatch | I hacked it using some setTimeouts but that's just a hack, you'll need to listen for the events and then simulate the events in the proper order | 21:43 |
| kadams54 | Your code doesn't work :-) | 21:43 |
| hatch | whaaaa | 21:43 |
| kadams54 | I tried looping through the options in a similar manner | 21:43 |
| kadams54 | Which works for the automated tests | 21:43 |
| kadams54 | But doesn't work in real life | 21:43 |
| hatch | why not? | 21:44 |
| kadams54 | When you select a new item in the browser, it doesn't update the selected attribute in the DOM | 21:44 |
| kadams54 | So you end up getting the option that was originally specified as selected, instead of the new one | 21:44 |
| kadams54 | That's when I switched to option:checked | 21:44 |
| kadams54 | I must not have pushed that change for the build that passed - only got pushed post-squash | 21:45 |
| hatch | ohhh | 21:45 |
| hatch | hmm | 21:45 |
| * kadams54 has a healthy loathing of dealing with selects in JS | 21:46 | |
| hatch | I must have known that at some point haha | 21:46 |
| kadams54 | LOL | 21:46 |
| hatch | hmm ok well then | 21:46 |
| hatch | how r we guna do this! | 21:47 |
| hatch | oh duh | 21:48 |
| hatch | use selectedIndex | 21:49 |
| hatch | heh man I just failed hard | 21:49 |
| kadams54 | And it all comes back. | 21:55 |
| kadams54 | OK, selectedIndex fix on the way | 21:55 |
| kadams54 | But seriously, why are we still doing this? | 21:55 |
| kadams54 | Why oh why can't the pseudo selector just work?!? | 21:56 |
| hatch | standards bodies are more interested in making 'new' features like arrow functions instead of providing better ones that actually solve problems? | 21:56 |
| kadams54 | Well :checked is well supported by all the "real" browsers | 21:58 |
| hatch | true true | 21:58 |
| kadams54 | Apparently it's just PhantomJS that has issues | 21:58 |
| kadams54 | Regardless, I think manipulating selectedIndex will be a better approach for the test | 21:58 |
| hatch | we are a few releases back on the phantomjs so maybe we should update | 21:59 |
| kadams54 | Hopefully closer to what's happening in the browser, since they don't change the selected attribute. | 21:59 |
| hatch | kadams54 yeah selectedIndex is the 'proper' way | 21:59 |
| hatch | sorry I should have remembered that sooner | 21:59 |
| kadams54 | hatch: is there a way to get at selectedIndex on a Node, or do I need to do node.getDOMNode().selectedIndex? | 22:21 |
| kadams54 | lazyweb | 22:21 |
| hatch | e.currentTarget.get('selectedIndex') | 22:21 |
| hatch | from your event handler | 22:21 |
| kadams54 | e.currentTarget is a Node instance | 22:22 |
| kadams54 | e._currentTarget is the DOM node | 22:22 |
| hatch | sort of | 22:23 |
| hatch | you want to use currentTarget | 22:23 |
| hatch | it's the Node instance | 22:23 |
| hatch | which normalizes a lot of things cross browser | 22:23 |
| hatch | OOo boy the remove relation dialogue doesn't work | 22:29 |
| huwshimi | Morning | 22:35 |
| huwshimi | hatch: Sorry I'm late | 22:35 |
| hatch | huwshimi YEAH!! | 22:36 |
| hatch | :P | 22:36 |
| hatch | morning | 22:36 |
| hatch | I'll let it slide...this time... | 22:37 |
| huwshimi | :) | 22:37 |
| hatch | huwshimi so the only thing on the docket is that kadams54 is going to wait to land his branch until yours lands so that you don't have to deal with any conflicts when everyone is gone | 22:38 |
| huwshimi | hatch: OK | 22:38 |
| huwshimi | hatch: Did you notice my last change? | 22:38 |
| hatch | yeah I saw that - I meant to ask you how it's supposed to get the drag events if they aren't attached when it's rendered anymore :) | 22:39 |
| huwshimi | hatch: Because they're already attached. | 22:39 |
| huwshimi | at init | 22:39 |
| hatch | huwshimi can you re-add your github avatar? they removed them a while back for some reason.... | 22:40 |
| hatch | :) | 22:40 |
| huwshimi | hatch: it's showing for me | 22:41 |
| hatch | yeah mine did too | 22:41 |
| hatch | I had to go in, remove it, and re-add it | 22:41 |
| huwshimi | oh | 22:41 |
| hatch | ok so yes they are being attached in the initializer now | 22:41 |
| hatch | I'm guessing it was done in render because it was only ever supposed to be rendered once | 22:41 |
| hatch | I'm guessing they are no longer only rendered once? | 22:42 |
| huwshimi | hatch: That's correct, it renders every time a unit gets added | 22:42 |
| huwshimi | (avatar uploaded) | 22:42 |
| hatch | ahh, well then in that case good fix :) | 22:42 |
| huwshimi | hatch: OK, well I'll finish the tests and try and get that landed then. | 22:43 |
| hatch | there's the robot I'm used to seeing! | 22:43 |
| huwshimi | hatch: Ah good | 22:43 |
| huwshimi | hatch: Anything else? | 22:43 |
| hatch | there was an extra card in the lane that kadams54 removed because he did it in his branch | 22:43 |
| hatch | my other branch landed so you can consolidate those methods if you like | 22:43 |
| hatch | and ecs ghost stuff is way blocked behind the new ghost ui changes.....but I have to confirm that with rick first | 22:44 |
| huwshimi | hatch: OK | 22:44 |
| hatch | Makyo are you still around? | 22:47 |
| Makyo | Barely, but yeah | 22:47 |
| huwshimi | hatch: Thanks for all that. I'm going to move locations. Back in 10. | 22:47 |
| hatch | quickly: the order of the endpoints in a relation is irrelevant right? | 22:47 |
| hatch | Makyo in other words I have to check both endpoint directions | 22:47 |
| Makyo | hatch, I believe so. | 22:48 |
| hatch | mysql:db > wordpress:db === wordpress:db > mysql:db | 22:48 |
| hatch | ok thanks | 22:48 |
| kadams54 | hatch: working on the issue of the simulates… not sure exactly how to deal with it though… are you thinking cascading 'after' event handlers like so: http://pastie.org/private/zrebcl2eth9bbmoar6ggfq ? | 23:07 |
| hatch | kadams54 yeah that should work | 23:07 |
| kadams54 | The only problem I see is that the code now executing after the event may be happening before or after any other event handlers (including code under test) that are looking at the same events. | 23:07 |
| hatch | but you'll need to add a done(); in the final callback | 23:08 |
| hatch | do you have other event handlers listening for the 'after' event in that test? | 23:08 |
| hatch | I'm not sure I understand | 23:09 |
| kadams54 | hatch: I *think* all the event handlers being exercised for the test are "on" and not "after" | 23:13 |
| kadams54 | But there's no guarantee | 23:14 |
| hatch | well does it pass? | 23:14 |
| hatch | holy look at the time | 23:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!