[06:11] <DalekSec> elfy: Howdy.
[06:14] <elfy> hi DalekSec
[10:32] <brendand> elfy, hello there
[11:06] <vinit> hi
[11:06] <vinit> hello anybody here
[11:06] <vinit> ?
[13:20] <elopio> ping ubuntu-qa: can somebody review this one please?
[13:20] <elopio> https://code.launchpad.net/~elopio/ubuntu-autopilot-tests/skip_dialer/+merge/223671
[13:23] <brendand> elopio, what's python2 about the test(s)?
[13:23] <brendand> elopio, oh is dialer_app python2?
[13:24] <elopio> brendand: yes, for now. The py3 branch is ready, but refusing to land.
[13:24] <robotfuel> elopio: I think we should wait for the dialer to land, disabling tests is evil.
[13:25] <elopio> robotfuel: I've waited since Malta.
[13:25] <elopio> https://code.launchpad.net/~barry/dialer-app/py3autopilot/+merge/220658
[13:25] <elopio> we certainly can wait more, but I think it's really important to get the project packaged, into de archive, and running daily with at least one test.
[13:26] <brendand> elopio, it's no rush. after all what's the point landing it if the tests won't run :)
[13:26] <elopio> I'm rebuilding almost daily the dialer, and chasing with a couple of people the errors.
[13:26] <elopio> brendand: there's one test that can run. The rush is that it will be really hard to get it working once people start landing more tests.
[13:27] <brendand> elopio, ok
[13:27] <elopio> if we have a green baseline, then it's easier to reject tests that make it red.
[13:27] <elopio> but if the two of you agree it's better to wait, I'll wait.
[13:27] <brendand> elopio, i can't ack it though. you need to ask ChrisGagnon
[13:35] <elopio> brendand: ok. robotfuel: it's your decision. If you want me to wait more, I'll wait more.
[13:36] <elopio> brendand: some things about your branch: https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus/+merge/223703
[13:36] <brendand> robotfuel IS ChrisGagnon :O
[13:36] <elopio> It comes without tests.
[13:36] <elopio> I think it should live in the address book helpers
[13:37] <elopio> and you have some pep257 errors and missing docstrings on public methods.
[13:38] <elopio> finally, the most important, it doesn't pass flake8.
[13:39] <brendand> elopio, it's really just so that me and rhuddie can share code at the moment. i don't think there's any point in having it in address-book until the tests there are going to use it
[13:39] <brendand> elopio, that's also the reason why it's a bit  'quick and dirty' style
[13:40] <brendand> elopio, it *barely* fails flake8 :P
[13:40] <elopio> brendand: that's precisely why we started this project. The original purpose was to improve the testability of all the projects we were working on. So we agreed to be blocked instead of merge things were they don't belong, or things without tests.
[13:41] <elopio> s/were/where
[13:41] <brendand> elopio, i'm disagreeing that it doesn't belong here, at the moment
[13:42] <elopio> brendand: I could understand we might need it there temporarily, but not without tests.
[13:44] <brendand> elopio, it's 50 lines of code right now
[13:44] <brendand> elopio, i will look at writing some tests for it though
[13:45] <elopio> brendand: thanks.
[13:48] <elopio> brendand: https://bugs.launchpad.net/ubuntu-autopilot-tests/+bug/1332093
[14:51] <elopio> brendand__: $ ubuntu-app-stop messaging-app
[14:52] <brendand__> elopio, cool - thanks!
[17:24] <balloons> elopio, you are messing with calendar right?
[17:38] <elopio> balloons: not yet. just reported the bug
[17:40] <balloons> elopio, ohh it failed on newevent? there's a toolkit bug and an autopilot bug attempting to be worked around in there
[17:40] <balloons> be careful
[18:01] <elopio> balloons: ok.
[18:02] <elopio> robotfuel: what's your veredict about https://code.launchpad.net/~elopio/ubuntu-autopilot-tests/skip_dialer/+merge/223671 ?
[18:02] <elopio> wait or land?
[18:03] <robotfuel> elopio: what will it take to get that mp to lan?
[18:03] <robotfuel> land
[18:03] <robotfuel> elopio: it doesn't seem like it should take much.
[18:03] <elopio> robotfuel: pray. We still don't have an idea of what's wrong.
[18:03] <robotfuel> elopio: who is working on it? barry?
[18:03] <elopio> robotfuel: that's what I though. But it's been ready since malta.
[18:05] <elopio> robotfuel: barry and xnox did the port. The current error is because ofono can't be installed, so people from ofono, the apps and ci are looking into it.
[18:05] <robotfuel> elopio: No module named 'exceptions' means it's using the old autopilot?
[18:05] <elopio> once ofono can be installed, it could work, or we could go back to one of the other errors. Every week is a different one.
[18:06] <elopio> robotfuel: what are you looking at?
[18:06] <robotfuel> elopio: maybe we need to maintain 2 branches :/ one for the py2 tests and one for py3?
[18:07] <elopio> robotfuel: why would we want to keep py2 tests instead of spend the effort porting them to py3?
[18:08] <robotfuel> elopio: because the py2 tests are working?
[18:08] <elopio> robotfuel: that's the reason we haven't finished the ports, because phablet-test-run has a hack that tries to import py3 and if it fails, runs the tests with py2.
[18:09] <elopio> they are working, yes. Not in a nice way though, delaying the removal of py2 and breaking the stories that will need to test things on apps that use py3 and others that use py2.
[18:11] <robotfuel> elopio: we can have 2 tests suites py3 and py2 until they are all py3? disabling the py2 tests because we want to move to py3 seems wrong to me.
[18:12] <elopio> robotfuel: well, disabling is relative. This tests have never been run. What I'm trying to do is to get them running for the first time.
[18:12] <elopio> so it's not that we will go from 2 tests to 1.
[18:12] <elopio> we will go from 0 tests to 1.
[18:12] <robotfuel> elopio: ah that is different then
[18:12] <robotfuel> elopio: +1 on getting to test 1
[18:13] <robotfuel> elopio: thanks for pointing that out :D
[20:59] <elopio> robotfuel: sorry, I lost my connection for a long time.
[20:59] <elopio> I just found out that I left the import dialer_app on the file, so instead of keeping code commented I just removed it
[20:59] <elopio> I will revert to the previous version once dialer is ready.
[21:00] <elopio> robotfuel: I would appreciate if you leave your review on the branch
[21:00] <robotfuel> elopio: I am glad you found it!
[21:00] <elopio> https://code.launchpad.net/~elopio/ubuntu-autopilot-tests/skip_dialer/+merge/223671
[21:15] <robotfuel> elopio: my debs are broken, it will be a bit.
[21:15] <robotfuel> apt  sources has a bad ppa
[21:16] <elopio> robotfuel: no need to rebuild it, thomi already checked that part.
[21:16] <elopio> actually,  I checked that what thomi gave me worked :)
[21:21] <robotfuel> elopio: I approved it, and updated the commit message.
[21:21] <robotfuel> elopio: I guess it has to be manually merged?
[21:21] <elopio> thanks robotfuel
[21:21] <robotfuel> elopio: we should setup a cfg in cupstream2-distro so it's run
[21:21] <robotfuel> in ci
[21:21] <elopio> yes, I will do it and ask ci for the automatic stuff.