| === shiznix_ is now known as shiznix | ||
| dednick | Saviq: re: active call indicator - I'm going into the office tomorrow to show designers what I've got. If they're happy, we're happy. | 07:45 |
|---|---|---|
| Saviq | dednick, kthxbai | 07:47 |
| Saviq | tsdgeos, hey, one more chevron is too big - the "go back to parent" one | 07:51 |
| tsdgeos | ah right | 07:51 |
| tsdgeos | too many of them | 07:51 |
| tsdgeos | pused | 07:53 |
| tsdgeos | +h | 07:53 |
| dednick | what's with the freaky new indicators on desktop... | 07:53 |
| * Saviq reboots | 07:53 | |
| dednick | they're like... buttons. | 07:54 |
| Saviq | dednick, sounds like you lost the theme? look the same here... | 07:56 |
| dednick | Saviq: yeah. that would probably track with what i'm seeing in other apps... | 07:56 |
| Saviq | mhr3, hey, do you know if it's on purpose that there's only headerless categories in the amazon scope now? | 08:02 |
| Saviq | mhr3, also, it seems the dept hierarchy in amazon is rather fragile... I just ended up in a category with no depts :| | 08:04 |
| Saviq | mhr3, although it looks like the query was good http://paste.ubuntu.com/7667799/ :| | 08:05 |
| mhr3 | Saviq, what category was that? | 08:10 |
| mhr3 | too much stuff in the log | 08:10 |
| Saviq | mhr3, the last one | 08:10 |
| Saviq | mhr3, I pasted the log as I was looking at a category with no depts | 08:11 |
| Saviq | tsdgeos, are we confident in childrenRect.height? wasn't it the case that it didn't update with the children changing size? | 08:11 |
| tsdgeos | hmmmm | 08:11 |
| Saviq | tsdgeos, I'm not seeing any artifacts of that in the behaviour, just asking | 08:12 |
| tsdgeos | i think there may be a problem if it shrinks | 08:12 |
| tsdgeos | don't recall right now | 08:12 |
| tsdgeos | but everywhere i've used lately seemed to work fine | 08:12 |
| Saviq | tsdgeos, now I remember | 08:12 |
| Saviq | tsdgeos, it was a specific case where anchors made the children grow, but shrinking didn't go back due to the children actually keeping the grown size | 08:13 |
| Saviq | tsdgeos, I'd have to think again to remember exactly what was happening, but yeah, it was some circular dep basically | 08:14 |
| tsdgeos | yeah i've seen that | 08:14 |
| tsdgeos | some min of childrenrect and stuff | 08:15 |
| tsdgeos | and then the parent makes the child big | 08:15 |
| tsdgeos | don't remember the exact sceneario either | 08:15 |
| tsdgeos | Saviq: just pushed a fix for swipe down to close two finger | 08:16 |
| tsdgeos | when you have time | 08:16 |
| Saviq | tsdgeos, great, thanks | 08:16 |
| Saviq | aaargh f*cking disappearing firefox... who broke unity :| | 08:17 |
| tsdgeos | my internet is specially unstable today :/ | 08:19 |
| Saviq | tsdgeos, we need a bit more margin between the "go back" chevron and the label | 08:19 |
| Saviq | https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/toolkit/2-navigation/02_Amazon_nav-01.jpg | 08:20 |
| tsdgeos | ok | 08:21 |
| tsdgeos | can do | 08:21 |
| tsdgeos | Saviq: i'm going to 0.5gu | 08:23 |
| tsdgeos | i know you hate decimal gus | 08:23 |
| Saviq | tsdgeos, .5 is fine | 08:23 |
| tsdgeos | but we're always going to have pxtogu > 2 | 08:23 |
| tsdgeos | so it should work | 08:24 |
| tsdgeos | pushed | 08:24 |
| Saviq | tx | 08:24 |
| Saviq | arg | 08:33 |
| mhr3 | Saviq, can't rep, you're getting different deps than in uk | 08:36 |
| Saviq | mhr3, k, let's see if we can get it later | 08:36 |
| mhr3 | Saviq, were you at least able to recover from it? | 08:37 |
| Saviq | mhr3, reopen the scope :| | 08:37 |
| Saviq | mhr3, wouldn't be good on a favourited one | 08:37 |
| Saviq | tsdgeos_, re: nullifyDepartment, why don't we just want to drop the delegate to the left as well? are we keeping the "history" of delegates all there? | 08:38 |
| mhr3 | Saviq, tried entering search and clearing? | 08:38 |
| Saviq | mhr3, right, that would probably help as well | 08:38 |
| Saviq | mhr3, but seeing as the query came back with departments, it looked like something broke closer to the UI (either plugin or dash UI) | 08:38 |
| tsdgeos_ | Saviq: it's hard to make the listview play nice with us if you remove the thing on the left | 08:39 |
| tsdgeos_ | doesn't like prepending stuff, et al | 08:39 |
| Saviq | tsdgeos_, mhm :| | 08:39 |
| tsdgeos_ | Saviq: don't remember the exact problem, but it's what i originally had | 08:39 |
| Saviq | tsdgeos_, the delegates are destroyed anyway, so it's probably fine | 08:40 |
| Saviq | tsdgeos_, any reason why not Flickable { Column { FooButton { } BarButton { } Repeater { } } } | 08:41 |
| tsdgeos_ | Saviq: "free" animation between columns when changing current index | 08:42 |
| mhr3 | Saviq, can we have a quick chat about customizations + cache later today? | 08:42 |
| Saviq | mhr3, tomorrow, I'm actually supposed to have a holiday today | 08:42 |
| mhr3 | heh, ok | 08:42 |
| Saviq | tsdgeos_, not sure what that means, we're switching the whole delegate anyway? | 08:43 |
| tsdgeos_ | i mean the horizontal animation when going up/down | 08:43 |
| tsdgeos_ | listview takes care of that | 08:43 |
| Saviq | tsdgeos_, yes | 08:43 |
| Saviq | tsdgeos_, I mean in DashDepartmentsList | 08:43 |
| tsdgeos_ | ah | 08:43 |
| Saviq | tsdgeos_, you have a Flickable, two (conditional) buttons and a Repeater there | 08:44 |
| tsdgeos_ | yep | 08:44 |
| Saviq | tsdgeos_, and calculate height / anchor / calculate y and all kind of things that column would do for you? | 08:44 |
| tsdgeos_ | right | 08:45 |
| tsdgeos_ | no reason other than i didn't think about it | 08:45 |
| Saviq | tsdgeos_, no need to change height then either, column disregards invisible items | 08:45 |
| tsdgeos_ | can try changing if you want | 08:45 |
| Saviq | tsdgeos_, yeah, it will be like 20 lines less and less complicated | 08:45 |
| tsdgeos_ | ook | 08:45 |
| * tsdgeos_ does | 08:45 | |
| tsdgeos | mhr3: so https://code.launchpad.net/~unity-api-team/unity-scopes-shell/department-support/+merge/222345 looks good to me, do you want me to top approve or wait for someone else? | 08:50 |
| mhr3 | tsdgeos, feel free to top, anyway pete and pawel are holidaying | 08:51 |
| tsdgeos | Saviq: it's not that many changes, no? only http://paste.ubuntu.com/7668003/ | 08:58 |
| tsdgeos | you see anything else that'd change? | 08:58 |
| Saviq | tsdgeos, sounds about right | 08:59 |
| tsdgeos | ok then | 08:59 |
| tsdgeos | not a huge improvement, but better still | 08:59 |
| Saviq | yeah, less crazy stuff :D | 09:00 |
| tsdgeos | but something broke horribly | 09:01 |
| * tsdgeos checks | 09:01 | |
| Saviq | tsdgeos, some small comments inline on the MP | 09:06 |
| tsdgeos | ok | 09:06 |
| Saviq | mhr3, tsdgeos, FYI, mikenagle is having a play with departments now, will comment on Albert's MP | 09:52 |
| Saviq | thostr_, ↑ | 09:52 |
| tsdgeos | Saviq: pushed + answered on the departments thing | 10:12 |
| tsdgeos | Saviq: cool, let's see what mikenagle thinks :D | 10:17 |
| mhr3 | > Why do we need this? Wouldn't model: department just work? Do we need to wait for it to be loaded? | 10:20 |
| mhr3 | Yes, i don't want stuff to appear one by one in case the model loads very slowly | 10:20 |
| mhr3 | tsdgeos, ^^ backend-wise it's already binary | 10:20 |
| mhr3 | the model is either empty and !loaded, or filled in && loaded | 10:21 |
| Saviq | tsdgeos, saw mhr3's response? | 10:26 |
| tsdgeos | nah | 10:26 |
| tsdgeos | sad internet today | 10:26 |
| Saviq | <mhr3> > Why do we need this? Wouldn't model: department just work? Do we need to wait for it to be loaded? | 10:26 |
| Saviq | Yes, i don't want stuff to appear one by one in case the model loads very slowly | 10:26 |
| Saviq | tsdgeos, ^^ backend-wise it's already binary | 10:26 |
| Saviq | the model is either empty and !loaded, or filled in && loaded | 10:26 |
| Saviq | mhr3, tsdgeos, in any case, this way it's more future-proof, in case you start lazy-loading them | 10:27 |
| tsdgeos | ah | 10:27 |
| tsdgeos | ok | 10:27 |
| Saviq | tsdgeos, still don't know how index == currentIndex is different than ListView.isCurrentItem ;) | 10:28 |
| Saviq | tsdgeos, the "I want to wait for the transition to finish" is handled by x == contentX | 10:28 |
| tsdgeos | Saviq: ah damn, i thought you were speaking about the other part | 10:28 |
| Saviq | tsdgeos, yeah, thought so | 10:28 |
| tsdgeos | actually with the other part i don't even need that i think | 10:29 |
| tsdgeos | let me check | 10:29 |
| Saviq | probably | 10:29 |
| Saviq | tsdgeos, did you have a look at http://developer.ubuntu.com/api/qml/sdk-1.0/Ubuntu.Components.ListItems/ ? those look kinda like everything you need (with the exception that the left icon would probably end up being too big... | 10:31 |
| Saviq | tsdgeos, so I'd be fine with "TODO: check if SDK ListItems could be use here" fornow | 10:32 |
| tsdgeos | i did look there yes | 10:32 |
| tsdgeos | i mean it provides what exactly that would save me any code? | 10:32 |
| Saviq | tsdgeos, in any case - if it does *not* help us, we need to make it so that it does | 10:33 |
| tsdgeos | correct | 10:34 |
| tsdgeos | ok, i'll add the TODO, ok? | 10:34 |
| Saviq | yup | 10:34 |
| Saviq | tsdgeos, because it's just a damn shame that we have to do it manually when the pattern is used across the board | 10:34 |
| Saviq | we should just be able to do | 10:34 |
| tsdgeos | correct | 10:35 |
| Saviq | ListItem { leftIcon: "foo"; text: "bar"; rightIcon: "bar" } | 10:35 |
| Saviq | and be done with it | 10:35 |
| tsdgeos | Standard would be it maybe | 10:36 |
| tsdgeos | but doesn't have the backicon and stuff | 10:36 |
| tsdgeos | Saviq: ok, removed index == departmentListView.currentIndex | 10:41 |
| Saviq | tsdgeos, well, backicon you could do, but there's no way to add a custom icon on the right | 10:55 |
| Saviq | mhr3, I just saw the "Get more apps" card in Apps... it's medium instead of large? and has transparent grey background, that expected? | 11:00 |
| mhr3 | Saviq, was asking apps guys about that, they said it's temporary cause dash doesn't support what they want | 11:01 |
| Saviq | mhr3, what is it they want? | 11:01 |
| Saviq | mhr3, it's wrapped, elided, it's just bad right now | 11:01 |
| mhr3 | https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/app-scope-home/app-scope-landing-page/01_Home_apps_store_scope.jpg?attachauth=ANoY7cpK1NvR0ZTsFyIXnZaKtcG2FSSY_cyU5yEdv-Xht60QMZ8PALgaBxN3HEIBoG6lzO45JQ2IoF-fagQuvVtjJIJn2g7JPlDr6RZZPTENKfu9uNzXWkHqdloDqYeINZa2Vyl4mcmaoeIXy_BK1G8H6W_PVwq7FTeqn8eW-kllBkw5OP8nws_JTfy2fKeeEzKj0FUmqhFyVpmr9wzrOLxYuHBUbDNG2EkDwKxAvoy3Z3DfaCmNDdfQkDy8713Bo | 11:01 |
| mhr3 | 5CmF224NEFg478xcqQRF6ohRhTiBtDFbh9WNbyM0B8VsHxKch7LaFk%3D&attredirects=0 | 11:01 |
| mhr3 | Saviq, http://goo.gl/DOVGvO | 11:02 |
| Saviq | hmm ok that's news to me, last I checked it was meant to be a full-width card :| | 11:03 |
| Saviq | what's on this image doesn't look like anything that's planned to work :| | 11:04 |
| mhr3 | Saviq, spec says Sm_ARt_Header_Vertical | 11:04 |
| Saviq | mhr3, except there's no overlay background | 11:05 |
| mhr3 | with title overlay | 11:05 |
| Saviq | mhr3, yeah, but overlay requires some background, this one doesn't have it | 11:05 |
| mhr3 | wasn't there one customization param for that? | 11:06 |
| Saviq | mhr3, solid background | 11:06 |
| Saviq | mhr3, not transparent, because then we can't know what foreground colour to use | 11:06 |
| Cimi | I will spend the rest of my life in this file | 11:07 |
| mhr3 | Saviq, meh, it's ubuntu orange | 11:07 |
| Saviq | mhr3, it's not, it's transparent ;) | 11:08 |
| mhr3 | visual bug :P | 11:08 |
| Saviq | if you say so ;) | 11:08 |
| Saviq | but yeah, we can do that with a solid overlay background | 11:08 |
| Saviq | mhr3, should I see "allLabel" in the proxy log? | 11:10 |
| mhr3 | Saviq, if it's != label | 11:10 |
| Saviq | mhr3, that's what Mike noticed that the bold label is not "All books" but "Books" | 11:10 |
| mhr3 | scope bug | 11:10 |
| Saviq | k | 11:11 |
| mhr3 | facundo should be here | 11:11 |
| Cimi | Saviq, I recommend to approve and merge emblem | 11:11 |
| Cimi | Saviq, then we wait for this rewrite | 11:11 |
| Saviq | Cimi, you "recommend" meaning that you couldn't do what I asked you to? | 11:12 |
| Cimi | Saviq, yeah | 11:12 |
| Cimi | Saviq, need more time | 11:12 |
| Cimi | Saviq, and we have a reference code that works | 11:13 |
| Cimi | Saviq, so it is easier to spot regressions if I mess up with this | 11:13 |
| Cimi | otherwise wait more :) | 11:13 |
| Cimi | i hope to finish today | 11:13 |
| facundobatista | buenos días a todos! | 11:14 |
| Saviq | Cimi, I'm finishing up for today anyway | 11:14 |
| Saviq | tsdgeos_, ACK from me | 11:14 |
| Saviq | mhr3, ↑ | 11:14 |
| Saviq | thostr_, ↑ | 11:14 |
| mhr3 | wooo :) | 11:15 |
| Saviq | so unless Mike says NACK, you can land | 11:15 |
| * Saviq rebuilds unity8 though | 11:15 | |
| mhr3 | i'll be heading to the office, see what mike says | 11:15 |
| tsdgeos_ | great | 11:15 |
| mhr3 | Saviq, i'll do it | 11:15 |
| Saviq | mhr3, ok | 11:15 |
| Saviq | mhr3, thostr_, you will execute the unity8 TestPlan of course? :) | 11:17 |
| * Saviq just added to the landing line | 11:18 | |
| mhr3 | Saviq, of course! ;) | 11:18 |
| Saviq | o/ | 11:19 |
| mhr3 | facundobatista, ehm | 12:03 |
| mhr3 | facundobatista, https://dash.ubuntu.com/smartscopes/v2/amazon/search?q=&session_id=session_id&query_id=0&platform=phone&locale=en_US | 12:03 |
| mhr3 | just departments, no results | 12:03 |
| mhr3 | what the? ^ | 12:03 |
| facundobatista | mhr3, amazon fuzzy behaviour? I just tried it and got one result | 12:05 |
| mhr3 | facundobatista, apparently it's the query_id=0 that blows it | 12:05 |
| facundobatista | mmm | 12:05 |
| facundobatista | mhr3, it shouldn't... query_id is just converted to int if there (so '0' is ok), and not used at all in the scope | 12:07 |
| * facundobatista tries it locally | 12:07 | |
| mhr3 | caching issue? | 12:07 |
| mhr3 | facundobatista, what is the id even used for? | 12:09 |
| mhr3 | we seem to be passing 0 all the time | 12:09 |
| mhr3 | marcustomlinson, ^? | 12:09 |
| marcustomlinson | mhr3: integer incremented for each subsequent query in a session | 12:10 |
| marcustomlinson | mhr3: we haven't even got session_id implemented | 12:10 |
| mhr3 | marcustomlinson, nope, query_id is always 0 in the request | 12:11 |
| marcustomlinson | mhr3: yes, I'm saying its not implemented | 12:11 |
| facundobatista | mhr3, when it's implemented, we will use it to gather stats between searches and previews | 12:11 |
| facundobatista | mhr3, like "oh, see, if the images are > N pixels wide, the preview hit rate goes up by M%!!" | 12:12 |
| mhr3 | seems too much to require per-session ids AND sequence number within that session | 12:12 |
| facundobatista | mhr3, in any case, it's not breaking the query | 12:12 |
| mhr3 | it is for me | 12:13 |
| mhr3 | facundobatista, does this help? http://paste.ubuntu.com/7668748/ | 12:14 |
| facundobatista | mhr3, you have different results without the query_id parameter? | 12:14 |
| mhr3 | yes | 12:14 |
| facundobatista | it may be caching, yes, let me see | 12:16 |
| facundobatista | mhr3, can you issue both queries from your machine using "curl -i", please? | 12:16 |
| === alan_g is now known as alan_g|lunch | ||
| mhr3 | facundobatista, http://paste.ubuntu.com/7668758/ | 12:17 |
| facundobatista | mhr3, that is not with and without the query_id parameter | 12:20 |
| facundobatista | mhr3, that is with different value | 12:20 |
| facundobatista | mhr3, "query_id" is not used at all in the amazon scope | 12:20 |
| mhr3 | same thing | 12:20 |
| mhr3 | http://paste.ubuntu.com/7668767/ | 12:20 |
| facundobatista | mhr3, right, same thing, that implies that the parameter is not breaking the query | 12:21 |
| mhr3 | it implies that the cache is broken for query_id=0 | 12:21 |
| facundobatista | ah, mmm | 12:23 |
| mhr3 | fwiw some of these were cache misses when i started | 12:24 |
| facundobatista | mhr3, I will investigate this cache issue | 12:24 |
| mhr3 | thx | 12:24 |
| === alan_g|lunch is now known as alan_g | ||
| elopio | ping @unity. Can somebody review this one please? | 13:21 |
| elopio | https://code.launchpad.net/~elopio/unity8/flake8/+merge/223495 | 13:21 |
| tsdgeos | it has lots of stuff i don't like | 13:22 |
| tsdgeos | probably has one of those silly "we live in the 70s and you're using a 80 column terminal to edit this so let's wrap the line" rules | 13:23 |
| tsdgeos | so you'll find someone else to approve it | 13:23 |
| * kgunn takes note to get tsdgeos and duflu in a cage match over 80 col topic ;) | 13:28 | |
| tsdgeos | kgunn: i honestly don't care, just unhappy people destroy history over small stuff like that | 13:29 |
| mhr3 | mikenagle, ping? | 13:41 |
| mhr3 | mikenagle, are you in a meeting somewhere? can't find you | 13:42 |
| Cimi | mhr3, he's not in the office | 13:44 |
| mhr3 | Cimi, oh? | 13:45 |
| Cimi | mhr3, you went to the office for nothing | 13:45 |
| Cimi | mhr3, I'm taking piss... I don't know really :P | 13:45 |
| mhr3 | Cimi, anyway i mostly wanted lunch for borough market :P | 13:46 |
| mhr3 | from* | 13:46 |
| Cimi | ahaha | 13:46 |
| mhr3 | Cimi, ah, cheeky bastard! :P | 13:46 |
| elopio | tsdgeos: it's pep8, not a small thing :D | 13:58 |
| elopio | all the rules of the python civilization are built on top of it | 13:59 |
| tsdgeos | elopio: that's why i'm not against it, just not approving it ;) | 14:04 |
| seb128 | Saviq, should unity8 in silo 008 be rebuilt with the new mir? | 14:12 |
| tsdgeos | seb128: i think he said he was off for the day | 14:13 |
| tsdgeos | seb128: but afaik we're landing departments first | 14:13 |
| tsdgeos | mhr3: are we? | 14:13 |
| tsdgeos | did anyone find mikenagle so he can ack/nack? | 14:13 |
| seb128 | tsdgeos, well, that silo is a test one, no landing planned yet | 14:13 |
| tsdgeos | ah :D | 14:14 |
| * tsdgeos hides | 14:14 | |
| mhr3 | tsdgeos, yes, landing right now | 14:14 |
| tsdgeos | mhr3: awesome \o/ | 14:14 |
| mhr3 | seb128, ^^ | 14:14 |
| seb128 | tsdgeos, mhr3: thanks | 14:15 |
| Cimi | Saviq, did you see my comment yesterday on how to turn on infographics? | 14:16 |
| mikenagle | tsdgeos - saviq got hold of me - just been in a lot of meetings | 14:16 |
| Saviq | Cimi, yes I saw that, we still need to wait for Pete to say why it doesn't work | 14:20 |
| Cimi | Saviq, well camera doesn't work | 14:20 |
| Cimi | Saviq, infographics on shell do | 14:20 |
| Saviq | Cimi, it should work on others as well (through a compatibility layer) | 14:20 |
| Saviq | seb128, no need to rebuild u8, no, not until 5.3 lands, which should happen later today | 14:20 |
| Saviq | seb128, only unity-mir would need rebuilds against new Mir | 14:21 |
| Cimi | Saviq, so we wait till pete fixes issues in the service? | 14:21 |
| seb128 | Saviq, k, thanks | 14:21 |
| === alan_g is now known as alan_g|tea | ||
| === alan_g|tea is now known as alan_g | ||
| === mhall119_ is now known as mhall119 | ||
| tsdgeos_ | arggg internet! | 15:52 |
| tsdgeos_ | enough internet disconnections for today | 15:59 |
| tsdgeos_ | ! | 15:59 |
| * tsdgeos_ waves | 15:59 | |
| kgunn | mterry: hey, boot anim looks good to me | 16:23 |
| mterry | kgunn, oh awesome! | 16:23 |
| mterry | kgunn, I'll mark that silo as tested then. Seemed fine to me yesterday too | 16:24 |
| kgunn | have you test n10 ? i was gonna test it real quick...n4, n7 look fine | 16:24 |
| mterry | kgunn, no I haven't recently | 16:24 |
| kgunn | 5 min and i'll have it | 16:24 |
| mterry | kgunn, OK | 16:24 |
| mterry | kgunn, I believe the icon will appear smaller than you'd like. But that's a filed bug that MacSlow will hopefully have time for | 16:24 |
| kgunn | ack | 16:25 |
| === gatox is now known as gatox_lunch | ||
| MRRpc | hello is there anybody to help me :) | 16:39 |
| mterry | kgunn, any luck with n10? | 16:48 |
| kgunn | mterry: just finished...all good | 16:48 |
| mterry | sweet | 16:48 |
| kgunn | ship it | 16:48 |
| mterry | kgunn, how was icon size? | 16:49 |
| kgunn | fine | 16:50 |
| mterry | oh good. Maybe MacSlow doesn't need to do anything after all | 16:53 |
| === alan_g is now known as alan_g|EOD | ||
| kgunn | mterry: do you have an opinion on the last comment on this mp ? | 17:08 |
| kgunn | https://code.launchpad.net/~albaguirre/unity8/use-new-display-power-state-interface/+merge/219552 | 17:08 |
| === gatox_lunch is now known as gatox | ||
| facundobatista | mzanetti, ping, remember that tool you told me about in Malta? How was it named? I have a Utopic machine, I can use it :) thanks! | 17:48 |
| === kgunn is now known as Guest13280 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
