/srv/irclogs.ubuntu.com/2014/06/23/#ubuntu-quality.txt

=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
pittiGood morning05:32
=== vrruiz_ is now known as rvr
=== roadmr is now known as roadmr_afk
=== roadmr_afk is now known as roadmr
=== ara is now known as Guest7746
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
pittiballoons: FYI, I can successfully run autopilot click tests through adt-run now :)13:55
balloonspitti, awesome!13:57
elfyballoons pitti - good day to you both13:59
balloonspitti, is this something I can try myself?13:59
pittihey elfy13:59
balloonsgood day elfy13:59
pittiballoons: yes, although it'll be slightly easier in an hour or so when I commit the script14:00
pittiballoons: for now I test in an LXC container and have a setup script which starts upstart session and Xvfg14:00
pittiballoons: today I figured out how to do that14:00
pittiballoons: it still apt-get installs test deps, that's still a TOD14:00
balloonspitti, awesome that's very similar to how we do it in core apps jenkins14:01
pittiballoons: that's my diff for lp:ubuntu-calculator-app FYI: http://paste.ubuntu.com/7690488/14:01
pittierr, I figure that should be @AUTOPILOT_DIR@ stil14:01
pittil14:01
balloonspitti, yes, I remember you started the conversation about PYTHONPATH=tests/autopilot:$PYTHONPATH autopilot3 run14:03
=== salem_ is now known as _salem
pittiballoons: I might do that PYTHONPATH by default, but for now this is working14:03
=== _salem is now known as salem_
jibelpitti, I've an almost working ssh runner + setup script for adb which works for deb packages. I need to add command line parsing to pass arguments like a serial-id then it'll be ready for a first review. It's still basic but works with simple packages.14:17
pittijibel: nice!14:20
pittijibel: coming from the other side, I now have a working --setup-commands script for running click autopilot tests with an LXC container; it runs Xvfb and an upstart user session, so that ubuntu-app-launch works14:21
pitti./run-from-checkout --setup-commands ~/setup-click-lxc ~/ubuntu/tmp/ubuntu-calculator-app/ ~/ubuntu/tmp/com.ubuntu.calculator_1.3.283_all.click --- lxc -es adt-utopic14:21
jibel./run-from-checkout -dd libpng --- ssh -s virt-subproc/adb.ssh -d -- -s 04dc228756e547e714:23
jibelwhere adb.ssh is the setup script for adb hosts14:23
pittijibel: nice! so you just pass the additional args directly to adb I suppose, so that you can also not specify it if you just have one dev?14:25
jibelpitti, I pass the additional args to the setup script which in turn can pass it to adb14:26
jibelthis way you can write a setup script that configures the device differently for debs or click for example14:26
pittiright14:27
pittivery nice14:27
jibeland in the setup script you create on function per hook in the runner if your host can support revert or reboot and other don't14:27
jibels/on/one14:27
brendandjibel, is there a simple way one can run autopkgtests in the same environment as they are run in jenkins?14:34
jibelbrendand, yes, http://packaging.ubuntu.com/html/auto-pkg-test.html14:40
jibeladt-run libpng -U --apt-pocket=proposed --- qemu adt-trusty-amd64-cloud.img14:40
=== salem_ is now known as _salem
pittiballoons: if you want, you can try it now15:12
=== _salem is now known as salem_
=== salem_ is now known as _salem
elopioballoons: you reverted also my changes to the filemanager tests, right? Should I propose the branch again?15:24
balloonspitti, as soon as I hop off this call I will.. probably will be EOD for you15:24
balloonselopio, those should be in trunk still15:24
balloonsI'll leave you my thoughts either way :-)15:25
elopioah, you are right.15:26
elopioI'm not sure what diff I read.15:26
=== _salem is now known as salem_
pittiballoons: I G+ed how to run them, let me know how it works for you :)15:43
balloonspitti, awesome thank you.. pitti do you think you would be available tomorrow for a ubuntu on air session? We'd like to interview you about systemd and all these testing goodies.. And the community is allowed to ask any questions as well15:45
balloonsit's at 1500 UTC tomorrow15:45
balloonsit's a weekly on-air we do (used to be jono, now it's various folks from the community team)15:46
pittiballoons: 15:00 UTC works, if it's not longer than an hour15:47
balloonspitti, thanks. Yes, it's an hour15:48
balloonsyou'll be with michael and I.. He'll send along an invite15:49
balloonsyou don't need to prep anything.. but if you want to give any demos of cool stuff you are working on feel free. I'm asking because people where curious about systemd and some of the other things you work on.. You're popular ;-)15:50
pittiballoons: heh, it's been some weeks since I've worked on systemd, have been busy with testing stuff; but I'll get back to it!15:51
balloonspitti, lol.. I'm glad you are on testing stuff :-)15:51
balloonsyou are solving a longstanding problem in a slick way.. I'm excitied to try it out15:51
=== chihchun is now known as chihchun_afk
balloonswxl, did you see the email from stgraber about alpha1? You should reply to it15:52
=== salem_ is now known as _salem
=== roadmr is now known as roadmr_afk
=== roadmr_afk is now known as roadmr
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
elopioballoons: lets talk about reminders.16:59
wxlballoons: argh, i must not be on the list. i'll have to take care of that when i have time to breathe :)17:04
balloonselopio, awesome, let's17:25
elopioI've just updated it and I get:17:27
elopio  File "/media/elopio/workspace/canonical/reminders-app/trunk/tests/autopilot/reminders/credentials.py", line 114, in _process_session17:27
elopio    session = Signon.AuthSession.new(identity, method)17:27
elopioTypeError: Argument 1 does not allow None as a value17:27
elopiowhich is a lot better than segfault.17:27
balloonselopio, so essentially the RemindersTestCaseWithAccount doesn't work reliably17:27
balloonselopio, when I tried on Friday I ran many times, but only saw one in which the test passed.17:28
elopioballoons: what's the error that you are getting?17:29
balloonsit's unclear if the account fails to create or if the dispatcher fails, or reminders itself17:29
balloonselopio, I get a test failure generally.. nothing indicative of were the problem lies17:30
balloonsohh running just now I got an actually crash, fun17:32
elopioI'm upgrading because there's a new online accounts.17:32
balloonsyea, I upgraded this morning17:33
balloonsprobably why it's crashing today17:33
elopioballoons: I get the same error after upgrading. TypeError.18:02
elopioI'll debug.18:02
balloonshttp://paste.ubuntu.com/7691432/18:02
balloonselopio, so let me ask a couple questions. It seems you are starting the app, creating the evernote account through the account console, then sending a fake dispatch message to reminders to let it know the account was created in online accounts and to use it. The tests then wait for the dialog to disappear and then runs18:11
balloonsso first question, why not just make the account before we launch?18:11
balloonssecond, I think we could use a little more debugging around creating the account and the dispatch to know when / where/ how things are failing18:12
=== salem_ is now known as _salem
balloonselopio, any luck?20:26
elfywxl: it's all good fun isn't it :)20:32
elopioballoons: sorry, I took the lunch break.20:56
elopioI'm looking at the log as I debug.20:56
elopioto answer your questions, we are not sending a fake dispatch message to reminders. We are creating a real account through the gi backend of online accounts.20:57
elopiono fakes here.20:57
balloonselopio, ok, so how does reminders see the new account? and why create it after the fact?20:58
elopiowe make the account after we launch, because the existing set up opened the app.20:58
elopiothen online accounts sends a signal somehow to the app, and it notices now it has an account.20:59
balloonselopio, so this signal might not be happening.. or might be taking a long time, etc20:59
balloonsI tried adding a long sleep to no avail20:59
elopiowe could create it before, but it doesn't change anything.20:59
elopiono, the account is not being created.20:59
elopioat least here.20:59
elopio$ account-console list21:00
elopiodoes that show the evernote account for you while we are waiting for the dialog to disappear?21:00
balloonselopio, it wasn't before.. I can check again21:06
balloonswhen I was looking friday, it was my first target.. more feedback on successful (or not) account creation21:06
balloonsso since we don't have control over when/how the message is sent to the app, that means it could be a race condition as well21:07
balloonsas I said, it did work one time on friday21:07
balloonselopio, actually I do see the new account in account-console list :-)21:08
elopioballoons: if the application doesn't see when the account is created and hides the dialog, then it would be a bug on the app.21:08
balloonssee running it again, no account created21:10
elopioif the account is not created, the problem is on the credentials.py or online accounts.21:11
elopioabout adding more debug information, yes it will help.21:11
balloonsok, now this time it worked21:11
balloonsclearly there's a race going on21:11
elopioI have put a check on the errors on all the async methods, but it seems the error here comes from the internal gi methods.21:12
elopioballoons: I don't have it clear what you mean with race condition.21:12
elopiolike, we are adding the new account before we are deleting the old one?21:13
* balloons continues to play21:13
balloonsI mean we create the account, and somewhere along the line it's not transmitted to the app..21:13
balloonsbut playing further I'm not sure that's correct now21:14
elopioI'm going to make a new test that only checks that the account is added.21:16
elopiowe don't have that, and that's why there's a huge gap on the feedback we get out of the tests.21:16
balloonselopio, ok, so interesting.. I've noticed it works if I do the accountmanager creation before starting the app21:19
balloonsI don't create the account itself till after app launch, but I create the object21:19
balloonsbefore it launches21:19
balloonslet me commit and push and you'll see what I mean21:19
elopioballoons: ok, that's good. Can you try opening the app manually, and then adding the account manually to see what happens?21:20
balloonselopio, here's the diff21:21
balloonshttp://paste.ubuntu.com/7692263/21:21
balloonshas a couple local commits minus in it, sorry about that21:21
elopiook, that's weird, but if it fixes your problem and makes your tests pass always, then I guess it's good.21:22
elopioI'll try it here, but I think the error I'm seeing is different than the one you are seeing.21:23
balloonselopio, lol.. well actually the tests fail trying to find some sort of tab, but I'm not worried about that so long as they run.. But yea, weird eh?21:23
elopiowhat you are doing there is creating the account manager before patching the home.21:23
balloonsyes indeed21:23
balloonsbut we can try some other fun things.. there's probably something more elegant.. it's just indicative of the issue. A clue about what's going on if you will21:24
elopioballoons: to actually understand things, we would need mardy. This is a lot of async calls with not a lot of documentation, so I have just been doing what he tells me.21:27
balloonselopio, mmm.. I wonder...21:28
balloonselopio, I assume there is a backend service being run correct? For music to work I had to pass the environment to upstart as well21:30
elopioballoons: oh, one more thing. You have to check account-console list using the same HOME as the test.21:30
elopioballoons: are you on the phone or on desktop?21:31
balloonselopio, ofc.. i'm on the desktop atm, as it wasn't working on either one.. easier to play with on desktop first21:31
elopioballoons: ok, I was just wondering if we were on the same environment.21:31
elopioballoons: utopic, right?21:32
balloonselopio, yes utopic.. why what is trunk of reminders doing for you?21:32
elopioballoons: session = Signon.AuthSession.new(identity, method)21:33
elopioTypeError: Argument 1 does not allow None as a value21:33
elopioI don't get why it works for you.21:33
balloonsyou are totally up to date?21:33
balloonsno weird ppas? let me check package info and compare with you21:34
elopioballoons: only the apps ppa.21:34
balloonsubuntu-system-settings-online-accounts Version: 0.4+14.10.20140612-0ubuntu121:35
balloonsgnome-online-accounts Version: 3.12.2-121:36
elopiocrap, no. I thought I upgraded but this packages were kept back.21:36
* elopio dist-upgrades.21:36
balloons:-)21:37
balloonsso elopio you aren't doing anything with FakeURLDispatcherService atm?21:41
elopioballoons: I am for the tests without account. Click the go to accounts button, and check that the fake url dispatcher got the right url.21:42
balloonselopio, ahh.. ok, gotcha21:42
elopiowith an account, we don't need url dispatcher at all.21:42
balloonselopio, well.. I'm wondering what to do21:46
balloonsI'm going to send this at the device and jenkins and see what happens21:47
balloonstests pass (i forgot to compile the new app, lol)21:48
elopiook, after a long fight with my modem, I'm up-to-date22:03
elopiosame error :@22:03
balloonselopio, wow22:04
balloonshttps://code.launchpad.net/~nskaggs/reminders-app/real-account-ap-fix/+merge/22422022:04
elopioballoons: are all those wait_select_single actually needed?22:06
balloonselopio, I don't think so. let me revert them22:06
balloonsI'm fighting with my python installation atm22:07
balloonsso I've lost bzr, but I'll revert22:07
elopioI see my problem, the authentication method is None.22:08
elopiobut I don't understand how's that possible.22:08
elopioI'll ask mardy by mail.22:08
elopioballoons: after uncommenting the assertEqual, you can remove these lines:22:10
elopio127self.assertEqual(last_notebook[0], test_notebook_title)22:10
elopio128self.assertEqual(last_notebook[2], 'Private')22:10
elopio129self.assertEqual(last_notebook[3], 0)22:10
elopioif your changes pass on Jenkins, I'd say lets get them merged.22:10
elopioleave the understanding for later.22:11
balloonselopio, lol, I see those now.. k, I'll do that too22:11
* balloons notes reinstalling python is cubersome22:11
balloonswhich is almost like cumbersome.. but easier to (mis)spell22:12
knome:P22:13
balloonsevening knome22:14
knomeevening22:15
knomewatched a lot of football lately? ;)22:15
balloonsknome, I've been watching all the costa rica games.. otherwise I haven't seen any22:18
balloonslol, btw elopio , I watch the games in Spanish.. It's the only proper way22:18
knomeoh boo22:18
knomewhy costa rica only?22:18
balloonsknome, why boo? Is there another game I should see?22:19
elopioballoons: tomorrow watch it on teletica.com22:19
knomemany!22:19
balloonselopio, ty, I will22:20
knomegermany-ghana was awesome...22:20
balloonsknome, lol, I suppose. I may watch some of the later games out of group stage22:20
balloonsgets easier with less matches22:20
knome italy-uruguay tomorrow22:21
knomethey decide which one goes through22:21
balloonsyes, someone has to join england and go home22:21
knomeso that's an interesting one at least22:22
balloonscourse, those are the only 2 other teams I've seen play, lol22:22
knome:P22:22
knomeand why not the group C matches tomorrow as well22:22
knomepretty much is still open22:22
knomewednesday looks somewhat boring, but thursday is going to be interesting all around22:23
balloonsstill re-installing..22:24
balloonsohh I see us plays germany thursday22:24
knomethat too ;)22:25
knometechnically any team can be dropped out from that group..22:26
balloonsyes, with the tie22:26
knomeeven germany can be out22:26
knomewell, they'd have to lose to the US and either of the other teams would have to win by far22:27
knomeit's *very* unlikely22:27
balloonselopio, https://code.launchpad.net/~elopio/reminders-app/fix_with_account/+merge/224221, why not use the helper?22:31
elopioballoons: which helper?22:35
balloonselopio, the mocking helper you did.. it merged did it not? The one based on calendar22:36
balloonselopio, get rid of _patch_home and use the helper right?22:36
elopiooh, the fake home, yes.22:36
elopioI didn't want to change anything on that first try.22:37
balloonsfair enough.. btw, I tried implementing jamie's idea of using symlinks to finish off the last errors and it didn't work..22:37
balloonsrandom sidebar ^^22:37
elopioballoons: all the test passed there :(22:38
elopioI was expecting jenkins to show what you see or what I see. It shows neither.22:38
balloonselopio, yes pretty crazy22:38
balloonselopio, I tried topapproving riccardo's change that won't land due to the issues experienced22:38
balloonsit theory, it should land now if jenkins is suddenly happy again22:39
elopioI'll keep rebuilding it, to see if I find sometihng useful.22:39
balloonselopio, the real tests is https://code.launchpad.net/~rpadovani/reminders-app/newHeader/+merge/22029122:44
balloonslook at the long ling of rejections22:44
elopioballoons: well, the last errors there show22:55
elopio    self.main_view.open_toolbar().click_button('addNotebookButton')22:55
elopiowhich of course is going to fail as there is no toolbar.22:56
balloonswow...22:57
balloonsI had thought it was something else22:57
balloonsso all that said, why does it fail on my desktop, lol22:57
* balloons is confused22:57
elopiothat's not in trunk yet, right?22:58
balloonsthe newheader isn't in trunk no, that's the merge. We can update the tests easily enough to account for it22:58
elopioso it could be that you are using trunk, or that you are launching the installed reminders that's trun22:58
elopioor something weirder, that's alwasy possible.22:58
balloonsindeed.. well, I'll grab his branch and fix the test to account for no toolbar at least22:59
elopioballoons: ok, thanks.23:00
balloonsty ofc23:00
elopioI hate when it works everywhere except in my machine.23:00
elopioI'll fire up a vm to see if a clean environment is better.23:00
balloonsI'm feeling that way.. I'm starting to feel a little crazy.. but that's ok, if it works, it's good.23:00
balloonselopio, want to have some fun?23:01
elopioballoons: sounds like a trick23:01
balloonselopio, https://plus.google.com/107564545827215425270/posts/ebnEJNS9SJ223:02
balloonsrather than vm, you could run in an lxc container :-)23:02
elopiooh yes! that's going to be nice.23:02
balloonsanyways . . .23:02
elopiobut I don't yet understand how will it work with lxc, if mir doesn't suport a virtual framebuffer23:02
elopioI'll give it a try.23:03
elopioballoons: I've just set it up on my laptop, and it runs flawlessly from trunk.23:54
balloonselopio, tried your branch and trunk.. both fail23:54
balloonsmy branch works for me23:54
balloonsgonna land https://code.launchpad.net/~nskaggs/reminders-app/newHeader/+merge/224225, then call it for the night23:54
elopioballoons: it seems from the diff that you are touching the po files.23:56
elopioas for the autopilot change to use the header, looks good.23:57
elopiothanks to timp for making it that easy.23:57
balloonselopio, ugh, that's not intended23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!