=== Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === fginther is now known as fginther|away === fginther|away is now known as fginther === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === chihchun_afk is now known as chihchun === roadmr_afk is now known as roadmr === roadmr is now known as roadmr_afk === roadmr_afk is now known as roadmr [07:29] pitti, I made some progress on a nova setup script for the ssh runner. I'd need to add a wait_for_ssh in adt-virt-ssh because nova returns when the VM is active but it takes a moment before ssh is really listening. Are you okay with that or do you think of another way to do it? [07:29] jibel: no, that's a good idea; it can affect LXC as well [07:30] jibel: http://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=shortlog;h=refs/heads/adt-virt-ssh is up to date with what I have [07:30] (except the test cases) [07:30] pitti, ok, that's the branch I checked out [07:31] * pitti AFK for a bit [07:42] hm, I'm getting sh: 1: Syntax error: Bad fd number [07:42] for a tar copy [08:09] jibel: did you happen to run into something like that? http://paste.ubuntu.com/7709955/ [08:09] jibel: that's the closest I got so far [08:10] jibel: i. e. with multi-line scripts it fails [08:10] $ bash -x /tmp/runcmd sh -ec 'exec 3>&1 >&2; whoami' [08:10] that works fine [08:10] jibel: so it's getting confused by line breaks somehow [08:14] indeed quoting is completely different: sh -ec $'exec 3>&1 >&2\nwhoami' for the 1rst case and sh -ec exec\ 3\>\&1\ \>\&2\;whoami for the second [08:14] I never noticed that before [08:15] jibel: I'm ssh'ing into LXC, not sure if that makes any difference [08:16] but I had assumed that pretty much any test would need to run scripts [08:16] $ ./run-from-checkout -B ~/ubuntu/tmp/testpkg// --- ssh -s ssh-setup/adb [08:16] pitti, it is not related to lxc, because if you execute it directly it's the same errpr [08:16] but this stilll works fine [08:16] sh -c "sh -ec $'exec 3>&1 >&2\nwhoami'" [08:16] sh: 1: Syntax error: Bad fd number [08:18] jibel: oh, the >3 bits are only done from build_source() [08:19] pitti, re wait_for_ssh, I'll add a retry argument to VirtSubproc.check_exec(), what do you think? [08:20] jibel: ah, I would just do that loop in virt-ssh's setup, and call VirtSubproc.execute_timeout until it succeeds [08:21] pitti, ok [09:24] pitti, autopkgtest in a nova instance: ./run-from-checkout --setup-commands="apt-get update" -d libpng --- ssh -s ssh-setup/nova -d -l ubuntu -- -f 1 -k j-lallement -i 138cdd41-e72d-4f98-b394-db2b66ba24af [09:24] \o/ [09:24] yay! [09:25] jibel: still wondering how you can evade that quoting issue; maybe it behaves differently if you have sudo in between? [09:25] jibel: but anyway, after wresting with lots of various shell trickeries, I resigned and changed adt-run to never give commands with newlines [09:33] jibel: what's that magic -i number? [09:34] * knome never knew "c" (etc) is a number [09:34] pitti, -f is the flavor (m1.tiny ...) -i the id of the image [09:35] -k the name of your key in the keypair you registered [09:35] jibel: ah, of course [09:35] pitti, I tried in canonistack, it probably work in hpcloud but didn't try [09:36] test_no_script_no_root (__main__.SshRunner) [09:36] no setup script, no root ... ok [09:36] test_password (__main__.SshRunner) [09:36] no setup script, no root, password auth ... skipped 'ssh password auth is not implemented' [09:36] \o/ [09:38] jibel: ok, I committed two fixes to master (one of them the \n → ; change, to avoid the %q madness), and rebased the adt-virt-ssh branch [09:38] jibel: does git pull just work for you, or does that complain? [09:39] pitti, it seees to be happy, just complained that I changed adt-virt-ssh too [09:39] seems [09:39] jibel: ah, so "git stash save", "git pull", "git stash pop" [09:40] pitti, yup, [09:41] pitti, i'm adding a cleanup and will send you the nova setup script and my changes for review [10:03] jibel: would you mind pulling again, and see how far this gets? ADT_TEST_LXC=adt-utopic tests/adt-run SshRunner [10:04] jibel: I have a suspicion it'll fail because your tests/home/.ssh/id_rsa is not 0600, but 0644 or so (then ssh complains); git doesn't seem to maintain permissions that way [10:04] * pitti makes it robust against that anyway [10:04] ah yes, even a simple checkout master / checkout adt-virt-ssh makes it fail [10:05] jibel: so hold on [10:07] jibel: ok, fixed; can you please give it a try? [10:28] pitti, ADT_TEST_LXC=adt-trusty-amd64 tests/adt-run [10:28] Ran 95 tests in 517.676s [10:28] OK (skipped=32) [10:29] jibel: splendid! You can run only the ssh ones with ADT_TEST_LXC=adt-trusty-amd64 tests/adt-run SshRunner [10:29] (amongst which sshrunner) [10:29] pitti, they all ran and passed [10:30] correction 1 skipped [10:30] jibel: right, expected; I wrote a test case for "password but no ssh key", and then realized that this isn't implemented yet [10:31] (but we should at some point, by faking an SSH_ASKPASS) [10:38] jibel: open and setup are really redundant, right? I'd consolidate this to use open only to correspond to the adt-virt protocol [10:38] pitti, agreed [10:41] jibel: WDYT? http://paste.ubuntu.com/7710515/ [10:41] jibel: that's a ssh-setup/SKELETON file [10:42] pitti, LGTM [10:43] jibel: pushed that and the setup/open unification [10:43] pitti, I'm nearly done with nova. I'll finish it after lunch [10:44] jibel: so I suppose you need to adjust nova now === roadmr is now known as roadmr_afk [10:44] pitti, right, that's why I'm nearly done essentially :) [10:48] jibel: ah, so for an external lxc setup script I'll also need the "state" string that open() can generate; you already did that, right? [10:48] ok, running + lunch, bbl [10:48] pitti, yes, I added an 'extraopts' key that is passed back to the script [10:49] pitti, the form is extraopts="key1=val1 key2=val2 [...]" [10:49] pitti, then there is a function to return the value for a key [10:50] jibel: ah, is that easier to handle than extraopts=-d /foo -i myid ? [10:50] or just a string which is passed back verbatim as --state [10:51] jibel: sure, works as well; that function needs to be in every setup script then, right? [11:33] pitti, right, your approach is more generic, I'll change that [12:50] ping ubuntu-qa: can somebody review this please? [12:50] https://code.launchpad.net/~elopio/ubuntu-calendar-app/fix1332173-swipe_to_create_new_event/+merge/224735 [12:51] la_juyis: I'm here for when you want to pair program. [12:51] elopio, great! I think I'll be ready in ~1hr === _salem is now known as salem_ [13:05] jibel: shockingly, writing tests for "with setup script" revealed another bug :) fixed/tests pushed [13:06] jibel: (I created that bug, so I'm just proving myself wrong) [13:06] pitti, it's impossible, the bug must be in the test ;P === fader_` is now known as fader [13:30] pitti, http://paste.ubuntu.com/7711161/ setup script for nova + extraopts + small fixes [13:31] pitti, tested on canonistack, it should work the same on hpcloud, maybe the detection of the IP will be a bit different depending on the output of nova show [13:49] jibel: landed click support in master now! [13:49] * pitti tests virt-ssh with click then [13:52] jibel: adt-virt-ssh branch rebased against master with click, so we can test the two together now [13:54] pitti, I filed bug 1335134 to not lose the diff for nova [13:54] bug 1335134 in autopkgtest (Ubuntu) "add nova setup script for adt-virt-ssh" [Undecided,New] https://launchpad.net/bugs/1335134 [13:54] * jibel updates master [13:54] jibel: I have it in a tab, but thanks [13:54] jibel: sorry, haven't looked yet, was busy with rebasing and fixing some conflicts [13:55] pitti, no problem, that's why I filed a report. [13:56] Yay autopkgtest 3.0 \o/ [13:56] hehe [13:56] One Runner to Rule Them All! [13:58] pitti, I'll teach the nova runner to create snapshot so it doesn't always have to create a new instance, and that'll open the revert capability [13:58] jibel: nice [13:58] jibel: also, I had the idea of speeding up virt-ssh by using ssh connection sharing; I'll file that as a bug too [13:59] bug 1335136 [13:59] bug 1335136 in autopkgtest (Ubuntu) "adt-virt-ssh: Use connection sharing for speedup" [Wishlist,Triaged] https://launchpad.net/bugs/1335136 [14:01] pitti, did you try click on the phone already? [14:02] jibel: not yet, currently writing a test for click + ssh [14:03] jibel: and BAM!, bug found; I hate test suites! :-) [14:04] yeah, passing --setup-commands through the ssh runner is again that quoting issue [14:05] jibel: ok, this is still broken in some ways, that's something for next week I'm afraid [14:06] jibel: I need to change the way --setup-commands works, to avoid running the commands through the auxverb :( [14:08] or we need a proper fix for quoting of commands containing \n [14:14] jibel: http://paste.ubuntu.com/7711353/ [14:14] jibel: !! [14:15] now, *drumroll*, putting it all together [14:15] pitti, !!!! [14:15] :) [14:16] jibel: http://paste.ubuntu.com/7711366/ [14:16] jibel: we somehow need to export the phone user's environment to that runner [14:16] jibel: i. e. in the setup script [14:17] so with "su" I get the env [14:18] hm, also with ssh [14:18] pitti, isn't it because we do a sudo su and lose the env at some point? [14:18] but presumably not throgh sudo [14:18] phone, brb [14:18] try with sudo -E [14:38] jibel: it's probably not on that side, we need su -l or so [14:39] root@ubuntu-phablet:~# su -c 'env|grep UPSTART' phablet [14:39] root@ubuntu-phablet:~# su -l -c 'env|grep UPSTART' phablet [14:39] UPSTART_SESSION=unix:abstract=/com/ubuntu/upstart-session/32011/1312 [15:03] pitti, ah it's the same -l that solved the cd . permission denied. it makes sense [15:03] jibel: it just breaks other stuff :/ [15:18] ubuntu-qa, can someone review these pep8 fixes. Should be really quick check; https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/new-pep8-fixes/+merge/224856, https://code.launchpad.net/~nskaggs/ubuntu-rssreader-app/new-pep8-fixes/+merge/224855, https://code.launchpad.net/~nskaggs/ubuntu-clock-app/new-pep8-fixes/+merge/224853, https://code.launchpad.net/~nskaggs/dropping-letters/new-pep8-fixes/+merge/224857 [15:18] balloons: me _o/ choose me!!! [15:18] elopio, :-) I think that's the rest of the core apps that needed it [15:18] balloons, i can do at least some [15:19] * elopio cedes the job to la_juyis [15:19] go and earn some nice karma. [15:20] elopio, :D [15:21] balloons: can you review this one? https://code.launchpad.net/~elopio/ubuntu-calendar-app/fix1332173-swipe_to_create_new_event/+merge/224735 [15:23] elopio, oO.. is this what I think it is? ;-) [15:25] balloons: probably not. I went a little crazier on this one and it got big. [15:27] * balloons sees an EventBubble class.. Leo went ham! [15:35] pitti, last but not least a man page http://paste.ubuntu.com/7711679/ [16:07] * tachyons_ is away: Away , ദൂരെ [16:22] elopio, so you don't interact with the the time and date spinners [16:22] I assume because of the AP date/time issues we encountered? [16:23] we should link that bug.. let me find it [16:26] balloons: I didn't do it in this branch because the original test wasn't doing it. [16:27] I haven't even tried yet. [16:27] elopio, yea, that code must have been completely gutted. I had code to do it, I clearly didn't leave it as a comment I guess. It used the new helper [16:29] balloons: what's next after this branch should be to add an event for the future. [16:29] I'm not sure if I will be able to do it next week though. [16:29] elopio, https://bugs.launchpad.net/autopilot/+bug/1328600 [16:29] Ubuntu bug 1328600 in Autopilot "test_new_event autopilot test fails on device (r315)" [High,Confirmed] [16:29] balloons: oh, right, that one. [16:30] we need the autopilot guys to fix it first. [16:30] elopio, I would simply note the bug and give a small comment about setting times [16:30] elopio, yes, but that way we don't forget and try and add the time selection [16:30] balloons: in progress... [16:33] balloons: pushed. [16:38] elopio, shouldn't class DayView inherit the Page class? [16:42] actually I suppose many pages might make sense to import from page.. I realize they don't use the methods atm... Also should clean up the imports, still using emulators as toolkit_emulators [16:51] balloons: I think that page class should be removed. [16:51] you shouldn't just drag a page up or down. [16:51] you should drag it to make something visible, and I think it's clearer if you call that something.swipe_into_view() [16:51] elopio, that's also an option [16:52] so, the Page object will be eventually without methods, and then it makes no sense to add it to the class hierarchy. [16:52] we do need a page helper. But I think it will have something like a reference to the previous page, and a go_back method that opens it. [16:53] I'm happy with cutting it.. but if it stays you should use it [16:53] balloons: oh, I didn't notice it's not longer in use. [16:54] so if you are happy with what I said above, I'll remove it. [16:54] elopio, yes when you mentioned the methods I was thinking why they existed. [16:55] elopio, it's used in test_yearview I see at least [16:57] balloons: humph, I can't find where that self.page is defined [16:59] balloons: I think that means test_yearview will fail in 4 days. [16:59] elopio, :-) [16:59] well we caught it in time [17:03] balloons: I'll report the bug. That can be done with swipe_into_view if the element is loaded, of with flickable.click_element if we have to scroll for it to be created. === roadmr_afk is now known as roadmr [17:08] https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1335241 [17:08] Ubuntu bug 1335241 in Ubuntu Calendar App "test_yearview will fail after june" [High,New] [17:10] hmm.. I set my month locally to a later date [17:15] still seems to be fine [17:16] ahh, broke it :-) [17:19] balloons: when you have time, remind me to talk about patching home and about reminders. [17:19] elopio, I haven't forgotten. [17:20] elopio, let's chat after lunch on it eh? [17:20] elopio, I think for the merge as-is, I would like to see Page removed. We can fix the scroll issue in another mp [17:21] I'll approve [17:21] top approved, thanks === chihchun is now known as chihchun_afk [17:46] thanks balloons === rsalveti_ is now known as rsalveti === la_juyis` is now known as la_juyis === tachyons_ is now known as tachyons === salem_ is now known as _salem