[07:04] * tsdgeos reports back from holiday week #1 [07:04] bitten by mosquitos all over [07:04] have to type slower because of swollen mosquito-bit finger [07:13] am i going to be killed if i mention we should move to Qt5.3.1 insteadd of Qt5.3.0? [07:53] mzanetti: Saviq: what's the status of https://code.launchpad.net/~aacid/unity8/swipe_down_close_no_remove_dash/+merge/221996 ? [07:56] tsdgeos: Saviq found some issues and put it back to needs review [07:56] tsdgeos: I have then done/fixed it on top of the QtComp branch [07:56] i see [08:09] mzanetti: can you comment in https://code.launchpad.net/~aacid/unity8/swipe_down_close_no_remove_dash/+merge/221996 saying it's done in the qtcomp branch? [08:09] so it's clearer it's "done-ish" [08:11] tsdgeos: ack [08:21] mako improved so much over the last months [08:21] exciting [08:43] tsdgeos, could you take a look at https://code.launchpad.net/~unity-team/unity8/caching-image-provider/+merge/224415 pls? it seems to be causing memory corruption and i have no idea why [08:46] mhr3: how does the memory corruption manifest? [08:46] i.e. what do i do to make it crash? [08:47] Saviq, also, async image providers suck, qt is using a single thread to request them, so basically all requests to custom image providers get serialized [08:47] tsdgeos, it's kinda random and i can make it happen only on armhf [08:47] tsdgeos, basically play with it on phone and it crashes after a while [08:47] tsdgeos, fwiw it's in 005 [08:48] ok [08:48] mhr3, requests, maybe, but the provider can return and fill the image later, no? [08:48] mhr3, if not, QTBUG [08:50] Saviq, nope, the sync part of it (the actual ->requestImage() calls) is serialized cause it's being done by just one thread [08:51] mhr3: not the cause of the problem for sure but i'd say if (uri.search(/^http(s)?:/) == 0) { should be if (uri && uri.search(/^http(s)?:/) == 0) { since we're passing down stuff we previously were not checking was undefined or anything [08:52] mhr3, well, yeah, but I was under the impression that you can return an empty image and fill it later, isn't that how asyncing custom providers work? [08:52] Saviq: nope [08:52] Saviq, not as far as i know, after you return the image, it will try to just upload it to the gpu, no? [08:52] async providers just promise they won't crash if running in a multithread env [08:53] mhr3, tsdgeos, :| [08:53] mhr3, OTOH, the provider is just a single object, right (as opposed to a factory)? [08:54] mhr3, so that kinda precludes multiple requests at the same time [08:54] Saviq, not really, the docs do explicitely say that the methods image provider implements need to be reentrant [08:54] mhm [08:55] mhr3, in any case, that calls for a QTBUG to find out what's the deal and what can be done about it... like 90% of our SDK uses a custom image provider (via the image://scaled/ provider for @blah) :| [08:57] well, the thread is per QQmlEngine, but i haven't seen there being multiple QmlEngine, when can that happen? [09:07] mhr3: i really can't find anything wrong in the code, but otoh i'm not really much into std::future (i should look at them more carefully) [09:08] tsdgeos, i think it actually has something to do with the future/promise [09:08] mhr3: might as well be that the glibc/arm implementation of it is not totally perfect [09:09] it's not like stuff like that hasn't happened before [09:09] dont even want to think about that [09:09] tsdgeos, were you able to rep the crash? [09:10] maybe it's just me in the end? :) [09:10] mhr3: still flashing the phone, just came back from a week of holidays today [09:11] tsdgeos, right, sorry for jumping on you like that :) [09:11] it's ok :) [09:12] guess i could try to reimplement it using simple mutex and condvar [09:23] may be one way to try to get it fixed [09:23] mhr3: if you give me soem time i'll try it on the phone and see if i can make it crash too [09:41] Saviq, I updated infographics apart moving infographics code to sdk, which I will start now [09:42] Cimi, ktx [09:53] tsdgeos, think i fixed it, will rebuild the silo [09:53] mhr3: cool [09:55] tsdgeos, oh, should add the js check.. how do i check if something is string? [09:55] cause ints won't have .search() :) [09:55] mhr3: there's the tyeof thing [09:57] - if (uri.search(/^http(s)?:/) == 0) { [09:57] + if (typeof uri == "string" && uri.search(/^http(s)?:/) == 0) { [09:57] ^^ k? === davmor2_ is now known as davmor2 [09:58] triple equal to be more JS === lool- is now known as lool [10:13] Saviq, btw anyone trying u8 on the device with valgrind? it's *very* unhappy about things [10:14] might have something to do with hybris, but still... at least having a suppressions file would be nice [10:23] mhr3, tsdgeos has experience [10:23] mhr3: i just ignore all that crap [10:23] :D [10:24] mhr3: agreed someone that knows about android should look at it and either fix it or provide a supressions file [10:24] tsdgeos, do you also get the please use --workaround-gcc-bug thing? [10:24] hmmm [10:24] don't remember i get that no [10:25] hm, when i tried it, it started to print hundreds of those, so after a while it just went - oh yea, too many error, i won't report any more [10:26] hmmm [10:26] mhr3: does adding --smc-check=all-non-file help? [10:26] haven't tried that [10:27] give it a go [10:27] i think i'm using it [10:28] yea, from reading about that, i guess it could help [10:29] don't feel like trying to launch it under valgrind again, too much pain and takes ages :P [10:33] :D [10:40] any chance we could get https://codereview.qt-project.org/#/c/84026/ landed in our Qt5.3? I really miss my scrollwheel in QtC [10:42] greyback: let's just update to 5.3.1 :D [10:42] tsdgeos: or that :) [10:45] i'm confused :/ [10:45] http://paste.ubuntu.com/7725836/ [10:45] how can root be null :/ [10:46] dat be f*cked up yo [10:47] tsdgeos: does it crash? [10:47] greyback: i can make it assert or crash or work depending on the elements of that list i comment out [10:48] tsdgeos: eeek [10:48] yep [10:52] Saviq, ok, so i'm ready to land 005, seems like it's no longer crashing which is good :) the question is are we ok about loosing http pipelining? [10:53] mhr3, QNetworkAccessManager doesn't do it? [10:53] Saviq, it does, but as i said earlier, requests from image provider will be serialized, so it will never ask for an image until the previous one finishes loading [10:55] mhr3, well, as it's cached... shouldn't it be better anyway? [10:55] it should... once they fix the servers [10:55] mhr3, most times we shouldn't even hit the servers, right? [10:55] based on cache control? [10:55] yea.. it's just they don't serve cache control yet :) [10:56] so it'll get worse before it gets better? ;) [10:56] kinda... it will still use the cache, but it will have to validate it first [10:56] ah so just the HTTP header? [10:57] yep [10:57] fwiw that's like 90% of the latency :P [10:57] trueth [10:57] but will still save quite some data [10:57] mhr3, what's the feel btw? [10:58] Saviq, hm, let me reflash current image to be able to tell :) [10:58] Saviq, or you can check 005 === gatox_ultra is now known as gatox === MacSlow is now known as MacSlow|lunch [11:18] dednick, hmm DashContent failure in move-indicator-qml now? [11:18] Saviq: hm. i'll take a look [11:42] Saviq: hi! On the last image we noticed a crash happening during unity8 tests, probably causing a test failure [11:42] Saviq: psivaa filled in a bug for it: [11:42] Saviq: https://bugs.launchpad.net/ubuntu-app-launch/+bug/1329141 <- [11:42] Ubuntu bug 1329141 in qtdeclarative-opensource-src (Ubuntu) "qmlscene crashed while running test_can_launch_multiple_applications" [Undecided,Incomplete] [11:43] Saviq: it might not be unity8 here at fault, but still I guess you would be able to judge the best [11:43] sil2100, if it's qmlscene crashing, then it's not unity8 at fault for sure ;) [11:44] sil2100, if you get some symbols, please let us know [11:47] Sure :) [11:49] Saviq, when you know what you're looking for, you can see that things take longer to load [11:50] mhr3, I'm starting to wonder... maybe we just need a caching proxy on the device :P [11:53] mhr3, what's the ETA on fixing the servers? [11:53] Saviq, i did have the same idea... but shelved in the crazy folder :P [11:53] not so crazy now! [11:54] Saviq, for click store it was on staging on friday, but had some issues [11:55] Saviq, we could still go with what you did - set the cache on the global QmlEngine's network access manager [11:56] then it will at least still do the pipelining [11:57] but then we won't be able to cache scaled images [11:57] mhr3, I'm leaning towards that, we were just missing the per-request setting to use the cache on no network? [11:57] that shouldn't even be necessary when the servers are fixed [11:58] well, I'd rather not rely on all servers being fixed ;) [11:58] mhr3, the scaling is most important for svgs, and we could put those through a different code path than the rest [12:05] Saviq, i am lost with the inline diffs [12:05] do you have a tip to see where you comment? [12:05] Cimi, click on "see inline diff" in the comment header [12:06] Cimi, and then scroll, unfortunately [12:06] Saviq, but sends me to your first comment [12:06] to find [12:06] not the new added [12:06] Cimi, right, if it's on the same revision, it's not great === alan_g is now known as alan_g|lunch [12:08] Holas [12:09] Saviq, I think it doesn't work great with the current implementation, can we stick to the old reviews until they fix the ui? [12:09] Cimi, no [12:09] Cimi, I will use it [12:09] I'm scrolling in this super long page trying to find your comments [12:09] it's not great, but it's still much better [12:09] and where you replied [12:10] Cimi, Ctrl+F [12:10] before was simply looking at the comment, easy [12:10] so I should ctrl f saviq? :) [12:10] Cimi, yeah, you know it was me that commented [12:11] Saviq, so basically what's wrong is the wrapper? [12:11] Cimi, its existence [12:11] I thought it was fine [12:11] abstract programming [12:12] Cimi, just for the purpose of having 2 props, there's no point in adding another object / hierarchy level [12:12] Saviq, that's because now we have two props [12:12] we might change implementation [12:12] anyway ok [12:13] Cimi, when we change the implementation so that it requires a wrapper, let's! [12:13] Saviq, so I should remove the first preload in tests/qmltests/CMakeLists.txt ? [12:14] Cimi, LD_ only matters for linking, for dynamically loaded libraries [12:14] I thought I needed it for test/mocks/Infographics [12:14] to avoid using thr system one [12:14] Cimi, ld doesn't know anything about QML, qmldir or whatnot [12:14] Cimi, that's what you have QML2_IMPORT_PATH for [12:14] ok [12:17] Saviq, although makes testing the infoghraphics harder [12:17] Cimi, what does? [12:17] Saviq, because you'd have to use the whole greeter then [12:17] Cimi, when? [12:17] Saviq, merging Greeter/Infographics.qml into Greeter/GreeterContent [12:18] Cimi, I'm not saying you should do that [12:18] Saviq, I'd have to move the tests into tstSingleGreeter [12:18] Cimi, I'm saying the Item in Infographics.qml is not needed [12:18] sh using CrossFadeImage directly? [12:18] yes [12:18] that was abvious [12:18] my bad === MacSlow|lunch is now known as MacSlow [12:25] mhr3, so what do we do, what do we do? it's a rock and a hard place :| [12:26] Saviq, i want proper async image providers :/ [12:27] mhr3, I *know*, and a way to override the default one... [12:28] Saviq, if we're not going to do caching of scaled images, i think we should just override the network access manager [12:28] Saviq, although you didn't like it's feel either when you tried it right? [12:28] its* [12:28] mhr3, that was non-authoritative... [12:28] mhr3, I never tried on device [12:29] mhr3, and spent like 2 minutes on this [12:32] Saviq, hm, let's revisit it, i'll build it in 005 and see if it's better [12:32] mhr3, yup, thanks [12:33] Saviq, can you change owner of https://code.launchpad.net/~saviq/unity8/cache-network-data to unity-team? === alan_g|lunch is now known as alan_g [13:11] tsdgeos: welcome back! [13:12] kgunn: hi [13:12] dednick: do you just need a volunteer for review ? [13:12] https://code.launchpad.net/~nick-dedekind/unity8/indicator.call-hint/+merge/218627 [13:13] kgunn: hm. nearly. i'm busy fixing the tests. [13:13] i'll put it back in wip [13:14] dednick: its fine... [13:14] pretty large code diff, i never realized it was that meaty [13:49] Saviq: if I want to test the logout Dialog stuff. I'll need to trigger a fake dbus event. Does that mean I need to go writing some code in tests/mocks/Unity/Session? Is tests/mocks for that? [13:51] paulliu, yeah, you want a mock object that doesn't actually talk DBus [13:51] paulliu, but you can control from the test [13:51] Saviq: ok. got it. [13:51] Saviq, branch updated [13:52] Cimi, k === dandrader is now known as dandrader|afk === alan_g is now known as alan_g|tea === alan_g|tea is now known as alan_g === dandrader|afk is now known as dandrader [14:55] dednick, could you go through https://code.launchpad.net/~unity-team/unity8/suru-switch/+merge/207991 please [14:55] dednick, stuff this depends on is built in silo 004 [14:57] dednick, ah crap, need to put the image thing in settings components, settings UI is broken with it, too :| [14:57] Saviq: image thing? [14:58] dednick, I had to re-do SDK's Icon [14:58] dednick, to maintain aspect ratio of icons [14:58] dednick, bug #1284235 [14:58] bug 1284235 in Ubuntu UI Toolkit "Icon has to be sized explicitly" [Undecided,Incomplete] https://launchpad.net/bugs/1284235 [14:59] dandrader: http://paste.ubuntu.com/7726801/ looks scary [15:03] Saviq: property string iconPath: "/usr/share/icons/suru/status/scalable/%1.svg" - is that your fix for it picking up the lower prioirty icons? [15:03] dednick, not really, I need to load the images directly through Image [15:03] mterry, we have a crash on the wizard with the wifi [15:03] dednick, themed icons can only be square [15:04] dednick, side-effect is indeed that the priority problem is gone [15:04] dednick, it's a nasty hack, but we won't fix it properly in time [15:04] dednick, and we need to land this shit finally [15:05] Saviq: uhuh :) [15:05] dednick, another solution welcome [15:05] mterry, https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1334203 [15:05] Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,Incomplete] [15:05] mterry, I had a look, and I will have a look now [15:06] mterry, if you have ideas... throw [15:06] Saviq: write a c++ image component? [15:06] mterry, from what I have seen, it's the property http://paste.ubuntu.com/7710506/ [15:06] Cimi, I haven't looked into that yet. Not sure off the top of my head [15:07] dednick, that doesn't solve the problem that themed icons can only be square by definition of the icon theme [15:07] dednick, so would be a workaround just as the one I'm proposing [15:07] Cimi, ah maybe destroying that property is buggy [15:07] dednick, the index.theme files only deal with one-dimensional "size" of the icon, resulting in the assumption that the icons are square [15:08] dednick, which means you'd need to load the image file to find the aspect ratio out, at which point the whole icon theme system becomes kinda useless [15:08] Cimi, maybe also related to bug 1335298 [15:08] bug 1335298 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes on stop" [Undecided,New] https://launchpad.net/bugs/1335298 [15:08] Saviq: hm. I'm sure the bluetooth icon was rectangluar at some point. [15:09] dednick, sure, that's why unity7 has its own loading implementation, too ;) [15:09] Saviq: although that may have been due to some aspect [15:09] dednick, battery is rectangular [15:09] mterry, but not bug on our side? [15:09] mterry, do you know what can we do to workaround this property? [15:10] Cimi, I don't know if it's a bug on our side or not [15:10] mterry, I don't think it is [15:10] mterry, commenting out that code makes the wizard stop crashing [15:11] Cimi, does other code that uses UnityMenuAction have this problem, is what I'm wondering? [15:11] Cimi, i.e. is it a problem with UnityMenuAction, or how we use it [15:12] dednick, about the crash with UnityMenuAction [15:12] http://paste.ubuntu.com/7710506/ [15:12] dednick, this makes the wizard crash on some occasions [15:12] dednick, do we have similar crashes somewhere else on the platform? [15:13] dednick, are we using it wrong in the wizard? [15:13] Cimi: can you send a stacktrace? [15:13] not sure hot to get it [15:13] mterry, to get stacktrace we attach gdb right? [15:13] Cimi, yeah [15:13] which dbg symbols we need? [15:14] Cimi: apport-cli /var/crash/XXX.crash [15:14] mterry, in order to reproduce bug I need to have wifi off [15:14] so might try to manually get dbg [15:14] Cimi, you probably want qtbase5-dbg at least [15:15] Cimi, not sure which package has UnityMenuAction [15:15] mterry, qmenumodel [15:16] but I don't see dbg for it [15:16] libqmenumodel [15:16] dednick, and debug symbols? === Malsasa_ is now known as Malsasa [15:19] Cimi: libqmenumodel0-dbgsym [15:19] it's not on the phone [15:19] what shall I enable? [15:20] who knows guys? [15:20] Cimi: https://wiki.ubuntu.com/DebuggingProgramCrash [15:20] on phone presumably [15:21] Saviq: you need me to check that branch out now, or you doing something in usc for it? [15:22] dednick, yeah, I'll have another usc branch for this in a few mins hopefully [15:23] dednick, mterry http://paste.ubuntu.com/7726901/ [15:23] so yeah I need those symbols [15:27] Cimi: that trace was fine. === pete-woods is now known as pete-woods-eodlu [15:31] Cimi: where is the code? [15:34] dednick, http://bazaar.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk/view/head:/wizard/qml/Pages/20-wifi.qml [15:34] line 121 I think [15:35] kgunn: Saviq: some managementarial decision needed at https://bugs.launchpad.net/unity8/+bug/1332598 [15:35] Ubuntu bug 1332598 in Unity 8 "make testShell crashes" [Critical,In progress] [15:36] upstream guys that can decide on that bug seem to be away for a while [15:37] dednick, https://code.launchpad.net/~unity-team/ubuntu-settings-components/status-icon/+merge/225034 [15:37] dandrader: can you confirm that your crash is also gone if you use the patch from https://codereview.qt-project.org/#/c/88717/ ? [15:38] hm. network indicator doesnt seem to work on desktop anymore... [15:38] tedg: ^ ? [15:38] tsdgeos, will try it now [15:43] tsdgeos, yes, it does fix it! [15:44] Saviq: so how do we proceed in here? ↑ [15:44] Cimi: hm. doesnt seem to crash on desktop. [15:46] Cimi: does it always happen under certain cirumstances? how to reproduce? [15:49] mzanetti, hey, what's the situation with "dash as an app"? [15:50] ie, why did we stop working on it? [15:50] dandrader: we decided to land that separately, no? [15:50] dandrader: we didn't really stop working on it [15:50] mzanetti, I don't remember. that's why I'm asking :) [15:50] tsdgeos: so iiuc, upstream says "your patch is our best guess" [15:50] "use it, until we fix it" [15:50] dandrader: that's one step towards that: https://code.launchpad.net/~mzanetti/unity8/new-header/+merge/224585 [15:50] kgunn: upstream says "the guys that knows how this works are on holiday, your patch doesn't look terribly wrong to the guys left" [15:51] dandrader: once this has landed there shouldn't be any links between shell and dash any more in the code. [15:51] dandrader: I already have a branch here that creates an application binary for it [15:51] Saviq: has that usc branch gone into the silo? [15:51] tsdgeos: based on your experience & dandrader, we should go for a distro patch & stick it in ci-train...we can always ask for more extensive testing [15:51] kgunn: +1 [15:52] dandrader: one thing missing is we need ApplicationManager pick up applications started by upstart (as opposed to ubuntu-app-launch) so the dash would appear in the running apps list [15:52] e.g. get a qa resource at least, and maybe pull in some app folk [15:52] Saviq: ubuntu-settings-components branch that is [15:52] does anyone know if Mirv is on holiday? [15:52] dandrader: I decided not to make Gerry do that before we have QtComp in, or at least in the silo [15:52] tsdgeos: he was... [15:52] he always does the ci-train-ing of Qt stuff for me [15:52] mmm he's Finnish....might be long vacation [15:53] dednick_, not yet, lemme add [15:53] kgunn: tsdgeos: yeah, I think its another week [15:53] Cimi: not sure if you got my message. How do you reproduce the crash? doesnt seem to occur on desktop [15:53] mzanetti: did you get a Qt-patch in ci-train ? [15:53] ...i know the process is a little diff [15:53] into the train yes, not sure if it made it into the image yet [15:54] mzanetti, because I think "dash as an app" is an important piece in the "shell rotation" story [15:54] dandrader: I agree that might make things a lot easier [15:54] mzanetti: did you use a canonical branch ? or just local mod and give src ball to core dev [15:54] assuming you did this w/o Mirv [15:54] dandrader: well. afaik we were also not enabling rotation for the first batch of QtComp goodness [15:54] mzanetti, on the phone. Dash stays in portrait but the indicartors panel, launcher etc do rotate according to app preferences [15:55] kgunn: I used the kubuntu-packagers branch and proposed my change towards that [15:55] kgunn: after I figured we got the packages from that one lately [15:55] mzanetti, and we hopefully also mitigate (or even eliminate) that horrible ~2 secs gui choke when resizing unity8 due to a rotation [15:55] dandrader: huh? we're going to rotate launcher and panel but not the rest? [15:56] * mzanetti wonders how we even do that [15:56] mzanetti, with dash as an app? [15:56] mzanetti, well, dash might choke, shell won't ;) [15:56] ah... yeah, once its an app, yes [15:57] I thought dandrader was doing that with current codebase [15:57] dednick_, is building [15:58] dandrader: so yeah, after QtComp is in the silo and requires less attention we're going to do the appman changes and finish my branch with the separate app for the dash [15:58] dandrader: then you can finalize the rotation along with that [15:59] dednick_, on the phone [16:00] dednick_, https://bugs.launchpad.net/qmenumodel/+bug/1334203 [16:00] Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,New] [16:00] dednick_, basically on the phone, you have to do [16:01] rm /etc/NetworkManager/system-connections/% [16:01] rm /etc/NetworkManager/system-connections/* [16:01] then [16:01] rm /home/phablet/.config/ubuntu-system-settings/wizard-has-run [16:01] reboot [16:02] at the wizard, wait till it loads wifi then you tap back [16:02] happens 100% here [16:03] tsdgeos: are you familiar with that part of the process ? (see zanetti's post wrt kubuntu-packagers) [16:04] tsdgeos, kgunn: fyi, this is the branch: https://code.launchpad.net/~mzanetti/kubuntu-packaging/qtdeclarative-opensource-src/+merge/224517 [16:06] yep...i see it now, tsdgeos, if you can upload in the same fashion & get me the mp, i can get you on the ci-train [16:06] Cimi: need to connect to a wifi hotspot? [16:06] kgunn: tomorrow :) [16:07] tsdgeos: no worries...you can hit up Saviq you're morning, he can get you on the train [16:07] cool :) [16:07] * tsdgeos leaves for the day [16:08] * kgunn feels qt code control less out of control than he thot... [16:08] still seems funky [16:09] dednick_, no [16:10] Cimi: didnt work for me. [16:10] dednick_, clear as I said [16:10] Cimi: i'm flashing device. [16:10] dednick_, do not connect to any wifi [16:10] Cimi: i didnt [16:10] dednick_, otherwise bootstrap [16:10] Cimi: heh. good luck getting me to do that ;) [16:10] dednick_, https://bugs.launchpad.net/qmenumodel/+bug/1334203 [16:10] Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,New] === om26er is now known as om26er|away === gatox is now known as gatox_lunch [16:28] dednick_, luck? [16:29] Cimi: :( nope [16:29] dednick_, do you want me to test code? [16:35] dednick, do you want me to test code? [16:35] Cimi: give me a minute. [16:35] ok === dandrader is now known as dandrader|lunch === om26er|away is now known as om26er === alan_g is now known as alan_g|EOD [17:12] Cimi: reproduced. === gatox_lunch is now known as gatox [17:32] Saviq, here? [17:34] Saviq, when you will be - https://code.launchpad.net/~unity-team/unity8/cache-network-data/+merge/224995 seems to work fine and ready for landing in 005 [17:45] Cimi: https://code.launchpad.net/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203 === dandrader|lunch is now known as dandrader [19:42] mhr3, kk === dandrader is now known as dandrader|afk [20:31] seb128, could you please resubmit https://code.launchpad.net/~seb128/ubuntu-system-settings/use-theme-icons/+merge/214950 using lp:~unity-team/ubuntu-system-settings/use-theme-icons instead? === Daviey_ is now known as Daviey === dandrader|afk is now known as dandrader === salem_ is now known as _salem