=== TheMuso` is now known as TheMuso | ||
=== alexabreu is now known as alex-abreu|off | ||
=== josharenson1 is now known as josharenson | ||
mzanetti | moin moin | 07:14 |
---|---|---|
Saviq | hi ho | 07:14 |
Cimi | mzanetti, we have a fix for the wizard https://bugs.launchpad.net/qmenumodel/+bug/1334203 | 07:37 |
ubot5 | Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,New] | 07:37 |
Cimi | "we" as in nick has :D | 07:37 |
mzanetti | yep, I've seen that yesterday | 07:38 |
sil2100 | Saviq: hi! When can we expect silo 004 to land finally? | 08:11 |
Saviq | sil2100, today | 08:12 |
sil2100 | \o/ | 08:12 |
mhr3 | Saviq, me first, me first! | 08:14 |
sil2100 | :| | 08:14 |
Saviq | mhr3, got a reviewer yet? | 08:14 |
mhr3 | Saviq, sure, you! :) | 08:15 |
Saviq | mhr3, in that case, me first :P | 08:15 |
mhr3 | touche | 08:15 |
seb128 | Saviq, hey, sorry I was off yesterday, do you still want me to resubmit some u-s-s changes? | 08:24 |
Saviq | seb128, yes please | 08:25 |
seb128 | Saviq, k, having a look | 08:25 |
tsdgeos | Saviq: how do we get https://code.launchpad.net/~aacid/kubuntu-packaging/qtdeclarative-opensource-src/+merge/225119 into a silo? | 08:26 |
=== vrruiz_ is now known as rvr | ||
Saviq | tsdgeos, I need to build a source package and we need to upload it manually | 08:39 |
Saviq | sil2100, right? to push a source package through silo, someone with the rights needs to dput it to the PPA? | 08:40 |
sil2100 | Saviq: yes, just add the source package name to the right column and then provide us with a source package which we can dput for you :) | 08:41 |
Saviq | sil2100, yup, will do | 08:41 |
seb128 | Saviq, so, what do you want me to do with https://code.launchpad.net/~seb128/ubuntu-system-settings/use-theme-icons/+merge/214950? I'm not sure to understand | 08:45 |
dednick | Saviq: can we land https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/menu.plugin/+merge/224616 today? | 08:48 |
seb128 | Saviq, do you just want me to push to a shared location because you have changes to do on top or...? | 08:48 |
Saviq | seb128, just resubmit your MP with my branch | 08:49 |
Saviq | seb128, I don't have the permissions | 08:49 |
Saviq | seb128, https://code.launchpad.net/~seb128/ubuntu-system-settings/use-theme-icons/+merge/214950/+resubmit | 08:49 |
Saviq | seb128, yes, because I have changes on top | 08:50 |
seb128 | Saviq, I don't understand why you simply don't propose your for merging? | 08:50 |
seb128 | like let's call mine superseeded | 08:50 |
Saviq | seb128, that's what resubmitting does ;) | 08:50 |
Saviq | seb128, but keeps a connection between the superseded and new one | 08:51 |
seb128 | oh | 08:51 |
seb128 | Saviq, https://code.launchpad.net/~unity-team/ubuntu-system-settings/use-theme-icons/+merge/225122 like that? | 08:51 |
Saviq | seb128, yup! thanks | 08:52 |
seb128 | yw | 08:52 |
seb128 | Saviq, is that going to land today? I've a setting landing I want to do at some point, just trying to figure if I should wait for you to be done ;-) | 08:53 |
Saviq | seb128, yeah, I want to land today | 09:01 |
seb128 | great | 09:02 |
tsdgeos | oh noes | 09:02 |
tsdgeos | i'm now getting http://paste.ubuntu.com/7730416/ on testshell still | 09:02 |
tsdgeos | on shutdown | 09:02 |
mzanetti | anyone knows how volume up/down keypresses end up in the apps right now? | 09:09 |
Saviq | mzanetti, they don't end up in the apps | 09:19 |
Saviq | mzanetti, or well, if they do, that's not expected ;) | 09:19 |
Saviq | mzanetti, or well, | 09:20 |
mzanetti | Saviq: I think that is expected (although lacking some policy thing still) | 09:20 |
Saviq | mzanetti, shell just gets all the events | 09:20 |
Saviq | mzanetti, I mean unexpected as in no one *coded* it | 09:20 |
Saviq | mzanetti, it's just a side effect of lack of implementation | 09:20 |
mzanetti | Saviq: nope... I know it broke some time ago and someone fixed it again... | 09:20 |
Saviq | mzanetti, shell is an input filter, but we have no way to filter key presses | 09:20 |
mzanetti | I think it was tvoss | 09:20 |
Saviq | mzanetti, we only filter touch events with the InputAreasa | 09:21 |
Saviq | -a | 09:21 |
Saviq | mzanetti, keys just go to the focused app *and* shell | 09:21 |
Saviq | mzanetti, and yeah, the real solution would be to deliver them to shell, then to app, then back to shell | 09:22 |
mzanetti | why doesn't it work in QtComp branches any more then? | 09:22 |
Saviq | mzanetti, because you replaced the input system | 09:22 |
mzanetti | ok... I guess I'll have a chat with Daniel when he shows up | 09:22 |
Saviq | mzanetti, check out src/main.cpp:147 | 09:23 |
seb128 | dednick, hey, who does qmenumodel code reviews for you usually? | 09:37 |
seb128 | just asking because of https://code.launchpad.net/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203/+merge/225063 | 09:37 |
seb128 | larsu, ^? | 09:37 |
larsu | seb128: sometimes :) not so much recently though. I'll have a look but won't top-approve yet | 09:39 |
seb128 | larsu, thanks | 09:39 |
dednick | seb128: Cimi should probably give it a test before top approving to ensure it fixes th issue he was having. | 09:58 |
seb128 | dednick, k | 09:58 |
dednick | Cimi: ^ fix for your wizard problem | 09:59 |
tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity8/no_model_reset_from_destructor/+merge/225127 | 09:59 |
mzanetti | tsdgeos: ok... I guess I'm fine with that change (need to branch and read surrounding stuff still) | 10:02 |
mzanetti | tsdgeos: but seems this is getting "fixed" upstream too | 10:02 |
tsdgeos | yep | 10:02 |
tsdgeos | for 5.4 | 10:02 |
tsdgeos | it's been fixed already | 10:02 |
tsdgeos | but this is easier than fighting the powers to get yet another qt declarative patch in :D | 10:03 |
mzanetti | tsdgeos: agreed | 10:03 |
Cimi | dednick, testing now | 10:05 |
Cimi | dednick, seb128 fixed for me, thx | 10:14 |
dednick | Cimi: ta. can you top approve? | 10:15 |
Cimi | dednick, done | 10:15 |
Cimi | dednick, you might want to change the copyright from the test file | 10:15 |
dednick | Cimi: ta | 10:18 |
karni | facundobatista: mhr3: would it be true the departments are sorted alphabetically, regardless of the order they're feed to the framework? | 10:21 |
karni | is there a way to order them the way a developer wants isntead? | 10:21 |
mhr3 | karni, hm, don't recall such limitation, if that's the case, the ui is doing it :) | 10:23 |
mhr3 | tsdgeos, ^? | 10:24 |
karni | That is possible. | 10:24 |
tsdgeos | hmmm | 10:24 |
tsdgeos | no | 10:24 |
karni | I'd like to have the control over the order of departments. It is natural that some (at the top) could be more important than the others. | 10:24 |
tsdgeos | don't recall adding any code for that | 10:24 |
karni | haa, I think I know the problem | 10:24 |
karni | this is server scope. Python: feeds.keys() is unordered | 10:25 |
karni | feeds is a dict, my bad. thanks mhr3, tsdgeos | 10:25 |
tsdgeos | :) | 10:25 |
* karni hides ashamed he once again had to bounce of this channel heh | 10:25 | |
mhr3 | we're the debugging ducks :) | 10:26 |
tsdgeos | karni: a fixed problem is nothing to be ashamed of :) | 10:27 |
karni | :) | 10:27 |
apw | it looks like a libgtop2 ABI bump has just broken bamfdaemon, and thereby unity7 | 10:28 |
Saviq | dednick, can you please review https://code.launchpad.net/~unity-team/ubuntu-settings-components/status-icon/+merge/225034 | 10:48 |
Saviq | dednick, I'll do https://code.launchpad.net/~unity-team/ubuntu-settings-components/suru-theme/+merge/220739 now | 10:48 |
Saviq | dednick, reviewed ↑, small things | 10:54 |
mzanetti | paulliu: hi, mind adding the checklist and top-approving now that we have a design approval: https://code.launchpad.net/~mzanetti/unity8/launcher-drop-spacing/+merge/224094 | 11:07 |
tsdgeos | Saviq: https://code.launchpad.net/~aacid/kubuntu-packaging/qtbase-opensource-src/+merge/225134 is the last branch we need to make testShell pass | 11:07 |
Saviq | tsdgeos, oh ok, let's land this together | 11:09 |
tsdgeos | +1 | 11:12 |
facundobatista | Holas | 11:15 |
tsdgeos | hi there | 11:16 |
facundobatista | karni, the server returns the the departments alphabetically ordered (at least that is the intention... if you find an example where they're not, it's a bug) | 11:16 |
karni | facundobatista: the problem was that I actually used Python set .keys() to iterate through. the server returns them ordered the way the scope feeds them, not alphabletically :) | 11:17 |
karni | facundobatista: unless you're talking specifically about amzn - yes, it's alphabetical there, I believe | 11:18 |
facundobatista | karni, do sorted() | 11:18 |
karni | facundobatista: nah, I actually wanted a non-alphabletical sort :) thanks!~ | 11:18 |
facundobatista | karni, btw, if you iterate over a dict, you'll get its keys, so sorted(the_dict) will work | 11:18 |
karni | facundobatista: right, thanks for the tip :) | 11:18 |
facundobatista | karni, ah, you have departments more important than others? | 11:19 |
karni | facundobatista: correct :) | 11:19 |
karni | facundobatista: I now just feed them the order I want | 11:19 |
facundobatista | yeap | 11:19 |
karni | facundobatista: why does amazon scope use single space for query when surfacing? | 11:36 |
facundobatista | karni, IIRC, you need to send that, otherwise it won't answer correctly | 11:39 |
facundobatista | (that is: a generic search, useful for surfacing) | 11:40 |
karni | facundobatista: I see Keywords=' ' -- so this is Amazon specific, right? | 11:40 |
=== MacSlow is now known as MacSlow|lunch | ||
facundobatista | karni, yes | 11:41 |
karni | ack | 11:41 |
dednick | Saviq: any idea why overriding sets in settings app doesnt work? | 11:48 |
Saviq | dednick, no, it's completely bollocks | 11:48 |
Saviq | dednick, but I don't want to block on this | 11:49 |
Saviq | dednick, as you can see it worked in the test (and actually works in unity8) | 11:49 |
dednick | Saviq: hm. and should it be a string rather that an array? | 11:50 |
dednick | ie. why are we testing multiple sets? | 11:50 |
Saviq | dednick, yes we are | 11:50 |
Saviq | dednick, in settings, for example, some of the icons come from the apps set, some from the status set | 11:50 |
dednick | i c. and we don't know which one beforehand? or is it just because of this FIXME? | 11:51 |
=== karni is now known as Guest11873 | ||
Saviq | dednick, yeah, we don't | 11:54 |
Saviq | dednick, we just get the name | 11:54 |
Saviq | dednick, the FIXME is just about the default being [ "status" ] instead of what it is now | 11:54 |
dednick | Saviq: ok | 11:54 |
=== Guest11873 is now known as karni | ||
=== alan_g is now known as alan_g|lunch | ||
dednick | Saviq: done. just some small bits | 12:07 |
Saviq | dednick, fixed | 12:10 |
Saviq | dednick, can you do https://code.launchpad.net/~unity-team/unity8/suru-switch/+merge/207991 too, or should I find another victim? | 12:12 |
dednick | Saviq: can do. just busy with usc review | 12:13 |
Saviq | dednick, k thanks | 12:13 |
dednick | Saviq: fixed https://code.launchpad.net/~unity-team/ubuntu-settings-components/suru-theme/+merge/220739 | 12:16 |
dednick | Saviq: is the theme changing on desktop as well? | 12:16 |
Saviq | dednick, yes | 12:16 |
dednick | ok | 12:17 |
Saviq | dednick, I mean under unity8 desktop | 12:17 |
Saviq | on that note | 12:17 |
Saviq | bregma, seb128, could you please test out silo 004 under unity8 desktop session? | 12:17 |
dednick | Saviq: hm. you removed the UBUNTU_ICON_THEME from autopilot cmake? Is that sorted by the code now? | 12:18 |
Saviq | dednick, we don't have any say in that any more | 12:18 |
Saviq | dednick, UITK hardcodes the theme | 12:18 |
dednick | ok. thought it might | 12:18 |
Saviq | since https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1284218 | 12:19 |
ubot5 | Ubuntu bug 1284218 in Ubuntu UI Toolkit "Use mobile icon theme in UITK apps" [High,Fix released] | 12:19 |
dednick | so much for theming... | 12:19 |
Saviq | dednick, you don't need layouts in build-deps do you? | 12:19 |
dednick | Saviq: for tests | 12:19 |
Saviq | dednick, are there tests for StandardMenu? | 12:19 |
Saviq | or is something wrapping it? | 12:20 |
seb128 | Saviq, I don't have my test machine with me atm ... bregma, can you do it? | 12:20 |
dednick | uhhh. maybe not. | 12:20 |
dednick | but there will be :) | 12:20 |
Saviq | dednick, ok ;) | 12:20 |
Saviq | ACK | 12:20 |
bregma | Saviq, I'm doing it -- just a sanity test, right? we shouldn't see anything new or unusual? | 12:21 |
Saviq | bregma, yes, it should just look better ;) | 12:22 |
dednick | Saviq: no gu rounding? | 12:22 |
Saviq | dednick, see commit comment | 12:22 |
Saviq | dednick, now that icons are non-square | 12:22 |
Saviq | dednick, we ended up with huge gaps between icons | 12:22 |
bregma | Saviq, change is bad, I want my old Unity 8 back, I'm off to complain on the internets | 12:22 |
Saviq | ;) | 12:23 |
Saviq | dednick, because e.g. they *just* passed gu boundary, or were just under | 12:23 |
Saviq | dednick, that ended up throwing them all over the place, it looked really bad | 12:23 |
dednick | Saviq: design know about that? there is a specific requirement about that. | 12:25 |
=== MacSlow|lunch is now known as MacSlow | ||
Saviq | dednick, there *was* | 12:25 |
Saviq | dednick, it was for the old icons | 12:25 |
Saviq | dednick, let's go with that now and I'll let them know | 12:25 |
Saviq | dednick, and see if they care any more | 12:26 |
dednick | Saviq: ok. :) | 12:26 |
=== _salem is now known as salem_ | ||
karni | Would it be possible to have surfacing in a scope different than the root of the departments tree? (imagine I have quite heavy "All" department and, while I want it to be available to the user, I would like to start with a subdepartment instead for initial surfacing) | 12:35 |
karni | One of the ways would be to actually have the "All" department as one of the subcategories, but the order wouldn't look right (in this case, something I currently have as a subdepartment could take place of initial surfacing) | 12:36 |
Saviq | karni, I can't think why not | 12:37 |
Saviq | karni, you just need to make sure that the department you send with surfacing is a child | 12:37 |
Saviq | karni, and has parent info | 12:37 |
karni | Saviq: right. I'll look closer at the amazon scope. thanks | 12:38 |
karni | Saviq: what exactly you mean by "has parent info" ? | 12:38 |
Saviq | karni, it needs the name and id of the parent scope | 12:39 |
Saviq | s/scope/department/ | 12:39 |
Saviq | karni, hmm not sure your side of the API looks the same as mine ;) | 12:40 |
Saviq | karni, you'll have to check with pstolowski / mhr3 | 12:40 |
dednick | Saviq: hm. slider test failed on jenkins... | 12:40 |
karni | Saviq: yeah, looking at the doc now, and can't figure it out. I'll try digging, thanks | 12:40 |
Saviq | dednick, lemme see | 12:40 |
dednick | Saviq: https://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/3/? | 12:41 |
Saviq | dednick, yeah, fails locally, too | 12:41 |
Saviq | dednick, looks like the tap misses the button TBH | 12:42 |
dednick | Saviq: yeah, probably due to a failed icon load | 12:42 |
dednick | Saviq: oh. min/max button tests. probably isn't one if there isn't an icon :) | 12:43 |
Saviq | dednick, well, they're there... | 12:44 |
dednick | Saviq: possibly still loading when the test is run. changing shape maybe | 12:44 |
Saviq | dednick, heh, actually slightly different issue ;) | 12:47 |
Saviq | dednick, fixed | 12:47 |
dednick | Saviq: needs putting into https://code.launchpad.net/~unity-team/ubuntu-settings-components/suru-theme/+merge/220739 | 12:48 |
Saviq | dednick, ah, right | 12:48 |
Saviq | wrong branch | 12:48 |
Saviq | dednick, done | 12:50 |
dednick | Saviq: approved | 12:50 |
Saviq | dednick, tx | 12:51 |
Saviq | dednick, re-ack please, had to merge | 12:52 |
dednick | Saviq: done | 12:54 |
Saviq | o/ | 12:54 |
Saviq | tsdgeos, please merge your qtbase and qtdeclarative branches, there was stuff in distro that was not on the branches, so you need to bump changelog more | 12:55 |
dednick | Saviq: is there a new icon theme not released yet? I'm missing a alarm icon | 12:56 |
dednick | https://code.launchpad.net/~tiheum/ubuntu-themes/suru-icons/+merge/217767 ? | 12:57 |
Saviq | dednick, it's in silo 5 | 12:57 |
Saviq | dednick, that branch, that is | 12:57 |
Saviq | dednick, looks like you're right, we're missing it in the theme | 12:57 |
dednick | Saviq: unity8 is in the silo | 12:58 |
dednick | 5 | 12:58 |
Saviq | dednick, meant silo 4 sorry | 12:58 |
Saviq | dednick, can you see its name in ~/.cache/upstart/unity8.log? | 12:58 |
dednick | Saviq: file:///usr/share/icons/suru/status/scalable/alarm.svg | 12:58 |
dednick | Saviq: getting quite a few errors. | 12:59 |
dednick | althought they're probably just from first icons failing | 12:59 |
Saviq | yeah | 12:59 |
Saviq | dednick, hmm can you see what names are being tried for the alarms icon? (somehow I don't get it here at all) | 13:04 |
dednick | Saviq: sure | 13:07 |
tsdgeos | Saviq: hmm, against which branch then? | 13:07 |
Saviq | dednick, in theory you should get the qwarn | 13:07 |
Saviq | tsdgeos, the branch is updated already | 13:07 |
tsdgeos | ah, so only remerge | 13:07 |
Saviq | tsdgeos, yup | 13:07 |
* Saviq needs food | 13:08 | |
tsdgeos | Saviq: i don't see any diff | 13:08 |
tsdgeos | http://paste.ubuntu.com/7731339/ | 13:09 |
Saviq | tsdgeos, http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src/revision/182 http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtdeclarative-opensource-src/revision/159 | 13:09 |
Saviq | tsdgeos, ah huh | 13:11 |
Saviq | rsalveti, the changes from Albert's branches were not in distro yet | 13:11 |
Saviq | rsalveti, your change was already released as ubuntu5 | 13:12 |
Saviq | rsalveti, but we need a change on top of that | 13:12 |
rsalveti | let me check | 13:12 |
rsalveti | Saviq: oh, right, sorry, 11 hours jetlags are not helpful | 13:13 |
rsalveti | let me fix those | 13:13 |
rsalveti | Saviq: should I just upload to the archive? | 13:13 |
Saviq | rsalveti, well, sure | 13:14 |
rsalveti | give me a sec | 13:14 |
Saviq | rsalveti, I wanted to push through silo, 'cause I'm not powerful enough | 13:14 |
Saviq | rsalveti, just do a sanity-check on the changes then | 13:14 |
rsalveti | yeah | 13:14 |
* Saviq really needs food | 13:14 | |
rsalveti | Saviq: they are upstream changes | 13:14 |
rsalveti | so fine | 13:14 |
Saviq | rsalveti, well, one of them is rejected upstream ;) | 13:15 |
rsalveti | Saviq: :-) | 13:15 |
Saviq | being a hack, and in lieu of a proper fix | 13:15 |
rsalveti | right | 13:15 |
dednick | Saviq: "image://theme/alarm-clock,alarm" | 13:15 |
dednick | it's in actions set | 13:16 |
Saviq | dednick, ah, nasty | 13:16 |
Saviq | dednick, will add actions there then | 13:16 |
Saviq | dednick, pushed | 13:17 |
tsdgeos | Saviq: rsalveti; it's technically not rejecte but "let's wait for the guy that knows better to approve or reject" | 13:19 |
rsalveti | alright | 13:19 |
dednick | Saviq: so where? | 13:19 |
dednick | to. | 13:19 |
Saviq | dednick, unity8 | 13:19 |
Saviq | dednick, just added "actions" as a fallback set | 13:20 |
dednick | Saviq: ah | 13:20 |
Saviq | dednick, I'm in quick'n'dirty mode now, didn't you notice? ;P | 13:20 |
=== alan_g|lunch is now known as alan_g | ||
Saviq | FOOD | 13:21 |
* Saviq suspends to not hear the pings | 13:21 | |
dednick | ahha. i did :) | 13:21 |
dednick | Saviq: reviewed https://code.launchpad.net/~unity-team/unity8/suru-switch/+merge/207991. tiny fix | 13:31 |
davmor2 | Saviq: you have another mode? | 13:35 |
dandrader | mzanetti, if I slowly do a right edge-drag and release before it leaves phase 0 I'm getting "Cannot read property 'fullscreen' of null" because of "root.fullscreen = ApplicationManager.get(index).fullscreen;" in "function snapTo(index)" which uses index===1 | 13:46 |
dandrader | mzanetti, but when you have only one app running | 13:47 |
dandrader | mzanetti, there's only index 0 | 13:47 |
mzanetti | dandrader: pushed a fix for that like 2 minutes ago | 13:48 |
dandrader | :) | 13:49 |
mzanetti | dandrader: am I correct with this? https://code.launchpad.net/~mzanetti/unity8/new-header/+merge/224585/comments/541168 | 13:51 |
dandrader | mzanetti, you mean the lower right part of the "SEARCH" label? | 13:53 |
mzanetti | dandrader: no, the search label in the panel is gone... Instead we have a magnifier glass icon in the header of the dash, at the right edge | 13:53 |
mzanetti | dandrader: and parts of it are not clickable | 13:54 |
mzanetti | I'm quite sure its the 2 grid units used for the drag area at the right | 13:54 |
dandrader | mzanetti, ah, ok. then yeah, your comments sounds right | 13:54 |
mzanetti | tsdgeos: ^ | 13:54 |
Saviq | davmor2, pfft! | 13:55 |
mzanetti | tsdgeos: you can tryPageHeader, it won't happen there | 13:55 |
dandrader | mzanetti, gesture canceling will come after qt comp has landed | 13:55 |
tsdgeos | mzanetti: ?¿ | 13:55 |
mzanetti | tsdgeos: but as all the apps use the same header and have icons in the same place, I don't think its a real issue | 13:55 |
mzanetti | tsdgeos: re comment https://code.launchpad.net/~mzanetti/unity8/new-header/+merge/224585/comments/541168 | 13:55 |
tsdgeos | why is half of the thing not being clickable ok? | 13:55 |
mzanetti | tsdgeos: yeah, the shell's right/left edges drag areas cover it | 13:56 |
tsdgeos | ah | 13:56 |
tsdgeos | :/ | 13:56 |
mzanetti | tsdgeos: after QtComp has landed those areas will inject clicks to the app behind if its not a real gesture | 13:56 |
dandrader | mzanetti, tsdgeos can't we add some right margin to the icon so that it doesn't stand so close to the edge? | 13:56 |
mzanetti | dandrader: no | 13:56 |
dandrader | btw, haven't seem the thing yet | 13:56 |
mzanetti | well, the SDK would need to do that in the header for all apps | 13:57 |
Saviq | dednick, fixed, pushed | 13:57 |
dandrader | mzanetti, a workaround, if this is really bothering, is to reduce the height of the right-edge EdgeDragArea so that it begins right below the header | 13:58 |
tsdgeos | dandrader: mzanetti: let's just land QtComp :D | 13:59 |
mzanetti | dandrader: I don't think this is a real issue. Otherwise apps people would have complained already | 13:59 |
mzanetti | dandrader: its just that tsdgeos found it in the review and hence the discussion popped up | 13:59 |
mzanetti | dandrader: but here's one for you: in QtComp's input handler we'd need to forward keypresses to the apps again | 14:01 |
rsalveti | tsdgeos: Saviq: done, https://launchpad.net/ubuntu/+source/qtbase-opensource-src/5.3.0+dfsg-2ubuntu6 and https://launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/5.3.0-3ubuntu6 | 14:01 |
mzanetti | dandrader: QtComp breaks for example Volume up/down keys in apps | 14:01 |
Saviq | rsalveti, thanks | 14:02 |
tsdgeos | +1 | 14:02 |
sil2100 | Saviq: when are we landing 008 :8 ? | 14:02 |
Saviq | sil2100, no idea | 14:03 |
dandrader | mzanetti, could you add it here (if it's not there already)? -> https://docs.google.com/a/canonical.com/spreadsheets/d/1Balt7jlHQlNuf7RBuXYjnYJWaICd_wTRpSVfTYYb3cQ/edit#gid=0 | 14:04 |
Saviq | sil2100, you'll need to talk to tvoss :) | 14:04 |
mzanetti | dandrader: just added it | 14:05 |
mzanetti | dandrader: 22 | 14:05 |
dandrader | mzanetti, thanks | 14:05 |
mzanetti | btw, see 21 | 14:05 |
mterry | Does anyone have any experience with QFuture? | 14:06 |
kgunn | greyback_: so dednick and i were just chatting on trust prompts then we started talking about use of desktop file hints...and why unity-mir "verifies" this, is it _only_ to launch from the command line ? | 14:07 |
greyback_ | kgunn: yes, only for that reason. | 14:07 |
greyback_ | kgunn: I want to remove it ultimately | 14:08 |
kgunn | greyback_: wow...ok, so if we wholly rely on the "system" to check security...and we remove this, then we don't really need to add anything | 14:08 |
kgunn | back in place | 14:08 |
greyback_ | kgunn: yep, can move the decision making into that "system" | 14:09 |
greyback_ | whetever that is | 14:09 |
greyback_ | appArmor? | 14:09 |
kgunn | greyback_: so if an app shows up (e.g. a trusted provider) wanting to connect to mir & draw stuff...and its been "checked" by app armor at the mir socket level then | 14:09 |
kgunn | unity-mir just says "ok"....never refuses for any reason | 14:10 |
greyback_ | kgunn: well unity-mir still needs to know the desktop file associated with the process | 14:10 |
kgunn | greyback_: hmmm, that's the prob as dednick pointed out....trusted provider won't have a desktop file | 14:10 |
kgunn | assoc'd | 14:10 |
greyback_ | which would be a pity. A trust provider would ideally have a manifest file of some kind to tell shell "this is how I want my splash screen to look" | 14:11 |
greyback_ | and I think desktop files are good for that | 14:11 |
dednick | but the desktop file is found when we have the app id from upstart isnt it? | 14:11 |
dednick | greyback_: so do we really need anything in "authoriseSession"? | 14:12 |
greyback_ | dednick: if that trust helper is launched via upstart, then yes. But I saw people saying that dbus activation could be used | 14:12 |
greyback_ | in that latter case, unity-mir only gets a PID. It can't reliably associate an appId & thus desktop file with that | 14:13 |
dednick | greyback_: but the prompt providers could be started by upstart maybe? | 14:14 |
greyback_ | dednick: if we can convince everyone to do that, then I think we're golden | 14:14 |
kgunn | dednick: if that's the case...that'd be a new mandate not discussed yet | 14:14 |
dednick | not sure about that though... | 14:14 |
greyback_ | nor am I. | 14:14 |
greyback_ | proper integration of dbus-activation and upstart would be only way to make everyone happy | 14:15 |
greyback_ | but that's not trivial I'd imagine | 14:15 |
mzanetti | dednick: when I have a bluetooth mouse attached, unity8's indicator only shows battery status of that mouse instead of the notebook | 14:16 |
dednick | mzanetti: yeah... sucks huh | 14:16 |
mzanetti | dednick: is that indicator-power? | 14:16 |
dednick | mzanetti: yep | 14:16 |
mzanetti | ok, reporting | 14:17 |
greyback_ | mzanetti: I've that problem with my desktop. My bluetooth keyboard always reports 0 battery, so I always have a red battery symbol | 14:17 |
greyback_ | would be nice to see both power icons | 14:17 |
dednick | greyback_: so, should we just be authorizing everything coming into autoriseSession? | 14:17 |
kgunn | greyback_: dednick ....so i'm re-reading, iiuc, you're saying...desktop file not used for "authorization"...but good for things like "here's my splash screen"...so more about user exp affectations | 14:18 |
mzanetti | greyback_: heh, I remember KDE had this problem about a year ago... it would even suspend my PC when the mouse runs empty :D | 14:18 |
kgunn | dednick: much simpler way to ask the question :P | 14:18 |
mzanetti | or not suspend the PC if the mouse is full | 14:18 |
mhr3 | tsdgeos, how doable is another chevron on the scopes category headers? | 14:19 |
greyback_ | dednick: no, every app must have a desktop file. A trusted helper isn't an app, so perhaps can be exempt from that | 14:19 |
tsdgeos | mhr3: to do what? | 14:20 |
tsdgeos | mhr3: or you mean a different shape? | 14:20 |
mhr3 | tsdgeos, to perform a new query, possibly open temp dash page | 14:20 |
tsdgeos | waht?¿ | 14:20 |
mzanetti | greyback_: if you wanna add something or confirm: https://bugs.launchpad.net/unity8/+bug/1336285 | 14:20 |
ubot5 | Ubuntu bug 1336285 in Unity 8 "When a Bluetooth mouse is connected, indicator-power reports only that information instead of notebook battery" [Undecided,New] | 14:21 |
mhr3 | tsdgeos, design... | 14:21 |
tsdgeos | mhr3: so every line has two different "buttons"? | 14:21 |
mhr3 | tsdgeos, well, no, the original expanding chevron should go away | 14:21 |
tsdgeos | mhr3: not doable timewise, i have 1.5h of work left and them i'm off until next tuesday | 14:21 |
tsdgeos | :D | 14:21 |
mhr3 | there should be "See more" below the first row | 14:21 |
kgunn | greyback_: but then how do you "know" its a trusted helper ? | 14:22 |
kgunn | or a trust provider | 14:22 |
dednick | kgunn: at the moment, authoriseSession is used to reject everything that unity doesnt consider a legal unity application (ie doesnt have a desktop file so will not appear in application lists). However, there are some exceptions to that rule, eg OSK. | 14:22 |
dednick | It also allows us to start processes via command line by providing a desktop_file_hint so that it will consider these processes as unity applications. | 14:22 |
dednick | bit more complicated way of thinking of it ;) | 14:22 |
mhr3 | s/first/x-th/ | 14:22 |
greyback_ | kgunn: that's the problem. unity-mir has no way to determine that, something external needs to know | 14:23 |
dednick | kgunn: in trust sessions current unity-mir implementation, we have added the trust sesion processes to that list of exceptions which include OKS | 14:23 |
dednick | s/OKS/OSK | 14:23 |
mhr3 | tsdgeos, i'm mostly wondering if it's tweaking a bit of qml or more involved | 14:23 |
tsdgeos | mhr3: i'm not sure i understand the concept yet | 14:23 |
kgunn | dednick: so sounds like your task is more like you originally described | 14:24 |
tsdgeos | mhr3: which of the 3 different chevrons we have in deparments has to be replaced/changed? | 14:24 |
dednick | kgunn: what we decided in the meeting now (as i understood), was to created a socket in mir which is pre-trusted, and will bypass the autoriseSession process. | 14:24 |
mhr3 | tsdgeos, not about departments | 14:24 |
tsdgeos | :D | 14:24 |
dednick | kgunn: the helpers will connect to this trusted socket | 14:24 |
tsdgeos | sorry | 14:24 |
tsdgeos | mhr3: you mean https://code.launchpad.net/~aacid/unity8/grid-see-more ? | 14:25 |
tsdgeos | it's doable | 14:25 |
tsdgeos | needs work | 14:25 |
tsdgeos | that branch probably doesn't compile nor merge anymore | 14:25 |
mhr3 | ah, yea, that will be part of it | 14:25 |
dednick | kgunn: but the trust prompt providers will not, which is why they still will go through authoriseSession. | 14:25 |
tsdgeos | and by doable i mean "it's not hard", not "we have time" ;) | 14:25 |
mhr3 | tsdgeos, then the other part is conditionally adding a chevron to some categories | 14:25 |
dednick | greyback_: i was just saying return true from authorizeSession, not to give everything "app status" | 14:28 |
tsdgeos | mhr3: it's not impossible if we get a design, but i for sure don't think i'll have cycles for it | 14:28 |
tsdgeos | dash overview still needs to be done ^_^ | 14:29 |
* tsdgeos jumps over the window | 14:29 | |
dednick | ie. only things with a dekstop file will become apps, but we don't reject session connection attempts. | 14:29 |
mhr3 | tsdgeos, that's why i'm asking how complex is it, maybe i could manage | 14:29 |
dednick | greyback_: ^ | 14:29 |
tsdgeos | mhr3: you could give it a try, shouldn't be ultra hard | 14:29 |
greyback_ | dednick: then _anything_ can connect to Mir. We wanted shell to mediate exactly what can connect or not. | 14:30 |
mhr3 | tsdgeos, wanted to hear "easy / simple", not "not ultra hard" :P | 14:30 |
dednick | greyback_: yeah, but "what cant" ? | 14:30 |
mhr3 | tsdgeos, which means "only mildly hard"? :) | 14:30 |
greyback_ | dednick: seems a security risk to allow processes to connect to mir, but are "ignored" by the shell | 14:30 |
greyback_ | dednick: app that does not have a desktop file associated with it, or app which already has running instance. | 14:31 |
greyback_ | same old stuff | 14:31 |
dednick | greyback_: anything stopping you from running an app on your desktop? | 14:33 |
tsdgeos | mhr3: means easy if you have the time | 14:35 |
kgunn | dednick: i _think_ i understand, and yeah...so you and greyback_ are still determining, does unity-mir really have an "authorization" role to play here... | 14:42 |
greyback_ | kgunn: dednick: the reason we impose a strong app-desktopFile connection with Mir & authorizeSession is to avoid the horror that is BAMF in today's unity desktop, which uses complex heuristics to try match a process with a desktop file | 14:43 |
greyback_ | it is also a security and performance restriction, only letting things connect to Mir that a user expects | 14:44 |
Saviq | dednick, I pushed the fix to unity8 btw | 14:47 |
=== dandrader is now known as dandrader|afk | ||
tsdgeos | Saviq: https://code.launchpad.net/~unity-team/unity8/scope-customizations/+merge/225170 | 14:54 |
Saviq | tsdgeos, yup, saw that, thanks! | 14:55 |
tsdgeos | i'm going to try to do some small stuff before leaving | 14:55 |
tsdgeos | but mostly anotated with TODOs what i think needs doing | 14:55 |
Saviq | yup | 14:55 |
mhr3 | tsdgeos, yey, customizations, the server should already provide logos for a few scopes, did you see any? | 14:56 |
tsdgeos | mhr3: didn't try ^_^ just on the test apps | 14:56 |
tsdgeos | mhr3: know which scopes? | 14:57 |
mhr3 | tsdgeos, amazon | 14:57 |
tsdgeos | let me see | 14:57 |
mhr3 | tsdgeos, +wiki, +grooveshark | 14:58 |
tsdgeos | mhr3: yep, they show up | 14:59 |
tsdgeos | we're having a pixelization problem somewhere i'd say though | 15:00 |
mhr3 | tsdgeos, snap a screenshot so cwayne is happy :) | 15:00 |
mhr3 | or maybe don't then :P | 15:00 |
cwayne | hah, i've already branched it and am building now :P | 15:00 |
tsdgeos | mhr3: cwayne: http://i.imgur.com/T6oD5it.png | 15:01 |
cwayne | holy crap that makes me happy | 15:01 |
tsdgeos | cwayne: you need unreleased ubnutu-sdk stuff to run it, may not be so trivial | 15:02 |
tsdgeos | cwayne: mzanetti has some custom build debs for you if you really want to | 15:02 |
cwayne | i think i need to be at a sprint with you guys so I can properly repay all of you with beers | 15:02 |
cwayne | id like to if there's debs :) | 15:02 |
tsdgeos | <mzanetti> https://chinstrap.canonical.com/~mzanetti/qtdeclarative5-ubuntu-ui-toolkit-plugin_0.1.47+14.10.20140618-0ubuntu1_amd64.deb | 15:03 |
tsdgeos | <mzanetti> https://chinstrap.canonical.com/~mzanetti/ubuntu-ui-toolkit-theme_0.1.47+14.10.20140618-0ubuntu1_amd64.deb | 15:03 |
tsdgeos | -*- mzanetti hopes you use amd64 | 15:03 |
mhr3 | tsdgeos, oh yea +ebay :) | 15:03 |
dednick | Saviq: approved. | 15:06 |
Saviq | dednick, o/ | 15:06 |
Saviq | dednick, top-ack? | 15:08 |
dednick | Saviq: done | 15:08 |
Saviq | \o/ | 15:09 |
=== dandrader|afk is now known as dandrader | ||
dednick | now. some food would be nice... | 15:10 |
=== Malsasa_ is now known as Malsasa | ||
=== elopio_ is now known as elopio | ||
bregma | I get a segfault in Unity8 on the desktop today, during startup | 15:49 |
bregma | #1 0x00007fffef5903fc in ServerStatusListener::started() () from /usr/lib/x86_64-linux-gnu/libunity-mir.so.1 | 15:50 |
bregma | anyone else see that? | 15:50 |
Saviq | greyback_, ↑↑ ideas? | 15:51 |
greyback_ | bregma: never seen that ever before. Backtrace possible? | 15:52 |
bregma | greyback_, I'm currently installing ddebs (hope they're available for the packages) | 15:53 |
kgunn | dednick: do you need some reviewer love on | 15:57 |
kgunn | https://code.launchpad.net/~nick-dedekind/unity8/indicator.call-hint/+merge/218627 | 15:57 |
kgunn | Saviq: ^ it'd be great if we can land this by thurs | 15:58 |
kgunn | think nick was updating tests y'day....but should be good now? | 15:58 |
Saviq | kgunn, sure, doable | 15:58 |
=== gatox is now known as gatox_lunch | ||
bregma | greyback_, I'm wrong about a segfault, it's just caught in some kind of loop receiving SIGSTOP and eventually gets killed | 16:04 |
greyback_ | bregma: ok, thanks for letting me know | 16:05 |
Saviq | bregma, did you manage to test silo 4 with the new icons then? | 16:27 |
Saviq | dandrader, would you have time to review https://code.launchpad.net/~nick-dedekind/unity8/indicator.call-hint/+merge/218627 ? | 16:28 |
dandrader | Saviq, I can do it first thing tomorrow | 16:31 |
Saviq | dandrader, that would be great, thanks | 16:32 |
dandrader | Saviq, btw, where's the "Approved by: " line in commit messages? | 16:32 |
dandrader | Saviq, I've a feeling that automation will never come back :( | 16:33 |
Saviq | dandrader, file a bug in https://bugs.launchpad.net/ubuntu-ci-services-itself | 16:33 |
Saviq | dandrader, assign sil2100 to it | 16:33 |
Saviq | dandrader, it'll happen :) | 16:33 |
dandrader | Saviq, reported it https://bugs.launchpad.net/ubuntu-ci-services-itself/+bug/1336409 | 16:38 |
ubot5 | Ubuntu bug 1336409 in Ubuntu CI Services "Merge proposals that that get in lp:unity8 are missing "Approved by" lines" [Undecided,New] | 16:38 |
dandrader | Saviq, but I'm not able to assign it to him | 16:38 |
dandrader | sil2100, https://bugs.launchpad.net/ubuntu-ci-services-itself/+bug/1336409 could you please take it? :) | 16:38 |
dandrader | Saviq, hmm, so you know the proper wording for this stuff ;) | 16:39 |
Saviq | dandrader, kinda have to ;) | 16:39 |
Saviq | daaamn ^W | 16:41 |
dednick | kgunn: yup, it's ready to be reviewed | 16:43 |
mzanetti | Saviq: what up? :D | 16:44 |
Saviq | mzanetti, I tend to press ^W a lot to close tabs in firefox | 16:44 |
mzanetti | ah :D | 16:45 |
Saviq | mzanetti, but with two screens I often end up doing that in the xchat window | 16:45 |
Saviq | hence leaving the channel | 16:45 |
mzanetti | hey, just flashed latest devel-proposed. did we anything that could break launching stuff from indicators? | 16:45 |
Saviq | ^Q directed at Qt creator ends up in Firefox sometimes, too ;) | 16:45 |
* mzanetti never closes stuff | 16:45 | |
Saviq | mzanetti, not that I know of | 16:45 |
mzanetti | Saviq: seems to be broken here :/ | 16:46 |
Saviq | mzanetti, I sometimes have like three different QtC with different sessions open | 16:46 |
Saviq | mzanetti, will check in a mo after autopilot finishes | 16:46 |
mzanetti | lately my X seems to crash daily between 6 and 7 pm, that helps with cleaning up windows | 16:47 |
Saviq | you should try Unity, you'd your desktop cleaned up much more often ;P | 16:47 |
Saviq | +have | 16:47 |
mzanetti | why? | 16:48 |
Saviq | j/k | 16:48 |
Saviq | but it's been annoying me a few times lately | 16:48 |
Saviq | ending up in ctrl+alt+backspace | 16:48 |
mzanetti | oh really, didn't have that in ages | 16:48 |
Saviq | sometimes it just locks up for me | 16:48 |
Saviq | today nautilus lost theming | 16:48 |
mzanetti | but as I said, on friday and yesterday this time my X just went away :D but only the work desktop, leaving me with the private one... probably some work hours control feature | 16:49 |
* Saviq should cron something like that | 16:50 | |
Saviq | probably just needs to get it from tsdgeos | 16:51 |
mzanetti | lol | 16:51 |
mzanetti | kgunn: packages built | 16:58 |
mhr3 | i still like our `restart scope-registry` | 16:58 |
mhr3 | which seems to be alias for `pkill -f init` | 16:58 |
mzanetti | hmmm... | 16:59 |
mzanetti | my crashes did happen when calling ./run.sh | 16:59 |
mhr3 | if you have init's .crash in /var/crash then that's it | 17:00 |
mzanetti | I do :) | 17:00 |
=== gatox_lunch is now known as gatox | ||
mhr3 | mzanetti, cool... so just wait till 16.04 when we'll have systemd :P | 17:00 |
mzanetti | :) | 17:01 |
=== alan_g is now known as alan_g|EOD | ||
mzanetti | I think I have crash files for KDEs crash reporter here | 17:02 |
mhr3 | crash-ception | 17:03 |
=== dandrader is now known as dandrader|lunch | ||
Saviq | seb128, duude, how long do the settings ap tests take? :P | 17:23 |
* Saviq likes qmltests :P | 17:24 | |
AlbertA | can somebody take a look at: https://code.launchpad.net/~albaguirre/unity-system-compositor/fix-1336411/+merge/225209 | 17:30 |
mzanetti | kgunn: heads up... some dependencies changed in the system => qtmir failed to build in the ppa => mismatch => ppa broken atm :/ | 17:37 |
mzanetti | kgunn: seems some transition in the underlaying deps.. should hopefully go away soon | 17:37 |
kgunn | ack | 17:44 |
sil2100 | dandrader|lunch: let me take a look ;) | 18:23 |
=== salem_ is now known as _salem | ||
=== dandrader|lunch is now known as dandrader | ||
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!