=== _salem is now known as salem_
Saviqmzanetti, hmm, icon data is stored in accountsservice directly is it?09:02
mzanettiSaviq: need to check, one sec09:02
mzanettiSaviq: yes09:03
Saviqmzanetti, not great, means old icons in launcher when they get updated :/09:03
mzanettiSaviq: yes...09:04
mzanettiSaviq: but I can't access stuff from the greeter session otherwise09:04
Saviqmzanetti, we might need to refresh the data on startup though09:05
mzanettihmm... I think I acutally do that... it's been a while09:05
mzanettiSaviq: no. I don't atm09:06
Wellarkhey, how can I run a single test under qmltest directory ?09:06
Wellarkfrom a local checkout09:06
SaviqWellark, make -C builddir testFoo09:06
Saviqmzanetti, yeah, I'll file a bug09:07
Saviqmzanetti, we should also hook up to app upgrades09:07
WellarkSaviq: cool. thanks09:08
Saviqmzanetti, can I ask you to review https://code.launchpad.net/~renatofilho/unity8/blue-led/+merge/22489909:08
mzanettiSaviq: hmm... wouldn't be some telepathy stuff the better place for this?09:16
Saviqmzanetti, that's temporary09:16
Saviqmzanetti, we'll have a central notification place at some point, telepathy isn't enough either09:17
WellarkSaviq: could I get somebody to take a quick look https://code.launchpad.net/~unity-api-team/unity8/modeminfo/+merge/22515909:22
SaviqWellark, the components should probably go to lp:ubuntu-settings-components09:25
SaviqWellark, and actually you might be able to just use Menus.StandardMenu from https://code.launchpad.net/~unity-team/ubuntu-settings-components/suru-theme09:25
SaviqWellark, it's landing with the suru theme in a few moments09:25
Saviqdednick, looks like this would fall on your plate ↑09:26
SaviqWellark, hmm or maybe not, you have two icons on the left09:27
dednickSaviq: yeah. i just saw it this morning09:27
dednickSaviq: custom item09:28
dednickWellark: that needs to go into lp:ubuntu-settings-components09:29
Wellarkdednick: could we move it there if we actually need it somewhere else. it's indicator-network related custom component and will not be used anywhere else09:43
dednickWellark: it will most likely be in settings as well.09:43
dednickWellark: there are no menu components in unity8 anymore.09:44
Wellarkdednick: settings display the information in an entirely different manner as there is actually room there. this is purely an indicator thing09:44
dednickWellark: is there a spec for this item anywhere?10:00
Saviqmzanetti, is there a way we can affect colour of the header icons?10:07
mzanettiSaviq: it's uitk's Action component. Don't think it has an api for that.10:07
Saviqok, we'll need it10:07
mzanettiSaviq: the back button is even hidden inside the PageHeadStyoe10:07
mzanettiSaviq: so when the dash becomes an app, it won't inherit shell's theme any more10:08
mzanettiSaviq: will we still need it then?10:08
Saviqmzanetti, yes, scope authors need to have control over that10:09
mzanettiSaviq: yeah. I guess we'd need to talk to timp10:09
mzanettiSaviq: will you or should I take care of that?10:09
Saviqmzanetti, already talking10:09
Wellarkdednick: no, there is none. I discussed this item with mpt at Malta and we agreed that I will cook it up so that we can get the information to the indicator. I will attach the related bug reports to the MP.10:12
dednickWellark: https://docs.google.com/a/canonical.com/document/d/1OyHUg_uUfmhDNa-9UrMc1tZ_eH_99PEU_V2l1YFA1UY/edit#10:12
dednickWellark: i've commented on your MP10:13
dednickmzanetti: do we have sim unlock in the greeter now?10:14
mzanettidednick: define "in the greeter"10:14
dednickuuuh. in the greeter screen. ie forced to unlock before get into dash10:15
mzanettidednick: so it won't be "in" the greeter, but yes, it should pop up behind the greeter so you'd get there when swiping the greeter away10:15
dednickmzanetti: because apparently that's a requirement.10:15
mzanettidednick: its not there yet, no10:16
dednickmzanetti: right.10:16
mzanettidednick: faik Wellark was to take care of that10:16
dednickmzanetti: ok. it's apparently not supposed to be part of indicators. guess we added that as a temp patch10:17
dednickWellark: ^10:17
mzanettidednick: so all it takes is to fire a notification10:17
mzanettimy last information was the indicators were supposed to do that... but its been a while10:17
mzanettiI think Saviq has the full plan on it10:17
Saviqmzanetti, dednick, yeah the button was temporary, and yes it's supposed to show before the greeter, not sure if cancellable though10:19
mzanettiSaviq: Olga revised Katies decision to show it before the greeter10:20
dednickSaviq, mzanetti: apparently not. requirement for german operators to enter sim to get to phone.10:20
dednick"to phone" - being to be able to use any part of phone10:20
Saviqdednick, interesting, Nokia didn't get the memo then ;)10:20
* mzanetti has a hard time to believe that10:20
Saviqdednick, and it's stupid, too - just take the SIM card out and you're in10:21
dednickJohnLea: ^10:21
dednickheh. true10:21
dednickperhaps not germany. he did say "I think"10:22
mzanettidednick: still, the button in the indicators needs to stay I think10:23
mzanettidednick: if you cancel the dialog, you still want a way to introduce the pin later10:24
JohnLeadednick, mzanetti, Saviq; hyia, minor adjustment from my conversation with dednick earlier; the only place users will be able to unlock the SIM PIN is via the screens and designs that I shared with dednick, but this does not necessarily need to block the user from entering the phone as long as when a SIM PIN is needed we can display the relevant screen from the designs I shared and then return the user to where they were.  However if10:29
JohnLea this is not possible for RTM it is ok to require the user to enter the SIM ping before logging into the phone (if this makes you life easier)10:29
WellarkJohnLea: umm, which design are you talking about, just to be sure?10:40
dednickWellark: https://docs.google.com/a/canonical.com/document/d/1VajNkWbBH61iVixXJAmOvNGiG__GWQTMXGNOZijXWJw/edit#heading=h.dxyj97l61sl710:40
dednickit's the greeter design10:40
Wellarkdednick, mzanetti, Saviq: indicator-network will have to have the SIM Unlock button in the future, too, as already stated that the user might just cancel the sim unlock dialog on the first time10:45
mzanettiyep, makes sense to me10:46
SaviqWellark, I agree, it should be triggered automatically by some events (like trying to call a non-emergency number or so)10:46
SaviqWellark, but indeed a clear button to do so is needed, too10:47
Wellarkdednick: where can we get more info on this requirement from german operators10:47
Saviqjust a second ago I cancelled the dialog on my N9 accidentally and I had to pop the SIM out and back in, had no idea how to unlock otherwise10:47
Wellarksounds like there might be some misunderstanding going on with that requirement..10:47
dednickWellark, Saviq, mzanetti: so we're just going to ignore what the designers say?10:48
WellarkSIM code != general lock code10:48
Saviqdednick, where does it say the button should not be there?10:48
dednicki'm not saying it's wrong. but we'll have to re-work if it is10:48
dednickJohnLea just said so. and https://docs.google.com/a/canonical.com/document/d/1OyHUg_uUfmhDNa-9UrMc1tZ_eH_99PEU_V2l1YFA1UY/edit#10:48
Saviqdednick, I don't think that's what JohnLea said, he just said those are the screens to unlock, not how to get to that screen in case you dismissed it10:49
Saviqdednick, that document doesn't cover that use case AFAICT, is all10:50
dednick"the only place users will be able to unlock the SIM PIN is via the screens and designs that I shared with dednick" and "as long as when a SIM PIN is needed we can display the relevant screen from the designs"10:50
JohnLeaSaviq, dednick; ideally for RTM if the user needs to unlock a SIM at a later date they should be directed to the greeter screens https://plus.google.com/hangouts/_/canonical.com/toolkit-sync and then back to where they were10:51
mzanettiJohnLea: sure... it'll always be the same pinentry screen10:51
mzanettiJohnLea: we're talking about how to open it again if it got dismissed when it popped up automatically10:51
SaviqJohnLea, you don't want to show it on every unlock after it's dismissed do you?10:52
Saviqso there needs to be a way to trigger the SIM entry UI10:52
JohnLeaSaviq; that can be set in System Settings I think, one sec I'll find the design10:52
WellarkJohnLea: SIM PIN != lock code10:52
JohnLeaWellark; of course!10:53
Wellarklooking at the greeter spec it seems to handle SIM PIN the way it should handle lock code10:53
Wellarkor am I missing something10:53
dednickWellark: it does both.10:53
mzanettiWellark: well, its the same dialog10:53
JohnLeaWellark; yes, they are different things, but they are handled in a very similar way10:53
JohnLeavery similar dialog10:53
Wellarkso what happens when the user boots up, sees the greeter, sees the <<unlock>> there, swipes the greeter open and then cancels the SIM unlock dialog?10:54
WellarkJohnLea: ^10:55
dednickJohnLea: i think having quick access button on indicator menu for locked sims wouldn't be a bad thing. Problem with the idea that "if you want to use your phone, then pop up SIM unlock" is that you can't receive calls either. Don't think the user should be prompted for SIM pin every time they use the greeter.10:55
SaviqJohnLea, btw, should I add a ubuntu-ux task for purely visual bugs as well? bug #133673110:57
ubot5bug 1336731 in Unity 8 "Sticky headings when scrolling the dash should have some visible separation from the icons that slide under them." [Undecided,New] https://launchpad.net/bugs/133673110:57
mzanettidednick: I very often intentionally not unlock the sim to not be reachable... but still want to use the phone as a music player.... so if it were me, I wouldn't pop it up every time automatically10:59
mzanettibut that's just my 2 cents... I guess I would survive it would do so too10:59
JohnLeadednick; the SIM PIN settings are shown at https://wiki.ubuntu.com/SecurityAndPrivacySettings#Phone  By default a user only ever needs to enter the SIM PIN one time, however in Germany there are different regulations, so the option to for the user to enter the SIM PIN after switching on the phone in order to use the SIM will be switched on11:01
mhr3Saviq, can you or someone take a look at https://code.launchpad.net/~unity-api-team/unity-api/scope-settings-shell/+merge/225287 pls?11:02
JohnLeaSaviq, yes, add ubuntu-ux for visual bugs as well, thanks!11:02
mzanettibuenos dias11:03
sil2100bregma: hi! Could you give me a ping once you're around?11:06
bregmasil2100, sure11:06
bregmasil2100, ping11:07
sil2100bregma: ;) :D So, I have a question about the compiz landing that's set to Testing: Done right now11:07
sil2100Silo 1011:07
sil2100bregma: since I already saw a compiz SRU for trusty in -proposed11:07
bregmayes, we had to respin the package11:07
sil2100bregma: ok, so I'll just re-publish it again then11:07
bregmasil2100, thanks, we've already been in touch with SRU people, but it was a holiday here yesterday so the middle bits were neglected11:08
Saviqmhr3, no api version bump?11:13
mhr3Saviq, needs fixing i guess11:15
mhr3Saviq, was mostly a question if you're happy with such interface11:15
Saviqmhr3, looks fine from what I can tell11:16
Saviqmhr3, properties will be a QVariantMap I assume?11:16
mhr3pete-woods, ^?11:16
* mhr3 still needs to look at the actual impl11:17
Saviq/food, then new header11:22
Saviqmhr3, fyi, new UITK release will happen just after suru, so we won't be blocked by that11:22
Saviq*but* sil2100 is chicken and doesn't want to release suru into the same image as new Mir11:23
sil2100I'm not chicken... :|11:24
=== MacSlow is now known as MacSlow|lunch
pete-woodsSaviq: yes, the properties is just boring variant map11:27
dandradermzanetti, is there an app that visibly changes when I press the volume keys?11:44
pete-woodsSaviq: if you're interested in the API usage, I have a "developer UI" (i.e. crappy QML) here http://bazaar.launchpad.net/~unity-api-team/unity-scopes-shell/scope-settings/view/head:/tools/settings/Settings.qml11:44
dandradermzanetti, i.e., showing in its UI in response to the presses11:44
mzanettidandrader: don't think so... I tested with xbmcremote which would changes my living room's volume when the buttons work11:44
mzanettidandrader: but you'd need xbmc running somewhere for that11:45
dandradermzanetti, np, will write a simple qml app then11:45
=== MacSlow|lunch is now known as MacSlow
=== alan_g is now known as alan_g|lunch
=== dandrader is now known as dandrader|afk
larsudednick: hey man, how's it going?12:28
larsudednick: did you see https://code.launchpad.net/~larsu/indicator-messages/add-simple-dbus-api ?12:29
larsuI'm starting to think we should have this API in unity itself and handle notifications and messaging menu with it12:29
larsu(this or something similar)12:29
=== dandrader|afk is now known as dandrader
=== _salem is now known as salem_
=== alan_g|lunch is now known as alan_g
dednicklarsu: hey. havent seen it.13:05
kgunndandrader: mzanetti greyback_ miracles never stop...mir040 landing in archive atm...so later today we can jettison mir out of rightedge ppa13:08
dednicklarsu: so that is a dbus menu to add messages to the menu model in indicator-messages?13:08
dandraderkgunn, finally :)13:08
greyback_kgunn: yay!13:08
dednicklarsu: dbus api i mean13:08
larsudednick: exactly, but without all the baggage that we needed for the desktop's messaging menu13:09
larsuand I think going through a gmenumodel for this just makes it more complicated13:10
dednicklarsu: right. why would it be exposed by unity8? That means that any app using it would need to be using unity813:10
larsusince we could use the same api for notifications (which uses org.freedesktop.Notification right now)13:10
dednickrather than indicator-messages13:10
larsuya, that's my point13:10
larsubasically, I want notifications and messaging menu to become the same thing from an apps pov13:11
dednicklarsu: by notification you mean?13:11
larsuah sorry, bubble notifications13:11
larsuand snap decisions13:11
larsusnap decisions look exactly the same as entries in the messaging menu on the phone13:12
=== MacSlow_ is now known as MacSlow
dednicklarsu: mmmm. are you meaning that we don't go through indicator-messages at all?13:14
larsudednick: if we go this way (notification center style I mean), indicator-messages would only contain code to convert between two kinds of APIs13:15
larsumight as well have this in unity8 directly13:15
larsuespecially considering that we already have a notification api in unity813:15
dednicklarsu: so why would we add the complication of 2 paths into unity8 messaging menu?13:15
dednickand 2 paths into notifications13:16
larsuthat's what we have now, I want to consolidate it into one13:16
larsuan app now has to talk libmessaging-menu and libnotify13:16
larsuand feed both with exactly the same data13:16
larsuwhat I'm proposing is that we only have this new api for both of them13:17
larsuand deprecate everything else13:17
larsuand since then indicator-messages would only do something  very trivial, get rid of that too13:17
larsujust throwing this idea out there for now, I haven't talked to all the relevant people yet13:19
larsu(but I guess this is the start of it)13:19
mzanettiuuhhh... nasty Qt 5.3 bug (I suppose its qt 5.3): scrolling on unity8's launcher with the mouse wheel scrolls the launcher *and* the dash behind it13:20
dednicklarsu: gmenumodel business?13:22
larsudednick: hm?13:22
dednicklarsu: the message menu is described as a gmenuodel13:23
larsudednick: in other news, Chipaca pointed out a bug in the messaging menu: you can't "open" the message below the one you've just activated13:24
larsudednick: right, I don't think it's that beneficial to us anymore13:24
larsuhm, untiy8 segfaults when I close it13:24
dednicklarsu: by open/activate, do you mean expand?13:25
larsudednick: by open I mean expand, by activate I mean click on the app icon13:25
dednicklarsu: when you click the app icon, it should open the app.13:26
Chipacadednick: put two messages on there, expand the top one and click the app icon13:27
dednickoh. other way around13:27
Chipacadednick: the second one moves up, but it seems to get stuck in a weird state, you can no longer expand it13:27
dednickChipaca: hm. mine is ok13:28
dednickwell, when i click on the app icon my indicators dissapear13:28
larsuright, you need to reopen it :)13:28
Chipacayeah, i skipped that bit :)13:29
dednickChipaca: ah. yeah, true.13:29
dednickChipaca: need to expand another one first13:29
dednickChipaca: i think the model thinks it's still expanded13:30
Chipacawithout knowing the code, that's what it looked like, a model and view out of sync13:30
dednicklarsu: and as for the api, think you're asking alot there :) It will be a lot of work which we don't "really" need right now.13:32
larsudednick: Chipaca is having trouble implementing push notifications with the messaging-menu API, this would help him a lot13:34
larsudednick: and the same will happen for sdk guys trying to expose both the messaging menu and libnotify to applications13:34
larsudednick: I'm not saying we need to do the full-on switch now13:34
larsuwhich is why I've added it to indicator-messages for now13:35
larsuas a transition13:35
larsubut before we decide to merge it, I want to make sure we're all on the same page on how to go forward13:35
dednicklarsu: I don't think it can be in unity8 process though.13:36
dednicklarsu: will need it in greeter.13:37
dednickas well i mean13:37
larsudoes greeter have bubble notifications? The same would apply to those, no?13:37
dednicklarsu: don't know about notifications.13:38
larsudednick: who does?13:38
larsuSaviq: ?13:38
Saviqlarsu, there's only a single layer of notifications now13:38
Saviqlarsu, we did have two when we split the greeter, but we reverted that13:39
dednicksame with indicators i guess13:39
dednickbut will be split.13:39
Saviqlarsu, and ultimately I'm after actually only having one layer of notifications, common for everything, syncing them between greeter and session proved real error prone13:40
Saviqwe may need one per user, there's investigation to eb had13:41
larsuSaviq: what do you mean by layer?13:41
larsuhaving it in a separate process?13:41
Saviqlarsu, no, rendered by the greeter session13:41
larsuright, but where does it get the data from?`13:42
Saviqlarsu, it will have to get it from the sessions, multiplex with its own13:42
Saviqthere's advantages and disadvantages, but I think we can cope13:43
larsuSaviq: makes sense to me. I was just talking to dednick about combining notifications and the messaging menu, since snap decisions look exactly the same as entries in the messaging menu13:46
larsuSaviq: and then letting unity8 handle both of them, without the indicator as a middle man13:46
larsudo you have any thought on that?13:46
Saviqlarsu, I think the whole PostOffice approach would facilitate that13:47
Saviqlarsu, and yeah, don't think there needs to be an indicator in between13:47
Saviqlarsu, but that's far away13:47
larsuSaviq: I've proposed a branch for indicator-messages to help the transition (so that applications / push notification service can already use a simpler API to get stuff into the messaging menu)13:49
larsuSaviq: I also don't know how the post office would help here. That's just another consumer of the api, no?13:49
Saviqlarsu, that's the only thing the app would talk to13:49
Saviqlarsu, whether that message would result in bubble, bubble+menu entry, menu entry alone, the post office would decide13:50
dednicki think it would work well for notifications, but would need some way for the data to live between greeter/unity sessions for messages.13:50
larsuSaviq: and the post office talks to unity how?13:50
Saviqlarsu, I wouldn't want to introduce a temporary API like this unless we have a longer-term plan that this aligns with13:50
Saviqlarsu, whatever we say works13:51
larsuSaviq: that's what I'm discussing right now..13:51
Saviqlarsu, I won't have time to discuss this properly for a few weeks at least still13:51
* Saviq hates Qt for the doc url mess, had to remove all related history >:[13:54
larsuSaviq: I'm bringing this up now because it's quite hard to integrate with the messaging menu right now and I'm afraid we're wasting some people's time13:55
Saviqlarsu, is that a public API on the phone anyway? or is this about push?13:56
larsuSaviq: not public, but for the push guys to use (and later the sdk guys if we ever decide to let apps issue notifications)13:57
Saviqlarsu, yeah, the "later" part is something that will require the PostOffice discussion to happen properly for sure, if the API is just for push consumption, I'm fine with that13:58
Saviqlarsu, whether it's going to be a separate process later that will expose the same / similar API and then communicate that to the shell, or just a library shell will load I've no strong opinion on, both works just fine13:59
larsuSaviq: right, that's what I'm thinking. It would even live in indicator-messages at first (for the transition)14:00
larsuI did call it com.canonical.Notifications though14:00
larsunot sure if that's what we want14:00
larsuI do like the thought of merging notifications and this, though14:00
Saviqlarsu, it's internal API for push consumption alone, not *really* important14:01
Saviqlarsu, sure, completely agree, but not *now* ;)14:01
larsuSaviq: okay, understood :) I do find it a bit odd with how low of a priority everyone treats notifications and the messaging menu14:03
Saviqlarsu, it's not low priority, they just work good enough as they do now, no significant work has been planned on those for first release14:04
Saviqlarsu, we're driven by business and design req, nothing came on that topic from there14:04
larsuSaviq: that's my point. "nothing came from there"14:06
Saviqlarsu, must mean it's purrfect, what you complain about!14:07
larsuSaviq: :) I don't know. I don't think it's good enough at all. Do we have apps other than phone that puts stuff into the messaging menu?14:08
Saviqlarsu, you know lifecycle prevents that on the phone anyway14:09
Saviqso not a huge prio14:09
sil2100seb128, Saviq: I can also publish the suru silo now if you want, but only on your resposibility! What's in that silo? Is that only some path change for the themes or something more complicated?14:13
Saviqsil2100, the default icon theme changed, icons got updated in apps, unity8 and settings had some adaptations to new icon sizes14:13
Saviqsil2100, I can take on the responsibility if you need me to14:14
Saviqwhoa it's 4pm already14:14
larsuSaviq: lifecycle prevents it because we have a bad API. Why do we have push notifications anyway if this doesn't work?14:14
Saviqlarsu, what doesn't work? push notifications are not lifecycled, push is exactly one way to "escape" lifecycle14:15
larsuSaviq: ah, the idea is that apps can only notify about something via push for now?14:17
Saviqlarsu, yes14:17
Saviqlarsu, if they're focused, they shouldn't even use notifications / messaging menu as... they're focused14:18
Saviqlarsu, and if they're not focused, they're suspended, so they can't do it anyway14:18
Saviqlarsu, so system services / push are the only way to issue notifications / messaging menu items14:19
larsuSaviq: fair enough, thanks14:20
=== alan_g is now known as alan_g|tea
karnimhr3_: I could have done something wrong, but I wouldn't expect to meet an assertion in scoperegistry :) Any ideas what could have gone wrong? http://paste.ubuntu.com/7737096/14:33
mhr3_karni, display name unset for a new scope?14:34
karnimhr3_: you're right, I'm using cmake to configure the ini file, and removed the setting SCOPE_TITLE from my CMakeLists, thanks14:35
dandraderSaviq, completely forgot about that indicators mp review14:39
Saviqdandrader, I'd have pung you, but the afternoon crept up on me14:40
=== mhr3_ is now known as mhr3
=== dandrader is now known as dandrader|lunch
=== gatox is now known as gatox_lunch
=== alan_g|tea is now known as alan_g
=== alan_g is now known as alan_g|EOD
mhr3Saviq, yey, cache-control in production for the click apps server17:08
=== gatox_lunch is now known as gatox
=== dandrader|lunch is now known as dandrader
mzanettiSaviq: still around?17:26
=== boiko_ is now known as boiko
CimiSaviq, you know where ApplicationManager.keyboardVisible is defined? (real one, not mocks)18:07
greyback_Cimi: it's in unity-mir18:08
greyback_Cimi: I thought you were going to ask me tomorrow18:08
eriduhey everyone; I'm seeing a regression in Unity in the HUD alt-tap behavior18:08
Cimigreyback_, I grep for it and nothing appears18:09
eriduafter upgrading to 14.04, the HUD started being launched even if I used a key chord like alt-b or alt-f as long as the tap is short enough18:09
eridushould I report this as a bug, or is there anything I could do first to ensure it wasn't my own system?18:09
greyback_Cimi: right you are. It's long gone18:10
Cimigreyback_, wondering how the shell works then...18:11
greyback_eridu: I say you should log it as a bug18:11
eridugreyback_: how do you recommend doing that? is there an apport line I should run so that all the right information gets harvested?18:11
Cimigreyback_, we have this piece of code in the shell is doing nothing18:12
greyback_Cimi: so I see. OSKController is only thing managing keyboard as far as I know18:13
greyback_Cimi: dead code I guess18:13
Cimigreyback_, so why the shell has input filtering under osk?18:13
* greyback_ changes password18:13
greyback_Cimi: lp:unity-mir src/modules/Unity/Application/OSKController.qml18:16
greyback_that should be doing all you need, but yes tell me tomorrow what's wrong18:16
dandradergreyback_, have you been able to successfully use QLoggingCategory filtering yet?18:21
greyback_dandrader: I did ages ago with a test. But I've not tried it since. Note that all messages are enabled by default so far18:22
Saviqmzanetti, back18:22
dandraderyeah, that I know18:22
mzanettiSaviq: reading through the merge... you often comment the import version bump18:22
mzanettiSaviq: I asked sdk people and asked if they think its a problem if I have mixed stuff from e.g. Ubuntu.Components 0.1 and ..Themes 1.118:23
mzanettiSaviq: they said I shouldn't do that, and we should update to 1.1 in general18:23
mzanettiSaviq: so I bumped it at least every where where I touched the import statements anyways18:24
Saviqmzanetti, hmm I don't think it matters as long as you have the right imports in the right places18:24
Saviqmzanetti, and for migration to 1.1 let's just do a separate MP just for that18:24
mzanettiSaviq: as albert said, I don't think auto bumping everything to 1.1 is a good idea18:25
mzanettior well in general auto updating qml imports18:25
mzanettiI would think that when we touch them anyways in code we test we should upgrade them18:25
mzanettibut not doing one batch that doesn't get enouch attention to each and every one18:25
mzanettiit probably doesn't really matter now for uitk 0.1 -> 1.118:26
mzanettibut we should figure a strategy for this18:26
mzanettiSaviq: want me to revert all the import changes then?18:26
Saviqmzanetti, dunno, I just wouldn't touch them unless needed, I can't see how that would be a problem18:26
Saviqmzanetti, all those that are not required I think yes, no need to touch them AFAICT18:27
Saviqmzanetti, if it was the problem to have them mixed, it doesn't matter if you change in 5 places but not in 5018:27
Saviqmzanetti, imports don't propagate across files, so the fact that you need 1.1 somewhere means that you just need 1.1 in that particular file18:28
mzanettisure... I know that18:28
Saviqmzanetti, singletons are interesting actually18:28
mzanettiI just had the import theme pretty much everywhere at some point. that's why I bumped the other components to 1.1 too18:29
Saviqmzanetti, I think wherever you use singletons you need to bump all at the same time18:29
mzanetticause I'd say we agree that if theme 1.1 is needed, the components should be 1.1 too18:29
Saviqmzanetti, sure, where there is themes 1.1, components in sync18:29
Saviqmzanetti, but if there's nothing 1.1 required, let's leave them be18:29
Saviqmzanetti, I think singletons are an exception - you need to bump all uses, otherwise you'd probably end up with separate files18:30
mzanettiSaviq: I still think it would be better to upgrade them like this... but your call. gonna revert the changes18:30
Saviqmzanetti, but what's the advantage?18:30
mzanettiSaviq: esp for QtQuick, I wouldn't want to do the one commit that bumps 2.0 to 2.218:30
mzanettibut I would be ok with upgrading the parts I touch anyways18:31
mzanettiaanyways. will add the singleton and see what's left18:32
Saviqmzanetti, right now I have the feeling that it's best to only bump when we actually need the changes, I don't see much of a difference between bumping them all at once or bumping without the need18:33
Saviqmzanetti, truth be told we should ask Simon/Alan if they thought about that18:33
mzanettihmm... ok... I would have said its better to keep up to date instead of having 2.0 and 2.10 mixed at some point18:34
Saviqmzanetti, there's a flaw in that approach, though - what if we don't touch a file between now and 2.1018:34
Saviqit'll be at 3.0 still18:34
Saviqand then we need auto-bump anyway18:35
mzanettibut then its not many any more which could bring potential issues18:35
Saviqwe could bump in waves, too18:35
Saviqlike per component18:35
mzanettiok well... lets just think about it and discuss that again when albert is back. I'm sure he has an opinion on it18:36
mzanettifor now I do what you told18:36
om26erHi! can anyone please review my test branch for unity8 ?18:44
om26erWe need this in for a UX test.18:45
Saviqom26er, hey, we're a bit swamped for reviews, it's not like we singled out yours to leave rotting18:46
Saviqom26er, we'll definitely get to it18:46
om26erSaviq, ok.18:47
Saviqom26er, it's not too big either, so it shouldn't take too long18:47
dandraderSaviq, btw, nick set his https://code.launchpad.net/~nick-dedekind/unity8/indicator.call-hint/+merge/218627 as "work in progress". so I think I got away with it for now :)18:47
Saviqdandrader, looks Needs review to me?18:48
* dandrader checks again18:48
dandraderoh right, that was on jun 30. don't know why I didnt get the next status update e-mail18:49
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!