| josharenson | I am getting the following error when calling launch_click_package | 01:16 |
|---|---|---|
| josharenson | http://pastebin.ubuntu.com/7739626/ | 01:16 |
| josharenson | The app launches just fine, but it seems the return value is bad? | 01:17 |
| veebers | thomi: when you have a moment would you be able to review this please: https://code.launchpad.net/~veebers/autopilot/adding_screenshots_to_details/+merge/225423 | 03:47 |
| thomi | veebers, looking now | 03:52 |
| veebers | awesome, cheers | 03:52 |
| thomi | veebers: want feedback here, or in the MP? | 03:53 |
| veebers | thomi: in the MP please so I don't lose it :-) | 03:53 |
| thomi | veebers: you *really* need to mock/patch waaaay less | 04:19 |
| veebers | thomi: fair enough, do you have any suggested for that MP? | 04:22 |
| thomi | veebers: yes, lots | 04:22 |
| thomi | you might want to get a drink | 04:22 |
| veebers | thomi: heh, I'm ready when you are :-) | 04:23 |
| thomi | veebers: review posted | 04:26 |
| thomi | veebers: I'm happy to talk about it in person, if you need | 04:26 |
| veebers | thomi: sweet, I'll take a look and ping you in a couple of minutes once I've digested it? | 04:27 |
| thomi | sure | 04:27 |
| veebers | thomi: also, could I get you to eyeball this pre-req please: https://code.launchpad.net/~veebers/autopilot/logging-binary-attachments-1336109/+merge/225098 | 04:27 |
| veebers | thomi: all your comments make sense I don't think there is need for a call. I'll hit those points now | 04:31 |
| veebers | thomi: for detecting if the display is x11/mir and the platform module. That currently only gives us details like Desktop/device/tablet etc. I don't think it's enough to say "if is device then it's mir, desktop is x11" | 05:08 |
| veebers | thomi: do you have any better ideas than either the tests in that MP or the desktop==x11, not desktop=mir? | 05:08 |
| thomi | veebers: so, however you do the detection, the public api should be in the platform module.... | 05:09 |
| thomi | regarding detection for X11, is checking for $DISPLAY enough? Presumably your screenshot function needs that in order to work | 05:10 |
| thomi | WRT detecting mir, have you asked the mir team? My personal bet would be to try and find the mir socket, but that really only tells you that it's running *somewhere*, not necessarily in the current session | 05:11 |
| veebers | thomi: rats, I've lost the link, but I read a SO that said "xset q" was good, if a xset query fails than X isn't around | 05:11 |
| veebers | ah right: http://stackoverflow.com/questions/637005/x-server-running | 05:12 |
| thomi | veebers: xset reads $DISPLAY internally, and you have access to the X python bindings, I think we can do soemthing nicer than spawning a new process... | 05:14 |
| elopio | thomi: can you review this one please? | 05:14 |
| elopio | https://code.launchpad.net/~elopio/ubuntu-autopilot-tests/fix_packaging/+merge/225426 | 05:14 |
| veebers | thomi: ok, I'll look further | 05:14 |
| thomi | veebers: it'd be interesting to see what xset does under the hook | 05:15 |
| thomi | *hood | 05:15 |
| elopio | it seems that without the pybuild name, it tries to install in python3, instead of dist-packages. | 05:15 |
| thomi | veebers: but *at least* please protect that subprocess call with a functools.lru_cache :) | 05:15 |
| thomi | elopio: ahh, ok | 05:15 |
| thomi | elopio: approved | 05:16 |
| elopio | thomi: thanks. | 05:16 |
| elopio | now we have jenkins tests :D Lets see if they like it. | 05:16 |
| === vila_ is now known as vila | ||
| josharenson | elopio, I was able to modify all the templates to fit my project, but it still can't find my project's MainView | 20:16 |
| josharenson | the only thing that is different is directory structure... any insight on how the search works? It can find other objects just fine if I commend out the MainView search part | 20:16 |
| elopio | josharenson: can you put a import pdb; pdb.set_trace() just before selecting the main view? | 20:17 |
| elopio | and then open autopilot vis | 20:17 |
| josharenson | sure | 20:17 |
| elopio | it might be that you are extending main view, and it gets a different QML class name. | 20:17 |
| josharenson | elopio, it hit the break point and I see the contents in vis | 20:21 |
| josharenson | looking around | 20:21 |
| josharenson | says object name is "mainView" | 20:21 |
| elopio | josharenson: here we are not using the objectName to select the item, onlye the class name | 20:23 |
| elopio | what you see on the left side of the autopilot vis, on the tree. | 20:23 |
| elopio | is it MainView? | 20:23 |
| josharenson | elopio, no its my app name | 20:26 |
| balloons | o hai josharenson :- | 20:26 |
| josharenson | The object in my QML is MainView type though... | 20:26 |
| josharenson | hii | 20:26 |
| josharenson | I'll try renaming the qml file to MainView.qml? | 20:27 |
| elopio | josharenson: no | 20:27 |
| balloons | josharenson,what does the qml look like? | 20:27 |
| josharenson | yeah that seems dumb | 20:27 |
| elopio | that's one of the weird things that QML + autopilot have. | 20:27 |
| elopio | josharenson: can you send a screenshot of the qml tree from autopilot, just to be sure I send you the right code to add? | 20:28 |
| balloons | josharenson, the main qml file will have MainView specified | 20:28 |
| josharenson | http://pastebin.ubuntu.com/7743793/ | 20:28 |
| * josharenson getting screenshot | 20:28 | |
| balloons | josharenson, is that the entire file or just the top? | 20:28 |
| elopio | josharenson: what's the name of that file? | 20:28 |
| josharenson | the top... filename is SimplePerf.qml | 20:28 |
| balloons | josharenson, kk :-) yep, that looks like what we want to see | 20:29 |
| elopio | josharenson: yes, I think that if you remove | 20:29 |
| elopio | property real main_view_padding: units.gu(50) | 20:29 |
| elopio | the tree will show MainView instaed of SimplePerf. | 20:29 |
| elopio | I think you will have to do this: | 20:29 |
| elopio | on @property main_view, change it to | 20:30 |
| elopio | self.app.select_single(SimplePerf) | 20:30 |
| elopio | and under that, define a new class | 20:30 |
| elopio | class SimplePerf(emulators.MainView): | 20:30 |
| elopio | pass | 20:30 |
| josharenson | https://dl.dropboxusercontent.com/u/12477656/Screenshot%20from%202014-07-03%2013%3A29%3A29.png | 20:30 |
| * josharenson trying that | 20:31 | |
| elopio | josharenson: now, to see if I should modify the templates, did you change the MainView.qml file? | 20:31 |
| elopio | and what template are you using? | 20:31 |
| josharenson | Using the QML w/ Qt extension template | 20:32 |
| josharenson | elopio, what is the MainView.qml file? like the file that contains main view? | 20:32 |
| elopio | oh, right, it's called SimplePerf.qml, not MainView. Sorry. | 20:33 |
| elopio | josharenson: I'll make sure to update that template next week. | 20:33 |
| elopio | for now, lunch break. | 20:33 |
| josharenson | sure, thanks for the help | 20:33 |
| elopio | np. | 20:35 |
| josharenson | elopio the new class doesn't seem to work.. I'll keep messing with it... (same error except replace MainView with SimplePerf) | 20:37 |
| elopio | josharenson: hum hum. | 20:57 |
| elopio | it should work, according to your screenshot. | 21:01 |
| elopio | josharenson: if you push your project to a branch, I can give it a tyr. | 21:02 |
| elopio | *try | 21:02 |
| josharenson | ok | 21:02 |
| josharenson | elopio lp:~josharenson/+junk/SimplePerf/ | 21:03 |
| elopio | josharenson: you re defining the SimplePerf class inside the ClickAppTestCase | 21:19 |
| elopio | delete the leading spaces of that class, and you should be good to go. | 21:19 |
| elopio | almost | 21:20 |
| elopio | you are also missing the return on the @property method. | 21:21 |
| elopio | http://paste.ubuntu.com/7744035/ | 21:21 |
| josharenson | ah | 21:21 |
| josharenson | elopio, woot works.. thanks a lot | 21:22 |
| elopio | josharenson: no problem. | 21:23 |
| elopio | I'll be away for a while, but ping if you need more help with the tests. I'll check the backlog. | 21:23 |
| josharenson | elopio I'm about to head into the wilderness w/o internet for the weekend so no worries.. | 21:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
