[01:16] I am getting the following error when calling launch_click_package [01:16] http://pastebin.ubuntu.com/7739626/ [01:17] The app launches just fine, but it seems the return value is bad? [03:47] thomi: when you have a moment would you be able to review this please: https://code.launchpad.net/~veebers/autopilot/adding_screenshots_to_details/+merge/225423 [03:52] veebers, looking now [03:52] awesome, cheers [03:53] veebers: want feedback here, or in the MP? [03:53] thomi: in the MP please so I don't lose it :-) [04:19] veebers: you *really* need to mock/patch waaaay less [04:22] thomi: fair enough, do you have any suggested for that MP? [04:22] veebers: yes, lots [04:22] you might want to get a drink [04:23] thomi: heh, I'm ready when you are :-) [04:26] veebers: review posted [04:26] veebers: I'm happy to talk about it in person, if you need [04:27] thomi: sweet, I'll take a look and ping you in a couple of minutes once I've digested it? [04:27] sure [04:27] thomi: also, could I get you to eyeball this pre-req please: https://code.launchpad.net/~veebers/autopilot/logging-binary-attachments-1336109/+merge/225098 [04:31] thomi: all your comments make sense I don't think there is need for a call. I'll hit those points now [05:08] thomi: for detecting if the display is x11/mir and the platform module. That currently only gives us details like Desktop/device/tablet etc. I don't think it's enough to say "if is device then it's mir, desktop is x11" [05:08] thomi: do you have any better ideas than either the tests in that MP or the desktop==x11, not desktop=mir? [05:09] veebers: so, however you do the detection, the public api should be in the platform module.... [05:10] regarding detection for X11, is checking for $DISPLAY enough? Presumably your screenshot function needs that in order to work [05:11] WRT detecting mir, have you asked the mir team? My personal bet would be to try and find the mir socket, but that really only tells you that it's running *somewhere*, not necessarily in the current session [05:11] thomi: rats, I've lost the link, but I read a SO that said "xset q" was good, if a xset query fails than X isn't around [05:12] ah right: http://stackoverflow.com/questions/637005/x-server-running [05:14] veebers: xset reads $DISPLAY internally, and you have access to the X python bindings, I think we can do soemthing nicer than spawning a new process... [05:14] thomi: can you review this one please? [05:14] https://code.launchpad.net/~elopio/ubuntu-autopilot-tests/fix_packaging/+merge/225426 [05:14] thomi: ok, I'll look further [05:15] veebers: it'd be interesting to see what xset does under the hook [05:15] *hood [05:15] it seems that without the pybuild name, it tries to install in python3, instead of dist-packages. [05:15] veebers: but *at least* please protect that subprocess call with a functools.lru_cache :) [05:15] elopio: ahh, ok [05:16] elopio: approved [05:16] thomi: thanks. [05:16] now we have jenkins tests :D Lets see if they like it. === vila_ is now known as vila [20:16] elopio, I was able to modify all the templates to fit my project, but it still can't find my project's MainView [20:16] the only thing that is different is directory structure... any insight on how the search works? It can find other objects just fine if I commend out the MainView search part [20:17] josharenson: can you put a import pdb; pdb.set_trace() just before selecting the main view? [20:17] and then open autopilot vis [20:17] sure [20:17] it might be that you are extending main view, and it gets a different QML class name. [20:21] elopio, it hit the break point and I see the contents in vis [20:21] looking around [20:21] says object name is "mainView" [20:23] josharenson: here we are not using the objectName to select the item, onlye the class name [20:23] what you see on the left side of the autopilot vis, on the tree. [20:23] is it MainView? [20:26] elopio, no its my app name [20:26] o hai josharenson :- [20:26] The object in my QML is MainView type though... [20:26] hii [20:27] I'll try renaming the qml file to MainView.qml? [20:27] josharenson: no [20:27] josharenson,what does the qml look like? [20:27] yeah that seems dumb [20:27] that's one of the weird things that QML + autopilot have. [20:28] josharenson: can you send a screenshot of the qml tree from autopilot, just to be sure I send you the right code to add? [20:28] josharenson, the main qml file will have MainView specified [20:28] http://pastebin.ubuntu.com/7743793/ [20:28] * josharenson getting screenshot [20:28] josharenson, is that the entire file or just the top? [20:28] josharenson: what's the name of that file? [20:28] the top... filename is SimplePerf.qml [20:29] josharenson, kk :-) yep, that looks like what we want to see [20:29] josharenson: yes, I think that if you remove [20:29] property real main_view_padding: units.gu(50) [20:29] the tree will show MainView instaed of SimplePerf. [20:29] I think you will have to do this: [20:30] on @property main_view, change it to [20:30] self.app.select_single(SimplePerf) [20:30] and under that, define a new class [20:30] class SimplePerf(emulators.MainView): [20:30] pass [20:30] https://dl.dropboxusercontent.com/u/12477656/Screenshot%20from%202014-07-03%2013%3A29%3A29.png [20:31] * josharenson trying that [20:31] josharenson: now, to see if I should modify the templates, did you change the MainView.qml file? [20:31] and what template are you using? [20:32] Using the QML w/ Qt extension template [20:32] elopio, what is the MainView.qml file? like the file that contains main view? [20:33] oh, right, it's called SimplePerf.qml, not MainView. Sorry. [20:33] josharenson: I'll make sure to update that template next week. [20:33] for now, lunch break. [20:33] sure, thanks for the help [20:35] np. [20:37] elopio the new class doesn't seem to work.. I'll keep messing with it... (same error except replace MainView with SimplePerf) [20:57] josharenson: hum hum. [21:01] it should work, according to your screenshot. [21:02] josharenson: if you push your project to a branch, I can give it a tyr. [21:02] *try [21:02] ok [21:03] elopio lp:~josharenson/+junk/SimplePerf/ [21:19] josharenson: you re defining the SimplePerf class inside the ClickAppTestCase [21:19] delete the leading spaces of that class, and you should be good to go. [21:20] almost [21:21] you are also missing the return on the @property method. [21:21] http://paste.ubuntu.com/7744035/ [21:21] ah [21:22] elopio, woot works.. thanks a lot [21:23] josharenson: no problem. [21:23] I'll be away for a while, but ping if you need more help with the tests. I'll check the backlog. [21:27] elopio I'm about to head into the wilderness w/o internet for the weekend so no worries..