[03:43] <balloons> elopio, I was just working on this: https://code.launchpad.net/~nskaggs/ubuntu-ui-toolkit/add-popover-object-support/+merge/225404. Seems I found a bug; https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1336945
[03:43] <ubot5> Ubuntu bug 1336945 in Ubuntu UI Toolkit "ActionSelectionPopover doesn't close automatically" [Undecided,New]
[03:43] <balloons> i may ping you tomorrow about it.. buenos noches
=== salem_ is now known as _salem
[05:08] <elopio> balloons: I saw it. Thanks for working on it.
[08:57] <l3on> Hi all!.. I'm working on enabling autopkgtest for my (nodejs) packages.. I would make some "import-python-like" test...
[08:58] <l3on> The result is this commit: http://anonscm.debian.org/gitweb/?p=pkg-javascript/node-debug.git;a=commitdiff;h=d291750004417da5af9ef2d42a9d41d943771b15
[08:58] <l3on> you think everything is fine?
=== vila_ is now known as vila
=== zequence_ is now known as zequence
[11:46] <melodie> hi
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
[15:29] <balloons> good morning elopio.. you about?
=== chihchun is now known as chihchun_afk
[16:09] <elopio> balloons: just waking up.
[16:10] <balloons> elopio, well when you ready I have a couple things to ask you about and get help on :-)
=== roadmr is now known as roadmr_afk
[17:11] <balloons> pitti, still about?
[17:15] <elopio> balloons: ok, my meetings in coming to an end. How can I help you?
=== roadmr_afk is now known as roadmr
=== salem_ is now known as _salem
[17:19] <elopio> brendand: so my question was: if we have a py3-only project, should we stop doing all the weird things needed for py2, like inherit from object?
[17:24] <balloons> elopio, the other piece I wanted to chat about is rssreader and namely ActionSelectionPopover and the helper
[17:25] <elopio> balloons: ok.
[17:26] <balloons> elopio, I was investigating this failures from rss reader; and I got to playing with the popup helper. It needs some love as it's still using text to find and click. So I started an mp for it.
[17:27] <elopio> I'm looking at it.
[17:27] <balloons> you can see the failures here; http://91.189.93.70:8080/job/generic-mediumtests-utopic/822/testReport/junit/shorts_app.tests.test_rssreader/TestMainWindow/test_add_feed_to_new_topic_with_mouse_/
[17:27] <balloons> basically the autoclose check code fails because it's already closed in jenkins. Seems fine on desktop and phone.
[17:27] <elopio> balloons: well, your branch is failing due to pep8
[17:27] <balloons> I also had some fun with Tim, but we arrived at a solution to your old bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1205144
[17:27] <ubot5> Ubuntu bug 1205144 in Ubuntu UI Toolkit "We can't set the objectName to a ActionSelectionPopover Action" [Undecided,Confirmed]
[17:28] <balloons> so in the interim, I'm going to catch the dbus error I think so rssreader can land and continue to run
[17:29] <balloons> then I'll fix up popups.py and finish the merge for it
[17:30] <elopio> balloons: I'm not getting the problem. The pop up is not closing when it should, is that it?
[17:30] <balloons> elopio, well it's kind of a long story.. and since I figured it out with tim this morning, I didn't go into details.
[17:30] <balloons> yesterday I discovered that setting up an actionselectpopover as instructed didn't autoclose
[17:31] <balloons> turns out the example shows using listitem, which is a non-default delegate.
[17:31] <elopio> oh, I see. We do if self.autoClose and that can fail if the popover is already deleted from the tree.
[17:31] <balloons> a non-default delegate will not autoclose. But if I use the default delegate, I can't set objectnames, aka your old bug. Tim reminded me of using the objectname+item trick
[17:32] <balloons> elopio, yes.. the popover object is gone, but you still check the property outside a try/catch
[17:32] <elopio> balloons: yes, so please move that inside the try on your branch :)
[17:32] <elopio> balloons: another thing from your branch
[17:32] <elopio> 56	+ if button is None:
[17:32] <elopio> 57	+ raise _common.ToolkitException(
[17:32] <elopio> 58	+ 'Button with text "{0}" not found.'.format(text))
[17:33] <balloons> anyways, I'll try and fix everything up.. I was going to ask for help in getting rss reader fixed up in the interim, but discovered all this new info before you awoke ;-)
[17:33] <elopio> that's old autopilot. Now select_single will raise an exception instead of returning None.
[17:33] <balloons> elopio, ahh good catch!
[17:34] <elopio> balloons: well, you will need tests to all the new things you are adding before merging, so they would have caught that anyway.
[17:34] <elopio> :D
[17:34] <elopio> let me know if you need a hand with the self-tests.
[17:34] <balloons> yes, I left a comment about needing tests before someone else did it ;-)
[17:34] <elopio> other than that, looks pretty good.
=== _salem is now known as salem_
[17:34] <balloons> it was quick hack while I was trying to debug rss reader.. so I figured I'd just turn it into an mp
[17:40] <balloons> ohh elopio one more quick thing.. Should I leave click_button_by_text in that mp? we don't support that idea in other places
[17:42] <elopio> balloons: yes, because otherwise you'll break tests.
[17:42] <balloons> elopio, legacy legacy.. ok :-)
[17:42] <elopio> please add a logger.warn('This is dreprecated, please use this other one.')
[17:42] <balloons> right.. perfect
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem