=== _salem is now known as salem_ === salem_ is now known as _salem [07:47] Saviq, you know what is blocking input events under the osk in unity? [07:47] otherwise I'll try to dig [07:48] Cimi, the InputArea in OSK [07:48] in OSKController that is [07:48] Saviq, so why doesn't work in wizard? [07:50] Cimi, did you even look in OSKController? did you check what doesn't work? [07:51] mzanetti, please keep an eye on © dates, in new files [07:51] there's 2012,2013 in the lights plugin.h [07:52] meh... [07:52] Saviq, I will try to look for bugs [07:52] I told hom twice [07:52] Saviq, anyway in Shell.qml we have deprecated code then [07:52] Saviq, the MouseArea responding to ApplicationManager.keyboardVisible can be removed [07:52] Cimi, no it can't [07:53] Cimi, that one blocks input *within* the shell [07:53] Cimi, so now that you mention this [07:53] Saviq, ApplicationManager.keyboardVisible does not exist [07:53] Cimi, ah ok [07:53] Cimi, OSKC took that over [07:54] Cimi, what do you mean "you'll try to look for bugs"? [07:55] Saviq, in the OSKController [07:55] k [07:57] is it possible that in the wizard, the surface does not change to MirSurface.Maximized? [07:57] Cimi, you should close your IRC client when working [07:58] Saviq, it's a valid question because I don't know mir [07:58] neither OSK [07:59] Cimi, it's easy to check, too [07:59] Cimi, it's just one console.debug line in that file [07:59] Cimi, which you can even edit on device [07:59] Saviq, well the answer is yes, don't have to debug that [07:59] Saviq, my question was more why this happens [07:59] just on the wizard [07:59] Cimi, you typed more to ask the question than to check yourself [08:00] mhr3, something dawned on me... how do we deal with dark/light foreground color (on cards with background)... [08:00] start reading mir code? :) [08:01] Cimi, no, check what happens in OSKC [08:01] Cimi, whether everything there behaves as expected [08:01] Cimi, if not, you'll at least know which part is responsible [08:01] I checked, this is the only thing that enables the inputarea [08:02] Cimi, how about its size [08:02] Saviq, hm, scope can specify the overlay background as well, can§t it_ so it§s problem [08:02] eh [08:02] mhr3, not overlay [08:02] mhr3, background [08:02] mhr3, like in scopes [08:02] that could be as well indeed [08:03] mhr3, and well, same for overlay colour, once we allow different overlay colours, we'll need to make the "dark or light" decision on the colour as well [08:04] mhr3, and this decision assumes that foreground colour is dark, and goes to white if background is dark [08:04] mhr3, but if foreground colour is light (because scope background is dark)? [08:05] we *could* check the foreground colour and fall back to white/grey accordingly [08:05] just wondering if we should supply both dark and light foreground colours [08:05] (or scope should) [08:06] mhr3, it's probably not even a question to you ;) [08:06] Saviq, eh, give me a moment, you love pinging me during our morning meeting :) [08:06] mhr3, lol [08:50] Saviq: re: Text field itself, back and clear buttons should be exempt from tap-to-dismiss behaviour of the popup and activate instantly. [08:50] Saviq: how would that work? The Popover has the InverseMouseArea integrated [08:53] Saviq, so seems you know what has to be done ultimately :) [08:54] Saviq, glad to be your debugging duck ;) [08:54] mhr3, you mean "to ask design"? ;) [08:54] mzanetti, yeah, but I thought you could tweak it [08:54] mzanetti, we did that before [08:55] hmm... I just copied the Popover as it was in the previous code [08:55] mzanetti, hmm seems like we lost the code [08:55] mzanetti, because the behaviour change [08:55] d [08:56] mzanetti, please check with timp whether that's possible [08:56] mzanetti, I think what we had is we had our own IMA covering more than just the popover... and maybe disabled the popover IMA? [08:57] mzanetti, don't remember now, but with the new behaviour (history as type-ahead search), we'll need that badly [08:59] Saviq: could you do a an update for silo 15? lp:~nick-dedekind/unity-mir/trusted-sessions [09:03] dednick, ah you just need a rebuild? [09:04] Saviq: if that pulls down the latest from the branch. [09:04] dednick, yup, it does, kicked [09:04] Saviq: thanks === vila_ is now known as vila [09:10] Saviq: you really wanna get rid of the clear history button? [09:10] mzanetti, that's not a "clear history" button, just a "close history" one [09:11] oh right... [09:11] dropping === shiznix_ is now known as shiznix [09:24] mzanetti, you had the uitk pkgs with the necessary header changes? [09:24] mhr3: one sec [09:24] [15:38] https://chinstrap.canonical.com/~mzanetti/qtdeclarative5-ubuntu-ui-toolkit-plugin_0.1.47+14.10.20140618-0ubuntu1_amd64.deb [09:24] [15:38] https://chinstrap.canonical.com/~mzanetti/ubuntu-ui-toolkit-theme_0.1.47+14.10.20140618-0ubuntu1_amd64.deb [09:24] [15:38] * mzanetti hopes you use amd64 [09:24] mhr3: ^ [09:25] thx [09:26] * mhr3 just wgetting some html :P [09:43] Saviq, so UbuntuKeyboardInfo does not connect to the socket [09:43] Cimi, do you see error messages on its console? [09:43] "QLocalSocket::connectToServer: Connection refused" [09:44] Cimi, and is the keyboard launched along with the wizard or somewhen later? [09:44] Saviq, I see this after creating the mir surface [09:45] so I'd say at wizard startup [09:45] Cimi, no, you see this after instantiating OSKController [09:45] at wizard startup [09:45] Cimi, which uses UbuntuKeyboardInfo [09:45] since it's in main.qml [09:45] Cimi, but that doesn't answer my question [09:45] Cimi, it's the keyboard that creates the socket [09:45] it is launched in main.qml [09:45] like, OSKController is in the main.qml [09:45] Cimi, maliit is launched in main.qml? [09:46] no in the upstart [09:46] let me see when [09:46] Cimi, that was my question [09:46] Saviq, in post-start [09:46] might move to pre-start [09:47] Cimi, no you can't [09:47] ok [09:47] Cimi, as it will die 'cause it couldn't connect to mir [09:48] Cimi, you need to check if the keyboard creates the socket [09:50] * Cimi builds unity-mir [09:51] why? [09:51] Cimi, it should be in /run/user/32011/ [09:51] /run/user/32011/ubuntu-keyboard-info [09:51] if it's not there, but is in /tmp/ubuntu-keyboard-info [09:52] means maliit doesn't get XDG_RUNTIME_DIR set in time [09:52] Saviq, to debug [09:52] Saviq, it's in run/user [09:53] Cimi, I'm not getting the keyboard error messages in ~/.cache/upstart/ubuntu-system-settings-wizard.log [09:54] Saviq, grep -rn UbuntuKeyboardInfo /home/phablet/.cache/upstart/ [09:55] nothing? [09:55] Cimi, no [09:55] ugh [09:55] Saviq, so you don't have this? https://bugs.launchpad.net/ubuntu-welcome-wizard/+bug/1334429 [09:55] Ubuntu bug 1334429 in Ubuntu Welcome Wizard "touch event allowed through OSK to what is underneath" [High,New] [09:56] Cimi, wizard just crashed for me when I tried this [09:56] Saviq, that was another bug [09:57] Saviq, https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1334203 [09:57] Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,New] [09:58] Cimi, yeah, so seems I do have the bug, if the back button is causing it [09:58] Saviq, which means the events pass through [09:58] Cimi, yes, but the cause looks different than what you found [09:59] Saviq, in my case, UbuntuKeyboardInfo width and height is 0 [10:02] Cimi, I got one 'UbuntuKeyboardInfo - socket error: "QLocalSocket::connectToServer: Connection refused"' now [10:02] Cimi, but it retries [10:02] Cimi, and connects fine again [10:02] Saviq, if you want to add console.log("oskSurface state changed", ubuntuKeyboardInfo.height, ubuntuKeyboardInfo.width); [10:02] in /usr/lib/arm-linux-gnueabihf/unity8/qml/Unity/Application/OSKController.qml [10:02] at the last connection near end of file [10:03] Cimi, you'd have more of those warnings, and then an ultimate "failed to connect" if it really failed to connect [10:03] ah ok [10:03] so different indeed here [10:10] Cimi, btw, wizard-has-run is created too early IMO [10:10] Cimi, it should only be created after the wizard completed [10:10] Saviq, it is [10:10] Saviq, post-stop [10:10] Cimi, does it check the exit code? [10:10] no [10:11] Cimi, it should [10:11] it's in upstart [10:11] Saviq, what about wizard keeps crashing and you cannot boot? [10:11] I understand both ways [10:11] Cimi, a bit extreme, but maybe [10:12] Saviq, we can echo the exit code in the wizard-has-run [10:13] Cimi, oh and also, SIM page should probably be optional on devices where there isn't a modem at all [10:13] Saviq, and like redo the wizard at boot if contains just 1 invalid error code [10:13] Saviq, I know this [10:13] k [10:13] Saviq, but need to hack on ofono for that [10:14] (and add api to expose number of modems) [10:15] Saviq, once 004 finishes migrating, am i green to rebuild and land 005? or do you have more landings and would like to combine them? [10:16] mhr3, maybe we should indeed [10:16] Saviq, fine with me, it's nicely isolated change [10:17] Cimi, I added some qml debugs and everything works as expected [10:18] in OSKController at least [10:19] Saviq, so, feel free to add more mps to 005... or if you want to merge it with like 009, then perhaps the other way around [10:19] Saviq, UbuntuKeyboardInfo is still 0 0 width height [10:19] Cimi, here's my OSKController [10:19] http://paste.ubuntu.com/7741264/ [10:20] Saviq, and what does it print for you? [10:21] Cimi, http://pastebin.ubuntu.com/7741273/ [10:21] dednick, btw the package built in silo 15 [10:21] Saviq: thanks! === zequence_ is now known as zequence [10:30] mzanetti, .length will complain if imageSource is not a string [10:31] mzanetti, result the same, but less warnings [10:31] mhm... so given that imageSource is defined as property string... is there a difference? [10:31] hmm right [10:32] mzanetti, probably no diff, maybe better readable [10:32] no problem anyways [10:32] yeah. imo the .length is the more readable one... [10:32] but really no strong opinion [10:32] was just curious if I really miss a technical detail [10:32] mzanetti, I probably come from python, where you rely on boolean infers a lot [10:33] yeah, I don't like that at all... but again, no problem at all. I can deal with both [10:33] Saviq, it is not positioned correctly [10:33] Saviq, it seems like it has space at the bottom [10:33] Cimi, panel height maybe? [10:33] more [10:33] I think [10:33] let me see in unity [10:33] Saviq, I put a nice Rectangle on the input area :) [10:34] Cimi, yup [10:36] Saviq, and I disccovered a bug in unity :) [10:36] Saviq, the very bottom edge of the keyboard passes through [10:36] in unity as well [10:36] Cimi, you can pat yourself on the back, well done [10:37] ;P [10:37] it is just not as bas as the wizard [10:37] Saviq, I tried moving a dash app at the bottom of the screen, like gallery app [10:37] Saviq, open a search [10:37] Cimi, you don't have to explain the bug to me [10:37] and tap between the spacebar and the edge [10:37] ok [10:38] Cimi, either file it as a bug or, better yet, fix it! [10:38] Saviq, I need some thoughts on this [10:38] so let me ask [10:39] the input area should be taller than the keyboard, otherwise we cannot dismiss by swiping down, right? [10:42] gosh... we have a very bad mix of onClicked, onTriggered, onPressed [10:42] all doing the same thing [10:43] Cimi, not sure, I think the keyboard only has something like 1gu near the top [10:43] Cimi, doesn't actually go out of the keyboard rectangle [10:44] I see those info coming from ubuntu-keyboard [10:44] on portrait, it is misplaced of 1 panel height up [10:44] (it is roughly 1 panel height) [10:44] on landscape, is fine [10:45] before digging, I need to understand one thing [10:45] - is this filter area supposed to extend also to the dismiss area on top of the keyboard? [10:46] (I think so, but currently it is not) [10:46] because uses UbuntuKeyboardInfo that has keyboard dimensions [10:47] ubuntu-keyboard provides the area, now there could be a bug there or in mir itself [10:49] Saviq: look at that :D [10:49] mzanetti, k, one minor thing in new-header [10:49] if (searchTextField.text) { [10:49] this doesn't work ^^ [10:49] while this does: if (searchTextField.text.length == 0) { [10:49] mzanetti, you're missing a ! [10:49] lol [10:49] if you're comparing to 0 [10:50] I guess I need a break [10:50] btw. still fixing the non-inline comments [10:50] mhm [10:50] mzanetti, the dash failures are weird, they seem to come and go on jenkins [10:51] yeah, will look into that [10:53] Cimi, I don't think there's a dismiss area "on top" of the keyboard [10:53] Cimi, there's only the 1GU padding you have above the keys [10:54] Saviq, ok right indeed [10:54] Saviq, so the y in the socket is wrong in portrait [10:55] Cimi, here's the MP that dealt with that [10:55] https://code.launchpad.net/~dandrader/ubuntu-keyboard/improve_kbd_info_ipc/+merge/190418 [10:55] I'm looking at ubuntu-keyboard [10:56] Cimi, not sure I can confirm your findings, though - I added a rectangle here, too, and it covers the whole bottom of the screen correctly [10:56] Saviq, in portrait? [10:56] Cimi, yes [10:56] on mako> [10:56] not here [10:56] Cimi, on flo actually, let me try on mako [10:58] Cimi, looks fine on mako, too [10:59] Cimi, maybe you're seeing http://bazaar.launchpad.net/~mir-team/unity-mir/trunk/revision/238 ? [10:59] Cimi, or well I meant https://code.launchpad.net/~afrantzis/unity-mir/fix-1332624-input-area/+merge/224768 [11:00] Cimi, that was released yesterday [11:00] Cimi, https://bugs.launchpad.net/unity-mir/+bug/1332624 [11:00] Ubuntu bug 1332624 in unity-mir "cant' swipe the keyboard away anymore" [Critical,Fix released] [11:00] let me upgrade [11:02] Cimi, hah [11:02] Cimi, it moved after typing [11:04] Cimi, and yeah, it's panel-height [11:05] it was moving immediately for me [11:05] anyway [11:05] doesn't matter [11:05] in wizard is like double panel height [11:05] Cimi, was one panel height for me [11:05] that's why it is possible to tap on back button underneath [11:06] Saviq, weird - with the today image I have no bug [11:06] let me see in wizard [11:06] Saviq, did the rectangle move after typing in unity8? [11:06] Cimi, no [11:07] Saviq, unity8 is fine for me with 111 image [11:07] Cimi, yeah, so that but above [11:07] Saviq, wizard is 1 panel height shifted [11:08] Cimi, while in wizard panel isn't taken into account [11:08] but what is setting the panel [11:08] unity-mir [11:08] but OSK surface should be fullscreen [11:08] panel shouldn't matter [11:09] status is maximised [11:09] not fullscreen [11:09] yeah [11:09] Cimi, [11:09] there's an explicit topMargin in OSKController in Shell.qml [11:10] Cimi, that should've been a hint [11:11] Saviq, ok yeah sounds like it [11:11] Saviq, it is hardcoded or what? [11:11] Cimi, yes it is [11:11] in unity mir? [11:11] I could get the panel height from ApplicationManager in Unity.Application [11:11] Cimi, there, and in Panel.qml [11:12] (maybe) [11:12] but wizard should not look into unity8 [11:12] Cimi, panelHeight: units.gu(3) + units.dp(2) [11:12] Cimi, with a FIXME that this shouldn't be hardcoded [11:12] I can copy that as topMargin? ;\ [11:12] Cimi, yeah [11:13] Cimi, I agree OSK should communicate global coords [11:13] Cimi, and that's worth a bug [11:13] Cimi, but a quick fix is just to copy that === MacSlow is now known as MacSlow|lunch [11:13] Saviq, thanks [11:17] Saviq, wrt SettingsModelInterface, shouldn't it have a isEmpty / rowCount prop? so you can do showSettingsButton: !scope.settingsModel.isEmpty [11:18] mhr3, yeah, count, forgot that's not Q_PROPERTY by default... [11:18] Saviq, or do you consider scope.settingsModel being null enough? [11:18] mhr3, I'd probably like both [11:19] Saviq, so where is the bug then? unity mir or ubuntu keyboard?> [11:19] Cimi, keyboard [11:19] Cimi, and unity8 [11:19] unity8?? [11:24] Holas [11:26] o/ [11:26] Cimi, unity8 should not have the margin applied there [11:26] ah sure [11:26] yes [11:26] /food [11:27] * mzanetti thanks init for cleaning up his window mess === alan_g is now known as alan_g|lunch === MacSlow|lunch is now known as MacSlow === _salem is now known as salem_ [12:53] mzanetti, remember we'll need to bump the UITK dependency [12:54] mzanetti, but we need to wait until silo 4 lands & merges finally [12:58] Saviq, are there plans to resurrect grid-see-more branch? i'd kinda need that so we can have the new section header queries [13:00] mhr3, yeah, there are [13:00] mhr3, the string needs to come from scope, though [13:00] mhr3, and we need to add a sticky footer [13:00] Saviq, what string? [13:00] mhr3, "show more" / "show all" [13:00] oh? [13:00] why? [13:01] l [13:01] f*cking multi-monitor [13:01] mhr3, because it's meant to be "show more" or "show all", depending on what it will actually do [13:01] greyback_, ah so that's why we know your password? [13:01] Saviq, it will be just all for now, no need for more imo [13:01] Saviq, unless you decide to chunk it [13:01] mhr3, tell Mike that [13:01] Saviq: you know an old password... [13:01] mhr3, no no, it's more because it can't display all [13:01] greyback_, I know I know [13:02] mhr3, not because pressing it will display less than show all would [13:02] gnome-terminal's cursor flashes even when its window does not have focus. So annoying [13:02] greyback_, hmm? [13:02] greyback_, not here it doesn't [13:02] does here. [13:02] greyback_, I get a hollow rectangle when unfocused [13:03] * greyback_ digs into settings [13:03] greyback_, I'm using byobu + bash, maybe zsh doesn't deal with that well? [13:03] Saviq: maybe [13:03] Saviq, afaik there are no plans to be able to do offsetted queries, so i'm not sure now [13:03] greyback_, same behaviour without byobu [13:04] mhr3, again, it's not about what we can display in dash [13:04] mhr3, it's about what we can't [13:04] Saviq: for me same bad behaviour with bash [13:04] mhr3, if the max you can display in dash is not "all" (because of, say, API), then "show more" is meant to be shown [13:05] mhr3, let's confirm with Mike [13:05] Saviq, yea, that's the first time i hear this tbh [13:05] Saviq, in spec? [13:05] mhr3, yeah... no [13:05] mhr3, well, in multiple specs [13:05] sigh [13:05] mhr3, some say "more", some say "all" ;) === alan_g|lunch is now known as alan_g [13:14] NOW MIGRATE ALREADY! [13:22] * Saviq can die now [13:36] dednick, please merge trunk into lp:~nick-dedekind/unity8/move-indicator-qml [13:39] Saviq: doing [13:39] dednick, thanks [13:48] Saviq: done [13:49] dednick, tx [13:52] Saviq, is u8 trunk not merged with ubuntu? [13:53] mhr3, it's not [13:53] mhr3, I'll prep an MP shortly [13:53] mhr3, why? [13:53] landing bot complaining [13:53] https://ci-train.ubuntu.com/job/landing-013-1-build/55/console [13:54] mhr3, ah you're landing that separately? [13:54] mhr3, I added it to my silo [13:54] mhr3, lemme prep the mP [13:57] Saviq, imo should just push the fix to trunk, we said the two should be always in sync [13:57] mhr3, yeah ok, doing [13:58] Saviq, when was the last time you just pushed to trunk anyway, doesn't it sound exciting? :) === pete-woods is now known as pete-woods-lunch [13:59] mhr3, done [13:59] ty [14:05] Cimi: hey, where does the welcome wizard print its logs? I can't find it in .cache/upstart or /var/log/upstart [14:14] greyback_, ~/.cache/upstart/ubuntu-system-settings-wizard.log [14:15] Cimi: ah, forgot the ubuntu- prefix. thanks [14:15] l [14:16] greyback_, what are you looking? [14:16] Cimi: welcome wiaard needs some changes to make compatible with QtCOmp [14:16] Cimi: I've them done, just wanted to check things are ok [14:17] Cimi: I'm not seeing any wifi networks in the list, any idea how I could debug? [14:18] greyback_, we had this issue once, was due to initialisation errors of the indicators [14:18] maybe mterry knows [14:18] Cimi, I don't recall *why* it was happening -- I believe it went away for us by starting indicators differently -- instead of just the network-indicator, we did the general indicator startup [14:19] greyback_, do you hae wireless in Ireland? [14:21] lol [14:27] Saviq, could you jump into the meeting 5 minutes earlier? got few Qs [14:27] the one in 30ish minutes [14:31] mhr3, prolly yes === salem_ is now known as _salem === alan_g is now known as alan_g|tea [14:40] greyback_: did the wifi list show up after you touched it ? [14:40] kgunn: reboot fixed it [14:40] i saw the same bug last week...any interaction populated the list [14:40] ah [14:42] Cimi: mterry: ever seen this crash? http://pastebin.ubuntu.com/7742229/ - I reproduce reliably with my code, when I go to list of networks (one already selected), then hit back [14:42] greyback_, someone filed a bug with that, yea [14:42] mterry: ok [14:43] greyback_, haven't looked at it yet [14:43] somebody needs to do a landing with https://code.launchpad.net/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203/+merge/225063 [14:43] mterry, ^ I think that might be the fix for that issue [14:43] https://bugs.launchpad.net/qmenumodel/+bug/1334203 [14:43] Ubuntu bug 1334203 in ubuntu-system-settings (Ubuntu) "ubuntu-system-settings-wizard crashes/freezes when using the back button" [High,New] [14:43] mterry: no worries, just checking it wasn't consequence of my changes [14:43]