| hatch | huwshimi hey | 04:30 |
|---|---|---|
| huwshimi | hatch: Hey | 04:33 |
| hatch | thanks for the comment | 04:33 |
| hatch | unfortunately that means I have to re-write a bunch of stuff...lol | 04:35 |
| hatch | but it's a lot nicer approach | 04:35 |
| huwshimi | hatch: No problems. We seem to be heading in the direction of using these state classes for all our "widgets" that have multiple states. I figure it'd be good to stay consistent. | 04:35 |
| huwshimi | hatch: Yeah, I know it's a bit of a pain | 04:35 |
| hatch | so, the idea then is that any time there is a state change in the UI we wlll add a new class and appropriate nested stuff | 04:36 |
| hatch | that was a question | 04:37 |
| hatch | :) | 04:37 |
| huwshimi | hatch: Well, swap out the state class, but yeah, I think this approach would work | 04:38 |
| hatch | ok cool | 04:39 |
| huwshimi | hatch: I'm pretty sure it was your idea :) | 04:40 |
| hatch | lol this last little while has been nuts | 04:40 |
| hatch | yay me? | 04:40 |
| hatch | nah, yay you! | 04:40 |
| hatch | so my comment https://github.com/juju/juju-gui/pull/424 is because objects keys aren't in any order | 04:41 |
| hatch | so just because you add two things in a row in an object doesn't mean they will be in that order | 04:41 |
| hatch | it's likely that they will be in order but there is no guarantee | 04:42 |
| hatch | only arrays are guaranteed to be in order | 04:42 |
| huwshimi | hatch: Yeah, but if we build this list in the dom based on the list of keys and then grab the first key to select the first item it seems to maintain the order | 04:42 |
| hatch | it does, but it's not guaranteed | 04:43 |
| hatch | you can make two loops through an object's keys and get them in two different orders | 04:44 |
| hatch | if we only have it in that format then it's the way it's got to be | 04:44 |
| huwshimi | hatch: Yeah, I get that, I guess the other way to do it would be to grab the id off the first token in the dom | 04:45 |
| hatch | well...what do you think? | 04:45 |
| hatch | is there any real issue in selecting one that's not the first? | 04:46 |
| huwshimi | hatch: Only that it would be weird to have a machine that is not at the top of the list selected by default | 04:46 |
| hatch | well I'll leave it up to you :) | 04:47 |
| huwshimi | hatch: I can grab it from the dom, that would always do the right thing. | 04:47 |
| hatch | ok cool | 04:48 |
| huwshimi | hatch: I called out the state classes when I landed my branch, but I'll try make sure it's clearer next time so the person picking up the work can see them. | 04:56 |
| hatch | cool | 04:57 |
| hatch | huwshimi ok I'm taking off, have a good night | 05:10 |
| huwshimi | hatch: Night! | 05:11 |
| === uru-afk is now known as urulama | ||
| === rogpeppe2 is now known as rogpeppe | ||
| rogpeppe | frankban: up for continuing? | 08:33 |
| frankban | rogpeppe: morning, sure! | 08:34 |
| rogpeppe | frankban: i'm in the standup | 08:34 |
| === rogpeppe is now known as rogpeppe1 | ||
| === urulama is now known as uru-brunch | ||
| === uru-brunch is now known as urulama | ||
| rogpeppe | frankban: back | 10:20 |
| rick_h__ | morning party people | 11:11 |
| rick_h__ | frankban: if you get a sec can I get the low down on the reproduction steps for the bug in quickstart you guys fixed against 1.20? We're working on trying to figure out some sort of CI | 11:14 |
| rick_h__ | frankban: and curious why we didn't hit that bug in normal use of quickstart against dev releases | 11:15 |
| frankban | rick_h__: welcome back | 11:15 |
| frankban | rick_h__: `chat? I am in the daily hangout | 11:15 |
| rick_h__ | frankban: help, tie me down before I run away! | 11:15 |
| rick_h__ | frankban: sure thing | 11:15 |
| * frankban lunches | 11:24 | |
| rick_h__ | rogpeppe: frankban email forwarded to peeps from carla about bundle details per the call last week with bac and I and UX. | 11:31 |
| rogpeppe | rick_h__: thanks | 11:32 |
| rick_h__ | rogpeppe: frankban just as an fyi on some data UX needs for bundles eventually in case any of it fits current WIP. | 11:32 |
| rick_h__ | rogpeppe: bac frankban make sure to check out https://github.com/juju/juju/pull/250 and provide any feedback we have on the style guide. | 12:04 |
| rick_h__ | if approved and landed it's something we should be aware of and pick up I think. | 12:05 |
| urulama | rick_h__: where should i put the card for bug 1339005 ... maintenance/review? | 12:08 |
| rick_h__ | urulama: looking | 12:08 |
| rick_h__ | urulama: ok, so just file it and I'll traige and add a card. | 12:08 |
| rick_h__ | urulama: I'll add it to the on deck backlog for maintenacne | 12:09 |
| rick_h__ | maintence | 12:09 |
| rick_h__ | bah | 12:09 |
| rick_h__ | urulama: we only use high and low importances. If it's high, we should try to fix it, if it's low, we ack it but don't promise to get to it any time soon (really ever) | 12:09 |
| rick_h__ | urulama: when you get time let's catch up | 12:11 |
| rick_h__ | jrwren: same ^ | 12:11 |
| bac | morning | 12:11 |
| rick_h__ | morning bac, made it to NC safely? | 12:12 |
| urulama | rick_h__: i'm gonna pick up my kids in 45min, change location. is 10AM ok for you? | 12:13 |
| rick_h__ | urulama: party | 12:14 |
| rick_h__ | urulama: I mean yes :) | 12:14 |
| === urulama is now known as uru-afk | ||
| bac | rick_h__: eventually. our original flight went through with no problems on friday but i'm still glad we postponed. the thought of getting stuck in ATL was unpleasant. | 12:21 |
| rick_h__ | bac: hah, not a fan of our great south? :P | 12:21 |
| bac | rick_h__: not a fan of sleeping in any airport | 12:23 |
| rick_h__ | bac: good call | 12:23 |
| === uru-afk is now known as urulama | ||
| frankban | rogpeppe: I am back, please ping me when you are ready | 12:27 |
| rogpeppe | frankban: will do. currently perusing rick_h__'s comments | 12:27 |
| frankban | rick_h__: thanks for the link/email | 12:29 |
| frankban | rick_h__: machine/unit counts can be easily calculated by clients IMHO, agree with you re: owner details, the current spec allows for easily adding customized API later | 12:30 |
| rogpeppe | frankban: i'm in the hangout, BTW | 12:33 |
| rick_h__ | frankban: yea, maybe I'm getting ahead of myself. I have this fear that those counts will be filter/selection criteria for searches | 12:39 |
| rick_h__ | frankban: but they're not currently so you're right, for display purposes they can be client side calc'd | 12:39 |
| bac | rick_h__: wanted you to be aware of bug 1316174 -- it affects users on precise trying to bootstrap local envs. it's a juju-core issue but affects quickstart | 12:45 |
| _mup_ | Bug #1316174: 'precise-updates/cloud-tools' is invalid for APT::Default-Release <juju-core:Triaged> <https://launchpad.net/bugs/1316174> | 12:45 |
| rick_h__ | bac: looking | 12:47 |
| hazmat | did we loose the ability to hide subordinate relation lines? | 12:47 |
| hazmat | looks like we draw in gray with the little box to the side of the sub service, we used to be able to click the box and hide the sub rel lines, but it hasn't seem to worked in a while. | 12:48 |
| rick_h__ | hazmat: yes, we're supposed to be getting to controlling it with the deployed service inspector | 12:48 |
| rick_h__ | hazmat: is the box still there? /me goes to try it out, been a while. | 12:48 |
| hazmat | rick_h__, yes its still there | 12:48 |
| rick_h__ | hazmat: what UI box is there to hide then? | 12:49 |
| rick_h__ | them? | 12:49 |
| rick_h__ | bac: :/ ok. Will make sure it's brought up. | 12:50 |
| rick_h__ | frankban: rogpeppe is there a card on the board for the current WIP? | 12:51 |
| frankban | rick_h__: no, I'll create one, thanks | 12:51 |
| rick_h__ | frankban: ty much | 12:51 |
| hazmat | rick_h__, off subordinate services there is a ... line to a subordinate count box, that box is supposed to toggle display of that's sub service's relation lines | 12:53 |
| rick_h__ | hazmat: ah ok. checking existing bugs now. | 12:54 |
| jrwren | rick_h__: you around in 10m? | 12:55 |
| rick_h__ | jrwren: on a call but can ping when I get off | 12:55 |
| jrwren | perfect | 12:55 |
| hazmat | rick_h__, don't think there is one.. its been broken for a long time (at least 6months). | 12:56 |
| rick_h__ | hazmat: right, I know we've talked a lot about showing/hiding lines including subordinates and we've got work this cycle to allow it with all services | 12:56 |
| rick_h__ | hazmat: I'll file a bug and see if there's a quick fix, some code that's not getting run or if it's actually been removed | 12:57 |
| hazmat | rick_h__, ok | 12:58 |
| rick_h__ | hazmat: https://bugs.launchpad.net/juju-gui/+bug/1339029 | 12:58 |
| _mup_ | Bug #1339029: show/hide a subordinate relation line not functioning <juju-gui:Triaged by makyo> <https://launchpad.net/bugs/1339029> | 12:58 |
| rick_h__ | hazmat: will ask mayko to take a peek at it and see if it's something we can hook back up easily | 12:58 |
| hazmat | rick_h__, even if there's a long term thought on rel display, subordinates are a special case given their cross cutting concerns in an env, ie. is has 6-8 subordinate rels to every service. | 12:59 |
| hazmat | rick_h__, cool, thanks | 12:59 |
| rick_h__ | hazmat: the work to show/hide any rel line is scheduled late into the cycle so won't be updated soon. | 12:59 |
| rick_h__ | hazmat: right, the idea is that you can show/hide the blocks and lines for any service in an environment | 12:59 |
| rick_h__ | luca: add a call to the meeting? | 13:01 |
| luca | rick_h__: forgot, doing it now | 13:01 |
| luca | rick_h__: https://plus.google.com/hangouts/_/canonical.com/jaas-catch-up?authuser=1 | 13:01 |
| rick_h__ | luca: ty much | 13:01 |
| urulama | jrwren: regarding the sprint in London - heard you're really close to rick_h__ (what's a 100km in usa ;)) , so, if calls would not suffice, you can probably just meet and get over details, so, don't worry about the sprint | 13:02 |
| * urulama needs to pick up the kids now | 13:03 | |
| rick_h__ | jrwren: ping | 13:46 |
| jrwren | pong | 13:46 |
| rick_h__ | jrwren: meet in the standup hangout? | 13:46 |
| jrwren | yes | 13:46 |
| rick_h__ | whoops, others are there | 13:47 |
| jrwren | new room? | 13:47 |
| rick_h__ | yep, getting invite together | 13:47 |
| rick_h__ | https://plus.google.com/hangouts/_/g6xwjb53dpltyqiu66zdkmpnvma?authuser=1&hl=en | 13:47 |
| rick_h__ | change the authuser part of the url to your own google accounts | 13:48 |
| jcsackett | hey, hatch__, i've pushed up all the work from yesterday we discussed. can you take a look? https://github.com/juju/juju-gui/pull/422 | 13:51 |
| hatch__ | you bet | 13:51 |
| hatch__ | odd I can't change my name to hatch | 13:51 |
| hatch__ | jcsackett you didn't address my comment in viewlet-manager.js | 13:55 |
| jcsackett | hatch__: ...actually i did. i don't know why that didn't get pushed up. | 13:55 |
| hatch__ | heh, welllllll push'r'up | 13:56 |
| jcsackett | hatch__: huh. it pushed up the change to service-inspector but not viewlet...weird. | 13:56 |
| rick_h__ | hatch__: how goes, when you get a sec I'd like to meet up with you and kadams54 and get caught up on where we are with MV | 13:56 |
| rick_h__ | it looks like half the cards are blocked and now following why and want to make sure we plot a path through that asap | 13:57 |
| hatch__ | rick_h__ sure, 20mins? | 13:57 |
| rick_h__ | hatch__: k | 13:57 |
| urulama | rick_h__: ping | 13:58 |
| rick_h__ | urulama: howdy | 13:58 |
| rick_h__ | urulama: ready to chat? | 13:58 |
| urulama | rick_h__: sure | 13:58 |
| rick_h__ | urulama: k, invite on the way | 13:58 |
| rick_h__ | urulama: https://plus.google.com/hangouts/_/g5fbbzj56dl7cjvipytcasn5zma?authuser=1&hl=en | 13:59 |
| urulama | rick_h__: ok, tnx, see that the room is busy :D | 13:59 |
| jcsackett | hatch__: pushed. | 14:03 |
| hatch__ | jcsackett man git really did the diff odd with your branch heh | 14:11 |
| === hatch__ is now known as hatch | ||
| jcsackett | hatch: yes. | 14:12 |
| jcsackett | i find git frequently does terrible things with diffs. | 14:12 |
| hatch | it tries super hard to keep old lines even if they don't make any sense in the context heh | 14:14 |
| hatch | "no you saved THIS curly bracket" lol | 14:14 |
| jcsackett | hatch: yeah. and it seems super easily thrown off by lines moved around. | 14:16 |
| jcsackett | "you deleted this line and and move that one...better mark the whole file as a conflict!" | 14:17 |
| hatch | rick_h__ I'm ready whenever you are | 14:21 |
| rick_h__ | hatch: coolio, kadams54 available? | 14:22 |
| kadams54 | rick_h__: yup | 14:22 |
| rick_h__ | kadams54: https://plus.google.com/hangouts/_/gsmrjulttdrhsdmyukjid7aenma?authuser=1&hl=en | 14:22 |
| jcsackett | hatch: saw your comment on retry; how would retry get the inspectors object? because it just sets up y.later, which only returns a timer. | 14:35 |
| hatch | jcsackett otp | 14:37 |
| rick_h__ | luca: if you can file that bug with the roll overs I'll get huw to look at it tonight | 14:40 |
| luca | rick_h__: awesome, I’ll do it now | 14:40 |
| luca | rick_h__: https://bugs.launchpad.net/juju-gui/+bug/1339092 | 14:44 |
| _mup_ | Bug #1339092: Implement roll over and states for machine view tokens <juju-gui:New> <https://launchpad.net/bugs/1339092> | 14:44 |
| rick_h__ | luca: ty | 14:45 |
| hatch | jcsackett ok done, I'll look into HOW to do what I mentioned heh | 14:47 |
| hatch | it'll definitely require a bit of a refactoring | 14:47 |
| hatch | (reworking?) :) | 14:47 |
| jcsackett | hatch: yeah, Y.later doesn't even let you set a callback or something for the function, which is both odd and vexing. | 14:47 |
| jcsackett | hatch: i hope not much--this work has taken way too long to get through review already. :p | 14:48 |
| hatch | I added one other comment as well | 14:48 |
| jcsackett | hatch: if we don't find a simple way, then Y.later can just retry the dispatcher. | 14:48 |
| hatch | right, but wasn't that what you were trying to avoid in the first place? | 14:48 |
| jcsackett | hatch: well, it's what used to happen. this seemed better, but it sets up a problem. | 14:49 |
| jcsackett | hatch: so we can fall back to what used to happen, which wasn't broken. | 14:49 |
| rick_h__ | jujugui call in 10, kanban please | 14:50 |
| rick_h__ | jcsackett: hatch why a retry loop? is this for when we load the env for the first time and the data's not there yet from the env? | 14:52 |
| hatch | jcsackett the only 'simple' way is to call the inspector dispatcher again | 14:52 |
| jcsackett | rick_h__: right. | 14:52 |
| jcsackett | hatch: then i say that's what we do. | 14:52 |
| hatch | the other way is way to complicated and whtnot | 14:52 |
| rick_h__ | jcsackett: can we not just tie up to the db events like we talked about before? | 14:52 |
| hatch | agreed | 14:52 |
| jcsackett | b/c i don't think spending much more time on this is valuable. | 14:52 |
| hatch | yeah I'm find with switching it back, it's a simple fix then | 14:52 |
| bac | rick_h__: the comingsoon to azure card, is that something you'd like to do now? | 14:53 |
| jcsackett | rick_h__: as i recall, no, b/c the dispatcher doesn't wait on db. | 14:53 |
| rick_h__ | bac: yes, if you care to take it. | 14:53 |
| rick_h__ | jcsackett: right, but who cares about the dispatcher? | 14:53 |
| hatch | dispatcher don't wait for nobody! | 14:53 |
| jcsackett | rick_h__: this is all about dispatch. | 14:54 |
| bac | rick_h__: i don't understand the second part of the description, but yeah. | 14:54 |
| jcsackett | we have to retry, b/c dispatch doesn't wait for db and throws a fit when it can't find the data it needs. | 14:54 |
| jcsackett | so we tell it to retry b/c the data will be there in a moment. | 14:54 |
| rick_h__ | bac: ah, the second part was a question on do we just serve out the jenkins workspace as a 'comingsoon' but that could be bad | 14:54 |
| rick_h__ | bac: the idea was that the -merge job would eaily update a local path and just serve out the gui | 14:55 |
| rick_h__ | bac: vs a new machine | 14:55 |
| rick_h__ | bac: meet in standup pre stand up and chat? | 14:55 |
| bac | rick_h__: i just submitted an hr request for tomorrow as we discussed last week. | 14:56 |
| rick_h__ | bac: rgr | 14:56 |
| rick_h__ | jujugui call in 2 | 14:59 |
| rick_h__ | kadams54: ^ | 15:00 |
| kadams54 | Joining | 15:00 |
| urulama | rick_h__: when you finish with calls: what's machine view :D | 15:13 |
| hatch | urulama http://comingsoon.jujucharms.com/machine/:flags:/mv/ | 15:14 |
| hatch | it show the actual juju machines and allows you to fiddle with the placement of units and whatnot | 15:14 |
| hatch | this is a new feature in the GUI and apparently.....a very long one to implement :) | 15:15 |
| urulama | hatch: tnx | 15:15 |
| rick_h__ | urulama: yea, it's manual placement for the GUI | 15:21 |
| jcsackett | hatch: updated PR. | 15:21 |
| hatch | jcsackett thanks will look again | 15:22 |
| rick_h__ | hey, there he is | 15:26 |
| rick_h__ | Makyo: I removed you from that bug fyi | 15:26 |
| rick_h__ | jrwren: responeded to the bug report, thanks for looking into that | 15:37 |
| rick_h__ | jrwren: can you go ahead with the update to the CN and file a bug on the gui for the user help? | 15:38 |
| rick_h__ | hatch: going to get food and then we can chat. | 15:38 |
| jrwren | sure, is it fixable? | 15:38 |
| rick_h__ | jrwren: is what fixable? | 15:38 |
| hatch | rick_h__ cool thanks | 15:38 |
| jrwren | oh, the bug is just for docs for this. OK. | 15:39 |
| jrwren | I was just thinking, "why file a bug, if it can't be fixed", but it can be documented | 15:39 |
| rick_h__ | jrwren: yea, the browser can try to do some detection and at least help point the user 'hey I can't connect you might check xxx' | 15:39 |
| jrwren | ah, ok. | 15:40 |
| rick_h__ | right now the lack of user feedback makes them think juju is broken vs their browser | 15:40 |
| jrwren | this bug is on juju-gui, should it just be this same bug, or a new one? | 15:40 |
| rick_h__ | jrwren: a new one, this one is on both the charm and the gui. I think having one aroudn the ssl cert for the charm is cool and the other for the gui being helpful | 15:41 |
| jrwren | ok | 15:41 |
| hatch | jcsackett two qa issues posted | 15:41 |
| jcsackett | hatch: huh. haven't seen that. let me see if i broke something addressing last few comments. | 15:43 |
| hatch | sure thing | 15:43 |
| jcsackett | hatch: ok, that first one seems to be fallout i missed from moving the change event firing out of viewlet manager (and is in fact the reason that i put it in the viewlet manager in the first place. i'm digging into why it doesn't work now) | 15:45 |
| jcsackett | that second one, i have no idea. | 15:46 |
| jcsackett | this damn branch. | 15:46 |
| hatch | jcsackett it's likely a state issue | 15:48 |
| jcsackett | hatch: so, this is fallout from moving to the just checking model.id hasn't changed to see if we should re-render or make a new one. | 15:48 |
| jcsackett | b/c we don't actually destroy this._inspector when the inspector closes. | 15:49 |
| hatch | that's issue #2? | 15:49 |
| jcsackett | yeah. | 15:49 |
| hatch | well we should be destroying it | 15:49 |
| jcsackett | hatch: i concur. | 15:49 |
| hatch | +1 | 15:49 |
| hatch | be sure to add a test :PPP | 15:49 |
| jcsackett | hatch: i'm looking into why it doesn't get destroyed. | 15:49 |
| jcsackett | hatch: oh man, we've never destroyed it; it doesn't get destroyed in develop either. so it's not just a simple case of a broken dispatch change. | 15:52 |
| jcsackett | hatch: safe to say that when state sees metadata with inspector: null we can kill this._activeInspector? | 15:52 |
| hatch | jcsackett you bet - I'm curious though as to why it's not, the enptysectiona method should be destroying it | 15:53 |
| hatch | ohhhh | 15:53 |
| hatch | I bet that's what happened | 15:53 |
| jcsackett | "that" == what now? | 15:53 |
| hatch | oh wait nm you fixed that | 15:54 |
| hatch | ok look into emptysectiona method | 15:54 |
| hatch | it should be being called and destroying the inspector | 15:54 |
| hatch | https://github.com/jaycee/juju-gui/blob/dispatch-details/app/subapps/browser/browser.js#L390 | 15:54 |
| jcsackett | hatch: this is fun. | 15:57 |
| jcsackett | this._inspector.destroy() is getting called. | 15:58 |
| jcsackett | immediately after which, you can still check this._inspector and find an object. | 15:58 |
| jcsackett | same in develop if you look at this_activeInspector. | 15:58 |
| hatch | oh...right, duh | 15:58 |
| hatch | destroy() calls the destructor cycle, it doesn't null out the ref | 15:58 |
| jcsackett | should empty section set it to undefined or something? | 15:58 |
| hatch | null probably, yeah | 15:58 |
| hatch | null....undefined....whatever | 15:58 |
| hatch | heh | 15:59 |
| jcsackett | yeah, that fixes that. | 15:59 |
| jrwren | what we talked about: https://bugs.launchpad.net/juju-gui/+bug/1339155 | 16:05 |
| _mup_ | Bug #1339155: gui should display help when wss fails due to incorrectly accepted certificate <juju-gui:New> <https://launchpad.net/bugs/1339155> | 16:05 |
| jcsackett | hatch: so it looks like the onHide function in service-inspector isn't even being called? it's just jumping straight to viewlet managers hideSlot, despite my setting click on close-slot to onHide in the service inspector. | 16:05 |
| jcsackett | thoughts? | 16:05 |
| rick_h__ | ty jrwren | 16:05 |
| urulama | rick_h__: i've added some suggestions to the "new hire" doc | 16:05 |
| rick_h__ | urulama: ty much | 16:06 |
| jrwren | rick_h__: should I start working on that bug? | 16:06 |
| rick_h__ | jrwren: just the CN one in the charm | 16:07 |
| jrwren | ah, did that. | 16:07 |
| rick_h__ | jrwren: so that it doesn't lead to juju.ubuntu.com but to their own env | 16:07 |
| rick_h__ | jrwren: ok, is that reviewed and landed then? | 16:07 |
| jrwren | point me to docs on that process? | 16:07 |
| rick_h__ | jrwren: there's a hacking doc around the charm with some functional tests. | 16:07 |
| jrwren | got it. | 16:08 |
| urulama | jrwren: please share | 16:08 |
| rick_h__ | jrwren: so you need to pull down the charm code, update it, push it up under your name space, create a merge request from launchpad, and ping to get a review | 16:08 |
| rick_h__ | http://bazaar.launchpad.net/~juju-gui-charmers/charms/precise/juju-gui/trunk/files | 16:08 |
| rick_h__ | http://bazaar.launchpad.net/~juju-gui-charmers/charms/precise/juju-gui/trunk/view/head:/HACKING.md | 16:08 |
| jrwren | guess I shouldn't have bzr push :parent then. ooops | 16:08 |
| urulama | rick_h__: tnx | 16:09 |
| hatch | jcsackett hmm lemme take a look | 16:09 |
| rick_h__ | jrwren: heh, nope | 16:09 |
| hatch | I'm not sure | 16:09 |
| rick_h__ | jrwren: urulama nothing ever lands without review and all stuff should be forked to your own name space (in github or LP) and a pull request/merge proposal created to be signed off on | 16:09 |
| rick_h__ | jrwren: urulama and we try hard to create a HACKING doc in each project to help describe the workflow for devs | 16:10 |
| frankban | also for charm/quickstart development we use lbox | 16:10 |
| rick_h__ | can't promise them, but try to | 16:10 |
| jrwren | i don't know lbox | 16:11 |
| rick_h__ | frankban: we do for the charm? | 16:11 |
| frankban | rick_h__: yes | 16:11 |
| rick_h__ | ok, looks like we need some updating to the hacking docs | 16:11 |
| frankban | rick_h__: +1 | 16:11 |
| urulama | frankban: this lbox? https://launchpad.net/lbox | 16:12 |
| rick_h__ | urulama: yes | 16:12 |
| rick_h__ | urulama: jrwren lbox is a tool written to help push reviews through reitveld | 16:12 |
| rick_h__ | it allows for some nicer code review tooling and lbox helps sync with the launchpad merge proposals/etc | 16:12 |
| * urulama was happy for a minute not to have to deal with new stuff ... oh well ... :D | 16:12 | |
| jrwren | i wondered what that .lbox file was in the charm | 16:13 |
| rick_h__ | yea, it runs a pre-pull request hook basically to make sure tests pass locally before pushing | 16:13 |
| rick_h__ | quickstart docs don't mention lbox either :/ | 16:13 |
| hatch | jcsackett found it | 16:13 |
| hatch | https://github.com/juju/juju-gui/blob/develop/app/views/viewlets/charm-details.js#L93 | 16:14 |
| hatch | jcsackett see the e.halt() in that method? That's why it's not being called....e.halt() is the devil which we need to use because I bet the X is an anchor tag | 16:14 |
| rick_h__ | jrwren: urulama ok, good finds some old docs on lbox :) https://github.com/juju/charm-tools/blob/master/HACKING.txt#L29 | 16:15 |
| rick_h__ | jrwren: urulama and I think last time we had to go the go get lbox route | 16:15 |
| hatch | jcsackett so if so the X needs to be changed from an anchor into a span, then that e.halt() can be removed and then it'll work | 16:15 |
| rick_h__ | sudo go get launchpad.net/lbox will install it globally or you can do it local/etc | 16:15 |
| urulama | rick_h__: why sudo? isn't the go/bin dir enough? | 16:16 |
| rick_h__ | urulama: that's what I mean, you choice | 16:16 |
| hatch | jrwren damn that safari thing sure sucks.... | 16:18 |
| rick_h__ | jrwren: so from here, can you make sure to run the functional tests of the charm with what you've landed | 16:18 |
| rick_h__ | jrwren: otherwise it's a minor change and should be good, just want to make sure no tests were relying/checking that | 16:18 |
| jrwren | hatch: SECURITY! :) | 16:19 |
| hatch | "SECURE ALL THE THINGS!!!!" | 16:19 |
| jrwren | rick_h__: yes, doing that. | 16:19 |
| rick_h__ | jrwren: ty much | 16:19 |
| rick_h__ | jrwren: let me know when you've got time to chat | 16:20 |
| jrwren | was JUST going to run out to lunch. | 16:22 |
| jrwren | lets chat, then I'll run. | 16:23 |
| rick_h__ | jrwren: sorry, was meant to be hatch | 16:23 |
| rick_h__ | jrwren: go to lunch, we're good | 16:23 |
| rick_h__ | hatch: let me know when you've got time to chat | 16:23 |
| jrwren | oh, in that case, I'm running out for a bit. brb in 45min or less. | 16:23 |
| hatch | rick_h__ 1 min | 16:23 |
| urulama | jujugui: bye all, fun day ;) | 16:24 |
| rogpeppe | urulama: g'night | 16:24 |
| bac | bye urulama | 16:24 |
| rick_h__ | urulama: night | 16:24 |
| hatch | rick_h__ standup room? | 16:25 |
| rick_h__ | hatch: k | 16:25 |
| * urulama gets embarrassed for checking out during daytime ;) | 16:25 | |
| rick_h__ | hatch: new room | 16:25 |
| hatch | nope it's full | 16:25 |
| hatch | heh | 16:25 |
| === urulama is now known as uru-afk | ||
| * jcsackett discovers he was disconnected from znc for some reason. | 16:42 | |
| jcsackett | hatch: is there any fallout to always calling addTarget on viewlets to the view manager? then the viewlet's close can just fire the change event. | 16:43 |
| hatch | man all these hangouts have killed my battery | 17:13 |
| hatch | jcsackett the only issue is that it may fire an event that someone up the chain is listening for | 17:13 |
| hatch | so it'll react accidentally to the event | 17:13 |
| hatch | there is also a performance issue....but neither of these are very big negatives tbh | 17:14 |
| hatch | if you had like 100's then yeah it would suck, but there is only one so... | 17:14 |
| hatch | jcsackett ^ | 17:16 |
| hatch | rick_h__ sorry it wasn't the oatmeal it was http://techcrunch.com/2014/07/04/just-be-present/ | 17:18 |
| rick_h__ | hatch: I do like this "I’d bet you’ll find most of the ones without people in them pretty boring." | 17:20 |
| rick_h__ | hatch: but yea nice post | 17:20 |
| hatch | I just found it funny because it showed up right under your post about your fireworks pics | 17:20 |
| rick_h__ | :) sometimes I've got good timing | 17:21 |
| hatch | haha | 17:22 |
| hatch | well you can take some solace in knowing that yours are awesome | 17:23 |
| rick_h__ | hatch: so based on our call, did you want to shuffle the cards around? move the coding one back and the other back to code? | 17:24 |
| rick_h__ | jcastro: and if your two cards are one chunk feel free to combine | 17:24 |
| rick_h__ | bah jcsackett ^ | 17:24 |
| jcastro | oooh, you're going to let me move your cards around? I'd _love_ to reprioritize stuff! | 17:25 |
| rick_h__ | hah! | 17:26 |
| rick_h__ | you and Mark S can duke it out | 17:26 |
| rick_h__ | I'd pay to see that | 17:26 |
| hatch | rick_h__ yep I'll re-org them | 17:28 |
| * rogpeppe is done for the day | 17:31 | |
| rogpeppe | g'night all | 17:31 |
| jcsackett | rick_h__: i can combine, but it's two branches, one done but dependent on changes from the one currently on review. | 17:40 |
| rick_h__ | jcsackett: ah ok cool | 17:41 |
| rick_h__ | jcsackett: I didn't realize it was two branches knew you were working through the review of one | 17:41 |
| jrwren | http://bazaar.launchpad.net/~juju-gui-charmers/charms/precise/juju-gui/trunk/view/head:/HACKING.md says juju-test is part of charm tools, but... it does not seem to be for me. did this change from ppa:juju/stable -> ppa:juju/dev | 17:51 |
| rick_h__ | jrwren: it used to be, I think it's just a single file and in the tree now? I don't think you need that. | 17:53 |
| jrwren | which tree? | 17:54 |
| rick_h__ | jrwren: the charm | 17:55 |
| rick_h__ | jrwren: sorry, new laptop and don't have the sources locally. Working on looking. | 17:55 |
| jrwren | i'm looking too | 17:55 |
| jrwren | oh! my bad. | 18:01 |
| jrwren | i need both juju/devel and juju/stable PPA | 18:01 |
| jrwren | poor assumptions here. | 18:01 |
| rick_h__ | jrwren: no, this is what I mean by the documentation being out of date on that. Apologies on our end. | 18:03 |
| rick_h__ | they should be copy/pastable | 18:03 |
| jrwren | they are. | 18:03 |
| jrwren | i assummed that I didn't need hte ppa the documentation wrote, because stable v. devel | 18:04 |
| jrwren | charm-tools is in stable ppa, but not devel ppa. Its really my bad. | 18:04 |
| rick_h__ | ah gotcha | 18:04 |
| jrwren | maybe I'll update HACKING.md with a note stating as much. | 18:04 |
| rick_h__ | jrwren: yea,a if it threw you off it's likely to catch someone else as well | 18:08 |
| jrwren | whoa, selenium. cool. | 18:17 |
| rick_h__ | putting the functional into the functional tests wheeee | 18:19 |
| marcoceppi | rick_h__: is there a special flag in the gui that will show the icon on personal branches? | 18:23 |
| marcoceppi | also, if so, what is that flag | 18:24 |
| marcoceppi | ps <3 | 18:24 |
| rick_h__ | marcoceppi: no, it's never gotten done. Only for local charms deployed | 18:25 |
| marcoceppi | whyyy have you all forsaken meeeeeeee | 18:25 |
| rick_h__ | marcoceppi: because you didn't send enough pie | 18:25 |
| * marcoceppi bakes a ton of pie | 18:26 | |
| rick_h__ | marcoceppi: honestly, because i added a branch do it it and then it actually broke things and I've never gotten to write code again and it's never gotten fixed :) | 18:26 |
| marcoceppi | rick_h__: any way to get this in to gui? We're looking down teh barrel where people want to demo stuff and are putting pressure to promulgate charms because they can't see silly little icons, but these charms are demoware not store stuff | 18:28 |
| Makyo | Damnit, got pinged for an appointment I forgot about. Will be back in a bit. | 18:28 |
| rick_h__ | Makyo: have fun | 18:29 |
| rick_h__ | marcoceppi: not until after machine view is out | 18:29 |
| rick_h__ | marcoceppi: we're under the gun for this. I'm happy to make it a task after that | 18:29 |
| marcoceppi | and that's not going to happen by the 18th? | 18:29 |
| rick_h__ | heh, I'm hoping, but only just by the 18th | 18:30 |
| marcoceppi | rick_h__: cool, should I open a bug to track this request? | 18:30 |
| * marcoceppi is excited for machine view | 18:30 | |
| rick_h__ | and then we're out of town so we'd start it the week after that | 18:30 |
| rick_h__ | hmm, thought we had a bug. Let me look | 18:30 |
| rick_h__ | marcoceppi: https://bugs.launchpad.net/juju-gui/+bug/1260854 | 18:33 |
| _mup_ | Bug #1260854: we really need to support icons for all charms, at least as an option <juju-gui:Triaged> <https://launchpad.net/bugs/1260854> | 18:33 |
| rick_h__ | marcoceppi: I did one branch that did it for charms, but then that broken icons for bundles and caused us to not release it | 18:33 |
| marcoceppi | rick_h__: cool, thanks man | 18:34 |
| rick_h__ | marcoceppi: but since local charms work, that's a great way to get things deployed for a demo and then they get icons | 18:34 |
| rick_h__ | marcoceppi: not sure on the full path of the demo/etc | 18:34 |
| marcoceppi | rick_h__: yeah, but for this demo they're going to want to do the zero to drag and drop deploy | 18:35 |
| rick_h__ | marcoceppi: gotcha | 18:35 |
| marcoceppi | I do really love that local shows icon | 18:35 |
| marcoceppi | makes charm dev a nice experience | 18:35 |
| rick_h__ | kadams54: around? | 18:38 |
| kadams54 | rick_h__: yup | 18:38 |
| rick_h__ | kadams54: got a sec to chat in the hangout on the machine naming business? | 18:39 |
| kadams54 | Sure | 18:39 |
| kadams54 | rick_h__: ^ | 18:43 |
| rick_h__ | kadams54: hmm, sitting in there | 18:44 |
| * rick_h__ tries again | 18:44 | |
| rick_h__ | kadams54: https://plus.google.com/hangouts/_/canonical.com/daily-standup?authuser=1 | 18:44 |
| hatch__ | oo rick_h__ you're gona love this new impl | 18:49 |
| * hatch__ also loves it like 1B times more than the original one | 18:49 | |
| rick_h__ | hatch__: woot woot | 18:50 |
| hatch__ | https://gist.github.com/hatched/d56c0a585397e9d8ef73 | 18:51 |
| hatch__ | there's the preliminary diff of the scale-up.js file | 18:51 |
| rick_h__ | hatch__: cool, glad the conversation was useful | 19:00 |
| rick_h__ | kadams54: marked the bug as invalid and replied to the thread. | 19:04 |
| rick_h__ | kadams54: feel free to ditch the card and move on to something more interesting | 19:04 |
| kadams54 | Will do. | 19:05 |
| hatch__ | making logical commits as I was working is also making it very easy to remove commits which are no longer valid from this refactoring | 19:07 |
| hatch__ | saving a bunch of work | 19:07 |
| hatch__ | rick_h__ kadams54 we are no longer removing 'new' ? | 19:07 |
| jcsackett | hatch__: ok, i've been able to sort out QA fixes. can you verify QA good now? | 19:10 |
| hatch__ | jcsackett | 19:11 |
| hatch__ | yes | 19:11 |
| hatch__ | :) | 19:11 |
| * jcsackett crosses fingers that you'll actually see QA good. :p | 19:12 | |
| jcsackett | ...yes, hatch? :p | 19:12 |
| jcsackett | heheh. | 19:12 |
| hatch__ | haha | 19:12 |
| hatch__ | r u going to rebase into logical commits before landing? | 19:12 |
| hatch__ | want to do that before I QA? just in case | 19:12 |
| rick_h__ | hatch__: no, we're not for now. See email thread. | 19:12 |
| hatch__ | rick_h__ cool will look | 19:13 |
| kadams54 | rick_h__, hatch__ : https://bugs.launchpad.net/juju-gui/+bug/1339289 for the follow up bug to improve logic around committed/uncommitted. | 19:14 |
| _mup_ | Bug #1339289: Stop using ID to determine if a machine is uncommitted <juju-gui:New> <https://launchpad.net/bugs/1339289> | 19:14 |
| rick_h__ | kadams54: k, adding a card to the backlog to look into it | 19:14 |
| hatch__ | kadams54 thanks | 19:14 |
| rick_h__ | kadams54: feel free to use that with any XXX | 19:14 |
| kadams54 | Yeah, I'll add XXX comments as drive-bys in my next branch. | 19:15 |
| hatch__ | I'm too old and overweight for my hobbies, crashed hard yesterday kiting and I'm paying for it today.....can I be 21 again? | 19:16 |
| rick_h__ | hatch__: heh, I'm sore from the camping weekend | 19:19 |
| hatch__ | sheesh, don't start kiting then lol | 19:19 |
| rick_h__ | hah | 19:19 |
| hatch__ | I got to hit the gym | 19:19 |
| hatch__ | maybe get one of those treadmill desks | 19:19 |
| hatch__ | I wonder if I can jog and type | 19:19 |
| hatch__ | lol | 19:19 |
| hatch__ | I have an elliptical but those just don't quite work for the whole....desk + treadmill thing :) | 19:21 |
| jrwren | We had treadmill desks at my last job, in the office. They were nice. | 19:21 |
| hatch__ | you could concentrate while walking and typing? | 19:22 |
| jrwren | yes. | 19:22 |
| jrwren | it had a slow max speed. | 19:22 |
| hatch__ | I'm worried I'd have to turn it off to think | 19:22 |
| hatch__ | lol | 19:22 |
| jrwren | i didn't use it much. | 19:22 |
| jrwren | I prefer standing desk. | 19:22 |
| hatch__ | yeah I'm rocking two mdf boxes ontop of my normal desk as a standing desk :) | 19:23 |
| jrwren | nice. | 19:23 |
| jrwren | i'm still on laptop on cardboard for my standing desk, i'll upgrade to something almost that hacky soon. | 19:23 |
| hatch__ | haha | 19:23 |
| hatch__ | it works well, just slow to convert back to a sitting desk | 19:24 |
| jrwren | I've not converted yet. | 19:24 |
| jrwren | i'm doing pretty good at standing all day. | 19:25 |
| jrwren | maybe, sit for lunch. | 19:25 |
| jrwren | Yesterday, I sat for 10m because the docs I needed to read were a bit long :) | 19:25 |
| hatch__ | haha - yeah I'm thinking of going for a motorized standing/sitting desk for more room and then putting a recliner in my office for deep thinking bouts | 19:26 |
| jrwren | awesome. when I sat for that doc reading it was in my Ikea POÄNG :) | 19:27 |
| jcsackett | hatch__: logical commits pushed. | 19:28 |
| rick_h__ | hatch__: woot watch arrived | 19:33 |
| hatch__ | rick_h__ lucky!! mine is 'being held by ups' | 19:33 |
| hatch__ | watever that means :/ | 19:33 |
| hatch__ | jcsackett cool will qa | 19:33 |
| hatch__ | jcsackett while I do this want to kick off a new CI build? | 19:37 |
| hatch__ | it failed right-away | 19:37 |
| jcsackett | hatch__: yeah, what's up with that failure? | 19:37 |
| hatch__ | no idea... | 19:38 |
| jcsackett | it's an npm thing taht doesn't happen locally. | 19:38 |
| jcsackett | hatch__: don't bother QAing. i just noticed something else wrong. | 19:39 |
| hatch__ | jcsackett when I deploy a charm (without mv) the inspector doesn't have units... | 19:39 |
| jcsackett | for some reason units are not now rendering... | 19:39 |
| jcsackett | yeah. | 19:39 |
| hatch__ | ok :) | 19:39 |
| jcsackett | ... | 19:39 |
| hatch__ | sorry :) | 19:40 |
| hatch__ | i feel your pain | 19:40 |
| jcsackett | i'm growing to *really* hate the inspector, and dispatch, and viewlets, and... | 19:40 |
| jcsackett | :p | 19:40 |
| hatch__ | just imagine what it was like before that :) | 19:41 |
| jcsackett | hatch__: i think you're going to be blocked on your card in perpetuity man. | 19:42 |
| hatch__ | nah I have faith in you | 19:42 |
| * rick_h__ runs away for the evening. | 19:55 | |
| hatch__ | stepping out for lunch bbl | 19:55 |
| rick_h__ | I'll be back later, but hatch__ Makyo if you see huw before I do I've assigned him a card for tonight to help UX | 19:55 |
| rick_h__ | hatch__: Makyo please point it out to him if you see him first | 19:56 |
| hatch__ | will do | 19:56 |
| bac | ugh, i just told my phone 'juju set a timer' instead of 'siri'. | 20:36 |
| rick_h__ | bac: lol | 20:47 |
| hatch__ | haha | 20:49 |
| Makyo | Erk | 20:57 |
| jcsackett | hatch__: found and fixed it, need to change locations to get a reliable enough internet connection to push changes. should be just a few moments. | 21:19 |
| hatch__ | heh where are you in a cave? ;) | 21:23 |
| rick_h__ | says the man who had to cell signal it up for a week :P | 21:26 |
| hatch__ | lol, now shut your mouth | 21:27 |
| hatch__ | I have no comeback | 21:27 |
| hatch__ | that's all you get | 21:27 |
| hatch__ | haha | 21:27 |
| jcsackett | hatch__: ok, everything looks good on my end now, and i've pushed. | 21:54 |
| jcsackett | hopefully i didn't miss anything this time around, and there's nothing new broken. :p | 21:54 |
| hatch__ | :) | 21:54 |
| hatch__ | will look | 21:54 |
| hatch__ | jcsackett did you happen to check this in a real env so you can see if /charm gets dispatched on load? | 22:01 |
| jcsackett | hatch__: no, actually, i did not. do you have real env to check against, by any chance? | 22:09 |
| hatch__ | I don't I can spin one up if needed though | 22:09 |
| hatch__ | I'll do that | 22:10 |
| hatch__ | maybe.... | 22:10 |
| hatch__ | hmm | 22:10 |
| hatch__ | not sure if working... | 22:10 |
| hatch__ | oh there it goes | 22:10 |
| hatch__ | slow internets today I guess | 22:10 |
| * jcsackett laughs | 22:11 | |
| jcsackett | hatch__: if it doesn't dispatch on load properly, i think let's deal with it as a follow up so we can get this moving and get you unblocked. | 22:12 |
| hatch__ | :-) | 22:12 |
| hatch__ | in that case you might as well shipit while I do this | 22:13 |
| hatch__ | I +1d | 22:13 |
| hatch__ | because local testing was ok | 22:13 |
| jcsackett | oh, i missed that. well, i'm curious to know. if it fails in a simple way, i'm game for looking into it. | 22:13 |
| jcsackett | naively, i think it should just work--the only issue is model loading, and that's already handled. | 22:14 |
| hatch__ | ok it'll probably be 20mins before this is up, amazon is slow | 22:14 |
| jcsackett | hatch__: hm. ok. maybe i should just :shipit: so i can get the next dependent (but thankfully *much* smaller) branch up for PR. | 22:20 |
| jcsackett | hatch__: when is your EoD/ | 22:20 |
| rick_h__ | jcsackett: +1 if the tests pass and normal QA is good then feel free to shipit and follow up with a good QA tomorrow. | 22:21 |
| hatch__ | technically 40mins, but I'm going to get my branch up for review before I'm done regardless | 22:21 |
| jcsackett | rick_h__: ok. | 22:21 |
| rick_h__ | jcsackett: it won't hold anyone back and we're not looking to do a release tomorrow. | 22:21 |
| rick_h__ | jcsackett: but it is a good idea to check it out as the issue is particularly with live envs | 22:21 |
| hatch__ | gui is pending | 22:21 |
| jcsackett | hatch__: how long is gui likely to take to spin up? no more than 5 min or so, right? | 22:22 |
| hatch__ | jcsackett iunno depends on what I have my ec2 instances set up | 22:23 |
| hatch__ | on | 22:23 |
| jcsackett | ah. | 22:23 |
| hatch__ | still pending | 22:23 |
| hatch__ | :) | 22:23 |
| jcsackett | hatch__: well, i'll go ahead and :shipit: and if you tell me it doesn't work on live, i know what i'm doing tomorrow. :) | 22:23 |
| jcsackett | and i'll get the other PR up so we can unblock your work. | 22:23 |
| hatch__ | sounds good | 22:25 |
| hatch__ | jcsackett gui up | 22:42 |
| jcsackett | hatch__: awesome. merge job still going. :p | 22:51 |
| jcsackett | how's /charm load up on persistent? | 22:51 |
| hatch__ | I'm having an odd issue with juju | 22:51 |
| hatch__ | it's saying the juju-gui machine doesn't exist | 22:51 |
| hatch__ | when it's in the status list... | 22:51 |
| jcsackett | that's...bizarre. | 22:52 |
| jcsackett | hatch__: what v of juju? they just did a release, could be a bug? | 22:52 |
| hatch__ | 1.18.4 | 22:52 |
| hatch__ | jcsackett crud there is bugs in your branch | 22:54 |
| jcsackett | hatch__: what? | 22:54 |
| hatch__ | can't load the inspector on load | 22:54 |
| hatch__ | Uncaught TypeError: Cannot read property 'get' of null service-config.js:97 | 22:54 |
| jcsackett | hatch__: this is only with persistent env, though? | 22:54 |
| jcsackett | or did we miss something in QA? | 22:55 |
| hatch__ | well...yeah a real env...like what people /actually/ use lol | 22:55 |
| hatch__ | so how do you want me to do this? Do you want me to file a bug or will you just give it a go in the morning and work on a fix? | 22:56 |
| jcsackett | hatch__: i'll make a card saying it's an issue in persistent. | 22:57 |
| jcsackett | and i'll deal in the morning. | 22:57 |
| jcsackett | hatch__: if you're game, second branch https://github.com/juju/juju-gui/pull/426 | 22:58 |
| hatch__ | ok sounds good, I'll tear down the env | 22:58 |
| jcsackett | hatch__: second PR is *much* smaller. :) | 23:00 |
| jcsackett | hatch__: also, if you don't have a reviewer for your upcoming PR, i can try to get to it sometime tonight, if not first thing in the morning which i believe is before your day starts. | 23:01 |
| hatch__ | ok that sounds like a plan | 23:02 |
| hatch__ | I'll get on your review in a few mins | 23:02 |
| huwshimi | Morning | 23:03 |
| rick_h__ | huwshimi: morning, want to chat when you get settled this morning please | 23:04 |
| huwshimi | rick_h__: Sure. Call? | 23:04 |
| rick_h__ | huwshimi: sure thing | 23:04 |
| rick_h__ | huwshimi: https://plus.google.com/hangouts/_/guoc2hcs3slor7fh67oxp764dea?authuser=1&hl=en | 23:05 |
| hatch__ | jcsackett just finishing up my branch - I'll do your review before your SOD | 23:13 |
| jcsackett | hatch__: don't stay up too late; if it has to wait till you start tomorrow, that's fine. | 23:23 |
| jcsackett | :p | 23:23 |
| jcsackett | i'm out for a bit. | 23:23 |
| hatch__ | jcsackett looks like you have a bonified CI failure | 23:44 |
| hatch__ | jujugui lf a review and qa on https://github.com/juju/juju-gui/pull/425 | 23:52 |
| hatch__ | thanks | 23:53 |
| huwshimi | hatch: So the point of those state classes is that you should only need to ever have one applied to the container. In your branch it seems that you need to have two bits of UI showing so you're adding an additional state class instead of modifying the CSS to fix the real issue | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!