[00:20] * thumper off to visit the vet, bbl [01:08] lucky(~/src/github.com/juju/juju/environmentserver/authentication) % vim authentication.go [01:08] lucky(~/src/github.com/juju/juju/environmentserver/authentication) % [01:08] why does this new package have ZERO tests ?!? [01:08] why is there a whole package for one file [01:08] and two types !?! [01:09] no, not two type [01:09] two functions [01:09] davecheney: because it's waiting for you to write the rest of it? [01:09] :) [01:11] rick_h__: i didn't add that [01:12] me is frustrated with the proliferation of tiny packages [01:12] ffs people, this isn't java [01:52] menn0: https://github.com/juju/juju/pull/284 [01:52] small PR for your lunchtime perusal [01:59] davecheney: will look right after this meeting (if it happens) [02:06] oh shit [02:06] i was going to take a screenshot of the hangout screen that showed 12:05 [02:06] but the it ticked over to 12:06 [02:06] and it didn't hav the ring to it [02:07] info.SetAPICredentials(configstore.APICredentials{ [02:07] User: apiInfo.Tag.Id(), [02:07] Password: apiInfo.Password, [02:07] }) [02:07] ohh, [02:07] here is an intersting one [02:07] we have a Tag, so "user-dave" [02:07] but the api credentials being written down will be "dave" [02:07] so that User field cannot be used to turn back into a tag [02:07] yeah, that is all fucked up [02:07] anyway... [02:07] I've touched that I think [02:08] where do those credntials go ? [02:08] those are stored in the .jenv file [02:08] if the thing at the other end is doing [02:08] names.ParseUserTag [02:08] that is ok [02:08] it isn't [02:08] if it's doing [02:08] names.ParseTag [02:08] then it's wrong [02:09] ok, comment added anyway, i'll come back to it after I've fixed the compile errors [02:09] I think it is doing neither [02:11] thumper: [02:11] var environUUID string [02:11] if apiInfo.EnvironTag != nil { [02:11] tag, err := names.ParseEnvironTag(apiInfo.Tag) [02:11] if err != nil { [02:11] return err [02:11] } [02:11] environUUID = tag.Id() [02:11] } [02:12] yep [02:12] so, if the environtag _is_ set, then ignore it and use the id of the apiInfo.Tag ... [02:12] o_O [02:13] ah wat? [02:13] I misread the code [02:13] that is all sorts of fucked up [02:13] pretty sure it should be using EnvironTag ... [02:15] yup [02:19] thumper: do you want me to land a quick branch to fix this before doing some more wholescale changes ? [02:19] yeah, I think that would be good [02:20] ok, two secs [02:20] davecheney: if it makes you feel better, I'm down in the trenches of weird/shitty code too [02:22] \o/ [02:24] thumper: menn0 https://github.com/juju/juju/pull/285 [02:25] davecheney: there are no tests? [02:25] don't appear to be [02:25] how silly of me... a test would have shown it wasn't working [02:25] didn't run the whole test suite [02:25] just go test ./juju/api [02:25] davecheney: is there a quick test that could be written around that? [02:25] thumper: no idea [02:26] haven't looked at the tests in that code [02:26] can you take a look? [02:36] hmm [02:36] so [02:36] none of our test fixtures have an environment-uuid: field [02:39] ok, this is bigger than a quick branch [02:39] logging a bug [02:42] * thumper is fighting side-effects in code being tested elsewhere [02:42] https://bugs.launchpad.net/juju-core/+bug/1339967 [02:42] <_mup_> Bug #1339967: juju: cacheAPIInfo users the wrong tag when storing the environ UUID [02:42] its on the list [02:42] i don't want to get distracted [02:55] davecheney: can play.golang.org do github imports? [02:57] thumper: failed for me, maybe it does certain ones?? [02:57] thumper: no [02:57] failed for me too... [02:57] ok that is why [02:58] func RunConfigureScript(script string, params ConfigureParams) error { [02:58] logger.Debugf("Running script on %s: %s", params.Host, script) [02:58] client := params.Client [02:58] if client == nil { [02:58] client = ssh.DefaultClient [02:58] } [02:58] cmd := ssh.Command(params.Host, []string{"sudo", "/bin/bash"}, nil) [02:58] cmd.Stdin = strings.NewReader(script) [02:58] cmd.Stderr = params.ProgressWriter [02:58] return cmd.Run() [02:58] } [02:58] client is not being used at all ?!?! [02:59] looks that way [03:00] hmph - I'll leave a question for the reviewer [03:00] does that code even compile ? [03:00] cloudinit/sshinit/configure.go:52 [03:01] yep, I have not touched it [03:01] davecheney: ^ [03:01] it's cos of the check [03:01] the if on line 51 [03:02] yep [03:02] http://play.golang.org/p/m4Z-kfxN3w [03:02] oh well [03:02] why oh why are so many of our tests so shit? [03:03] thumper: you know that 383,000 lines of code ? [03:03] that's not a number i'm particularly proud of [03:03] * thumper smirks [03:05] I'm assuming they meant client.Command(... not ssh.Command [03:06] waigani_: yes [03:06] log a bug [03:07] davecheney: I actually need to fix it for my branch - need to manually provision with a given key [03:08] davecheney: should I still associate a bug with it and address it in my PR? [03:15] waigani_: if you're not going to fix it staight away [03:15] log a bug [03:15] so when you are on leave next week [03:15] it doesn't get lost [03:35] woot. I think I've reviewed everything that needs reviewing. [03:36] I'll keep an eye on the PR queue but ping me if there's anything that needs urgent review. [03:36] omg... [03:36] I found a test that tests something that can never happen... [03:36] effectively it goes like this: [03:36] look for the api end points [03:36] make sure there are no addresses [03:36] if there are no addresses, connect to the api to find the addresses [03:36] return addresses [03:37] yay [03:37] * thumper waves his hand [03:37] magic [03:37] juju magic [03:41] * thumper sighs [03:41] thumper: the test does that and passes? [03:42] menn0: well it mocks out the actual connection [03:42] to return values [03:43] right. so it's an unnecessary test. [03:45] yup [03:46] here is a good error message: logger.Warningf("cannot failed to cache API addresses: %v", localerr) [03:46] double negative, so it worked, right? [03:51] 8-) [03:56] WT actual F? [03:56] * thumper sighs [03:56] * thumper holds in the rage and turns a little green [03:57] why, oh why would the environment uuid change on an api connection? [03:57] perhaps to save it? [03:57] when it wasn't before? [03:57] that is the only consideration I can think of [03:59] davecheney: if I have a function that is package private, but I also export the func in export_test.go using the BigName = smallName method [03:59] davecheney: but the function takes an arg that is an unexported interface [03:59] davecheney: is go going to complain? [03:59] or magically work? [03:59] as long as what I pass in matches? [04:22] hmm... unnecessary test is not entirely unnecessary [04:22] there are other assumptions built int [04:22] in [04:42] thumper: while working on the schema migrations doc I think I've found a bug in the current upgrade mechanics [04:42] oh? [04:42] thumper: line 817 cmd/jujud/machine.go [04:43] there [04:43] a variable holding an error is carefully created but is never used [04:43] and there's no tests that look for that error [04:43] so if upgrades fail we silently ignore the failure and everything keeps going as if the upgrade was successful [04:44] heh [04:44] oops [04:44] we should probably fix that [04:45] I think the last return in runUpgrades should be "return err" not "return nil" [04:45] surely there is a test... [04:45] this was wallyworld_, so there should be a test [04:45] I searched for "cannot perform upgrade" in the entire tree and it's only mentioned in that function [04:47] hmm [04:47] write a failing test :) [04:47] thumper: menn0: it wasn't me [04:47] one where the step always fails [04:47] and check [04:47] it was roger :-P [04:47] look at annotate :-) [04:47] will do. I know this bit of the code quite well now. [04:48] also... should probably look at the upgrade error before the "failed to update agent version error" [04:48] i suspect there hsould have been a baned return value [04:48] named [04:49] wallyworld_: yep understood [04:49] :-) [04:49] I think it might be clearer without a named return anyway [04:51] wallyworld_: what is currently the desired behaviour if a upgrade steps fail? it's 50/50 whether it's better to downgrade or pressing on with the new version depending on which upgrade steps have already run. [04:51] soon we will be able to rollback using the backup, but what do we expect right now? [04:53] menn0: hmmm. we haven't really supported rollback till now. rollback is more than db, includes config also etc. we don't really handle upgrade errors very well. [04:53] hard problem [04:53] wallyworld_: right and I'm trying to make that situation better. [04:53] wallyworld_: but given current limitations what do we do? [04:53] error out and then the agent restarts [04:53] wallyworld_: or what /should/ we do is probably the better question [04:54] try and recover [04:54] * thumper is pulling gently on the end of a piece of string, but is just getting a big knot every time [04:54] and restart the old agent [04:55] wallyworld_: ok. that seems about the best we can do. [04:55] yeah [04:55] the old agent may not work because of changes made by upgrade steps for the next version but we can't do much better [04:55] we can try and rollback the file changes [04:55] but that may not work either [04:55] soon we will be recovering from the backup which has both the database and configuration files [04:56] the thought was, if it fails, it's time to call juju support [04:56] got it [04:56] great, look forward to that [04:58] wallyworld_: it was definitely rog's change... I just had a look and I can see exactly what happened. [04:58] \o/ [04:59] * wallyworld_ makes mistakes too, but sometimes needs to defend his honour :-) [04:59] especially since thumper implied there should have been a test :-) [04:59] wallyworld_: that is because you always supply tests for your work [04:59] although the lack of pre-existing tests for that error condition probably didn't help when rog refactored that code... [04:59] yes :-) [04:59] :-p [05:00] well, i didn't write the original either [05:00] just teasing [05:00] the jujud upgrade stuff is separate from the upgrade steps stuff [05:00] :-P [05:00] * menn0 rolls up his sleeves [05:00] * wallyworld_ takes the bait [05:00] ;-) [05:00] * wallyworld_ needs sleep, later [05:40] success... just one failing test to fix [05:40] * thumper is done for now [05:40] meetings later [05:40] night all === uru-afk is now known as urulama [05:57] menn0: someone refactored untested code? tsk tsk [05:58] ChrisW1: indeed :) [06:04] thumper: re that test, http://static.comicvine.com/uploads/original/11111/111119363/3792894-7922452111-tumbl.gif [06:05] it won't complain, but you won't be able to construct a value to pass to that function [06:05] however, if you have someone elses' value, that will work [06:06] menn0: re named return, hold that thought [06:06] it will be a good example for waigani [06:07] menn0: chrisw1, http://dave.cheney.net/2013/11/14/more-simple-test-coverage-in-go-1-2 [06:07] may be useful for figuring out which footguns are lacking their protective covers [06:08] davecheney: I'm not sure if this is the best sample for discussing named returns [06:08] menn0: what was the bug you found before ? [06:08] the code is hairy [06:09] not really about named returns [06:09] :/ [06:09] thumper or wallyworld were theorising that perhaps someone intended there to be named returns but there wasn't [06:09] at any rate, no named returns are being used [06:10] the bug is about an error not being returned [06:10] ok [06:10] a line that says "return nil" when it should say "return err" (well actually it's more complex than that but that's the core of it) [06:10] * davecheney moves on [06:10] :~ === liam_ is now known as Guest5405 [07:18] frustrated email sent to juju-dev [07:18] I'm done for this week. [07:18] Back on Monday. [08:09] morning [08:23] i've just filed bug 1340077 (https://bugs.launchpad.net/juju-core/+bug/1340077) ... didn't find similar one, but maybe it already exists [08:23] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:23] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:24] 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 1340077 [08:24] #1340077 [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] i wonder if mup is dumb enough to fall for that [08:25] #1340077 #1340077 #1340077 #1340077 #1340077 #1340077 #1340077 #1340077 #1340077 [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] <_mup_> Bug #1340077: if "default" is named to undefined env, the parsing fails [08:25] and the answer is, yes [08:25] QED ;) [08:25] * davecheney waves to urulama [08:25] welcome to canonical [08:25] thanks [08:27] oh, australia, good evening then [08:28] o/ [08:28] i'm representing for the southen himsphere tonight [08:32] * TheMue waves as antipode [09:03] urulama: welcome. So how does one intend to pronounce "urulama" ? My first instinct is to read it as "you're a llama", but the intent could be something different [09:04] jam: :D :D [09:05] jam: never thought about that ... it's an old nick, so old that i don't thing about it, but maybe it is time to change it [09:06] jam: "ooroo"+"llama" would sound as we read it [09:06] urulama: strong l or a y or a j sound ? [09:06] strong L [09:22] jam: urulama: maybe it’s the right time to have nicks in phonetics (thinking of international teams) [09:22] TheMue: or in asciiart :D [09:24] urulama: ;) [09:28] so, mine is ðə mjuː [09:32] it's probably a known bug that autocomplet for debug-hooks in terminal returns charm/1 as charm is on machine 1, but hooks are connected only when "juju debug-hooks charm/0" is executed? [09:34] on a amazon or manual env, not on local [10:15] tasdomas`, I added some review comments to your ports PR === psivaa-off is now known as psivaa [10:38] urulama: I haven't heard of it, so feel free to report a bug about autocomplete, as the first unit of a service is always 0, it shouldn't depend what machine it is on. [10:43] so, https://github.com/juju/juju/pull/281 is back in for review [10:45] TheMue: dimitern vladk|offline standup? [10:53] one more bug 1340133 [10:53] <_mup_> Bug #1340133: debug-hooks don't work in manual env [11:02] urulama: whenever I read your name my first response is "nu-uh, *you're* a llama" :) === urulama is now known as uru_ [11:02] damn, taken === uru_ is now known as uru-urnotallama [11:03] jam: better? :D [11:03] *rofl* [11:04] uru-urnotallama: :) === uru-urnotallama is now known as urulama [11:11] dimitern: so you're gone from tomorrow for 2 weeks/ [11:11] ah, that's next week [11:11] jam, yep, next week [11:31] dimitern, thanks === urulama is now known as uru-afk === uru-afk is now known as urulama [12:31] * dimitern needs to step out now, bbl === tasdomas` is now known as tasdomas [12:44] are pull requests for packages like github.com/juju/names managed by a landing bot or do I just merge them myself (having received an LGTM) [12:44] ? [12:44] morning [12:45] perrito666: morning [12:45] perrito666: we’ll see on Sunday, ha? :D [12:45] TheMue: I return home on sunday, I will most likely sleep trough the game [12:46] perrito666: hey, you cannot do that, you’ll see how our team beats yours :P [12:48] I care as much for football as I do for ... I think there is nothing I care that little about :p [12:50] perrito666: hehe, in that case [13:37] morning all [13:39] bodie_: hey [13:41] mbruzek: hey [13:41] davecheney, hello [13:41] mbruzek: did you see my update on taht issue [13:42] do you have the dmesg from that system [13:42] yes I uploaded dmesg [13:42] * davecheney checks email [13:42] hmm, nup [13:42] nothing [13:43] https://bugs.launchpad.net/ubuntu/+source/gccgo-4.9/+bug/1304754/comments/35 [13:44] <_mup_> Bug #1304754: gccgo has issues when page size is not 4kB

[13:44] davecheney, ^ [13:45] mbruzek: it's empty [13:45] davecheney, Sorry take the comments/35 off [13:46] the bug was updated with my dmesg_output.txt I thought I would be clever by showing you on which comment, but I left no messages on file upload. [13:46] mbruzek: thanks [13:46] ok, so it's not the usual issue [13:46] dmesg shows no issue [13:58] wife bought strawberry cake, daughter made a tea - a very good working environment [15:20] * perrito666 finds another race [15:22] axw: if you want a break from mongo fun https://github.com/juju/juju/pull/288 [15:26] AWS question: does anyone know if there's any documentation on what version of signature each region supports? [15:28] katco: not sure what you mean version of signature [15:29] yeah, sorry: http://docs.aws.amazon.com/general/latest/gr/signing_aws_api_requests.html [15:29] they support v2, 3, and 4 [15:29] and i'm trying to introduce support for 4; turns out it's important to know which region supports which [15:42] sinzui: \o/ [15:43] katco: man, that is a terrible name for ... well anything. [15:43] wallyworld_: btw, A/C people still not here :/ Supposed to be here between 10 and noon, so the clock is ticking [15:43] natefinch: mm? what's a terrible name? [15:44] natefinch: np. we'll try not to eat *all* the kunch [15:44] lunch [15:44] katco: "SIgnature" [15:44] natefinch: ah [15:44] natefinch: context increase IQ by 100% ;) [15:45] natefinch: so much for "they usually come here first" [15:46] perrito666: Usually they end up coming early. I guess they found out I'm not actually supposed to be working from home today, so decided to come late [15:46] natefinch: sounds possible [15:46] There have been a couple times they have simply not shown up. But I called at 11 to make sure they hadn't just left me off the list this time. [15:48] wallyworld_, the 1.20.1 final test run and the 1.20.2 first test run were the two best runs CI has seen in 6 weeks. In both cases every test passed the first try. The entire run was less than 2 hour each [15:48] wow, awesome [15:59] is there a juju / charm acolyte who might be able to help breze441 in #juju ? [15:59] I tried to prime the pump a bit since his question was vague, but I think there's enough detail now that someone who knows juju/charms better may be able to help with? [16:05] katco, axw: btw, I pinged niemeyer about moving goamz to github, since some Go people had been asking about which version they should use - launchpad's or the dozens of copies on github. [16:14] sinzui, good stuff on 1.20.1, thanks for getting it out there! [16:15] thank you alexisb === urulama is now known as uru-qfk [16:32] natefinch: got ac? [16:35] natefinch: thanks, I think that'd be a good idea. === uru-qfk is now known as uru-afk [16:37] natefinch: +1, ty [16:50] perrito666: they're here, but it's not fixed yet [16:50] natefinch: well its something [16:54] perrito666: yeah, but I fear the person they sent is not their most competent at diagnosing problems. They have like 3 really good technicians and a bunch of flunkies that are not that great [17:04] * perrito666 wonders if we cannot fix that, there are like 8 of us here [17:12] rogpeppe: ping [17:12] rogpeppe: are you around? [17:12] voidspace: hiya [17:13] voidspace: that i am [17:13] rogpeppe: hey Roger, hi [17:13] I'm in Lexington [17:13] voidspace: cool [17:13] rogpeppe: I have a question about HA [17:13] voidspace: fire away [17:14] rogpeppe: should all writes go to mongo master - and does that mean that only the machine hosting the mongo primary should do writes, or do the other state servers connect remotely to the primary? [17:14] or does it mean something else [17:14] what I'm seeing, which surprised me, is that after "ensure-availability" the machine with JobManageEnviron is not the Primary mongo [17:14] voidspace: if you connect to a mongo secondary, it will automatically make a connection to the primary and send writes there [17:14] cool [17:14] so we don't need to worry about that [17:15] voidspace: after ensure-availability, there should be 3 machines with JobManageEnviron [17:15] they should all have JobManageEnviron, ok [17:15] voidspace: and the choice of primary is entirely up to mongo [17:15] hmmm... my machine 1 only listed JobHostUnits in its agents.conf [17:16] rogpeppe: I'm looking at the behaviour of HA when mongo dies but juju itself remains running [17:16] voidspace: when a majority of replicas die? [17:16] no, just when a single one dies [17:16] voidspace: it *should* just carry on working [17:17] voidspace: although there will be some churn [17:17]