| === chihchun is now known as chihchun_afk | ||
| === _salem is now known as salem_ | ||
| === chihchun_afk is now known as chihchun | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === salem_ is now known as _salem | ||
| pitti | Good morning | 04:21 |
|---|---|---|
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === _salem is now known as salem_ | ||
| elopio | brendand: please review om26er's branch: https://code.launchpad.net/~om26er/messaging-app/use_fixture/+merge/225350 | 12:54 |
| elopio | you are the one that I think will benefit with it. | 12:54 |
| elopio | rhuddie: I saw the push team writing autopilot tests. | 12:55 |
| elopio | congrats! | 12:55 |
| rhuddie | elopio, yes, they finally landed my suite yesterday | 12:55 |
| rhuddie | elopio, I hadn't realised they were adding new ones already :) | 12:56 |
| om26er | rhuddie, elopio my test is almost done, just waiting for contactsdbus stuff to be moved to address-book-app | 12:56 |
| om26er | brendand, ^ | 12:56 |
| rhuddie | om26er, that's good, I could use that in some of my address-book-app tests too | 12:56 |
| rhuddie | elopio, thanks for the info on the content-hub | 12:57 |
| rhuddie | elopio, i've not had a chance to look at it yet | 12:57 |
| brendand | elopio, looks fine to me | 12:58 |
| elopio | brendand: thanks. | 13:01 |
| elopio | om26er: brendand: in the end, did you guys discuss about how to add and remove contacts? | 13:02 |
| om26er | elopio, yes, will be using the contacts dbus api to add/remove contacts | 13:03 |
| om26er | I suggested that to be done as a fixture with a stock VCARD, that way we can just use the fixture in any project, though a parameter to the fixture could also be provided to support custom vcards | 13:04 |
| brendand | om26er, btw that code is in ubuntu-experience-tests now, so you aren't blocked. i am going to propose the branch to add it in address-book-app | 13:05 |
| om26er | brendand, yeah, my test is currently using what is in ubuntu-experience-tests | 13:05 |
| patdk-wk | crap I missed it, was on the phone wit hthe wife yesterday during that meeting/presentation/... | 13:06 |
| elopio | ok, sounds good to me, thanks. | 13:06 |
| elopio | om26er or brendand, please review https://code.launchpad.net/~elopio/ubuntu-system-settings/refactor_about_tests/+merge/225425 | 13:13 |
| elopio | the python3 branch already landed, so this is the one that's next for my UX test. | 13:14 |
| brendand | elopio, i'll review it today | 13:15 |
| elopio | thanks. | 13:15 |
| om26er | jfunk, Call time! | 13:30 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| elopio | brendand: we are sooo close. We just need your notes app branch to land, and to kill media player. | 14:56 |
| brendand | elopio, notes app did land - http://ci.ubuntu.com/smokeng/utopic/touch/mako/126:20140711.1:20140709/9000/notes_app/ | 14:59 |
| brendand | elopio, the media player fix we thought would work, didn't though | 14:59 |
| elopio | yay! | 14:59 |
| elopio | balloons: any luck reproducing the issues on barry's branch for the dialer-app? | 15:06 |
| balloons | elopio, afaict my branch should work, but I'm not sure what jenkins is running. I was curious about the weird results I got, so I added lots of debugging logging and other changes; but they don't appear in the logs for the runs. | 15:07 |
| balloons | all the tests pass, except for the 2 it shouldn't be running. there are skips, but it runs them anyway | 15:08 |
| balloons | and fails | 15:08 |
| elopio | balloons: it seems to fail on the set up, that's run before the skip. | 15:10 |
| balloons | elopio, ohh., well that probably explains it :-) I was going to do some more work on tweaking the skips so it wouldn't run them, but haven't done it | 15:11 |
| elopio | balloons: and I see your added logs here: https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2017/console | 15:12 |
| elopio | let me know if you need a hand. I just don't know what to do, but after not looking at it for a week, I have forgotten my frustration. | 15:12 |
| balloons | elopio, wow, so it did run them.. ok, well I got frustrated and left it. But I too have had a couple days away. After I finish some things this morning, I'll swing back to it | 15:13 |
| elopio | balloons: thanks. | 15:20 |
| elopio | brendand: about your helpers on the messaging app | 15:27 |
| elopio | we shouldn't add address book as a dependency to those tests. | 15:27 |
| elopio | what we should do is to check that url-dispatcher has received the right message. | 15:28 |
| === chihchun_afk is now known as chihchun | ||
| brendand | elopio, ok - good idea | 15:29 |
| brendand | elopio, any existing tests that do that? | 15:29 |
| elopio | brendand: remindersa-app is using it's own fake service. | 15:29 |
| elopio | brendand: there is a fake service on the url-dispatcher that I haven't seen when I did reminders. So I was thinking to check that one out, see if it gets installed with the url dispatcher and how to call it from the tests. | 15:30 |
| elopio | so you can duplicate the fake service for now, or try to call the one in url-dispatcher. | 15:31 |
| brendand | elopio, would i need to duplicate the code in reminders? | 15:33 |
| elopio | brendand: if you want to use the python fake, yes. | 15:33 |
| brendand | elopio, i was thinking , there are some helpers that might be useful across project, but not actually belong in a specific one. do we need a general place to put these? | 15:35 |
| === chihchun is now known as chihchun_afk | ||
| elopio | brendand: with balloons we discussed about two options | 15:58 |
| elopio | first and ideal, to get them on the related project. So if we have a helper for the url-dispatcher, put it on the url dispatcher project | 15:58 |
| elopio | second and in case the first option fails, put them on the ubuntu-ui-toolkit-autopilot | 15:59 |
| elopio | which is not bad. That project should contain all the helpers to test ubuntu sdk apps, so it makes sense to even provide things that are outside of the toolkit code. | 16:00 |
| elopio | ping om26er: is this still relevant? https://code.launchpad.net/~om26er/mediaplayer-app/fix_test_vid/+merge/212731 | 16:22 |
| elopio | rvr: I'm ready. | 16:31 |
| elopio | rvr: lets use the same meeting hangout. | 16:31 |
| rvr | elopio: Ack | 16:31 |
| om26er | elopio, don't think so, tests are passing so I guess they did something for that. | 17:11 |
| elopio | rvr: https://code.launchpad.net/~elopio/ubuntu-system-settings-online-accounts/launch_fixture/+merge/226498 | 17:31 |
| elopio | om26er: no, the test fails on my machine. | 17:31 |
| elopio | not sure why. I'll dig after a break. | 17:32 |
| === JoseeAntonioR is now known as jose | ||
| === roadmr is now known as roadmr_afk | ||
| === roadmr_afk is now known as roadmr | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!