=== jamesh__ is now known as jamesh
=== seelaman` is now known as seelaman
cjwatsonWTF sampledata09:37
cjwatsonwgrant: There's a sourcepackagepublishinghistory row in sampledata with a distroseries whose distribution doesn't match that of its archive.  Removing the distroseries checks (for non-PPAs) causes the careful-publishing tests to try to republish it.  Should I just make the relevant tests mark that series OBSOLETE and go lalalala, or should I maybe add a distribution condition to getPending*Publications as a guard against this?09:40
cjwatsonI suspect cleaning up that bit of sampledata would be an Aegean-stables exercise09:40
wgrantcjwatson: I only fixed the publication factories to prevent that situation last week. Fixing a single row shouldn't be too bad.09:42
wgrantThere was a fair bit of test fallout from the code changes, but it wasn't intractable.09:42
wgrantLet's see which pub it is.09:42
cjwatson24 was the one I found09:42
cjwatsonI'm more wondering whether this might be indicating something I need to guard against on prod09:43
wgrantIt is indeed the only one.09:44
wgrantI think I only ever did it on staging.09:44
wgrantBut I was playing around with that sort of bug before I had code access, so I forget.09:44
wgrantWorth checking on staging, I suppose.09:44
wgrantWe should fix the data rather than the code.09:44
wgrantSince the data fix is quite obvious.09:44
wgrant(except for sampledata)09:45
cjwatsonIs it?  status = DELETED or something, I guess09:45
wgrantNo, obliterate the rows entirely. They would never have moved out of PENDING.09:45
wgrantSo they are invalid and there must be no artifacts on disk.09:46
wgrantHm, so it's mozilla-firefox in ubuntu-test primary.09:47
wgrantI don't imagine there would be much direct fallout from that.09:47
wgrantThere are four broken SPPHs on prod.09:47
cjwatsonYeah, I'd just found those on DF09:48
wgrantOne of them is mine, the other three aren't.09:48
wgrantTwo of them are mine, sorry.09:48
wgrantAnd the other two are in some other PPA.09:48
wgrantAnd there shouldn't be any binaries, since they could have only have been copied from debian/primary, but let's check.09:49
cjwatsonI'm just checking that now on DF09:49
cjwatsonRather slower query ...09:49
cjwatson0 rows09:49
wgrantBPPH is several times larger, and there's an extra join.09:50
wgrant   id   | archive | distroseries | status | datepublished |        dateremoved09:50
cjwatsonSo these were Debian SPPHs that were erroneously republished in Ubuntu PPAs rather than copied properly?09:50
wgrant 483272 |      71 |           50 |      4 |               | 2009-01-26 14:03:21.73296209:50
wgrant 484547 |    2919 |           49 |      4 |               | 2009-06-13 12:47:14.88924109:50
wgrant 484546 |    2919 |           50 |      4 |               | 2009-06-13 12:47:14.88924109:51
wgrant 539825 |    7823 |           50 |      4 |               | 2009-07-31 06:13:14.75125509:51
wgrantDoes p-d-r really not restrict by distro?09:51
cjwatsonAnyway, DELETED ones aren't a problem for this09:51
cjwatsonWe might want to clean them up anyway, but the publisher isn't going to try to republish them09:51
wgrantRight, we use the source archive's series in +copy-packages, and the copier used to not validate series.09:51
cjwatsonOh, that09:52
wgrantThe copier now validates that the series exists in the target, and also the underlying model methods will refuse such madness as of last week.09:52
cjwatsonOK, I guess I fix the sampledata row and run all archivepublisher and soyuz tests or something, then09:52
wgrantso I think we just DELETE FROM sourcepackagepublishinghistory WHERE id IN (483272, 484547, 484546, 539825); on prod and probably correct the series in sampledata.09:53
wgranthttps://bugs.launchpad.net/launchpad/+bug/320398 ftr09:53
_mup_Bug #320398: Copy UI uses source distribution series names rather than target distribution series names <lp-soyuz> <package-copies> <phone-rtm> <ppa> <Launchpad itself:Triaged> <https://launchpad.net/bugs/320398>09:53
cjwatsonYeah, saw that from the phone-rtm list the other day09:53
wgrantI never thought it would be on me to clean my evil test data up :P09:54
cjwatsonThe more I work on Launchpad the more I understand why people hate and despise sampledata09:58
wgrantIt wouldn't be so bad if the sampledata was a vaguely representative sample of anything.09:59
wgrantBut, at least in the Soyuz case, it's mostly invalid crap.09:59
cjwatsonI'm just going to try removing the two broken sampledata rows (one source, one binary).  Let's see who rusts first.10:22
=== olli_ is now known as olli
cjwatsonwgrant: Would you mind re-reviewing https://code.launchpad.net/~cjwatson/launchpad/optimise-publish-a/+merge/226312 ?  I *think* I have it right now, but it took a while to sort out the details.17:04

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!