=== jamesh__ is now known as jamesh
Saviqwhoa it's quiet here today...08:04
mhr3_Saviq, what's the difference between Q_INVOKABLE and Q_SIGNAL?08:24
Saviqmhr3_, Qt deals with the function08:24
Saviqmhr3_, and I can use a SignalSpy to monitor it08:24
Saviqmhr3_, otherwise I'd need to emit myself08:24
Saviqin the test of course08:25
mhr3_Saviq, ah, so just a proper signal08:25
Saviqmhr3_, yeah yeah08:25
mhr3_Saviq, you changed pretty much everything i did for see more + header links :/08:27
Saviqmhr3_, didn't want to touch seemore qml, as it's used in previews still08:27
Saviqmhr3_, and in GSV I just did a long awaiting refactor08:28
mhr3_Saviq, btw did we decide on the interface for the thing next to departments?08:30
Saviqmhr3_, yeah, I want the same...08:31
mhr3_yey me08:32
mhr3_but yea, makes sense08:32
mhr3_Saviq, then what we're missing is interface for the no internet overlay08:33
mhr3_Saviq, and ideally also the no internet / no location info bar08:33
Saviqmhr3_, both are scope-wide are they not?08:33
mhr3_well.. search-specific08:34
mhr3_but searches are tied to the scope state08:34
Saviqmhr3_, do we need the scope to be able to override the message?08:37
mhr3_hm, good question08:37
mhr3_we do not have api for it yet08:38
mhr3_scopes lib-wise08:38
mhr3_think i'd rather limit it08:38
mhr3_marcustomlinson, fyi ^08:38
Saviqmhr3_, would we ever show both location and internet bars?08:40
mhr3_Saviq, no, when you fix internet, you'll discover that you need location too :)08:40
Saviqmhr3_, so how about an enum08:44
mhr3_Saviq, sounds good to me... unless marcustomlinson says that we can't have it as enums, and will want to pass arbitrary reasons from the scopes08:45
marcustomlinsonSaviq, mhr3_: an enum of possible error conditions (e.g. no internet, no location, no account info) is fine. But bare in mind these may be returned with partial results too08:46
mhr3_yea, we need two interfaces, one for the full overlay, and one for agg scopes when there's some results, but not all08:47
marcustomlinsonSaviq, mhr3_: yeah, so the finished() callback will give you say: a no_internet error, but you should check if there are results in the return to decide on whether to display the full overlay or not08:49
Saviqmhr3_, marcustomlinson, hmm could we have a separate enum value for the full-screen overlay, or should I take care of it in the shell?08:51
Saviqmhr3_, marcustomlinson, can there be a location full-screen one?08:51
mhr3_Saviq, haven't seen in desin08:51
marcustomlinsonSaviq, mhr3_: seems redundant. I suspect there'll be more conditions coming up in the future, and to add 2 values everytime is bit ugly08:52
mhr3_Saviq, i can easily split in into two interface in the plugin08:52
Saviqmhr3_, but maybe it makes sense if there's no results because of location either08:52
Saviqmhr3_, marcustomlinson, the only problem I can see is that if the enum value comes before results, in the UI I'd display the no-internet overlay, and then when results come I'd move it to the bar08:53
Saviqmhr3_, marcustomlinson, but then maybe I can wait for it to finish first, and only display anything afterwards08:53
mhr3_Saviq, since it will be in the finished msg, there's no way there would be more results afterwards08:54
Saviqmhr3_, ah ok08:54
Saviqmhr3_, marcustomlinson, should we maybe go for a "status" flag then08:54
Saviqfuture-proof, too08:55
Saviqand allowing for multiple status flags to be passed08:55
mhr3_Saviq, it's not like we needed stable api there :)08:55
Saviqwe only have designs for exclusive ones now, but I can make them exclusive in the UI08:56
Saviqmhr3_, marcustomlinson, so Q_FLAGS(StatusFlags) enum StatusFlags { NoInternet, NoLocation }?08:57
Saviqand then depending on whether there's any non-empty category and display full-screen or info bar08:57
Saviqinternet taking precedence08:58
mhr3_Saviq, sounds reasonable to me, though wondering if it's not too limiting when the shell has to wait for the finished08:58
mhr3_but meh, let's go with it for now08:59
Saviqwe'll get the finished straight away most times won't we08:59
Saviqfor empty queries at least08:59
mhr3_Saviq, might take a while when you have very bad internet09:00
marcustomlinsonSaviq. mhr3_: ok so where do you want to get this status from? as a parameter in the finished() callback?09:00
mhr3_marcustomlinson, i can work with that, but if you want to pass it in another way, fine with me09:01
dednickmzanetti: howdy. did you do the spead work on the untiy8 qtmir branch?09:31
mzanettidednick: yes09:32
dednickmzanetti: is the spread view the normal view for the apps? ie when they're flat as well?09:32
mzanettidednick: yep09:32
dednickmzanetti: ok thanks.09:34
mzanettidednick: any problems with that?09:36
mzanettidednick: don't really know how the trusted session stuff will work09:36
dednickmzanetti: having some crashes, but not yet sure why. crashdump is not useful.09:41
codephobicI've downloaded Sublime Text 3 and want to place it in my ubuntu 14.04 filesystem so that the icons and attendant information are picked up by Unity for the launcher and the lens. Where should I be placing the files, in order to achieve that?10:17
=== Mike is now known as Guest51633
=== MacSlow is now known as MacSlow|lunch
mhr3_Saviq, is there any reason why the logo image in the header has 1gu margins?11:52
mhr3_Saviq, shouldn't all the height be available for the image?11:53
Saviqmhr3__, why would it ever use full height?12:24
=== _salem is now known as salem_
=== MacSlow|lunch is now known as MacSlow
Saviqelopio, I need your help!12:59
mhr3__Saviq, it probably wouldn't, but without giving the full height, the logos will look different on each device13:08
Saviqmhr3__, huh?13:08
* mhr3__ thinks13:10
=== mhr3__ is now known as mhr3
mhr3Saviq, ok i guess you could, but imagine that you want your logo to be exactly half the height of the header13:10
Saviqmhr3, 4GU, done13:10
Saviqmhr3, so you make your image 6gu with 1gu padding13:11
mhr3Saviq, yea, and these calculations don't seem magical to you?13:11
Saviqmhr3, no more magical than padding with 2gu13:11
Saviqmhr3, I think it's rather easy, you get 6gu height centered vertically in the header13:12
mhr3Saviq, much more magical than just positioning the image exactly in the center13:12
mhr3positioning the logo13:12
Saviqnow do what you need to do13:12
Saviqmhr3, yeah, at what size?13:12
mhr3whatever you want, right, it will be scaled to fit13:13
Saviqmhr3, scaled, to what13:13
mhr3to those 8gu13:13
Saviqif it's scaled to fill the header, you get 8gu height13:13
Saviqand you can make it look real bad by actually making it reaching the edges13:13
Saviqvs. having 6gus to work with13:14
SaviqI can see no difference between saying it will be 8gu or 6gu vcentered13:14
mhr3that's scope authors problem13:14
mhr3if they want it to look bad, well... it will13:14
SaviqI see completely no difference TBH13:14
Saviqonly providing a better default13:15
Saviqwhich 6gu is13:15
mhr3i think it makes it more difficult to create the logo image13:15
=== Estilanda_ is now known as Estilanda
Saviqmhr3, but why?13:16
Saviqmhr3, the difference is exactly that: do a 8gu high image vs. do a 6gu high image13:17
=== olli_ is now known as olli
Saviqwe should ask those that create that logo image maybe ;P13:17
mhr3i'm actually going to talk to joshua about it13:18
Saviqmhr3, people will be throwing in random images in there, with 1gu margins built-in, the default is acceptable in most cases, without it it won't be13:19
mhr3Saviq, and you know, he has all the headers and needs to export the logo image, it's much easier to just draw a rect around the entire header, than to subtract random amount of pixels from each side13:19
Saviqmhr3, saying "random amount of pixels" is detrimental13:20
mhr3Saviq, but that's what it is, who will know the magic 8gu const?13:20
Saviqmhr3, hopefully everyone that designs anything will13:21
=== greyback is now known as greyback|lunch
mhr3maybe our designers13:21
mhr33rd party devs... yea... no13:21
Saviqmhr3, it would be at the expense of having a worse default, I really doubt it's so much hassle13:22
Saviqmhr3, we need to define what image is expected in $docs anyway13:22
Saviqmhr3, but yeah, it's neither of us that should decide13:24
Saviqmhr3, it's between Esti and Joshua to say what should be possible13:24
mhr3Saviq, ok, i'll go with whatever joshua says13:25
=== greyback|lunch is now known as greyback
Saviqtsdgeos, this should be a 1 min for you https://code.launchpad.net/~saviq/unity8/dont-preview-in-clickscope/+merge/22663814:05
* Saviq puts in a silo in the mean time14:05
* tsdgeos clicks14:07
tsdgeosSaviq: hmm, is that qmluitests regressions?14:08
Saviqtsdgeos, right, they are...14:09
Saviqtsdgeos, need to switch them to a different name proberbly14:09
tsdgeosSaviq: so what happens now with non installed stuff when you click on them?14:10
Saviqtsdgeos, there is no non-installed stuff in there14:10
Saviqtsdgeos, there is only a "go to Store" button14:10
tsdgeosah right14:10
tsdgeosforgot about that big button14:11
tsdgeosSaviq: not even in search?14:11
Saviqtsdgeos, nope, not even there14:11
Saviqtsdgeos, fix pushed14:15
elopioSaviq: I'm here.14:15
elopiohow can I help you?14:16
Saviqelopio, hey, so...14:16
Saviqelopio, because of a change in delegate management in https://code.launchpad.net/~saviq/unity8/drop-filtergrid/+merge/22641514:17
Saviqelopio, we don't get all the items in the grid if they're offscreen14:17
Saviqelopio, so we need to scroll the category in question into view firsr14:18
Saviqelopio, so I started with http://paste.ubuntu.com/7793707/14:19
Saviqelopio, but it's a little naïve...14:19
Saviqelopio, the emulator assumes the category is on screen already, otherwise _get_category_element would fail already14:20
Saviqelopio, it feels like we'd need to scroll through completely to oportunistically find the category and put it in view14:21
elopioSaviq: is the category inside a list view?14:21
Saviqelopio, it's actually inside our own custom ListViewWithPageHeader, which inherits Flickable directly14:22
Saviqelopio, but the QQuickListView emulator from UITK could potentially be abused for this, yeah14:23
elopioSaviq: probably, what we should do is to move this _find_element to the flickable, and make it public14:24
elopioin the mean time, you can copy it to your ListViewWithPageHeader. It starts swiping to top, and then swipes down one page at a time.14:25
Saviqelopio, what do I do to "register" an emulator for LVWPH?14:25
elopioSaviq: define a python class with the same name, that inherits from ubuntuuitoolkit.QQuickFlickable.14:26
Saviqelopio, should I put it somewhere special, or do you think it's good in dash.py?14:27
elopiothe name of the class should be what autopilot vis shows you. Usually it's the same as the qml file name, but sometimes Qt behaves weird.14:27
elopioSaviq: at some point we need to split dash, because it's growing big. But for now, I'd put it there.14:28
elopioSaviq: but on question. We usually don't have tests with that many data, it's not common to have to swipe an entire list to get the element that we want.14:28
elopioso, is it bad to just use the naive implementation with swipe_into_view?14:28
Saviqelopio, maybe not, you tell me14:28
Saviqelopio, well, it doesn't work as-is now, 'cause it flicks14:29
Saviqelopio, and I need to make it stop (pointers btw?)14:29
Saviqelopio, but wasn't sure you'd be fine with that approach14:29
Saviqelopio, if you are, I'm game14:29
elopioSaviq: with "it flicks" do you mean that you are swiping too fast and it goes below the category that you want?14:30
Saviqelopio, yeah14:33
Saviqelopio, well, it's not even about speed, but the fact that it releases without stopping first14:33
elopioSaviq: the parent of flickable has a method called _slow_drag14:36
elopioit works for the current cases, but yes, it probably need a better implementation.14:36
elopioyou can overwrite it. However, if you try to put a sleep before releasing the finger, you will hit an autopilot bug that's on my TODO list.14:37
ubot5Ubuntu bug 1266601 in Autopilot "Pointer move with Touch backend should take into account when it is pressed" [Undecided,In progress]14:38
elopioSaviq: which test is failing for you with swipe into view? I can give it a try.14:38
Saviqelopio, the correct_applications one14:38
* elopio branches.14:39
elopioSaviq: jenkins is not running that one? I see no errors on your MP executions.14:39
Saviqelopio, sorry, standup, back with you14:44
Saviqelopio, right, it fails locally for me though, most probably an off-by-1-pixel thing14:45
Saviqelopio, bascially around here the second row of items goes 1px further down than on jenkins ('cause it's scaled down here, not so on jenkins)14:46
Saviqelopio, and here the last row of delegates is not created, so test fails, 'cause can't find them14:46
elopioSaviq: this is interesting. I have the same problem on the toolkit scrolling big lists, probably because we are not taking into account the grid unit.14:46
elopioSaviq: what's your resolution?14:46
Saviqelopio, 1600x90014:47
Saviqelopio, and the problem shows up in the 1080p scenario, when it's scaled down 2x14:47
Saviqsize of the window, that is14:47
Saviqand GU, too14:47
elopioSaviq: that resolution is not available with my monitor, but I can try to force the 2x scale down.14:53
elopioa couple of quick things to get the test working for you:14:53
elopio- this test originally used the category 1. tsdgeos changed it to use category 2 because now the first category of the first scope is not the grid, is the strip.14:53
elopiowe use this on the click scope, that only uses the grid, so you could open the second scope on the set up of the test, and use the first category of that scope.14:53
Saviqelopio, right, that could be a quick fix indeed14:54
elopio- as it only fails on your machine for your resolution, you can ignore it for now. We have jenkins checking that it will work for the click tests, so not a big deal.14:54
elopioyou can open a bug, assign it to me, and I will take care of fixing the slow swipe during the week.14:55
Saviqelopio, ok then, that works14:55
Saviqelopio, btw, you might find that interesting https://code.launchpad.net/~saviq/unity8/cmake-pydev-fixes/+merge/22641614:56
Saviqelopio, I can launch a particular test under PyDev debugging with this14:56
elopioI haven't tried pydev. I used to love eclipse in my previous live.14:57
elopioI'll give it a try.14:57
Saviqelopio, what are you using for py dev now?14:58
elopioSaviq: emacs.14:58
Saviqelopio, do you have it integrated with a step debugger of some kind?14:58
elopioSaviq: no, I just add import pdb; pdb.set_trace() when I want to break.14:59
elopioit's not too nice, but due to vila's influence, I tried to stop debugging and start writing tests when I had problems. So now I don't do it that much.15:00
=== dandrader is now known as dandrader|afk
MacSlowSaviq, btw... https://bugs.launchpad.net/unity8/+bug/1308011 ready for human-eyes.15:01
ubot5Ubuntu bug 1308011 in Unity 8 "SIM unlock UI shifts a half-gridunit when starting and breaks easily" [High,In progress]15:01
SaviqMacSlow, thanks15:03
mhr3Saviq, ehm, the header is 6.5gu, is that right?15:04
mhr3Saviq, so with the 1gu margins the image is just 4.5gu15:05
Saviqmhr3, I invented the 8gu when I talked to you, but I think it is, lemme find something with a grid15:05
Saviqmhr3, but well, same applies, Josh and Esti need to tell us what area of the header is given to scope developers to do as they please15:06
mhall119mhr3: does the scopes test tool talk directly to the scope process, or does it need to go through Unity itself?15:30
=== Estilanda_ is now known as Estilanda
Saviqmhr3, couldn't find anything with grids, but from the redlines Josh sent me the header is 7GU, the orange tab bar overflowing it15:35
Saviqmhr3, so we should probably resolve this somehow indeed15:36
=== dandrader|afk is now known as dandrader
mhr3mhall119, it's direct15:44
mzanettiSaviq: did you unapprove the drop-filtergrid branch "just" because of jenkins or is there something else wring with it still?15:56
mhr3mhall119, what would make you think it needs unity? there's no unity running when you launch it15:58
mhall119mhr3: so would it be possible to compile a scope against the 14.10 API and have the scope test tool talk to it using the 14.10 API, without backporting the actual 14.10 functionality to 14.04?15:59
mhr3mhall119, ok, i see what you're asking now... the test tool itself it just using components from unity8, so it needs things like the new header that wasn't in 14.0416:01
mhall119mhr3: so what needs to be backported isn't the API, it's the components for the test tool?16:03
dandradermzanetti, about sending keys to the focused MirSurfaceItem. is it working now?16:03
dandradermzanetti, I saw your fix in qtmir16:03
dandradermzanetti, wondering about unity8 changes16:03
mzanettidandrader: I just wrapped the Surface in a FocusScope and call forceActiveFocus () on it when it gets focused16:03
dandradermzanetti, but what about sending keys to *both* the focused MirSurfaceItem and to the VolumeControl in Shell.qml?16:04
mzanettidandrader: it's not both... but from my testing that's actually much better...16:05
mhr3mhall119, well both, but building the api itself is trivial in T, building part of u8 that uses new sdk, where naming of half of the qml pkgs changed after 14.04... not so much16:05
dandradermzanetti, I thought we would need to send keys to both...16:06
mhall119mhr3: would it be worth doing that work so we can support scope developers on 14.04 better?16:06
mzanettidandrader: well, we had both before, and we "broke" it for apps with QtComp so I thought the easier way would be to just inject it again into both to have it at least working16:06
mzanettidandrader: but turns out, this is actually the correct solution and it just works :)16:06
dandradermzanetti, well. that16:07
dandraderthat's nice when it just works :)16:07
elopioping Saviq: I need your help to get reviews for my branches: https://code.launchpad.net/~elopio/unity8/16:07
mhr3mhall119, the question is - is it feasible16:07
elopiowell, except the precommit one. I need to apply your suggestions there.16:07
dandradermzanetti, another thing on the same subject: why do we need to wrap the surface in a FocusScope?16:07
mhall119mhr3: is it feasible?16:08
mhr3mhall119, apps already made the decision that it isn't, no?16:08
mzanettidandrader: Hmm... We could try to remove that again... I had the impression that it didn't really work without it, but when I tested there still was an issue in qtmir...16:08
mzanettidandrader: so it might not be required after all16:09
mhall119mhr3: we can still develop apps against 14.04 because not that much has changed16:09
mhr3mhall119, so you can take advantage of everything with 14.04 sdk? like the bottom swipe, and new header16:10
mhr3then apps are apparently further than scopes16:11
mhall119they are, yes16:17
mhall119we did run into a similar problem early on in app development, but back then bzoltan's team was backporting all of the SDK, including Qt, to older stable releases of Ubuntu16:18
mhr3Saviq, where there any changes to the customizations?16:25
mhr3Saviq, i'll update the docs and mention there everything we defined in the json doc16:25
=== dandrader is now known as dandrader|lunch
karniSaviq: Do you know if I can disable the blue highlight if there are links in a Preview Text widget?16:54
=== gatox is now known as gatox_lunch
=== dandrader|lunch is now known as dandrader
greybackmterry: hey, you know a nice way I can test the lockscreen?17:19
mterrygreyback, I'm building the branches in a PPA as we speak17:20
mterrygreyback, silo 00417:20
greybackmterry: but how can I test it now? I just want to enable things to when I turn on my phone & must enter a pin/passcode17:21
mterrygreyback, you can test the current demo version of it by editing /home/phablet/.unity8-greeter-demo and making it look like:17:22
greybackmterry: perfect, thank you17:22
=== alan_g is now known as alan_g|EOD
=== gatox_lunch is now known as gatox
Saviqelopio, we'll try and get those done asap, we18:11
Saviq're a bit crammed for reviews right now :|18:11
Saviqkarni, they shouldn't be there, must be we've not disabled rich text in there18:12
Saviqkarni, are the links in <a> in there or url in plain text?18:12
cwaynei think he's gone, but I believe they're in <a> tags Saviq18:15
Saviqcwayne, right, we'll have to disable those18:16
cwayneSaviq: hm, fair enough, though I know victor's been using rich text as a way to better control formatting in text/title widgets18:17
Saviqcwayne, the dash toolkit design does not allow that, though...18:17
Saviqcwayne, we'll probably have to discuss exceptions and apply a whitelist on html tags18:18
cwayneSaviq: fair enough, I think the bug victor was working around is here: https://bugs.launchpad.net/savilerow/+bug/132851318:19
ubot5Ubuntu bug 1328513 in Unity 8 "Preview header title truncated" [High,Triaged]18:19
cwayneI guess just make sure that's fixed before we disable rich text, for minimal victor pushback :)18:19
Saviqcwayne, yeah, will just drop the text size back to what's in the Card, that was old design where this was different18:20
cwayneSaviq: makes sense to me18:23
=== dandrader is now known as dandrader|afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!