| hatch | huwshimi hey, everything working out ok? | 03:08 |
|---|---|---|
| hatch | huwshimi I have a question about pr #433 when you get back | 03:09 |
| huwshimi | hatch: Yep, all good | 03:11 |
| huwshimi | hatch: What's the question? | 03:12 |
| hatch | huwshimi so is there a reason why https://github.com/juju/juju-gui/pull/433/files#diff-e6baa739d19ae967f00d894884a065acR602 can't go in the addMachines loop? | 03:12 |
| hatch | huwshimi sorry server went down :) | 03:28 |
| huwshimi | np | 03:29 |
| hatch | so did that last message make it to you about putting that stuff in the addMachines loop? | 03:29 |
| huwshimi | nope | 03:30 |
| hatch | hatch | 03:30 |
| hatch | huwshimi so is there a reason why https://github.com/juju/juju-gui/pull/433/files#diff-e6baa739d19ae967f00d894884a065acR602 can't go in the addMachines loop? | 03:30 |
| huwshimi | hatch: oh, up in the case? | 03:32 |
| hatch | yeah | 03:32 |
| hatch | looks like it can be done in the same loop so you don't have to loop twice | 03:32 |
| huwshimi | I don't see why not | 03:32 |
| hatch | excellent | 03:33 |
| hatch | huwshimi and as for the line wrapping, it's fine for now but we should fire an email off to design because I bet _every_ time you change the constraints they will wrap | 03:34 |
| huwshimi | hatch: Yeah, I'm just not sure what the problem with the line wrapping is? | 03:35 |
| hatch | oh it just doesn't look very good heh | 03:35 |
| hatch | nothing else wraps | 03:35 |
| huwshimi | hatch: OK, just pushed that change | 03:40 |
| hatch | huwshimi thanks! +1'd but I can't QA it atm so...I'll have to take your word on it ;) | 03:42 |
| huwshimi | :) | 03:42 |
| === uru-afk is now known as urulama | ||
| rogpeppe1 | mornin' all | 07:07 |
| rogpeppe1 | urulama: how're you doing today? | 07:07 |
| urulama | rogpeppe1: morning | 07:07 |
| urulama | rogpeppe1: better | 07:07 |
| rogpeppe1 | urulama: good to hear! | 07:07 |
| rogpeppe1 | urulama: is that "totally better" or "only just made it to work" better? | 07:08 |
| urulama | rogpeppe1: more of the second, but at least i am awake and am able to think :D | 07:09 |
| rogpeppe1 | urulama: well that's something... | 07:09 |
| urulama | rogpeppe1: how was your diving? | 07:17 |
| rogpeppe1 | urulama: not much diving, but some good plunges... | 07:17 |
| rogpeppe1 | urulama: a great trip down Hell Gill | 07:18 |
| rogpeppe1 | urulama: https://www.google.co.uk/search?q=hellgill&es_sm=93&tbm=isch&tbo=u&source=univ&sa=X&ei=mtXEU_nHL4ua1AWsKA&ved=0CC0Q7Ak&biw=1237&bih=600#imgdii=_ | 07:19 |
| urulama | rogpeppe1: niiiiice! | 07:20 |
| rick_h__ | morning | 11:00 |
| rick_h__ | bac: comingsoon seems to be pointing at a real env? | 13:52 |
| rick_h__ | bac: it's asking for a user login, maybe it's just missing the sandbox config? | 13:52 |
| * bac looks | 13:53 | |
| rick_h__ | bac: oh hmm, getting a diff ip | 13:53 |
| bac | 138 something? | 13:54 |
| rick_h__ | bac: right | 13:54 |
| bac | i get 138.91.155.196 | 13:54 |
| rick_h__ | 138.91.155.196 for comingsoon | 13:54 |
| rick_h__ | 138.91.154.88 for ci.jujugui.org | 13:54 |
| rick_h__ | it's on that ci machine right? | 13:55 |
| bac | comingsoon should be 138.91.154.88 | 13:56 |
| rick_h__ | luca: so working on comingsoon, looks like a dns issue ^ sorry for the trouble | 13:56 |
| luca | rick_h__: ah, it’s ok. Was just wondering if you has passworded it :) | 13:56 |
| rick_h__ | luca: no more changing for you, locked out! :P | 13:57 |
| luca | rick_h__: haha | 13:57 |
| luca | rick_h__: if you want me to stop submitting bugs you have to only ask :P | 13:57 |
| rick_h__ | luca: no, appreciate the eyeballs | 13:57 |
| rick_h__ | bac: looking at the rt it's set to 138.91.155.196 per the request | 13:58 |
| rick_h__ | bac: can you reopen or file a new rt please? | 13:58 |
| bac | rick_h__: i see that. yes, i incorrectly pointed it at the GUI managing the cluster | 14:00 |
| bac | rick_h__: comingsoon dns is corrected | 14:12 |
| rick_h__ | bac: ty much | 14:14 |
| rick_h__ | luca: ^ you should be able to access it again | 14:14 |
| luca | rick_h__: cheers | 14:14 |
| jcastro | hey rick_h__ | 14:18 |
| jcastro | I just realized something that I used to consider an annoyance | 14:18 |
| jcastro | but like, IMO should now be considered a workflow/usability buzzkill | 14:19 |
| jcastro | waiting 15 minutes for my shiny new bundle to be indexed before I can share it with the world totally saps the enthusiasm | 14:19 |
| jcsackett | jujugui: can someone look at https://github.com/juju/juju-gui/pull/435 for me? | 14:29 |
| hatch | on it | 14:29 |
| jcastro | hey bundle people: https://jujucharms.com/bundle/~jorge/hadoop-es/8/constraints/?text=hadoop-es#deploy | 14:30 |
| jcastro | if I drop the 8 from the quickstart command, will that just deploy the latest version of the bundle? | 14:30 |
| rick_h__ | jcastro: yes, it should | 14:31 |
| jcsackett | Makyo: your current work addresses bug 1340666, doens't it? | 14:32 |
| _mup_ | Bug #1340666: Clicking the destroy icon does not destroy the machine or container <juju-gui:Triaged> <https://launchpad.net/bugs/1340666> | 14:32 |
| rick_h__ | luca: carla around? | 14:35 |
| luca | rick_h__: on holiday today | 14:35 |
| rick_h__ | luca: ok thanks | 14:35 |
| luca | rick_h__: do you need anything in particular? | 14:35 |
| rick_h__ | luca: yes, we agreed to add some description field to bundles | 14:36 |
| rick_h__ | luca: and I can't find anything that notes if we kept the summary (one line) or description (couple of sentences) for it | 14:36 |
| hatch | luca thanks for the email, I forgot about THAT mockup.....(we have too many lol) | 14:36 |
| rick_h__ | luca: and wanted to see if she knew and which sized content she was designing for | 14:36 |
| luca | hatch: no worries :) | 14:36 |
| luca | rick_h__: I’ll pass the message on, she’ll be back tomorrow | 14:38 |
| rick_h__ | luca: ok ty | 14:38 |
| rick_h__ | luca: I can send her an email then. Just wondered if she just wasn't on irc | 14:38 |
| luca | rick_h__: ok :) | 14:38 |
| hatch | jcsackett review/qa done | 14:39 |
| jcsackett | hatch: thanks! | 14:39 |
| hatch | I think CI is broken on Makyo's branch | 14:39 |
| jcsackett | hatch: i concur. | 14:41 |
| bac | hatch, jcsackett: what is the issue with CI? | 14:50 |
| hatch | bac it didn't pick it up | 14:50 |
| hatch | it said 'please test this' | 14:50 |
| bac | did you manually kick it? | 14:50 |
| hatch | I'm wondering if Makyo used the wrong user account or something | 14:50 |
| hatch | you can manually kick it from GH? | 14:51 |
| bac | hatch: no. via jenkins. | 14:51 |
| hatch | oh, no, but it's odd that it didn't pick it up on GH no? | 14:51 |
| bac | yes, i guess. i haven't looked at the details | 14:52 |
| Makyo | Was on the other computer, sorry. Yes, jcsackett. I only have one account, hatch. | 14:53 |
| hatch | Makyo odd, you don't have an icon anymore, thought it was a different account | 14:54 |
| Makyo | hatch, I have an icon on my end. You running into gravatar problems? | 14:54 |
| jcsackett | Makyo: mostly he's musing at why jenkins seems to think your PR doesn't get auto tested. | 14:56 |
| jcsackett | Makyo: i'm going to throw your head on the card and assign that bug to you, if you have no objections. | 14:56 |
| hatch | Makyo GH doesn't use gravatar any longer apparently | 14:56 |
| Makyo | Yeah, that's the second time I've gotten that, too. And yes, that's fine. | 14:56 |
| Makyo | hatch, you have to set it as a separate setting. | 14:56 |
| jcsackett | Makyo: so, CI just has it in for you? :p | 14:56 |
| hatch | I have to set it to allow me to see your avatar? lol | 14:57 |
| Makyo | hatch, No, sorry, you have to add a separate gravatar email. | 14:57 |
| hatch | https://avatars3.githubusercontent.com/u/303761?s=140 that is the address for your icon | 14:57 |
| Makyo | hatch, jcsackett https://github.com/juju/juju-gui/pull/416 rick_h__ did :ok test:, is this a setting? | 14:57 |
| hatch | not gravatar | 14:57 |
| bac | Makyo: so do you want me to kick off a jenkins build for 0c9371c35e | 14:57 |
| Makyo | bac, sure | 14:58 |
| Makyo | oops, jujugui call now | 15:00 |
| rick_h__ | Makyo: & | 15:00 |
| jcsackett | :) | 15:00 |
| rick_h__ | Makyo: ^ | 15:00 |
| rick_h__ | heh next key over | 15:00 |
| hatch | http://www.meetup.com/London-React-User-Group/events/191406572/ and http://www.meetup.com/swiftly/events/192370642/ | 15:11 |
| hatch | I'm not sure I'll be attending any - just thought i'd bring it up | 15:11 |
| hatch | they are both fairly close | 15:11 |
| hatch | couple tube stops away | 15:11 |
| kadams54 | jujugui: my wifi died just as I was joining standup. Currently using my cellphone as a hotspot, but I don't get great coverage in my house. Restarted the router twice and still can't see wifi so not sure when I'll have dependable internet again. | 15:12 |
| hatch | kadams54 are you using a 2Wire router? Thats what our isp provides and it's junk | 15:12 |
| hatch | lol | 15:12 |
| hatch | rick_h__ watch should arrive today......it's on the truck! | 15:18 |
| rick_h__ | hatch: woot! | 15:20 |
| rick_h__ | got in trouble with my wife about it :P | 15:20 |
| hatch | lol - that's how you know it's a good purchase! | 15:20 |
| hatch | with my luck mine won't even work | 15:20 |
| hatch | hahaha | 15:21 |
| rick_h__ | battery dead | 15:24 |
| rick_h__ | must charge for 8hrs before you can use it :P | 15:24 |
| hatch | lol son-of-a | 15:32 |
| rogpeppe1 | rick_h__: a bit of googling solved it | 15:40 |
| rogpeppe1 | rick_h__: jeeze google don't make intuitive UIs these days | 15:41 |
| bac | Makyo: so the build for your branch failed on jenkins, but since it was started manually didn't report back to github. http://ci.jujugui.org:8080/job/juju-gui/1417/console | 15:41 |
| hatch | lint failure | 15:43 |
| rick_h__ | rogpeppe1: ah awesome! | 15:43 |
| rick_h__ | rogpeppe1: I've given up and just make sure I create the doc from the folder. I fail at moving it | 15:43 |
| rogpeppe1 | rick_h__: i added the folder to my drive, then dragged the doc from to the folder | 15:44 |
| rogpeppe1 | rick_h__: i guess you can't add stuff to folders unless they're in "My Drive". | 15:45 |
| rick_h__ | rogpeppe1: oh, interesting | 15:45 |
| rick_h__ | luca: ping got a sec before your EOD? | 15:49 |
| luca | rick_h__: hey, yes I do | 15:49 |
| rick_h__ | can you jump in the standout hangout? | 15:49 |
| luca | omw | 15:49 |
| * rick_h__ goes to get lunch | 16:10 | |
| jcsackett | luca: i'm working on bug 1339779, and it seems a bit odd as listed. do you just want containers to not be shown if the machine they're on has also just been created? b/c i figure we should show something in the deploy confirmation if your just creating a container on a machine that already exists. | 16:23 |
| _mup_ | Bug #1339779: Containers that are created in MV should not be shown as part of the "Machines created" section in the deployment summary <juju-gui:Triaged by jcsackett> <https://launchpad.net/bugs/1339779> | 16:23 |
| jcsackett | also: you only reference the deploy confirmation--do you also mean the regular summary? | 16:24 |
| luca | jcsackett: if your just creating a container thats a minor change which incurs no extra cost so it should be part of the deployment summary | 16:25 |
| jcsackett | luca: ok, so just hide it from the summary if the machine it's on is also being created. | 16:26 |
| luca | jcsackett: creating a container doesn’t constitute a new machine either so the “Container created” message shouldn’t be populated within the “Machines created” summary section. | 16:26 |
| luca | jcsackett: well, it should be hidden regardless if the machine is new or old | 16:27 |
| jcsackett | luca: so, you want a new "Containers added" section as well--in that case rather than not showing the container when the machine is created shouldn't we just put in the container section? | 16:27 |
| luca | jcsackett: no, I think I’m confusing issues with the wording of the bug. | 16:27 |
| jcsackett | luca: i'm certainly confused. :p | 16:27 |
| luca | jcsackett: I don’t want to show that containers have been created at all in the deployment summary | 16:27 |
| luca | jcsackett: the only place it should be visible is in the complete change log | 16:28 |
| luca | jcsackett: sorry! | 16:28 |
| jcsackett | luca: ok. | 16:28 |
| jcsackett | one usability thing then--if i create a container, i either a) have created something, but see no indication that i can commit that change, or b) see i can commit the change, but when i get a confirmation there's nothing there. | 16:28 |
| luca | jcsackett: well, for a) you’ll see a single change in the change log if you open the curtain. b) if there are no big changes made to populate the summary the full change log should be open by deafult. | 16:30 |
| jcsackett | luca: ah, ok. | 16:31 |
| jcsackett | luca: so if i just create a container, when i go to deploy we'll open the changelog rather than displaying the summary thing. | 16:32 |
| jcsackett | that makes more sense. | 16:32 |
| luca | jcsackett: yeah, though I’m not sure that was ever built in. | 16:32 |
| jcsackett | luca: i dn't believe that behavior exists yet, no. | 16:32 |
| jcsackett | but i think it's in scope for this branch. | 16:32 |
| luca | jcsackett: ok, cool | 16:33 |
| jcsackett | luca: thanks for the clarification. :) | 16:33 |
| luca | jcsackett: no worries, I’m happy to help :) | 16:33 |
| hatch | interesting perf results .apply() .bind() .call() http://jsperf.com/function-calls-direct-vs-apply-vs-call-vs-bind/40 | 16:37 |
| hatch | 2-more-tests | 16:49 |
| rick_h__ | bac: can you peek at https://bugs.launchpad.net/bugs/1311321 and help post a verification so they can move forward with 1.3.2 into trusty? | 16:59 |
| _mup_ | Bug #1311321: ascii can't decode error in 14.04 server install <verification-needed> <juju-quickstart:Fix Released by frankban> <juju-quickstart (Ubuntu):Fix Released> <juju-quickstart (Ubuntu Trusty):Fix Committed> <https://launchpad.net/bugs/1311321> | 16:59 |
| rick_h__ | tvansteenburgh: I see your recent MP go by. We'd love to make sure you take a peek at the charmstore api doc emailed out to make sure the api there will help all your needs . | 17:02 |
| tvansteenburgh | rick_h__: cool, is this email already sent? | 17:02 |
| rick_h__ | tvansteenburgh: yes, it was sent to juju-dev | 17:03 |
| tvansteenburgh | rick_h__: k, will take a look, thanks | 17:03 |
| rick_h__ | tvansteenburgh: we've got a few specs you and your team might be interested in, /me goes for the link | 17:04 |
| rick_h__ | tvansteenburgh: https://docs.google.com/a/canonical.com/document/d/1TgRA7jW_mmXoKH3JiwBbtPvQu7WiM6XMrz1wSrhTMXw/edit | 17:05 |
| tvansteenburgh | rick_h__: thanks | 17:05 |
| * rick_h__ moves to the coffee shop | 17:22 | |
| hatch | does anyone know how I remove a file from a series of commits? | 17:25 |
| rogpeppe | computer crashed, just like that. luckily i'd saved my recent changes, phew. | 17:26 |
| rogpeppe | a good sign i should stop though. | 17:26 |
| rogpeppe | g'night all | 17:26 |
| hatch | rogpeppe you should use a real editor :P night | 17:26 |
| rogpeppe | hatch: actually, i've been meaning to make acme do a periodic dump for ages. | 17:27 |
| rogpeppe | hatch: it already supports dumping the whole state of the editor - but just manually. | 17:27 |
| rogpeppe | (or if the editor is killed) | 17:27 |
| rogpeppe | kernels shouldn't crash just like that | 17:27 |
| hatch | sublime does some auto-save-to-temp, so anytime it crashes or whatever the changes are always there but not reflected in the original unless saved | 17:27 |
| hatch | heh nope they shouldn't | 17:28 |
| rbasak | rick_h__: so juju-quickstart SRU landed in trusty-proposed. We need to get these bugs verified from the binaries in trusty-proposed itself now. | 17:28 |
| rogpeppe | once upon a time they'd at least produce a panic message so you had *some* idea what the problem might be | 17:28 |
| rbasak | rick_h__: I know you had some ongoing CI efforts going. I wonder if you could run the same CI against trusty-proposed as an easy way to automate this verification? | 17:28 |
| rogpeppe | but this has happened a few times to me - the whole thing just switches off and on again | 17:28 |
| rogpeppe | darn, i have lost more stuff than i thought. | 17:30 |
| hatch | jujugui I need a review and qa for the new scale-up UI branch https://github.com/juju/juju-gui/pull/437 plz and thanks | 17:34 |
| kadams54_ | hatch: I can take a look | 17:34 |
| hatch | rogpeppe :-( | 17:34 |
| hatch | kadams54_ thanks | 17:34 |
| rick_h__ | rbasak: thanks for the heads up. We'll work on getting that QA'd. | 17:44 |
| rick_h__ | rbasak: the CI efforts aren't ready currently, we'll manually QA. I'm not sure how we'd automate off the proposed package. That's an interesting idea to look into. | 17:44 |
| rick_h__ | we normally do things off the source | 17:45 |
| rick_h__ | damn glossy laptop screens, outdoor fail | 17:47 |
| hatch | haha, just sit facing the sun :) | 17:47 |
| rick_h__ | I'm in the shade but like I'm trying tinto a mirror | 17:47 |
| rick_h__ | typing that is | 17:47 |
| hatch | hmm odd mine isnt like that | 17:48 |
| hatch | is this your new dell? | 17:48 |
| hatch | "Dude you got a Dell!" | 17:49 |
| rick_h__ | hatch: yea, stupid thing | 17:49 |
| rick_h__ | hatch: you on the test failures for your branch? | 17:52 |
| hatch | rick_h__ yeah, iunno wth is going on | 17:53 |
| hatch | looks like the third manually triggered run is still going | 17:54 |
| * hatch crosses fingers | 17:54 | |
| rick_h__ | hatch: :/ it seemed to be a legit test there | 17:54 |
| hatch | yeah I know, but I can't reproduce that failure locally running prod/debug on phantom or chrome | 17:55 |
| rbasak | rick_h__: OK - thanks! | 17:59 |
| rick_h__ | rbasak: thank you | 17:59 |
| rbasak | rick_h__: oh, wait. Note that the juju-core SRU still needs further review. You might be broken until that goes from 1.18.1 to 1.18.4. | 18:00 |
| rick_h__ | bah, and rain clouds on the way. Curse you mother nature for giving me a great day but not able to enjoy it. | 18:00 |
| rbasak | (if you need that - I forget) | 18:00 |
| hatch | watch hath arrived | 18:00 |
| rick_h__ | rbasak: no, I think our update was only tied because of 1.18.1? We're actually tied to 1.18.0 as far as our release goes | 18:00 |
| rick_h__ | it was a response to bugs presented by the 1.18.0 release | 18:01 |
| rbasak | rick_h__: OK - it might not actually be broken then. | 18:01 |
| rbasak | In any case, if it is, it's fine to wait until it lands. | 18:01 |
| * rbasak needs to run | 18:01 | |
| hatch | looks like the test failure is legit....now to figure out why... and why I can't reproduce it locally | 18:07 |
| hatch | kadams54_ I'm not sure I understand your qa issue | 18:08 |
| kadams54_ | hatch: which one? | 18:08 |
| hatch | the first one | 18:08 |
| hatch | you can't place two units on bare-metal | 18:08 |
| kadams54_ | Doesn't mean people won't try :-) | 18:09 |
| hatch | sure - but that's not related to this branch | 18:09 |
| kadams54_ | Right now we allow it and it gets everything into a funky state | 18:09 |
| kadams54_ | Maybe a new bug then? | 18:09 |
| hatch | I'll try a qa doing that on a container and see what happens | 18:09 |
| bac | rick_h__: i found the charmworld ngram search error and will be finishing up shortly | 18:11 |
| hatch | kadams54_ can you elaborate with a step-by-step on point 1? I can't reproduce it | 18:11 |
| rick_h__ | bac: awesome, thanks for that | 18:12 |
| kadams54_ | hatch: on a container or on the bare metal? I just tried on a container and I still get stuck with one change that just won't commit… | 18:12 |
| hatch | kadams54_ yeah I need step-by-step because it's working perfect here | 18:12 |
| kadams54_ | hatch: also doing a clean build right now to make sure it's not something on my end. | 18:12 |
| kadams54_ | hatch: How about a screenshare? | 18:14 |
| kadams54_ | hatch: still seeing problems after a clean build. | 18:14 |
| hatch | yeah sure | 18:15 |
| hatch | standup room? | 18:15 |
| hatch | ok in | 18:15 |
| kadams54_ | k | 18:15 |
| hatch | rick_h__ u got a sec? | 18:18 |
| hatch | join the standup room? | 18:18 |
| rick_h__ | hatch: loading | 18:18 |
| hatch | I'm going to step away for some lunch, when I return I'll track down that CI issue with my branch. | 18:27 |
| kadams54_ | hatch: still running into a JS error, even with one unit per container. Ping me when you're back from lunch. | 18:35 |
| jrwren | ping https://github.com/juju/charm/pull/17 | 19:05 |
| rick_h__ | jrwren: so normally just ping that with the jujugui highlight | 19:06 |
| rick_h__ | jrwren: and please make sure your irc client is setup to highlight on jujugui | 19:06 |
| rick_h__ | Makyo: you up for a tiny Go review? ^ | 19:06 |
| kadams54_ | So many jujugui pings… | 19:06 |
| Makyo | Sure | 19:06 |
| rick_h__ | kadams54_: just for you :P | 19:06 |
| kadams54_ | :-) | 19:06 |
| jcsackett | and then try not to ping too much on jujugui if hatch is anywhere near you, as his sound effect is annoying. :p | 19:06 |
| rick_h__ | lol | 19:07 |
| kadams54_ | Good things to know before next week | 19:07 |
| bac | jcsackett: i think we're at a safe distance atm | 19:07 |
| bac | jcsackett: and you know he only turns that on when you're around | 19:07 |
| jcsackett | for his own sanity, i should hope so. | 19:08 |
| jrwren | highligh jujugui like this? :p | 19:08 |
| rick_h__ | jrwren: :) | 19:08 |
| kadams54_ | Yup, now all jujugui knows. | 19:08 |
| jcsackett | jrwren: you should work out just fine in this group. :p | 19:08 |
| jrwren | i may have done that wrong. jujugui like this. | 19:09 |
| * kadams54_ giggles. | 19:09 | |
| jrwren | i really want to keep going, but I shall practice restraint. | 19:09 |
| jrwren | what is the process now? do /I/ go merge the pull req? | 19:15 |
| rick_h__ | jrwren: for now just hit the merge button | 19:15 |
| rick_h__ | jrwren: there's work to pull that into a CI system with juju-core and other deps and eventually it'll hopefully be part of a CI process | 19:15 |
| jrwren | oh, i don't have write access | 19:16 |
| rick_h__ | jrwren: oh hmm, /me checks perms | 19:16 |
| rick_h__ | jrwren: added you to juju org, make sure to go to https://github.com/orgs/juju/members and mark your membership as public please | 19:17 |
| jrwren | done | 19:18 |
| jrwren | push the green button | 19:18 |
| rick_h__ | jrwren: cool then mark the card as done by moving to daily call | 19:18 |
| rick_h__ | jrwren: and I think you can move forward with the description card now. I don't think if we have a summary (1 sentence) or longer it matters to the source. | 19:19 |
| jrwren | ok | 19:20 |
| jrwren | jujugui: https://github.com/juju/charm/pull/19 | 19:44 |
| hatch | kadams54_ back | 19:46 |
| hatch | kadams54_ I'll need you to put the exact step-by-step instructions in the PR as I cannot reproduce any errors | 19:49 |
| hatch | jujugui anyone have a free moment to run some tests locally for me to see if they fail? | 19:52 |
| jrwren | maybe? | 19:54 |
| jrwren | hatch: what tests? | 19:54 |
| hatch | the gui's make test-prod and test-debug tests | 19:54 |
| hatch | do you have phantomjs and whatnot installed? | 19:54 |
| hatch | jrwren actually you can forget it I figured out a way to make it fail locally | 19:56 |
| hatch | thanks though | 19:56 |
| bac | jcsackett, rick_h__: could either of you review and QA my charmworld branch? https://codereview.appspot.com/117810044 | 19:56 |
| hatch | jujugui the :checked psudo selector does NOT work in phantomjs..... | 20:06 |
| hatch | 'input[name="placement"]:checked' | 20:06 |
| bac | jrwren: i looked at your branch and made some trivial suggestions. i think we're deferring to rogpeppe and frankban for final approvals. | 20:06 |
| hatch | ugh | 20:06 |
| jrwren | thanks for catching typos. Pretty lazy on my part. | 20:08 |
| kadams54_ | hatch: yeah, that also bit me awhile back. | 20:09 |
| hatch | what a piss-off | 20:10 |
| hatch | lol | 20:10 |
| rick_h__ | bac: I've hit EOD and have to run to swim class. Let me know if jcsackett isn't available and I can qa it in the morning | 20:10 |
| bac | rick_h__: happy swimming | 20:11 |
| rick_h__ | heh, 4ry old almost drowing ftw | 20:11 |
| rick_h__ | drowning | 20:11 |
| hatch | lol - he'll learn :) | 20:13 |
| kadams54_ | hatch: added steps to the PR. Let me know what happens. | 20:18 |
| hatch | thanks, checking | 20:18 |
| hatch | kadams54_ ok I can reproduce what you're seeing now - lemme take a look to see where the issue is | 20:21 |
| jrwren | i'm done for day, but i'm taking the kid to gymnastics and working more from there :) | 20:23 |
| hatch | kadams54_ very odd bug....nice catch, this might be a bigger issue, I'll see if I can do a driveby | 20:28 |
| kadams54_ | Yay? ;-) | 20:29 |
| hatch | lol | 20:29 |
| hatch | better we found this now that in 2 weeks | 20:29 |
| bac | jujugui: anyone want to do a charmworld review and QA? changes are pretty straightforward. https://codereview.appspot.com/117810044 | 20:30 |
| hatch | bac I don't have charmworld set up but I can after I get mine landed | 20:31 |
| hatch | will likely be a while heh sorry | 20:31 |
| bac | hatch: no prob | 20:34 |
| hatch | jujugui ^ if anyone wants to take this review/qa before me feel free to do so | 20:35 |
| Makyo | hatch, bac on it. | 20:35 |
| hatch | thanks Makyo | 20:35 |
| bac | ty Makyo | 20:35 |
| hatch | kadams54_ this is fixable...fixing | 20:38 |
| hatch | :) just keeping you posted I guess heh | 20:39 |
| kadams54_ | :-) | 20:39 |
| kadams54_ | Thanks | 20:39 |
| kadams54_ | How's the fixing going? | 20:39 |
| kadams54_ | 10% 25% 76% done? | 20:39 |
| hatch | good - I !@#$%^&* it up | 20:39 |
| hatch | :P | 20:39 |
| hatch | lol | 20:39 |
| kadams54_ | LOL | 20:39 |
| kadams54_ | Well that didn't take long | 20:39 |
| hatch | just giving credit where credit is due ya know... | 20:39 |
| hatch | kadams54_ and fixed....aww yeah | 20:42 |
| kadams54_ | Sweet… | 20:42 |
| hatch | kadams54_ heh I had this like this before and must have removed it by accident or something https://gist.github.com/577c30b5dc9fec36b895 | 20:42 |
| hatch | oops | 20:43 |
| kadams54_ | My honor to break it then :-) | 20:43 |
| hatch | haha | 20:43 |
| hatch | linting, running tests then will be good for another qa | 20:44 |
| hatch | when is your EOD? | 20:44 |
| hatch | kadams54_ ok ready to go for another QA | 20:49 |
| bac | Makyo: i'm going to take the dog out. will be back later. | 21:06 |
| Makyo | bac, can't log into RV to say so, but LGTM, QA okay | 21:09 |
| hatch | oh darn he left | 21:20 |
| hatch | jujugui anyone able to do another review/qa on https://github.com/juju/juju-gui/pull/437 ? | 21:20 |
| hatch | rick_h__ do you know if you can send hangout messages from this watch? It seems to only support sms | 21:22 |
| rick_h__ | hatch: I use hangouts as my sms app so not sure. | 21:27 |
| rick_h__ | when I send it uses hangouts and not sure what it ends up doing | 21:27 |
| hatch | yeah it seems to only send via SMS not hangouts | 21:27 |
| hatch | well hangouts app | 21:27 |
| hatch | bit sms | 21:27 |
| hatch | but* | 21:27 |
| hatch | kind of odd | 21:27 |
| rick_h__ | hatch: ping me via hangouts and I'll see if I can reply :P | 21:28 |
| rick_h__ | to mitechie not canonical | 21:28 |
| hatch | oh I don't have it | 21:28 |
| hatch | my wife stole it | 21:28 |
| hatch | lol | 21:28 |
| rick_h__ | lol | 21:30 |
| hatch | so....I may not have a watch anymore? | 21:31 |
| hatch | haha | 21:31 |
| hatch | guess time will tell | 21:31 |
| rick_h__ | needed a watch strap with a lock on it :) | 21:32 |
| rick_h__ | though I suppose losing a watch > losing an arm | 21:32 |
| hatch | haha - it's unfortunate it doesn't have a speaker | 21:32 |
| hatch | would be nice to answer calls on it | 21:32 |
| rick_h__ | no, no it would not | 21:32 |
| rick_h__ | go get that samsung thing with that stuff if you want that | 21:32 |
| hatch | the samsung one has a speaker? | 21:32 |
| bac | Makyo: would you mind adding your approval and comments to the MP in launchpad? https://code.launchpad.net/~bac/charmworld/ngram-inquiry/+merge/226910 | 21:53 |
| bac | Makyo: and thanks for looking at it. | 21:53 |
| hatch | Makyo I think there is something wrong with your GH account - your new branch isn't being tested either | 22:07 |
| Makyo | hatch, the only variable I can think of is whether or not my membership is public. Will make sure. | 22:08 |
| hatch | I still don't get any photo for you, but I do for everyone else | 22:08 |
| Makyo | I get a photo for myself on all devices. | 22:08 |
| hatch | weird | 22:09 |
| rick_h__ | Makyo: why does CI hate you and not want to test your branches? | 22:10 |
| hatch | rick_h__ do you see an avatar for him on GH? | 22:11 |
| rick_h__ | the drinking dog? | 22:11 |
| Makyo | It's an arctic fox dressed in a victorian suit with a gin and tonic, I'll have you know. | 22:11 |
| hatch | I see a grey octopus | 22:11 |
| rick_h__ | Makyo: oh, well in that case :P | 22:12 |
| Makyo | Hahaha | 22:12 |
| hatch | lol!!] | 22:12 |
| Makyo | It was leftover from gravatar, which I see has been removed. | 22:12 |
| hatch | oh so I was right? They did remove gravatar support? | 22:12 |
| hatch | I remembered reading something about that, but wasn't sure if I remembered right | 22:13 |
| Makyo | hatch, yeah, since I last checked I guess. | 22:13 |
| Makyo | It's been ages. | 22:13 |
| hatch | very odd that you can see your avatar though | 22:13 |
| hatch | lol | 22:13 |
| huwshimi | Morning | 22:58 |
| hatch | morning huwshimi how you doing? | 23:01 |
| huwshimi | hatch: Hey, good thanks. Yourself? | 23:01 |
| hatch | good good, just doing some CSS remembering why I hate it | 23:02 |
| hatch | huwshimi it would be awesome if you could review/qa this https://github.com/juju/juju-gui/pull/437 | 23:03 |
| huwshimi | hatch: code review and QA? | 23:06 |
| hatch | yeah please - kadams54 ran into a few issues, one was an unsupported feature that we haven't blocked yet and the other I resolved | 23:06 |
| hatch | I'm doing the follow-up to remove the old code right now so would like to get both of these landed for my SOD tomorrow | 23:07 |
| hatch | gona put in a little OT to get it done | 23:07 |
| huwshimi | hatch: QA seems good | 23:16 |
| bac | morning huwshimi | 23:16 |
| huwshimi | bac: Hey | 23:16 |
| bac | bye huwshimi | 23:16 |
| bac | :) | 23:16 |
| huwshimi | bac: Bye | 23:16 |
| huwshimi | hatch: So do you want me to do the code review on this branch or your followup? | 23:18 |
| hatch | huwshimi both? :) unless you're too busy to do it | 23:18 |
| huwshimi | hatch: No that's fine I just do know what you're going to change that's all | 23:21 |
| hatch | oh the follow-up is just the old code removal, styling fixes from said removal, and fixing it so you can't scale-up subordinates | 23:22 |
| huwshimi | ah ok | 23:22 |
| hatch | rick_h__ here is another critical one for the mv stuff https://bugs.launchpad.net/juju-gui/+bug/1342414 | 23:29 |
| _mup_ | Bug #1342414: Deploying subordinate services with machine view fails <juju-gui:New> <https://launchpad.net/bugs/1342414> | 23:29 |
| rick_h__ | hatch: looking | 23:30 |
| rick_h__ | hatch: ty | 23:31 |
| hatch | huwshimi https://github.com/juju/juju-gui/pull/439 new follow-up | 23:36 |
| hatch | it has so many commits because it's branched off the previous PR | 23:36 |
| hatch | so most of the commits should go away once that one lands | 23:36 |
| hatch | oops lint error, fixing | 23:39 |
| huwshimi | I'm just going to go with a maybe on the code | 23:40 |
| hatch | lol yeah? | 23:42 |
| hatch | huwshimi we are disabling form submits on enter because they may have done it by accident and atm we can't remove unplaced units :) | 23:43 |
| hatch | I'll reply in the PR | 23:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!