| thomi | elopio: thoughts? https://docs.google.com/a/canonical.com/document/d/1dLdjvRbrILs3314dBM7sKazHDJgeFe3i2E5Rk5pJHTM/edit# | 00:11 |
|---|---|---|
| thomi | elopio: you have edit / comment rights now | 00:11 |
| elopio | checking. | 00:11 |
| thomi | elopio: I need to go to lunch and run some errands in town. I'll be back in about an hour. Please leave notes (if you have any) in that docuemnt | 00:17 |
| elopio | thomi: is the comma part of xpath? I thought it would be something like | | 00:17 |
| elopio | thomi: ack, I'll comment. | 00:17 |
| thomi | elopio: well, we can make it part of it | 00:17 |
| thomi | elopio: I'm open to alternative suggestions for syntax though | 00:17 |
| thomi | ok, bbs | 00:17 |
| elopio | thomi: I might not be here when you return. It looks really good for me. I left you some comments, and I will show it to the toolkit devs tomorrow. | 00:29 |
| thomi | elopio: ok, thanks | 01:38 |
| thomi | elopio: still around? | 01:39 |
| thomi | veebers: could you please review https://code.launchpad.net/~thomir/autopilot/refactor-test-logger/+merge/226063 | 01:45 |
| elopio | thomi: I'm back. | 04:03 |
| thomi | elopio: I replied to your comments | 04:03 |
| thomi | elopio: note that no one will ever actually see the query bytestring | 04:04 |
| thomi | elopio: but I expanded the code examples to show how this fits with the existing validate_dbus_object method | 04:05 |
| elopio | thomi: I thought xpathselect was a subset of xpath. If that's private, do it as you prefer. | 04:06 |
| elopio | I'll report the bug about the cache tomorrow. It will take a little more time to make a small example for that one. | 04:07 |
| thomi | elopio: yeah, it's only commonality is the name :) | 04:08 |
| thomi | I picked a poor name 3 years ago, and it stuck :( | 04:08 |
| thomi | ever since then I've hated it | 04:08 |
| elopio | thomi: rename it to xps ;) | 04:08 |
| thomi | that's a good idea, I might just do that | 04:09 |
| thomi | libxps | 04:09 |
| elopio | barry: hey, can you resubmit your mediaplayer branch with this one as a prerequisite? | 14:59 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/mediaplayer-app/fix1341956-test_no_video/+merge/226774 | 14:59 |
| barry | elopio: sure | 14:59 |
| barry | elopio: done. crossing fingers! :) | 15:02 |
| elopio | barry: thanks. | 15:02 |
| elopio | barry: please fill the MP checklist on your mediaplayer branch | 18:05 |
| elopio | https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps | 18:05 |
| === rpadovani_ is now known as rpadovani | ||
| barry | elopio: done; let me know if that's sufficient | 19:37 |
| elopio | barry: well, now that you ask, it would be nice for you to merge with the prerequisite, so Jenkins gives you the approval. | 19:37 |
| barry | elopio: you want me to merge the prereq branch into mine and push? | 19:38 |
| elopio | barry: yes. That way the test that fails on your MP will be skipped. | 19:38 |
| barry | elopio: gotcha | 19:38 |
| barry | elopio: done | 19:41 |
| elopio | barry: thanks. | 19:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!