=== salem_ is now known as _salem === beidl_ is now known as beidl === _salem is now known as salem_ === maxb is now known as Guest41692 === salem_ is now known as _salem === Morgawr is now known as Guest56494 [07:22] Saviq: went through all MR again and checked if they merge fine, there's no new broken ones afaics [07:30] tsdgeos, ktx [07:30] Saviq: there's something wrong in CI [07:30] or in our code [07:30] not sure where [07:30] but see https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/431/consoleText [07:31] search for "Totals: 2 passed, 1 failed, 0 skipped" [07:31] then see https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/431/? [07:31] and is green [07:31] oh interesting === Guest41692 is now known as maxb [07:33] and make xvfbtestDashContent seems to be failing in trunk now [07:33] :/ [07:33] for me locally [07:33] passed now [07:33] unstable then [07:34] tsdgeos, the card creator test somehow isn't picked up in test results at all https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/431/testReport/%28root%29/ [07:34] :/ [07:35] maybe i did something wrong? [07:35] tsdgeos, doesn't look like it [07:35] doesn't look like it to me either [07:35] but then what? [07:36] tsdgeos, we'd need to record the .xml files as artifacts from the job, I'll talk to Francis later [07:39] tsdgeos, ah, there's no output at all? [07:39] Saviq: what do you mean no output? [07:39] tsdgeos, no .xml file [07:39] hmmm [07:39] ah no [07:40] it's there [07:40] there should [07:40] different name between testCardCreator and xvfbtestCardCreator, though (Test.xml vs. CardCreatorTest.xml) [07:41] hmmm [07:41] but yeah, we'll have to pick the files up from the runs [07:41] Test.xml looks fishy [07:41] yeah, but on jenkins it's running xvfb so it's correct [07:41] Saviq: but the other tests do the same, why isn't this the one working? [07:42] tsdgeos, no idea atm [07:56] @unity hey, we need volunteers for reviews: [07:56] https://code.launchpad.net/~mterry/unity8/is-active/+merge/223653 [07:56] https://code.launchpad.net/~mterry/unity8/show-greeter-dbus/+merge/224942 [07:56] https://code.launchpad.net/~mterry/unity8/dialer-above/+merge/226476 [07:56] https://code.launchpad.net/~mterry/ubuntu-system-settings/locking-hash/+merge/224346 [07:56] https://code.launchpad.net/~mterry/unity8/locking-hash/+merge/225538 [07:57] mzanetti, you already looked at the first one, would be good to follow up [07:57] Saviq: ack [07:57] Saviq: what's with this one? https://code.launchpad.net/~aacid/unity8/removeDuplicateCheckers/+merge/221365 [07:57] mzanetti, https://code.launchpad.net/~aacid/unity8/removeDuplicateCheckers/+merge/221365/comments/532483 [07:58] mzanetti, we probably just need to agree on something [07:58] Saviq: yeah, I've read the comments... but it doesn't say needs fixing or something [07:58] mzanetti, because we don't know what it needs ;) [07:58] Saviq: I either you're ok with the checker.png, or we should put it to WIP [07:59] mzanetti, the show-greeter-dbus is 100 lines, please take that, too [07:59] ok [08:05] dednick, hey, would you have time to review https://code.launchpad.net/~mterry/unity8/dialer-above/+merge/226476 please? [08:06] Saviq: sure [08:06] tx [08:09] dednick: qmenumodel doesn't merge automatically? I added a nameOwner property for MacSlow last week: https://code.launchpad.net/~larsu/qmenumodel/add-nameowner-property/+merge/226428 [08:10] larsu: um, i don't think anything merges automatically anymore does it? [08:11] I don't know [08:11] it used to, no? [08:11] larsu: i think you need landing requests [08:11] larsu: yes, it used to [08:12] dednick: bah. Who do I talk to for those? [08:12] larsu: probably thostr_ [08:12] dednick: thanks [08:12] or maybe Saviq [08:13] Saviq, thostr_: morning. Can one of you please initiate a landing for the above branch please? [08:13] larsu: there's a spreadsheet somewhere detailing who is responsible for each project... trying to find [08:13] https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0Au6idq7TkpUUdC05a2ZQSmgwU2NFYnJQOE9qMDRYa3c&usp=drive_web#gid=0 [08:14] dednick, but that one's not there [08:14] ah yes it is [08:14] but has no owner ;) [08:14] Saviq: i would say it's probably ours [08:14] kk [08:15] larsu, could I land this with Mirco's changes later, or is it pressing to land earlier? [08:16] Saviq: Mirco was the one who asked me for the change. It should be fine to land this with his stuff [08:17] larsu, yup, will do [08:17] I just wanted to follow up to make sure it lands at all [08:17] Saviq: thanks° [08:17] *thanks! [08:27] tsdgeos, sanity check, if we qmlRegisterSingletonType, we don't get enums on it in QML do we? [08:28] Saviq: don't know to be honest [08:28] but if we don't i'd call it a bug [08:28] * Saviq checks something [08:32] tsdgeos, wrong, we do [08:32] nice then :) [08:33] yup [08:50] larsu: dednick: Saviq: added the MP to CI [09:01] Saviq: anything i need to get this emergency call button showing? [09:01] thostr_, I wanted to land it later, but if you have a landing, great [09:01] dednick, TBH no idea, Description doesn't say? [09:01] doesnt seem to be showing up. [09:02] Saviq: feel free to edit the line... [09:02] thostr_, yeah, let's just wait with this, I'll land it along with the related unity-notifications / unity8 changes when they're ready [09:03] thostr_, gave this up, too small a change to warrant testing by itself [09:03] ok, mark it with not ready [09:03] Saviq: doesnt seem so, i've seen the icon before, but only because of a bug in code i wrote :/. I'll check with mterry later if i can't figure it out [09:03] Saviq: ok [09:03] dednick, k [09:05] Saviq: ah. it's on lock screen, not greeter. er. how do i set a password?! [09:06] mzanetti: how do i set a phone password? [09:07] dednick: I think its still the ~/.unity8-greeter-demo file [09:07] dednick: add that file with "pin=1234" or "passkey=foobar" [09:07] then it should appear next time you lock the greeter [09:08] dednick: if that doesn't work any more, mterry changed it and I don't know how to trigger it any more. You'd need to ask him [09:08] or check out the lightdm plugin [09:08] mzanetti: ta. i'll give it a go [09:10] dednick: https://www.mail-archive.com/ubuntu-phone@lists.launchpad.net/msg03515.html [09:11] dednick, yeah, in that branch it'll still be in that file [09:11] dednick, only with the later branches it will be taken from PAM [09:14] hm. doesnt seem to work [09:14] dednick, that's old [09:14] dednick, you need groups there now [09:15] * Saviq tries to find [09:17] dednick, http://pastebin.ubuntu.com/7797565/ [09:17] dednick, same file, ↑ this content [09:17] Saviq: ta [09:23] mzanetti, dednick, btw, the whole thing is in silo 4 already [09:23] ah nice [09:34] Saviq: where is the qml that draws the scopes scope? i.e. the buttons [09:34] greyback, it's generated in cardCreator.js [09:34] greyback, based on what the scope wants its cards to look like [09:34] Saviq: thanks === Guest56494 is now known as Morgawr [10:04] Saviq: we can throw away that one, can we? https://code.launchpad.net/~nicolas-doffay/unity8/filter-selector/+merge/191145 [10:04] mzanetti, probably yeah, guess what, design changed completely... [10:04] oh, did it? [10:05] :P === dandrader is now known as dandrader|afk [10:28] Saviq, didn't see reply from you yesterday - any changes you're aware of for the customizations? [10:31] mhr3, yeah, because you were not here when I tried to reply ;) [10:31] mhr3, nothing changed since it got checked in, no [10:32] mhr3, I want to add page header background today as folks were asking for that the most [10:32] Saviq, they were indeed :) k, so i'll document *all* the fields that are specced in the json doc [10:33] mhr3, ah in that sense... I think we discussed the icon colorization key color, but maybe it's fine to not have it for now [10:39] tsdgeos, is upstart crashing for you frequently still? [10:40] Saviq, with the branches for qmenumodel, unity-notification and unity8 needing manual merges at this point in time, what is required to get them in the "queue"? [10:40] MacSlow, I'll handle that [10:40] MacSlow, you just need to get them to be top-approved ;) [10:41] Saviq: haven't tried running autopilot tests in a while [10:44] Saviq, fwiw upstart has been lately crashing on me when running `restart unity8` on the phone [10:44] Saviq, for the branches of qmenumodel and unity-notifications that is already the case... and I addressed your mentioned issues with unity8... so there I need for yours and jenkins approval :) [10:44] mhr3, yeah, that's the most reproducible thing [10:44] Saviq, although jenkins will only be happy if the branches for qmenumodel and unity-notifications landed first [10:46] MacSlow, yeah yeah, that's fine [10:47] mhr3: have a sec? [10:47] tsdgeos, yep [10:47] mhr3: so think dash overview [10:47] you know there's the "favorite" and "all" sub-views [10:48] in the "all" sub-view i need a way to know which card/index is the current one in the general dash [10:48] Saviq suggested using the scope id and iterating through the model matching against the uri role [10:49] thing is, i can't really iterate the model since it doesn't provide that facility [10:49] so i was thinking how you'd prefer to solve this [10:49] we could specifically for that resultsmodel add a scopeIndex(Scope *) invokable [10:49] or something else [10:49] what's your thought? [10:50] sorry, lied, i'm writing a mail :) [10:51] hmm, let me check the specs again [10:53] mhr3, don't check the specs, we need to be able to match a scope to an index in the scopes scope result models [10:53] by name or Scope * or something [10:54] and why do you need that? [10:54] mhr3: i need to match the zoom out animation with the position the current scope has when pressing done [10:55] i.e. the card "grows" into the dash [10:55] but i need to know which card it is :D [10:56] we could just add a "int ResultModel::indexOf(string uri)" [10:56] that too [10:57] will be O(n) but meh [10:57] well it's a 100 n [10:57] not that anyone cares [10:57] mhr3: and uri in my case would always be scope://scopeId/ ? [10:58] tsdgeos, encoded in some way, yea [10:58] mhr3: well i need to knwo that encoding [10:58] otherwise the function is of no use to me, no? [10:58] tsdgeos, could expose the exact format on the scope object itself [11:00] as in a new read-only property [11:00] mhr3: as in uri() ? [11:00] something like that yea [11:00] in Scope ? [11:00] yep [11:00] mhr3, I was thinking you could give us a ScopesResultsModel that'd have the custom things *just* for the scopes scope === dandrader|afk is now known as dandrader [11:01] Saviq, why so much special casing, can just be on the result model itself [11:01] mhr3: well what you suggesting is kind of special casing too [11:01] otoh maybe we'll need it anyway [11:01] since only Scope will expose uri() [11:01] mhr3, yeah, but now you're starting to talk about the uri format [11:01] so how else would i use int ResultModel::indexOf(string uri ? [11:02] Saviq, tsdgeos, well it's just a prop.. like scope.icon [11:02] sure sure [11:02] i just mean [11:02] you're making it generic [11:02] but it's not really :D [11:02] it's tailored to search a scope in a resultmodel [11:03] because it's the only thing i can know a uri of [11:05] yesterday i was suggesting to avoid talking to the scope completely and just build the result model from the registry metadata, and that will be much simpler with a ScopesResultModel, so let's go with that [11:05] and ScopesCategories :/ [11:07] mhr3, except it won't [11:07] mhr3, because then we start searching [11:08] mhr3, and I really don't want to implement everything from scratch [11:08] Saviq, i'm not saying avoid all the time :) [11:08] mhr3, well, as long as the API you expose our way is the same :P [11:08] or similar enough [11:09] Saviq, i'm starting to think these two things should *really* special [11:09] well [11:09] Saviq, as in [Special]ResultModel* Scopes::getFavouritesModel() and Scopes::getAllModel() [11:09] honestly i'm not fond of changing the api under i built stuff now [11:10] mhr3: i don't see how that solves my current problem [11:10] tsdgeos, can add whatever you want to SpecialResultModel [11:11] tsdgeos, int SpecialResultModel::indexOfScope(Scope*) [11:11] mhr3, yeah, there's just one problem with that... [11:11] hm? [11:11] mhr3, there's multiple (other) categories when searching [11:12] but well, we could switch to CategoriesModel when searching [11:12] mhr3: sure, but you can add that anyway without changing scope api, no? [11:12] Saviq, exactly [11:12] i mean all you need is have a SpecialResultModel internally and add a invokable [11:13] mhr3, but we'd need a ScopeResultsModel there as well [11:13] mhr3, so you'd need to make it special there anyway === pete-woods is now known as pete-woods|lunch [11:13] Saviq, what's that supposed to be? [11:13] mhr3, the ResultsModel that has getScopeIndex() [11:13] or something similar [11:14] you mean for the searches [11:14] mhr3, yes [11:14] mhr3, because you might search for a scope and open it [11:14] mhr3, so we need to treat it exactly the same [11:14] or wait [11:14] no [11:14] I'm stupid [11:14] we only need to map the other way around (when opening the overview) [11:15] or well, no [11:15] I'm not stupid [11:15] we need it when pressing Done, too [11:15] aaaargh ;( [11:15] and there's multiple categories.... and the scope might be in one of them somewhere..... [11:16] crazies [11:17] this entire thing is just... scope but not a scope, kmn [11:34] and we lost stamina :D [11:34] mhr3: Saviq: i really need a solution for this [11:34] otheriwse i'm stuck [11:36] tsdgeos, the indexOf won't even work, cause server will return stuff like "scope://onlinemusic/q=u2" when searching [11:38] not to mention that it can request vertical journal cards or whatever === MacSlow is now known as MacSlow|lunch [11:42] Holas [11:44] facundobatista, fyi, the logo joshua sent isn't good [11:47] mhr3: so what do we do, i don't think this is a non-resoluble problem [11:50] mhr3, ok, will you answer that mail so everybody knows that that image shouldn't be put in production? thanks! [11:54] tsdgeos, for the surfacing it seemed pretty clear, but for searches... i have no idea, we have no control over what server sends back, and the server guys were screaming when we tried to mangle the server results in any way [11:55] does the latest devel-proposed boot up for you guys? [11:58] tsdgeos, but to unblock you - just add a method that takes a scopeId (not the entire uri) and returns an int [11:59] tsdgeos, and in searches you need to call that in each category i guess :/ [12:00] mzanetti, when do you land QtComp branch ? [12:01] om26er: hopefully soon... reviews are in progress [12:01] well I works fine except for the intermediate frame skipping/jittering in Unity [12:01] om26er: we've fixed most of the bugs you guys reported [12:01] om26er: yeah, I've been doing a lot of optimizing on friday and monday [12:01] om26er: Gerry is still looking into optimizing other stuff in there [12:02] mzanetti, does the ppa have the latest stuff ? I can give it a try again. [12:02] om26er: the silo should have fairly recent stuff... But I'm not sure if it currently works... I am currently flashing to find out [12:02] om26er: will let you know in a bit [12:02] mzanetti, ok, thanks. === alan_g is now known as alan_g|lunch [12:08] mzanetti: sorry for the confusion. I just remove the "don't review" line in the description. [12:08] paulliu: no worries. approved it [12:13] mzanetti: ok. Thanks. [12:15] om26er: ok, seems to boot up fine... [12:15] mzanetti, alright. I'll test that now. [12:16] om26er: however, the Dash frame rate didn't really improve yet === _salem is now known as salem_ [12:16] mzanetti, hmm, Gerry is working on that ? [12:16] greyback: what's the status on the invisible scopes stuff? ^ [12:16] om26er: yes he is [12:16] hehe:) [12:17] I'm going for a run... bb in an hour... [12:17] mzanetti: I've pushed some fixes, they help a bit [12:17] hah [12:17] cool, will check out those changes when I'm back [12:17] but not build into silo yet [12:17] I'll wait then. [12:26] MacSlow|lunch, there's still a few comments on https://code.launchpad.net/~unity-team/unity8/fix-1308011/+merge/225354 that you didn't reply [12:29] kgunn: ping [12:30] Saviq: are you able to bump unity-mir to build in mir staging ppa? [12:30] sure [12:30] Saviq: thanks [12:31] dednick, ah mir staging? let's see [12:33] dednick, hmm there's some versioning fuup [12:33] dednick, unity-mir 1.0+ is in the PPA already, while the recipe produces 0.4+ [12:34] Saviq: ok. [12:34] dednick, I'll leave it to kgunn to resolve === MacSlow|lunch is now known as MacSlow [12:35] Saviq, looking... [12:38] Saviq, I'm not sure if lp is playing tricks on me with the inline-commenting system... but my comments are all still marked as "unsaved comment"... only see yours and mzanetti's marked with your names [12:41] MacSlow, you need to click on the green checkmark on the right of the comment box to "commit" those [12:41] seb128, I do [12:41] then you need to post using the "send comment" button next to the usual comment box [12:41] e.g at the top of the changes [12:42] MacSlow, what seb128 says [12:43] seb128, Saviq: folks... there's no "send comment" button anywhere on that page [12:43] MacSlow, "Save comment" [12:44] MacSlow, the inline comments are "part" of the usual comment [12:44] MacSlow, the button you always use to post review comments before having inline ones [12:44] MacSlow, so until you save that, they're only stored in your browser to keep them safe [12:45] MacSlow, before "Unmerged revisions" [12:46] doh [12:47] * MacSlow feels slightly stupid... [12:47] but to a part also regards this as UI-fail [12:47] it is an ui fail yes [12:50] +1 [12:50] there's a few still === dandrader_ is now known as dandrader [12:53] greyback, done with the papi bureaucracy. what can I do now in the qtcomp front? [12:54] dandrader: it qtubuntu ok? [12:54] is [12:54] greyback, yes. I updated it accordingly [12:54] should probably trigger new builds for the ppa [12:54] dandrader: ok cool [12:56] mzanetti any idea why is it listing 2 platform-api packages? https://code.launchpad.net/~unity-team/+archive/ubuntu/phone-right-edge/+packages [12:58] dandrader, one's still building [12:59] dandrader, the new one is pending, the old one still published, will change to published/superseded, accordingly [13:00] hmm [13:05] mhr3: ok, i add that as an invokable in the class that implements scopsoverviewresults, not in the resultmodel in general, right? === alan_g|lunch is now known as alan_g [13:05] greyback, unity's scrolling performance gets an impact when the Scopes Scope is loaded. After that scrolling in Apps scope is also slowed down. [13:06] om26er: correct [13:07] om26er: I've a fix to improve that, but it's still not perfect. [13:19] tsdgeos, meh, does it really matter? [13:19] mhr3: well how do you justify [13:19] Q_INVOKABLE int scopeId(QString const& id) const; [13:19] in ResultsModelInterface ? [13:20] tsdgeos, you're adding proper ScopesResultsModel to unity-api? [13:20] no [13:21] tsdgeos, so.. it doesn't matter :) [13:21] bug 1342103 [13:21] i'm confused [13:21] bug 1342103 in Unity 8 "[QtComp] Camera doesn't often work" [Undecided,New] https://launchpad.net/bugs/1342103 [13:21] but ok [13:21] mzanetti, that ^ === pete-woods|lunch is now known as pete-woods [13:24] om26er: is the camera app still responding? [13:25] greyback, yes. [13:25] re [13:25] greyback: right... I remember [13:25] I saw that too [13:25] but wasn't sure if its qtcomp or just camera breakage [13:26] dandrader: could you check that out please: https://launchpad.net/bugs/1342103 [13:26] Ubuntu bug 1342103 in Unity 8 "[QtComp] Camera doesn't often work" [Undecided,New] [13:27] dandrader: it might have to do with the fact we are not telling apps when they're focused/unfocused [13:28] right now, the camera just doesn't work at all for me [13:28] greyback, what do you mean by "we are not telling apps when they're focused/unfocused"? [13:28] greyback, irrc we do [13:29] dandrader: if shell unfocuses an app, does the app get notified it is unfocused? I'm not sure we do, at least I didn't see the code where we do that [13:29] do check please, I could be wrong [13:29] greyback, it does [13:29] ok, then that idea out the window [13:29] greyback, or at least it should. I recall I wrote code for that [13:29] greyback, called "window activated" in qt terms [13:30] MacSlow, still one more inline comment unanswered (you need to click on the "Show diff comments" link in my last comment, or make sure you're looking at "r1003 into r1044" diff) [13:31] Saviq, the sound-hint undefined issue?! [13:31] MacSlow, yes [13:31] Saviq, I'm on that [13:32] MacSlow, oh ok [13:39] Saviq, fix committed [13:42] MacSlow, thanks [13:47] greyback, this looks good as diff between qtubuntu-gles before/after qtcomp http://paste.ubuntu.com/7798535/ ? [14:02] mhr3: can i assume that scopes in the scope overview categories "all" and "favorite" will have the same uri role if and only if they are the same scope? [14:02] tsdgeos, I don't think you can assume that ever, they will have the same hostname part of the uri, but not the whole [14:03] ok [14:03] then i need a way to know if a scope from All is a favorite or not [14:04] suggestions? [14:04] mhr3: Saviq: ↑ [14:05] you and your needs ;P [14:05] tsdgeos, bad idea: allCategory.indexOf(scope) >= 0 [14:05] tsdgeos, but other than having a list of favourites somewhere else... [14:06] Saviq: but i don't have scope [14:06] that's the nice part about cards [14:06] i have no clue of what thye are :D [14:06] tsdgeos, well you have uri, extract the scope name from it [14:06] tsdgeos, it's scope://scope-name/blah [14:06] tsdgeos, i was thinking about manually adding a role to the special model [14:07] role that will hold the scopeId itself [14:07] mhr3: that i like more [14:07] if i have the scopeId i can do lots of stuff [14:08] Saviq: kinda, it builds the QML plugin again for all arches [14:08] Saviq: oh sory, that's qtubuntu you've worked on [14:09] tsdgeos, it almost feels like this entire thing won't be a major hack... but only almost :P [14:09] :D [14:10] mhr3: ok, i'll add the role [14:10] Saviq: you are not setting the arch for the qtubuntu-android to be i386/amd64 [14:13] nice i can do [14:13] case RoleBackground + 1: [14:13] never thought about it :D === dandrader is now known as dandrader|afk [14:15] greyback, that's not between non-gles and -gles [14:15] greyback, that's diff between -gles < 0.60 and >= 0.60 [14:16] * mzanetti likes what Olga just did to our bug tracker [14:16] Saviq: oh sorry [14:16] +1 [14:16] mzanetti: eh? What changed? [14:17] Saviq: +1 for me [14:17] greyback, yup, both -gles are building now [14:17] Saviq: magic, thank you [14:17] oups, qtubuntu-gles failed :| [14:17] greyback: bug tracker? she's closing all those super old bugs we couldn't close ourselves because we'd need design input [14:18] mzanetti: ahhh :) === dandrader|afk is now known as dandrader === gatox is now known as gatox_lunch [14:40] dednick, updated unclear stand-up notes... does my mic mess up again? [14:40] MacSlow: you were just talking a bit fast :) [14:40] dednick, ups... sorry :) [14:41] dednick, I'm not that ill anymore :) [14:41] MacSlow: no prob. just a bit hard to understand without knowing context. [14:41] dednick, sure... the usual trouble for every stand-up note-taker [14:43] mterry: so..... today we've put together some TODO list and took the freedom to put you name on it :D [14:44] mterry: can you help us out with this? https://docs.google.com/a/canonical.com/document/d/163nyfh_G90nzQnRdI7IYgrMH_0VdmesBju5jpb4wse0/edit# [14:45] k [14:45] mzanetti, I see I'm on packaging changes. For lp:~unity-team/unity8/mirCompositor I presume [14:45] mterry: yeah, and the QtUbuntu one [14:46] mterry: and not sure if you're supposed to help with the main inclusion request too... [14:46] mterry: long story short, we need to get all that stuff landed and would require your help in fixing up the packaging [14:46]