[00:05] huwshimi so besides the var things code review ok? [00:06] hatch: I don't really know. I mean there's code there, it does some stuff. I'm not sure I know enough to be reviewing branches like this. [00:07] ahh ok [00:08] huwshimi can you respond with QA OK and then I'll land it, if there are some code issues that others don't like we can fix them in a follow-up [00:09] I just don't want to get held up as there are more changes to be made in this section [00:12] hatch: Left a note [00:12] lol, nice passive agressive comment [00:12] if you would like you could fire an email off to design :) [00:14] hatch: I'm not sure about landing this without a proper code review though. I can't see if Kyle did one either [00:15] huwshimi: hatch what do you need? [00:15] hatch: I can do one in the morning before you start if required [00:15] huwshimi ok that's fine if you're not comfortable [00:15] no calls until 10 yay! [00:16] rick_h__ that would be awesome thanks [00:16] hatch: ok, I've got it on my morning todo. [00:16] too shut down to look right now sorry [00:16] thanks for looking huw [00:17] np it's well past EOD :) [00:17] rick_h__ https://github.com/juju/juju-gui/pull/437 then https://github.com/juju/juju-gui/pull/439 is branched from it [00:17] hatch: rgr [00:18] and now I'm also done :) [00:18] night hatch [00:18] night rick_h__ huwshimi [00:18] go find your watch :P [00:18] lol [00:18] right! === uru is now known as urulama [08:00] urulama: morning! [08:11] rogpeppe: morning [08:11] urulama: how're you feeling today? [08:12] rogpeppe: better, at least i feel hungry now :D [08:12] urulama: always a good sign... [08:12] urulama: do you fancy pairing on moving the charm store apiHandler stuff forward? [08:13] sure. give me 10min to grab something to eat [08:13] urulama: np [08:42] rogpeppe: sorry, that breakfast didn't land well :S [08:43] urulama: oh dear :-\ [08:43] rogpeppe: yeah, fats to soon ... nevermind, it'll pass ... [08:43] rogpeppe: gogogo? [08:43] urulama: if you'd prefer to go back to bed, or not interact much, that's fine [08:43] urulama: yup, i'm there [10:44] * urulama lunches [11:27] morning all [11:27] rogpeppe: have you followed the license thread? [11:27] rick_h__: i have [11:27] rick_h__: (g'morning, BTW) [11:27] rogpeppe: can you please make sure all our repos, charmstore, charm, etc are ok on that front please? [11:28] rogpeppe: it looked like the agreement was lgpl with exception? [11:28] for outside libs [11:28] rick_h__: yes [11:28] rick_h__: charmstore is fine [11:28] rick_h__: charm should probably be LGPL but is currently AGPL [11:29] ah, since it was pulled from core which is agpl? [11:30] rick_h__: yes [11:30] rick_h__: but it could easily be changed to LGPL [11:30] ok [11:30] rick_h__: (with a possible caveat of whether LGPL is compatible with the apache 2 license) [12:03] moving to the coffee shop, biab [12:06] hola [12:20] morning bac [12:22] how was swim lessons? i remember enjoying them until they tried to make us go off the high dive. didn't go back. [12:23] heh, due to scheduling fun we had to go private lessons this round and the boy is loving the personal attention [12:24] show off "I can swim under water" and he just throws himself into the lake [12:24] then comes up with half the lake being swallowed [12:24] but it's fun, hard to not get eager for him to do real swimming so we can trust him to be more indenpendent at water parks/etc [12:26] i need to change place, "feels" too crowdy at home today :D [12:27] urulama: yea, coffee shops ftw [12:28] rick_h__: i actually have access to place with net and everything on the other side of town, near woods and more important, no kids singing and dancing around :D [12:29] urulama: sounds like a winner [13:01] morning. [13:01] morning jrwren [13:53] hatch: sorry, I'm behind on your reviews. Been a busy morning [13:53] hatch: looking now and will try to get done asap [13:53] np thx [14:12] hatch: one round of comments in [14:13] thx will check [14:13] hatch: going to wait on the second one until the diff is one vs both [14:15] ok I'm going to have to fix the markup to enable enter submissions as it uses multiple form elements [14:15] atm you can submit the constraints form, the unit count form, etc which doesn't make any sense [14:16] hatch: ah, yea that's ungood. To the user it's all the same form [14:17] I'm guessing huw did that on purpose so I wonder what surprises await me in doing that [14:17] * rick_h__ heads back home, coffee shop is getting crowded. [14:17] hatch: heh, well that's fine to do it as a follow up [14:17] hatch: but your current branch can land without the block [14:17] without the block? [14:17] hatch: but take a stab at it, if you end up in css hell, create a card and punt it [14:18] without the block on the enter key [14:18] saying "if you use the enter key it doesn't work predictably" is a follow on bug/card [14:18] well not really - they can submit the constraints form [14:18] so it falls apart if they hit enter on that [14:18] I'll take a stab, see where it ends up [14:32] hi abentley [14:32] bac: otp [14:33] abentley: ok, please ping me when you have a few minutes free [14:55] jujugui call in 5 [14:58] jujugui call in 1 and go [14:59] or now ish [14:59] jujugui: hmm, i'm getting "Couldn't start the video call because of an error" [14:59] rick_h__: same here [14:59] rogpeppe: urulama another browser? [15:00] kadams54: ^ [15:00] i'll try incognito [15:00] bac: ^ [15:01] trying [15:03] that didn't work [15:03] me neither [15:03] unfortunately i don't have another browser installed currently [15:03] tried firefox and chrome [15:03] (and safari /me runs away) [15:04] urulama: our previous session seems to have tainted both of us... [15:04] i get the "due to the number of participants ..." error [15:04] i don't get that [15:04] it lets me in (apparently) and then gives me the error [15:05] jujugui: sorry guys [15:05] yes, same here ... see who is there but not able to join :( [15:06] sounds like it hates EU folks :/ [15:06] everyone else is here [15:06] rick_h__: for the record, the "store: start version api responses" card is making good progress. urulama and i should have something to show very soon [15:07] urulama: can you still join gogogo? [15:07] rogpeppe: yes [15:07] rogpeppe: no [15:07] :S [15:07] urulama: i thought it was working for me too... [15:07] urulama: and then not [15:07] urulama: bugger [15:08] rogpeppe: maybe google blocked us due to the usage today :D :D [15:08] urulama: hmm [15:09] rogpeppe: let's give it 10min and retry [15:09] urulama: yeah [15:11] rogpeppe: urulama k, reported. Nothing big from the team. I've got a vet appt and will be afk some this afternoon, but that's post your EOD so no worried on your end [15:12] rick_h__: re the tagging notion--are we going to be on the hook to do that as proper tagging? e.g. a charm can have multiple tags, and a search should be able to do multiple tags? [15:12] In go, I know we follow gofmt. do we have style guidelines beyond that? e.g. prefer multiline string to string with embedded \n after a certain number of newlines? [15:13] jrwren: in python, flake8 is your style bible. [15:13] yes, I flake8 in python. [15:13] that's about it, afaik. [15:13] ok. [15:13] and for js in the gui, i have no idea what our style rules are--i just fix what the linter screams at me about. :P [15:14] seems to be working so far. :P [15:15] jrwren: there's a pull request in juju core for style guide [15:15] jrwren: take a peek and see if you can find it in current or recently closed pull requests in /juju/juju [15:15] jcsackett: it'll be just like categories now, a list of string. And yes, we'll index those and allow searching on that filter [15:15] rick_h__: cool. [15:15] rick_h__: ok, good luck at the vet, maybe see you later [15:16] urulama: sure thing, I think we should chat in a bit. just cathing up [15:16] rick_h__: ok, ping when you come back, otherwise, first thing in the morning? [15:17] urulama: yep [15:18] jrwren: https://github.com/juju/juju/tree/master/doc/contribution [15:18] thanks rick_h__ [15:19] np, it's a WIP but something we should get familiar with and support across projects. rogpeppe urulama ^ as well [15:19] bac: Makyo ^ [15:19] rick_h__: checking [15:20] jrwren: also, this is well worth reading: https://code.google.com/p/go-wiki/wiki/CodeReviewComments [15:21] jrwren: and in general, the go stdlib is very well written and idomatically designed - if it does something a particular way, it's usually a good way to do it [15:22] Great to know. [15:22] jrwren: there's also this: https://github.com/golang/lint [15:23] * urulama brb [15:23] oooh, golint, lots of messages. I like it. [15:24] rick_h__: got a sec? http://162.213.35.28:8080/job/charmworld-autoland/165/console -- search for "Selec+" ... it seems the console output abruptly halted, not capturing the actual problem [15:24] not a one off [15:24] bac: looking [15:26] bac: hmm, yea. It was still installing deps and then failed. Mabye a netork issue? [15:27] perhaps. i'll look to see if it failed at the same point previously [15:27] network, the jenkins-launchpad-plugin? Maybe a missing dep? [15:27] from the download cache? [15:27] bac: I'd look at a normal fresh run and see what package it's grabbing after the python-lazr and see if something is up with fetching it? [15:27] ok [15:31] rogpeppe: still no gogogog :( [15:31] urulama: rogpeppe I'm going to setup a call for the morning. Hopefully the hangouts issues work out by then [15:31] rick_h__: ok [15:31] rick_h__ moving that form stuff is causing issues, I'll land my two branches then do it as a follow-up right away, will be muuuch easier when I don't have to worry about conflicts from my next branch [15:31] urulama: yeah, i'm still having the same problems [15:31] hatch: rgr [15:33] urulama: this is what splitId is looking like now, BTW: http://paste.ubuntu.com/7803979/ [15:34] rogpeppe: ok, this is muuuch better then the clutter before :D [15:35] rogpeppe: but we do "parse" it twice, right (with the Charm.parse) call? [15:36] urulama: sure. but the first parsing is very lightweight. i doubt it'll take more than a small number of ns [15:37] rick_h__ ok while these things land I'm just going to pick off another bug card from the pile [15:38] hatch: rgr [15:39] * rick_h__ goes to get some lunch [15:39] rogpeppe: yes, i was just thinking in a way, that this splitId could be part of Charm, so that it is always in sync to all [15:39] urulama: that's a good idea [15:40] urulama: i guess you'd probably want to make the knownSeries an argument to it then [15:41] rogpeppe: that part i don't like :D (but have no alternative atm) [15:41] (as agreed before) [15:41] urulama: yeah, i'm not keen either. i'm tempted to just leave this logic in the charm store for the time being, as we don't really want other people doing the same thing [15:41] rogpeppe: +1 [15:42] urulama: after all, we do double-check that the final URL parses ok [15:42] urulama: so if charm urls change, then our tests will break immediately [15:56] rogpeppe: https://github.com/juju/charm/pull/19 look good? [15:57] jrwren: LGTM [15:57] ty. [15:57] now I can bug rick_h__ for moar! :) [15:58] ruh roh [15:58] * rick_h__ pulls up the board of work item doom [16:00] jrwren: side task, can you git pull origin develop from the ci slave machine in the /var/lib/jenkins/jenkins-github-lander directory? [16:01] oh, to get changes there? sure. [16:01] jrwren: yea, catch it up to latest src [16:09] I can't status the ci-environment :( http://pastebin.ubuntu.com/7804136/ [16:10] jrwren: there's been a bug going around on that, /me looks [16:11] jrwren: https://bugs.launchpad.net/juju-core/+bug/1307434 [16:11] <_mup_> Bug #1307434: talking to mongo can fail with "TCP i/o timeout"

[16:11] restarting the state server seems to have helped? [16:12] jrwren: marked as in progress [16:12] jrwren: did you get access to azure? [16:12] jrwren: or need me to do the bouncing? [16:12] i don't have access to the web portal. I could probably use azure cmdline tools to do it. [16:12] that might be a good exercise for me :) [16:14] jrwren: will reboot it here, one sec [16:16] jrwren: give it a shot? [16:17] thanks. [16:19] thanks to all the hard work jcsackett put into the changes in rendering the inspector my current branch is super trivial to implement :) yay jcsackett [16:19] woot yay jcsackett :) [16:20] rick_h__: just trusty-slave or other slaves too? [16:20] jrwren: I can't recall which I updated, please check all three [16:20] jenkins machines [16:22] rick_h__ hey I just wanted to point this bug out that my branch will create - I'm not sure what priority you want to put it at https://bugs.launchpad.net/juju-gui/+bug/1342809 [16:22] <_mup_> Bug #1342809: Inspector tabs should route the url [16:23] hatch: they can't route because it's too hard to figure out inspector tab vs details/browser tabs [16:23] hatch: and we've prioritized the charm details over inspector tabs [16:24] I'm not sure I understand, I don't see why they both can't work? [16:25] http://192.168.33.10:8888/inspector/wordpress/charm/tab/relations/:flags:/mv/ seems to work just fine [16:27] oh I see a bug in it... showTab() closes the breakout [16:27] so you can't have a tab navigate and the breakout visible [16:28] I'm pretty sure that's the viewlet slot issue and not a routing issue though [16:30] rick_h__: the jenkins issues was due to it running out of disk while doing an install inside the lxc, so the error message got swallowed. cleaned up some old lxc directories and trying again. [16:30] s/issues/issue/ [16:30] bac: ah! [16:31] hatch: looking, sorry. in my head tabs in the inspector would be just like the browser as #tabname [16:31] and so we have two namespaces living in the one propery [16:32] hatch: but it looks like I'm mistaken and the inspector tab is part of the root url? [16:32] it is now :) [16:32] hatch: hangout? [16:32] sure [16:32] trying to join the standup one [16:49] rick_h__ does your watch disconnect from the phone a lot? This one dc's like every hour then you have to turn the phone on and hit the button to reconnect [16:50] hatch: no, it's been really good [16:50] hatch: does your phone do BT LE, 4.0 I think? [16:50] yep, running the latest android and everything - all power saving options turned off [16:50] I can't even find anyone complaining online so this might be an isolated incident [17:02] rick_h__ https://github.com/juju/juju-gui/pull/439 is ready for review - sidenote: I had to pull it down and rebase develop into it to remove the old commits, I kind of assumed the Pr would do that automatically [17:04] hatch: rgr, loading [17:07] jujugui night all [17:07] urulama: have a good evening [17:15] hatch: can I ask you about non machine view uses? [17:15] pourquoi? [17:15] qa without :flags:/mv [17:16] oh... [17:16] hmm [17:16] it seems to be wanting a bit now [17:16] heh [17:16] ok I guess my removal branch can't land? [17:16] not at this time. [17:17] hmm [17:17] it can make sure you only get the new UX in MV, but without the flag is still important for 3wks [17:17] well, 2 we'll call it [17:18] hmm ok I think I can use those new flag css classes to hide it with mv [17:18] I'll leave this branch for reference, close the PR, and create a new one to hide the old stuff under mv [17:18] hatch: k, so I this branch will be a bit diff to land [17:18] hatch: ok, sounds good thanks [17:18] sorry for the blockage there :/ [17:19] s'ok there will be some conflicts in the future but the majority of the code will still be usable so definitely want to keep it around [17:19] k [17:20] jujugui, just a reminder to QA both with and without the feature flag. [17:30] rick_h__ can you comment about the non mv stuff on #439 PR? [17:43] jujugui looking for a quick review/qa on https://github.com/juju/juju-gui/pull/440 [17:43] hatch: checking [17:43] th [17:43] x [17:44] welcom [17:44] e [17:47] : [17:47] P [17:53] LOL airbnb's new logo [17:53] clearly they didn't run that one past the internet lewd machine first [17:58] arosales hey did you see the ghost charm is now promulgated? [18:29] jujugui looking for a review/qa on https://github.com/juju/juju-gui/pull/441 [18:29] really trivial css change [18:30] kadams54 did you get lost on #440? The diff isn't that big ;) [18:33] hatch: sorry, had an important phone call come in. [18:34] those are the worst - getting in the way of the daily activities [18:35] hatch: all done with review and QA. [18:35] thanks! Can I sucker you into doing #441 too? [18:35] it's really really small :) [18:35] To make up for it, I'll check out your trivial CSS change. [18:35] Hah! [18:35] Great minds. [18:35] lol [18:40] Trivial thing I just noticed: we don't have proper pluralization in the new scale up UI or in the unit list below… "1 units" and "1 running units". [18:40] Not in the scope of your work though [18:41] it's a simple helper, add it real quick :P [18:41] OK, #441 is ready to ship [18:41] we're getting bad about not catching drive by stuff with that plural stuff. It's getting wrong all over [18:45] kadams54 thanks, I'll add that pluralization in the follow-up [18:52] http://blog.atom.io/2014/07/02/moving-atom-to-react.html [18:52] kadams54: how goes your branch? [18:53] it says they are using jquery...I really have no idea what for when they control the environment it operates in [18:54] kadams54: I'm heading to the vet, but I'd like to get another set of eyes on your WIP to help move the card of work through. hatch or Makyo can one of you take a peek and see how you can help please? [18:54] sure [18:54] kadams54 what's he talking about? [18:54] ;) [18:55] * rick_h__ goes to get the dog poked [19:01] yay, my favorite test case now works: https://jujucharms.com/?text=ouch [19:04] kadams54: are you leaving friday morning from london? [19:07] jcsackett I am [19:07] well...friday noon i think [19:08] iunno it's in the spreadsheet heh [19:08] hatch: i'm pinging kadams54 b/c i think he is on the same flight as me, and mine got modified--i'm leaving the 26th, but the sheet says the 25th. i would imagine kyle is in the same boat, unless he really is leaving friday AM. [19:08] ohhh [19:09] yeah, i just emailed sarah to sort it, but kadams54 might need to do the same. [19:10] jcsackett: Uh oh, yeah, that wouldn't be good [19:10] kadams54: you're in the same boat, then? [19:10] jcsackett: I haven't seen any e-mails about changes yet. [19:10] kadams54: are you leaving sat or fri? [19:10] Last I knew, Friday [19:11] kadams54: ok, so you're fine. that's what it says for you. we're both DL-19, just on different days. [19:11] DL0019, leaving at 9:35 AM [19:12] cool, figured there was a chance we were both on the same flight, rather than just flight num, and yours had been goofed too. [19:12] hatch, Makyo: I'll have a PR shortly for you to look at on that branch. [19:12] but it's just the same flight, so i'm the only one goofed. :P [19:12] er, flight no. anyway. [19:20] jcsackett: I'll try not to trash the plane too much on my flight then :-) [19:20] kadams54: i would appreciate that. :p [19:44] guihelp: is there a reason /:flags:/mv/ is 404ing for me on comingsoon? [19:45] bac ^ comingsoon isn't dispatching paths to the guiserver [19:46] kadams54 ^ the app is supposed to be handling the urls but the server isn't passing them through [19:48] hatch: ungood [19:48] that's your fault right? [19:48] :) [19:48] hatch: yes, it was my mid-afternoon time bomb [19:48] lol [19:48] bac is it something you can take a look at or should someone else? [19:50] hatch: i'm looking. [19:51] thank yas! [19:54] hatch: [client 198.69.45.233] File does not exist: /var/www/juju-gui/build-prod/:flags: [19:54] bac right, but why is it now thinking that that's a file? [19:55] http://comingsoon.jujucharms.com/machine also fails for example [19:55] so apache is attempting to [19:55] bac it should be passing anything that's not in the juju-ui path to the GUI [19:55] serve it instead of having the app do it [19:55] yeah...did someone break the charm? [19:55] charm or apache config? [19:56] doesn't the charm contain the apache config? [19:56] heh [19:56] not charm. this isn't installed via charm [19:56] ohhh [19:56] it were hand-rolled by me [19:56] I thought this was the charm which was just updated every time [19:56] has anyone tried :flags: in the last week or so? [19:57] I thought I used it yesterday tbh [19:57] maybe it was monday? [19:57] this config hasn't changed since the 10th [19:59] hmm, well then... [19:59] maybe I didn't use a flag or direct url [19:59] sorry I can't be of more help [19:59] I could look at the config though if you want [20:02] hatch: http://bazaar.launchpad.net/~juju-gui-charmers/charms/trusty/juju-gui/trunk/view/head:/config/apache-site.template [20:02] that's what the charm does [20:03] i didn't think to copy the charm and just manually created an apache config from the nginx config we used on the old site [20:03] hatch: FallbackResource looks interesting [20:03] I was just going to say that might be the trick, I was just looking it up heh [20:04] yep that does look like what we need [20:04] wow it's been a long time since I've had to read an apache config [20:04] ha [20:04] brings me back to the good ol days of multiple client PHP work on the same server [20:04] oy [20:05] "directive all the things!" [20:11] thanks hatch. kadams54 http://comingsoon.jujucharms.com/:flags:/mv/ works [20:11] bac: thanks [20:11] bac thanks for doing that so quick! u rock [20:11] np [20:25] Makyo, hatch: WIP PR at https://github.com/juju/juju-gui/pull/442 [20:25] Looking [20:26] Makyo, hatch: I also ran into something that may have invalidated work today. Need to talk to someone about the supportedContainers attribute on machines. [20:29] oh? [20:29] what's the issue? [20:34] and the dog has a high temp right before I leave for a trip. Go pets! [20:36] poor puppy [20:37] hatch: got a few minutes to chat? [20:37] sure 1min just got to relocate to somewhere cooler [20:38] You're in Canada already. [20:38] it's like 20c out there...way to hot ;) ( rick_h__ ) [20:39] kadams54 ok joining the standup room [20:44] today, bundles don't have ability to run services on existing machine, does it? [20:44] I know this is coming as part of charm store api [20:46] jrwren correct [20:46] bundles are just a yaml file [20:46] actually [20:46] that's a deployer file [20:46] :) [20:46] go conflated terminology! [20:46] a yaml file with no to: machine node :) [20:49] oh THAT juju-deployer! [20:49] thanks hatch [20:49] kadams54 your branch will conflict with Makyo's that just landed [20:50] hatch: Got it. [20:50] jrwren lol np, don't worry it's confusing to people who have been working with it for a long time :) [20:50] the deployer will be moving into juju-core at some point [20:52] jujugui: can someone review https://github.com/juju/juju-gui/pull/443 for me? [20:52] yup [20:52] I can [20:53] thanks hatch. [20:53]