veebers | thomi: Can you review my latest changes to the screenshot MP for the Gdk importing please? https://code.launchpad.net/~veebers/autopilot/adding_screenshots_to_details/+merge/225423 | 02:15 |
---|---|---|
thomi | sure | 02:16 |
thomi | veebers: diff line 24 needs more info I think | 02:17 |
veebers | thomi: i.e. details for why the order matters etc. ? | 02:17 |
thomi | veebers: yes, ideally with a bug report | 02:17 |
thomi | veebers: also, if you specify 'version' to one of the import functions, but they've already been imported, what happens? | 02:18 |
veebers | thomi: hmm, that's a very good point. I think I'll remove the version stuff | 02:18 |
veebers | that was there to solve a previous version, so I think just having 3.0 there is fine | 02:19 |
thomi | veebers: other than that, it looks good to me | 02:21 |
veebers | thomi: coolio thanks. I'm just filing the bug then will update docstring | 02:22 |
veebers | thomi: what's the best way to file a bug when I know the package name? a search in launchpad for 'gir1.2-gtk-3.0' gives me binary package pages | 02:23 |
thomi | ubuntu-bug? | 02:23 |
veebers | oh yeah, forgot about that. I poked around and found "https://launchpad.net/ubuntu/+source/gtk+3.0", I'll give ubuntu-bug a whirl though | 02:24 |
veebers | thomi: fyi have pushed the fix | 02:37 |
thomi | veebers: done | 02:39 |
veebers | thomi: awesome, thanks | 02:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!