=== wgrant_ is now known as wgrant === wallyworld__ is now known as wallyworld === wallyworld__ is now known as wallyworld === CyberJacob|Away is now known as CyberJacob === CyberJacob is now known as CyberJacob|Away [10:57] allenap: I'm creating a small utility to send an event and create the event type if it doesn't exist. How will that function (which will be called from the power-{on, off} tasks) get hold of the rpc_service object? [10:57] rvba: That’s a good question :) [10:58] rvba: I think we need to create a singleton to refer to all the services (or the application). I have some work towards that lying around... [10:58] allenap: yeah, I was thinking about a singleton too. [10:59] I'll make the utility take a rpc_service argument for now. [10:59] We can figure out how to pass it around later. [10:59] rvba: Yeah, that sounds good. [10:59] Cool. Ta. === roadmr is now known as roadmr_afk === roadmr_afk is now known as roadmr === jfarschman is now known as MilesDenver [13:58] blake_r: reviewing your add-boot-type-to-node branch now. [13:59] rvba: oh, cool. thanks [14:37] allenap: how can I easily unit test a method that uses other methods from the RPC region service? Since I can't call call_responder directly… is there a better option or will I have to patch all the RPC methods? [14:50] rvba: See ClusterRPCFixture (er, which may not yet have landed). That wires up RPC calls to the cluster without needing sockets and whatnot. [14:53] allenap: right, not landed yet… === sebas538_ is now known as sebas5384 [15:58] rvba: Got time for a very quick review before you finish for the weekend? https://code.launchpad.net/~allenap/maas/rpc-cluster-client-service-ipv4-only/+merge/227358 [15:59] Just think, what a great way to finish a Friday. [16:03] allenap: i can do it [16:03] allenap: nice! [16:03] blake_r: What a wise man you are :) Thanks. [16:07] allenap: thanks for the review! Now, I need a review for https://code.launchpad.net/~rvb/maas/event-rpc-methods/+merge/227215 and https://code.launchpad.net/~rvb/maas/event-model/+merge/227156 and I'll be able to land this thing! [16:08] rvba: Looking at that now. [16:08] allenap: Thanks! [17:08] blake_r: Do you mind taking another look at https://code.launchpad.net/~allenap/maas/rpc-cluster-client-service-ipv4-only/+merge/227358? [17:08] allenap: looking at it now [17:08] Ta. [17:16] done [17:22] blake_r: Thanks. Have a tip top weekend. [17:22] allenap: you to! === roadmr is now known as roadmr_afk === CyberJacob|Away is now known as CyberJacob === roadmr_afk is now known as roadmr === alexpilotti_ is now known as alexpilotti === CyberJacob is now known as CyberJacob|Away