| veebers | elopio: ping, hey you available to do a MP review for me? | 00:03 |
|---|---|---|
| elopio | veebers: I am. Give me the link please. | 00:05 |
| === thomi_ is now known as thomi | ||
| veebers | elopio: awesome, https://code.launchpad.net/~veebers/autopilot-qt/enable-datamodel-elements-add-new-nodes/+merge/224061 | 00:09 |
| veebers | elopio: will you be around much longer? I was about to get lunch but can hold off if you want me around to query etc. | 00:11 |
| elopio | I'm going to have dinner soon but then I'll be back. | 00:12 |
| elopio | I can leave you comments on the MP and we can chat after eating. | 00:12 |
| elopio | veebers: one big details is that I have no idea what I'm reviewing here. | 00:13 |
| elopio | I've never seen autopilot-qt code before. | 00:13 |
| thomi | elopio: there's a first time for everything :) | 00:13 |
| veebers | elopio: ah right, well we can hangout quickly if you want and can give you a quick overview | 00:14 |
| veebers | elopio: thomi has (and I'll get a re-review too) reviewed so between the 2 of you it should get good coverage for AP related things as well as general code quality | 00:15 |
| elopio | veebers: I'll just read it and get some context first. | 00:15 |
| veebers | elopio: sweet, I'll head out for lunch. Thanks again :-) | 00:15 |
| elopio | veebers: I'm going out for dinner. I'll continue with the branch when I'm back. | 00:38 |
| === rvr is now known as rvrOff | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!